[Alexandria-list] What is supposed to be the contents of a yaml file in Alexandria

[Timothy Malone]

You're right, I think I did mean book.dup, must have not occurred to me
that it was just a reference at the time. You're also right that it
isn't used by the main app, as far as I could tell with a quick grep of
trunk, though it is probably a good idea to preserve the reference in
case it's needed later, or if Reading-List uses library.rb to write to
files (I don't think it writes anything to book files yet).

Tim

On Sat, 2008-02-23 at 23:00 +0000, Cathal Mc Ginley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Sat, 23 Feb 2008 17:37:03 -0500
> "Tim Malone" <timothy.malone at gmail.com> wrote:
> 
> > oops, I had sent an email in response to this and forgot to cc the
> > list. Anyway, the problem was something I had fixed a little while ago
> > after noticing that my yaml files were getting quite large. The
> > problem was the pointer to the Library was getting written to each
> > file. It doesn't seem to cause any dire consequences (files load
> > properly and I've seen no instances of duplicate books getting
> > loaded). However, with the patch I committed (before 0.6.3), simply
> > opening a book's properties and then hitting the save button fixes the
> > file. Lennart replied to my offlist email and confirmed that this was
> > the problem and that re-saving the file fixed it.
> 
> Glad to hear it causes no long-term problems. And that the issue is not
> actually present in a formal release.
> 
> > It would be interesting to know if the Library link was in any release
> > versions of Alexandria. If so we might want to include a check for
> > affected files when loading a library just in case a problem shows up
> > with them later on.
> 
> It was only ever in subversion between 0.6.2 and 0.6.3, there were no
> interim releases. However, I did notice one thing and forgot to bring
> it up (a cardinal error, I didn't write it down). In order to set the
> library to nil, you have the following lines in library.rb (434 & 435)
>       temp_book=book
>       temp_book.library=nil
> And then you write out temp_book. That first line there only copies the
> *reference*, you probably wanted temp_book=book.dup to copy the object.
> I don't know what effect setting a book's library to nil will have in
> the grander scheme of things. In reality, I think book.library is only
> used by the ReadingList application.
> 
>    -   C.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.2.2 (GNU/Linux)
> Comment: GnuPT 2.6.2.1 by EQUIPMENTE.DE
> 
> iD8DBQFHwKV9fMAUnRdb+8oRAhA+AJ9zT7ihFoxtCtkdozZhcmxTXtG3yQCgqnlU
> yFJS9Tpv5QskMPayLubIwz8=
> =qq6R
> -----END PGP SIGNATURE-----