From estebanm at opera.com  Tue Feb 19 11:45:12 2008
From: estebanm at opera.com (=?utf-8?Q?Esteban_Manchado_Vel=C3=A1zquez?=)
Date: Tue, 19 Feb 2008 17:45:12 +0100
Subject: [Cruisecontrolrb-developers] Test result collectors patch
Message-ID: <op.t6r55mqyqcqbbv@estebanm-desktop>

Hi,

    I'm sorry I haven't sent the patch earlier, I was busy and had some  
"problems" (delays) getting to the legal department to make sure I could  
"sign" that paper for the patch.

    So, I'm sending that "paper" below, and I also want to start discussing  
how the patch will end up. I have filed a bug already with my current  
patch (see http://jira.public.thoughtworks.org/browse/CCRB-172), but I  
know that you don't like that I'm reading the project configuration on  
initialisation. In particular, I mean this part of the patch:


--- app/models/projects.rb      (revision 600)
+++ app/models/projects.rb      (working copy)
@@ -15,7 +15,8 @@
      end

      def load_project(dir)
-      project = Project.read(dir, load_config = false)
+      # project = Project.read(dir, load_config = false)
+      project = Project.read(dir, load_config = true)
        project.path = dir
        project
      end


I'm not sure what's the best solution. One idea I have is:

    * Modify Projects.find and Projects.load_project so they receive an  
optional parameter, specifying if the configuration should be loaded or  
not.
    * Modify BuildsController#show to call Projects.find with that  
parameter, stating that the configuration should be loaded.

Is that better? The problem is, I'm not sure *why* you don't want to just  
always load the project configuration, that's why I ask. Do you have any  
other ideas or comments?


-------------------------------------------------------------------------

CruiseControl.rb is distributed under the Apache 2.0 open-source license.
However, ThoughtWorks wants to ensure that ownership of the codebase
remains clear.  Therefore, we ask that all contributors to
CruiseControl.rb share ownership of their contribution with us.  This is
not some sort of evil world domination scheme, just a legal precaution.
Apache Software Foundation in fact does something to accomplish a similar
outcome:  http://www.apache.org/licenses/icla.txt.

We deeply value contributions from the community (what is an open source
project without any?) and request that you read and respond to this email
indicating your agreement to the following terms so that we can accept
your contribution.

You represent and warrant that your contribution is your original
creation, that it does not violate the rights of any person or entity,
including your employer and that you have the right to submit your
contribution.

You assign to ThoughtWorks joint and equal ownership in all worldwide
intellectual property rights with respect to such contribution, without
the obligation to provide attribution or to account to each other for
amounts received in connection with the contribution.

In order to confirm your acceptance of these terms, please reply to this
email with the following:

Full Name: Esteban Manchado Vel?zquez
Employer Name: Opera Software ASA
Email: estebanm at opera.com

Thank you,

The CC.rb team

-- 
Esteban Manchado Vel?zquez <estebanm at opera.com>, who has mixed feelings  
about internal Opera builds

From alexey.verkhovsky at gmail.com  Thu Feb 21 21:09:42 2008
From: alexey.verkhovsky at gmail.com (Alexey Verkhovsky)
Date: Thu, 21 Feb 2008 19:09:42 -0700
Subject: [Cruisecontrolrb-developers] Rev 604 is deployed to ccrb.tw.com
Message-ID: <3945c4270802211809y1f05a1f6td2f6c1a27766c2f8@mail.gmail.com>

{subj}

Because of the changes to where [ccrb]/projects and site-specific
configuration files are located by default, it was pretty hard going.
Anyone who is running CC.rb in a proper daemon environment (no-login
account with restricted rights and non-writable $HOME) will have a
heck of a time upgrading to the next  CC.rb release, if they don't
know to set CRUISE_DATA_ROOT environment variable to someplace
writable.

-- 
Alexey Verkhovsky
CruiseControl.rb [http://cruisecontrolrb.thoughtworks.com]
RubyWorks [http://rubyworks.thoughtworks.com]

From alexey.verkhovsky at gmail.com  Mon Feb 25 14:12:42 2008
From: alexey.verkhovsky at gmail.com (Alexey Verkhovsky)
Date: Mon, 25 Feb 2008 12:12:42 -0700
Subject: [Cruisecontrolrb-developers] Reopening SMTP conversation after
	getting false from starttls
Message-ID: <3945c4270802251112h326262c1n6853bfe22d83a6d7@mail.gmail.com>

Hi all,

I've just checked in rev 608 with comment "Restart SMTP conversation
if STARTTLS failed - some SMTP servers that don't support TLS drop the
socket at this point".
It solves the problem with ThoughtWorks SMTP server, which responds to
STARTTLS with "502 Error: command not implemented", and drops its end
of the SMTP socket.

I vaguely remember that I wanted to do it once before, and don't
remember why I didn't :) If anyone knows of any potential problems
with this change, please let me know.

-- 
Alexey Verkhovsky
CruiseControl.rb [http://cruisecontrolrb.thoughtworks.com]
RubyWorks [http://rubyworks.thoughtworks.com]

From estebanm at opera.com  Tue Feb 26 04:20:13 2008
From: estebanm at opera.com (=?utf-8?Q?Esteban_Manchado_Vel=C3=A1zquez?=)
Date: Tue, 26 Feb 2008 10:20:13 +0100
Subject: [Cruisecontrolrb-developers] Test result collectors patch
In-Reply-To: <op.t6r55mqyqcqbbv@estebanm-desktop>
References: <op.t6r55mqyqcqbbv@estebanm-desktop>
Message-ID: <op.t64j7zgyqcqbbv@estebanm-desktop>

Hi all,

    Any feedback on the patch? Are you interested at all? Just curious.  
I'll probably update the patch from time to time so it applies cleanly,  
but with SVN is not trivial, so I'd rather avoid it altogether if you're  
not interested.

-- 
Esteban Manchado Vel?zquez <estebanm at opera.com>, who has mixed feelings  
about internal Opera builds