From bret at pettichord.com  Mon Mar  1 19:47:51 2010
From: bret at pettichord.com (Bret Pettichord)
Date: Mon, 1 Mar 2010 18:47:51 -0600
Subject: [Cruisecontrolrb-developers] How about we turn off pull
	requests (Was: [GitHub] gnufied sent you a pull request from
	gnufied/cruisecontrol.rb)
In-Reply-To: <e3af97511002281326o45d16759q80e078b178a54513@mail.gmail.com>
References: <e3af97511002281326o45d16759q80e078b178a54513@mail.gmail.com>
Message-ID: <ade75c5b1003011647x50d5caa5l771dd94cdb3eb863@mail.gmail.com>

Another option would be to ask people to post a link to their commit in the
ticket. This gives the advantages of using git (way better than patch files)
but puts in a place that everyone can see.

BTW, this seems to be a general problem with github. I have the same problem
with the Watir project. Wondering if maybe we could ask them to give us a
better solution.

Bret

On Sun, Feb 28, 2010 at 3:26 PM, Chad Woolley <thewoolleyman at gmail.com>wrote:

> How about we turn off pull requests with message asking for
> patch+ticket?  Since github doesn't allow non-account-owners to view
> pull requests, that's the only way to allow all the collaborators to
> help manage tickets/patches.
>
>
> ---------- Forwarded message ----------
> From: GitHub <noreply at github.com>
> Date: Mon, Jan 25, 2010 at 12:52 PM
> Subject: [GitHub] gnufied sent you a pull request from
> gnufied/cruisecontrol.rb
> To: thewoolleyman at gmail.com
>
>
>
>
> gnufied wants you to pull from gnufied/cruisecontrol.rb at master
>
> Body: Can you guys pull in from my fork? I have done two things:
>
> 1. Do not load smtl_tls.rb for Ruby 1.8.7.
> 2. Implement twitter support via plugin.
>
> There are test cases to cover the functionality as well (and thus
> shouldn't be a problem to merge).
>
>
> View repository: http://github.com/gnufied/cruisecontrol.rb/tree/master
> _______________________________________________
> Cruisecontrolrb-developers mailing list
> Cruisecontrolrb-developers at rubyforge.org
> http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers
>



-- 
Bret Pettichord
Lead Developer, Watir, www.watir.com

Blog, www.io.com/~wazmo/blog
Twitter, www.twitter.com/bpettichord
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/cruisecontrolrb-developers/attachments/20100301/d07a8d91/attachment.html>

From thewoolleyman at gmail.com  Mon Mar  1 20:17:41 2010
From: thewoolleyman at gmail.com (Chad Woolley)
Date: Mon, 1 Mar 2010 18:17:41 -0700
Subject: [Cruisecontrolrb-developers] How about we turn off pull
	requests (Was: [GitHub] gnufied sent you a pull request from
	gnufied/cruisecontrol.rb)
In-Reply-To: <ade75c5b1003011647x50d5caa5l771dd94cdb3eb863@mail.gmail.com>
References: <e3af97511002281326o45d16759q80e078b178a54513@mail.gmail.com> 
	<ade75c5b1003011647x50d5caa5l771dd94cdb3eb863@mail.gmail.com>
Message-ID: <e3af97511003011717x77b5719eqeb1a10f0b649e3b6@mail.gmail.com>

On Mon, Mar 1, 2010 at 5:47 PM, Bret Pettichord <bret at pettichord.com> wrote:
> Another option would be to ask people to post a link to their commit in the
> ticket. This gives the advantages of using git (way better than patch files)
> but puts in a place that everyone can see.

Why is a pull request better than 'git format-patch'?  With
format-patch I know exactly what changes they want me to pull; a pull
request makes you sort out what changes they actually want to submit
(which is hard if they point to master instead of a topic branch, and
have continued with unrelated hacks on their master fork).

Plus, as I said, there's no way for all the admins to know what is
addressed and what isn't with pull requests (and we aren't that good
at being responsive anyway, which is the whole reason I brought this
up).

I'm still strongly in favor of turning off pull requests with a nice
descriptive message telling them exactly what to do instead (generate
a patch with git format-patch and give them a URL to submit it to the
lighthouse project).

Also, this is what Rails does, and it seems to work OK for them.

Who actually has admin privileges to the thoughtworks github account
anyway?  I know Jeremy created it, but I don't know the password.

-- Chad

From thewoolleyman at gmail.com  Mon Mar  1 20:20:01 2010
From: thewoolleyman at gmail.com (Chad Woolley)
Date: Mon, 1 Mar 2010 18:20:01 -0700
Subject: [Cruisecontrolrb-developers] How about we turn off pull
	requests (Was: [GitHub] gnufied sent you a pull request from
	gnufied/cruisecontrol.rb)
In-Reply-To: <ade75c5b1003011647x50d5caa5l771dd94cdb3eb863@mail.gmail.com>
References: <e3af97511002281326o45d16759q80e078b178a54513@mail.gmail.com> 
	<ade75c5b1003011647x50d5caa5l771dd94cdb3eb863@mail.gmail.com>
Message-ID: <e3af97511003011720y6a834cbn94cb0b92030eaaf1@mail.gmail.com>

On Mon, Mar 1, 2010 at 5:47 PM, Bret Pettichord <bret at pettichord.com> wrote:
> Another option would be to ask people to post a link to their commit

Just realized I didn't actually address your point.  Asking people to
include a link to the commit is not good because:

1. People will ignore it
2. changes can span multiple commits

git format-patch + ticket solves this plus the other issues I mentioned.

From bguthrie at thoughtworks.com  Mon Mar  1 22:47:39 2010
From: bguthrie at thoughtworks.com (Brian Guthrie)
Date: Mon, 1 Mar 2010 21:47:39 -0600
Subject: [Cruisecontrolrb-developers] How about we turn off pull
	requests (Was: [GitHub] gnufied sent you a pull request from
	gnufied/cruisecontrol.rb)
In-Reply-To: <e3af97511003011720y6a834cbn94cb0b92030eaaf1@mail.gmail.com>
References: <e3af97511002281326o45d16759q80e078b178a54513@mail.gmail.com> 
	<ade75c5b1003011647x50d5caa5l771dd94cdb3eb863@mail.gmail.com> 
	<e3af97511003011720y6a834cbn94cb0b92030eaaf1@mail.gmail.com>
Message-ID: <646a09521003011947h75c48328x6a9226910b18b0d6@mail.gmail.com>

I didn't realize at first why this would be a Good Thing but trying to pull
in more recent changes leaves me in agreement that this is a much easier way
to handle it - at least you always carry the context with you. I have admin
rights and will go ahead and give it a shot.

Brian

On Mon, Mar 1, 2010 at 7:20 PM, Chad Woolley <thewoolleyman at gmail.com>wrote:

> On Mon, Mar 1, 2010 at 5:47 PM, Bret Pettichord <bret at pettichord.com>
> wrote:
> > Another option would be to ask people to post a link to their commit
>
> Just realized I didn't actually address your point.  Asking people to
> include a link to the commit is not good because:
>
> 1. People will ignore it
> 2. changes can span multiple commits
>
> git format-patch + ticket solves this plus the other issues I mentioned.
> _______________________________________________
> Cruisecontrolrb-developers mailing list
> Cruisecontrolrb-developers at rubyforge.org
> http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/cruisecontrolrb-developers/attachments/20100301/117427d6/attachment-0001.html>

From bret at pettichord.com  Tue Mar  2 18:45:11 2010
From: bret at pettichord.com (Bret Pettichord)
Date: Tue, 2 Mar 2010 17:45:11 -0600
Subject: [Cruisecontrolrb-developers] How about we turn off pull
	requests (Was: [GitHub] gnufied sent you a pull request from
	gnufied/cruisecontrol.rb)
In-Reply-To: <e3af97511003011720y6a834cbn94cb0b92030eaaf1@mail.gmail.com>
References: <e3af97511002281326o45d16759q80e078b178a54513@mail.gmail.com>
	<ade75c5b1003011647x50d5caa5l771dd94cdb3eb863@mail.gmail.com>
	<e3af97511003011720y6a834cbn94cb0b92030eaaf1@mail.gmail.com>
Message-ID: <ade75c5b1003021545q1b3eb2a4wfadbcf9b0279d2de@mail.gmail.com>

I didn't know about git format-patch. I will look into using for Watir.
Thanks for the explanation.

Bret

On Mon, Mar 1, 2010 at 7:20 PM, Chad Woolley <thewoolleyman at gmail.com>wrote:

> On Mon, Mar 1, 2010 at 5:47 PM, Bret Pettichord <bret at pettichord.com>
> wrote:
> > Another option would be to ask people to post a link to their commit
>
> Just realized I didn't actually address your point.  Asking people to
> include a link to the commit is not good because:
>
> 1. People will ignore it
> 2. changes can span multiple commits
>
> git format-patch + ticket solves this plus the other issues I mentioned.
> _______________________________________________
> Cruisecontrolrb-developers mailing list
> Cruisecontrolrb-developers at rubyforge.org
> http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers
>



-- 
Bret Pettichord
Lead Developer, Watir, www.watir.com

Blog, www.io.com/~wazmo/blog
Twitter, www.twitter.com/bpettichord
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://rubyforge.org/pipermail/cruisecontrolrb-developers/attachments/20100302/2f6265b2/attachment.html>