From brian.takita at gmail.com Sat Dec 13 04:09:13 2008 From: brian.takita at gmail.com (Brian Takita) Date: Sat, 13 Dec 2008 04:09:13 -0500 Subject: [Erector-devel] New version ready to go out Message-ID: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> I added support for Rails 2.2.0. This involved having the Widget write to a String rather than an IO object. I also removed the Doc object because it didn't seem to add much anymore. It also seems most of the development happens in Git now. That being said, I changed the repo information and the versioning scheme. Jeff Dean and other have requested that the automatic creation of attr_readers (when instantiating a Widget) be optional because the attr_readers can conflict with domain logic or tags. I'd also like to add a Rails::Widget subclass, rather than monkey-patching Widget in Rails because its getting too complex. Brian From brian.takita at gmail.com Sun Dec 14 03:32:59 2008 From: brian.takita at gmail.com (Brian Takita) Date: Sun, 14 Dec 2008 03:32:59 -0500 Subject: [Erector-devel] New version ready to go out In-Reply-To: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> Message-ID: <1d7ddd110812140032s4b1d40fp63c6d44245e8429b@mail.gmail.com> I'm having trouble releasing. rsync: failed to set times on "/var/www/gforge-projects/erector/rdoc/.": Operation not permitted (1) I guess this is what happened to Jim before. On Sat, Dec 13, 2008 at 4:09 AM, Brian Takita wrote: > I added support for Rails 2.2.0. This involved having the Widget write > to a String rather than an IO object. I also removed the Doc object > because it didn't seem to add much anymore. > > It also seems most of the development happens in Git now. That being > said, I changed the repo information and the versioning scheme. > > Jeff Dean and other have requested that the automatic creation of > attr_readers (when instantiating a Widget) be optional because the > attr_readers can conflict with domain logic or tags. > > I'd also like to add a Rails::Widget subclass, rather than > monkey-patching Widget in Rails because its getting too complex. > > Brian > From kingdon at panix.com Sun Dec 14 15:17:11 2008 From: kingdon at panix.com (Jim Kingdon) Date: Sun, 14 Dec 2008 15:17:11 -0500 (EST) Subject: [Erector-devel] New version ready to go out In-Reply-To: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> (brian.takita@gmail.com) References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> Message-ID: <20081214201711.EC60D24238@panix5.panix.com> > It also seems most of the development happens in Git now. That being > said, I changed the repo information and the versioning scheme. I'm fine with switching to git, but would suggest that we: 1. Really switch to git. That is, get rid of the svn repository (or at least disable future checkins there). I don't think we can push to github and also use git-svn (because of the well-known limitations of rebase). If I'm wrong about this, I'd be glad to see directions for how to make it work, but it is probably simplest just to switch to git for real. (I haven't used github for erector in some months, because of these issues). 2. Update the documentation. Maybe you've done this, but I don't have your recent changes, as I'm tracking svn and your changes aren't there, nor are the changes on the web site (presumably because of the permissions problem). I find the status quo rather confusing, and worse than either (a) use svn, or (b) use git. From kingdon at panix.com Sun Dec 14 15:23:07 2008 From: kingdon at panix.com (Jim Kingdon) Date: Sun, 14 Dec 2008 15:23:07 -0500 (EST) Subject: [Erector-devel] New version ready to go out In-Reply-To: <1d7ddd110812140032s4b1d40fp63c6d44245e8429b@mail.gmail.com> (brian.takita@gmail.com) References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <1d7ddd110812140032s4b1d40fp63c6d44245e8429b@mail.gmail.com> Message-ID: <20081214202307.C669724238@panix5.panix.com> > rsync: failed to set times on > "/var/www/gforge-projects/erector/rdoc/.": Operation not permitted (1) > > I guess this is what happened to Jim before. What happens if you try following the instructions here: http://rubyforge.org/docman/view.php/5/460/faq.html#vhost_perms ? I can't try this myself as I'm not a project admin, but Brian is. From brian.takita at gmail.com Sun Dec 14 15:58:55 2008 From: brian.takita at gmail.com (Brian Takita) Date: Sun, 14 Dec 2008 15:58:55 -0500 Subject: [Erector-devel] New version ready to go out In-Reply-To: <20081214202307.C669724238@panix5.panix.com> References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <1d7ddd110812140032s4b1d40fp63c6d44245e8429b@mail.gmail.com> <20081214202307.C669724238@panix5.panix.com> Message-ID: <1d7ddd110812141258g1840d0d0t1c09c4d12ba93473@mail.gmail.com> On Sun, Dec 14, 2008 at 3:23 PM, Jim Kingdon wrote: >> rsync: failed to set times on >> "/var/www/gforge-projects/erector/rdoc/.": Operation not permitted (1) >> >> I guess this is what happened to Jim before. > > What happens if you try following the > instructions here: > http://rubyforge.org/docman/view.php/5/460/faq.html#vhost_perms > ? It didn't seem to work. I'll file a ticket with Rubyforge. > > I can't try this myself as I'm not a project admin, but Brian is. > I made you a project admin. From brian.takita at gmail.com Sun Dec 14 16:12:18 2008 From: brian.takita at gmail.com (Brian Takita) Date: Sun, 14 Dec 2008 16:12:18 -0500 Subject: [Erector-devel] New version ready to go out In-Reply-To: <20081214201711.EC60D24238@panix5.panix.com> References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <20081214201711.EC60D24238@panix5.panix.com> Message-ID: <1d7ddd110812141312h7819322l4387217366e1e77a@mail.gmail.com> On Sun, Dec 14, 2008 at 3:17 PM, Jim Kingdon wrote: >> It also seems most of the development happens in Git now. That being >> said, I changed the repo information and the versioning scheme. > > I'm fine with switching to git, but would suggest that we: > > 1. Really switch to git. That is, get rid of the svn repository (or > at least disable future checkins there). I don't think we can push > to github and also use git-svn (because of the well-known > limitations of rebase). If I'm wrong about this, I'd be glad to > see directions for how to make it work, but it is probably simplest > just to switch to git for real. (I haven't used github for erector > in some months, because of these issues). I agree. > > 2. Update the documentation. Maybe you've done this, but I don't have > your recent changes, as I'm tracking svn and your changes aren't > there, nor are the changes on the web site (presumably because of > the permissions problem). I did. Its checked into the git repo. Is Alex's github username alexch? > > I find the status quo rather confusing, and worse than either (a) use > svn, or (b) use git. > From brian.takita at gmail.com Sun Dec 14 16:18:01 2008 From: brian.takita at gmail.com (Brian Takita) Date: Sun, 14 Dec 2008 16:18:01 -0500 Subject: [Erector-devel] New version ready to go out In-Reply-To: <1d7ddd110812141258g1840d0d0t1c09c4d12ba93473@mail.gmail.com> References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <1d7ddd110812140032s4b1d40fp63c6d44245e8429b@mail.gmail.com> <20081214202307.C669724238@panix5.panix.com> <1d7ddd110812141258g1840d0d0t1c09c4d12ba93473@mail.gmail.com> Message-ID: <1d7ddd110812141318q49b36b83h196c279cf6984551@mail.gmail.com> On Sun, Dec 14, 2008 at 3:58 PM, Brian Takita wrote: > On Sun, Dec 14, 2008 at 3:23 PM, Jim Kingdon wrote: >>> rsync: failed to set times on >>> "/var/www/gforge-projects/erector/rdoc/.": Operation not permitted (1) >>> >>> I guess this is what happened to Jim before. >> >> What happens if you try following the >> instructions here: >> http://rubyforge.org/docman/view.php/5/460/faq.html#vhost_perms >> ? > It didn't seem to work. I'll file a ticket with Rubyforge. I had a ssh key issue. I'll try updating the key on my account and see if that fixes things. >> >> I can't try this myself as I'm not a project admin, but Brian is. >> > I made you a project admin. > From mike at pivotallabs.com Mon Dec 15 17:24:30 2008 From: mike at pivotallabs.com (Mike Grafton) Date: Mon, 15 Dec 2008 17:24:30 -0500 Subject: [Erector-devel] New version ready to go out In-Reply-To: <1d7ddd110812141312h7819322l4387217366e1e77a@mail.gmail.com> References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <20081214201711.EC60D24238@panix5.panix.com> <1d7ddd110812141312h7819322l4387217366e1e77a@mail.gmail.com> Message-ID: Is this known to work with Desert? I'm getting the following with both desert 0.3.2 (gem) or the commit of desert from GitHub: ./config/../vendor/desert/lib/desert/rails/dependencies.rb:56:in `look_for_constant_in_parent_module': Constant Erector::Doc from erector/doc.rb not found (NameError) Constant Doc from doc.rb not found from ./config/../vendor/desert/lib/desert/rails/dependencies.rb:13:in `load_missing_constant' from /Library/Ruby/Gems/1.8/gems/activesupport-2.2.2/lib/active_support/dependencies.rb:77:in `const_missing' from /Users/pivotal/workspace/casebook/config/environments/test.rb:4:in `load_environment' from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/lib/initializer.rb:340:in `load_environment' from /Library/Ruby/Gems/1.8/gems/activesupport-2.2.2/lib/active_support/core_ext/kernel/reporting.rb:11:in `silence_warnings' from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/lib/initializer.rb:333:in `load_environment' from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/lib/initializer.rb:136:in `process' from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/lib/initializer.rb:112:in `send' ... 13 levels... from /Library/Ruby/Gems/1.8/gems/rspec-1.1.9/lib/spec/runner/command_line.rb:10:in `run' from /Library/Ruby/Gems/1.8/gems/rspec-1.1.9/bin/spec:4 from /usr/bin/spec:19:in `load' from /usr/bin/spec:19 Mike On Sun, Dec 14, 2008 at 4:12 PM, Brian Takita wrote: > On Sun, Dec 14, 2008 at 3:17 PM, Jim Kingdon wrote: > >> It also seems most of the development happens in Git now. That being > >> said, I changed the repo information and the versioning scheme. > > > > I'm fine with switching to git, but would suggest that we: > > > > 1. Really switch to git. That is, get rid of the svn repository (or > > at least disable future checkins there). I don't think we can push > > to github and also use git-svn (because of the well-known > > limitations of rebase). If I'm wrong about this, I'd be glad to > > see directions for how to make it work, but it is probably simplest > > just to switch to git for real. (I haven't used github for erector > > in some months, because of these issues). > I agree. > > > > 2. Update the documentation. Maybe you've done this, but I don't have > > your recent changes, as I'm tracking svn and your changes aren't > > there, nor are the changes on the web site (presumably because of > > the permissions problem). > I did. Its checked into the git repo. Is Alex's github username alexch? > > > > I find the status quo rather confusing, and worse than either (a) use > > svn, or (b) use git. > > > _______________________________________________ > Erector-devel mailing list > Erector-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/erector-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From mike at pivotallabs.com Mon Dec 15 17:25:04 2008 From: mike at pivotallabs.com (Mike Grafton) Date: Mon, 15 Dec 2008 17:25:04 -0500 Subject: [Erector-devel] New version ready to go out In-Reply-To: References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <20081214201711.EC60D24238@panix5.panix.com> <1d7ddd110812141312h7819322l4387217366e1e77a@mail.gmail.com> Message-ID: (I meant "the latest commit of desert from GitHub") On Mon, Dec 15, 2008 at 5:24 PM, Mike Grafton wrote: > Is this known to work with Desert? I'm getting the following with both > desert 0.3.2 (gem) or the commit of desert from GitHub: > > ./config/../vendor/desert/lib/desert/rails/dependencies.rb:56:in > `look_for_constant_in_parent_module': Constant Erector::Doc from > erector/doc.rb not found (NameError) > Constant Doc from doc.rb not found from > ./config/../vendor/desert/lib/desert/rails/dependencies.rb:13:in > `load_missing_constant' > from > /Library/Ruby/Gems/1.8/gems/activesupport-2.2.2/lib/active_support/dependencies.rb:77:in > `const_missing' > from /Users/pivotal/workspace/casebook/config/environments/test.rb:4:in > `load_environment' > from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/lib/initializer.rb:340:in > `load_environment' > from > /Library/Ruby/Gems/1.8/gems/activesupport-2.2.2/lib/active_support/core_ext/kernel/reporting.rb:11:in > `silence_warnings' > from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/lib/initializer.rb:333:in > `load_environment' > from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/lib/initializer.rb:136:in > `process' > from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/lib/initializer.rb:112:in > `send' > ... 13 levels... > from > /Library/Ruby/Gems/1.8/gems/rspec-1.1.9/lib/spec/runner/command_line.rb:10:in > `run' > from /Library/Ruby/Gems/1.8/gems/rspec-1.1.9/bin/spec:4 > from /usr/bin/spec:19:in `load' > from /usr/bin/spec:19 > > Mike > > > > On Sun, Dec 14, 2008 at 4:12 PM, Brian Takita wrote: > >> On Sun, Dec 14, 2008 at 3:17 PM, Jim Kingdon wrote: >> >> It also seems most of the development happens in Git now. That being >> >> said, I changed the repo information and the versioning scheme. >> > >> > I'm fine with switching to git, but would suggest that we: >> > >> > 1. Really switch to git. That is, get rid of the svn repository (or >> > at least disable future checkins there). I don't think we can push >> > to github and also use git-svn (because of the well-known >> > limitations of rebase). If I'm wrong about this, I'd be glad to >> > see directions for how to make it work, but it is probably simplest >> > just to switch to git for real. (I haven't used github for erector >> > in some months, because of these issues). >> I agree. >> > >> > 2. Update the documentation. Maybe you've done this, but I don't have >> > your recent changes, as I'm tracking svn and your changes aren't >> > there, nor are the changes on the web site (presumably because of >> > the permissions problem). >> I did. Its checked into the git repo. Is Alex's github username alexch? >> > >> > I find the status quo rather confusing, and worse than either (a) use >> > svn, or (b) use git. >> > >> _______________________________________________ >> Erector-devel mailing list >> Erector-devel at rubyforge.org >> http://rubyforge.org/mailman/listinfo/erector-devel >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From brian at pivotallabs.com Mon Dec 15 18:08:28 2008 From: brian at pivotallabs.com (Brian Takita) Date: Mon, 15 Dec 2008 18:08:28 -0500 Subject: [Erector-devel] New version ready to go out In-Reply-To: References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <20081214201711.EC60D24238@panix5.panix.com> <1d7ddd110812141312h7819322l4387217366e1e77a@mail.gmail.com> Message-ID: <1d7ddd110812151508t152130e6y2668f38df5961030@mail.gmail.com> On Mon, Dec 15, 2008 at 5:24 PM, Mike Grafton wrote: > Is this known to work with Desert? I'm getting the following with both > desert 0.3.2 (gem) or the commit of desert from GitHub: It looks like are overriding Erector::Doc. Erector::Doc is gone. Override Erector::Widget instead. > > ./config/../vendor/desert/lib/desert/rails/dependencies.rb:56:in > `look_for_constant_in_parent_module': Constant Erector::Doc from > erector/doc.rb not found (NameError) > Constant Doc from doc.rb not found from > ./config/../vendor/desert/lib/desert/rails/dependencies.rb:13:in > `load_missing_constant' > from > /Library/Ruby/Gems/1.8/gems/activesupport-2.2.2/lib/active_support/dependencies.rb:77:in > `const_missing' > from /Users/pivotal/workspace/casebook/config/environments/test.rb:4:in > `load_environment' > from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/lib/initializer.rb:340:in > `load_environment' > from > /Library/Ruby/Gems/1.8/gems/activesupport-2.2.2/lib/active_support/core_ext/kernel/reporting.rb:11:in > `silence_warnings' > from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/lib/initializer.rb:333:in > `load_environment' > from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/lib/initializer.rb:136:in > `process' > from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/lib/initializer.rb:112:in > `send' > ... 13 levels... > from > /Library/Ruby/Gems/1.8/gems/rspec-1.1.9/lib/spec/runner/command_line.rb:10:in > `run' > from /Library/Ruby/Gems/1.8/gems/rspec-1.1.9/bin/spec:4 > from /usr/bin/spec:19:in `load' > from /usr/bin/spec:19 > > Mike > > > On Sun, Dec 14, 2008 at 4:12 PM, Brian Takita > wrote: >> >> On Sun, Dec 14, 2008 at 3:17 PM, Jim Kingdon wrote: >> >> It also seems most of the development happens in Git now. That being >> >> said, I changed the repo information and the versioning scheme. >> > >> > I'm fine with switching to git, but would suggest that we: >> > >> > 1. Really switch to git. That is, get rid of the svn repository (or >> > at least disable future checkins there). I don't think we can push >> > to github and also use git-svn (because of the well-known >> > limitations of rebase). If I'm wrong about this, I'd be glad to >> > see directions for how to make it work, but it is probably simplest >> > just to switch to git for real. (I haven't used github for erector >> > in some months, because of these issues). >> I agree. >> > >> > 2. Update the documentation. Maybe you've done this, but I don't have >> > your recent changes, as I'm tracking svn and your changes aren't >> > there, nor are the changes on the web site (presumably because of >> > the permissions problem). >> I did. Its checked into the git repo. Is Alex's github username alexch? >> > >> > I find the status quo rather confusing, and worse than either (a) use >> > svn, or (b) use git. >> > >> _______________________________________________ >> Erector-devel mailing list >> Erector-devel at rubyforge.org >> http://rubyforge.org/mailman/listinfo/erector-devel > > From kingdon at panix.com Mon Dec 15 22:47:23 2008 From: kingdon at panix.com (Jim Kingdon) Date: Mon, 15 Dec 2008 22:47:23 -0500 (EST) Subject: [Erector-devel] New version ready to go out In-Reply-To: <20081214201711.EC60D24238@panix5.panix.com> (message from Jim Kingdon on Sun, 14 Dec 2008 15:17:11 -0500 (EST)) References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <20081214201711.EC60D24238@panix5.panix.com> Message-ID: <20081216034724.003B924238@panix5.panix.com> > It also seems most of the development happens in Git now. That being > said, I changed the repo information and the versioning scheme. I've looked over the logs, and find that the development was split perhaps 50-50 between svn and git, with noone merging between the two. This includes the same feature (col/colgroup) being added both in svn and in git, differently of course. I'll try to get the merge done (again, as I did when we had forks in several different svn repositories about 9 months ago) but I really hope this is going to stop happening. From andy at carbonfive.com Mon Dec 15 23:59:50 2008 From: andy at carbonfive.com (Andy Peterson) Date: Mon, 15 Dec 2008 20:59:50 -0800 Subject: [Erector-devel] New version ready to go out Message-ID: Great to see fixes for 2.2. We noticed a change the broke most, if not all of, our pages. We put our views in folders named after the plural form of the entity, eg. app/views/companies/index.rb. The package structure for this class is therefore Views::Companies::Index. The new version uses .classify to convert from a path to a class, so it ends up with a class that uses the singular form: Views::Company::Index. Is this change intentional? Below is an edge patch we used to restore the pevious behavior. Andy C5 --- .../2.2.0/action_view_template_handler.rb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/erector/rails/template_handlers/2.2.0/action_view_template_handler.rb b/lib/erector/rails/template_handlers/2.2.0/action_view_template_handler.rb index dfa5e22..9dfd654 100644 --- a/lib/erector/rails/template_handlers/2.2.0/action_view_template_handler.rb +++ b/lib/erector/rails/template_handlers/2.2.0/action_view_template_handler.rb @@ -17,7 +17,7 @@ module ActionView #:nodoc: require_dependency File.expand_path(template.filename) widget_class_parts = relative_path_parts.inject(['Views']) do |class_parts, node| - class_parts << node.gsub(/^_/, "").gsub(/(\.html)?\.rb$/, '').classify + class_parts << node.gsub(/^_/, "").gsub(/(\.html)?\.rb$/, '').camelize class_parts end widget_class_name = widget_class_parts.join("::") -- 1.6.0.4 -------------- next part -------------- An HTML attachment was scrubbed... URL: From kingdon at panix.com Tue Dec 16 00:07:38 2008 From: kingdon at panix.com (Jim Kingdon) Date: Tue, 16 Dec 2008 00:07:38 -0500 (EST) Subject: [Erector-devel] New version ready to go out In-Reply-To: <20081216034724.003B924238@panix5.panix.com> (message from Jim Kingdon on Mon, 15 Dec 2008 22:47:23 -0500 (EST)) References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <20081214201711.EC60D24238@panix5.panix.com> <20081216034724.003B924238@panix5.panix.com> Message-ID: <20081216050738.43F4A24238@panix5.panix.com> OK, merge is done. I will say that git does make this kind of thing easier (once you figure it out, in this case the key step was "git remote add" of the git repository that git-svn created, followed by the usual fetch/merge/etc). I still had to resolve conflicts by hand but once I did, the history looks nice and informative. Still, it wasn't easy enough that I recommend letting things go months between merges, as happened here. From kingdon at panix.com Tue Dec 16 00:13:42 2008 From: kingdon at panix.com (Jim Kingdon) Date: Tue, 16 Dec 2008 00:13:42 -0500 (EST) Subject: [Erector-devel] New version ready to go out In-Reply-To: <1d7ddd110812151508t152130e6y2668f38df5961030@mail.gmail.com> (brian@pivotallabs.com) References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <20081214201711.EC60D24238@panix5.panix.com> <1d7ddd110812141312h7819322l4387217366e1e77a@mail.gmail.com> <1d7ddd110812151508t152130e6y2668f38df5961030@mail.gmail.com> Message-ID: <20081216051342.A3DE624238@panix5.panix.com> > Erector::Doc is gone. I have mixed feelings about this. On the one side, the interaction between Doc and Widget was kind of a tangle, and probably not a good thing to be included in the public API. On the other hand, it turned out nicely the way that Doc was responsible for pretty-printing, and Widget was responsible for all kinds of other stuff. Even without the code that got moved from Doc, Widget is a big class with a lot of responsibilities. Assuming that the public API remains Doc-less, we can always factor out the pretty-printing again later, so this isn't some kind of crisis, but I thought I should at least say something rather than agonize in silence. From kingdon at panix.com Tue Dec 16 00:52:47 2008 From: kingdon at panix.com (Jim Kingdon) Date: Tue, 16 Dec 2008 00:52:47 -0500 (EST) Subject: [Erector-devel] New version ready to go out In-Reply-To: <1d7ddd110812141318q49b36b83h196c279cf6984551@mail.gmail.com> (brian.takita@gmail.com) References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <1d7ddd110812140032s4b1d40fp63c6d44245e8429b@mail.gmail.com> <20081214202307.C669724238@panix5.panix.com> <1d7ddd110812141258g1840d0d0t1c09c4d12ba93473@mail.gmail.com> <1d7ddd110812141318q49b36b83h196c279cf6984551@mail.gmail.com> Message-ID: <20081216055247.3B01024238@panix5.panix.com> >>> rsync: failed to set times on >>> "/var/www/gforge-projects/erector/rdoc/.": Operation not permitted (1) Ah, the "failed to set times" (and some of the other messages) are the hint: rsync was being called with a variety of options which only work for root (or, perhaps, the owner, not just group member, of the file). I got it to work and checked in the Rakefile fixes. Check out http://erector.rubyforge.org/ and note how the left sidebar says "github repository" instead of "subversion repository". I also set the subversion repository to read-only. Anyone trying to check in there will get an error such as the following: $ svn ci Sending README.txt Transmitting file data .svn: Commit failed (details follow): svn: Can't create directory '/var/svn/erector/db/transactions/214-1.txn': Permission denied svn: Your commit message was left in a temporary file: svn: '/home/kingdon/zwork/old-erectors/erector-svn-2008-12/svn-commit.tmp' $ From brian.takita at gmail.com Tue Dec 16 13:36:22 2008 From: brian.takita at gmail.com (Brian Takita) Date: Tue, 16 Dec 2008 13:36:22 -0500 Subject: [Erector-devel] New version ready to go out In-Reply-To: References: Message-ID: <1d7ddd110812161036m55f417b9kf79080c3a6ec1203@mail.gmail.com> On Mon, Dec 15, 2008 at 11:59 PM, Andy Peterson wrote: > Great to see fixes for 2.2. > > We noticed a change the broke most, if not all of, our pages. We put our > views > in folders named after the plural form of the entity, eg. > app/views/companies/index.rb. > The package structure for this class is therefore Views::Companies::Index. > > The new version uses .classify to convert from a path to a class, so it ends > up with a class that uses the singular form: Views::Company::Index. > > Is this change intentional? No, its a bug. Thanks for the patch. I'll go ahead and apply it. > > Below is an edge patch we used to restore the pevious behavior. > > Andy > C5 > > --- > .../2.2.0/action_view_ > template_handler.rb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git > a/lib/erector/rails/template_handlers/2.2.0/action_view_template_handler.rb > b/lib/erector/rails/template_handlers/2.2.0/action_view_template_handler.rb > index dfa5e22..9dfd654 100644 > --- > a/lib/erector/rails/template_handlers/2.2.0/action_view_template_handler.rb > +++ > b/lib/erector/rails/template_handlers/2.2.0/action_view_template_handler.rb > @@ -17,7 +17,7 @@ module ActionView #:nodoc: > require_dependency File.expand_path(template.filename) > > widget_class_parts = relative_path_parts.inject(['Views']) do > |class_parts, node| > - class_parts << node.gsub(/^_/, "").gsub(/(\.html)?\.rb$/, > '').classify > + class_parts << node.gsub(/^_/, "").gsub(/(\.html)?\.rb$/, > '').camelize > class_parts > end > widget_class_name = widget_class_parts.join("::") > -- > 1.6.0.4 > > > > _______________________________________________ > Erector-devel mailing list > Erector-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/erector-devel > > From brian.takita at gmail.com Tue Dec 16 13:39:11 2008 From: brian.takita at gmail.com (Brian Takita) Date: Tue, 16 Dec 2008 13:39:11 -0500 Subject: [Erector-devel] New version ready to go out In-Reply-To: <20081216051342.A3DE624238@panix5.panix.com> References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <20081214201711.EC60D24238@panix5.panix.com> <1d7ddd110812141312h7819322l4387217366e1e77a@mail.gmail.com> <1d7ddd110812151508t152130e6y2668f38df5961030@mail.gmail.com> <20081216051342.A3DE624238@panix5.panix.com> Message-ID: <1d7ddd110812161039p373ab75bn92b0564489801a2f@mail.gmail.com> On Tue, Dec 16, 2008 at 12:13 AM, Jim Kingdon wrote: >> Erector::Doc is gone. > > I have mixed feelings about this. > > On the one side, the interaction between Doc and Widget was kind of a > tangle, and probably not a good thing to be included in the public API. > > On the other hand, it turned out nicely the way that Doc was > responsible for pretty-printing, and Widget was responsible for all > kinds of other stuff. Even without the code that got moved from Doc, > Widget is a big class with a lot of responsibilities. > > Assuming that the public API remains Doc-less, we can always factor > out the pretty-printing again later, so this isn't some kind of > crisis, but I thought I should at least say something rather than > agonize in silence. > That makes sense. The issue I was having was Doc was sort of getting in the way and confusing. I do agree that it would be nice to have some sort of nice abstraction, I just don't know what is best yet. Another thing to consider, is that the base Widget class is overridden. This means critical methods cannot be accidentally overridden. We sort of adopted the convention of surrounding these critical method names with '__'. From alex at pivotallabs.com Tue Dec 16 13:57:53 2008 From: alex at pivotallabs.com (Alex Chaffee) Date: Tue, 16 Dec 2008 10:57:53 -0800 Subject: [Erector-devel] New version ready to go out In-Reply-To: <1d7ddd110812161039p373ab75bn92b0564489801a2f@mail.gmail.com> References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <20081214201711.EC60D24238@panix5.panix.com> <1d7ddd110812141312h7819322l4387217366e1e77a@mail.gmail.com> <1d7ddd110812151508t152130e6y2668f38df5961030@mail.gmail.com> <20081216051342.A3DE624238@panix5.panix.com> <1d7ddd110812161039p373ab75bn92b0564489801a2f@mail.gmail.com> Message-ID: <7a93bd340812161057t48b1b6b0vf4ffa9a5d16de091@mail.gmail.com> > > We sort of adopted the convention of surrounding these critical method > names with '__'. > This bothers me, not least because nowhere in the code is this convention explained. I've always had an aversion to underscores. Too ambiguous (does it mean private? final? system? instance?) and too ugly. I'm just saying. - A -------------- next part -------------- An HTML attachment was scrubbed... URL: From sconover at gmail.com Tue Dec 16 14:58:23 2008 From: sconover at gmail.com (Steve Conover) Date: Tue, 16 Dec 2008 11:58:23 -0800 Subject: [Erector-devel] New version ready to go out In-Reply-To: <7a93bd340812161057t48b1b6b0vf4ffa9a5d16de091@mail.gmail.com> References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <20081214201711.EC60D24238@panix5.panix.com> <1d7ddd110812141312h7819322l4387217366e1e77a@mail.gmail.com> <1d7ddd110812151508t152130e6y2668f38df5961030@mail.gmail.com> <20081216051342.A3DE624238@panix5.panix.com> <1d7ddd110812161039p373ab75bn92b0564489801a2f@mail.gmail.com> <7a93bd340812161057t48b1b6b0vf4ffa9a5d16de091@mail.gmail.com> Message-ID: It means private On Tue, Dec 16, 2008 at 10:57 AM, Alex Chaffee wrote: >> We sort of adopted the convention of surrounding these critical method >> names with '__'. > > This bothers me, not least because nowhere in the code is this convention > explained. > I've always had an aversion to underscores. Too ambiguous (does it mean > private? final? system? instance?) and too ugly. > I'm just saying. > - A > > _______________________________________________ > Erector-devel mailing list > Erector-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/erector-devel > > From mike at pivotallabs.com Tue Dec 16 15:07:58 2008 From: mike at pivotallabs.com (Mike Grafton) Date: Tue, 16 Dec 2008 15:07:58 -0500 Subject: [Erector-devel] Erector 0.5.1 Message-ID: Brian and I just fixed the problem reported by Andy Peterson and which I also saw on my project (thanks, Andy, for the patch). We rolled a new gem and pushed it. Let us know if there are any problems. Mike -------------- next part -------------- An HTML attachment was scrubbed... URL: From brian.takita at gmail.com Tue Dec 16 15:11:00 2008 From: brian.takita at gmail.com (Brian Takita) Date: Tue, 16 Dec 2008 15:11:00 -0500 Subject: [Erector-devel] New version ready to go out In-Reply-To: <7a93bd340812161057t48b1b6b0vf4ffa9a5d16de091@mail.gmail.com> References: <1d7ddd110812130109r52940476r5703bcd5aa255f07@mail.gmail.com> <20081214201711.EC60D24238@panix5.panix.com> <1d7ddd110812141312h7819322l4387217366e1e77a@mail.gmail.com> <1d7ddd110812151508t152130e6y2668f38df5961030@mail.gmail.com> <20081216051342.A3DE624238@panix5.panix.com> <1d7ddd110812161039p373ab75bn92b0564489801a2f@mail.gmail.com> <7a93bd340812161057t48b1b6b0vf4ffa9a5d16de091@mail.gmail.com> Message-ID: <1d7ddd110812161211v3c87c83ck55bea8a0141851c9@mail.gmail.com> On Tue, Dec 16, 2008 at 1:57 PM, Alex Chaffee wrote: >> We sort of adopted the convention of surrounding these critical method >> names with '__'. > > This bothers me, not least because nowhere in the code is this convention > explained. That makes sense. I can add some documentation. > I've always had an aversion to underscores. Too ambiguous (does it mean > private? final? system? instance?) and too ugly. Thats fine. If we can find a better solution, lets use it. > I'm just saying. > - A > From mike at pivotallabs.com Wed Dec 17 17:51:16 2008 From: mike at pivotallabs.com (Mike Grafton) Date: Wed, 17 Dec 2008 17:51:16 -0500 Subject: [Erector-devel] Rendering erector widgets inside of RJS templates Message-ID: In our app, we often render erector widgets in an RJS context: render :update do |page| page.insert_html :bottom, "user_id", Views::Users::Thumbnail.new(self, {:user => @user}) end However, this breaks in erector with the following: /Library/Ruby/Gems/1.8/gems/erector-0.5.1/lib/erector/widget.rb:235:in `concat' /Library/Ruby/Gems/1.8/gems/erector-0.5.1/lib/erector/widget.rb:235:in `text /Library/Ruby/Gems/1.8/gems/erector-0.5.1/lib/erector/widget.rb:138:in `send' /Library/Ruby/Gems/1.8/gems/erector-0.5.1/lib/erector/widget.rb:138:in `to_s' /Library/Ruby/Gems/1.8/gems/actionpack-2.2.2/lib/action_view/helpers/prototype_helper.rb:1003:in `render' /Library/Ruby/Gems/1.8/gems/actionpack-2.2.2/lib/action_view/helpers/prototype_helper.rb:752:in `insert_html' app/controllers/users_controller.rb:25:in `__instance_exec0' What we've found is that in the RJS context, the view's output_buffer is an Array, not a String, as erector expects. And the code in the Rails 2.2.0 extension overrides the Widget class's output method, returning the output_buffer of the template. If we change that code to call #to_s on the output_buffer Array, form_for completely breaks. I can elaborate on that if anybody cares (we're still looking into a solution for that, but I thought I'd post early to see if anybody has run into this). Any suggestions? Mike -------------- next part -------------- An HTML attachment was scrubbed... URL: From gshilin at kbb1.com Sat Dec 20 22:19:11 2008 From: gshilin at kbb1.com (gshilin) Date: Sun, 21 Dec 2008 05:19:11 +0200 Subject: [Erector-devel] Difference in 0.5.1 Message-ID: <523BED5D31E848AEBF8B7C8CE8FF2C5E@bbdomain> Hi, I'm moving to Rails 2.2.2 and was quite happy to find out that Erector was already ported to this version. But then I've discovered that the following render :widget => widget, :tree_node => tree_node, :view_mode => params[:view_mode], :options => options, :layout => false just doesn't work anymore. Instead I should use @tree_node = tree_node @view_mode = params[:view_mode] @options = options @layout = false render :widget => widget This doesn't look as natural as it was before. Any ideas? Thanks, Gregory -------------- next part -------------- An HTML attachment was scrubbed... URL: From brian.takita at gmail.com Sun Dec 21 17:33:44 2008 From: brian.takita at gmail.com (Brian Takita) Date: Sun, 21 Dec 2008 17:33:44 -0500 Subject: [Erector-devel] Difference in 0.5.1 In-Reply-To: <523BED5D31E848AEBF8B7C8CE8FF2C5E@bbdomain> References: <523BED5D31E848AEBF8B7C8CE8FF2C5E@bbdomain> Message-ID: <1d7ddd110812211433u75b698fchfcffb0b34ab66e78@mail.gmail.com> On Sat, Dec 20, 2008 at 10:19 PM, gshilin wrote: > Hi, > > > > I'm moving to Rails 2.2.2 and was quite happy to find out that Erector was > already ported to this version. > > > > But then I've discovered that the following > > > > render :widget => widget, :tree_node => tree_node, :view_mode => > params[:view_mode], :options => options, :layout => false > > > > just doesn't work anymore. Instead I should use > > > > @tree_node = tree_node > > @view_mode = params[:view_mode] > > @options = options > > @layout = false > > render :widget => widget > > > > This doesn't look as natural as it was before? > > > > Any ideas? This is a bug. I created a ticket at bug at http://rubyforge.org/tracker/index.php?group_id=4797&atid=18570 > > > > Thanks, > > Gregory > > _______________________________________________ > Erector-devel mailing list > Erector-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/erector-devel > > From jeff at jwhitmire.com Mon Dec 22 09:37:09 2008 From: jeff at jwhitmire.com (Jeff Whitmire) Date: Mon, 22 Dec 2008 09:37:09 -0500 Subject: [Erector-devel] Merb port? Message-ID: <45c4ccc30812220637h6520b1eegb3842f31e2ac880e@mail.gmail.com> Anybody worked in getting erector to work with merb yet? I've got a couple of merb projects and I'm using haml at the moment just because I feel the need to get my head around it. I was curious about whether anyone had tried to use erector with merb yet. Jeff Whitmire Think. Learn. Be. Grockit, Inc. http://grockit.com -------------- next part -------------- An HTML attachment was scrubbed... URL: From brian.takita at gmail.com Mon Dec 22 10:56:33 2008 From: brian.takita at gmail.com (Brian Takita) Date: Mon, 22 Dec 2008 10:56:33 -0500 Subject: [Erector-devel] Merb port? In-Reply-To: <45c4ccc30812220637h6520b1eegb3842f31e2ac880e@mail.gmail.com> References: <45c4ccc30812220637h6520b1eegb3842f31e2ac880e@mail.gmail.com> Message-ID: <1d7ddd110812220756q2b355f61h5c5f325d45a024e6@mail.gmail.com> On Mon, Dec 22, 2008 at 9:37 AM, Jeff Whitmire wrote: > Anybody worked in getting erector to work with merb yet? I've got a couple > of merb projects and I'm using haml at the moment just because I feel the > need to get my head around it. I was curious about whether anyone had tried > to use erector with merb yet. Pat Maddox was working on Merb integration. I don't see a fork on his github page though. > Jeff Whitmire > Think. Learn. Be. > Grockit, Inc. > http://grockit.com > > _______________________________________________ > Erector-devel mailing list > Erector-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/erector-devel > >