From kingdon at panix.com Sat Sep 20 00:03:25 2008 From: kingdon at panix.com (Jim Kingdon) Date: Sat, 20 Sep 2008 00:03:25 -0400 (EDT) Subject: [Erector-devel] removing require 'erector' in Rakefile Message-ID: <20080920040325.E8329241DD@panix5.panix.com> I have moved the Erector::VERSION constant from lib/erector.rb to a file of its own, lib/erector/version.rb and included only the latter in Rakefile. That is an attempt to solve the problem described below: As for including geminstaller as a prerequisite, it already is for "rake cruise". It seems like it would be harmless to add it elsewhere, but I'm not sure where it would go. Geminstaller does seem to take something like 0.4 seconds on my machine, up to about 1.0 seconds with a cold cache (compared with about 13 seconds for "rake"). This is in response the following which I think was from Chad: I just had to run GemInstaller manually. The problem is the "require 'erector'" at the beginning of the rakefile outside of any task, which requires treetop, which was not installed. Not sure why you need this require. It would be cleaner to put the require inside of tasks as appropriate, and always make geminstaller task a prerequisite. This should not be any slower, geminstaller exits quickly with no remote calls if nothing needs to be installed. From thewoolleyman at gmail.com Sat Sep 20 04:04:45 2008 From: thewoolleyman at gmail.com (Chad Woolley) Date: Sat, 20 Sep 2008 01:04:45 -0700 Subject: [Erector-devel] removing require 'erector' in Rakefile In-Reply-To: <20080920040325.E8329241DD@panix5.panix.com> References: <20080920040325.E8329241DD@panix5.panix.com> Message-ID: If it is run by rake cruise, that is probably good enough, if not we'll find out. Might want to make an explicit documented geminstaller rake task so it is easier for hackers to find with rake -T. On Fri, Sep 19, 2008 at 9:03 PM, Jim Kingdon wrote: > I have moved the Erector::VERSION constant from lib/erector.rb to a > file of its own, lib/erector/version.rb and included only the latter > in Rakefile. That is an attempt to solve the problem described below: > > As for including geminstaller as a prerequisite, it already is for > "rake cruise". It seems like it would be harmless to add it > elsewhere, but I'm not sure where it would go. Geminstaller does seem > to take something like 0.4 seconds on my machine, up to about 1.0 > seconds with a cold cache (compared with about 13 seconds for "rake"). > > This is in response the following which I think was from Chad: > > I just had to run GemInstaller manually. > > The problem is the "require 'erector'" at the beginning of the > rakefile outside of any task, which requires treetop, which was not > installed. > > Not sure why you need this require. It would be cleaner to put the > require inside of tasks as appropriate, and always make geminstaller > task a prerequisite. This should not be any slower, geminstaller > exits quickly with no remote calls if nothing needs to be installed. > >