[Facebooker-talk] Rails 2.2 support

[Mike Mangino]

On Nov 19, 2008, at 2:59 PM, Victor Costan wrote:

> You already merged my changes that make Rails 2.2 happy. My app seems
> to work on 2.2RC2.

Okay, that's good to know. It looks like I just need to fix the tests  
then.

>
>
> There's one outstanding issue that doesn't have a nice, clear
> solution. As of 2.2, concat complains that it doesn't need a binding
> argument anymore, and the old use is deprecated. On the other hand,
> removing that argument will break anyone who's not on 2.2 yet.
>
> Possible solutions:
> 1) define our own method that calls concat and does the right thing
> depending on the version of rails
> 2) make a git branch for rails 2.2 changes, make the change below in  
> this branch
> 3) remove the binding argument everywhere and make people upgrade
> 4) do nothing

That's annoying. I'm okay with the warnings for now. If anyone feels  
strongly about it, they can create another level of indirection.

Mike

>
>
> Preferences?
>    Victor
>
>
>
> On Wed, Nov 19, 2008 at 10:10 AM, Mike Mangino
> <mmangino at elevatedrails.com> wrote:
>> I remember a while back that somebody had patches to make  
>> Facebooker work on
>> Rails 2.2. Are those still around? I'd like to get them merged over  
>> the next
>> couple of days.
>>
>> Mike
>>
>> --
>> Mike Mangino
>> http://www.elevatedrails.com
>>
>>
>>
>> _______________________________________________
>> Facebooker-talk mailing list
>> Facebooker-talk at rubyforge.org
>> http://rubyforge.org/mailman/listinfo/facebooker-talk
>>

--
Mike Mangino
http://www.elevatedrails.com