[libxml-devel] patch for memory leak

[Tom Bagby]

When you posted that you had applied the patch, I updated and nothing came down so I was confused.  I see that you have been very busy, awesome!  Anyway, some of those patches that I just sent are still applicable.

Should it be possible to build the gem on Windows with VC6 with what's checked into svn now?

Thanks so much,
Tom


-----Original Message-----
From: libxml-devel-bounces at rubyforge.org on behalf of Charlie Savage
Sent: Tue 7/1/2008 12:07 AM
To: libxml-devel at rubyforge.org
Subject: Re: [libxml-devel] patch for memory leak
 
Hi Tom,


> I found a memory leak when the value of an attribute is accessed.  Fix 
> is simple, in function ruby_xml_attr_value in ruby_xml_attr.c, need to 
> call xmlFree:
> 
> 356,357c356,360
> 
> <     if (value != NULL)
> 
> <       return(rb_str_new2((const char*)value));
> 
> ---
> 
>>     if (value != NULL) {
> 
>>       VALUE retVal = rb_str_new2((const char*)value);
> 
>>       xmlFree(value);
> 
>>       return(retVal);
> 

Thanks for the patch.  I've applied it, and found about 6 other places 
similar issues were happening.

Charlie


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/ms-tnef
Size: 3109 bytes
Desc: not available
URL: <http://rubyforge.org/pipermail/libxml-devel/attachments/20080702/167117d9/attachment.bin>