From langstefan at gmx.at Wed Apr 18 12:27:12 2007 From: langstefan at gmx.at (Stefan Lang) Date: Wed, 18 Apr 2007 18:27:12 +0200 Subject: [Rant] [Rant-cafe] Support for 1.9? In-Reply-To: <20070418111025.E27025240AD2@rubyforge.org> References: <20070418111025.E27025240AD2@rubyforge.org> Message-ID: <200704181827.12687.langstefan@gmx.at> On Wednesday 18 April 2007 13:04, Kevin Burge wrote: Hi, I used to test with 1.9 before releases. > I was wondering if anyone had tried Rant under 1.9. I have, and it > seems to work after either removing the colon from all "when" > clauses that are already multi-line, or replacing it with ";" or > "then" for "when" clauses that are on the same line. Can you create a patch? Stefan From kevin.burge at systemware.com Wed Apr 18 13:05:10 2007 From: kevin.burge at systemware.com (Kevin Burge) Date: Wed, 18 Apr 2007 12:05:10 -0500 Subject: [Rant] About the patch... Message-ID: <20070418170629.4986C5240A41@rubyforge.org> It appears that the reason the tests fail are related to ruby 1.9, not to the changes I made. Syntax checks out okay on all .rb .rant and Rakefiles. http://www.systemware.com/ From kevin.burge at systemware.com Wed Apr 18 13:00:50 2007 From: kevin.burge at systemware.com (Kevin Burge) Date: Wed, 18 Apr 2007 12:00:50 -0500 Subject: [Rant] [Rant-cafe] Support for 1.9? In-Reply-To: <200704181827.12687.langstefan@gmx.at> References: <20070418111025.E27025240AD2@rubyforge.org> <200704181827.12687.langstefan@gmx.at> Message-ID: <20070418170729.139DF5240AB0@rubyforge.org> Here's the patch. I ran the tests to see if it would pass the test suite, and it did not. I have not tried the patch on ruby 1.8. 240 tests, 999 assertions, 29 failures, 0 errors Stefan Lang wrote: > On Wednesday 18 April 2007 13:04, Kevin Burge wrote: > > Hi, > I used to test with 1.9 before releases. > > >> I was wondering if anyone had tried Rant under 1.9. I have, and it >> seems to work after either removing the colon from all "when" >> clauses that are already multi-line, or replacing it with ";" or >> "then" for "when" clauses that are on the same line. >> > > Can you create a patch? > > Stefan > _______________________________________________ > make-cafe mailing list > make-cafe at rubyforge.org > http://rubyforge.org/mailman/listinfo/make-cafe > > http://www.systemware.com/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/make-cafe/attachments/20070418/20d1cb24/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: rant.patch Type: text/x-patch Size: 14481 bytes Desc: not available Url : http://rubyforge.org/pipermail/make-cafe/attachments/20070418/20d1cb24/attachment.bin From langstefan at gmx.at Wed Apr 18 14:51:52 2007 From: langstefan at gmx.at (Stefan Lang) Date: Wed, 18 Apr 2007 20:51:52 +0200 Subject: [Rant] [Rant-cafe] Support for 1.9? In-Reply-To: <20070418170729.139DF5240AB0@rubyforge.org> References: <20070418111025.E27025240AD2@rubyforge.org> <200704181827.12687.langstefan@gmx.at> <20070418170729.139DF5240AB0@rubyforge.org> Message-ID: <200704182051.52395.langstefan@gmx.at> On Wednesday 18 April 2007 19:00, Kevin Burge wrote: > Here's the patch. > > I ran the tests to see if it would pass the test suite, and it did > not. I have not tried the patch on ruby 1.8. > > 240 tests, 999 assertions, 29 failures, 0 errors All tests pass on ruby 1.8.4 on my machine, so I've applied the patch. Thank you! Stefan From kevin.burge at systemware.com Wed Apr 18 15:23:46 2007 From: kevin.burge at systemware.com (Kevin Burge) Date: Wed, 18 Apr 2007 14:23:46 -0500 Subject: [Rant] [Rant-cafe] Support for 1.9? In-Reply-To: <200704182051.52395.langstefan@gmx.at> References: <20070418111025.E27025240AD2@rubyforge.org> <200704181827.12687.langstefan@gmx.at> <20070418170729.139DF5240AB0@rubyforge.org> <200704182051.52395.langstefan@gmx.at> Message-ID: <20070418192308.419585240BA9@rubyforge.org> One more patch: I have ruby19 built in my home dir, and $MANPATH is all inaccessible as a regular user. Apply the following patch to install to Ruby's Config::CONFIG['mandir'] if it's set. Bug Output: trying to install rant(1) manpage... install -c -m 0644 doc/rant.1 /usr/local/share/man/man1 rant: [ERROR] in file `/home/kevin/src/rant/Rantfile', line 217: Permission denied - /usr/local/share/man/man1 rant: [ERROR] Task `install' fail. rant aborted! Stefan Lang wrote: > On Wednesday 18 April 2007 19:00, Kevin Burge wrote: > >> Here's the patch. >> >> I ran the tests to see if it would pass the test suite, and it did >> not. I have not tried the patch on ruby 1.8. >> >> 240 tests, 999 assertions, 29 failures, 0 errors >> > > All tests pass on ruby 1.8.4 on my machine, so I've applied > the patch. > > Thank you! > > Stefan > _______________________________________________ > make-cafe mailing list > make-cafe at rubyforge.org > http://rubyforge.org/mailman/listinfo/make-cafe > > http://www.systemware.com/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/make-cafe/attachments/20070418/f4bf0a16/attachment-0001.html -------------- next part -------------- A non-text attachment was scrubbed... Name: man_fix.patch Type: text/x-patch Size: 601 bytes Desc: not available Url : http://rubyforge.org/pipermail/make-cafe/attachments/20070418/f4bf0a16/attachment-0001.bin From langstefan at gmx.at Wed Apr 18 16:14:15 2007 From: langstefan at gmx.at (Stefan Lang) Date: Wed, 18 Apr 2007 22:14:15 +0200 Subject: [Rant] [Rant-cafe] Support for 1.9? In-Reply-To: <20070418192308.419585240BA9@rubyforge.org> References: <20070418111025.E27025240AD2@rubyforge.org> <200704182051.52395.langstefan@gmx.at> <20070418192308.419585240BA9@rubyforge.org> Message-ID: <200704182214.15596.langstefan@gmx.at> On Wednesday 18 April 2007 21:23, Kevin Burge wrote: > One more patch: I have ruby19 built in my home dir, and $MANPATH is > all inaccessible as a regular user. Apply the following patch to > install to Ruby's Config::CONFIG['mandir'] if it's set. Applied. Thanks, Stefan