From nyarly at gmail.com Tue Jul 21 14:36:40 2009 From: nyarly at gmail.com (Judson Lester) Date: Tue, 21 Jul 2009 11:36:40 -0700 Subject: [Rake-devel] Multitask doesn't append scope to prereqs Message-ID: <8905c87a0907211136k2160e8e6i6c3b36d7806cd8d7@mail.gmail.com> I discovered recently to my chagrin that tasks created with "multitask" don't look for their prerequisites in the appropriate namespaces. The fix is incredibly simple and I think correct (unless there's an intended semantic that multitask :task => :other_task should always search for :other_task in the root namespace). I'd be happy to put a patch together - what's the preference for that? Judson -------------- next part -------------- An HTML attachment was scrubbed... URL: From jim.weirich at gmail.com Tue Jul 21 16:00:35 2009 From: jim.weirich at gmail.com (Jim Weirich) Date: Tue, 21 Jul 2009 21:00:35 +0100 Subject: [Rake-devel] Multitask doesn't append scope to prereqs In-Reply-To: <8905c87a0907211136k2160e8e6i6c3b36d7806cd8d7@mail.gmail.com> References: <8905c87a0907211136k2160e8e6i6c3b36d7806cd8d7@mail.gmail.com> Message-ID: On Jul 21, 2009, at 7:36 PM, Judson Lester wrote: > I discovered recently to my chagrin that tasks created with > "multitask" > don't look for their prerequisites in the appropriate namespaces. > The fix > is incredibly simple and I think correct (unless there's an intended > semantic that multitask :task => :other_task should always search for > :other_task in the root namespace). > > I'd be happy to put a patch together - what's the preference for that? A patch would be welcome. The best option is a pull request from github (against the env branch). Failing that, a regular patch file is acceptable (again, against the env branch is preferred). Patches with test cases are looked upon with extreme favor. Recording a ticket at http://onestepback.org/redmine will help make sure it doesn't fall off my map. -- -- Jim Weirich -- jim.weirich at gmail.com From nyarly at gmail.com Tue Jul 21 17:40:21 2009 From: nyarly at gmail.com (Judson Lester) Date: Tue, 21 Jul 2009 14:40:21 -0700 Subject: [Rake-devel] Multitask doesn't append scope to prereqs In-Reply-To: References: <8905c87a0907211136k2160e8e6i6c3b36d7806cd8d7@mail.gmail.com> Message-ID: <8905c87a0907211440r3ca494cbq1406b3989463e0a@mail.gmail.com> Right on. I'll see about getting that back to you in a couple of days. On Tue, Jul 21, 2009 at 1:00 PM, Jim Weirich wrote: > On Jul 21, 2009, at 7:36 PM, Judson Lester wrote: > > I discovered recently to my chagrin that tasks created with "multitask" >> don't look for their prerequisites in the appropriate namespaces. The fix >> is incredibly simple and I think correct (unless there's an intended >> semantic that multitask :task => :other_task should always search for >> :other_task in the root namespace). >> >> I'd be happy to put a patch together - what's the preference for that? >> > > > A patch would be welcome. The best option is a pull request from github > (against the env branch). Failing that, a regular patch file is acceptable > (again, against the env branch is preferred). Patches with test cases are > looked upon with extreme favor. > > Recording a ticket at http://onestepback.org/redmine will help make sure > it doesn't fall off my map. > > -- > -- Jim Weirich > -- jim.weirich at gmail.com > > _______________________________________________ > Rake-devel mailing list > Rake-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rake-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: