From nobody at rubyforge.org  Sat Dec  1 21:34:36 2007
From: nobody at rubyforge.org (nobody at rubyforge.org)
Date: Sat,  1 Dec 2007 21:34:36 -0500 (EST)
Subject: [Raven-devel] [199] branches/v1.x/lib/raven/java_tasks.rb: JUnit
 task fix to customize test patterns.
Message-ID: <20071202023436.92FB618585BF@rubyforge.org>

An HTML attachment was scrubbed...
URL: http://rubyforge.org/pipermail/raven-devel/attachments/20071201/991f5a2d/attachment.html 

From nobody at rubyforge.org  Sun Dec  2 20:11:12 2007
From: nobody at rubyforge.org (nobody at rubyforge.org)
Date: Sun,  2 Dec 2007 20:11:12 -0500 (EST)
Subject: [Raven-devel] [200] branches/v1.x: JRuby on Windows fixes.
Message-ID: <20071203011112.3D66B18585C7@rubyforge.org>

An HTML attachment was scrubbed...
URL: http://rubyforge.org/pipermail/raven-devel/attachments/20071202/4d354831/attachment.html 

From akiyoshi.ochiai at gmail.com  Sun Dec 23 23:28:48 2007
From: akiyoshi.ochiai at gmail.com (Akiyoshi OCHIAI)
Date: Mon, 24 Dec 2007 13:28:48 +0900
Subject: [Raven-devel] JarTask's manifest option(-m) handling bug in v1.x
Message-ID: <775e94bd0712232028g35607ad5td527f71a9cdb1d1c@mail.gmail.com>

Hi,

The "jar" command has "tar"-style option.
At present JarTask builds a command string like:

  jar -cf NAME -m MANIFEST ...

But it should be:

  jar -cfm NAME MANIFEST ...

I wrote a small patch to fix this:

--- v1.x/lib/raven/java_tasks.rb.orig	2007-12-24 10:25:38.000000000 +0900
+++ v1.x/lib/raven/java_tasks.rb	2007-12-24 10:30:17.000000000 +0900
@@ -129,10 +129,16 @@
         latest = Raven.latest_file('target/classes')

         # Manifest inclusion
-        mfest_param = @manifest ? "-m #{@manifest}" : ""
+        if @manifest
+          mfest_param = @manifest
+          mfest_flag = "m"
+        else
+          mfest_param = ""
+          mfest_flag = ""
+        end

         if !File.exist?("target/#{name}") ||
File.stat("target/#{name}").mtime < latest
-          `jar -cf target/#{name} #{mfest_param} -C target/classes .`
+          `jar -cf#{mfest_flag} target/#{name} #{mfest_param} -C
target/classes .`
           puts "Built jar file #{name}." if RakeFileUtils.verbose_flag
         else
           puts 'Nothing to do, jar is fresh enough.' if
RakeFileUtils.verbose_flag

From nobody at rubyforge.org  Mon Dec 24 08:28:03 2007
From: nobody at rubyforge.org (nobody at rubyforge.org)
Date: Mon, 24 Dec 2007 08:28:03 -0500 (EST)
Subject: [Raven-devel] [201] branches/v1.x/lib/raven/java_tasks.rb: Applying
 Akiyoshi OCHIAI patch for jar manifest fix.
Message-ID: <20071224132803.E224118585D6@rubyforge.org>

An HTML attachment was scrubbed...
URL: http://rubyforge.org/pipermail/raven-devel/attachments/20071224/032bcf7e/attachment.html 

From matthieu at offthelip.org  Mon Dec 24 08:29:50 2007
From: matthieu at offthelip.org (Matthieu Riou)
Date: Mon, 24 Dec 2007 05:29:50 -0800
Subject: [Raven-devel] JarTask's manifest option(-m) handling bug in v1.x
In-Reply-To: <775e94bd0712232028g35607ad5td527f71a9cdb1d1c@mail.gmail.com>
References: <775e94bd0712232028g35607ad5td527f71a9cdb1d1c@mail.gmail.com>
Message-ID: <fbdc6a970712240529o7d277ecexde585723200e5639@mail.gmail.com>

Hi Akiyoshi,

Thanks a lot for the patch, I've just applied it on the Raven 1.x branch.
Just svn update and you should get it.

Thanks again,
Matthieu

On Dec 23, 2007 8:28 PM, Akiyoshi OCHIAI <akiyoshi.ochiai at gmail.com> wrote:

> Hi,
>
> The "jar" command has "tar"-style option.
> At present JarTask builds a command string like:
>
>  jar -cf NAME -m MANIFEST ...
>
> But it should be:
>
>  jar -cfm NAME MANIFEST ...
>
> I wrote a small patch to fix this:
>
> --- v1.x/lib/raven/java_tasks.rb.orig   2007-12-24 10:25:38.000000000+0900
> +++ v1.x/lib/raven/java_tasks.rb        2007-12-24 10:30:17.000000000+0900
> @@ -129,10 +129,16 @@
>         latest = Raven.latest_file('target/classes')
>
>         # Manifest inclusion
> -        mfest_param = @manifest ? "-m #{@manifest}" : ""
> +        if @manifest
> +          mfest_param = @manifest
> +          mfest_flag = "m"
> +        else
> +          mfest_param = ""
> +          mfest_flag = ""
> +        end
>
>         if !File.exist?("target/#{name}") ||
> File.stat("target/#{name}").mtime < latest
> -          `jar -cf target/#{name} #{mfest_param} -C target/classes .`
> +          `jar -cf#{mfest_flag} target/#{name} #{mfest_param} -C
> target/classes .`
>           puts "Built jar file #{name}." if RakeFileUtils.verbose_flag
>         else
>           puts 'Nothing to do, jar is fresh enough.' if
> RakeFileUtils.verbose_flag
> _______________________________________________
> Raven-devel mailing list
> Raven-devel at rubyforge.org
> http://rubyforge.org/mailman/listinfo/raven-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://rubyforge.org/pipermail/raven-devel/attachments/20071224/737d1ebe/attachment.html