From m at rebooten.de Thu Jun 12 20:18:02 2008 From: m at rebooten.de (Markus Boelter) Date: Thu, 12 Jun 2008 17:18:02 -0700 Subject: Bug with multiple "!!!" Message-ID: Hi! I discovered a bug in the latest stable RedCloth release where multiple "!!!" are not handled correctly. The bug seems related to line 1118 in redcloth.rb. Old version: next if prop == 'src' and attrv !~ /^http/ New version: next if prop == 'src' and attrv =~ %r{^(?!http)\w+:} Even in the old version, the string "?!?!?" is not processed correctly and gives only "??" as output. The new version crashed with an error. Anyone an idea? Cheers, Markus From jg at jasongarber.com Mon Jun 16 17:35:23 2008 From: jg at jasongarber.com (Jason Garber) Date: Mon, 16 Jun 2008 17:35:23 -0400 Subject: Bug with multiple "!!!" In-Reply-To: References: Message-ID: <863E5150-D745-408F-AB62-4535081EB088@jasongarber.com> This is in RedCloth 3.0.4, I take it? On Jun 12, 2008, at 8:18 PM, Markus Boelter wrote: > Hi! > > I discovered a bug in the latest stable RedCloth release where > multiple "!!!" are not handled correctly. The bug seems related to > line 1118 in redcloth.rb. > > Old version: > next if prop == 'src' and attrv !~ /^http/ > > New version: > next if prop == 'src' and attrv =~ %r{^(?!http)\w+:} > > Even in the old version, the string "?!?!?" is not processed > correctly and gives only "??" as output. The new version crashed > with an error. > > Anyone an idea? > > Cheers, > Markus > _______________________________________________ > Redcloth-upwards mailing list > Redcloth-upwards at rubyforge.org > http://rubyforge.org/mailman/listinfo/redcloth-upwards From m at rebooten.de Mon Jun 16 18:38:21 2008 From: m at rebooten.de (Markus Boelter) Date: Mon, 16 Jun 2008 15:38:21 -0700 Subject: Bug with multiple "!!!" In-Reply-To: <863E5150-D745-408F-AB62-4535081EB088@jasongarber.com> References: <863E5150-D745-408F-AB62-4535081EB088@jasongarber.com> Message-ID: <5AEEA2EE-6F7F-407B-BE6B-6246D27A7581@rebooten.de> Hi! On Jun 16, 2008, at 2:35 PM, Jason Garber wrote: > This is in RedCloth 3.0.4, I take it? Yes, it is Thanks, Markus From jg at jasongarber.com Thu Jun 19 17:29:34 2008 From: jg at jasongarber.com (Jason Garber) Date: Thu, 19 Jun 2008 17:29:34 -0400 Subject: Latest benchmarks Message-ID: <189BAE5F-58DC-44A9-9290-619D079BC95E@jasongarber.com> Rehearsal -------------------------------------------------- RedCloth 3.328 0.050000 0.000000 0.050000 ( 0.053957) RedCloth 3.0.4 1.670000 0.010000 1.680000 ( 1.701113) ----------------------------------------- total: 1.730000sec user system total real RedCloth 3.328 0.040000 0.000000 0.040000 ( 0.043745) RedCloth 3.0.4 1.650000 0.010000 1.660000 ( 1.672715) Is it fair to say the new version is 40 times faster? Math was never my strongest subject. :-) Jason -------------- next part -------------- An HTML attachment was scrubbed... URL: From snk at gna.org Fri Jun 20 13:10:12 2008 From: snk at gna.org (Suraj N. Kurapati) Date: Fri, 20 Jun 2008 10:10:12 -0700 Subject: Latest benchmarks In-Reply-To: <189BAE5F-58DC-44A9-9290-619D079BC95E@jasongarber.com> References: <189BAE5F-58DC-44A9-9290-619D079BC95E@jasongarber.com> Message-ID: <485BE474.1030606@gna.org> Jason Garber wrote: > Rehearsal -------------------------------------------------- > RedCloth 3.328 0.050000 0.000000 0.050000 ( 0.053957) > RedCloth 3.0.4 1.670000 0.010000 1.680000 ( 1.701113) > ----------------------------------------- total: 1.730000sec > > user system total real > RedCloth 3.328 0.040000 0.000000 0.040000 ( 0.043745) > RedCloth 3.0.4 1.650000 0.010000 1.660000 ( 1.672715) > > Is it fair to say the new version is 40 times faster? Math was never my > strongest subject. :-) The equation for speedup is time_old / time_new: rehearsal_speedup = 1.701113 / 0.053957 = 31.5271975832607 real_speedup = 1.672715 / 0.043745 = 38.2378557549434 So yes, the new version is roughly 40 times faster. From failed_artist at yahoo.com Sun Jun 22 00:01:51 2008 From: failed_artist at yahoo.com (failed artist) Date: Sat, 21 Jun 2008 21:01:51 -0700 (PDT) Subject: problem characters Message-ID: <740423.2685.qm@web59607.mail.ac4.yahoo.com> hey all new to the list. we're using redcloth 3.0.4 on a live website i'm finding some characters are causing 'stack level too deep' errors.... i'm not sure which character exactly, but i think one of the following is the problem ??? ?? ??? ??? is this a problem which can be fixed in redcloth and if not have you got any suggestions on how I can control our users? do we need to scrape the error characters or can redcloth do that for us? thanks ahead -------------- next part -------------- An HTML attachment was scrubbed... URL: From jason at hybd.net Sun Jun 22 14:54:07 2008 From: jason at hybd.net (Jase) Date: Sun, 22 Jun 2008 19:54:07 +0100 Subject: problem characters In-Reply-To: <740423.2685.qm@web59607.mail.ac4.yahoo.com> References: <740423.2685.qm@web59607.mail.ac4.yahoo.com> Message-ID: <1214160847.4338.8.camel@jase-ubuntu> As far as I know, RedCloth 3.0.4 bugs are being ignored in favour of the the new 4.0 version that's just round the corner (as 4.0 fixes most of these). I suggest you replace your RedCloth with the new version at https://code.whytheluckystiff.net/redcloth/wiki/SuperRedCloth gem install RedCloth --source http://code.whytheluckystiff.net ^ should do the trick. I wouldn't use the bleeding edge version in git yet because there are a couple of bugs I've just reported relating to links (I think other Jason probably knows this from failing test cases tbh) and latex formatting (Not to mention you need a recent copy of Ragel too) >From what I can see the new RedCloth seems to handle UTF-8 encoding, so it should sort out your issues. Jase On Sat, 2008-06-21 at 21:01 -0700, failed artist wrote: > hey all > > new to the list. we're using redcloth 3..0.4 on a live website > > i'm finding some characters are causing 'stack level too deep' > errors... i'm not sure which character exactly, but i think one of the > following is the problem > > ??? > ?? > ??? > ??? > > > is this a problem which can be fixed in redcloth and if not have you > got any suggestions on how I can control our users? do we need to > scrape the error characters or can redcloth do that for us? > > thanks ahead > > > _______________________________________________ > Redcloth-upwards mailing list > Redcloth-upwards at rubyforge.org > http://rubyforge.org/mailman/listinfo/redcloth-upwards From jg at jasongarber.com Wed Jun 25 14:46:36 2008 From: jg at jasongarber.com (Jason Garber) Date: Wed, 25 Jun 2008 14:46:36 -0400 Subject: problem characters In-Reply-To: <740423.2685.qm@web59607.mail.ac4.yahoo.com> References: <740423.2685.qm@web59607.mail.ac4.yahoo.com> Message-ID: <61C7C354-4DF2-4A4A-B876-16C66949BE76@jasongarber.com> Have you tried the 4.0 pre-release testing gems? They're a little out of date, but it should still give you a good idea of whether it will work in RedCloth 4 or not. On Jun 22, 2008, at 12:01 AM, failed artist wrote: > hey all > > new to the list. we're using redcloth 3..0.4 on a live website > > i'm finding some characters are causing 'stack level too deep' > errors... i'm not sure which character exactly, but i think one of > the following is the problem > > ??? > ?? > ??? > ??? > > > is this a problem which can be fixed in redcloth and if not have you > got any suggestions on how I can control our users? do we need to > scrape the error characters or can redcloth do that for us? > > thanks ahead > > _______________________________________________ > Redcloth-upwards mailing list > Redcloth-upwards at rubyforge.org > http://rubyforge.org/mailman/listinfo/redcloth-upwards -------------- next part -------------- An HTML attachment was scrubbed... URL: