From aslak.hellesoy at gmail.com Sat Dec 1 08:06:07 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Sat, 1 Dec 2007 14:06:07 +0100 Subject: [rspec-devel] christmas cleaning Message-ID: <8d961d900712010506y342130e4jebe5c566e26358ae@mail.gmail.com> hi all, we've all been cleaning up and deleting crufty code lately - good! i'd like to continue this so we get a leaner and faster codebase. suggestions: 1) Options It has too many references to various things. I'd like to make it know less and move the references to the objects that use them instead of asking options 2) Reporter It's an unnecessary middleman. The classes talking to it should talk directly with the formatters instead and we should delete Reporter. Instead of getting options through the constructor it's cleaner to pass an array of formatters to the various run/execute methods. 3) Example I'd like to merge this class with ExampleMethods and get rid of Example. This requires some changes in SharedExampleGroup. 4) Lazy loading In order to run faster we should require files as needed. We don't need to load all the formatters. There may be other classes too. 5) Move circularly dependent classes in expectations and matchers into one directory. These are the things off the top of my head. Thoughts? Aslak From dchelimsky at gmail.com Sat Dec 1 10:07:41 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Sat, 1 Dec 2007 10:07:41 -0500 Subject: [rspec-devel] christmas cleaning In-Reply-To: <8d961d900712010506y342130e4jebe5c566e26358ae@mail.gmail.com> References: <8d961d900712010506y342130e4jebe5c566e26358ae@mail.gmail.com> Message-ID: <57c63afe0712010707y5061ea89xa4abac847a8e80cb@mail.gmail.com> On Dec 1, 2007 8:06 AM, aslak hellesoy wrote: > hi all, > > we've all been cleaning up and deleting crufty code lately - good! > > i'd like to continue this so we get a leaner and faster codebase. suggestions: > > 1) Options > It has too many references to various things. I'd like to make it know > less and move the references to the objects that use them instead of > asking options +1 > 2) Reporter > It's an unnecessary middleman. The classes talking to it should talk > directly with the formatters instead and we should delete Reporter. > Instead of getting options through the constructor it's cleaner to > pass an array of formatters to the various run/execute methods. +1 This is how the Story Runner already works. It lets you register listeners. The ones it uses ignore everything they're not interested in w/ method_missing. I wonder if we can have a single html formatter that serves both stories and examples. Especially now that we have nested example groups. > > 3) Example > I'd like to merge this class with ExampleMethods and get rid of > Example. This requires some changes in SharedExampleGroup. +1 We've discussed this off-line, so to fill everyone else in ... we now have two concepts for sharing: nested example groups and shared example groups. The difference is that shared groups share before/after, helper methods and examples, whereas nested groups share everything but the examples. If we define methods instead of storing examples, we can simply inherit everything and pass down a lists of methods to run and not to run. This would align these mechanisms and simplify things a great deal. We started in this direction but discovered that auto-generated example docstrings didn't work any more (e.g. specify {foo.should == bar ). I have an idea of how we can solve that (other than removing the feature :) ) > 4) Lazy loading > In order to run faster we should require files as needed. We don't > need to load all the formatters. There may be other classes too. +1 > > 5) Move circularly dependent classes in expectations and matchers into > one directory. -1 Circular dependencies are a problem in things that get deployed as separate packages, not just because they're in separate directories. I don't think this is a problem here. And it's nice to have things separated. Merging these would buy us nothing and add confusion, IMHO. > > These are the things off the top of my head. Thoughts? > > Aslak > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From aslak.hellesoy at gmail.com Sat Dec 1 10:52:08 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Sat, 1 Dec 2007 16:52:08 +0100 Subject: [rspec-devel] christmas cleaning In-Reply-To: <57c63afe0712010707y5061ea89xa4abac847a8e80cb@mail.gmail.com> References: <8d961d900712010506y342130e4jebe5c566e26358ae@mail.gmail.com> <57c63afe0712010707y5061ea89xa4abac847a8e80cb@mail.gmail.com> Message-ID: <8d961d900712010752u2c943b5fk3c514883a6a4588d@mail.gmail.com> On Dec 1, 2007 4:07 PM, David Chelimsky wrote: > On Dec 1, 2007 8:06 AM, aslak hellesoy wrote: > > hi all, > > > > we've all been cleaning up and deleting crufty code lately - good! > > > > i'd like to continue this so we get a leaner and faster codebase. suggestions: > > > > 1) Options > > It has too many references to various things. I'd like to make it know > > less and move the references to the objects that use them instead of > > asking options > > +1 > > > 2) Reporter > > It's an unnecessary middleman. The classes talking to it should talk > > directly with the formatters instead and we should delete Reporter. > > Instead of getting options through the constructor it's cleaner to > > pass an array of formatters to the various run/execute methods. > > +1 > > This is how the Story Runner already works. It lets you register > listeners. The ones it uses ignore everything they're not interested > in w/ method_missing. > > I wonder if we can have a single html formatter that serves both > stories and examples. Especially now that we have nested example > groups. > > > > > 3) Example > > I'd like to merge this class with ExampleMethods and get rid of > > Example. This requires some changes in SharedExampleGroup. > > +1 > > We've discussed this off-line, so to fill everyone else in ... we now > have two concepts for sharing: nested example groups and shared > example groups. The difference is that shared groups share > before/after, helper methods and examples, whereas nested groups share > everything but the examples. > > If we define methods instead of storing examples, we can simply > inherit everything and pass down a lists of methods to run and not to > run. This would align these mechanisms and simplify things a great > deal. > > We started in this direction but discovered that auto-generated > example docstrings didn't work any more (e.g. specify {foo.should == > bar ). I have an idea of how we can solve that (other than removing > the feature :) ) > > > 4) Lazy loading > > In order to run faster we should require files as needed. We don't > > need to load all the formatters. There may be other classes too. > > +1 > The story framework is no longer loaded by require 'spec' - it has to be loaded explicitly with require 'spec/story'. Further - formatters are loaded lazily and transparently. This had a huge impact on the startup time :-) Aslak > > > > 5) Move circularly dependent classes in expectations and matchers into > > one directory. > > -1 > > Circular dependencies are a problem in things that get deployed as > separate packages, not just because they're in separate directories. I > don't think this is a problem here. And it's nice to have things > separated. Merging these would buy us nothing and add confusion, IMHO. > > > > > These are the things off the top of my head. Thoughts? > > > > Aslak > > _______________________________________________ > > rspec-devel mailing list > > rspec-devel at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-devel > > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From undees at gmail.com Mon Dec 3 00:57:30 2007 From: undees at gmail.com (Ian Dees) Date: Sun, 2 Dec 2007 21:57:30 -0800 Subject: [rspec-devel] StoryRunner backtrace Message-ID: Hi, all. The default run_options for StoryRunner seem to include the quiet backtrace tweaker, but I still end up with a huge backtrace for something as simple as a failed Scenario. Would it be useful for me to add some kind of flag to (optionally) cull the dozens and dozens of lines between Spec::Expectations::ExpectationNotMetError: expected: 6, got: 5 (using ==) and a_story.rb:22 ? Would the most RSpec-like approach be another backtrace tweaker class, or a config option, or...? --Ian From dchelimsky at gmail.com Tue Dec 4 07:21:28 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 4 Dec 2007 06:21:28 -0600 Subject: [rspec-devel] StoryRunner backtrace In-Reply-To: References: Message-ID: <57c63afe0712040421i42e1b5fdnd5ed8c836152d52a@mail.gmail.com> On Dec 2, 2007 11:57 PM, Ian Dees wrote: > Hi, all. > > The default run_options for StoryRunner seem to include the quiet > backtrace tweaker, but I still end up with a huge backtrace for > something as simple as a failed Scenario. Would it be useful for me > to add some kind of flag to (optionally) cull the dozens and dozens of > lines between > > Spec::Expectations::ExpectationNotMetError: expected: 6, > got: 5 (using ==) > > and > > a_story.rb:22 > > ? Would the most RSpec-like approach be another backtrace tweaker > class, or a config option, or...? If you'd like to contribute something for this, I'd say a separate tweaker for scenario backtraces is probably the right thing. I wouldn't necessarily want to remove all of the lines in there. There are useful bits like the name of the step that show up as well. So we might have to play w/ the details a bit. But please feel free to get it rolling w/ a ticket at http://rspec.lighthouseapp.com. Cheers, David > > --Ian > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From nicksieger at gmail.com Wed Dec 5 15:40:03 2007 From: nicksieger at gmail.com (Nick Sieger) Date: Wed, 5 Dec 2007 14:40:03 -0600 Subject: [rspec-devel] JRuby + RSpec CI again Message-ID: Hey guys, We have a long-dormant JRuby + RSpec CI build that I'd like to get going again. The previous build configuration sucked because it didn't watch changes to the RSpec repository. Well, the build I set up now does, but there's one little problem holding me back: RCov. So would you consider applying the attached patch to the Rakefile? After that, there are still some issues preventing RSpec from being green on JRuby, but hopefully with better visibility someone will be able to patch the result. I'd be happy to host a CI build for RSpec on MRI as extra incentive... Cheers, /Nick -------------- next part -------------- A non-text attachment was scrubbed... Name: Rakefile.patch Type: application/octet-stream Size: 685 bytes Desc: not available Url : http://rubyforge.org/pipermail/rspec-devel/attachments/20071205/38e9b5d6/attachment.obj From dchelimsky at gmail.com Wed Dec 5 15:57:32 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 5 Dec 2007 14:57:32 -0600 Subject: [rspec-devel] JRuby + RSpec CI again In-Reply-To: References: Message-ID: <57c63afe0712051257o3bf3a074p1e96174fb8e68b43@mail.gmail.com> On Dec 5, 2007 2:40 PM, Nick Sieger wrote: > Hey guys, > > We have a long-dormant JRuby + RSpec CI build that I'd like to get > going again. The previous build configuration sucked because it didn't > watch changes to the RSpec repository. > > Well, the build I set up now does, but there's one little problem > holding me back: RCov. So would you consider applying the attached > patch to the Rakefile? > > After that, there are still some issues preventing RSpec from being > green on JRuby, but hopefully with better visibility someone will be > able to patch the result. > > I'd be happy to host a CI build for RSpec on MRI as extra incentive... Applied the patch (r3055). Thanks. I'll follow up later about CI. We've got a plan formulating, and we could definitely use your help. Cheers, David > > Cheers, > /Nick > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From aslak.hellesoy at gmail.com Wed Dec 5 16:23:33 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Wed, 5 Dec 2007 22:23:33 +0100 Subject: [rspec-devel] JRuby + RSpec CI again In-Reply-To: <57c63afe0712051257o3bf3a074p1e96174fb8e68b43@mail.gmail.com> References: <57c63afe0712051257o3bf3a074p1e96174fb8e68b43@mail.gmail.com> Message-ID: <8d961d900712051323m350071c3sbdee052d70c8bdd0@mail.gmail.com> On Dec 5, 2007 9:57 PM, David Chelimsky wrote: > > On Dec 5, 2007 2:40 PM, Nick Sieger wrote: > > Hey guys, > > > > We have a long-dormant JRuby + RSpec CI build that I'd like to get > > going again. The previous build configuration sucked because it didn't > > watch changes to the RSpec repository. > > It's excellent if you can fire it up again. I'll try to fix any bugs in the next week or so. > > Well, the build I set up now does, but there's one little problem > > holding me back: RCov. So would you consider applying the attached > > patch to the Rakefile? > > > > After that, there are still some issues preventing RSpec from being > > green on JRuby, but hopefully with better visibility someone will be > > able to patch the result. > > > > I'd be happy to host a CI build for RSpec on MRI as extra incentive... > > Applied the patch (r3055). Thanks. > > I'll follow up later about CI. We've got a plan formulating, and we > could definitely use your help. > But this plan might take a while to materialise, so in the meanwhile it would be great to have your Bamboo run RSpec with JRuby (and MRI if it's not too much work). When we get our own up we can always phase out your gear. Aslak > Cheers, > David > > > > > Cheers, > > /Nick > > > > _______________________________________________ > > rspec-devel mailing list > > rspec-devel at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-devel > > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From nicksieger at gmail.com Thu Dec 6 11:08:30 2007 From: nicksieger at gmail.com (Nick Sieger) Date: Thu, 6 Dec 2007 10:08:30 -0600 Subject: [rspec-devel] JRuby + RSpec CI again In-Reply-To: <8d961d900712051323m350071c3sbdee052d70c8bdd0@mail.gmail.com> References: <57c63afe0712051257o3bf3a074p1e96174fb8e68b43@mail.gmail.com> <8d961d900712051323m350071c3sbdee052d70c8bdd0@mail.gmail.com> Message-ID: On 12/5/07, aslak hellesoy wrote: > > It's excellent if you can fire it up again. I'll try to fix any bugs > in the next week or so. Consider it fired up. Only 6 failures, not as bad as I thought! http://jruby.thresher.com/browse/RSPEC-TRUNK My ci_reporter utility doesn't appear to work too well w/ RSpec trunk (I'll have to look at that some other time), so the builds don't report test failures -- you'll have to go look at the build logs. > > But this plan might take a while to materialise, so in the meanwhile > it would be great to have your Bamboo run RSpec with JRuby (and MRI if > it's not too much work). > > When we get our own up we can always phase out your gear. > The MRI build is also up: http://jruby.thresher.com/browse/RSPEC-MRI It currently is showing 2 failures, is that what you'd expect? 1222 examples, 2 failures, 7 pending Let me know if anything looks fishy. Solaris has known to exhibit strange environmental differences for us. /Nick From dchelimsky at gmail.com Thu Dec 6 11:26:52 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 6 Dec 2007 10:26:52 -0600 Subject: [rspec-devel] JRuby + RSpec CI again In-Reply-To: References: <57c63afe0712051257o3bf3a074p1e96174fb8e68b43@mail.gmail.com> <8d961d900712051323m350071c3sbdee052d70c8bdd0@mail.gmail.com> Message-ID: <57c63afe0712060826p62b7ee78j6044dcfadb77e7c7@mail.gmail.com> On Dec 6, 2007 10:08 AM, Nick Sieger wrote: > On 12/5/07, aslak hellesoy wrote: > > > > It's excellent if you can fire it up again. I'll try to fix any bugs > > in the next week or so. > > Consider it fired up. Only 6 failures, not as bad as I thought! > > http://jruby.thresher.com/browse/RSPEC-TRUNK > > My ci_reporter utility doesn't appear to work too well w/ RSpec trunk > (I'll have to look at that some other time), so the builds don't > report test failures -- you'll have to go look at the build logs. > > > > > But this plan might take a while to materialise, so in the meanwhile > > it would be great to have your Bamboo run RSpec with JRuby (and MRI if > > it's not too much work). > > > > When we get our own up we can always phase out your gear. > > > > The MRI build is also up: > > http://jruby.thresher.com/browse/RSPEC-MRI > > It currently is showing 2 failures, is that what you'd expect? No. Should be 0 failures. Looking at http://jruby.thresher.com/build/viewBuildLog.action?buildNumber=15&buildKey=RSPEC-MRI, I see that the failures are related to the formatters. This is no surprise because, due to differences in the way different Ruby versions print backtraces, we have "gold masters" for Rubies 1.8.4, 1.8.5, 1.8.6 and jruby. My guess is that the most recent updates simply didn't make it to the for whatever version of ruby you're running. So what version of Ruby are you running? > > 1222 examples, 2 failures, 7 pending > > Let me know if anything looks fishy. Solaris has known to exhibit > strange environmental differences for us. > > > /Nick > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From nicksieger at gmail.com Thu Dec 6 11:37:49 2007 From: nicksieger at gmail.com (Nick Sieger) Date: Thu, 6 Dec 2007 10:37:49 -0600 Subject: [rspec-devel] JRuby + RSpec CI again In-Reply-To: <57c63afe0712060826p62b7ee78j6044dcfadb77e7c7@mail.gmail.com> References: <57c63afe0712051257o3bf3a074p1e96174fb8e68b43@mail.gmail.com> <8d961d900712051323m350071c3sbdee052d70c8bdd0@mail.gmail.com> <57c63afe0712060826p62b7ee78j6044dcfadb77e7c7@mail.gmail.com> Message-ID: On 12/6/07, David Chelimsky wrote: > On Dec 6, 2007 10:08 AM, Nick Sieger wrote: > > http://jruby.thresher.com/browse/RSPEC-MRI > > > > It currently is showing 2 failures, is that what you'd expect? > > No. Should be 0 failures. Looking at > http://jruby.thresher.com/build/viewBuildLog.action?buildNumber=15&buildKey=RSPEC-MRI, > I see that the failures are related to the formatters. This is no > surprise because, due to differences in the way different Ruby > versions print backtraces, we have "gold masters" for Rubies 1.8.4, > 1.8.5, 1.8.6 and jruby. > > My guess is that the most recent updates simply didn't make it to the > for whatever version of ruby you're running. So what version of Ruby > are you running? The latest patchlevel: $ ruby -v ruby 1.8.6 (2007-09-23 patchlevel 110) [i386-solaris2.8] /Nick From dchelimsky at gmail.com Thu Dec 6 16:09:17 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 6 Dec 2007 15:09:17 -0600 Subject: [rspec-devel] JRuby + RSpec CI again In-Reply-To: References: <57c63afe0712051257o3bf3a074p1e96174fb8e68b43@mail.gmail.com> <8d961d900712051323m350071c3sbdee052d70c8bdd0@mail.gmail.com> <57c63afe0712060826p62b7ee78j6044dcfadb77e7c7@mail.gmail.com> Message-ID: <57c63afe0712061309i7fe1a489u495c2f1d30e1d1bd@mail.gmail.com> On Dec 6, 2007 10:37 AM, Nick Sieger wrote: > On 12/6/07, David Chelimsky wrote: > > On Dec 6, 2007 10:08 AM, Nick Sieger wrote: > > > http://jruby.thresher.com/browse/RSPEC-MRI > > > > > > It currently is showing 2 failures, is that what you'd expect? > > > > No. Should be 0 failures. Looking at > > http://jruby.thresher.com/build/viewBuildLog.action?buildNumber=15&buildKey=RSPEC-MRI, > > I see that the failures are related to the formatters. This is no > > surprise because, due to differences in the way different Ruby > > versions print backtraces, we have "gold masters" for Rubies 1.8.4, > > 1.8.5, 1.8.6 and jruby. > > > > My guess is that the most recent updates simply didn't make it to the > > for whatever version of ruby you're running. So what version of Ruby > > are you running? > > The latest patchlevel: > > $ ruby -v > ruby 1.8.6 (2007-09-23 patchlevel 110) [i386-solaris2.8] Hey Nick - this is pretty silly, but in the backtrace you can see this: gem install syntax to get syntax highlighting That's why it's failing. Can you install the syntax gem on that box? Should solve the problem. Thanks, David > > > /Nick > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From aslak.hellesoy at gmail.com Thu Dec 6 16:10:42 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Thu, 6 Dec 2007 22:10:42 +0100 Subject: [rspec-devel] JRuby + RSpec CI again In-Reply-To: References: <57c63afe0712051257o3bf3a074p1e96174fb8e68b43@mail.gmail.com> <8d961d900712051323m350071c3sbdee052d70c8bdd0@mail.gmail.com> <57c63afe0712060826p62b7ee78j6044dcfadb77e7c7@mail.gmail.com> Message-ID: <8d961d900712061310p314e1afeka5dec0cf1822c5fb@mail.gmail.com> On Dec 6, 2007 5:37 PM, Nick Sieger wrote: > On 12/6/07, David Chelimsky wrote: > > On Dec 6, 2007 10:08 AM, Nick Sieger wrote: > > > http://jruby.thresher.com/browse/RSPEC-MRI > > > > > > It currently is showing 2 failures, is that what you'd expect? > > > > No. Should be 0 failures. Looking at > > http://jruby.thresher.com/build/viewBuildLog.action?buildNumber=15&buildKey=RSPEC-MRI, > > I see that the failures are related to the formatters. This is no > > surprise because, due to differences in the way different Ruby > > versions print backtraces, we have "gold masters" for Rubies 1.8.4, > > 1.8.5, 1.8.6 and jruby. > > > > My guess is that the most recent updates simply didn't make it to the > > for whatever version of ruby you're running. So what version of Ruby > > are you running? > > The latest patchlevel: > > $ ruby -v > ruby 1.8.6 (2007-09-23 patchlevel 110) [i386-solaris2.8] > David just spotted it. Can you gem install syntax? That should fix it. Aslak > > /Nick > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From nicksieger at gmail.com Thu Dec 6 16:34:52 2007 From: nicksieger at gmail.com (Nick Sieger) Date: Thu, 6 Dec 2007 15:34:52 -0600 Subject: [rspec-devel] JRuby + RSpec CI again In-Reply-To: <57c63afe0712061309i7fe1a489u495c2f1d30e1d1bd@mail.gmail.com> References: <57c63afe0712051257o3bf3a074p1e96174fb8e68b43@mail.gmail.com> <8d961d900712051323m350071c3sbdee052d70c8bdd0@mail.gmail.com> <57c63afe0712060826p62b7ee78j6044dcfadb77e7c7@mail.gmail.com> <57c63afe0712061309i7fe1a489u495c2f1d30e1d1bd@mail.gmail.com> Message-ID: On 12/6/07, David Chelimsky wrote: > > Hey Nick - this is pretty silly, but in the backtrace you can see this: > > gem install syntax to get syntax highlighting > > That's why it's failing. Can you install the syntax gem on that box? > Should solve the problem. Got it. Also installed a couple of other dependencies mentioned in pre_commit. I noticed one that may be missing -- ZenTest, no? (Already installed, BTW.) /Nick From dchelimsky at gmail.com Fri Dec 7 09:58:13 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 7 Dec 2007 08:58:13 -0600 Subject: [rspec-devel] help please Message-ID: <57c63afe0712070658y5f240572rb1fe0c6ac77e110a@mail.gmail.com> Hey all, Rails just got tagged 2.0.0, and then 2.0.1. Unfortunately, it includes a changeset from yesterday that breaks rspec's pre_commit task. I do not have cycles to address this until tonight, and I suspect that everyone is going to be grabbing the 2.0.1 release and become sad when RSpec won't work with it. If any of you (especially Josh Knowles, who added the feature to rails that is breaking rspec :), care to come up w/ a patch I can take the few minutes necessary to get it in to trunk. http://rspec.lighthouseapp.com/projects/5645/tickets/171 http://dev.rubyonrails.org/changeset/8324 http://dev.rubyonrails.org/ticket/10377 Cheers, David From chad at spicycode.com Fri Dec 7 10:06:26 2007 From: chad at spicycode.com (Chad Humphries) Date: Fri, 7 Dec 2007 10:06:26 -0500 Subject: [rspec-devel] help please In-Reply-To: <57c63afe0712070658y5f240572rb1fe0c6ac77e110a@mail.gmail.com> References: <57c63afe0712070658y5f240572rb1fe0c6ac77e110a@mail.gmail.com> Message-ID: <7740A3AD-32F0-4B12-BF1F-1390DB5D2542@spicycode.com> I'll take a peek at it. - Chad On Dec 7, 2007, at 9:58 AM, David Chelimsky wrote: > Hey all, > > Rails just got tagged 2.0.0, and then 2.0.1. Unfortunately, it > includes a changeset from yesterday that breaks rspec's pre_commit > task. I do not have cycles to address this until tonight, and I > suspect that everyone is going to be grabbing the 2.0.1 release and > become sad when RSpec won't work with it. > > If any of you (especially Josh Knowles, who added the feature to rails > that is breaking rspec :), care to come up w/ a patch I can take the > few minutes necessary to get it in to trunk. > > http://rspec.lighthouseapp.com/projects/5645/tickets/171 > http://dev.rubyonrails.org/changeset/8324 > http://dev.rubyonrails.org/ticket/10377 > > Cheers, > David > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel From dchelimsky at gmail.com Fri Dec 7 10:09:32 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 7 Dec 2007 09:09:32 -0600 Subject: [rspec-devel] help please In-Reply-To: <7740A3AD-32F0-4B12-BF1F-1390DB5D2542@spicycode.com> References: <57c63afe0712070658y5f240572rb1fe0c6ac77e110a@mail.gmail.com> <7740A3AD-32F0-4B12-BF1F-1390DB5D2542@spicycode.com> Message-ID: <57c63afe0712070709o280c5f0do50e79c46d51dc7be@mail.gmail.com> On Dec 7, 2007 9:06 AM, Chad Humphries wrote: > I'll take a peek at it. The failure is only when running against rails edge or 2.0.0 cd example_rails_app rake -f Multirails.rake pre_commit HTH > > - Chad > > > On Dec 7, 2007, at 9:58 AM, David Chelimsky wrote: > > > Hey all, > > > > Rails just got tagged 2.0.0, and then 2.0.1. Unfortunately, it > > includes a changeset from yesterday that breaks rspec's pre_commit > > task. I do not have cycles to address this until tonight, and I > > suspect that everyone is going to be grabbing the 2.0.1 release and > > become sad when RSpec won't work with it. > > > > If any of you (especially Josh Knowles, who added the feature to rails > > that is breaking rspec :), care to come up w/ a patch I can take the > > few minutes necessary to get it in to trunk. > > > > http://rspec.lighthouseapp.com/projects/5645/tickets/171 > > http://dev.rubyonrails.org/changeset/8324 > > http://dev.rubyonrails.org/ticket/10377 > > > > Cheers, > > David > > _______________________________________________ > > rspec-devel mailing list > > rspec-devel at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-devel > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From chad at spicycode.com Fri Dec 7 10:15:02 2007 From: chad at spicycode.com (Chad Humphries) Date: Fri, 7 Dec 2007 10:15:02 -0500 Subject: [rspec-devel] help please In-Reply-To: <57c63afe0712070709o280c5f0do50e79c46d51dc7be@mail.gmail.com> References: <57c63afe0712070658y5f240572rb1fe0c6ac77e110a@mail.gmail.com> <7740A3AD-32F0-4B12-BF1F-1390DB5D2542@spicycode.com> <57c63afe0712070709o280c5f0do50e79c46d51dc7be@mail.gmail.com> Message-ID: Cool, one of our internal apps is on edge rails via externals, so I'll test in that. - Chad On Dec 7, 2007, at 10:09 AM, David Chelimsky wrote: > On Dec 7, 2007 9:06 AM, Chad Humphries wrote: >> I'll take a peek at it. > > The failure is only when running against rails edge or 2.0.0 > > cd example_rails_app > rake -f Multirails.rake pre_commit > > HTH > >> >> - Chad >> >> >> On Dec 7, 2007, at 9:58 AM, David Chelimsky wrote: >> >>> Hey all, >>> >>> Rails just got tagged 2.0.0, and then 2.0.1. Unfortunately, it >>> includes a changeset from yesterday that breaks rspec's pre_commit >>> task. I do not have cycles to address this until tonight, and I >>> suspect that everyone is going to be grabbing the 2.0.1 release and >>> become sad when RSpec won't work with it. >>> >>> If any of you (especially Josh Knowles, who added the feature to >>> rails >>> that is breaking rspec :), care to come up w/ a patch I can take the >>> few minutes necessary to get it in to trunk. >>> >>> http://rspec.lighthouseapp.com/projects/5645/tickets/171 >>> http://dev.rubyonrails.org/changeset/8324 >>> http://dev.rubyonrails.org/ticket/10377 >>> >>> Cheers, >>> David >>> _______________________________________________ >>> rspec-devel mailing list >>> rspec-devel at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/rspec-devel >> >> _______________________________________________ >> rspec-devel mailing list >> rspec-devel at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-devel >> > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel From dchelimsky at gmail.com Fri Dec 7 10:47:54 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 7 Dec 2007 09:47:54 -0600 Subject: [rspec-devel] help please In-Reply-To: References: <57c63afe0712070658y5f240572rb1fe0c6ac77e110a@mail.gmail.com> <7740A3AD-32F0-4B12-BF1F-1390DB5D2542@spicycode.com> <57c63afe0712070709o280c5f0do50e79c46d51dc7be@mail.gmail.com> Message-ID: <57c63afe0712070747n564e03e0gc4e2ddfddfd4f0ec@mail.gmail.com> On Dec 7, 2007 9:15 AM, Chad Humphries wrote: > Cool, one of our internal apps is on edge rails via externals, so I'll > test in that. FYI - the problem is specifically with running rspec's examples for rails. It may not appear in your app. > > - Chad > > > On Dec 7, 2007, at 10:09 AM, David Chelimsky wrote: > > > On Dec 7, 2007 9:06 AM, Chad Humphries wrote: > >> I'll take a peek at it. > > > > The failure is only when running against rails edge or 2.0.0 > > > > cd example_rails_app > > rake -f Multirails.rake pre_commit > > > > HTH > > > >> > >> - Chad > >> > >> > >> On Dec 7, 2007, at 9:58 AM, David Chelimsky wrote: > >> > >>> Hey all, > >>> > >>> Rails just got tagged 2.0.0, and then 2.0.1. Unfortunately, it > >>> includes a changeset from yesterday that breaks rspec's pre_commit > >>> task. I do not have cycles to address this until tonight, and I > >>> suspect that everyone is going to be grabbing the 2.0.1 release and > >>> become sad when RSpec won't work with it. > >>> > >>> If any of you (especially Josh Knowles, who added the feature to > >>> rails > >>> that is breaking rspec :), care to come up w/ a patch I can take the > >>> few minutes necessary to get it in to trunk. > >>> > >>> http://rspec.lighthouseapp.com/projects/5645/tickets/171 > >>> http://dev.rubyonrails.org/changeset/8324 > >>> http://dev.rubyonrails.org/ticket/10377 > >>> > >>> Cheers, > >>> David > >>> _______________________________________________ > >>> rspec-devel mailing list > >>> rspec-devel at rubyforge.org > >>> http://rubyforge.org/mailman/listinfo/rspec-devel > >> > >> _______________________________________________ > >> rspec-devel mailing list > >> rspec-devel at rubyforge.org > >> http://rubyforge.org/mailman/listinfo/rspec-devel > >> > > _______________________________________________ > > rspec-devel mailing list > > rspec-devel at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-devel > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From chad at spicycode.com Fri Dec 7 10:59:09 2007 From: chad at spicycode.com (Chad Humphries) Date: Fri, 7 Dec 2007 10:59:09 -0500 Subject: [rspec-devel] help please In-Reply-To: <57c63afe0712070747n564e03e0gc4e2ddfddfd4f0ec@mail.gmail.com> References: <57c63afe0712070658y5f240572rb1fe0c6ac77e110a@mail.gmail.com> <7740A3AD-32F0-4B12-BF1F-1390DB5D2542@spicycode.com> <57c63afe0712070709o280c5f0do50e79c46d51dc7be@mail.gmail.com> <57c63afe0712070747n564e03e0gc4e2ddfddfd4f0ec@mail.gmail.com> Message-ID: <86534203-F608-4F1B-AA27-93D8A8B44D6A@spicycode.com> Yep, I found that and submitted a patch for it. It seems some routing specs are failing as well on edge. I'll look at those after lunch. - Chad On Dec 7, 2007, at 10:47 AM, David Chelimsky wrote: > On Dec 7, 2007 9:15 AM, Chad Humphries wrote: >> Cool, one of our internal apps is on edge rails via externals, so >> I'll >> test in that. > > FYI - the problem is specifically with running rspec's examples for > rails. It may not appear in your app. > >> >> - Chad >> >> >> On Dec 7, 2007, at 10:09 AM, David Chelimsky wrote: >> >>> On Dec 7, 2007 9:06 AM, Chad Humphries wrote: >>>> I'll take a peek at it. >>> >>> The failure is only when running against rails edge or 2.0.0 >>> >>> cd example_rails_app >>> rake -f Multirails.rake pre_commit >>> >>> HTH >>> >>>> >>>> - Chad >>>> >>>> >>>> On Dec 7, 2007, at 9:58 AM, David Chelimsky wrote: >>>> >>>>> Hey all, >>>>> >>>>> Rails just got tagged 2.0.0, and then 2.0.1. Unfortunately, it >>>>> includes a changeset from yesterday that breaks rspec's pre_commit >>>>> task. I do not have cycles to address this until tonight, and I >>>>> suspect that everyone is going to be grabbing the 2.0.1 release >>>>> and >>>>> become sad when RSpec won't work with it. >>>>> >>>>> If any of you (especially Josh Knowles, who added the feature to >>>>> rails >>>>> that is breaking rspec :), care to come up w/ a patch I can take >>>>> the >>>>> few minutes necessary to get it in to trunk. >>>>> >>>>> http://rspec.lighthouseapp.com/projects/5645/tickets/171 >>>>> http://dev.rubyonrails.org/changeset/8324 >>>>> http://dev.rubyonrails.org/ticket/10377 >>>>> >>>>> Cheers, >>>>> David >>>>> _______________________________________________ >>>>> rspec-devel mailing list >>>>> rspec-devel at rubyforge.org >>>>> http://rubyforge.org/mailman/listinfo/rspec-devel >>>> >>>> _______________________________________________ >>>> rspec-devel mailing list >>>> rspec-devel at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/rspec-devel >>>> >>> _______________________________________________ >>> rspec-devel mailing list >>> rspec-devel at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/rspec-devel >> >> _______________________________________________ >> rspec-devel mailing list >> rspec-devel at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-devel >> > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel From joshknowles at gmail.com Fri Dec 7 14:20:33 2007 From: joshknowles at gmail.com (Josh Knowles) Date: Fri, 7 Dec 2007 14:20:33 -0500 Subject: [rspec-devel] help please In-Reply-To: <86534203-F608-4F1B-AA27-93D8A8B44D6A@spicycode.com> References: <57c63afe0712070658y5f240572rb1fe0c6ac77e110a@mail.gmail.com> <7740A3AD-32F0-4B12-BF1F-1390DB5D2542@spicycode.com> <57c63afe0712070709o280c5f0do50e79c46d51dc7be@mail.gmail.com> <57c63afe0712070747n564e03e0gc4e2ddfddfd4f0ec@mail.gmail.com> <86534203-F608-4F1B-AA27-93D8A8B44D6A@spicycode.com> Message-ID: On 12/7/07, Chad Humphries wrote: > Yep, I found that and submitted a patch for it. It seems some routing > specs are failing as well on edge. I'll look at those after lunch. Sorry!!!! Chad let me know if you don't have time as I can take care of it this afternoon if you're busy. -- Josh Knowles phone: 509-979-1593 email: joshknowles at gmail.com web: http://joshknowles.com From dchelimsky at gmail.com Fri Dec 7 14:24:08 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 7 Dec 2007 13:24:08 -0600 Subject: [rspec-devel] help please In-Reply-To: References: <57c63afe0712070658y5f240572rb1fe0c6ac77e110a@mail.gmail.com> <7740A3AD-32F0-4B12-BF1F-1390DB5D2542@spicycode.com> <57c63afe0712070709o280c5f0do50e79c46d51dc7be@mail.gmail.com> <57c63afe0712070747n564e03e0gc4e2ddfddfd4f0ec@mail.gmail.com> <86534203-F608-4F1B-AA27-93D8A8B44D6A@spicycode.com> Message-ID: <57c63afe0712071124t3032341bo86ca933fae7da5f2@mail.gmail.com> On Dec 7, 2007 1:20 PM, Josh Knowles wrote: > On 12/7/07, Chad Humphries wrote: > > Yep, I found that and submitted a patch for it. It seems some routing > > specs are failing as well on edge. I'll look at those after lunch. > > Sorry!!!! :) It's a cool feature for 99% of the world. Just not for our screwy pre-commit task. > > Chad let me know if you don't have time as I can take care of it this > afternoon if you're busy. We got it fixed. Thanks. > > -- > Josh Knowles > phone: 509-979-1593 > email: joshknowles at gmail.com > web: http://joshknowles.com > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From dchelimsky at gmail.com Fri Dec 7 14:32:49 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 7 Dec 2007 13:32:49 -0600 Subject: [rspec-devel] rspec_on_rails (trunk - r3070) works with Rails 2.0.1 Message-ID: <57c63afe0712071132w2dbb6f4aqb6fc01ddd1a9c904@mail.gmail.com> After a couple of quick fixes this morning, rspec_on_rails (in trunk as of rev 3070) now works correctly with Rails 2.0.1 Now that Rails 2.0 is out, we'll try to get an RSpec 1.1 release candidate out the door in the next few days. Cheers, David From james.deville at gmail.com Fri Dec 7 19:01:47 2007 From: james.deville at gmail.com (James Deville) Date: Fri, 7 Dec 2007 16:01:47 -0800 Subject: [rspec-devel] rspec_on_rails (trunk - r3070) works with Rails 2.0.1 In-Reply-To: <57c63afe0712071132w2dbb6f4aqb6fc01ddd1a9c904@mail.gmail.com> References: <57c63afe0712071132w2dbb6f4aqb6fc01ddd1a9c904@mail.gmail.com> Message-ID: <4C8191A4-7409-4104-868C-4A3D70162CE8@gmail.com> I'm getting an error with this fix. My versions: rspec:3072 rspec_on_rails:3073 rails:2.0.1. Formatter in this case is Specdoc The odd part is that debugger is telling me that BaseFormatter, BaseTextFormatter and SpecdocFormatter all take one argument. I don't have the gem installed, so I'm not sure where Ruby is getting that from, as the code shows 2, options and where. Any advice on where to look, or what other information I can give you? Jim D Aragorn:mydna james$ rake spec (in /Users/james/projects/mydna) /Users/james/projects/mydna/app/models/asset.rb:23: warning: Object#id will be deprecated; use Object#object_id ./spec/models/mailers/person_notifier_spec.rb:41: warning: already initialized constant FIXTURES_PATH ./spec/models/mailers/person_notifier_spec.rb:42: warning: already initialized constant CHARSET ./spec/models/mailers/feedback_notifier_spec.rb:4: warning: already initialized constant FIXTURES_PATH ./spec/models/mailers/feedback_notifier_spec.rb:5: warning: already initialized constant CHARSET /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ options.rb:151:in `initialize': wrong number of arguments (2 for 1) (ArgumentError) from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ options.rb:151:in `new' from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ options.rb:151:in `formatters' from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ options.rb:144:in `map' from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ options.rb:144:in `formatters' from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ reporter.rb:71:in `formatters' from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ reporter.rb:58:in `dump' from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ example_group_runner.rb:37:in `finish' from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ example_group_runner.rb:26:in `run' from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ options.rb:85:in `run_examples' from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ command_line.rb:19:in `run' from /Users/james/projects/mydna/vendor/plugins/rspec/bin/spec:3 rake aborted! On Dec 7, 2007, at 11:32 AM, David Chelimsky wrote: > After a couple of quick fixes this morning, rspec_on_rails (in trunk > as of rev 3070) now works correctly with Rails 2.0.1 > > Now that Rails 2.0 is out, we'll try to get an RSpec 1.1 release > candidate out the door in the next few days. > > Cheers, > David > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel From dchelimsky at gmail.com Fri Dec 7 19:06:01 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 7 Dec 2007 18:06:01 -0600 Subject: [rspec-devel] rspec_on_rails (trunk - r3070) works with Rails 2.0.1 In-Reply-To: <4C8191A4-7409-4104-868C-4A3D70162CE8@gmail.com> References: <57c63afe0712071132w2dbb6f4aqb6fc01ddd1a9c904@mail.gmail.com> <4C8191A4-7409-4104-868C-4A3D70162CE8@gmail.com> Message-ID: <57c63afe0712071606l27bac993t8eb303e8352c104e@mail.gmail.com> On Dec 7, 2007 6:01 PM, James Deville wrote: > I'm getting an error with this fix. My versions: rspec:3072 > rspec_on_rails:3073 You've got 2 different revisions of rspec, 3072 and 3073. Can you align those and try again? > rails:2.0.1. Formatter in this case is Specdoc > > The odd part is that debugger is telling me that BaseFormatter, > BaseTextFormatter and SpecdocFormatter all take one argument. I don't > have the gem installed, so I'm not sure where Ruby is getting that > from, as the code shows 2, options and where. > > Any advice on where to look, or what other information I can give you? > > Jim D > > > Aragorn:mydna james$ rake spec > (in /Users/james/projects/mydna) > /Users/james/projects/mydna/app/models/asset.rb:23: warning: Object#id > will be deprecated; use Object#object_id > ./spec/models/mailers/person_notifier_spec.rb:41: warning: already > initialized constant FIXTURES_PATH > ./spec/models/mailers/person_notifier_spec.rb:42: warning: already > initialized constant CHARSET > ./spec/models/mailers/feedback_notifier_spec.rb:4: warning: already > initialized constant FIXTURES_PATH > ./spec/models/mailers/feedback_notifier_spec.rb:5: warning: already > initialized constant CHARSET > /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ > options.rb:151:in `initialize': wrong number of arguments (2 for 1) > (ArgumentError) > from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ > options.rb:151:in `new' > from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ > options.rb:151:in `formatters' > from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ > options.rb:144:in `map' > from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ > options.rb:144:in `formatters' > from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ > reporter.rb:71:in `formatters' > from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ > reporter.rb:58:in `dump' > from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ > example_group_runner.rb:37:in `finish' > from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ > example_group_runner.rb:26:in `run' > from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ > options.rb:85:in `run_examples' > from /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ > command_line.rb:19:in `run' > from /Users/james/projects/mydna/vendor/plugins/rspec/bin/spec:3 > rake aborted! > > > On Dec 7, 2007, at 11:32 AM, David Chelimsky wrote: > > > After a couple of quick fixes this morning, rspec_on_rails (in trunk > > as of rev 3070) now works correctly with Rails 2.0.1 > > > > Now that Rails 2.0 is out, we'll try to get an RSpec 1.1 release > > candidate out the door in the next few days. > > > > Cheers, > > David > > _______________________________________________ > > rspec-devel mailing list > > rspec-devel at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-devel > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From james.deville at gmail.com Fri Dec 7 19:18:41 2007 From: james.deville at gmail.com (James Deville) Date: Fri, 7 Dec 2007 16:18:41 -0800 Subject: [rspec-devel] rspec_on_rails (trunk - r3070) works with Rails 2.0.1 In-Reply-To: <57c63afe0712071606l27bac993t8eb303e8352c104e@mail.gmail.com> References: <57c63afe0712071132w2dbb6f4aqb6fc01ddd1a9c904@mail.gmail.com> <4C8191A4-7409-4104-868C-4A3D70162CE8@gmail.com> <57c63afe0712071606l27bac993t8eb303e8352c104e@mail.gmail.com> Message-ID: <9C5EA583-E613-41B7-82B3-5B3C56EC59CD@gmail.com> No change. Jim On Dec 7, 2007, at 4:06 PM, David Chelimsky wrote: > On Dec 7, 2007 6:01 PM, James Deville wrote: >> I'm getting an error with this fix. My versions: rspec:3072 >> rspec_on_rails:3073 > > You've got 2 different revisions of rspec, 3072 and 3073. Can you > align those and try again? > >> rails:2.0.1. Formatter in this case is Specdoc >> >> The odd part is that debugger is telling me that BaseFormatter, >> BaseTextFormatter and SpecdocFormatter all take one argument. I don't >> have the gem installed, so I'm not sure where Ruby is getting that >> from, as the code shows 2, options and where. >> >> Any advice on where to look, or what other information I can give >> you? >> >> Jim D >> >> >> Aragorn:mydna james$ rake spec >> (in /Users/james/projects/mydna) >> /Users/james/projects/mydna/app/models/asset.rb:23: warning: >> Object#id >> will be deprecated; use Object#object_id >> ./spec/models/mailers/person_notifier_spec.rb:41: warning: already >> initialized constant FIXTURES_PATH >> ./spec/models/mailers/person_notifier_spec.rb:42: warning: already >> initialized constant CHARSET >> ./spec/models/mailers/feedback_notifier_spec.rb:4: warning: already >> initialized constant FIXTURES_PATH >> ./spec/models/mailers/feedback_notifier_spec.rb:5: warning: already >> initialized constant CHARSET >> /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ >> options.rb:151:in `initialize': wrong number of arguments (2 for 1) >> (ArgumentError) >> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >> spec/runner/ >> options.rb:151:in `new' >> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >> spec/runner/ >> options.rb:151:in `formatters' >> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >> spec/runner/ >> options.rb:144:in `map' >> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >> spec/runner/ >> options.rb:144:in `formatters' >> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >> spec/runner/ >> reporter.rb:71:in `formatters' >> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >> spec/runner/ >> reporter.rb:58:in `dump' >> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >> spec/runner/ >> example_group_runner.rb:37:in `finish' >> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >> spec/runner/ >> example_group_runner.rb:26:in `run' >> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >> spec/runner/ >> options.rb:85:in `run_examples' >> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >> spec/runner/ >> command_line.rb:19:in `run' >> from /Users/james/projects/mydna/vendor/plugins/rspec/bin/ >> spec:3 >> rake aborted! >> >> >> On Dec 7, 2007, at 11:32 AM, David Chelimsky wrote: >> >>> After a couple of quick fixes this morning, rspec_on_rails (in trunk >>> as of rev 3070) now works correctly with Rails 2.0.1 >>> >>> Now that Rails 2.0 is out, we'll try to get an RSpec 1.1 release >>> candidate out the door in the next few days. >>> >>> Cheers, >>> David >>> _______________________________________________ >>> rspec-devel mailing list >>> rspec-devel at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/rspec-devel >> >> _______________________________________________ >> rspec-devel mailing list >> rspec-devel at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-devel >> > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel From pedrobelo at gmail.com Sat Dec 8 03:41:39 2007 From: pedrobelo at gmail.com (Pedro Mariano Belo) Date: Sat, 8 Dec 2007 00:41:39 -0800 Subject: [rspec-devel] RSpec Rails generators proposal Message-ID: <8b7646030712080041s2842b742i512b9d1e4641375c@mail.gmail.com> Hello guys, First of all thanks for this beautiful framework :) I'm just someone trying BDD and I have some ideas regarding RSpec Rails generators: It's great to have RSpec generators tied with Rails models, controllers and scaffolds -- but I think there's one kind of spec missing in there, one that should exist before all others: the single, decoupled spec. To quote Wikipedia, BDD "is a software development technique that questions the behavior of an application before and during the development process". And the problem is, right now we have no generator that allows us to write specs before the development process. We have to do a little of software design to figure out what models/controllers our application will require so we can start writing specs. So my proposal is: * Rename the current rspec generator to rspec_base or rspec_setup or something like this (btw, isn't it weird that the generator with the most generic and minimal name is the one used only once?) * Create a new rspec generator that receives one spec name as parameter and generates a minimal spec in spec/general Actually I did this already and I'm using it. So I normally begin projects running the generator with "script/generate rspec application_name". It generates the file spec/general/application_spec.rb, with: require File.dirname(__FILE__) + '/../spec_helper' describe 'Application name' do it 'should ...' end So I can quickly add examples and define a spec without thinking about models or controllers. Later, when generating a model, I normally move related examples from this general spec to the model spec and start adding blocks to define them. What do you guys think? I was going to send a patch but I couldn't do it because svn won't allow me to do all changes at once. So attached is my generators folder, compressed. And I never wrote a generator before so I'm sure this one sucks. But, anyways, it's working for me :) Thanks, Pedro -------------- next part -------------- A non-text attachment was scrubbed... Name: generators.zip Type: application/zip Size: 19959 bytes Desc: not available Url : http://rubyforge.org/pipermail/rspec-devel/attachments/20071208/b1005578/attachment-0001.zip From james.deville at gmail.com Sat Dec 8 23:41:56 2007 From: james.deville at gmail.com (James Deville) Date: Sat, 8 Dec 2007 20:41:56 -0800 Subject: [rspec-devel] Fwd: rspec_on_rails (trunk - r3070) works with Rails 2.0.1 References: <67C803D4-2F9D-4EED-B1ED-DC698F9E300A@gmail.com> Message-ID: <0AA03E13-A789-4D01-A27E-10E395B09CF9@gmail.com> Begin forwarded message: > From: James Deville > Date: December 7, 2007 4:39:29 PM PST > To: James Deville > Subject: Re: [rspec-devel] rspec_on_rails (trunk - r3070) works with > Rails 2.0.1 > > I think I just found it. I had rspec 1.0.8 unpacked as a gem in > vendor/gems > > However, now I am getting a test? spec before every group. I'll try > going to 3070 to see if it fixes the problem > > JD > On Dec 7, 2007, at 4:18 PM, James Deville wrote: > >> No change. >> >> Jim >> >> On Dec 7, 2007, at 4:06 PM, David Chelimsky wrote: >> >>> On Dec 7, 2007 6:01 PM, James Deville >>> wrote: >>>> I'm getting an error with this fix. My versions: rspec:3072 >>>> rspec_on_rails:3073 >>> >>> You've got 2 different revisions of rspec, 3072 and 3073. Can you >>> align those and try again? >>> >>>> rails:2.0.1. Formatter in this case is Specdoc >>>> >>>> The odd part is that debugger is telling me that BaseFormatter, >>>> BaseTextFormatter and SpecdocFormatter all take one argument. I >>>> don't >>>> have the gem installed, so I'm not sure where Ruby is getting that >>>> from, as the code shows 2, options and where. >>>> >>>> Any advice on where to look, or what other information I can give >>>> you? >>>> >>>> Jim D >>>> >>>> >>>> Aragorn:mydna james$ rake spec >>>> (in /Users/james/projects/mydna) >>>> /Users/james/projects/mydna/app/models/asset.rb:23: warning: >>>> Object#id >>>> will be deprecated; use Object#object_id >>>> ./spec/models/mailers/person_notifier_spec.rb:41: warning: already >>>> initialized constant FIXTURES_PATH >>>> ./spec/models/mailers/person_notifier_spec.rb:42: warning: already >>>> initialized constant CHARSET >>>> ./spec/models/mailers/feedback_notifier_spec.rb:4: warning: already >>>> initialized constant FIXTURES_PATH >>>> ./spec/models/mailers/feedback_notifier_spec.rb:5: warning: already >>>> initialized constant CHARSET >>>> /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ >>>> options.rb:151:in `initialize': wrong number of arguments (2 for 1) >>>> (ArgumentError) >>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>> spec/runner/ >>>> options.rb:151:in `new' >>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>> spec/runner/ >>>> options.rb:151:in `formatters' >>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>> spec/runner/ >>>> options.rb:144:in `map' >>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>> spec/runner/ >>>> options.rb:144:in `formatters' >>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>> spec/runner/ >>>> reporter.rb:71:in `formatters' >>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>> spec/runner/ >>>> reporter.rb:58:in `dump' >>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>> spec/runner/ >>>> example_group_runner.rb:37:in `finish' >>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>> spec/runner/ >>>> example_group_runner.rb:26:in `run' >>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>> spec/runner/ >>>> options.rb:85:in `run_examples' >>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>> spec/runner/ >>>> command_line.rb:19:in `run' >>>> from /Users/james/projects/mydna/vendor/plugins/rspec/bin/ >>>> spec:3 >>>> rake aborted! >>>> >>>> >>>> On Dec 7, 2007, at 11:32 AM, David Chelimsky wrote: >>>> >>>>> After a couple of quick fixes this morning, rspec_on_rails (in >>>>> trunk >>>>> as of rev 3070) now works correctly with Rails 2.0.1 >>>>> >>>>> Now that Rails 2.0 is out, we'll try to get an RSpec 1.1 release >>>>> candidate out the door in the next few days. >>>>> >>>>> Cheers, >>>>> David >>>>> _______________________________________________ >>>>> rspec-devel mailing list >>>>> rspec-devel at rubyforge.org >>>>> http://rubyforge.org/mailman/listinfo/rspec-devel >>>> >>>> _______________________________________________ >>>> rspec-devel mailing list >>>> rspec-devel at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/rspec-devel >>>> >>> _______________________________________________ >>> rspec-devel mailing list >>> rspec-devel at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/rspec-devel >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-devel/attachments/20071208/2e02e0a9/attachment.html From james.deville at gmail.com Sat Dec 8 23:42:03 2007 From: james.deville at gmail.com (James Deville) Date: Sat, 8 Dec 2007 20:42:03 -0800 Subject: [rspec-devel] Fwd: rspec_on_rails (trunk - r3070) works with Rails 2.0.1 References: <1865E5DA-99AF-4778-AEAA-868C45B184F3@gmail.com> Message-ID: Begin forwarded message: > From: James Deville > Date: December 7, 2007 5:00:30 PM PST > To: James Deville > Subject: Re: [rspec-devel] rspec_on_rails (trunk - r3070) works with > Rails 2.0.1 > > Nope, i'm now getting a test? spec before every group, it seems > related to the rspec_on_rails plugin. I'll take a look more at home, > but I would appreciate any help. > > Person with account > - test? > - should obviously show last login > ... > > Person model: A new Person > - test? > - should have an empty dna_contacts collection > ... > > > - test? > > > - test? > > > - test? (FAILED - 5) > > Spec::Rails::Example::FunctionalExampleGroup > - test? (ERROR - 6) > > > - test? > > Spec::Rails::Example::RailsExampleGroup > - test? > > Pending: > > > JD > > > > On Dec 7, 2007, at 4:39 PM, James Deville wrote: > >> I think I just found it. I had rspec 1.0.8 unpacked as a gem in >> vendor/gems >> >> However, now I am getting a test? spec before every group. I'll try >> going to 3070 to see if it fixes the problem >> >> JD >> On Dec 7, 2007, at 4:18 PM, James Deville wrote: >> >>> No change. >>> >>> Jim >>> >>> On Dec 7, 2007, at 4:06 PM, David Chelimsky wrote: >>> >>>> On Dec 7, 2007 6:01 PM, James Deville >>>> wrote: >>>>> I'm getting an error with this fix. My versions: rspec:3072 >>>>> rspec_on_rails:3073 >>>> >>>> You've got 2 different revisions of rspec, 3072 and 3073. Can you >>>> align those and try again? >>>> >>>>> rails:2.0.1. Formatter in this case is Specdoc >>>>> >>>>> The odd part is that debugger is telling me that BaseFormatter, >>>>> BaseTextFormatter and SpecdocFormatter all take one argument. I >>>>> don't >>>>> have the gem installed, so I'm not sure where Ruby is getting that >>>>> from, as the code shows 2, options and where. >>>>> >>>>> Any advice on where to look, or what other information I can >>>>> give you? >>>>> >>>>> Jim D >>>>> >>>>> >>>>> Aragorn:mydna james$ rake spec >>>>> (in /Users/james/projects/mydna) >>>>> /Users/james/projects/mydna/app/models/asset.rb:23: warning: >>>>> Object#id >>>>> will be deprecated; use Object#object_id >>>>> ./spec/models/mailers/person_notifier_spec.rb:41: warning: already >>>>> initialized constant FIXTURES_PATH >>>>> ./spec/models/mailers/person_notifier_spec.rb:42: warning: already >>>>> initialized constant CHARSET >>>>> ./spec/models/mailers/feedback_notifier_spec.rb:4: warning: >>>>> already >>>>> initialized constant FIXTURES_PATH >>>>> ./spec/models/mailers/feedback_notifier_spec.rb:5: warning: >>>>> already >>>>> initialized constant CHARSET >>>>> /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ >>>>> options.rb:151:in `initialize': wrong number of arguments (2 for >>>>> 1) >>>>> (ArgumentError) >>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>> spec/runner/ >>>>> options.rb:151:in `new' >>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>> spec/runner/ >>>>> options.rb:151:in `formatters' >>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>> spec/runner/ >>>>> options.rb:144:in `map' >>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>> spec/runner/ >>>>> options.rb:144:in `formatters' >>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>> spec/runner/ >>>>> reporter.rb:71:in `formatters' >>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>> spec/runner/ >>>>> reporter.rb:58:in `dump' >>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>> spec/runner/ >>>>> example_group_runner.rb:37:in `finish' >>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>> spec/runner/ >>>>> example_group_runner.rb:26:in `run' >>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>> spec/runner/ >>>>> options.rb:85:in `run_examples' >>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>> spec/runner/ >>>>> command_line.rb:19:in `run' >>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/bin/ >>>>> spec:3 >>>>> rake aborted! >>>>> >>>>> >>>>> On Dec 7, 2007, at 11:32 AM, David Chelimsky wrote: >>>>> >>>>>> After a couple of quick fixes this morning, rspec_on_rails (in >>>>>> trunk >>>>>> as of rev 3070) now works correctly with Rails 2.0.1 >>>>>> >>>>>> Now that Rails 2.0 is out, we'll try to get an RSpec 1.1 release >>>>>> candidate out the door in the next few days. >>>>>> >>>>>> Cheers, >>>>>> David >>>>>> _______________________________________________ >>>>>> rspec-devel mailing list >>>>>> rspec-devel at rubyforge.org >>>>>> http://rubyforge.org/mailman/listinfo/rspec-devel >>>>> >>>>> _______________________________________________ >>>>> rspec-devel mailing list >>>>> rspec-devel at rubyforge.org >>>>> http://rubyforge.org/mailman/listinfo/rspec-devel >>>>> >>>> _______________________________________________ >>>> rspec-devel mailing list >>>> rspec-devel at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/rspec-devel >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-devel/attachments/20071208/99d96125/attachment-0001.html From james.deville at gmail.com Sat Dec 8 23:47:24 2007 From: james.deville at gmail.com (James Deville) Date: Sat, 8 Dec 2007 20:47:24 -0800 Subject: [rspec-devel] rspec_on_rails (trunk - r3070) works with Rails 2.0.1 In-Reply-To: References: <1865E5DA-99AF-4778-AEAA-868C45B184F3@gmail.com> Message-ID: I figured most of it out. The Spec::Rails stuff was something in the code which has been fixed by revision 3099. The test methods partially make sense. Since the test/unit code has been integrated, methods with test in them are automatically turned into specs. However, the test? method is in a lib file that isn't directly loaded into the specs. It is a convenience method: def test?; RAILS_ENV=="test";end I don't know why this method is being included in my tests, every context has it as an example. Any ideas? Jim D On Dec 8, 2007, at 8:42 PM, James Deville wrote: > > > Begin forwarded message: > >> From: James Deville >> Date: December 7, 2007 5:00:30 PM PST >> To: James Deville >> Subject: Re: [rspec-devel] rspec_on_rails (trunk - r3070) works >> with Rails 2.0.1 >> >> Nope, i'm now getting a test? spec before every group, it seems >> related to the rspec_on_rails plugin. I'll take a look more at >> home, but I would appreciate any help. >> >> Person with account >> - test? >> - should obviously show last login >> ... >> >> Person model: A new Person >> - test? >> - should have an empty dna_contacts collection >> ... >> >> >> - test? >> >> >> - test? >> >> >> - test? (FAILED - 5) >> >> Spec::Rails::Example::FunctionalExampleGroup >> - test? (ERROR - 6) >> >> >> - test? >> >> Spec::Rails::Example::RailsExampleGroup >> - test? >> >> Pending: >> >> >> JD >> >> >> >> On Dec 7, 2007, at 4:39 PM, James Deville wrote: >> >>> I think I just found it. I had rspec 1.0.8 unpacked as a gem in >>> vendor/gems >>> >>> However, now I am getting a test? spec before every group. I'll >>> try going to 3070 to see if it fixes the problem >>> >>> JD >>> On Dec 7, 2007, at 4:18 PM, James Deville wrote: >>> >>>> No change. >>>> >>>> Jim >>>> >>>> On Dec 7, 2007, at 4:06 PM, David Chelimsky wrote: >>>> >>>>> On Dec 7, 2007 6:01 PM, James Deville >>>>> wrote: >>>>>> I'm getting an error with this fix. My versions: rspec:3072 >>>>>> rspec_on_rails:3073 >>>>> >>>>> You've got 2 different revisions of rspec, 3072 and 3073. Can you >>>>> align those and try again? >>>>> >>>>>> rails:2.0.1. Formatter in this case is Specdoc >>>>>> >>>>>> The odd part is that debugger is telling me that BaseFormatter, >>>>>> BaseTextFormatter and SpecdocFormatter all take one argument. I >>>>>> don't >>>>>> have the gem installed, so I'm not sure where Ruby is getting >>>>>> that >>>>>> from, as the code shows 2, options and where. >>>>>> >>>>>> Any advice on where to look, or what other information I can >>>>>> give you? >>>>>> >>>>>> Jim D >>>>>> >>>>>> >>>>>> Aragorn:mydna james$ rake spec >>>>>> (in /Users/james/projects/mydna) >>>>>> /Users/james/projects/mydna/app/models/asset.rb:23: warning: >>>>>> Object#id >>>>>> will be deprecated; use Object#object_id >>>>>> ./spec/models/mailers/person_notifier_spec.rb:41: warning: >>>>>> already >>>>>> initialized constant FIXTURES_PATH >>>>>> ./spec/models/mailers/person_notifier_spec.rb:42: warning: >>>>>> already >>>>>> initialized constant CHARSET >>>>>> ./spec/models/mailers/feedback_notifier_spec.rb:4: warning: >>>>>> already >>>>>> initialized constant FIXTURES_PATH >>>>>> ./spec/models/mailers/feedback_notifier_spec.rb:5: warning: >>>>>> already >>>>>> initialized constant CHARSET >>>>>> /Users/james/projects/mydna/vendor/plugins/rspec/lib/spec/runner/ >>>>>> options.rb:151:in `initialize': wrong number of arguments (2 >>>>>> for 1) >>>>>> (ArgumentError) >>>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>>> spec/runner/ >>>>>> options.rb:151:in `new' >>>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>>> spec/runner/ >>>>>> options.rb:151:in `formatters' >>>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>>> spec/runner/ >>>>>> options.rb:144:in `map' >>>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>>> spec/runner/ >>>>>> options.rb:144:in `formatters' >>>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>>> spec/runner/ >>>>>> reporter.rb:71:in `formatters' >>>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>>> spec/runner/ >>>>>> reporter.rb:58:in `dump' >>>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>>> spec/runner/ >>>>>> example_group_runner.rb:37:in `finish' >>>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>>> spec/runner/ >>>>>> example_group_runner.rb:26:in `run' >>>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>>> spec/runner/ >>>>>> options.rb:85:in `run_examples' >>>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/lib/ >>>>>> spec/runner/ >>>>>> command_line.rb:19:in `run' >>>>>> from /Users/james/projects/mydna/vendor/plugins/rspec/bin/ >>>>>> spec:3 >>>>>> rake aborted! >>>>>> >>>>>> >>>>>> On Dec 7, 2007, at 11:32 AM, David Chelimsky wrote: >>>>>> >>>>>>> After a couple of quick fixes this morning, rspec_on_rails (in >>>>>>> trunk >>>>>>> as of rev 3070) now works correctly with Rails 2.0.1 >>>>>>> >>>>>>> Now that Rails 2.0 is out, we'll try to get an RSpec 1.1 release >>>>>>> candidate out the door in the next few days. >>>>>>> >>>>>>> Cheers, >>>>>>> David >>>>>>> _______________________________________________ >>>>>>> rspec-devel mailing list >>>>>>> rspec-devel at rubyforge.org >>>>>>> http://rubyforge.org/mailman/listinfo/rspec-devel >>>>>> >>>>>> _______________________________________________ >>>>>> rspec-devel mailing list >>>>>> rspec-devel at rubyforge.org >>>>>> http://rubyforge.org/mailman/listinfo/rspec-devel >>>>>> >>>>> _______________________________________________ >>>>> rspec-devel mailing list >>>>> rspec-devel at rubyforge.org >>>>> http://rubyforge.org/mailman/listinfo/rspec-devel >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-devel/attachments/20071208/1bff0065/attachment-0001.html From cdemyanovich at gmail.com Sun Dec 9 10:09:03 2007 From: cdemyanovich at gmail.com (Craig Demyanovich) Date: Sun, 9 Dec 2007 10:09:03 -0500 Subject: [rspec-devel] [rspec-users] rspec_on_rails (trunk - r3070) works with Rails 2.0.1 In-Reply-To: References: <1865E5DA-99AF-4778-AEAA-868C45B184F3@gmail.com> Message-ID: <61c885db0712090709u3dd6e26an5b7aa0e7ddd9c316@mail.gmail.com> On Dec 8, 2007 11:47 PM, James Deville wrote: > I figured most of it out. The Spec::Rails stuff was something in the code > which has been fixed by revision 3099. The test methods partially make > sense. Since the test/unit code has been integrated, methods with test in > them are automatically turned into specs. However, the test? method is in a > lib file that isn't directly loaded into the specs. It is a convenience > method: def test?; RAILS_ENV=="test";end > I don't know why this method is being included in my tests, every context > has it as an example. Any ideas? > I have a couple ideas. If the lib file is on the load path, then maybe rspec is searching it. Also, re: the name, maybe rspec and/or test::unit is recognizing the method as a test because it begins with "test." Try renaming the method. Regards, Craig -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-devel/attachments/20071209/0da05940/attachment.html From brian.takita at gmail.com Tue Dec 11 12:46:43 2007 From: brian.takita at gmail.com (Brian Takita) Date: Tue, 11 Dec 2007 09:46:43 -0800 Subject: [rspec-devel] christmas cleaning In-Reply-To: <8d961d900712010752u2c943b5fk3c514883a6a4588d@mail.gmail.com> References: <8d961d900712010506y342130e4jebe5c566e26358ae@mail.gmail.com> <57c63afe0712010707y5061ea89xa4abac847a8e80cb@mail.gmail.com> <8d961d900712010752u2c943b5fk3c514883a6a4588d@mail.gmail.com> Message-ID: <1d7ddd110712110946t3e221c5dmf2a3691126ebc51f@mail.gmail.com> On Dec 1, 2007 7:52 AM, aslak hellesoy wrote: > > On Dec 1, 2007 4:07 PM, David Chelimsky wrote: > > On Dec 1, 2007 8:06 AM, aslak hellesoy wrote: > > > hi all, > > > > > > we've all been cleaning up and deleting crufty code lately - good! > > > > > > i'd like to continue this so we get a leaner and faster codebase. suggestions: > > > > > > 1) Options > > > It has too many references to various things. I'd like to make it know > > > less and move the references to the objects that use them instead of > > > asking options > > > > +1 > > > > > 2) Reporter > > > It's an unnecessary middleman. The classes talking to it should talk > > > directly with the formatters instead and we should delete Reporter. > > > Instead of getting options through the constructor it's cleaner to > > > pass an array of formatters to the various run/execute methods. > > > > +1 > > > > This is how the Story Runner already works. It lets you register > > listeners. The ones it uses ignore everything they're not interested > > in w/ method_missing. > > > > I wonder if we can have a single html formatter that serves both > > stories and examples. Especially now that we have nested example > > groups. > > > > > > > > 3) Example > > > I'd like to merge this class with ExampleMethods and get rid of > > > Example. This requires some changes in SharedExampleGroup. > > > > +1 > > > > We've discussed this off-line, so to fill everyone else in ... we now > > have two concepts for sharing: nested example groups and shared > > example groups. The difference is that shared groups share > > before/after, helper methods and examples, whereas nested groups share > > everything but the examples. > > > > If we define methods instead of storing examples, we can simply > > inherit everything and pass down a lists of methods to run and not to > > run. This would align these mechanisms and simplify things a great > > deal. > > > > We started in this direction but discovered that auto-generated > > example docstrings didn't work any more (e.g. specify {foo.should == > > bar ). I have an idea of how we can solve that (other than removing > > the feature :) ) > > > > > 4) Lazy loading > > > In order to run faster we should require files as needed. We don't > > > need to load all the formatters. There may be other classes too. > > > > +1 > > > > The story framework is no longer loaded by require 'spec' - it has to > be loaded explicitly with require 'spec/story'. > Further - formatters are loaded lazily and transparently. > > This had a huge impact on the startup time :-) Thats really surprising. Any ideas why just loading the story files and the formatters is so slow? One may argue thats its just simpler if everything is required. I don't know if its desirable or worth it, though. > > Aslak > > > > > > > > 5) Move circularly dependent classes in expectations and matchers into > > > one directory. > > > > -1 > > > > Circular dependencies are a problem in things that get deployed as > > separate packages, not just because they're in separate directories. I > > don't think this is a problem here. And it's nice to have things > > separated. Merging these would buy us nothing and add confusion, IMHO. > > > > > > > > These are the things off the top of my head. Thoughts? > > > > > > Aslak > > > _______________________________________________ > > > rspec-devel mailing list > > > rspec-devel at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-devel > > > > > _______________________________________________ > > rspec-devel mailing list > > rspec-devel at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-devel > > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From bob.cotton at rallydev.com Tue Dec 11 16:23:47 2007 From: bob.cotton at rallydev.com (Bob Cotton) Date: Tue, 11 Dec 2007 14:23:47 -0700 Subject: [rspec-devel] Fate of Reporters? Message-ID: Someone had mentioned a week or so ago about removing Spec::Runner::Reporter. I was about to start some work on spec_distributed, and was wondering if/when this was coming? Thanks - Bob From dchelimsky at gmail.com Tue Dec 11 17:50:28 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 11 Dec 2007 16:50:28 -0600 Subject: [rspec-devel] Fate of Reporters? In-Reply-To: References: Message-ID: <57c63afe0712111450j1604ed80g9d30bea83f67411d@mail.gmail.com> On Dec 11, 2007 3:23 PM, Bob Cotton wrote: > > Someone had mentioned a week or so ago about removing > Spec::Runner::Reporter. > > I was about to start some work on spec_distributed, and was wondering > if/when this was coming? We're looking at unifying the formatters between stories and granular examples. Right now stories just have arbitrary listeners - some of which are formatters. It would be nice to do the same thing for examples, but we're not there yet. Can't say it's going to happen, can't say it won't. I'd coordinate w/ Aslak on spec/dist. Cheers, David From aslak.hellesoy at gmail.com Tue Dec 11 21:11:34 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Wed, 12 Dec 2007 03:11:34 +0100 Subject: [rspec-devel] Fate of Reporters? In-Reply-To: References: Message-ID: <8d961d900712111811s60a44286q8c3c389cd488bc35@mail.gmail.com> On Dec 11, 2007 10:23 PM, Bob Cotton wrote: > > Someone had mentioned a week or so ago about removing > Spec::Runner::Reporter. > > I was about to start some work on spec_distributed, and was wondering > if/when this was coming? > S::D has been in limbo while the guts of RSpec were heavily refactored since last release. Let's do a chat about how to proceed with S::D. aslak_hellesoy at yahoo! or aslak.hellesoy at gmail.com for GTalk Aslak > Thanks > - Bob > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From bob.cotton at rallydev.com Thu Dec 13 17:50:56 2007 From: bob.cotton at rallydev.com (Bob Cotton) Date: Thu, 13 Dec 2007 15:50:56 -0700 Subject: [rspec-devel] The Reporter -> Formatter interface Message-ID: Before 1.1.0 gos out, I would like to propose a change to the interface of Formatter, and possibly Reporter. As the Formatter interface has already changed in 1.1.0, I would like to get this in now. I have on more then one occasion, in a custom Formatter, need to track the association between the "active" ExampleGroup and the currently passing/failing/pending Example. I believe this is caused by the fact that Examples have no knowledge of the ExampleGroup that they belong to. This can be see in Spec::Runner::Formatter which tracks a list of ExampleGroups so that in Formatter#example_pending, it may pass in the description of the ExampleGroup that the example belongs to. My proposal is to change the interface of Formatter such that whenever an Example is passed in, the ExampleGroup that Example belongs to is also passed in. This would change the signature of these methods: example_started example_passed example_failed example_pending to all take an example_group as the fist parameter. This could be accomplished by having the Reporter simply pass the last ExampleGroup it has seen to the Formatter. However this is not threadsafe. I don't have any mult-threaded requirements at the moment, so I'm not proposing that the Example -> Formatter interaction needs to know about their ExampleGroup. I have time to finish this work, and can have a patch in a day or two. Thoughts? - Bob From dchelimsky at gmail.com Fri Dec 14 00:41:01 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 13 Dec 2007 23:41:01 -0600 Subject: [rspec-devel] The Reporter -> Formatter interface In-Reply-To: References: Message-ID: <57c63afe0712132141w123f6d1rff011dc9e3fc1236@mail.gmail.com> On Dec 13, 2007 4:50 PM, Bob Cotton wrote: > > Before 1.1.0 gos out, I would like to propose a change to the interface > of Formatter, and possibly Reporter. As the Formatter interface has > already changed in 1.1.0, I would like to get this in now. Sorry Bob, but I just released 1.1 without this. I've been anxious to get it out for months and couldn't bear waiting for another feature. > I have on more then one occasion, in a custom Formatter, need to track > the association between the "active" ExampleGroup and the currently > passing/failing/pending Example. > > I believe this is caused by the fact that Examples have no knowledge of > the ExampleGroup that they belong to. Actually, as things stand now, the Example is an instance of the ExampleGroup class, each of which is unique and has its own description. Why don't you see if you can exploit that for your needs. If not, go ahead and submit a patch to the tracker. Now that we've gotten past the big hump of the 1.1 release, we should get back on track of more frequent minor releases. Cheers, David > This can be see in Spec::Runner::Formatter which tracks a list of > ExampleGroups so that in Formatter#example_pending, it may pass in the > description of the ExampleGroup that the example belongs to. > > My proposal is to change the interface of Formatter such that whenever > an Example is passed in, the ExampleGroup that Example belongs to is > also passed in. This would change the signature of these methods: > > example_started > example_passed > example_failed > example_pending > > to all take an example_group as the fist parameter. > > This could be accomplished by having the Reporter simply pass the last > ExampleGroup it has seen to the Formatter. However this is not > threadsafe. > > I don't have any mult-threaded requirements at the moment, so I'm not > proposing that the Example -> Formatter interaction needs to know about > their ExampleGroup. > > I have time to finish this work, and can have a patch in a day or two. > > Thoughts? > > - Bob > > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From dchelimsky at gmail.com Fri Dec 14 00:58:22 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 13 Dec 2007 23:58:22 -0600 Subject: [rspec-devel] [ANN] RSpec-1.1.0 is released Message-ID: <57c63afe0712132158p5ccc906v9a90c90c227be3e1@mail.gmail.com> The RSpec Development Team is pleased as glug (that's kind of like punch, but more festive) to announce RSpec-1.1.0. Thanks to all who have contributed patches over the last few months. Big thanks to Dan North and Brian Takita for their important work on this release. Dan contributed his rbehave framework which is now the Story Runner. Brian patiently did a TON of refactoring around interoperability with Test::Unit, and the result is a much cleaner RSpec core, and a clean adapter model that gets loaded when Test::Unit is on the path. == RSpec 1.1 brings four significant changes for RSpec users: * The RSpec Story Runner * Nested Example Groups * Support for Rails 2.0.1 * Test::Unit interoperability == Story Runner The RSpec Story Runner is Dan North's rbehave framework merged into RSpec. The Story Runner is a framework for expressing high level requirements in the form of executable User Stories with Scenarios that represent Customer Acceptance Tests. RSpec 1.1 also ships with a Ruby on Rails extension called RailsStory, which lets you write executable user stories for your rails apps as well. == Nested Example Groups Now you can nest groups to organize things a bit better: describe RubyDeveloper do before(:each) do @ruby_developer = RubyDeveloper.new end describe "using RSpec 1.1.0" do before(:each) do @ruby_developer.use_rspec('1.1.0') end it "should be able to nest example groups" do @ruby_developer.should be_able_to_nest_example_groups end end describe "using RSpec 1.0.1" do before(:each) do @ruby_developer.use_rspec('1.0.8') end it "should not be able to nest example groups" do @ruby_developer.should_not be_able_to_nest_example_groups end end end Running this outputs: RubyDeveloper using RSpec 1.1.0 - should be able to nest example groups RubyDeveloper using RSpec 1.0.8 - should not be able to nest example groups == Support for Rails 2.0.1 gem install rails rails myapp ruby script/install http://rspec.rubyforge.org/svn/tags/REL_1_1_0/rspec ruby script/install http://rspec.rubyforge.org/svn/tags/REL_1_1_0/rspec_on_rails script/generate rspec == Test::Unit Interoperability Contrary to popular belief, Spec::Rails, RSpec's Ruby on Rails plugin, has been a Test::Unit wrapper since the the 0.7 release in November of 2006. RSpec 1.1 ups the ante though, offering a smooth transition from Test::Unit to RSpec with or without Rails: 1. Start with a TestCase: require 'test/unit' class TransitionTest < Test::Unit::TestCase def test_should_be_smooth transition = Transition.new( :from => "Test::Unit::TestCase", :to => "Spec::ExampleGroup" ) assert_equal "really smooth", transition.in_practice end end 2. Require 'spec' require 'test/unit' require 'spec' class TransitionTest < Test::Unit::TestCase def test_should_be_smooth transition = Transition.new( :from => "Test::Unit::TestCase", :to => "Spec::ExampleGroup" ) assert_equal "really smooth", transition.in_practice end end 3. Convert TestCase to ExampleGroup require 'test/unit' require 'spec' describe "transitioning from TestCase to ExampleGroup" do def test_should_be_smooth transition = Transition.new( :from => "Test::Unit::TestCase", :to => "Spec::ExampleGroup" ) assert_equal "really smooth", transition.in_practice end end 4. Convert test methods to examples require 'test/unit' require 'spec' describe "transitioning from TestCase to ExampleGroup" do it "should be smooth" do transition = Transition.new( :from => "Test::Unit::TestCase", :to => "Spec::ExampleGroup" ) assert_equal "really smooth", transition.in_practice end end 5. Convert assertions to expectations require 'test/unit' require 'spec' describe "transitioning from TestCase to ExampleGroup" do it "should be smooth" do transition = Transition.new( :from => "Test::Unit::TestCase", :to => "Spec::ExampleGroup") transition.in_practice.should == "really smooth" end end 6. Un-require test/unit require 'spec' describe "transitioning from TestCase to ExampleGroup" do it "should be smooth" do transition = Transition.new( :from => "Test::Unit::TestCase", :to => "Spec::ExampleGroup" ) transition.in_practice.should == "really smooth" end end At every one of these steps after step 2, you can run the file with the ruby command and you'll be getting RSpec's developer friendly output. This means that you can transition things as gradually as you like: no wholesale changes. That's the story. Thanks again to all who contributed and to all who continue do so. From pergesu at gmail.com Fri Dec 14 02:01:32 2007 From: pergesu at gmail.com (Pat Maddox) Date: Thu, 13 Dec 2007 23:01:32 -0800 Subject: [rspec-devel] [ANN] RSpec-1.1.0 is released In-Reply-To: <57c63afe0712132158p5ccc906v9a90c90c227be3e1@mail.gmail.com> References: <57c63afe0712132158p5ccc906v9a90c90c227be3e1@mail.gmail.com> Message-ID: <810a540e0712132301l7f001ec4o2d2432f6ab121bc2@mail.gmail.com> On Dec 13, 2007 9:58 PM, David Chelimsky wrote: > > The RSpec Development Team is pleased as glug (that's kind of like > punch, but more festive) to announce RSpec-1.1.0. > > Thanks to all who have contributed patches over the last few months. > Big thanks to Dan North and Brian Takita for their important work on > this release. Dan contributed his rbehave framework which is now the > Story Runner. Brian patiently did a TON of refactoring around > interoperability with Test::Unit, and the result is a much cleaner > RSpec core, and a clean adapter model that gets loaded when Test::Unit > is on the path. > > == RSpec 1.1 brings four significant changes for RSpec users: > > * The RSpec Story Runner > * Nested Example Groups > * Support for Rails 2.0.1 > * Test::Unit interoperability > > == Story Runner > > The RSpec Story Runner is Dan North's rbehave framework merged into > RSpec. The Story Runner is a framework for expressing high level > requirements in the form of executable User Stories with Scenarios > that represent Customer Acceptance Tests. > > RSpec 1.1 also ships with a Ruby on Rails extension called RailsStory, > which lets you write executable user stories for your rails apps as > well. > > == Nested Example Groups > > Now you can nest groups to organize things a bit better: > > describe RubyDeveloper do > > before(:each) do > @ruby_developer = RubyDeveloper.new > end > > describe "using RSpec 1.1.0" do > > before(:each) do > @ruby_developer.use_rspec('1.1.0') > end > > it "should be able to nest example groups" do > @ruby_developer.should be_able_to_nest_example_groups > end > > end > > describe "using RSpec 1.0.1" do > > before(:each) do > @ruby_developer.use_rspec('1.0.8') > end > > it "should not be able to nest example groups" do > @ruby_developer.should_not be_able_to_nest_example_groups > end > > end > > end > > Running this outputs: > > RubyDeveloper using RSpec 1.1.0 > - should be able to nest example groups > > RubyDeveloper using RSpec 1.0.8 > - should not be able to nest example groups > > == Support for Rails 2.0.1 > > gem install rails > rails myapp > ruby script/install http://rspec.rubyforge.org/svn/tags/REL_1_1_0/rspec > ruby script/install http://rspec.rubyforge.org/svn/tags/REL_1_1_0/rspec_on_rails > script/generate rspec > > == Test::Unit Interoperability > > Contrary to popular belief, Spec::Rails, RSpec's Ruby on Rails plugin, > has been a Test::Unit wrapper since the the 0.7 release in November of > 2006. RSpec 1.1 ups the ante though, offering a smooth transition from > Test::Unit to RSpec with or without Rails: > > 1. Start with a TestCase: > > require 'test/unit' > > class TransitionTest < Test::Unit::TestCase > def test_should_be_smooth > transition = Transition.new( > :from => "Test::Unit::TestCase", > :to => "Spec::ExampleGroup" > ) > assert_equal "really smooth", transition.in_practice > end > end > 2. Require 'spec' > > require 'test/unit' > require 'spec' > > class TransitionTest < Test::Unit::TestCase > def test_should_be_smooth > transition = Transition.new( > :from => "Test::Unit::TestCase", > :to => "Spec::ExampleGroup" > ) > assert_equal "really smooth", transition.in_practice > end > end > 3. Convert TestCase to ExampleGroup > > require 'test/unit' > require 'spec' > > describe "transitioning from TestCase to ExampleGroup" do > def test_should_be_smooth > transition = Transition.new( > :from => "Test::Unit::TestCase", > :to => "Spec::ExampleGroup" > ) > assert_equal "really smooth", transition.in_practice > end > end > 4. Convert test methods to examples > > require 'test/unit' > require 'spec' > > describe "transitioning from TestCase to ExampleGroup" do > it "should be smooth" do > transition = Transition.new( > :from => "Test::Unit::TestCase", > :to => "Spec::ExampleGroup" > ) > assert_equal "really smooth", transition.in_practice > end > end > 5. Convert assertions to expectations > > require 'test/unit' > require 'spec' > > describe "transitioning from TestCase to ExampleGroup" do > it "should be smooth" do > transition = Transition.new( > :from => "Test::Unit::TestCase", > :to => "Spec::ExampleGroup") > transition.in_practice.should == "really smooth" > end > end > 6. Un-require test/unit > > require 'spec' > > describe "transitioning from TestCase to ExampleGroup" do > it "should be smooth" do > transition = Transition.new( > :from => "Test::Unit::TestCase", > :to => "Spec::ExampleGroup" > ) > transition.in_practice.should == "really smooth" > end > end > At every one of these steps after step 2, you can run the file with > the ruby command and you'll be getting RSpec's developer friendly > output. This means that you can transition things as gradually as you > like: no wholesale changes. > > That's the story. Thanks again to all who contributed and to all who > continue do so. > > Congratulations!! Very cool. Pat From nicksieger at gmail.com Fri Dec 14 02:10:18 2007 From: nicksieger at gmail.com (Nick Sieger) Date: Thu, 13 Dec 2007 23:10:18 -0800 Subject: [rspec-devel] [ANN] RSpec-1.1.0 is released In-Reply-To: <57c63afe0712132158p5ccc906v9a90c90c227be3e1@mail.gmail.com> References: <57c63afe0712132158p5ccc906v9a90c90c227be3e1@mail.gmail.com> Message-ID: On 12/13/07, David Chelimsky wrote: > The RSpec Development Team is pleased as glug (that's kind of like > punch, but more festive) to announce RSpec-1.1.0. > > Thanks to all who have contributed patches over the last few months. > Big thanks to Dan North and Brian Takita for their important work on > this release. Dan contributed his rbehave framework which is now the > Story Runner. Brian patiently did a TON of refactoring around > interoperability with Test::Unit, and the result is a much cleaner > RSpec core, and a clean adapter model that gets loaded when Test::Unit > is on the path. You guys are awesome! I don't know a single piece of software that packs more punch in a point release. Keep it coming! Your fan, /Nick From mlangenberg at gmail.com Fri Dec 14 03:13:31 2007 From: mlangenberg at gmail.com (Matthijs Langenberg) Date: Fri, 14 Dec 2007 09:13:31 +0100 Subject: [rspec-devel] [ANN] RSpec-1.1.0 is released In-Reply-To: References: <57c63afe0712132158p5ccc906v9a90c90c227be3e1@mail.gmail.com> Message-ID: <27c0ac6d0712140013u438a0472k5914738b1cda39f7@mail.gmail.com> Awesome work guys! Congratulations with the 1.1.0 release! On Dec 14, 2007 8:10 AM, Nick Sieger wrote: > On 12/13/07, David Chelimsky wrote: > > The RSpec Development Team is pleased as glug (that's kind of like > > punch, but more festive) to announce RSpec-1.1.0. > > > > Thanks to all who have contributed patches over the last few months. > > Big thanks to Dan North and Brian Takita for their important work on > > this release. Dan contributed his rbehave framework which is now the > > Story Runner. Brian patiently did a TON of refactoring around > > interoperability with Test::Unit, and the result is a much cleaner > > RSpec core, and a clean adapter model that gets loaded when Test::Unit > > is on the path. > > You guys are awesome! I don't know a single piece of software that > packs more punch in a point release. Keep it coming! > > Your fan, > /Nick > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-devel/attachments/20071214/742a67d3/attachment.html From mailing_lists at railsnewbie.com Fri Dec 14 09:05:09 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Fri, 14 Dec 2007 09:05:09 -0500 Subject: [rspec-devel] [ANN] RSpec-1.1.0 is released In-Reply-To: <57c63afe0712132158p5ccc906v9a90c90c227be3e1@mail.gmail.com> References: <57c63afe0712132158p5ccc906v9a90c90c227be3e1@mail.gmail.com> Message-ID: Congrats, David. You've worked really hard on this one, and it shows! Scott On Dec 14, 2007, at 12:58 AM, David Chelimsky wrote: > The RSpec Development Team is pleased as glug (that's kind of like > punch, but more festive) to announce RSpec-1.1.0. > > Thanks to all who have contributed patches over the last few months. > Big thanks to Dan North and Brian Takita for their important work on > this release. Dan contributed his rbehave framework which is now the > Story Runner. Brian patiently did a TON of refactoring around > interoperability with Test::Unit, and the result is a much cleaner > RSpec core, and a clean adapter model that gets loaded when Test::Unit > is on the path. > > == RSpec 1.1 brings four significant changes for RSpec users: > > * The RSpec Story Runner > * Nested Example Groups > * Support for Rails 2.0.1 > * Test::Unit interoperability > > == Story Runner > > The RSpec Story Runner is Dan North's rbehave framework merged into > RSpec. The Story Runner is a framework for expressing high level > requirements in the form of executable User Stories with Scenarios > that represent Customer Acceptance Tests. > > RSpec 1.1 also ships with a Ruby on Rails extension called RailsStory, > which lets you write executable user stories for your rails apps as > well. > > == Nested Example Groups > > Now you can nest groups to organize things a bit better: > > describe RubyDeveloper do > > before(:each) do > @ruby_developer = RubyDeveloper.new > end > > describe "using RSpec 1.1.0" do > > before(:each) do > @ruby_developer.use_rspec('1.1.0') > end > > it "should be able to nest example groups" do > @ruby_developer.should be_able_to_nest_example_groups > end > > end > > describe "using RSpec 1.0.1" do > > before(:each) do > @ruby_developer.use_rspec('1.0.8') > end > > it "should not be able to nest example groups" do > @ruby_developer.should_not be_able_to_nest_example_groups > end > > end > > end > > Running this outputs: > > RubyDeveloper using RSpec 1.1.0 > - should be able to nest example groups > > RubyDeveloper using RSpec 1.0.8 > - should not be able to nest example groups > > == Support for Rails 2.0.1 > > gem install rails > rails myapp > ruby script/install http://rspec.rubyforge.org/svn/tags/REL_1_1_0/ > rspec > ruby script/install http://rspec.rubyforge.org/svn/tags/REL_1_1_0/ > rspec_on_rails > script/generate rspec > > == Test::Unit Interoperability > > Contrary to popular belief, Spec::Rails, RSpec's Ruby on Rails plugin, > has been a Test::Unit wrapper since the the 0.7 release in November of > 2006. RSpec 1.1 ups the ante though, offering a smooth transition from > Test::Unit to RSpec with or without Rails: > > 1. Start with a TestCase: > > require 'test/unit' > > class TransitionTest < Test::Unit::TestCase > def test_should_be_smooth > transition = Transition.new( > :from => "Test::Unit::TestCase", > :to => "Spec::ExampleGroup" > ) > assert_equal "really smooth", transition.in_practice > end > end > 2. Require 'spec' > > require 'test/unit' > require 'spec' > > class TransitionTest < Test::Unit::TestCase > def test_should_be_smooth > transition = Transition.new( > :from => "Test::Unit::TestCase", > :to => "Spec::ExampleGroup" > ) > assert_equal "really smooth", transition.in_practice > end > end > 3. Convert TestCase to ExampleGroup > > require 'test/unit' > require 'spec' > > describe "transitioning from TestCase to ExampleGroup" do > def test_should_be_smooth > transition = Transition.new( > :from => "Test::Unit::TestCase", > :to => "Spec::ExampleGroup" > ) > assert_equal "really smooth", transition.in_practice > end > end > 4. Convert test methods to examples > > require 'test/unit' > require 'spec' > > describe "transitioning from TestCase to ExampleGroup" do > it "should be smooth" do > transition = Transition.new( > :from => "Test::Unit::TestCase", > :to => "Spec::ExampleGroup" > ) > assert_equal "really smooth", transition.in_practice > end > end > 5. Convert assertions to expectations > > require 'test/unit' > require 'spec' > > describe "transitioning from TestCase to ExampleGroup" do > it "should be smooth" do > transition = Transition.new( > :from => "Test::Unit::TestCase", > :to => "Spec::ExampleGroup") > transition.in_practice.should == "really smooth" > end > end > 6. Un-require test/unit > > require 'spec' > > describe "transitioning from TestCase to ExampleGroup" do > it "should be smooth" do > transition = Transition.new( > :from => "Test::Unit::TestCase", > :to => "Spec::ExampleGroup" > ) > transition.in_practice.should == "really smooth" > end > end > At every one of these steps after step 2, you can run the file with > the ruby command and you'll be getting RSpec's developer friendly > output. This means that you can transition things as gradually as you > like: no wholesale changes. > > That's the story. Thanks again to all who contributed and to all who > continue do so. > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel From dchelimsky at gmail.com Fri Dec 14 09:09:16 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 14 Dec 2007 08:09:16 -0600 Subject: [rspec-devel] [ANN] RSpec-1.1.0 is released In-Reply-To: References: <57c63afe0712132158p5ccc906v9a90c90c227be3e1@mail.gmail.com> Message-ID: <57c63afe0712140609tb1ae00au9fa80a4f7fef7c23@mail.gmail.com> On Dec 14, 2007 8:05 AM, Scott Taylor wrote: > > Congrats, David. You've worked really hard on this one, and it shows! Thanks Scott, but Brian and Dan really deserve a LOT of credit for this one. Plus the plethora of patches, etc. Cheers, David > > Scott > > > > On Dec 14, 2007, at 12:58 AM, David Chelimsky wrote: > > > The RSpec Development Team is pleased as glug (that's kind of like > > punch, but more festive) to announce RSpec-1.1.0. > > > > Thanks to all who have contributed patches over the last few months. > > Big thanks to Dan North and Brian Takita for their important work on > > this release. Dan contributed his rbehave framework which is now the > > Story Runner. Brian patiently did a TON of refactoring around > > interoperability with Test::Unit, and the result is a much cleaner > > RSpec core, and a clean adapter model that gets loaded when Test::Unit > > is on the path. > > > > == RSpec 1.1 brings four significant changes for RSpec users: > > > > * The RSpec Story Runner > > * Nested Example Groups > > * Support for Rails 2.0.1 > > * Test::Unit interoperability > > > > == Story Runner > > > > The RSpec Story Runner is Dan North's rbehave framework merged into > > RSpec. The Story Runner is a framework for expressing high level > > requirements in the form of executable User Stories with Scenarios > > that represent Customer Acceptance Tests. > > > > RSpec 1.1 also ships with a Ruby on Rails extension called RailsStory, > > which lets you write executable user stories for your rails apps as > > well. > > > > == Nested Example Groups > > > > Now you can nest groups to organize things a bit better: > > > > describe RubyDeveloper do > > > > before(:each) do > > @ruby_developer = RubyDeveloper.new > > end > > > > describe "using RSpec 1.1.0" do > > > > before(:each) do > > @ruby_developer.use_rspec('1.1.0') > > end > > > > it "should be able to nest example groups" do > > @ruby_developer.should be_able_to_nest_example_groups > > end > > > > end > > > > describe "using RSpec 1.0.1" do > > > > before(:each) do > > @ruby_developer.use_rspec('1.0.8') > > end > > > > it "should not be able to nest example groups" do > > @ruby_developer.should_not be_able_to_nest_example_groups > > end > > > > end > > > > end > > > > Running this outputs: > > > > RubyDeveloper using RSpec 1.1.0 > > - should be able to nest example groups > > > > RubyDeveloper using RSpec 1.0.8 > > - should not be able to nest example groups > > > > == Support for Rails 2.0.1 > > > > gem install rails > > rails myapp > > ruby script/install http://rspec.rubyforge.org/svn/tags/REL_1_1_0/ > > rspec > > ruby script/install http://rspec.rubyforge.org/svn/tags/REL_1_1_0/ > > rspec_on_rails > > script/generate rspec > > > > == Test::Unit Interoperability > > > > Contrary to popular belief, Spec::Rails, RSpec's Ruby on Rails plugin, > > has been a Test::Unit wrapper since the the 0.7 release in November of > > 2006. RSpec 1.1 ups the ante though, offering a smooth transition from > > Test::Unit to RSpec with or without Rails: > > > > 1. Start with a TestCase: > > > > require 'test/unit' > > > > class TransitionTest < Test::Unit::TestCase > > def test_should_be_smooth > > transition = Transition.new( > > :from => "Test::Unit::TestCase", > > :to => "Spec::ExampleGroup" > > ) > > assert_equal "really smooth", transition.in_practice > > end > > end > > 2. Require 'spec' > > > > require 'test/unit' > > require 'spec' > > > > class TransitionTest < Test::Unit::TestCase > > def test_should_be_smooth > > transition = Transition.new( > > :from => "Test::Unit::TestCase", > > :to => "Spec::ExampleGroup" > > ) > > assert_equal "really smooth", transition.in_practice > > end > > end > > 3. Convert TestCase to ExampleGroup > > > > require 'test/unit' > > require 'spec' > > > > describe "transitioning from TestCase to ExampleGroup" do > > def test_should_be_smooth > > transition = Transition.new( > > :from => "Test::Unit::TestCase", > > :to => "Spec::ExampleGroup" > > ) > > assert_equal "really smooth", transition.in_practice > > end > > end > > 4. Convert test methods to examples > > > > require 'test/unit' > > require 'spec' > > > > describe "transitioning from TestCase to ExampleGroup" do > > it "should be smooth" do > > transition = Transition.new( > > :from => "Test::Unit::TestCase", > > :to => "Spec::ExampleGroup" > > ) > > assert_equal "really smooth", transition.in_practice > > end > > end > > 5. Convert assertions to expectations > > > > require 'test/unit' > > require 'spec' > > > > describe "transitioning from TestCase to ExampleGroup" do > > it "should be smooth" do > > transition = Transition.new( > > :from => "Test::Unit::TestCase", > > :to => "Spec::ExampleGroup") > > transition.in_practice.should == "really smooth" > > end > > end > > 6. Un-require test/unit > > > > require 'spec' > > > > describe "transitioning from TestCase to ExampleGroup" do > > it "should be smooth" do > > transition = Transition.new( > > :from => "Test::Unit::TestCase", > > :to => "Spec::ExampleGroup" > > ) > > transition.in_practice.should == "really smooth" > > end > > end > > At every one of these steps after step 2, you can run the file with > > the ruby command and you'll be getting RSpec's developer friendly > > output. This means that you can transition things as gradually as you > > like: no wholesale changes. > > > > That's the story. Thanks again to all who contributed and to all who > > continue do so. > > _______________________________________________ > > rspec-devel mailing list > > rspec-devel at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-devel > > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From dchelimsky at gmail.com Fri Dec 14 10:05:01 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 14 Dec 2007 09:05:01 -0600 Subject: [rspec-devel] new home for the rspec website Message-ID: <57c63afe0712140705g308b2c64sfa2633a1c54dc5ec@mail.gmail.com> Hi all, We've moved the rspec website to http://rspec.info. We want http://rspec.org, of course, but someone is squatting on and has yet to respond to my email :( The 1.1.0 docs are there. The 1.0.8 docs are still at http://rspec.rubyforge.org for the time being. We'll be archiving them at the new site soon. This new site is hosted on our shiny new sponsored slice at Engine Yard, which will soon be the host for our source repository as well. Speaking of the new source repo, we got a lot of feedback pushing towards using git over hg, but we have some reasons that we might prefer hg. So here's what we're going to do. We're going to work in one for a month, and then the other, and then make a decision. I'll follow up as to which we're using first and how to access the repo. Either way, we'll continue to push changes over to the svn repo at rubyforge, so if you don't want to participate in our experiment you don't have to - though we will be asking patch contributors to so that we can really get a feel for what it's like to deal with patches, updates, etc with both tools. Cheers, David From adam at thewilliams.ws Fri Dec 14 10:05:18 2007 From: adam at thewilliams.ws (Adam Williams) Date: Fri, 14 Dec 2007 10:05:18 -0500 Subject: [rspec-devel] [ANN] RSpec-1.1.0 is released In-Reply-To: <57c63afe0712140609tb1ae00au9fa80a4f7fef7c23@mail.gmail.com> References: <57c63afe0712132158p5ccc906v9a90c90c227be3e1@mail.gmail.com> <57c63afe0712140609tb1ae00au9fa80a4f7fef7c23@mail.gmail.com> Message-ID: On Dec 14, 2007, at 9:09 AM, David Chelimsky wrote: > On Dec 14, 2007 8:05 AM, Scott Taylor > wrote: >> >> Congrats, David. You've worked really hard on this one, and it >> shows! > > Thanks Scott, but Brian and Dan really deserve a LOT of credit for > this one. Plus the plethora of patches, etc. I have been following this very closely, trying to keep a few plugins running on edge. The Test::Unit interop is greatly appreciated, and I can tell those who were in 1.0.8 - the newer architecture is a vast improvement. There is a model for the scripts I write!! Excellent work, gentlemen. Thank you for whatever sacrifices I'm sure you've made to bring this to us. aiwilliams From mailing_lists at railsnewbie.com Fri Dec 14 10:48:07 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Fri, 14 Dec 2007 10:48:07 -0500 Subject: [rspec-devel] [ANN] RSpec-1.1.0 is released In-Reply-To: <57c63afe0712140609tb1ae00au9fa80a4f7fef7c23@mail.gmail.com> References: <57c63afe0712132158p5ccc906v9a90c90c227be3e1@mail.gmail.com> <57c63afe0712140609tb1ae00au9fa80a4f7fef7c23@mail.gmail.com> Message-ID: On Dec 14, 2007, at 9:09 AM, David Chelimsky wrote: > On Dec 14, 2007 8:05 AM, Scott Taylor > wrote: >> >> Congrats, David. You've worked really hard on this one, and it >> shows! > > Thanks Scott, but Brian and Dan really deserve a LOT of credit for > this one. Plus the plethora of patches, etc. Oh yeah - Brian's refactoring is huge. Now the internals of rspec are very readable. And Dan's framework is great, and is already putting RSpec/Rbehave in the spotlight for many. Scott From nathan.sutton at gmail.com Fri Dec 14 12:19:24 2007 From: nathan.sutton at gmail.com (Nathan Sutton) Date: Fri, 14 Dec 2007 11:19:24 -0600 Subject: [rspec-devel] new home for the rspec website In-Reply-To: <57c63afe0712140705g308b2c64sfa2633a1c54dc5ec@mail.gmail.com> References: <57c63afe0712140705g308b2c64sfa2633a1c54dc5ec@mail.gmail.com> Message-ID: <7106FA00-9CD7-4445-A5AC-99E4D3DA15D5@gmail.com> David, Might want to add some easy-to-find links to the rdocs for rspec and rspec-on-rails. I just mimicked the urls on the old site to find them, although I did find a link to the main rspec rdocs eventually. Is there anything I can do to help this come about? http://rspec.info/rdoc/index.html http://rspec.info/rdoc-rails/index.html Thanks, Nathan Sutton fowlduck at gmail.com rspec edge revision 3052 rspec_on_rails edge revision 3049 rails 2.0.1 On Dec 14, 2007, at 9:05 AM, David Chelimsky wrote: > Hi all, > > We've moved the rspec website to http://rspec.info. We want > http://rspec.org, of course, but someone is squatting on and has yet > to respond to my email :( > > The 1.1.0 docs are there. The 1.0.8 docs are still at > http://rspec.rubyforge.org for the time being. We'll be archiving them > at the new site soon. > > This new site is hosted on our shiny new sponsored slice at Engine > Yard, which will soon be the host for our source repository as well. > > Speaking of the new source repo, we got a lot of feedback pushing > towards using git over hg, but we have some reasons that we might > prefer hg. So here's what we're going to do. We're going to work in > one for a month, and then the other, and then make a decision. I'll > follow up as to which we're using first and how to access the repo. > > Either way, we'll continue to push changes over to the svn repo at > rubyforge, so if you don't want to participate in our experiment you > don't have to - though we will be asking patch contributors to so that > we can really get a feel for what it's like to deal with patches, > updates, etc with both tools. > > Cheers, > David > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel From bob.cotton at rallydev.com Fri Dec 14 12:26:48 2007 From: bob.cotton at rallydev.com (Bob Cotton) Date: Fri, 14 Dec 2007 10:26:48 -0700 Subject: [rspec-devel] The Reporter -> Formatter interface In-Reply-To: <57c63afe0712132141w123f6d1rff011dc9e3fc1236@mail.gmail.com> (David Chelimsky's message of "Thu\, 13 Dec 2007 23\:41\:01 -0600") References: <57c63afe0712132141w123f6d1rff011dc9e3fc1236@mail.gmail.com> Message-ID: "David Chelimsky" writes: Congratulations on the release. I've stoked about the new features! > Actually, as things stand now, the Example is an instance of the > ExampleGroup class, each of which is unique and has its own > description. Why don't you see if you can exploit that for your needs. Good to know. I can use that. example.class gives the ExampleGroup. Any possibility of adding a #example_group method that does the same? Just to make it less magic? One more question, given an instance of either an example of example group, I'm having a hard time determining which is which, esp. when test/unit in the in the mix. Here's what I would like to do: case example_or_example_group when Spec::Example::ExampleGroup # something when Spec::Example::Example # something else end But: >> example.class Test::Unit::TestCase::Subclass_1 >> Spec::Example::ExampleGroupMethods === example_group => true other ideas? -Bob From lists-rspec at shopwatch.org Fri Dec 14 13:50:57 2007 From: lists-rspec at shopwatch.org (Jay Levitt) Date: Fri, 14 Dec 2007 13:50:57 -0500 Subject: [rspec-devel] new home for the rspec website In-Reply-To: <57c63afe0712140705g308b2c64sfa2633a1c54dc5ec@mail.gmail.com> References: <57c63afe0712140705g308b2c64sfa2633a1c54dc5ec@mail.gmail.com> Message-ID: <4762D091.30106@shopwatch.org> On 12/14/2007 10:05 AM, David Chelimsky wrote: > Speaking of the new source repo, we got a lot of feedback pushing > towards using git over hg, but we have some reasons that we might > prefer hg. So here's what we're going to do. We're going to work in > one for a month, and then the other, and then make a decision. I'll > follow up as to which we're using first and how to access the repo. It'd be good to know - both now and as things progress - what factors might make you want to use one over the other. We've had a good bit of discussion about how they differ in general, but I'd love to hear what specifically affects RSpec. (I imagine Windows support is a big one.) Jay From jeremy.stephens at vanderbilt.edu Tue Dec 18 16:53:09 2007 From: jeremy.stephens at vanderbilt.edu (Jeremy Stephens) Date: Tue, 18 Dec 2007 15:53:09 -0600 Subject: [rspec-devel] rake pre_commit fails Message-ID: <200712181553.09745.jeremy.stephens@vanderbilt.edu> Hey guys, I just checked out the repository because I want to write a patch for the rails plugin. I followed the instructions to get my development environment setup, but when I ran 'rake pre_commit', it failed. ./examples/stories/game-of-life/behaviour/stories/steps.rb:1: undefined method `steps_for' for main:Object (NoMethodError) from /home/foo/projects/rspec/rspec/lib/spec/runner/example_group_runner.rb:14:in `load' from /home/foo/projects/rspec/rspec/lib/spec/runner/example_group_runner.rb:14:in `load_files' from /home/foo/projects/rspec/rspec/lib/spec/runner/example_group_runner.rb:13:in `each' from /home/foo/projects/rspec/rspec/lib/spec/runner/example_group_runner.rb:13:in `load_files' from /home/foo/projects/rspec/rspec/lib/spec/runner/options.rb:83:in `run_examples' from /home/foo/projects/rspec/rspec/lib/spec/runner/command_line.rb:19:in `run' from /home/foo/projects/rspec/rspec/bin/spec:3 Did I set something up incorrectly? TIA, Jeremy -- Jeremy Stephens Computer Systems Analyst I School of Medicine Department of Biostatistics Vanderbilt University From dchelimsky at gmail.com Tue Dec 18 17:14:27 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 18 Dec 2007 16:14:27 -0600 Subject: [rspec-devel] rake pre_commit fails In-Reply-To: <200712181553.09745.jeremy.stephens@vanderbilt.edu> References: <200712181553.09745.jeremy.stephens@vanderbilt.edu> Message-ID: <57c63afe0712181414s1b91ec2el45975aac967a3d33@mail.gmail.com> On Dec 18, 2007 3:53 PM, Jeremy Stephens wrote: > Hey guys, > > I just checked out the repository because I want to write a patch for > the rails plugin. I followed the instructions to get my development > environment setup, but when I ran 'rake pre_commit', it failed. > > ./examples/stories/game-of-life/behaviour/stories/steps.rb:1: > undefined method `steps_for' for main:Object (NoMethodError) > from /home/foo/projects/rspec/rspec/lib/spec/runner/example_group_runner.rb:14:in > `load' > from /home/foo/projects/rspec/rspec/lib/spec/runner/example_group_runner.rb:14:in > `load_files' > from /home/foo/projects/rspec/rspec/lib/spec/runner/example_group_runner.rb:13:in > `each' > from /home/foo/projects/rspec/rspec/lib/spec/runner/example_group_runner.rb:13:in > `load_files' > from /home/foo/projects/rspec/rspec/lib/spec/runner/options.rb:83:in > `run_examples' > from /home/foo/projects/rspec/rspec/lib/spec/runner/command_line.rb:19:in > `run' > from /home/foo/projects/rspec/rspec/bin/spec:3 > > Did I set something up incorrectly? Where are you running pre_commit from? The root, or the rspec directory? Try running just 'rake' from the rspec directory first. If that passes, try just running 'rake' from the root directory. Thx > > TIA, > Jeremy > -- > Jeremy Stephens Computer Systems Analyst I School of Medicine > Department of Biostatistics Vanderbilt University > _______________________________________________ > rspec-devel mailing list > rspec-devel at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-devel > From jeremy.stephens at vanderbilt.edu Tue Dec 18 17:18:33 2007 From: jeremy.stephens at vanderbilt.edu (Jeremy Stephens) Date: Tue, 18 Dec 2007 16:18:33 -0600 Subject: [rspec-devel] rake pre_commit fails In-Reply-To: <57c63afe0712181414s1b91ec2el45975aac967a3d33@mail.gmail.com> References: <200712181553.09745.jeremy.stephens@vanderbilt.edu> <57c63afe0712181414s1b91ec2el45975aac967a3d33@mail.gmail.com> Message-ID: <200712181618.33624.jeremy.stephens@vanderbilt.edu> On Tuesday 18 December 2007 04:14:27 pm David Chelimsky wrote: > > Where are you running pre_commit from? The root, or the rspec > directory? Try running just 'rake' from the rspec directory first. > If that passes, try just running 'rake' from the root directory. > > Thx I tried in both the rspec and root directories with the same result. -- Jeremy Stephens Computer Systems Analyst I School of Medicine Department of Biostatistics Vanderbilt University From joshknowles at gmail.com Tue Dec 18 18:27:10 2007 From: joshknowles at gmail.com (Josh Knowles) Date: Tue, 18 Dec 2007 18:27:10 -0500 Subject: [rspec-devel] HaveMatcher & singular collection names Message-ID: I often find myself wanting to type out the singular form of the collection name when using the HaveMatcher with n == 1. For example: @person.should have(1).job as opposed to @person.should have(1).jobs I put together the following patch which attempts to solve this and am looking for some feedback: http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/193-havematcher-should-singularize-collection-name-for-single-items My pluralize method is very weak (it just adds an 's') as I wanted to get it out there and see if it was useful to anyone else. If so we can talk about building out a more robust pluralization system or piggybacking off of Rails if Inflector is present. -- Josh Knowles phone: 509-979-1593 email: joshknowles at gmail.com web: http://joshknowles.com From dchelimsky at gmail.com Fri Dec 28 21:24:33 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Sat, 29 Dec 2007 00:24:33 -0200 Subject: [rspec-devel] Help please: RSpec and Ruby 1.9 Message-ID: <57c63afe0712281824m1713beetaf5682041b0256a6@mail.gmail.com> Hey all, RSpec is not working with Ruby 1.9 yet. There have been a couple of posts about this on the ruby-talk mailing list: http://rubyurl.com/k9d If anyone has cycles to help resolve this in the short run, I'd personally really appreciate it as I probably won't for a couple of weeks. I'll make time to apply patches though :) Cheers, David From dchelimsky at gmail.com Sat Dec 29 05:44:15 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Sat, 29 Dec 2007 08:44:15 -0200 Subject: [rspec-devel] RSpec on Ruby 1.9: before(:all) (Not Yet Implemented) pending messages instead of tests In-Reply-To: <20071227181607.GI1277@durance.shot.pl> References: <20071227181607.GI1277@durance.shot.pl> Message-ID: <57c63afe0712290244p13fb9febp8e2e3fb1015edc9b@mail.gmail.com> On Dec 27, 2007 4:28 PM, Shot (Piotr Szotkowski) wrote: > Hi. > > I happily hand-compiled Ruby 1.9.0-0 into /home/shot/opt/ruby today > and I'm running into a strange error with RSpec ? all my examples work > perfectly with Ruby 1.8 but are considered peding on Ruby 1.9. > Pending: > ArtDecomp::Architecture before(:all) (Not Yet Implemented) > ArtDecomp::Architecture before(:all) (Not Yet Implemented) > ArtDecomp::Architecture before(:all) (Not Yet Implemented) > > Finished in 0.012114249 seconds > > 3 examples, 0 failures, 3 pending > > How can I bugtrack/fix this? RSpec's tracker can be found at http://rspec.lighthouseapp.com. The "Not Yet Implemented" issue you had is fixed in trunk now. > I had to patch RSpec in the below manner to get it running > on Ruby 1.9, but I doubt these fixes can be the culprit. > > --- lib/spec/runner/options.rb.orig 2007-12-27 16:36:03.000000000 +0100 > +++ lib/spec/runner/options.rb 2007-12-27 16:36:28.000000000 +0100 > @@ -102,7 +102,7 @@ > def colour=(colour) > @colour = colour > begin; \ > - require 'Win32/Console/ANSI' if @colour && PLATFORM =~ /win32/; \ > +# require 'Win32/Console/ANSI' if @colour && PLATFORM =~ /win32/; \ > rescue LoadError ; \ > raise "You must gem install win32console to use colour on Windows" ; \ > end > --- lib/spec/matchers/be.rb.orig 2007-12-27 16:30:51.000000000 +0100 > +++ lib/spec/matchers/be.rb 2007-12-27 16:32:14.000000000 +0100 > @@ -124,7 +124,8 @@ > def parse_expected(expected) > if Symbol === expected > @handling_predicate = true > - ["be_an_","be_a_","be_"].each do |@prefix| > + ["be_an_","be_a_","be_"].each do |at_prefix| > + @prefix = at_prefix > if expected.starts_with?(@prefix) > return "#{expected.to_s.sub(@prefix,"")}".to_sym > end > The change to be.rb has already been applied, but not the change to options.rb. I'm not sure I see any relationship between that and problems you might be experiencing with 1.9 (unless win32console does not yet support 1.9). Feel free to submit a ticket to the tracker on this one. Cheers, David From michael.s.klishin.lists at gmail.com Sun Dec 30 23:41:13 2007 From: michael.s.klishin.lists at gmail.com (Michael Klishin) Date: Mon, 31 Dec 2007 06:41:13 +0200 Subject: [rspec-devel] Help please: RSpec and Ruby 1.9 In-Reply-To: <57c63afe0712281824m1713beetaf5682041b0256a6@mail.gmail.com> References: <57c63afe0712281824m1713beetaf5682041b0256a6@mail.gmail.com> Message-ID: <5A9A87EB-0905-4E50-871C-EBDAE7C4E103@gmail.com> On 29 ???. 2007, at 04:24, David Chelimsky wrote: > RSpec is not working with Ruby 1.9 yet. There have been a couple of > posts about this on the ruby-talk mailing list: > > http://rubyurl.com/k9d > > If anyone has cycles to help resolve this in the short run, I'd > personally really appreciate it as I probably won't for a couple of > weeks. I'll make time to apply patches though :) I followed instructions in rspec/README and getting the following on website generation run: http://pastie.caboo.se/133428 Also, Hpricot and RCov fail to compile native extensions on rake install_dependencies run using Ruby 1.9.0. Anyone experienced this? MK void at novemberain.com http://novemberain.com From mailing_lists at railsnewbie.com Mon Dec 31 00:02:34 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Mon, 31 Dec 2007 00:02:34 -0500 Subject: [rspec-devel] Help please: RSpec and Ruby 1.9 In-Reply-To: <5A9A87EB-0905-4E50-871C-EBDAE7C4E103@gmail.com> References: <57c63afe0712281824m1713beetaf5682041b0256a6@mail.gmail.com> <5A9A87EB-0905-4E50-871C-EBDAE7C4E103@gmail.com> Message-ID: <3FB11DC3-4E0C-4864-A087-26D255DA983D@railsnewbie.com> On Dec 30, 2007, at 11:41 PM, Michael Klishin wrote: > On 29 ???. 2007, at 04:24, David Chelimsky wrote: > >> RSpec is not working with Ruby 1.9 yet. There have been a couple of >> posts about this on the ruby-talk mailing list: >> >> http://rubyurl.com/k9d >> >> If anyone has cycles to help resolve this in the short run, I'd >> personally really appreciate it as I probably won't for a couple of >> weeks. I'll make time to apply patches though :) > > > I followed instructions in rspec/README and getting the following on > website generation run: > > http://pastie.caboo.se/133428 > > Also, Hpricot and RCov fail to compile native extensions on rake > install_dependencies run using Ruby 1.9.0. > > Anyone experienced this? Not so far. You're probably the first who has tried to build rspec on ruby 1.9 I imagine you should file this in the bug tracker. Scott