I have some examples which should fail - I think - but do not: it ' should fail' do response.should have_tag( 'div.bug', :content => 'There is no content!' ) end it ' should fail since there is no bug attribute with a value of "here"' do response.should have_tag( 'div', :attributes => {:bug => "here"} ) response.should have_tag( 'div', :attributes => {:bug => "here", :another_bug => 'there'} ) end I am calling render :partial => '/bug/div' in the before :each block. As I said I would expect this to fail but it does not. I am trying this because in the /vendor/plugins/rspec_on_rails/spec/rails/dsl/view_spec_spec.rb file there is an example describe "A view that includes a partial using :collection and :spacer_template", :behaviour_type => :view do before(:each) do render "view_spec/partial_collection_including_template" end it "should render the partial w/ spacer_tamplate" do response.should have_tag('div', :content => 'Alice') response.should have_tag('hr', :attributes =>{:id => "spacer"}) response.should have_tag('div', :content => 'Bob') end end which does just this. Can anyone help please ? Cheers! sinclair -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070802/c3ed6209/attachment.html From dchelimsky at gmail.com Thu Aug 2 16:18:26 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 2 Aug 2007 15:18:26 -0500 Subject: [rspec-users] Do the :attributes and :content matchers work In-Reply-To: <2ca660dd0708021315qa701a95h7a13334daa625b89@mail.gmail.com> References: <2ca660dd0708021315qa701a95h7a13334daa625b89@mail.gmail.com> Message-ID: <57c63afe0708021318w60d74d6biecf4170e8f428ce@mail.gmail.com> On 8/2/07, sinclair bain wrote: > [Rails plugin 1.0.5] > > > Hi, > I am looking for some guidance. > When working on a partial which looks like this > >

> > I have some examples which should fail - I think - but do not: > > it ' should fail' do > response.should have_tag( 'div.bug', :content => 'There is no > content!' ) > end have_tag wraps the assert_select API. Basically, your hash (:content => ...) is being ignored. What you want to say is: response.should have_tag('div.bug', 'There is no content!') That should fail. Please report back. Thanks, David > > it ' should fail since there is no bug attribute with a value of > "here"' do > response.should have_tag( 'div', :attributes => {:bug => "here"} ) > response.should have_tag( 'div', :attributes => {:bug => "here", > :another_bug => 'there'} ) > end > > I am calling render :partial => '/bug/div' in the before :each block. > > As I said I would expect this to fail but it does not. > > I am trying this because in the > > > /vendor/plugins/rspec_on_rails/spec/rails/dsl/view_spec_spec.rb > > file there is an example > > describe "A view that includes a partial using :collection and > :spacer_template", :behaviour_type => :view do > > before(:each) do > render > "view_spec/partial_collection_including_template" > end > > it "should render the partial w/ spacer_tamplate" do > response.should have_tag('div', :content => 'Alice') > response.should have_tag('hr', :attributes =>{:id => "spacer"}) > response.should have_tag('div', :content => 'Bob') > end > > end > > which does just this. > > Can anyone help please ? > > Cheers! > sinclair > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Thu Aug 2 16:24:04 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 2 Aug 2007 15:24:04 -0500 Subject: [rspec-users] Do the :attributes and :content matchers work In-Reply-To: <2ca660dd0708021315qa701a95h7a13334daa625b89@mail.gmail.com> References: <2ca660dd0708021315qa701a95h7a13334daa625b89@mail.gmail.com> Message-ID: <57c63afe0708021324hcfc3921p6cdb46df1218ef33@mail.gmail.com> On 8/2/07, sinclair bain wrote: > [Rails plugin 1.0.5] > > > Hi, > I am looking for some guidance. > When working on a partial which looks like this > >

> > I have some examples which should fail - I think - but do not: > > it ' should fail' do > response.should have_tag( 'div.bug', :content => 'There is no > content!' ) > end > > it ' should fail since there is no bug attribute with a value of > "here"' do > response.should have_tag( 'div', :attributes => {:bug => "here"} ) > response.should have_tag( 'div', :attributes => {:bug => "here", > :another_bug => 'there'} ) > end > > I am calling render :partial => '/bug/div' in the before :each block. > > As I said I would expect this to fail but it does not. > > I am trying this because in the > > > /vendor/plugins/rspec_on_rails/spec/rails/dsl/view_spec_spec.rb > > file there is an example > > describe "A view that includes a partial using :collection and > :spacer_template", :behaviour_type => :view do > > before(:each) do > render > "view_spec/partial_collection_including_template" > end > > it "should render the partial w/ spacer_tamplate" do > response.should have_tag('div', :content => 'Alice') > response.should have_tag('hr', :attributes =>{:id => "spacer"}) > response.should have_tag('div', :content => 'Bob') > end Ugh. Those are holdovers from the old API and are only passing because :content and :attributes are being ignored. I'm updating them in rspec trunk to correctly reflect the API. > > end > > which does just this. > > Can anyone help please ? > > Cheers! > sinclair > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From philipp.engel at filzip.com Fri Aug 3 06:29:16 2007 From: philipp.engel at filzip.com (Philipp Engel) Date: Fri, 3 Aug 2007 10:29:16 +0000 (UTC) Subject: [rspec-users] more different predicates (not only should)? Message-ID: Hello, I am using rspec in a project and would like to know if you have thought about adding a feature. RSpec as I know it currently only knows about the predicate 'should'. What I have in mind would look something like this: it :should "have a valid name" now should is not part of the spec text, but a symbol. Then you could think of things like that: it :must "have a valid name" it :shall "have a valid name" so you can define some criticality, and if specs fail, you know what has a higher priority. Also, there could be a predicate that allows you to write down spec for future versions that do not have to work and are not shown when running the test in normal mode it :in_future_version_must "have a valid name" or something like that. Is something like that already planned or, if not, what do you think about a feature like this? From mailing_lists at railsnewbie.com Fri Aug 3 06:49:49 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Fri, 3 Aug 2007 06:49:49 -0400 Subject: [rspec-users] more different predicates (not only should)? In-Reply-To: References: Message-ID: <0B045C1F-CEB6-4426-8288-E660D1857D43@railsnewbie.com> On Aug 3, 2007, at 6:29 AM, Philipp Engel wrote: > Hello, > > I am using rspec in a project and would like to know if you have > thought about adding a feature. > RSpec as I know it currently only knows about the predicate 'should'. > What I have in mind would look something like this: > > it :should "have a valid name" > > now should is not part of the spec text, but a symbol. Then you > could think of things like that: > > it :must "have a valid name" > it :shall "have a valid name" > > so you can define some criticality, and if specs fail, you know > what has a higher priority. Also, there could be a predicate What would be the different levels of priority, and how would they be rated? As far as I've been doing it, BDD usually encourages example specification => implementing the spec => refactoring, and then repeating the process until your feature set is where you want it to be. Usually the only time a bunch of specs will fail is when you are doing some major refactoring, and so usually I look to refactor in a different way. From what I understand, there was once a time (long ago, something like pre v. 0.1) when these three names were all being considered as equals. Should won, and must lost. > that allows you to write down spec for future versions that do not > have to work and are not shown when running the test in normal mode > > it :in_future_version_must "have a valid name" > > or something like that. yep. That's the unimplemented spec. Don't provide a block, and the runner will let you know that the feature hasn't been implemented. So your example would be: it "should have a valid name" New on trunk is also the pending() method, which allows you to write the desired behaviour without it being implemented. It considers the spec as an unimplemented spec. Best, Scott From daniel at danielfischer.com Fri Aug 3 15:30:33 2007 From: daniel at danielfischer.com (Fischer, Daniel) Date: Fri, 3 Aug 2007 12:30:33 -0700 Subject: [rspec-users] Plugins 'speced' with rSpec? Message-ID: <7e565b5c0708031230wa0a51t1677136a8b4d571f@mail.gmail.com> Hello, I'm trying to figure out how to setup a spec structure for plugins. I'm getting pretty lost in figuring out how to isolate a plugin enviornment emulating rails, but not actually being reflected upon the current rails project. What I mean is this, let's say I have a comment plugin. This has two things in lib, the comment model (comment.rb) and then the module ruby file for methods. I'm trying to figure out how I would spec this out in the actual plugin directory (vendor/plugins/comment_plugin/spec). What would my spec_helper look like? How would I spec that it works? Why I'm saying this is because I can't use any of the /app/models/ in the rails project because that is specific to a rails project, I'm trying to isolate it into the plugin. How would I fake a model in rspec, especially with the line that "acts_as_comment" which sets up the polymorphic association. If anyone has any advice, or knows of any plugins that are tested with rspec and not rails testing, let me know. Thanks. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070803/09f9e2af/attachment-0001.html From lists-rspec at shopwatch.org Fri Aug 3 15:42:57 2007 From: lists-rspec at shopwatch.org (Jay Levitt) Date: Fri, 03 Aug 2007 15:42:57 -0400 Subject: [rspec-users] Plugins 'speced' with rSpec? In-Reply-To: <7e565b5c0708031230wa0a51t1677136a8b4d571f@mail.gmail.com> References: <7e565b5c0708031230wa0a51t1677136a8b4d571f@mail.gmail.com> Message-ID: <46B38541.5020603@jay.fm> Fischer, Daniel wrote: > Hello, > > I'm trying to figure out how to setup a spec structure for plugins. I'm > getting pretty lost in figuring out how to isolate a plugin enviornment > emulating rails, but not actually being reflected upon the current rails > project. I just saw an article yesterday about this very topic, though of course it's Test::Unit-focused, not rspec: http://www.pluginaweek.org/2006/11/24/plugin-tip-of-the-week-testing-your-plugins-the-right-way/ From pergesu at gmail.com Fri Aug 3 15:47:05 2007 From: pergesu at gmail.com (Pat Maddox) Date: Fri, 3 Aug 2007 12:47:05 -0700 Subject: [rspec-users] Plugins 'speced' with rSpec? In-Reply-To: <7e565b5c0708031230wa0a51t1677136a8b4d571f@mail.gmail.com> References: <7e565b5c0708031230wa0a51t1677136a8b4d571f@mail.gmail.com> Message-ID: <810a540e0708031247o3c40cb72q67ac84664f9b1b0c@mail.gmail.com> On 8/3/07, Fischer, Daniel wrote: > Hello, > > I'm trying to figure out how to setup a spec structure for plugins. I'm > getting pretty lost in figuring out how to isolate a plugin enviornment > emulating rails, but not actually being reflected upon the current rails > project. > > What I mean is this, let's say I have a comment plugin. This has two things > in lib, the comment model (comment.rb) and then the module ruby file for > methods. > > I'm trying to figure out how I would spec this out in the actual plugin > directory (vendor/plugins/comment_plugin/spec). What would > my spec_helper look like? How would I spec that it works? Why I'm saying > this is because I can't use any of the /app/models/ in the rails project > because that is specific to a rails project, I'm trying to isolate it into > the plugin. How would I fake a model in rspec, especially with the line > that "acts_as_comment" which sets up the polymorphic association. If anyone > has any advice, or knows of any plugins that are tested with rspec and not > rails testing, let me know. > > > Thanks. > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > Hey Daniel, You might be interested in the rspec_plugin generator. http://agilewebdevelopment.com/plugins/rspec_plugin Pat From justnothing at tiscali.co.uk Sat Aug 4 09:06:24 2007 From: justnothing at tiscali.co.uk (David Green) Date: Sat, 4 Aug 2007 06:06:24 -0700 (PDT) Subject: [rspec-users] reusable specs - almost there Message-ID: <11996399.post@talk.nabble.com> I have a lot of controllers with virtually identical functionality for most actions. I've been using shared behaviours to DRY things up a bit, but I still have to create separate behaviours for each context before I can use the shared behaviours what I have now is a generic file which contains all the behaviours and examples common to all the controllers, and that file gets loaded from an actual controller spec. The generic file knows which controller to test by calling kontroller(), which is defined in the controller spec. here's a very simplified example: http://pastebin.com/m6b47bae9 It works great when I run the specs individually, but when I use rake, specs begin to fail and i think it's because the value of kontroller() is set to whatever it returns the first time it gets called. Here's the rake output from running the specs shown above: FooController .FooController . Finished in 0.041793 seconds 2 examples, 0 failures I would expect it to print FooController and then BarController ... interestingly, if I insert 'puts kontroller.to_s' *outside* of the describe block, then it does output the names of both controllers as expected. does anyone know of a solution? thanks dave -- View this message in context: http://www.nabble.com/reusable-specs---almost-there-tf4216708.html#a11996399 Sent from the rspec-users mailing list archive at Nabble.com. From dchelimsky at gmail.com Sun Aug 5 11:57:38 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Sun, 5 Aug 2007 10:57:38 -0500 Subject: [rspec-users] reusable specs - almost there In-Reply-To: <11996399.post@talk.nabble.com> References: <11996399.post@talk.nabble.com> Message-ID: <57c63afe0708050857x61afe07aiedafcea9f4961698@mail.gmail.com> On 8/4/07, David Green wrote: > > I have a lot of controllers with virtually identical functionality for most > actions. I've been using shared behaviours to DRY things up a bit, but I > still have to create separate behaviours for each context before I can use > the shared behaviours > > what I have now is a generic file which contains all the behaviours and > examples common to all the controllers, and that file gets loaded from an > actual controller spec. The generic file knows which controller to test by > calling kontroller(), which is defined in the controller spec. > > here's a very simplified example: > http://pastebin.com/m6b47bae9 > > It works great when I run the specs individually, but when I use rake, specs > begin to fail and i think it's because the value of kontroller() is set to > whatever it returns the first time it gets called. Here's the rake output > from running the specs shown above: > > > FooController > .FooController > . > > Finished in 0.041793 seconds > 2 examples, 0 failures > > I would expect it to print FooController and then BarController ... > interestingly, if I insert 'puts kontroller.to_s' *outside* of the describe > block, then it does output the names of both controllers as expected. > > does anyone know of a solution? > thanks > > dave I'm all for keeping things DRY, but NEVER at the risk of clarity. You've got to balance DRY and readability/clarity. Anybody familiar with rspec can look at this: ========================= describe FooController do it_should_behave_like "All Controllers" end ========================= and understand what that means: A FooController should behave like All Controllers. Perhaps there is a split second of mental mapping: "Oh, there must be some behaviour described for all controllers that the FooController should adopt." Compare that to your example: ========================= def kontroller FooController end load File.dirname(__FILE__) + '/all_controllers.rb' ========================= First of all - how is that any more DRY than the example above? Perhaps you save a few keystrokes, but if you think that makes it more DRY then you don't really understand what DRY is all about. Second of all, what does it actually mean? Where's the story? How is a non-developer going to look at that and have any context for what that means? I'm a developer and I don't know what it means. Sure I can figure it out, but, in my opinion, it's just nowhere near as clear as the example above. FWIW, David From justnothing at tiscali.co.uk Sun Aug 5 15:43:16 2007 From: justnothing at tiscali.co.uk (David Green) Date: Sun, 5 Aug 2007 12:43:16 -0700 (PDT) Subject: [rspec-users] reusable specs - almost there In-Reply-To: <57c63afe0708050857x61afe07aiedafcea9f4961698@mail.gmail.com> References: <11996399.post@talk.nabble.com> <57c63afe0708050857x61afe07aiedafcea9f4961698@mail.gmail.com> Message-ID: <12007548.post@talk.nabble.com> that's a great point, but there are some things about shared behaviours I don't like. for example, I have 14 different contexts I'm testing (and more to come) in 8 controllers. I can do this: describe MyController do it_should_behave_like "context 1" it_should_behave_like "context 2" . . it_should_behave_like "context 14" end but then I lose the context info in the output, it just displays one long list of examples. The alternative is: describe MyController, "context 1" do it_should_behave_like "context 1" end describe MyController, "context 2" do it_should_behave_like "context 2" end . . describe MyController, "context 14" do it_should_behave_like "context 14" end this way the context info is preserved in the output, but it's more work, especially across 8 controllers. another thing is, depending on the model being used, controllers will instantiate variables of different names. e.g. in the "dvd" controller, an instance of the Dvd model would be stored in @dvd, whereas in the "book" controller, it would be in @book . using dynamic specs, I can make my examples more specific depending on the controller being tested e.g. : # obj and var passed in as parameters it "should load a #{obj.class} object into @#{varname}" do get :show assigns[var_name].should == obj end I could put obj and varname into instance variables in the before() method, but they're only available in the example block, not from the example title these are minor complaints really, but as my project grows, they become more of an issue. David Chelimsky-2 wrote: > > On 8/4/07, David Green wrote: >> >> I have a lot of controllers with virtually identical functionality for >> most >> actions. I've been using shared behaviours to DRY things up a bit, but I >> still have to create separate behaviours for each context before I can >> use >> the shared behaviours >> >> what I have now is a generic file which contains all the behaviours and >> examples common to all the controllers, and that file gets loaded from an >> actual controller spec. The generic file knows which controller to test >> by >> calling kontroller(), which is defined in the controller spec. >> >> here's a very simplified example: >> http://pastebin.com/m6b47bae9 >> >> It works great when I run the specs individually, but when I use rake, >> specs >> begin to fail and i think it's because the value of kontroller() is set >> to >> whatever it returns the first time it gets called. Here's the rake output >> from running the specs shown above: >> >> >> FooController >> .FooController >> . >> >> Finished in 0.041793 seconds >> 2 examples, 0 failures >> >> I would expect it to print FooController and then BarController ... >> interestingly, if I insert 'puts kontroller.to_s' *outside* of the >> describe >> block, then it does output the names of both controllers as expected. >> >> does anyone know of a solution? >> thanks >> >> dave > > I'm all for keeping things DRY, but NEVER at the risk of clarity. > You've got to balance DRY and readability/clarity. Anybody familiar > with rspec can look at this: > > ========================= > describe FooController do > it_should_behave_like "All Controllers" > end > ========================= > > and understand what that means: A FooController should behave like All > Controllers. Perhaps there is a split second of mental mapping: "Oh, > there must be some behaviour described for all controllers that the > FooController should adopt." > > Compare that to your example: > > ========================= > def kontroller > FooController > end > > load File.dirname(__FILE__) + '/all_controllers.rb' > ========================= > > First of all - how is that any more DRY than the example above? > Perhaps you save a few keystrokes, but if you think that makes it more > DRY then you don't really understand what DRY is all about. > > Second of all, what does it actually mean? Where's the story? How is a > non-developer going to look at that and have any context for what that > means? I'm a developer and I don't know what it means. Sure I can > figure it out, but, in my opinion, it's just nowhere near as clear as > the example above. > > FWIW, > David > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > > -- View this message in context: http://www.nabble.com/reusable-specs---almost-there-tf4216708.html#a12007548 Sent from the rspec-users mailing list archive at Nabble.com. From pergesu at gmail.com Sun Aug 5 16:18:15 2007 From: pergesu at gmail.com (Pat Maddox) Date: Sun, 5 Aug 2007 13:18:15 -0700 Subject: [rspec-users] reusable specs - almost there In-Reply-To: <12007548.post@talk.nabble.com> References: <11996399.post@talk.nabble.com> <57c63afe0708050857x61afe07aiedafcea9f4961698@mail.gmail.com> <12007548.post@talk.nabble.com> Message-ID: <810a540e0708051318jaa7d362w2efba62a335a5422@mail.gmail.com> I agree with David, I think this is too much magic. You'll often have more duplication in specs than you will in production code. That's not a bad thing though, because specs need to be explicit about the behavior being performed. Duplication doesn't lead to the same mistakes that it does in production code. You can and should factor out stuff when doing so won't hurt the clarity of the specs. However when you have to think hard to figure out what's going on, you lose one of the main benefits of RSpec. It's all about making your spec code easy to parse. Solving the problem of 14 different shared contexts isn't really hard. %w(admin_context regular_user_context manager_context).each do |con| describe MyController do it_should_be_have_like con end end Pat On 8/5/07, David Green wrote: > > that's a great point, but there are some things about shared behaviours I > don't like. for example, I have 14 different contexts I'm testing (and more > to come) in 8 controllers. > > I can do this: > > describe MyController do > it_should_behave_like "context 1" > it_should_behave_like "context 2" > . > . > it_should_behave_like "context 14" > end > > but then I lose the context info in the output, it just displays one long > list of examples. > The alternative is: > > describe MyController, "context 1" do > it_should_behave_like "context 1" > end > describe MyController, "context 2" do > it_should_behave_like "context 2" > end > . > . > describe MyController, "context 14" do > it_should_behave_like "context 14" > end > > this way the context info is preserved in the output, but it's more work, > especially across 8 controllers. > > another thing is, depending on the model being used, controllers will > instantiate variables of different names. e.g. in the "dvd" controller, an > instance of the Dvd model would be stored in @dvd, whereas in the "book" > controller, it would be in @book . using dynamic specs, I can make my > examples more specific depending on the controller being tested e.g. : > > # obj and var passed in as parameters > it "should load a #{obj.class} object into @#{varname}" do > get :show > assigns[var_name].should == obj > end > > I could put obj and varname into instance variables in the before() method, > but they're only available in the example block, not from the example title > > these are minor complaints really, but as my project grows, they become more > of an issue. > > > > David Chelimsky-2 wrote: > > > > On 8/4/07, David Green wrote: > >> > >> I have a lot of controllers with virtually identical functionality for > >> most > >> actions. I've been using shared behaviours to DRY things up a bit, but I > >> still have to create separate behaviours for each context before I can > >> use > >> the shared behaviours > >> > >> what I have now is a generic file which contains all the behaviours and > >> examples common to all the controllers, and that file gets loaded from an > >> actual controller spec. The generic file knows which controller to test > >> by > >> calling kontroller(), which is defined in the controller spec. > >> > >> here's a very simplified example: > >> http://pastebin.com/m6b47bae9 > >> > >> It works great when I run the specs individually, but when I use rake, > >> specs > >> begin to fail and i think it's because the value of kontroller() is set > >> to > >> whatever it returns the first time it gets called. Here's the rake output > >> from running the specs shown above: > >> > >> > >> FooController > >> .FooController > >> . > >> > >> Finished in 0.041793 seconds > >> 2 examples, 0 failures > >> > >> I would expect it to print FooController and then BarController ... > >> interestingly, if I insert 'puts kontroller.to_s' *outside* of the > >> describe > >> block, then it does output the names of both controllers as expected. > >> > >> does anyone know of a solution? > >> thanks > >> > >> dave > > > > I'm all for keeping things DRY, but NEVER at the risk of clarity. > > You've got to balance DRY and readability/clarity. Anybody familiar > > with rspec can look at this: > > > > ========================= > > describe FooController do > > it_should_behave_like "All Controllers" > > end > > ========================= > > > > and understand what that means: A FooController should behave like All > > Controllers. Perhaps there is a split second of mental mapping: "Oh, > > there must be some behaviour described for all controllers that the > > FooController should adopt." > > > > Compare that to your example: > > > > ========================= > > def kontroller > > FooController > > end > > > > load File.dirname(__FILE__) + '/all_controllers.rb' > > ========================= > > > > First of all - how is that any more DRY than the example above? > > Perhaps you save a few keystrokes, but if you think that makes it more > > DRY then you don't really understand what DRY is all about. > > > > Second of all, what does it actually mean? Where's the story? How is a > > non-developer going to look at that and have any context for what that > > means? I'm a developer and I don't know what it means. Sure I can > > figure it out, but, in my opinion, it's just nowhere near as clear as > > the example above. > > > > FWIW, > > David > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > -- > View this message in context: http://www.nabble.com/reusable-specs---almost-there-tf4216708.html#a12007548 > Sent from the rspec-users mailing list archive at Nabble.com. > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Sun Aug 5 17:52:18 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Sun, 5 Aug 2007 16:52:18 -0500 Subject: [rspec-users] reusable specs - almost there In-Reply-To: <12007548.post@talk.nabble.com> References: <11996399.post@talk.nabble.com> <57c63afe0708050857x61afe07aiedafcea9f4961698@mail.gmail.com> <12007548.post@talk.nabble.com> Message-ID: <57c63afe0708051452h3a4e4013saae007fd30c2c68a@mail.gmail.com> On 8/5/07, David Green wrote: > > that's a great point, but there are some things about shared behaviours I > don't like. for example, I have 14 different contexts I'm testing (and more > to come) in 8 controllers. > > I can do this: > > describe MyController do > it_should_behave_like "context 1" > it_should_behave_like "context 2" > . > . > it_should_behave_like "context 14" > end > > but then I lose the context info in the output, it just displays one long > list of examples. Interesting. This is kind of backwards from how I envision shared behaviours. To me, a shared behaviour is a behaviour that is shared across objects, not contexts. In other words: describe "any controller", :shared => true do it "should do a when b" { ... } end describe "a specific controller" do it_should_behave_like "any controller" end As opposed to: describe "any controller when the user is logged in", :shared => true do it "should do a when b" { ... } end describe "a specific controller" do it_should_behave_like "any controller when the user is logged in" end Subtle difference, but I'm sure it guides in a different direction. The problem you're experiencing is not new, and I'm definitely interested in discussing solutions for it, but I'm much more interested in ways rspec could improve than ways to work around rspec's deficiencies. > The alternative is: > > describe MyController, "context 1" do > it_should_behave_like "context 1" > end > describe MyController, "context 2" do > it_should_behave_like "context 2" > end > . > . > describe MyController, "context 14" do > it_should_behave_like "context 14" > end > > this way the context info is preserved in the output, but it's more work, > especially across 8 controllers. > > another thing is, depending on the model being used, controllers will > instantiate variables of different names. e.g. in the "dvd" controller, an > instance of the Dvd model would be stored in @dvd, whereas in the "book" > controller, it would be in @book . using dynamic specs, I can make my > examples more specific depending on the controller being tested e.g. : > > # obj and var passed in as parameters > it "should load a #{obj.class} object into @#{varname}" do > get :show > assigns[var_name].should == obj > end > > I could put obj and varname into instance variables in the before() method, > but they're only available in the example block, not from the example title > > these are minor complaints really, but as my project grows, they become more > of an issue. Understood - although, if all of these controllers are behaving exactly the same way with only a variable name or two difference, it seems to me that the duplication problem is in the code, not the specs. Perhaps there is some common code that could be extracted to a module - then you can have specs for that module and specify that the module should be included in each of your controllers. WDYT? > > > > David Chelimsky-2 wrote: > > > > On 8/4/07, David Green wrote: > >> > >> I have a lot of controllers with virtually identical functionality for > >> most > >> actions. I've been using shared behaviours to DRY things up a bit, but I > >> still have to create separate behaviours for each context before I can > >> use > >> the shared behaviours > >> > >> what I have now is a generic file which contains all the behaviours and > >> examples common to all the controllers, and that file gets loaded from an > >> actual controller spec. The generic file knows which controller to test > >> by > >> calling kontroller(), which is defined in the controller spec. > >> > >> here's a very simplified example: > >> http://pastebin.com/m6b47bae9 > >> > >> It works great when I run the specs individually, but when I use rake, > >> specs > >> begin to fail and i think it's because the value of kontroller() is set > >> to > >> whatever it returns the first time it gets called. Here's the rake output > >> from running the specs shown above: > >> > >> > >> FooController > >> .FooController > >> . > >> > >> Finished in 0.041793 seconds > >> 2 examples, 0 failures > >> > >> I would expect it to print FooController and then BarController ... > >> interestingly, if I insert 'puts kontroller.to_s' *outside* of the > >> describe > >> block, then it does output the names of both controllers as expected. > >> > >> does anyone know of a solution? > >> thanks > >> > >> dave > > > > I'm all for keeping things DRY, but NEVER at the risk of clarity. > > You've got to balance DRY and readability/clarity. Anybody familiar > > with rspec can look at this: > > > > ========================= > > describe FooController do > > it_should_behave_like "All Controllers" > > end > > ========================= > > > > and understand what that means: A FooController should behave like All > > Controllers. Perhaps there is a split second of mental mapping: "Oh, > > there must be some behaviour described for all controllers that the > > FooController should adopt." > > > > Compare that to your example: > > > > ========================= > > def kontroller > > FooController > > end > > > > load File.dirname(__FILE__) + '/all_controllers.rb' > > ========================= > > > > First of all - how is that any more DRY than the example above? > > Perhaps you save a few keystrokes, but if you think that makes it more > > DRY then you don't really understand what DRY is all about. > > > > Second of all, what does it actually mean? Where's the story? How is a > > non-developer going to look at that and have any context for what that > > means? I'm a developer and I don't know what it means. Sure I can > > figure it out, but, in my opinion, it's just nowhere near as clear as > > the example above. > > > > FWIW, > > David > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > -- > View this message in context: http://www.nabble.com/reusable-specs---almost-there-tf4216708.html#a12007548 > Sent from the rspec-users mailing list archive at Nabble.com. > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Sun Aug 5 22:12:06 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Sun, 5 Aug 2007 22:12:06 -0400 Subject: [rspec-users] Stubbing Enumerable#each Message-ID: <97C3CAEE-624F-4D68-9A31-6CA3A2862343@railsnewbie.com> I have a mock of an instance of a class which descends from Array: class ArrayDescendent < Array; end #... in the specs... @descendent = mock ArrayDescendent How would I stub out ArrayDescendent#each, which is inherited from Array, to return multiple values successively? I could use and_yield, but that is raising an arity error (the anonymous function/ block should expect only *one value at a time, but and_yield is yielding both values once). Should I be using a lambda expression here? Tips are welcome...Thanks, Scott From mailing_lists at railsnewbie.com Mon Aug 6 01:13:47 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Mon, 6 Aug 2007 01:13:47 -0400 Subject: [rspec-users] pending w/ no string Message-ID: <45BDB9EB-EC87-40AD-8F1C-092AC5352DC4@railsnewbie.com> Is there some reason that pending() *MUST* take an argument? Scott From pergesu at gmail.com Mon Aug 6 02:16:53 2007 From: pergesu at gmail.com (Pat Maddox) Date: Sun, 5 Aug 2007 23:16:53 -0700 Subject: [rspec-users] Stubbing Enumerable#each In-Reply-To: <97C3CAEE-624F-4D68-9A31-6CA3A2862343@railsnewbie.com> References: <97C3CAEE-624F-4D68-9A31-6CA3A2862343@railsnewbie.com> Message-ID: <810a540e0708052316q5f7f5b69y4457a001608675a4@mail.gmail.com> On 8/5/07, Scott Taylor wrote: > > I have a mock of an instance of a class which descends from Array: > > class ArrayDescendent < Array; end > > #... in the specs... > @descendent = mock ArrayDescendent > > How would I stub out ArrayDescendent#each, which is inherited from > Array, to return multiple values successively? I could use > and_yield, but that is raising an arity error (the anonymous function/ > block should expect only *one value at a time, but and_yield is > yielding both values once). Should I be using a lambda expression here? > > Tips are welcome...Thanks, > > Scott > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > Hey Scott, I'm not sure if there's a way you can currently do that (there may be and I just couldn't figure it out). However I agree it's useful, and I whipped up a quick patch to provide that behavior. http://rubyforge.org/tracker/index.php?func=detail&aid=12841&group_id=797&atid=3151 My example spec is it "should support yielding consecutive values" do yielded_values = [] @obj.stub!(:method_that_yields).and_yield_consecutively("abc", 123, :foobar) @obj.method_that_yields {|val| yielded_values << val } yielded_values.should == [ "abc", 123, :foobar ] @obj.rspec_verify end How's that? Pat From mailing_lists at railsnewbie.com Mon Aug 6 02:53:47 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Mon, 6 Aug 2007 02:53:47 -0400 Subject: [rspec-users] using RSpec's trunk in non-rails projects w/ Autotest Message-ID: <3C103E41-DEBC-4389-A0AB-E4F42CDE6338@railsnewbie.com> I believe for rails projects you can put rspec's code repos into vendor/plugins, and autotest will automatically use the rspec binary in that directory, and not the gem installed. Is there an easy way to do this for non-rails projects? There are a few advancements on trunk which I would like to take advantage of. Tips welcome ; ). Scott Taylor From dchelimsky at gmail.com Mon Aug 6 07:19:49 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 6 Aug 2007 06:19:49 -0500 Subject: [rspec-users] pending w/ no string In-Reply-To: <45BDB9EB-EC87-40AD-8F1C-092AC5352DC4@railsnewbie.com> References: <45BDB9EB-EC87-40AD-8F1C-092AC5352DC4@railsnewbie.com> Message-ID: <57c63afe0708060419p7499b4e4k5d4898ebc18bbbef@mail.gmail.com> On 8/6/07, Scott Taylor wrote: > > Is there some reason that pending() *MUST* take an argument? There was no discussion of this when the feature was contributed. Thinking about it now, to allow for no arg would require good default messages - one for when there is a block and one for when there is not. As long as you can come up w/ messages that really make sense in all situations, then a patch would be welcome. > > Scott > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Mon Aug 6 07:29:52 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Mon, 6 Aug 2007 07:29:52 -0400 Subject: [rspec-users] pending w/ no string In-Reply-To: <57c63afe0708060419p7499b4e4k5d4898ebc18bbbef@mail.gmail.com> References: <45BDB9EB-EC87-40AD-8F1C-092AC5352DC4@railsnewbie.com> <57c63afe0708060419p7499b4e4k5d4898ebc18bbbef@mail.gmail.com> Message-ID: On Aug 6, 2007, at 7:19 AM, David Chelimsky wrote: > On 8/6/07, Scott Taylor wrote: >> >> Is there some reason that pending() *MUST* take an argument? > > There was no discussion of this when the feature was contributed. > Thinking about it now, to allow for no arg would require good default > messages - one for when there is a block and one for when there is > not. As long as you can come up w/ messages that really make sense in > all situations, then a patch would be welcome. How about accepting no arguments if no block is given? Scott From dchelimsky at gmail.com Mon Aug 6 07:46:39 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 6 Aug 2007 06:46:39 -0500 Subject: [rspec-users] pending w/ no string In-Reply-To: References: <45BDB9EB-EC87-40AD-8F1C-092AC5352DC4@railsnewbie.com> <57c63afe0708060419p7499b4e4k5d4898ebc18bbbef@mail.gmail.com> Message-ID: <57c63afe0708060446t7ef0c43bie4d640d542455f26@mail.gmail.com> On 8/6/07, Scott Taylor wrote: > > On Aug 6, 2007, at 7:19 AM, David Chelimsky wrote: > > > On 8/6/07, Scott Taylor wrote: > >> > >> Is there some reason that pending() *MUST* take an argument? > > > > There was no discussion of this when the feature was contributed. > > Thinking about it now, to allow for no arg would require good default > > messages - one for when there is a block and one for when there is > > not. As long as you can come up w/ messages that really make sense in > > all situations, then a patch would be welcome. > > How about accepting no arguments if no block is given? I think that would be more confusing - it should work the same way for both situations. > > Scott > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lists-rspec at shopwatch.org Mon Aug 6 12:20:31 2007 From: lists-rspec at shopwatch.org (Jay Levitt) Date: Mon, 06 Aug 2007 12:20:31 -0400 Subject: [rspec-users] Specifying custom rails FormBuilders Message-ID: <46B74A4F.70705@jay.fm> I want to write a spec for a custom form builder, but I'm not really sure where it should live or how to include the right rspec_on_rails contexts. Ideally, I should be able to write a spec like: describe LabelledBuilder do it "should let me create a text field" do object = mock(object) object.stub!(:attribute).and_return("Test String") render :inline => "<% form_for(@object, :builder => LabelledBuilder) do |f| -%> <%= f.text_field :attribute %> <% end %>" response.should have_tag("label") end end but I'm not having much luck. Can anyone give me an idea where to start? Jay From dchelimsky at gmail.com Mon Aug 6 12:23:06 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 6 Aug 2007 11:23:06 -0500 Subject: [rspec-users] Specifying custom rails FormBuilders In-Reply-To: <46B74A4F.70705@jay.fm> References: <46B74A4F.70705@jay.fm> Message-ID: <57c63afe0708060923s222b5e56s2f30d83b88ef2880@mail.gmail.com> On 8/6/07, Jay Levitt wrote: > I want to write a spec for a custom form builder, but I'm not really > sure where it should live or how to include the right rspec_on_rails > contexts. Ideally, I should be able to write a spec like: > > > describe LabelledBuilder do > > it "should let me create a text field" do > object = mock(object) > object.stub!(:attribute).and_return("Test String") > > render :inline => > "<% form_for(@object, :builder => LabelledBuilder) do |f| -%> > <%= f.text_field :attribute %> > <% end %>" > > response.should have_tag("label") > end > end > > > but I'm not having much luck. How so? What error do you get from that? > Can anyone give me an idea where to start? > > Jay > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lists-rspec at shopwatch.org Mon Aug 6 12:42:07 2007 From: lists-rspec at shopwatch.org (Jay Levitt) Date: Mon, 06 Aug 2007 12:42:07 -0400 Subject: [rspec-users] Specifying custom rails FormBuilders In-Reply-To: <57c63afe0708060923s222b5e56s2f30d83b88ef2880@mail.gmail.com> References: <46B74A4F.70705@jay.fm> <57c63afe0708060923s222b5e56s2f30d83b88ef2880@mail.gmail.com> Message-ID: <46B74F5F.2030005@jay.fm> David Chelimsky wrote: > On 8/6/07, Jay Levitt wrote: >> I want to write a spec for a custom form builder, but I'm not really >> sure where it should live or how to include the right rspec_on_rails >> contexts. Ideally, I should be able to write a spec like: >> >> >> describe LabelledBuilder do >> >> it "should let me create a text field" do >> object = mock(object) >> object.stub!(:attribute).and_return("Test String") >> >> render :inline => >> "<% form_for(@object, :builder => LabelledBuilder) do |f| -%> >> <%= f.text_field :attribute %> >> <% end %>" >> >> response.should have_tag("label") >> end >> end >> >> >> but I'm not having much luck. > > How so? What error do you get from that? Well, if I put it in spec/helpers, where I expected it to work, I get: NoMethodError in 'LabelledBuilder should let me create a text field' undefined method `render' for [Dynamically generated class for RSpec example]:# ./spec/helpers/labelled_builder_spec.rb:15: If I instead put it in spec/views, I get: Exception in 'LabelledBuilder should let me create a text field' Unhandled render type in view spec. /Users/jay/Documents/eclipse/mediajoint/vendor/plugins/rspec_on_rails/lib/spec/rails/dsl/behaviour/view.rb:133:in `subject_of_render' /Users/jay/Documents/eclipse/mediajoint/vendor/plugins/rspec_on_rails/lib/spec/rails/dsl/behaviour/view.rb:118:in `derived_controller_name' /Users/jay/Documents/eclipse/mediajoint/vendor/plugins/rspec_on_rails/lib/spec/rails/dsl/behaviour/view.rb:114:in `base_view_path' /Users/jay/Documents/eclipse/mediajoint/vendor/plugins/rspec_on_rails/lib/spec/rails/dsl/behaviour/view.rb:110:in `set_base_view_path' /Users/jay/Documents/eclipse/mediajoint/vendor/plugins/rspec_on_rails/lib/spec/rails/dsl/behaviour/view.rb:27:in `render' ./spec/views/labelled_builder_spec.rb:15: which makes sense, since subject_of_render doesn't seem to handle inline rendering... but of course, if I move it out into a file and render it there, I have to make one fake view per test case. Jay From gramos at rectorado.unl.edu.ar Mon Aug 6 13:17:15 2007 From: gramos at rectorado.unl.edu.ar (Gaston Ramos) Date: Mon, 6 Aug 2007 13:17:15 -0400 Subject: [rspec-users] Problems with array mock Message-ID: <20070806171715.GA15788@marlasina> Hi everyone, I'm trying this in my helper spec and it didn't work: @curr_odontogram.should_receive('photos[1]').and_return(@photo) and the error is: SyntaxError in 'PersonHelper Deberia devolverme un link para eliminar una foto' compile error /home/gramos/src/rails/r-dental/config/../vendor/plugins/rspec/lib/spec/mocks/proxy.rb:99: syntax error, unexpected '[', expecting '\n' or ';' def photos[1](*args, &block) does anyone have a good solution for this? the complete code of the helper: http://pastie.caboo.se/85287 the complete code of the spec helper: http://pastie.caboo.se/85289 See you. -- Gast?n Ramos GNU/Linux Counter user #450312 http://gastonramos.wordpress.com/ No a la Matricula Obligatoria http://noalamatricula.wordpress.com/about/ From dchelimsky at gmail.com Mon Aug 6 12:52:28 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 6 Aug 2007 11:52:28 -0500 Subject: [rspec-users] Problems with array mock In-Reply-To: <20070806171715.GA15788@marlasina> References: <20070806171715.GA15788@marlasina> Message-ID: <57c63afe0708060952y7223e442sbc1fb716f45a03e7@mail.gmail.com> On 8/6/07, Gaston Ramos wrote: > > Hi everyone, > > I'm trying this in my helper spec and it didn't work: > > @curr_odontogram.should_receive('photos[1]').and_return(@photo) > > and the error is: > > SyntaxError in 'PersonHelper Deberia devolverme un link para eliminar una foto' > compile error > /home/gramos/src/rails/r-dental/config/../vendor/plugins/rspec/lib/spec/mocks/proxy.rb:99: > syntax error, unexpected '[', expecting '\n' or ';' > def photos[1](*args, &block) > > does anyone have a good solution for this? > > the complete code of the helper: > > http://pastie.caboo.se/85287 > > the complete code of the spec helper: > > http://pastie.caboo.se/85289 This is ruby magic causing confusion. When you call foo.photos[1], you're actually calling foo.photos[](1) (though that won't work) - so I *think* the expectation should read: @curr_odontogram.should_receive(:photos[]).with(1).and_return(@photo) Give that a try. > > > See you. > -- > Gast?n Ramos > > GNU/Linux Counter user #450312 > http://gastonramos.wordpress.com/ > > No a la Matricula Obligatoria > http://noalamatricula.wordpress.com/about/ > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From gramos at rectorado.unl.edu.ar Mon Aug 6 15:04:47 2007 From: gramos at rectorado.unl.edu.ar (Gaston Ramos) Date: Mon, 6 Aug 2007 15:04:47 -0400 Subject: [rspec-users] Problems with array mock In-Reply-To: <57c63afe0708060952y7223e442sbc1fb716f45a03e7@mail.gmail.com> References: <20070806171715.GA15788@marlasina> <57c63afe0708060952y7223e442sbc1fb716f45a03e7@mail.gmail.com> Message-ID: <20070806190447.GA23845@marlasina> El lun, 06 de ago de 2007, a las 11:52:28 -0500, David Chelimsky dijo: > On 8/6/07, Gaston Ramos wrote: > > > > Hi everyone, > > > > I'm trying this in my helper spec and it didn't work: > > > > @curr_odontogram.should_receive('photos[1]').and_return(@photo) > > > > and the error is: > > > > SyntaxError in 'PersonHelper Deberia devolverme un link para eliminar una foto' > > compile error > > /home/gramos/src/rails/r-dental/config/../vendor/plugins/rspec/lib/spec/mocks/proxy.rb:99: > > syntax error, unexpected '[', expecting '\n' or ';' > > def photos[1](*args, &block) > > > > does anyone have a good solution for this? > > > > the complete code of the helper: > > > > http://pastie.caboo.se/85287 > > > > the complete code of the spec helper: > > > > http://pastie.caboo.se/85289 > > This is ruby magic causing confusion. When you call foo.photos[1], > you're actually calling foo.photos[](1) (though that won't work) - so > I *think* the expectation should read: > > @curr_odontogram.should_receive(:photos[]).with(1).and_return(@photo) > > Give that a try. I tried this: @curr_odontogram.should_receive(:photos[]).with(1).and_return(@photo) and I have this error: NoMethodError in 'PersonHelper Deberia devolverme un link para eliminar una foto' undefined method `[]' for :photos:Symbol > > > > > > > See you. > > -- > > Gast?n Ramos > > > > GNU/Linux Counter user #450312 > > http://gastonramos.wordpress.com/ > > > > No a la Matricula Obligatoria > > http://noalamatricula.wordpress.com/about/ > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -- Gast?n Ramos GNU/Linux Counter user #450312 http://gastonramos.wordpress.com/ No a la Matricula Obligatoria http://noalamatricula.wordpress.com/about/ From aslak.hellesoy at gmail.com Mon Aug 6 14:03:53 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Mon, 6 Aug 2007 20:03:53 +0200 Subject: [rspec-users] Problems with array mock In-Reply-To: <20070806190447.GA23845@marlasina> References: <20070806171715.GA15788@marlasina> <57c63afe0708060952y7223e442sbc1fb716f45a03e7@mail.gmail.com> <20070806190447.GA23845@marlasina> Message-ID: <8d961d900708061103r30d8364bw1aef998c1bfd5b66@mail.gmail.com> On 8/6/07, Gaston Ramos wrote: > El lun, 06 de ago de 2007, a las 11:52:28 -0500, David Chelimsky dijo: > > On 8/6/07, Gaston Ramos wrote: > > > > > > Hi everyone, > > > > > > I'm trying this in my helper spec and it didn't work: > > > > > > @curr_odontogram.should_receive('photos[1]').and_return(@photo) > > > > > > and the error is: > > > > > > SyntaxError in 'PersonHelper Deberia devolverme un link para eliminar una foto' > > > compile error > > > /home/gramos/src/rails/r-dental/config/../vendor/plugins/rspec/lib/spec/mocks/proxy.rb:99: > > > syntax error, unexpected '[', expecting '\n' or ';' > > > def photos[1](*args, &block) > > > > > > does anyone have a good solution for this? > > > > > > the complete code of the helper: > > > > > > http://pastie.caboo.se/85287 > > > > > > the complete code of the spec helper: > > > > > > http://pastie.caboo.se/85289 > > > > This is ruby magic causing confusion. When you call foo.photos[1], > > you're actually calling foo.photos[](1) (though that won't work) - so > > I *think* the expectation should read: > > > > @curr_odontogram.should_receive(:photos[]).with(1).and_return(@photo) > > @curr_odontogram.photos.should_receive(:[]).with(1).and_return(@photo) Aslak > > Give that a try. > > I tried this: > @curr_odontogram.should_receive(:photos[]).with(1).and_return(@photo) > > and I have this error: > > NoMethodError in 'PersonHelper Deberia devolverme un link para eliminar una > foto' > undefined method `[]' for :photos:Symbol > > > > > > > > > > > > See you. > > > -- > > > Gast?n Ramos > > > > > > GNU/Linux Counter user #450312 > > > http://gastonramos.wordpress.com/ > > > > > > No a la Matricula Obligatoria > > > http://noalamatricula.wordpress.com/about/ > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > -- > Gast?n Ramos > > GNU/Linux Counter user #450312 > http://gastonramos.wordpress.com/ > > No a la Matricula Obligatoria > http://noalamatricula.wordpress.com/about/ > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Mon Aug 6 14:57:48 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 6 Aug 2007 13:57:48 -0500 Subject: [rspec-users] Problems with array mock In-Reply-To: <8d961d900708061103r30d8364bw1aef998c1bfd5b66@mail.gmail.com> References: <20070806171715.GA15788@marlasina> <57c63afe0708060952y7223e442sbc1fb716f45a03e7@mail.gmail.com> <20070806190447.GA23845@marlasina> <8d961d900708061103r30d8364bw1aef998c1bfd5b66@mail.gmail.com> Message-ID: <57c63afe0708061157hfffd3cct50f980e98566ea5f@mail.gmail.com> On 8/6/07, aslak hellesoy wrote: > @curr_odontogram.photos.should_receive(:[]).with(1).and_return(@photo) > > Aslak D'oh! Of course - that should do it. From ben at benburkert.com Mon Aug 6 17:25:55 2007 From: ben at benburkert.com (ben at benburkert.com) Date: Mon, 6 Aug 2007 16:25:55 -0500 (CDT) Subject: [rspec-users] used the described Class in a shared behavior Message-ID: <60190.64.129.167.114.1186435555.squirrel@webmail.benburkert.com> Is it possible to access the described class in a shared behavior? I'm trying to do something like this: describe "Siberian feline", :shared => true do described_class_instance_as :feline, :name => "fluffy", :breed => "Siberian" # or maybe before(:all) do @feline = described_class.new(:name => "fluffy", :breed => "Siberian") end it "should have long hair" do @feline.should be_long_haired end end describe SiberianCat, "(a subclass of, say, Cat)" do it_should_behave_like "Siberian feline" it "should purr" do @feline.sound.should == "purr" end end describe SiberianTiger, "(a subclass of BigCat)" do it_should_behave_like "Siberian feline" it "should roar" do @feline.sound.should == "roar" end end I'm looking for something more elegant than my current way, which is like so: describe "Siberian felines", :shared => true do before(:all) do @feline = @klass.new(:name => "fluffy", :breed => "Siberian") end it "should have long hair" do @feline.should be_long_haired end end describe SiberianCat, "(a subclass of, say, Cat)" do it_should_behave_like "Siberian felines" before(:all) do @klass = SiberianCat end it "should purr" do @feline.sound.should == "purr" end end describe SiberianTiger, "(a subclass of BigCat)" do it_should_behave_like "Siberian felines" before(:all) do @klass = SiberanTiger end it "should roar" do @feline.sound.should == "roar" end end Then again, i have a gut feeling that if i took better advantage of modules it wouldn't be an issue... -Ben From dchelimsky at gmail.com Mon Aug 6 20:47:46 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 6 Aug 2007 19:47:46 -0500 Subject: [rspec-users] used the described Class in a shared behavior In-Reply-To: <60190.64.129.167.114.1186435555.squirrel@webmail.benburkert.com> References: <60190.64.129.167.114.1186435555.squirrel@webmail.benburkert.com> Message-ID: <57c63afe0708061747o543d8947k37f3a8c123aee3e2@mail.gmail.com> On 8/6/07, ben at benburkert.com wrote: > Is it possible to access the described class in a shared behavior? I'm > trying to do something like this: > > describe "Siberian feline", :shared => true do > described_class_instance_as :feline, :name => "fluffy", :breed => > "Siberian" > > # or maybe > > before(:all) do > @feline = described_class.new(:name => "fluffy", :breed => "Siberian") > end > > it "should have long hair" do > @feline.should be_long_haired > end > end > > describe SiberianCat, "(a subclass of, say, Cat)" do > it_should_behave_like "Siberian feline" > > it "should purr" do > @feline.sound.should == "purr" > end > end > > describe SiberianTiger, "(a subclass of BigCat)" do > it_should_behave_like "Siberian feline" > > it "should roar" do > @feline.sound.should == "roar" > end > end > > > > I'm looking for something more elegant than my current way, which is like so: > > describe "Siberian felines", :shared => true do > before(:all) do > @feline = @klass.new(:name => "fluffy", :breed => "Siberian") > end > > it "should have long hair" do > @feline.should be_long_haired > end > end > > describe SiberianCat, "(a subclass of, say, Cat)" do > it_should_behave_like "Siberian felines" > > before(:all) do > @klass = SiberianCat > end > > it "should purr" do > @feline.sound.should == "purr" > end > end > > describe SiberianTiger, "(a subclass of BigCat)" do > it_should_behave_like "Siberian felines" > > before(:all) do > @klass = SiberanTiger > end > > it "should roar" do > @feline.sound.should == "roar" > end > end > The way you're approaching it means that if something changes about the initializer for the SiberianTiger that doesn't change for the initializer of the SiberianCat, you're kinda screwed. I'd do it like this: http://pastie.caboo.se/85444 This keeps the shared behaviour very simple (all it needs is an instance variable) and puts control of the object you're dealing with in the spec. WDYT? > > > > Then again, i have a gut feeling that if i took better advantage of > modules it wouldn't be an issue... > > -Ben > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Mon Aug 6 20:51:17 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 6 Aug 2007 19:51:17 -0500 Subject: [rspec-users] used the described Class in a shared behavior In-Reply-To: <57c63afe0708061747o543d8947k37f3a8c123aee3e2@mail.gmail.com> References: <60190.64.129.167.114.1186435555.squirrel@webmail.benburkert.com> <57c63afe0708061747o543d8947k37f3a8c123aee3e2@mail.gmail.com> Message-ID: <57c63afe0708061751g214690a7h815f1a79ecc6098d@mail.gmail.com> On 8/6/07, David Chelimsky wrote: > On 8/6/07, ben at benburkert.com wrote: > > Is it possible to access the described class in a shared behavior? I'm > > trying to do something like this: > > > > describe "Siberian feline", :shared => true do > > described_class_instance_as :feline, :name => "fluffy", :breed => > > "Siberian" > > > > # or maybe > > > > before(:all) do > > @feline = described_class.new(:name => "fluffy", :breed => "Siberian") > > end > > > > it "should have long hair" do > > @feline.should be_long_haired > > end > > end > > > > describe SiberianCat, "(a subclass of, say, Cat)" do > > it_should_behave_like "Siberian feline" > > > > it "should purr" do > > @feline.sound.should == "purr" > > end > > end > > > > describe SiberianTiger, "(a subclass of BigCat)" do > > it_should_behave_like "Siberian feline" > > > > it "should roar" do > > @feline.sound.should == "roar" > > end > > end > > > > > > > > I'm looking for something more elegant than my current way, which is like so: > > > > describe "Siberian felines", :shared => true do > > before(:all) do > > @feline = @klass.new(:name => "fluffy", :breed => "Siberian") > > end > > > > it "should have long hair" do > > @feline.should be_long_haired > > end > > end > > > > describe SiberianCat, "(a subclass of, say, Cat)" do > > it_should_behave_like "Siberian felines" > > > > before(:all) do > > @klass = SiberianCat > > end > > > > it "should purr" do > > @feline.sound.should == "purr" > > end > > end > > > > describe SiberianTiger, "(a subclass of BigCat)" do > > it_should_behave_like "Siberian felines" > > > > before(:all) do > > @klass = SiberanTiger > > end > > > > it "should roar" do > > @feline.sound.should == "roar" > > end > > end > > > > The way you're approaching it means that if something changes about > the initializer for the SiberianTiger that doesn't change for the > initializer of the SiberianCat, you're kinda screwed. I'd do it like > this: http://pastie.caboo.se/85444 > > This keeps the shared behaviour very simple (all it needs is an > instance variable) and puts control of the object you're dealing with > in the spec. > > WDYT? Also - side note - before(:each) is preferred over before(:all) because it's better to be sure that each example starts with a clean slate. If one should change the state of the object you're describing, you could end up with unexpected results and hair-pulling debugging sessions. > > > > > > > > > > Then again, i have a gut feeling that if i took better advantage of > > modules it wouldn't be an issue... > > > > -Ben > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > From mailing_lists at railsnewbie.com Mon Aug 6 21:36:04 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Mon, 6 Aug 2007 21:36:04 -0400 Subject: [rspec-users] Object equality with a DSL Message-ID: <3FEE2799-F858-4152-84C8-7DE10DE3721C@railsnewbie.com> How would you spec a DSL which descends from Jim Weirich's Blank Slate? I'm asking this question because I have written a DSL, and would like to have the DSL class descend from BlankSlate so that methods like == are not available in the DSL itself (in production), but only while Testing. Does any one have any insight on this? I can provide code samples if anyone would like me to be more specific. Scott Taylor From don at donpetersen.net Mon Aug 6 14:08:55 2007 From: don at donpetersen.net (Don Petersen) Date: Mon, 6 Aug 2007 13:08:55 -0500 Subject: [rspec-users] Problems with array mock In-Reply-To: <20070806190447.GA23845@marlasina> References: <20070806171715.GA15788@marlasina> <57c63afe0708060952y7223e442sbc1fb716f45a03e7@mail.gmail.com> <20070806190447.GA23845@marlasina> Message-ID: Have a look at this: http://pastie.textmate.org/85317 That should work out. Don On Aug 6, 2007, at 2:04 PM, Gaston Ramos wrote: > El lun, 06 de ago de 2007, a las 11:52:28 -0500, David Chelimsky dijo: >> On 8/6/07, Gaston Ramos wrote: >>> >>> Hi everyone, >>> >>> I'm trying this in my helper spec and it didn't work: >>> >>> @curr_odontogram.should_receive('photos[1]').and_return(@photo) >>> >>> and the error is: >>> >>> SyntaxError in 'PersonHelper Deberia devolverme un link para >>> eliminar una foto' >>> compile error >>> /home/gramos/src/rails/r-dental/config/../vendor/plugins/rspec/ >>> lib/spec/mocks/proxy.rb:99: >>> syntax error, unexpected '[', expecting '\n' or ';' >>> def photos[1](*args, &block) >>> >>> does anyone have a good solution for this? >>> >>> the complete code of the helper: >>> >>> http://pastie.caboo.se/85287 >>> >>> the complete code of the spec helper: >>> >>> http://pastie.caboo.se/85289 >> >> This is ruby magic causing confusion. When you call foo.photos[1], >> you're actually calling foo.photos[](1) (though that won't work) - so >> I *think* the expectation should read: >> >> @curr_odontogram.should_receive(:photos[]).with(1).and_return(@photo) >> >> Give that a try. > > I tried this: > @curr_odontogram.should_receive(:photos[]).with(1).and_return(@photo) > > and I have this error: > > NoMethodError in 'PersonHelper Deberia devolverme un link para > eliminar una > foto' > undefined method `[]' for :photos:Symbol > >> >>> >>> >>> See you. >>> -- >>> Gast?n Ramos >>> >>> GNU/Linux Counter user #450312 >>> http://gastonramos.wordpress.com/ >>> >>> No a la Matricula Obligatoria >>> http://noalamatricula.wordpress.com/about/ >>> _______________________________________________ >>> rspec-users mailing list >>> rspec-users at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/rspec-users >>> >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users >> > > -- > Gast?n Ramos > > GNU/Linux Counter user #450312 > http://gastonramos.wordpress.com/ > > No a la Matricula Obligatoria > http://noalamatricula.wordpress.com/about/ > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From flyeminent at hotmail.com Tue Aug 7 05:21:28 2007 From: flyeminent at hotmail.com (Shaker) Date: Tue, 7 Aug 2007 02:21:28 -0700 (PDT) Subject: [rspec-users] Rspec controller test Message-ID: <12030820.post@talk.nabble.com> Great Hi to everybody! I am currently working on a project which tests the controllers using rspec. I came across some methods in the controller which do not generate any actions at all. However, they still need testing! Some of these methods do require parameters. I am wondering how I can pass the test cases as the parameters to these targeted methods in the controller spec?? Below is a simple example for illustration: in the controller: def method_for_test(parameter_1, parameter_2) #do some coding #no action end in the controller_spec: it "should test the method_for_test" do parameter_1 parameter_2 ??how to pass them to method_for_test end Thank you all in advance. -- View this message in context: http://www.nabble.com/Rspec-controller-test-tf4229016.html#a12030820 Sent from the rspec-users mailing list archive at Nabble.com. From dchelimsky at gmail.com Tue Aug 7 10:43:05 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 7 Aug 2007 09:43:05 -0500 Subject: [rspec-users] Rspec controller test In-Reply-To: <12030820.post@talk.nabble.com> References: <12030820.post@talk.nabble.com> Message-ID: <57c63afe0708070743q42bb008fyf502787cbad607db@mail.gmail.com> On 8/7/07, Shaker wrote: > > Great Hi to everybody! > I am currently working on a project which tests the controllers using rspec. > I came across some methods in the controller which do not generate any > actions at all. However, they still need testing! Some of these methods do > require parameters. I am wondering how I can pass the test cases as the > parameters to these targeted methods in the controller spec?? Below is a > simple example for illustration: > in the controller: > def method_for_test(parameter_1, parameter_2) > #do some coding > #no action > end > > in the controller_spec: > it "should test the method_for_test" do > parameter_1 > parameter_2 > ??how to pass them to method_for_test > end controller.method_for_test(arg1, arg2) > > Thank you all in advance. > -- > View this message in context: http://www.nabble.com/Rspec-controller-test-tf4229016.html#a12030820 > Sent from the rspec-users mailing list archive at Nabble.com. > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Tue Aug 7 10:51:59 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 7 Aug 2007 10:51:59 -0400 Subject: [rspec-users] stubs which yield and return Message-ID: <7267A2FC-D7F9-4851-970E-867F7DA9AF0D@railsnewbie.com> Is there any reason why a stub couldn't both yield and return? I'm looking for a way to mock out a class I've made named "AnonymousClass": class AnonymousClass def initialize(&blk) @klass = Class.new @klass.instance_eval(&blk) if block_given? end def new @klass.new end def evaluate(&blk) @klass.instance_eval(&blk) end attr_reader :klass alias_method :class, :klass end One of the behaviours of the AnonymousClass is that new can take a block, and eval the block in the anonymous class, represented by the @klass instance_variable: ac = AnonymousClass.new do include Enumerable end So is there a way to stub AnonymousClass.new such that it yield an AnonymousClass mock, as well as yielding to the block given? What are the technical challenges involved in implementing this in the mocking framework? Or is it a matter of clean syntax? Regards, Scott From dchelimsky at gmail.com Tue Aug 7 12:54:45 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 7 Aug 2007 11:54:45 -0500 Subject: [rspec-users] stubs which yield and return In-Reply-To: <7267A2FC-D7F9-4851-970E-867F7DA9AF0D@railsnewbie.com> References: <7267A2FC-D7F9-4851-970E-867F7DA9AF0D@railsnewbie.com> Message-ID: <57c63afe0708070954ke9c3a71m64ac38611d53cd27@mail.gmail.com> On 8/7/07, Scott Taylor wrote: > > Is there any reason why a stub couldn't both yield and return? Yes. Nobody ever asked for it :) > I'm > looking for a way to mock out a class I've made named "AnonymousClass": > > class AnonymousClass > > def initialize(&blk) > @klass = Class.new > @klass.instance_eval(&blk) if block_given? > end > > def new > @klass.new > end > > def evaluate(&blk) > @klass.instance_eval(&blk) > end > > attr_reader :klass > alias_method :class, :klass > end > > One of the behaviours of the AnonymousClass is that new can take a > block, and eval the block in the anonymous class, represented by the > @klass instance_variable: > > ac = AnonymousClass.new do > include Enumerable > end > > So is there a way to stub AnonymousClass.new such that it yield an > AnonymousClass mock, as well as yielding to the block given? What > are the technical challenges involved in implementing this in the > mocking framework? Or is it a matter of clean syntax? Again - this simply hasn't come up. Please add an RFE and feel free to submit a patch. Cheers, David > > Regards, > > Scott > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Tue Aug 7 18:52:12 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 7 Aug 2007 18:52:12 -0400 Subject: [rspec-users] stubs which yield and return In-Reply-To: <57c63afe0708070954ke9c3a71m64ac38611d53cd27@mail.gmail.com> References: <7267A2FC-D7F9-4851-970E-867F7DA9AF0D@railsnewbie.com> <57c63afe0708070954ke9c3a71m64ac38611d53cd27@mail.gmail.com> Message-ID: <45130EC8-5479-4056-A24B-59473F6FE43D@railsnewbie.com> On Aug 7, 2007, at 12:54 PM, David Chelimsky wrote: > On 8/7/07, Scott Taylor wrote: >> >> Is there any reason why a stub couldn't both yield and return? > > Yes. Nobody ever asked for it :) > > Again - this simply hasn't come up. Please add an RFE and feel free to > submit a patch. > Will do. I think for now I'm going to override the stub in the individual spec to yield. More importantly, I'm going to get autotest to work w/ rspec's native development before I do anymore rspec work. The time to run the full test suite is absolutely unbearable on my Mac G4. Scott From eivindu at ifi.uio.no Tue Aug 7 19:55:50 2007 From: eivindu at ifi.uio.no (Eivind Uggedal) Date: Wed, 8 Aug 2007 01:55:50 +0200 Subject: [rspec-users] Problems with raising errors on a mocked object Message-ID: <824b51d00708071655n6c943a34j320f754e04636d87@mail.gmail.com> I'm trying to mock a object to raise a certain error. By doing so I get a ArgumentError on ActiveRecord's save! method: http://pastie.caboo.se/85628 I've tried to debug it but just can't seem to find what I'm doing wrong. Any help is greatly appreciated. Cheers, Eivind Uggedal From mailing_lists at railsnewbie.com Tue Aug 7 21:14:48 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 7 Aug 2007 21:14:48 -0400 Subject: [rspec-users] and_yield + instance_eval(&block) Message-ID: <46C54C9D-1BF3-436A-93A7-466B6B3BD51D@railsnewbie.com> I have the following code, which yields instance eval's the block given: class Foo def bar(&blk) instance_eval &blk end def baz yield end end The effect of this is that self is reassigned: Foo.new.bar do # here, self is the instance of Foo # created by new end But normally self is the object in which Foo.new.bar {...} occurs. Foo.new.baz do # self is the execution context # in which Foo.new was called, # since a block is a closure end The second case is easy; it is covered by and_yield (with no arguments). Is there some way to spec the first case? Do I smell the need for a patch? Scott From mailing_lists at railsnewbie.com Tue Aug 7 21:34:48 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 7 Aug 2007 21:34:48 -0400 Subject: [rspec-users] and_yield + instance_eval(&block) In-Reply-To: <46C54C9D-1BF3-436A-93A7-466B6B3BD51D@railsnewbie.com> References: <46C54C9D-1BF3-436A-93A7-466B6B3BD51D@railsnewbie.com> Message-ID: <43942287-CA4B-4334-AB15-31C20931EE9B@railsnewbie.com> Duh. I should be using and_return(), not and_yield(), since I am actually returning the value of the instance eval. The method in question takes one parameter, a proc obj (as block). But how can I get a handle on that object (since it is anonymous)? Scott On Aug 7, 2007, at 9:14 PM, Scott Taylor wrote: > > I have the following code, which yields instance eval's the block > given: > > class Foo > > def bar(&blk) > instance_eval &blk > end > > def baz > yield > end > > end > > The effect of this is that self is reassigned: > > Foo.new.bar do > # here, self is the instance of Foo > # created by new > end > > But normally self is the object in which > Foo.new.bar {...} occurs. > > Foo.new.baz do > > # self is the execution context > # in which Foo.new was called, > # since a block is a closure > > end > > > The second case is easy; it is covered by and_yield (with no > arguments). > > Is there some way to spec the first case? Do I smell the need for a > patch? > > Scott > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From dchelimsky at gmail.com Tue Aug 7 23:30:37 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 7 Aug 2007 22:30:37 -0500 Subject: [rspec-users] Problems with raising errors on a mocked object In-Reply-To: <824b51d00708071655n6c943a34j320f754e04636d87@mail.gmail.com> References: <824b51d00708071655n6c943a34j320f754e04636d87@mail.gmail.com> Message-ID: <57c63afe0708072030o423fcbbfk423ac89ed7dc31a4@mail.gmail.com> On 8/7/07, Eivind Uggedal wrote: > I'm trying to mock a object to raise a certain error. By doing so I > get a ArgumentError on ActiveRecord's save! method: > > http://pastie.caboo.se/85628 > > I've tried to debug it but just can't seem to find what I'm doing > wrong. Any help is greatly appreciated. Please run this: ruby script/spec ./spec/controllers/users_controller_spec.rb -b That will give the complete backtrace for the failure, which I'd ask you to pastie as well. > > Cheers, > Eivind Uggedal > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From flyeminent at hotmail.com Tue Aug 7 20:32:38 2007 From: flyeminent at hotmail.com (Shaker) Date: Tue, 7 Aug 2007 17:32:38 -0700 (PDT) Subject: [rspec-users] Failed to pass arguments to controller method Message-ID: <12045114.post@talk.nabble.com> Good morning to everyone: So weird!! I got a method called apply_settings(arg1, arg2) in the controller to be tested. In the controller spec, I of course called the method. In the controller: def apply_settings(arg1, arg2) #where arg1 is a hash, and arg2 is an array of object #do some coding end In the controller spec: before(:each) do @controller = Controller.new end it "should test the apply_settings" do @controller.apply_settings(Hash.new, array_of_object) #where the arguments are exactly some format #as required end However, it yielded "wrong number of arguments(0 for 1)" error after I ran the spec. It there anything wrong in my spec? Cheers! -- View this message in context: http://www.nabble.com/Failed-to-pass-arguments-to-controller-method-tf4233633.html#a12045114 Sent from the rspec-users mailing list archive at Nabble.com. From dchelimsky at gmail.com Wed Aug 8 00:03:01 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 7 Aug 2007 23:03:01 -0500 Subject: [rspec-users] Failed to pass arguments to controller method In-Reply-To: <12045114.post@talk.nabble.com> References: <12045114.post@talk.nabble.com> Message-ID: <57c63afe0708072103s724324f8ncf9b8431183f837d@mail.gmail.com> On 8/7/07, Shaker wrote: > > Good morning to everyone: > So weird!! > I got a method called apply_settings(arg1, arg2) in the controller to be > tested. In the controller spec, I of course called the method. > In the controller: > def apply_settings(arg1, arg2) #where arg1 is a hash, and arg2 is an > array of object > #do some coding > end > In the controller spec: > before(:each) do > @controller = Controller.new > end > > it "should test the apply_settings" do > @controller.apply_settings(Hash.new, array_of_object) #where the > arguments are exactly some format > > #as required > end > > However, it yielded "wrong number of arguments(0 for 1)" error after I ran > the spec. It there anything wrong in my spec? Difficult to say with the little bit of code you're posting. It would be a lot easier to help if you posted the full code of the spec'd method, the spec, and the resulting backtrace. From eivindu at ifi.uio.no Wed Aug 8 01:44:15 2007 From: eivindu at ifi.uio.no (Eivind Uggedal) Date: Wed, 8 Aug 2007 07:44:15 +0200 Subject: [rspec-users] Problems with raising errors on a mocked object In-Reply-To: <57c63afe0708072030o423fcbbfk423ac89ed7dc31a4@mail.gmail.com> References: <824b51d00708071655n6c943a34j320f754e04636d87@mail.gmail.com> <57c63afe0708072030o423fcbbfk423ac89ed7dc31a4@mail.gmail.com> Message-ID: <824b51d00708072244t1659a75k4e7da81af7a617a1@mail.gmail.com> Here you go: http://pastie.caboo.se/85876 Eivind On 8/8/07, David Chelimsky wrote: > On 8/7/07, Eivind Uggedal wrote: > > I'm trying to mock a object to raise a certain error. By doing so I > > get a ArgumentError on ActiveRecord's save! method: > > > > http://pastie.caboo.se/85628 > > > > I've tried to debug it but just can't seem to find what I'm doing > > wrong. Any help is greatly appreciated. > > Please run this: > > ruby script/spec ./spec/controllers/users_controller_spec.rb -b > > That will give the complete backtrace for the failure, which I'd ask > you to pastie as well. > > > > > Cheers, > > Eivind Uggedal > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Wed Aug 8 02:39:21 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 8 Aug 2007 01:39:21 -0500 Subject: [rspec-users] Problems with raising errors on a mocked object In-Reply-To: <824b51d00708072244t1659a75k4e7da81af7a617a1@mail.gmail.com> References: <824b51d00708071655n6c943a34j320f754e04636d87@mail.gmail.com> <57c63afe0708072030o423fcbbfk423ac89ed7dc31a4@mail.gmail.com> <824b51d00708072244t1659a75k4e7da81af7a617a1@mail.gmail.com> Message-ID: <57c63afe0708072339w51c2027dvf9b375dc4e62b745@mail.gmail.com> On 8/8/07, Eivind Uggedal wrote: > Here you go: http://pastie.caboo.se/85876 OK - that helped. The and_raise method can take an exception class or object. If you pass it the class, it will try to create an instance of it using Klass.new. This is the source of the problem. In your example we see: @user.should_receive(:save!).and_raise(ActiveRecord::RecordInvalid) Rspec tries to call ActiveRecord::RecordInvalid.new, but that requires an argument, which is why you get an error saying it got 0 for 1 arguments. Because and_raise can also take an exception object, the solution to this problem is: @user.should_receive(:save!).and_raise(ActiveRecord::RecordInvalid.new(@user)) I guess the root of the problem is poor docs - I'm updating the rdoc now and it will be published with the next release. Cheers, David > > Eivind > > On 8/8/07, David Chelimsky wrote: > > On 8/7/07, Eivind Uggedal wrote: > > > I'm trying to mock a object to raise a certain error. By doing so I > > > get a ArgumentError on ActiveRecord's save! method: > > > > > > http://pastie.caboo.se/85628 > > > > > > I've tried to debug it but just can't seem to find what I'm doing > > > wrong. Any help is greatly appreciated. > > > > Please run this: > > > > ruby script/spec ./spec/controllers/users_controller_spec.rb -b > > > > That will give the complete backtrace for the failure, which I'd ask > > you to pastie as well. > > > > > > > > Cheers, > > > Eivind Uggedal > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From eivindu at ifi.uio.no Wed Aug 8 03:26:52 2007 From: eivindu at ifi.uio.no (Eivind Uggedal) Date: Wed, 8 Aug 2007 09:26:52 +0200 Subject: [rspec-users] Problems with raising errors on a mocked object In-Reply-To: <57c63afe0708072339w51c2027dvf9b375dc4e62b745@mail.gmail.com> References: <824b51d00708071655n6c943a34j320f754e04636d87@mail.gmail.com> <57c63afe0708072030o423fcbbfk423ac89ed7dc31a4@mail.gmail.com> <824b51d00708072244t1659a75k4e7da81af7a617a1@mail.gmail.com> <57c63afe0708072339w51c2027dvf9b375dc4e62b745@mail.gmail.com> Message-ID: <824b51d00708080026n44f1dcacu278ece8978dd94fe@mail.gmail.com> Thanks, that worked great after I had mocked out the ActiveRecord::Errors::full_messages: http://pastie.caboo.se/85887 Cheers, Eivind Uggedal On 8/8/07, David Chelimsky wrote: > On 8/8/07, Eivind Uggedal wrote: > > Here you go: http://pastie.caboo.se/85876 > > OK - that helped. > > The and_raise method can take an exception class or object. If you > pass it the class, it will try to create an instance of it using > Klass.new. This is the source of the problem. In your example we see: > > @user.should_receive(:save!).and_raise(ActiveRecord::RecordInvalid) > > Rspec tries to call ActiveRecord::RecordInvalid.new, but that requires > an argument, which is why you get an error saying it got 0 for 1 > arguments. > > Because and_raise can also take an exception object, the solution to > this problem is: > > @user.should_receive(:save!).and_raise(ActiveRecord::RecordInvalid.new(@user)) > > I guess the root of the problem is poor docs - I'm updating the rdoc > now and it will be published with the next release. > > Cheers, > David > > > > > > Eivind > > > > On 8/8/07, David Chelimsky wrote: > > > On 8/7/07, Eivind Uggedal wrote: > > > > I'm trying to mock a object to raise a certain error. By doing so I > > > > get a ArgumentError on ActiveRecord's save! method: > > > > > > > > http://pastie.caboo.se/85628 > > > > > > > > I've tried to debug it but just can't seem to find what I'm doing > > > > wrong. Any help is greatly appreciated. > > > > > > Please run this: > > > > > > ruby script/spec ./spec/controllers/users_controller_spec.rb -b > > > > > > That will give the complete backtrace for the failure, which I'd ask > > > you to pastie as well. > > > > > > > > > > > Cheers, > > > > Eivind Uggedal > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From work at ashleymoran.me.uk Wed Aug 8 05:53:19 2007 From: work at ashleymoran.me.uk (Ashley Moran) Date: Wed, 8 Aug 2007 10:53:19 +0100 Subject: [rspec-users] RSpec book? Message-ID: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> Came across this as a stub page browsing Amazon UK. This is good news! I'm surprised it hasn't been discussed on the list before. Was Chad keeping it a secret? I hope it will have plenty of BDD theory. I'm still waiting for that magic book I can give to someone and say "here - read this, it tells you how to build software". Ashley From lancecarlson at gmail.com Wed Aug 8 10:26:21 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Wed, 8 Aug 2007 10:26:21 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers Message-ID: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> I am using helper the RESTfully generated helper methods in my views. My routes are nested so the helpers appear to need arguments passed to them, but it works without arguments. Say for example I have pages and comments. If I do page_comments_path without parameters, it works. However, when I run the rspec test, it fails and tells me i'm missing parameters. I tried to pass params[:page_id], but it still says it needs parameters. I did fill in the parameters like it asked and the test passed, but I think my views look cleaner without the arguments being passed everywhere. Do I have to stub these methods to get my views to pass, or is there some other way? TIA, Lance From kevwil at gmail.com Wed Aug 8 10:33:45 2007 From: kevwil at gmail.com (Kevin Williams) Date: Wed, 8 Aug 2007 08:33:45 -0600 Subject: [rspec-users] RSpec book? In-Reply-To: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> References: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> Message-ID: <683a886f0708080733w1aeca603le2e7a6c11ad08b54@mail.gmail.com> I can't wait to read this. If IronRuby ever supports RSpec, I'll give a copy of this book to all my .NET cronies and say just what Ashley said. :) On 8/8/07, Ashley Moran wrote: > > > Came across this as a stub page browsing Amazon UK. This is good > news! I'm surprised it hasn't been discussed on the list before. > Was Chad keeping it a secret? > > I hope it will have plenty of BDD theory. I'm still waiting for that > magic book I can give to someone and say "here - read this, it tells > you how to build software". > > Ashley > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -- Cheers, Kevin Williams http://www.almostserio.us/ http://kevwil.tumblr.com/ http://kevwil.jaiku.com/ From dchelimsky at gmail.com Wed Aug 8 11:07:42 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 8 Aug 2007 10:07:42 -0500 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> Message-ID: <57c63afe0708080807k6a8f13ecu435b97c24bd73207@mail.gmail.com> On 8/8/07, Lance Carlson wrote: > I am using helper the RESTfully generated helper methods in my views. > My routes are nested so the helpers appear to need arguments passed to > them, but it works without arguments. Say for example I have pages and > comments. If I do page_comments_path without parameters, it works. > However, when I run the rspec test, it fails and tells me i'm missing > parameters. I tried to pass params[:page_id], but it still says it > needs parameters. I did fill in the parameters like it asked and the > test passed, but I think my views look cleaner without the arguments > being passed everywhere. Do I have to stub these methods to get my > views to pass, or is there some other way? It would be much easier to answer your question if you posted the actual spec and code. > > TIA, > Lance > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lancecarlson at gmail.com Wed Aug 8 11:56:56 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Wed, 8 Aug 2007 11:56:56 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <57c63afe0708080807k6a8f13ecu435b97c24bd73207@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708080807k6a8f13ecu435b97c24bd73207@mail.gmail.com> Message-ID: <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> ActionView::TemplateError in 'Edit Artist Page should render the edit artist form' label_artist_url failed to generate from {:controller=>"artists", :action=>"show"} - you may have ambiguous routes, or you may need to supply additional parameters for this route. content_url has the following required parameters: ["labels", :label_id, "artists", :id] - are they all satisfied? On line #3 of app/views/artists/edit.rhtml 1:

Editing artist

2: 3: <% form_tag label_artist_path, :method => :put do %> 4: <%= render :partial => 'form' %> 5: <%= submit_tag 'Save' %> 6: <% end %> My spec looks like: require File.dirname(__FILE__) + '/../../spec_helper' describe 'Edit Artist Page' do before do @label = mock_model(Label) @artist = mock_model(Artist) assigns[:label] = @label assigns[:artist] = @artist end def render_edit render :template => 'artists/edit' end it "should render the edit artist form" do render_edit end end On 8/8/07, David Chelimsky wrote: > On 8/8/07, Lance Carlson wrote: > > I am using helper the RESTfully generated helper methods in my views. > > My routes are nested so the helpers appear to need arguments passed to > > them, but it works without arguments. Say for example I have pages and > > comments. If I do page_comments_path without parameters, it works. > > However, when I run the rspec test, it fails and tells me i'm missing > > parameters. I tried to pass params[:page_id], but it still says it > > needs parameters. I did fill in the parameters like it asked and the > > test passed, but I think my views look cleaner without the arguments > > being passed everywhere. Do I have to stub these methods to get my > > views to pass, or is there some other way? > > It would be much easier to answer your question if you posted the > actual spec and code. > > > > > TIA, > > Lance > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Wed Aug 8 13:34:05 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Wed, 8 Aug 2007 13:34:05 -0400 Subject: [rspec-users] RSpec book? In-Reply-To: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> References: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> Message-ID: <14755201-36B3-42F6-9D64-FE1BEE3B43B2@railsnewbie.com> Speaking of a BDD book, does anyone recommend Dave Astels book? Or should I assume I doing "testing well" if I'm using rspec? Scott On Aug 8, 2007, at 5:53 AM, Ashley Moran wrote: > > > Came across this as a stub page browsing Amazon UK. This is good > news! I'm surprised it hasn't been discussed on the list before. > Was Chad keeping it a secret? > > I hope it will have plenty of BDD theory. I'm still waiting for that > magic book I can give to someone and say "here - read this, it tells > you how to build software". > > Ashley > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From rails at content-space.de Wed Aug 8 13:41:12 2007 From: rails at content-space.de (Michael Hamann) Date: Wed, 08 Aug 2007 19:41:12 +0200 Subject: [rspec-users] Transactional fixtures not working as expected Message-ID: <46BA0038.10807@content-space.de> Hi! I am quite new to BDD and I just wrote my first tests. Suddenly I received unexpected results because in a model test I load only users-fixtures but when the views-fixtures in which I load the posts-fixtures, are run before this model-test, the posts-fixtures are loaded too. I test for example if there is one record in the posts-table after creating one post. But when there are fixtures loaded, this does not work of course. A similar issue was discussed here already in October 2006, but there was no real result: http://rubyforge.org/pipermail/rspec-users/2006-October/000088.html I am using edge rails with the current RSpec and RSpec on Rails - plugins. I first used sqlite3, then mysql to verify that it is no sqlite3 bug, but the errors occur also when I am using Mysql. Transactional fixtures are enabled, instantiated fixtures are disabled. My question is now: Is this behavior really desired? Because now my model-tests alone pass, and all the other tests too, but when the view-tests are run before the model-tests, they don't pass. So the passing of the tests becomes unpredictable. And I think I will have additional fixtures for models I don't use fixtures at the moment and this will make other tests fail, too. So should I really write tests that work with any fixtures loaded? And why is there a possibility to load fixtures in one description also this loads the fixtures actually globally? What can I do against this behavior? Is this a bug? Greetings Michael Hamann From lancecarlson at gmail.com Wed Aug 8 13:50:42 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Wed, 8 Aug 2007 13:50:42 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708080807k6a8f13ecu435b97c24bd73207@mail.gmail.com> <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> Message-ID: <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> I just passed label_artist_path(@label.id, @artist.id) into the view and it worked.. but I really don't want to have to pass those parameters in all my views. It looks ugly. Does anyone know a way around this without stubbing? It seems useless to test this view without allowing those methods to act out their real behavior. -TIA On 8/8/07, Lance Carlson wrote: > ActionView::TemplateError in 'Edit Artist Page should render the edit > artist form' > label_artist_url failed to generate from {:controller=>"artists", > :action=>"show"} - you may have ambiguous routes, or you may need to > supply additional parameters for this route. content_url has the > following required parameters: ["labels", :label_id, "artists", :id] - > are they all satisfied? > On line #3 of app/views/artists/edit.rhtml > > 1:

Editing artist

> 2: > 3: <% form_tag label_artist_path, :method => :put do %> > 4: <%= render :partial => 'form' %> > 5: <%= submit_tag 'Save' %> > 6: <% end %> > > > My spec looks like: > > require File.dirname(__FILE__) + '/../../spec_helper' > > describe 'Edit Artist Page' do > before do > @label = mock_model(Label) > @artist = mock_model(Artist) > > assigns[:label] = @label > assigns[:artist] = @artist > end > > def render_edit > render :template => 'artists/edit' > end > > it "should render the edit artist form" do > render_edit > end > end > > On 8/8/07, David Chelimsky wrote: > > On 8/8/07, Lance Carlson wrote: > > > I am using helper the RESTfully generated helper methods in my views. > > > My routes are nested so the helpers appear to need arguments passed to > > > them, but it works without arguments. Say for example I have pages and > > > comments. If I do page_comments_path without parameters, it works. > > > However, when I run the rspec test, it fails and tells me i'm missing > > > parameters. I tried to pass params[:page_id], but it still says it > > > needs parameters. I did fill in the parameters like it asked and the > > > test passed, but I think my views look cleaner without the arguments > > > being passed everywhere. Do I have to stub these methods to get my > > > views to pass, or is there some other way? > > > > It would be much easier to answer your question if you posted the > > actual spec and code. > > > > > > > > TIA, > > > Lance > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > From pergesu at gmail.com Wed Aug 8 14:07:23 2007 From: pergesu at gmail.com (Pat Maddox) Date: Wed, 8 Aug 2007 11:07:23 -0700 Subject: [rspec-users] RSpec book? In-Reply-To: <14755201-36B3-42F6-9D64-FE1BEE3B43B2@railsnewbie.com> References: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> <14755201-36B3-42F6-9D64-FE1BEE3B43B2@railsnewbie.com> Message-ID: <810a540e0708081107l6c021336l38f327da63b9d259@mail.gmail.com> It's dated, as far as the Java side goes. A lot of the examples don't work anymore. This wouldn't be a problem if it were just writing classes and text-based programs (because then it's cake to do it in Ruby ;), but in his example he creates a full-blown GUI app. So it's kind of hard to follow along, and I think a book about testing is of limited use when you can't really test the code ;) However it's still good from a conceptual standpoint, it drives home the point that TDD is about design, not testing. I really like Kent Beck's book, although it's more about testing techniques than using TDD as a design tool. This is an area where there's certainly a void, I think. All the people who've really mastered TDD/BDD are probably too busy working to write a book. I'm definitely looking forward to this. Pat On 8/8/07, Scott Taylor wrote: > > Speaking of a BDD book, does anyone recommend Dave Astels book? Or > should I assume I doing "testing well" if I'm using rspec? > > Scott > > On Aug 8, 2007, at 5:53 AM, Ashley Moran wrote: > > > > > > > Came across this as a stub page browsing Amazon UK. This is good > > news! I'm surprised it hasn't been discussed on the list before. > > Was Chad keeping it a secret? > > > > I hope it will have plenty of BDD theory. I'm still waiting for that > > magic book I can give to someone and say "here - read this, it tells > > you how to build software". > > > > Ashley > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Wed Aug 8 14:30:49 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 8 Aug 2007 13:30:49 -0500 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708080807k6a8f13ecu435b97c24bd73207@mail.gmail.com> <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> Message-ID: <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> On 8/8/07, Lance Carlson wrote: > I just passed label_artist_path(@label.id, @artist.id) into the view > and it worked.. but I really don't want to have to pass those > parameters in all my views. It looks ugly. Does anyone know a way > around this without stubbing? It seems useless to test this view > without allowing those methods to act out their real behavior. Can you point me to docs that say you're supposed to be able to just call label_artist_path without any args? I've not see such docs and I can't get it to work in any of my views - and I'm talking about just rendering the views at all, not getting specs to work. > > -TIA > > On 8/8/07, Lance Carlson wrote: > > ActionView::TemplateError in 'Edit Artist Page should render the edit > > artist form' > > label_artist_url failed to generate from {:controller=>"artists", > > :action=>"show"} - you may have ambiguous routes, or you may need to > > supply additional parameters for this route. content_url has the > > following required parameters: ["labels", :label_id, "artists", :id] - > > are they all satisfied? > > On line #3 of app/views/artists/edit.rhtml > > > > 1:

Editing artist

> > 2: > > 3: <% form_tag label_artist_path, :method => :put do %> > > 4: <%= render :partial => 'form' %> > > 5: <%= submit_tag 'Save' %> > > 6: <% end %> > > > > > > My spec looks like: > > > > require File.dirname(__FILE__) + '/../../spec_helper' > > > > describe 'Edit Artist Page' do > > before do > > @label = mock_model(Label) > > @artist = mock_model(Artist) > > > > assigns[:label] = @label > > assigns[:artist] = @artist > > end > > > > def render_edit > > render :template => 'artists/edit' > > end > > > > it "should render the edit artist form" do > > render_edit > > end > > end > > > > On 8/8/07, David Chelimsky wrote: > > > On 8/8/07, Lance Carlson wrote: > > > > I am using helper the RESTfully generated helper methods in my views. > > > > My routes are nested so the helpers appear to need arguments passed to > > > > them, but it works without arguments. Say for example I have pages and > > > > comments. If I do page_comments_path without parameters, it works. > > > > However, when I run the rspec test, it fails and tells me i'm missing > > > > parameters. I tried to pass params[:page_id], but it still says it > > > > needs parameters. I did fill in the parameters like it asked and the > > > > test passed, but I think my views look cleaner without the arguments > > > > being passed everywhere. Do I have to stub these methods to get my > > > > views to pass, or is there some other way? > > > > > > It would be much easier to answer your question if you posted the > > > actual spec and code. > > > > > > > > > > > TIA, > > > > Lance > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lancecarlson at gmail.com Wed Aug 8 14:38:47 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Wed, 8 Aug 2007 14:38:47 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708080807k6a8f13ecu435b97c24bd73207@mail.gmail.com> <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> Message-ID: <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> All I'm doing is passing the instance variables @label and @artist in the controller to the view using this code: @label = current_user.labels.find(params[:label_id]) @artist = params[:id].nil? ? Artist.new : @label.artists.find(params[:id]) By sending these two instance variables to the view, I don't need to specify these arguments and the view just works. Can you get it to work when you specify these instance variables in your controller? -L On 8/8/07, David Chelimsky wrote: > On 8/8/07, Lance Carlson wrote: > > I just passed label_artist_path(@label.id, @artist.id) into the view > > and it worked.. but I really don't want to have to pass those > > parameters in all my views. It looks ugly. Does anyone know a way > > around this without stubbing? It seems useless to test this view > > without allowing those methods to act out their real behavior. > > Can you point me to docs that say you're supposed to be able to just > call label_artist_path without any args? I've not see such docs and I > can't get it to work in any of my views - and I'm talking about just > rendering the views at all, not getting specs to work. > > > > > -TIA > > > > On 8/8/07, Lance Carlson wrote: > > > ActionView::TemplateError in 'Edit Artist Page should render the edit > > > artist form' > > > label_artist_url failed to generate from {:controller=>"artists", > > > :action=>"show"} - you may have ambiguous routes, or you may need to > > > supply additional parameters for this route. content_url has the > > > following required parameters: ["labels", :label_id, "artists", :id] - > > > are they all satisfied? > > > On line #3 of app/views/artists/edit.rhtml > > > > > > 1:

Editing artist

> > > 2: > > > 3: <% form_tag label_artist_path, :method => :put do %> > > > 4: <%= render :partial => 'form' %> > > > 5: <%= submit_tag 'Save' %> > > > 6: <% end %> > > > > > > > > > My spec looks like: > > > > > > require File.dirname(__FILE__) + '/../../spec_helper' > > > > > > describe 'Edit Artist Page' do > > > before do > > > @label = mock_model(Label) > > > @artist = mock_model(Artist) > > > > > > assigns[:label] = @label > > > assigns[:artist] = @artist > > > end > > > > > > def render_edit > > > render :template => 'artists/edit' > > > end > > > > > > it "should render the edit artist form" do > > > render_edit > > > end > > > end > > > > > > On 8/8/07, David Chelimsky wrote: > > > > On 8/8/07, Lance Carlson wrote: > > > > > I am using helper the RESTfully generated helper methods in my views. > > > > > My routes are nested so the helpers appear to need arguments passed to > > > > > them, but it works without arguments. Say for example I have pages and > > > > > comments. If I do page_comments_path without parameters, it works. > > > > > However, when I run the rspec test, it fails and tells me i'm missing > > > > > parameters. I tried to pass params[:page_id], but it still says it > > > > > needs parameters. I did fill in the parameters like it asked and the > > > > > test passed, but I think my views look cleaner without the arguments > > > > > being passed everywhere. Do I have to stub these methods to get my > > > > > views to pass, or is there some other way? > > > > > > > > It would be much easier to answer your question if you posted the > > > > actual spec and code. > > > > > > > > > > > > > > TIA, > > > > > Lance > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Wed Aug 8 14:41:31 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 8 Aug 2007 13:41:31 -0500 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708080807k6a8f13ecu435b97c24bd73207@mail.gmail.com> <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> Message-ID: <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> On 8/8/07, Lance Carlson wrote: > All I'm doing is passing the instance variables @label and @artist in > the controller to the view using this code: > > @label = current_user.labels.find(params[:label_id]) > @artist = params[:id].nil? ? Artist.new : @label.artists.find(params[:id]) > > By sending these two instance variables to the view, I don't need to > specify these arguments and the view just works. Can you get it to > work when you specify these instance variables in your controller? No. That's what I'm saying. I get the same ambigous URL error you cited in the first email in this thread, but in the browser. Using edge rails, edge rspec. > > -L > > On 8/8/07, David Chelimsky wrote: > > On 8/8/07, Lance Carlson wrote: > > > I just passed label_artist_path(@label.id, @artist.id) into the view > > > and it worked.. but I really don't want to have to pass those > > > parameters in all my views. It looks ugly. Does anyone know a way > > > around this without stubbing? It seems useless to test this view > > > without allowing those methods to act out their real behavior. > > > > Can you point me to docs that say you're supposed to be able to just > > call label_artist_path without any args? I've not see such docs and I > > can't get it to work in any of my views - and I'm talking about just > > rendering the views at all, not getting specs to work. > > > > > > > > -TIA > > > > > > On 8/8/07, Lance Carlson wrote: > > > > ActionView::TemplateError in 'Edit Artist Page should render the edit > > > > artist form' > > > > label_artist_url failed to generate from {:controller=>"artists", > > > > :action=>"show"} - you may have ambiguous routes, or you may need to > > > > supply additional parameters for this route. content_url has the > > > > following required parameters: ["labels", :label_id, "artists", :id] - > > > > are they all satisfied? > > > > On line #3 of app/views/artists/edit.rhtml > > > > > > > > 1:

Editing artist

> > > > 2: > > > > 3: <% form_tag label_artist_path, :method => :put do %> > > > > 4: <%= render :partial => 'form' %> > > > > 5: <%= submit_tag 'Save' %> > > > > 6: <% end %> > > > > > > > > > > > > My spec looks like: > > > > > > > > require File.dirname(__FILE__) + '/../../spec_helper' > > > > > > > > describe 'Edit Artist Page' do > > > > before do > > > > @label = mock_model(Label) > > > > @artist = mock_model(Artist) > > > > > > > > assigns[:label] = @label > > > > assigns[:artist] = @artist > > > > end > > > > > > > > def render_edit > > > > render :template => 'artists/edit' > > > > end > > > > > > > > it "should render the edit artist form" do > > > > render_edit > > > > end > > > > end > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > I am using helper the RESTfully generated helper methods in my views. > > > > > > My routes are nested so the helpers appear to need arguments passed to > > > > > > them, but it works without arguments. Say for example I have pages and > > > > > > comments. If I do page_comments_path without parameters, it works. > > > > > > However, when I run the rspec test, it fails and tells me i'm missing > > > > > > parameters. I tried to pass params[:page_id], but it still says it > > > > > > needs parameters. I did fill in the parameters like it asked and the > > > > > > test passed, but I think my views look cleaner without the arguments > > > > > > being passed everywhere. Do I have to stub these methods to get my > > > > > > views to pass, or is there some other way? > > > > > > > > > > It would be much easier to answer your question if you posted the > > > > > actual spec and code. > > > > > > > > > > > > > > > > > TIA, > > > > > > Lance > > > > > > _______________________________________________ > > > > > > rspec-users mailing list > > > > > > rspec-users at rubyforge.org > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lancecarlson at gmail.com Wed Aug 8 14:46:59 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Wed, 8 Aug 2007 14:46:59 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708080807k6a8f13ecu435b97c24bd73207@mail.gmail.com> <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> Message-ID: <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> I just visited the action in my browser and i don't get any errors. I am also running on edge rails as the application relies on ActiveResource. Can you show me the code you created? On 8/8/07, David Chelimsky wrote: > On 8/8/07, Lance Carlson wrote: > > All I'm doing is passing the instance variables @label and @artist in > > the controller to the view using this code: > > > > @label = current_user.labels.find(params[:label_id]) > > @artist = params[:id].nil? ? Artist.new : @label.artists.find(params[:id]) > > > > By sending these two instance variables to the view, I don't need to > > specify these arguments and the view just works. Can you get it to > > work when you specify these instance variables in your controller? > > No. That's what I'm saying. I get the same ambigous URL error you > cited in the first email in this thread, but in the browser. Using > edge rails, edge rspec. > > > > > -L > > > > On 8/8/07, David Chelimsky wrote: > > > On 8/8/07, Lance Carlson wrote: > > > > I just passed label_artist_path(@label.id, @artist.id) into the view > > > > and it worked.. but I really don't want to have to pass those > > > > parameters in all my views. It looks ugly. Does anyone know a way > > > > around this without stubbing? It seems useless to test this view > > > > without allowing those methods to act out their real behavior. > > > > > > Can you point me to docs that say you're supposed to be able to just > > > call label_artist_path without any args? I've not see such docs and I > > > can't get it to work in any of my views - and I'm talking about just > > > rendering the views at all, not getting specs to work. > > > > > > > > > > > -TIA > > > > > > > > On 8/8/07, Lance Carlson wrote: > > > > > ActionView::TemplateError in 'Edit Artist Page should render the edit > > > > > artist form' > > > > > label_artist_url failed to generate from {:controller=>"artists", > > > > > :action=>"show"} - you may have ambiguous routes, or you may need to > > > > > supply additional parameters for this route. content_url has the > > > > > following required parameters: ["labels", :label_id, "artists", :id] - > > > > > are they all satisfied? > > > > > On line #3 of app/views/artists/edit.rhtml > > > > > > > > > > 1:

Editing artist

> > > > > 2: > > > > > 3: <% form_tag label_artist_path, :method => :put do %> > > > > > 4: <%= render :partial => 'form' %> > > > > > 5: <%= submit_tag 'Save' %> > > > > > 6: <% end %> > > > > > > > > > > > > > > > My spec looks like: > > > > > > > > > > require File.dirname(__FILE__) + '/../../spec_helper' > > > > > > > > > > describe 'Edit Artist Page' do > > > > > before do > > > > > @label = mock_model(Label) > > > > > @artist = mock_model(Artist) > > > > > > > > > > assigns[:label] = @label > > > > > assigns[:artist] = @artist > > > > > end > > > > > > > > > > def render_edit > > > > > render :template => 'artists/edit' > > > > > end > > > > > > > > > > it "should render the edit artist form" do > > > > > render_edit > > > > > end > > > > > end > > > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > > I am using helper the RESTfully generated helper methods in my views. > > > > > > > My routes are nested so the helpers appear to need arguments passed to > > > > > > > them, but it works without arguments. Say for example I have pages and > > > > > > > comments. If I do page_comments_path without parameters, it works. > > > > > > > However, when I run the rspec test, it fails and tells me i'm missing > > > > > > > parameters. I tried to pass params[:page_id], but it still says it > > > > > > > needs parameters. I did fill in the parameters like it asked and the > > > > > > > test passed, but I think my views look cleaner without the arguments > > > > > > > being passed everywhere. Do I have to stub these methods to get my > > > > > > > views to pass, or is there some other way? > > > > > > > > > > > > It would be much easier to answer your question if you posted the > > > > > > actual spec and code. > > > > > > > > > > > > > > > > > > > > TIA, > > > > > > > Lance > > > > > > > _______________________________________________ > > > > > > > rspec-users mailing list > > > > > > > rspec-users at rubyforge.org > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > _______________________________________________ > > > > > > rspec-users mailing list > > > > > > rspec-users at rubyforge.org > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From nicksieger at gmail.com Wed Aug 8 16:17:31 2007 From: nicksieger at gmail.com (Nick Sieger) Date: Wed, 8 Aug 2007 15:17:31 -0500 Subject: [rspec-users] using RSpec's trunk in non-rails projects w/ Autotest In-Reply-To: <3C103E41-DEBC-4389-A0AB-E4F42CDE6338@railsnewbie.com> References: <3C103E41-DEBC-4389-A0AB-E4F42CDE6338@railsnewbie.com> Message-ID: On 8/6/07, Scott Taylor wrote: > > > I believe for rails projects you can put rspec's code repos into > vendor/plugins, and autotest will automatically use the rspec binary > in that directory, and not the gem installed. > > Is there an easy way to do this for non-rails projects? There are a > few advancements on trunk which I would like to take advantage of. > Tips welcome ; ). Check out the trunk somewhere and set RUBYLIB=/path/to/rspec/trunk? Emulate the Rails vendor structure somewhat and have a bootstrap script that adds RSpec in that location to the load path? /Nick -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070808/1c660c73/attachment.html From mailing_lists at railsnewbie.com Wed Aug 8 16:27:50 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Wed, 8 Aug 2007 16:27:50 -0400 Subject: [rspec-users] using RSpec's trunk in non-rails projects w/ Autotest In-Reply-To: References: <3C103E41-DEBC-4389-A0AB-E4F42CDE6338@railsnewbie.com> Message-ID: <46A856C5-0A29-4434-9CDC-0BC9EE207F4B@railsnewbie.com> Hey Nick, Good to hear from you (as the original developer of the autotest compatibility issue). I was working on the same issue David was (to fix autotest to work for RSpec's trunk), only to find that David had modified it. I have refactored the autotest plugin to use vendor/plugin/rspec/bin if that exists, and have spec'ed out most of the Autotest. This means that a non-rails project could use vendor/plugins w/ rspec checked out, and autotest should work out of the box. Right now spec coverage is at 99.7%, so I'm working on finishing up the specs for RSpec's autotest. (David, I assume this would be welcome?) Scott On Aug 8, 2007, at 4:17 PM, Nick Sieger wrote: > On 8/6/07, Scott Taylor wrote: > > I believe for rails projects you can put rspec's code repos into > vendor/plugins, and autotest will automatically use the rspec binary > in that directory, and not the gem installed. > > Is there an easy way to do this for non-rails projects? There are a > few advancements on trunk which I would like to take advantage of. > Tips welcome ; ). > > Check out the trunk somewhere and set RUBYLIB=/path/to/rspec/trunk? > > Emulate the Rails vendor structure somewhat and have a bootstrap > script that adds RSpec in that location to the load path? > > /Nick > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From dchelimsky at gmail.com Wed Aug 8 16:30:45 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 8 Aug 2007 15:30:45 -0500 Subject: [rspec-users] using RSpec's trunk in non-rails projects w/ Autotest In-Reply-To: <46A856C5-0A29-4434-9CDC-0BC9EE207F4B@railsnewbie.com> References: <3C103E41-DEBC-4389-A0AB-E4F42CDE6338@railsnewbie.com> <46A856C5-0A29-4434-9CDC-0BC9EE207F4B@railsnewbie.com> Message-ID: <57c63afe0708081330tfc8a1p6854b30da76380f9@mail.gmail.com> On 8/8/07, Scott Taylor wrote: > I was working on the same issue David was (to fix autotest to work > for RSpec's trunk), only to find that David had modified it. Sorry - I saw the RFE and was taking a look at solutions and it was too easy to not just do. > I have refactored the autotest plugin to use vendor/plugin/rspec/bin > if that exists, and have spec'ed out most of the Autotest. This > means that a non-rails project could use vendor/plugins w/ rspec > checked out, and autotest should work out of the box. > > Right now spec coverage is at 99.7%, so I'm working on finishing up > the specs for RSpec's autotest. (David, I assume this would be > welcome?) Absolutely!!!! I'll stay out of your way on this one :) Cheers, David From mailing_lists at railsnewbie.com Wed Aug 8 16:36:36 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Wed, 8 Aug 2007 16:36:36 -0400 Subject: [rspec-users] using RSpec's trunk in non-rails projects w/ Autotest In-Reply-To: <57c63afe0708081330tfc8a1p6854b30da76380f9@mail.gmail.com> References: <3C103E41-DEBC-4389-A0AB-E4F42CDE6338@railsnewbie.com> <46A856C5-0A29-4434-9CDC-0BC9EE207F4B@railsnewbie.com> <57c63afe0708081330tfc8a1p6854b30da76380f9@mail.gmail.com> Message-ID: On Aug 8, 2007, at 4:30 PM, David Chelimsky wrote: > On 8/8/07, Scott Taylor wrote: >> I was working on the same issue David was (to fix autotest to work >> for RSpec's trunk), only to find that David had modified it. > > Sorry - I saw the RFE and was taking a look at solutions and it was > too easy to not just do. > >> I have refactored the autotest plugin to use vendor/plugin/rspec/bin >> if that exists, and have spec'ed out most of the Autotest. This >> means that a non-rails project could use vendor/plugins w/ rspec >> checked out, and autotest should work out of the box. >> >> Right now spec coverage is at 99.7%, so I'm working on finishing up >> the specs for RSpec's autotest. (David, I assume this would be >> welcome?) > > Absolutely!!!! I'll stay out of your way on this one :) Unfortunately, the specs (for the rest of our Autotest plugin) are coupled with the original refactoring that I made. I hope that's alright (I've had this problem with multiple patch dependencies in the past). If that's not OK, then I'll submit them, and write some throw away specs for the version that is currently on trunk. Scott From dchelimsky at gmail.com Wed Aug 8 16:40:20 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 8 Aug 2007 15:40:20 -0500 Subject: [rspec-users] using RSpec's trunk in non-rails projects w/ Autotest In-Reply-To: References: <3C103E41-DEBC-4389-A0AB-E4F42CDE6338@railsnewbie.com> <46A856C5-0A29-4434-9CDC-0BC9EE207F4B@railsnewbie.com> <57c63afe0708081330tfc8a1p6854b30da76380f9@mail.gmail.com> Message-ID: <57c63afe0708081340w1b899c97u44a9a4101abb4d7b@mail.gmail.com> On 8/8/07, Scott Taylor wrote: > > On Aug 8, 2007, at 4:30 PM, David Chelimsky wrote: > > > On 8/8/07, Scott Taylor wrote: > >> I was working on the same issue David was (to fix autotest to work > >> for RSpec's trunk), only to find that David had modified it. > > > > Sorry - I saw the RFE and was taking a look at solutions and it was > > too easy to not just do. > > > >> I have refactored the autotest plugin to use vendor/plugin/rspec/bin > >> if that exists, and have spec'ed out most of the Autotest. This > >> means that a non-rails project could use vendor/plugins w/ rspec > >> checked out, and autotest should work out of the box. > >> > >> Right now spec coverage is at 99.7%, so I'm working on finishing up > >> the specs for RSpec's autotest. (David, I assume this would be > >> welcome?) > > > > Absolutely!!!! I'll stay out of your way on this one :) > > Unfortunately, the specs (for the rest of our Autotest plugin) are > coupled with the original refactoring that I made. I hope that's > alright (I've had this problem with multiple patch dependencies in > the past). > > If that's not OK, then I'll submit them, and write some throw away > specs for the version that is currently on trunk. I'm less worried about the implementation than I am about being able to easily apply your patch to the current trunk. As long as I can do that, it's fine. > > Scott > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lancecarlson at gmail.com Wed Aug 8 16:41:39 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Wed, 8 Aug 2007 16:41:39 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708080807k6a8f13ecu435b97c24bd73207@mail.gmail.com> <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> Message-ID: <49f64a900708081341o6282f6a2y371ca8c9ad764756@mail.gmail.com> David, I know for a fact that these helpers do not require arguments to be sent to them. Does anyone have any idea why rspec is forcing this to happen? On 8/8/07, Lance Carlson wrote: > I just visited the action in my browser and i don't get any errors. I > am also running on edge rails as the application relies on > ActiveResource. Can you show me the code you created? > > On 8/8/07, David Chelimsky wrote: > > On 8/8/07, Lance Carlson wrote: > > > All I'm doing is passing the instance variables @label and @artist in > > > the controller to the view using this code: > > > > > > @label = current_user.labels.find(params[:label_id]) > > > @artist = params[:id].nil? ? Artist.new : @label.artists.find(params[:id]) > > > > > > By sending these two instance variables to the view, I don't need to > > > specify these arguments and the view just works. Can you get it to > > > work when you specify these instance variables in your controller? > > > > No. That's what I'm saying. I get the same ambigous URL error you > > cited in the first email in this thread, but in the browser. Using > > edge rails, edge rspec. > > > > > > > > -L > > > > > > On 8/8/07, David Chelimsky wrote: > > > > On 8/8/07, Lance Carlson wrote: > > > > > I just passed label_artist_path(@label.id, @artist.id) into the view > > > > > and it worked.. but I really don't want to have to pass those > > > > > parameters in all my views. It looks ugly. Does anyone know a way > > > > > around this without stubbing? It seems useless to test this view > > > > > without allowing those methods to act out their real behavior. > > > > > > > > Can you point me to docs that say you're supposed to be able to just > > > > call label_artist_path without any args? I've not see such docs and I > > > > can't get it to work in any of my views - and I'm talking about just > > > > rendering the views at all, not getting specs to work. > > > > > > > > > > > > > > -TIA > > > > > > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > ActionView::TemplateError in 'Edit Artist Page should render the edit > > > > > > artist form' > > > > > > label_artist_url failed to generate from {:controller=>"artists", > > > > > > :action=>"show"} - you may have ambiguous routes, or you may need to > > > > > > supply additional parameters for this route. content_url has the > > > > > > following required parameters: ["labels", :label_id, "artists", :id] - > > > > > > are they all satisfied? > > > > > > On line #3 of app/views/artists/edit.rhtml > > > > > > > > > > > > 1:

Editing artist

> >>>>> 2: > >>>>> 3: <% form_tag label_artist_path, :method => :put do %> > >>>>> 4: <%= render :partial => 'form' %> > >>>>> 5: <%= submit_tag 'Save' %> > >>>>> 6: <% end %> > >>>>> > >>>>> > >>>>> My spec looks like: > >>>>> > >>>>> require File.dirname(__FILE__) + '/../../spec_helper' > >>>>> > >>>>> describe 'Edit Artist Page' do > >>>>> before do > >>>>> @label = mock_model(Label) > >>>>> @artist = mock_model(Artist) > >>>>> > >>>>> assigns[:label] = @label > >>>>> assigns[:artist] = @artist > >>>>> end > >>>>> > >>>>> def render_edit > >>>>> render :template => 'artists/edit' > >>>>> end > >>>>> > >>>>> it "should render the edit artist form" do > >>>>> render_edit > >>>>> end > >>>>> end > >>>>> > >>>>> On 8/8/07, David Chelimsky wrote: > >>>>>> On 8/8/07, Lance Carlson wrote: > >>>>>>> I am using helper the RESTfully generated helper methods in my views. > >>>>>>> My routes are nested so the helpers appear to need arguments passed to > >>>>>>> them, but it works without arguments. Say for example I have pages and > >>>>>>> comments. If I do page_comments_path without parameters, it works. > >>>>>>> However, when I run the rspec test, it fails and tells me i'm missing > >>>>>>> parameters. I tried to pass params[:page_id], but it still says it > >>>>>>> needs parameters. I did fill in the parameters like it asked and the > >>>>>>> test passed, but I think my views look cleaner without the arguments > >>>>>>> being passed everywhere. Do I have to stub these methods to get my > >>>>>>> views to pass, or is there some other way? > >>>>>> It would be much easier to answer your question if you posted the > >>>>>> actual spec and code. > >>>>>> > >>>>>>> TIA, > >>>>>>> Lance > >>>>>>> _______________________________________________ > >>>>>>> rspec-users mailing list > >>>>>>> rspec-users at rubyforge.org > >>>>>>> http://rubyforge.org/mailman/listinfo/rspec-users > >>>>>>> > >>>>>> _______________________________________________ > >>>>>> rspec-users mailing list > >>>>>> rspec-users at rubyforge.org > >>>>>> http://rubyforge.org/mailman/listinfo/rspec-users > >>>>>> > >>>> _______________________________________________ > >>>> rspec-users mailing list > >>>> rspec-users at rubyforge.org > >>>> http://rubyforge.org/mailman/listinfo/rspec-users > >>>> > >>> _______________________________________________ > >>> rspec-users mailing list > >>> rspec-users at rubyforge.org > >>> http://rubyforge.org/mailman/listinfo/rspec-users > >>> > >> _______________________________________________ > >> rspec-users mailing list > >> rspec-users at rubyforge.org > >> http://rubyforge.org/mailman/listinfo/rspec-users > >> > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From daniel at danielfischer.com Wed Aug 8 17:08:24 2007 From: daniel at danielfischer.com (Fischer, Daniel) Date: Wed, 8 Aug 2007 14:08:24 -0700 Subject: [rspec-users] Can't seem to spec a ActiveRecord::RecordInvalid exception properly... Message-ID: <7e565b5c0708081408q474ac9e9m729143cc86ddaab7@mail.gmail.com> 1 def create 2 @user = User.new(params[:user]) 3 @user.save! 4 self.current_user = @user 5 redirect_to user_path(@user) 6 flash[:notice] = "Thanks for signing up!" 7 rescue ActiveRecord::RecordInvalid 8 render :action => 'new' 9 end I can't seem to properly spec this out. I am trying numerous things, the latest one is this, which makes sense but it still fails... it "should re-render new on an invalid record exception" do post :create, :user => {:login => nil} response.should render_template(:new) end should re-render new on an invalid record exception expected "new", got nil Any help would be great, thanks! -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070808/9cb7bada/attachment.html From lancecarlson at gmail.com Wed Aug 8 17:14:03 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Wed, 8 Aug 2007 17:14:03 -0400 Subject: [rspec-users] Can't seem to spec a ActiveRecord::RecordInvalid exception properly... In-Reply-To: <7e565b5c0708081408q474ac9e9m729143cc86ddaab7@mail.gmail.com> References: <7e565b5c0708081408q474ac9e9m729143cc86ddaab7@mail.gmail.com> Message-ID: <49f64a900708081414o26bdc9bax949115dee2a67d87@mail.gmail.com> Does it redirect instead? On 8/8/07, Fischer, Daniel wrote: > 1 def create > 2 @user = User.new(params[:user]) > 3 @user.save! > 4 self.current_user = @user > 5 redirect_to user_path(@user) > 6 flash[:notice] = "Thanks for signing up!" > 7 rescue ActiveRecord::RecordInvalid > 8 render :action => 'new' > 9 end > > I can't seem to properly spec this out. I am trying numerous things, the > latest one is this, which makes sense but it still fails... > > > it "should re-render new on an invalid record exception" do > post :create, :user => {:login => nil} > response.should render_template(:new) > end > > should re-render new on an invalid record exception > expected "new", got nil > > Any help would be great, thanks! > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From daniel at danielfischer.com Wed Aug 8 17:22:15 2007 From: daniel at danielfischer.com (Fischer, Daniel) Date: Wed, 8 Aug 2007 14:22:15 -0700 Subject: [rspec-users] Can't seem to spec a ActiveRecord::RecordInvalid exception properly... In-Reply-To: <49f64a900708081414o26bdc9bax949115dee2a67d87@mail.gmail.com> References: <7e565b5c0708081408q474ac9e9m729143cc86ddaab7@mail.gmail.com> <49f64a900708081414o26bdc9bax949115dee2a67d87@mail.gmail.com> Message-ID: <7e565b5c0708081422i5cbe77d7h22a9de9c892e2ad3@mail.gmail.com> It's redirecting to /users/1 so it's not causing a fail on the exception, which I don't know why. My question is how to properly do this in rSpec? On 8/8/07, Lance Carlson wrote: > > Does it redirect instead? > > On 8/8/07, Fischer, Daniel wrote: > > 1 def create > > 2 @user = User.new(params[:user]) > > 3 @user.save! > > 4 self.current_user = @user > > 5 redirect_to user_path(@user) > > 6 flash[:notice] = "Thanks for signing up!" > > 7 rescue ActiveRecord::RecordInvalid > > 8 render :action => 'new' > > 9 end > > > > I can't seem to properly spec this out. I am trying numerous things, the > > latest one is this, which makes sense but it still fails... > > > > > > it "should re-render new on an invalid record exception" do > > post :create, :user => {:login => nil} > > response.should render_template(:new) > > end > > > > should re-render new on an invalid record exception > > expected "new", got nil > > > > Any help would be great, thanks! > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070808/5817f2a6/attachment.html From nemo7467 at gmail.com Wed Aug 8 17:25:56 2007 From: nemo7467 at gmail.com (David Parker) Date: Wed, 8 Aug 2007 16:25:56 -0500 Subject: [rspec-users] rspec with autotest on a windows machine Message-ID: <9a07e4a80708081425q515be2b1m6bd4183b452bde59@mail.gmail.com> Hello all, I'm new to rSpec but after reading a couple of tutorials I've become enamored. Anyway, I am at minute 42 of the rSpec basics screencast ( peepcode.com) and I'm having the following error running autotest w/rSpec: D:\ruby\projects\forecaster>autotest loading autotest/rails_rspec c:\ruby\bin\ruby -rrubygems -e "require 'redgreen'" -S script/spec -O spec/spec.opts spec/models/weather_spec.rb spec/views/weathers/show.rhtml_spec.rb spec/controllers/weathers_controller_spec.rb spec/views/weathers/new.rhtml_spec.rb spec/views/weathers/edit.rhtml_spec.rb spec/helpers/weathers_helper_spec.rb spec/views/weathers/index.rhtml_spec.rb invalid option: -O Test::Unit automatic runner. I also have the TDD screencast and I am able to run autotest with no problems: D:\ruby\projects\journal_app>autotest loading autotest/rails c:\ruby\bin\ruby -rrubygems -e "require 'redgreen'" -I.;lib;test -rtest/unit -e "%w[test/functional/journals_controller_test.rb test/integration/journal_stories_test.rb test/unit/journal_test.rb].each { |f| require f }" | unit_diff -u Loaded suite -e Started ................ Finished in 1.265 seconds. 16 tests, 33 assertions, 0 failures, 0 errors Note: I am running Rails 1.2.3 and ZenTest v 3.6.1 on a Windows machine (sad, I know, but we've discussed that already). When I run 'ruby script/spec -v' it says: RSpec-1.0.5 (r2081) - BDD for Ruby I've also tried installing the newest version of the rSpec plugins and running "ruby script/generate rspec" so the proper files are copied to the script folder. as a "hack" fix, I did this: 1) I removed my .autotest file completely (so no fun red/green/etc) 2) I modified plugins>rspec>lib>autotest> rspec.rb and removed "#{add_options_if_present}" from line 50 Anyone know of what my problem may be? Windows perhaps? It would sure be nice to be able to keep my .autotest file... Thanks for any help you can provide! -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070808/a24d9cf4/attachment.html From lancecarlson at gmail.com Wed Aug 8 17:35:19 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Wed, 8 Aug 2007 17:35:19 -0400 Subject: [rspec-users] Can't seem to spec a ActiveRecord::RecordInvalid exception properly... In-Reply-To: <7e565b5c0708081422i5cbe77d7h22a9de9c892e2ad3@mail.gmail.com> References: <7e565b5c0708081408q474ac9e9m729143cc86ddaab7@mail.gmail.com> <49f64a900708081414o26bdc9bax949115dee2a67d87@mail.gmail.com> <7e565b5c0708081422i5cbe77d7h22a9de9c892e2ad3@mail.gmail.com> Message-ID: <49f64a900708081435pfa7319bqaf156ff6fe52ad8c@mail.gmail.com> Is it redirecting or is it rendering new? On 8/8/07, Fischer, Daniel wrote: > It's redirecting to /users/1 so it's not causing a fail on the exception, > which I don't know why. My question is how to properly do this in rSpec? > > > On 8/8/07, Lance Carlson wrote: > > Does it redirect instead? > > > > On 8/8/07, Fischer, Daniel wrote: > > > 1 def create > > > 2 @user = User.new(params[:user]) > > > 3 @ user.save! > > > 4 self.current_user = @user > > > 5 redirect_to user_path(@user) > > > 6 flash[:notice] = "Thanks for signing up!" > > > 7 rescue ActiveRecord::RecordInvalid > > > 8 render :action => 'new' > > > 9 end > > > > > > I can't seem to properly spec this out. I am trying numerous things, the > > > latest one is this, which makes sense but it still fails... > > > > > > > > > it "should re-render new on an invalid record exception" do > > > post :create, :user => {:login => nil} > > > response.should render_template(:new) > > > end > > > > > > should re-render new on an invalid record exception > > > expected "new", got nil > > > > > > Any help would be great, thanks! > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Wed Aug 8 17:45:23 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Wed, 8 Aug 2007 17:45:23 -0400 Subject: [rspec-users] rspec with autotest on a windows machine In-Reply-To: <9a07e4a80708081425q515be2b1m6bd4183b452bde59@mail.gmail.com> References: <9a07e4a80708081425q515be2b1m6bd4183b452bde59@mail.gmail.com> Message-ID: Do you have spec/spec.opts? Scott On Aug 8, 2007, at 5:25 PM, David Parker wrote: > Hello all, > I'm new to rSpec but after reading a couple of tutorials I've > become enamored. Anyway, I am at minute 42 of the rSpec basics > screencast ( peepcode.com) and I'm having the following error > running autotest w/rSpec: > D:\ruby\projects\forecaster > >autotest > loading autotest/rails_rspec > c:\ruby\bin\ruby -rrubygems -e "require 'redgreen'" -S script/spec > -O spec/spec.opts spec/models/weather_spec.rb spec/views/weathers/ > show.rhtml_spec.rb spec/controllers/weathers_controller_spec.rb > spec/views/weathers/new.rhtml_spec.rb spec/views/weathers/ > edit.rhtml_spec.rb spec/helpers/weathers_helper_spec.rb spec/views/ > weathers/index.rhtml_spec.rb > invalid option: -O > Test::Unit automatic runner. > > I also have the TDD screencast and I am able to run autotest with > no problems: > D:\ruby\projects\journal_app>autotest > loading autotest/rails > c:\ruby\bin\ruby -rrubygems -e "require 'redgreen'" -I.;lib;test - > rtest/unit -e "%w[test/functional/journals_controller_test.rb test/ > integration/journal_stories_test.rb test/unit/journal_test.rb].each > { |f| require f }" | unit_diff -u > Loaded suite -e > Started > ................ > Finished in 1.265 seconds. > 16 tests, 33 assertions, 0 failures, 0 errors > > Note: I am running Rails 1.2.3 and ZenTest v 3.6.1 on a Windows > machine (sad, I know, but we've discussed that already). > > When I run 'ruby script/spec -v' it says: > RSpec-1.0.5 (r2081) - BDD for Ruby > > I've also tried installing the newest version of the rSpec plugins > and running "ruby script/generate rspec" so the proper files are > copied to the script folder. > > as a "hack" fix, I did this: > 1) I removed my .autotest file completely (so no fun red/green/etc) > 2) I modified plugins>rspec >lib>autotest> rspec.rb and removed "# > {add_options_if_present}" from line 50 > > Anyone know of what my problem may be? Windows perhaps? It would > sure be nice to be able to keep my .autotest file... > Thanks for any help you can provide! > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From dchelimsky at gmail.com Wed Aug 8 18:10:19 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 8 Aug 2007 17:10:19 -0500 Subject: [rspec-users] Can't seem to spec a ActiveRecord::RecordInvalid exception properly... In-Reply-To: <7e565b5c0708081408q474ac9e9m729143cc86ddaab7@mail.gmail.com> References: <7e565b5c0708081408q474ac9e9m729143cc86ddaab7@mail.gmail.com> Message-ID: <57c63afe0708081510n53f725edu9aac14b9457a403a@mail.gmail.com> On 8/8/07, Fischer, Daniel wrote: > 1 def create > 2 @user = User.new(params[:user]) > 3 @user.save! > 4 self.current_user = @user > 5 redirect_to user_path(@user) > 6 flash[:notice] = "Thanks for signing up!" > 7 rescue ActiveRecord::RecordInvalid > 8 render :action => 'new' > 9 end Try this: describe "/users/create" do before(:each) do User.stub!(:new).and_return(@user = mock_model(User)) end it "should redirect to show on successful save" do @user.should_receive(:save!) post :create response.should redirect_to(user_path(@user)) end it "should re-render new on failed save" do @user.should_receive(:save!).and_raise(ActiveRecord::RecordInvalid.new(@user)) post :create response.should render_template('new') end end Cheers, David > > I can't seem to properly spec this out. I am trying numerous things, the > latest one is this, which makes sense but it still fails... > > > it "should re-render new on an invalid record exception" do > post :create, :user => {:login => nil} > response.should render_template(:new) > end > > should re-render new on an invalid record exception > expected "new", got nil > > Any help would be great, thanks! > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Wed Aug 8 18:53:16 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 8 Aug 2007 17:53:16 -0500 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708080807k6a8f13ecu435b97c24bd73207@mail.gmail.com> <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> Message-ID: <57c63afe0708081553w73a5d5afme2d851a3179fe343@mail.gmail.com> On 8/8/07, Lance Carlson wrote: > I just visited the action in my browser and i don't get any errors. I > am also running on edge rails as the application relies on > ActiveResource. Can you show me the code you created? OK - I've created a small project and am able to reproduce the behaviour you're describing. I'll follow up when learn something. David From lancecarlson at gmail.com Wed Aug 8 18:56:43 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Wed, 8 Aug 2007 18:56:43 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <57c63afe0708081553w73a5d5afme2d851a3179fe343@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708080807k6a8f13ecu435b97c24bd73207@mail.gmail.com> <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> <57c63afe0708081553w73a5d5afme2d851a3179fe343@mail.gmail.com> Message-ID: <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> Awesome! Thank you! :) On 8/8/07, David Chelimsky wrote: > On 8/8/07, Lance Carlson wrote: > > I just visited the action in my browser and i don't get any errors. I > > am also running on edge rails as the application relies on > > ActiveResource. Can you show me the code you created? > > OK - I've created a small project and am able to reproduce the > behaviour you're describing. I'll follow up when learn something. > > David > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From nemo7467 at gmail.com Wed Aug 8 19:12:32 2007 From: nemo7467 at gmail.com (David Parker) Date: Wed, 8 Aug 2007 18:12:32 -0500 Subject: [rspec-users] rspec with autotest on a windows machine Message-ID: <9a07e4a80708081612s56ae814ax43e9caaa92eb59fb@mail.gmail.com> Scott, Yes, my spec.opts file contains the following: --colour --format progress --loadby mtime --reverse Thoughts? If this seems like too much of a hassle, or unknown, I should say that I plan on "upgrading" my windows machine to Ubuntu Linux in the next week or two... Thanks, David Parker >Do you have spec/spec.opts? > >Scott On Aug 8, 2007, at 5:25 PM, David Parker wrote: > Hello all, > I'm new to rSpec but after reading a couple of tutorials I've > become enamored. Anyway, I am at minute 42 of the rSpec basics > screencast ( peepcode.com) and I'm having the following error > running autotest w/rSpec: > D:\ruby\projects\forecaster > >autotest > loading autotest/rails_rspec > c:\ruby\bin\ruby -rrubygems -e "require 'redgreen'" -S script/spec > -O spec/spec.opts spec/models/weather_spec.rb spec/views/weathers/ > show.rhtml_spec.rb spec/controllers/weathers_controller_spec.rb > spec/views/weathers/new.rhtml_spec.rb spec/views/weathers/ > edit.rhtml_spec.rb spec/helpers/weathers_helper_spec.rb spec/views/ > weathers/index.rhtml_spec.rb > invalid option: -O > Test::Unit automatic runner. > > I also have the TDD screencast and I am able to run autotest with > no problems: > D:\ruby\projects\journal_app>autotest > loading autotest/rails > c:\ruby\bin\ruby -rrubygems -e "require 'redgreen'" -I.;lib;test - > rtest/unit -e "%w[test/functional/journals_controller_test.rb test/ > integration/journal_stories_test.rb test/unit/journal_test.rb].each > { |f| require f }" | unit_diff -u > Loaded suite -e > Started > ................ > Finished in 1.265 seconds. > 16 tests, 33 assertions, 0 failures, 0 errors > > Note: I am running Rails 1.2.3 and ZenTest v 3.6.1 on a Windows > machine (sad, I know, but we've discussed that already). > > When I run 'ruby script/spec -v' it says: > RSpec-1.0.5 (r2081) - BDD for Ruby > > I've also tried installing the newest version of the rSpec plugins > and running "ruby script/generate rspec" so the proper files are > copied to the script folder. > > as a "hack" fix, I did this: > 1) I removed my .autotest file completely (so no fun red/green/etc) > 2) I modified plugins>rspec >lib>autotest> rspec.rb and removed "# > {add_options_if_present}" from line 50 > > Anyone know of what my problem may be? Windows perhaps? It would > sure be nice to be able to keep my .autotest file... > Thanks for any help you can provide! -- dp -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070808/962a6026/attachment.html From dchelimsky at gmail.com Wed Aug 8 22:35:34 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 8 Aug 2007 21:35:34 -0500 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708080807k6a8f13ecu435b97c24bd73207@mail.gmail.com> <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> <57c63afe0708081553w73a5d5afme2d851a3179fe343@mail.gmail.com> <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> Message-ID: <57c63afe0708081935x21e68a7ey74335c0129149325@mail.gmail.com> On 8/8/07, Lance Carlson wrote: > Awesome! Thank you! :) Don't thank me yet. I've spent some time trying to track this down and I've found my way into some methods in routing.rb that are dynamically generated (and so you can't )(*&)(*& read them to debug them quite so easily) that call the methods (in your case) label_id_value and id_value (being the artist id). I have no idea yet where those two methods get generated. Once I do, then we can stub them. Unfortunately I can't really spend any more time on this right now (though I'd love to solve it). In the mean time, you'll just have to use the parameters if you want the specs to work with the same code with which your app works. > > On 8/8/07, David Chelimsky wrote: > > On 8/8/07, Lance Carlson wrote: > > > I just visited the action in my browser and i don't get any errors. I > > > am also running on edge rails as the application relies on > > > ActiveResource. Can you show me the code you created? > > > > OK - I've created a small project and am able to reproduce the > > behaviour you're describing. I'll follow up when learn something. > > > > David > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Wed Aug 8 22:48:43 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 8 Aug 2007 21:48:43 -0500 Subject: [rspec-users] RSpec book? In-Reply-To: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> References: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> Message-ID: <57c63afe0708081948k6d5f8019p27ffcb055f18d0c4@mail.gmail.com> On 8/8/07, Ashley Moran wrote: > > > Came across this as a stub page browsing Amazon UK. This is good > news! I'm surprised it hasn't been discussed on the list before. > Was Chad keeping it a secret? > > I hope it will have plenty of BDD theory. I'm still waiting for that > magic book I can give to someone and say "here - read this, it tells > you how to build software". I don't think this will be the one and only book to solve that problem, but you should know that Aslak and I are working on an RSpec/BDD book as well. There are still some things being worked out, which is why I haven't really been spouting about it yet, but you can expect to be hearing quite a bit about it within the next few weeks. From dchelimsky at gmail.com Wed Aug 8 22:52:00 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 8 Aug 2007 21:52:00 -0500 Subject: [rspec-users] RSpec book? In-Reply-To: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> References: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> Message-ID: <57c63afe0708081952o51db239em66152a01823268a8@mail.gmail.com> On 8/8/07, Ashley Moran wrote: > I'm still waiting for that > magic book I can give to someone and say "here - read this, it tells > you how to build software". Have you read this one? http://www.amazon.com/Software-Development-Principles-Patterns-Practices/dp/0135974445/ref=pd_bbs_sr_1/002-7438072-0005646?ie=UTF8&s=books&qid=1186627780&sr=8-1 It pre-dates the BDD discussion, but is packed with very relevant material. From kevwil at gmail.com Wed Aug 8 22:52:52 2007 From: kevwil at gmail.com (Kevin Williams) Date: Wed, 8 Aug 2007 20:52:52 -0600 Subject: [rspec-users] RSpec book? In-Reply-To: <57c63afe0708081948k6d5f8019p27ffcb055f18d0c4@mail.gmail.com> References: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> <57c63afe0708081948k6d5f8019p27ffcb055f18d0c4@mail.gmail.com> Message-ID: <683a886f0708081952o53a31e71m4fcd79eaf3529b1c@mail.gmail.com> Cool. The more exposure we can give BDD/RSpec, the better. I'll probably read both. :) On 8/8/07, David Chelimsky wrote: > On 8/8/07, Ashley Moran wrote: > > > > > > Came across this as a stub page browsing Amazon UK. This is good > > news! I'm surprised it hasn't been discussed on the list before. > > Was Chad keeping it a secret? > > > > I hope it will have plenty of BDD theory. I'm still waiting for that > > magic book I can give to someone and say "here - read this, it tells > > you how to build software". > > I don't think this will be the one and only book to solve that > problem, but you should know that Aslak and I are working on an > RSpec/BDD book as well. There are still some things being worked out, > which is why I haven't really been spouting about it yet, but you can > expect to be hearing quite a bit about it within the next few weeks. > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -- Cheers, Kevin Williams http://www.almostserio.us/ http://kevwil.tumblr.com/ http://kevwil.jaiku.com/ From znmeb at cesmail.net Thu Aug 9 00:00:58 2007 From: znmeb at cesmail.net (M. Edward (Ed) Borasky) Date: Wed, 08 Aug 2007 21:00:58 -0700 Subject: [rspec-users] RSpec book? In-Reply-To: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> References: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> Message-ID: <46BA917A.6090503@cesmail.net> Ashley Moran wrote: > I hope it will have plenty of BDD theory. I'm still waiting for that > magic book I can give to someone and say "here - read this, it tells > you how to build software". I have two copies, but as far as I know it's still in print. If you can't find it, let me know -- I'll trade you for your copy of the magic book that tells you how to make money giving programming expertise away. :) From obiefernandez at gmail.com Thu Aug 9 01:09:13 2007 From: obiefernandez at gmail.com (Obie Fernandez) Date: Thu, 9 Aug 2007 01:09:13 -0400 Subject: [rspec-users] RSpec book? In-Reply-To: <46BA917A.6090503@cesmail.net> References: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> <46BA917A.6090503@cesmail.net> Message-ID: <8bf510930708082209w65b186ebl67e44155efc6e9e2@mail.gmail.com> I'm including a chapter about RSpec and its Rails plugin in my book, The Rails Way. It'll be out in October. I'm also rallying for an RSpec book to be added to our Professional Ruby Series at Addison-Wesley. Stay tuned for more on that. -- Obie Fernandez http://jroller.com/obie/ Pre-order my book The Rails Way today! http://www.amazon.com/dp/0321445619 From smingins at elctech.com Thu Aug 9 01:14:18 2007 From: smingins at elctech.com (Shane Mingins) Date: Thu, 9 Aug 2007 17:14:18 +1200 Subject: [rspec-users] RSpec book? In-Reply-To: <8bf510930708082209w65b186ebl67e44155efc6e9e2@mail.gmail.com> References: <0ECB23AC-0DAF-41E6-B1C0-5F81D002AA58@ashleymoran.me.uk> <46BA917A.6090503@cesmail.net> <8bf510930708082209w65b186ebl67e44155efc6e9e2@mail.gmail.com> Message-ID: Hi Obie I am patiently waiting for October as I am really look forward to this book! Cheers Shane On 9/08/2007, at 5:09 PM, Obie Fernandez wrote: > I'm including a chapter about RSpec and its Rails plugin in my book, > The Rails Way. It'll be out in October. I'm also rallying for an RSpec > book to be added to our Professional Ruby Series at Addison-Wesley. > Stay tuned for more on that. > > -- > Obie Fernandez > http://jroller.com/obie/ > > Pre-order my book The Rails Way today! > http://www.amazon.com/dp/0321445619 > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070809/ee57b554/attachment-0001.html From obiefernandez at gmail.com Thu Aug 9 01:35:21 2007 From: obiefernandez at gmail.com (Obie Fernandez) Date: Thu, 9 Aug 2007 01:35:21 -0400 Subject: [rspec-users] Any liberally-licensed open source projects out there that make good use of RSpec? In-Reply-To: References: <8bf510930707301948r36e2fbb7t7062175829eed85e@mail.gmail.com> Message-ID: <8bf510930708082235r2d521deg7dc35ee324a06915@mail.gmail.com> Thanks, Scott. Checking it out now. On 7/31/07, Scott Taylor wrote: > > I've just started DatedBackup (an rsnapshot-like utility), which has > about 500 LOC at the moment. It is licensed under the GPL, and has > 190 example specs. If you are interested, download the trunk from > Rubyforge: > > svn checkout svn://rubyforge.org/var/svn/datedbackup/trunk/ > svn checkout http://datedbackup.rubyforge.org/svn/trunk/ > > It has a DSL baked in, which I know is up your alley. > > Of course, Rspec itself would probably be the model if you needed to > look at specs. > > Best Regards, > > > Scott > > On Jul 30, 2007, at 10:48 PM, Obie Fernandez wrote: > > > I'm trolling for example RSpec code. Any pointers appreciated. > > > > Cheers, > > Obie > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -- Obie Fernandez http://jroller.com/obie/ Pre-order my book The Rails Way today! http://www.amazon.com/dp/0321445619 From obiefernandez at gmail.com Thu Aug 9 01:39:01 2007 From: obiefernandez at gmail.com (Obie Fernandez) Date: Thu, 9 Aug 2007 01:39:01 -0400 Subject: [rspec-users] Any liberally-licensed open source projects out there that make good use of RSpec? In-Reply-To: References: <8bf510930707301948r36e2fbb7t7062175829eed85e@mail.gmail.com> Message-ID: <8bf510930708082239h4636fb24idc3f0a25d93da02c@mail.gmail.com> Any idea if it's kosher to include snippets of GPL'd code in a commercial publication? MIT license is no problem, but the GPL makes me nervous about that. On 7/31/07, Scott Taylor wrote: > > I've just started DatedBackup (an rsnapshot-like utility), which has > about 500 LOC at the moment. It is licensed under the GPL, and has > 190 example specs. If you are interested, download the trunk from > Rubyforge: > > svn checkout svn://rubyforge.org/var/svn/datedbackup/trunk/ > svn checkout http://datedbackup.rubyforge.org/svn/trunk/ > > It has a DSL baked in, which I know is up your alley. > > Of course, Rspec itself would probably be the model if you needed to > look at specs. > > Best Regards, > > > Scott > > On Jul 30, 2007, at 10:48 PM, Obie Fernandez wrote: > > > I'm trolling for example RSpec code. Any pointers appreciated. > > > > Cheers, > > Obie > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -- Obie Fernandez http://jroller.com/obie/ Pre-order my book The Rails Way today! http://www.amazon.com/dp/0321445619 From has.sox at gmail.com Thu Aug 9 01:39:43 2007 From: has.sox at gmail.com (Daniel N) Date: Thu, 9 Aug 2007 15:39:43 +1000 Subject: [rspec-users] Any liberally-licensed open source projects out there that make good use of RSpec? In-Reply-To: <8bf510930708082235r2d521deg7dc35ee324a06915@mail.gmail.com> References: <8bf510930707301948r36e2fbb7t7062175829eed85e@mail.gmail.com> <8bf510930708082235r2d521deg7dc35ee324a06915@mail.gmail.com> Message-ID: <2fff50390708082239v7fb99e52kb694aa938b887992@mail.gmail.com> On 8/9/07, Obie Fernandez wrote: > > Thanks, Scott. Checking it out now. > > On 7/31/07, Scott Taylor wrote: > > > > I've just started DatedBackup (an rsnapshot-like utility), which has > > about 500 LOC at the moment. It is licensed under the GPL, and has > > 190 example specs. If you are interested, download the trunk from > > Rubyforge: > > > > svn checkout svn://rubyforge.org/var/svn/datedbackup/trunk/ > > svn checkout http://datedbackup.rubyforge.org/svn/trunk/ > > > > It has a DSL baked in, which I know is up your alley. > > > > Of course, Rspec itself would probably be the model if you needed to > > look at specs. > > > > Best Regards, > > > > > > Scott > > > > On Jul 30, 2007, at 10:48 PM, Obie Fernandez wrote: > > > > > I'm trolling for example RSpec code. Any pointers appreciated. > > > > > > Cheers, > > > Obie > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > -- > Obie Fernandez > http://jroller.com/obie/ Merb writes it's spec in rspec. merb.devjavu.com I don't know that they're best practice but there are a few different styles amongst the specs HTH Daniel -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070809/2c4da0cd/attachment.html From mailing_lists at railsnewbie.com Thu Aug 9 03:55:01 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Thu, 9 Aug 2007 03:55:01 -0400 Subject: [rspec-users] rspec with autotest on a windows machine In-Reply-To: <9a07e4a80708081612s56ae814ax43e9caaa92eb59fb@mail.gmail.com> References: <9a07e4a80708081612s56ae814ax43e9caaa92eb59fb@mail.gmail.com> Message-ID: Well, I can tell you that you *won't* need the --loadby, and -- reverse switches if using autotest. Does the command generated by autotest run ok on your DOS command line? Scott On Aug 8, 2007, at 7:12 PM, David Parker wrote: > Scott, > > Yes, my spec.opts file contains the following: > --colour > --format > progress > --loadby > mtime > --reverse > > Thoughts? If this seems like too much of a hassle, or unknown, I > should say that I plan on "upgrading" my windows machine to Ubuntu > Linux in the next week or two... > > Thanks, > > David Parker > > > >Do you have spec/spec.opts? > > > >Scott > > > On Aug 8, 2007, at 5:25 PM, David Parker wrote: > > > Hello all, > > I'm new to rSpec but after reading a couple of tutorials I've > > become enamored. Anyway, I am at minute 42 of the rSpec basics > > screencast ( peepcode.com) and I'm having the following error > > running autotest w/rSpec: > > D:\ruby\projects\forecaster > > >autotest > > loading autotest/rails_rspec > > c:\ruby\bin\ruby -rrubygems -e "require 'redgreen'" -S script/spec > > -O spec/spec.opts spec/models/weather_spec.rb spec/views/weathers/ > > show.rhtml_spec.rb spec/controllers/weathers > _controller_spec.rb > > spec/views/weathers/new.rhtml_spec.rb spec/views/weathers/ > > edit.rhtml_spec.rb spec/helpers/weathers_helper_spec.rb spec/views/ > > weathers/index.rhtml_spec.rb > > invalid option: -O > > Test::Unit automatic runner. > > > > I also have the TDD screencast and I am able to run autotest with > > no problems: > > D:\ruby\projects\journal_app>autotest > > loading autotest/rails > > c:\ruby\bin\ruby -rrubygems -e "require 'redgreen'" -I.;lib;test - > > rtest/unit -e "%w[test/functional/journals_controller_test.rb test/ > > integration/journal_stories_test.rb test/unit/journal_test.rb].each > > { |f| require f }" | unit_diff -u > > Loaded suite -e > > Started > > ................ > > Finished in 1.265 seconds. > > 16 tests, 33 assertions, 0 failures, 0 errors > > > > Note: I am running Rails 1.2.3 and ZenTest v 3.6.1 on a Windows > > machine (sad, I know, but we've discussed that already). > > > > When I run 'ruby script/spec -v' it says: > > RSpec-1.0.5 (r2081) - BDD for Ruby > > > > I've also tried installing the newest version of the rSpec plugins > > and running "ruby script/generate rspec" so the proper files are > > copied to the script folder. > > > > as a "hack" fix, I did this: > > 1) I removed my .autotest file completely (so no fun red/green/etc) > > 2) I modified plugins>rspec >lib>autotest> rspec.rb and removed "# > > {add_options_if_present}" from line 50 > > > > Anyone know of what my problem may be? Windows perhaps? It would > > sure be nice to be able to keep my .autotest file... > > Thanks for any help you can provide! > > > -- > > dp > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From aslak.hellesoy at gmail.com Thu Aug 9 05:33:58 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Thu, 9 Aug 2007 11:33:58 +0200 Subject: [rspec-users] Any liberally-licensed open source projects out there that make good use of RSpec? In-Reply-To: <8bf510930708082239h4636fb24idc3f0a25d93da02c@mail.gmail.com> References: <8bf510930707301948r36e2fbb7t7062175829eed85e@mail.gmail.com> <8bf510930708082239h4636fb24idc3f0a25d93da02c@mail.gmail.com> Message-ID: <8d961d900708090233o510d00dah574ec305f582beb5@mail.gmail.com> Hi Obie! Check out Rubinius and Gecode/R (and RSpec hehe) On 8/9/07, Obie Fernandez wrote: > Any idea if it's kosher to include snippets of GPL'd code in a > commercial publication? MIT license is no problem, but the GPL makes > me nervous about that. > I, personally, wouldn't want to put a virus in my book, but IANAL. Aslak > On 7/31/07, Scott Taylor wrote: > > > > I've just started DatedBackup (an rsnapshot-like utility), which has > > about 500 LOC at the moment. It is licensed under the GPL, and has > > 190 example specs. If you are interested, download the trunk from > > Rubyforge: > > > > svn checkout svn://rubyforge.org/var/svn/datedbackup/trunk/ > > svn checkout http://datedbackup.rubyforge.org/svn/trunk/ > > > > It has a DSL baked in, which I know is up your alley. > > > > Of course, Rspec itself would probably be the model if you needed to > > look at specs. > > > > Best Regards, > > > > > > Scott > > > > On Jul 30, 2007, at 10:48 PM, Obie Fernandez wrote: > > > > > I'm trolling for example RSpec code. Any pointers appreciated. > > > > > > Cheers, > > > Obie > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > -- > Obie Fernandez > http://jroller.com/obie/ > > Pre-order my book The Rails Way today! > http://www.amazon.com/dp/0321445619 > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Thu Aug 9 06:36:37 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Thu, 9 Aug 2007 06:36:37 -0400 Subject: [rspec-users] Any liberally-licensed open source projects out there that make good use of RSpec? In-Reply-To: <8d961d900708090233o510d00dah574ec305f582beb5@mail.gmail.com> References: <8bf510930707301948r36e2fbb7t7062175829eed85e@mail.gmail.com> <8bf510930708082239h4636fb24idc3f0a25d93da02c@mail.gmail.com> <8d961d900708090233o510d00dah574ec305f582beb5@mail.gmail.com> Message-ID: <520E60AC-35CA-4B46-8E9B-16BFE33E5260@railsnewbie.com> On Aug 9, 2007, at 5:33 AM, aslak hellesoy wrote: > Hi Obie! > > Check out Rubinius and Gecode/R (and RSpec hehe) > I would second Rubinius, because it would considerably lessen the learning curve for some one new to RSpec. > On 8/9/07, Obie Fernandez wrote: >> Any idea if it's kosher to include snippets of GPL'd code in a >> commercial publication? MIT license is no problem, but the GPL makes >> me nervous about that. >> > > I, personally, wouldn't want to put a virus in my book, but IANAL. A virus? Strong words, Aslak. On another note, this book aside: Why is *all* the Ruby code out there licensed under MIT, and not GPL'ed or dual licensed? Scott From justnothing at tiscali.co.uk Thu Aug 9 07:07:31 2007 From: justnothing at tiscali.co.uk (David Green) Date: Thu, 9 Aug 2007 04:07:31 -0700 (PDT) Subject: [rspec-users] reusable specs - almost there In-Reply-To: <57c63afe0708051452h3a4e4013saae007fd30c2c68a@mail.gmail.com> References: <11996399.post@talk.nabble.com> <57c63afe0708050857x61afe07aiedafcea9f4961698@mail.gmail.com> <12007548.post@talk.nabble.com> <57c63afe0708051452h3a4e4013saae007fd30c2c68a@mail.gmail.com> Message-ID: <12070479.post@talk.nabble.com> David Chelimsky-2 wrote: > > On 8/5/07, David Green wrote: >> >> that's a great point, but there are some things about shared behaviours I >> don't like. for example, I have 14 different contexts I'm testing (and >> more >> to come) in 8 controllers. >> >> I can do this: >> >> describe MyController do >> it_should_behave_like "context 1" >> it_should_behave_like "context 2" >> . >> . >> it_should_behave_like "context 14" >> end >> >> but then I lose the context info in the output, it just displays one long >> list of examples. > > Interesting. This is kind of backwards from how I envision shared > behaviours. To me, a shared behaviour is a behaviour that is shared > across objects, not contexts. In other words: > > describe "any controller", :shared => true do > it "should do a when b" { ... } > end > > describe "a specific controller" do > it_should_behave_like "any controller" > end > > As opposed to: > > describe "any controller when the user is logged in", :shared => true do > it "should do a when b" { ... } > end > > describe "a specific controller" do > it_should_behave_like "any controller when the user is logged in" > end > > Subtle difference, but I'm sure it guides in a different direction. > > The problem you're experiencing is not new, and I'm definitely > interested in discussing solutions for it, but I'm much more > interested in ways rspec could improve than ways to work around > rspec's deficiencies. > >> The alternative is: >> >> describe MyController, "context 1" do >> it_should_behave_like "context 1" >> end >> describe MyController, "context 2" do >> it_should_behave_like "context 2" >> end >> . >> . >> describe MyController, "context 14" do >> it_should_behave_like "context 14" >> end >> >> this way the context info is preserved in the output, but it's more work, >> especially across 8 controllers. >> >> another thing is, depending on the model being used, controllers will >> instantiate variables of different names. e.g. in the "dvd" controller, >> an >> instance of the Dvd model would be stored in @dvd, whereas in the "book" >> controller, it would be in @book . using dynamic specs, I can make my >> examples more specific depending on the controller being tested e.g. : >> >> # obj and var passed in as parameters >> it "should load a #{obj.class} object into @#{varname}" do >> get :show >> assigns[var_name].should == obj >> end >> >> I could put obj and varname into instance variables in the before() >> method, >> but they're only available in the example block, not from the example >> title >> >> these are minor complaints really, but as my project grows, they become >> more >> of an issue. > > Understood - although, if all of these controllers are behaving > exactly the same way with only a variable name or two difference, it > seems to me that the duplication problem is in the code, not the > specs. Perhaps there is some common code that could be extracted to a > module - then you can have specs for that module and specify that the > module should be included in each of your controllers. > > WDYT? > > I spent some time refactoring and I'm at happy with the stage I'm at now. as per your suggestion, I extracted common code and now only test it in one controller. In situations where it isn't practical to extract code, I'm still using shared behaviour but setting instance variables in before() to customize the specs slightly. I've pretty much given up on dynamically generating specs. as for improving rspec, I think it would be a great feature if shared behaviours could accept parameters, which are available both inside and outside examples. Then you could do things like: describe "a standard create action", :shared => true do it "should instantiate a new #{target_class} object called #{target_name}" do get :create assigns[target_name].should be_instance_of(target_class) end end I can accomplish the same by setting @target_name and @target_class instance variables, but it would be nice if the example titles could include those values too. thanks for all your help dave -- View this message in context: http://www.nabble.com/reusable-specs---almost-there-tf4216708.html#a12070479 Sent from the rspec-users mailing list archive at Nabble.com. From mailing_lists at railsnewbie.com Thu Aug 9 07:57:00 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Thu, 9 Aug 2007 07:57:00 -0400 Subject: [rspec-users] Any liberally-licensed open source projects out there that make good use of RSpec? In-Reply-To: <8d961d900708090233o510d00dah574ec305f582beb5@mail.gmail.com> References: <8bf510930707301948r36e2fbb7t7062175829eed85e@mail.gmail.com> <8bf510930708082239h4636fb24idc3f0a25d93da02c@mail.gmail.com> <8d961d900708090233o510d00dah574ec305f582beb5@mail.gmail.com> Message-ID: On Aug 9, 2007, at 5:33 AM, aslak hellesoy wrote: > Hi Obie! > > Check out Rubinius and Gecode/R (and RSpec hehe) > > On 8/9/07, Obie Fernandez wrote: >> Any idea if it's kosher to include snippets of GPL'd code in a >> commercial publication? MIT license is no problem, but the GPL makes >> me nervous about that. >> > > I, personally, wouldn't want to put a virus in my book, but IANAL. This seems to cover it (at least in the US): http://www.gnu.org/licenses/gpl-faq.html#SourceCodeInDocumentation http://en.wikipedia.org/wiki/Fair_Use Scott From rspec.user at gmail.com Thu Aug 9 19:44:10 2007 From: rspec.user at gmail.com (sinclair bain) Date: Thu, 9 Aug 2007 19:44:10 -0400 Subject: [rspec-users] AutoTest plugin and rspec for rails Message-ID: <2ca660dd0708091644v27397e2bpaa8187ca36381276@mail.gmail.com> (WinXP) Hi, I have the autotest rails plugin running - detecting changes and running the examples. However the rspec color output (of which I am a fan) ... has stopped happening Anybody got a spare moment to point me in the right direction, please ? Cheers! sinclair -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070809/2331a41a/attachment.html From dchelimsky at gmail.com Thu Aug 9 19:47:56 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 9 Aug 2007 18:47:56 -0500 Subject: [rspec-users] AutoTest plugin and rspec for rails In-Reply-To: <2ca660dd0708091644v27397e2bpaa8187ca36381276@mail.gmail.com> References: <2ca660dd0708091644v27397e2bpaa8187ca36381276@mail.gmail.com> Message-ID: <57c63afe0708091647w1fb65279k4c164638e795480b@mail.gmail.com> On 8/9/07, sinclair bain wrote: > (WinXP) > Hi, > > I have the autotest rails plugin running - detecting changes and running the > examples. > > However the rspec color output (of which I am a fan) ... has stopped > happening > > Anybody got a spare moment to point me in the right direction, please ? You need a spec/spec.opts file with the following: --colour Is that in place? Also, what versions of everything are you using? > > Cheers! > sinclair > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lancecarlson at gmail.com Thu Aug 9 20:11:49 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Thu, 9 Aug 2007 20:11:49 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <57c63afe0708081935x21e68a7ey74335c0129149325@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> <57c63afe0708081553w73a5d5afme2d851a3179fe343@mail.gmail.com> <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> <57c63afe0708081935x21e68a7ey74335c0129149325@mail.gmail.com> Message-ID: <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> Were you able to come up with any solutions? On 8/8/07, David Chelimsky wrote: > On 8/8/07, Lance Carlson wrote: > > Awesome! Thank you! :) > > Don't thank me yet. I've spent some time trying to track this down and > I've found my way into some methods in routing.rb that are dynamically > generated (and so you can't )(*&)(*& read them to debug them quite so > easily) that call the methods (in your case) label_id_value and > id_value (being the artist id). I have no idea yet where those two > methods get generated. Once I do, then we can stub them. Unfortunately > I can't really spend any more time on this right now (though I'd love > to solve it). > > In the mean time, you'll just have to use the parameters if you want > the specs to work with the same code with which your app works. > > > > > > On 8/8/07, David Chelimsky wrote: > > > On 8/8/07, Lance Carlson wrote: > > > > I just visited the action in my browser and i don't get any errors. I > > > > am also running on edge rails as the application relies on > > > > ActiveResource. Can you show me the code you created? > > > > > > OK - I've created a small project and am able to reproduce the > > > behaviour you're describing. I'll follow up when learn something. > > > > > > David > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Thu Aug 9 20:16:34 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 9 Aug 2007 19:16:34 -0500 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> <57c63afe0708081553w73a5d5afme2d851a3179fe343@mail.gmail.com> <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> <57c63afe0708081935x21e68a7ey74335c0129149325@mail.gmail.com> <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> Message-ID: <57c63afe0708091716u70a2f998j43fed817f6fe0f27@mail.gmail.com> On 8/9/07, Lance Carlson wrote: > Were you able to come up with any solutions? Nope. Anyone else? > > On 8/8/07, David Chelimsky wrote: > > On 8/8/07, Lance Carlson wrote: > > > Awesome! Thank you! :) > > > > Don't thank me yet. I've spent some time trying to track this down and > > I've found my way into some methods in routing.rb that are dynamically > > generated (and so you can't )(*&)(*& read them to debug them quite so > > easily) that call the methods (in your case) label_id_value and > > id_value (being the artist id). I have no idea yet where those two > > methods get generated. Once I do, then we can stub them. Unfortunately > > I can't really spend any more time on this right now (though I'd love > > to solve it). > > > > In the mean time, you'll just have to use the parameters if you want > > the specs to work with the same code with which your app works. > > > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > On 8/8/07, Lance Carlson wrote: > > > > > I just visited the action in my browser and i don't get any errors. I > > > > > am also running on edge rails as the application relies on > > > > > ActiveResource. Can you show me the code you created? > > > > > > > > OK - I've created a small project and am able to reproduce the > > > > behaviour you're describing. I'll follow up when learn something. > > > > > > > > David > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lancecarlson at gmail.com Thu Aug 9 20:21:05 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Thu, 9 Aug 2007 20:21:05 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <57c63afe0708091716u70a2f998j43fed817f6fe0f27@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> <57c63afe0708081553w73a5d5afme2d851a3179fe343@mail.gmail.com> <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> <57c63afe0708081935x21e68a7ey74335c0129149325@mail.gmail.com> <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> <57c63afe0708091716u70a2f998j43fed817f6fe0f27@mail.gmail.com> Message-ID: <49f64a900708091721x4c7e0beeqf6febb40a7845192@mail.gmail.com> Is it possible that rspec is not pulling the instance variables into the method because this method is being defined before instance variables in parameters are assigned to that method? I'm trying to hone down where the problem is popping up exactly. Any insight? On 8/9/07, David Chelimsky wrote: > On 8/9/07, Lance Carlson wrote: > > Were you able to come up with any solutions? > > Nope. Anyone else? > > > > > On 8/8/07, David Chelimsky wrote: > > > On 8/8/07, Lance Carlson wrote: > > > > Awesome! Thank you! :) > > > > > > Don't thank me yet. I've spent some time trying to track this down and > > > I've found my way into some methods in routing.rb that are dynamically > > > generated (and so you can't )(*&)(*& read them to debug them quite so > > > easily) that call the methods (in your case) label_id_value and > > > id_value (being the artist id). I have no idea yet where those two > > > methods get generated. Once I do, then we can stub them. Unfortunately > > > I can't really spend any more time on this right now (though I'd love > > > to solve it). > > > > > > In the mean time, you'll just have to use the parameters if you want > > > the specs to work with the same code with which your app works. > > > > > > > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > I just visited the action in my browser and i don't get any errors. I > > > > > > am also running on edge rails as the application relies on > > > > > > ActiveResource. Can you show me the code you created? > > > > > > > > > > OK - I've created a small project and am able to reproduce the > > > > > behaviour you're describing. I'll follow up when learn something. > > > > > > > > > > David > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Thu Aug 9 20:31:14 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 9 Aug 2007 19:31:14 -0500 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <49f64a900708091721x4c7e0beeqf6febb40a7845192@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> <57c63afe0708081553w73a5d5afme2d851a3179fe343@mail.gmail.com> <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> <57c63afe0708081935x21e68a7ey74335c0129149325@mail.gmail.com> <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> <57c63afe0708091716u70a2f998j43fed817f6fe0f27@mail.gmail.com> <49f64a900708091721x4c7e0beeqf6febb40a7845192@mail.gmail.com> Message-ID: <57c63afe0708091731h37fc80a7qa5f1cff16bbd7549@mail.gmail.com> On 8/9/07, Lance Carlson wrote: > Is it possible that rspec is not pulling the instance variables into > the method because this method is being defined before instance > variables in parameters are assigned to that method? I'm trying to > hone down where the problem is popping up exactly. Any insight? Not really more than what I said earlier in this thread. > On 8/9/07, David Chelimsky wrote: > > On 8/9/07, Lance Carlson wrote: > > > Were you able to come up with any solutions? > > > > Nope. Anyone else? > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > On 8/8/07, Lance Carlson wrote: > > > > > Awesome! Thank you! :) > > > > > > > > Don't thank me yet. I've spent some time trying to track this down and > > > > I've found my way into some methods in routing.rb that are dynamically > > > > generated (and so you can't )(*&)(*& read them to debug them quite so > > > > easily) that call the methods (in your case) label_id_value and > > > > id_value (being the artist id). I have no idea yet where those two > > > > methods get generated. Once I do, then we can stub them. Unfortunately > > > > I can't really spend any more time on this right now (though I'd love > > > > to solve it). > > > > > > > > In the mean time, you'll just have to use the parameters if you want > > > > the specs to work with the same code with which your app works. > > > > > > > > > > > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > > I just visited the action in my browser and i don't get any errors. I > > > > > > > am also running on edge rails as the application relies on > > > > > > > ActiveResource. Can you show me the code you created? > > > > > > > > > > > > OK - I've created a small project and am able to reproduce the > > > > > > behaviour you're describing. I'll follow up when learn something. > > > > > > > > > > > > David > > > > > > _______________________________________________ > > > > > > rspec-users mailing list > > > > > > rspec-users at rubyforge.org > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lancecarlson at gmail.com Thu Aug 9 20:36:12 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Thu, 9 Aug 2007 20:36:12 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <57c63afe0708091731h37fc80a7qa5f1cff16bbd7549@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> <57c63afe0708081553w73a5d5afme2d851a3179fe343@mail.gmail.com> <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> <57c63afe0708081935x21e68a7ey74335c0129149325@mail.gmail.com> <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> <57c63afe0708091716u70a2f998j43fed817f6fe0f27@mail.gmail.com> <49f64a900708091721x4c7e0beeqf6febb40a7845192@mail.gmail.com> <57c63afe0708091731h37fc80a7qa5f1cff16bbd7549@mail.gmail.com> Message-ID: <49f64a900708091736x4b71f847je4dd001081b145e3@mail.gmail.com> About these methods requiring arguments? I thought you were able to reproduce the problems I was having and was also able to reproduce a working application with no arguments. By default these methods should not require arguments to be passed as it is unnecessary noise in the code. Perhaps we can continue this discussion on IRC? #rspec? What is your s/n? On 8/9/07, David Chelimsky wrote: > On 8/9/07, Lance Carlson wrote: > > Is it possible that rspec is not pulling the instance variables into > > the method because this method is being defined before instance > > variables in parameters are assigned to that method? I'm trying to > > hone down where the problem is popping up exactly. Any insight? > > Not really more than what I said earlier in this thread. > > > On 8/9/07, David Chelimsky wrote: > > > On 8/9/07, Lance Carlson wrote: > > > > Were you able to come up with any solutions? > > > > > > Nope. Anyone else? > > > > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > Awesome! Thank you! :) > > > > > > > > > > Don't thank me yet. I've spent some time trying to track this down and > > > > > I've found my way into some methods in routing.rb that are dynamically > > > > > generated (and so you can't )(*&)(*& read them to debug them quite so > > > > > easily) that call the methods (in your case) label_id_value and > > > > > id_value (being the artist id). I have no idea yet where those two > > > > > methods get generated. Once I do, then we can stub them. Unfortunately > > > > > I can't really spend any more time on this right now (though I'd love > > > > > to solve it). > > > > > > > > > > In the mean time, you'll just have to use the parameters if you want > > > > > the specs to work with the same code with which your app works. > > > > > > > > > > > > > > > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > > > I just visited the action in my browser and i don't get any errors. I > > > > > > > > am also running on edge rails as the application relies on > > > > > > > > ActiveResource. Can you show me the code you created? > > > > > > > > > > > > > > OK - I've created a small project and am able to reproduce the > > > > > > > behaviour you're describing. I'll follow up when learn something. > > > > > > > > > > > > > > David > > > > > > > _______________________________________________ > > > > > > > rspec-users mailing list > > > > > > > rspec-users at rubyforge.org > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > _______________________________________________ > > > > > > rspec-users mailing list > > > > > > rspec-users at rubyforge.org > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From barjunk at attglobal.net Thu Aug 9 20:57:41 2007 From: barjunk at attglobal.net (barsalou) Date: Thu, 09 Aug 2007 16:57:41 -0800 Subject: [rspec-users] Using rcov and ouput to screen Message-ID: <20070809165741.haskmtz628sgg88w@lcgalaska.com> I'd like to output my rcov data to the screen in ascii instead of html...is that possible using the rake spec:rcov command? Also, is there somewhere that will allow me to search the mail archives...I'm pretty sure someone else has asked similar questions. Thanks for the help. Mike B. ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program. From mailing_lists at railsnewbie.com Thu Aug 9 22:16:07 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Thu, 9 Aug 2007 22:16:07 -0400 Subject: [rspec-users] AutoTest plugin and rspec for rails In-Reply-To: <57c63afe0708091647w1fb65279k4c164638e795480b@mail.gmail.com> References: <2ca660dd0708091644v27397e2bpaa8187ca36381276@mail.gmail.com> <57c63afe0708091647w1fb65279k4c164638e795480b@mail.gmail.com> Message-ID: On Aug 9, 2007, at 7:47 PM, David Chelimsky wrote: > On 8/9/07, sinclair bain wrote: >> (WinXP) >> Hi, >> >> I have the autotest rails plugin running - detecting changes and >> running the >> examples. >> >> However the rspec color output (of which I am a fan) ... has stopped >> happening >> >> Anybody got a spare moment to point me in the right direction, >> please ? > > You need a spec/spec.opts file with the following: > > --colour > > Is that in place? Also, what versions of everything are you using? Also try running it would the --drb flag, if you are already using it. Scott From mailing_lists at railsnewbie.com Thu Aug 9 22:20:37 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Thu, 9 Aug 2007 22:20:37 -0400 Subject: [rspec-users] Using rcov and ouput to screen In-Reply-To: <20070809165741.haskmtz628sgg88w@lcgalaska.com> References: <20070809165741.haskmtz628sgg88w@lcgalaska.com> Message-ID: <82882AA6-F729-4431-AFCA-7FFEEA71CFF3@railsnewbie.com> On Aug 9, 2007, at 8:57 PM, barsalou wrote: > I'd like to output my rcov data to the screen in ascii instead of > html...is that possible using the rake spec:rcov command? Look at the RSpec gem's rdoc. I believe it is something like Rake::RcovTask. An option can be provided to give rcov options. Run rcov --help. > > Also, is there somewhere that will allow me to search the mail > archives...I'm pretty sure someone else has asked similar questions. > Google is your friend. Rubyforge also has the mailing lists, although they aren't searchable. Scott From rspec.user at gmail.com Thu Aug 9 22:33:12 2007 From: rspec.user at gmail.com (sinclair bain) Date: Thu, 9 Aug 2007 22:33:12 -0400 Subject: [rspec-users] AutoTest plugin and rspec for rails In-Reply-To: <57c63afe0708091647w1fb65279k4c164638e795480b@mail.gmail.com> References: <2ca660dd0708091644v27397e2bpaa8187ca36381276@mail.gmail.com> <57c63afe0708091647w1fb65279k4c164638e795480b@mail.gmail.com> Message-ID: <2ca660dd0708091933g6d0e9215p85c466a591835fb7@mail.gmail.com> Dave, Got that ... --colour --format progress ... The latest ... all installed today ... except rspec 4 rails it is 1.0. This was all going ok before I installed autotest (red, green and yellow). On 8/9/07, David Chelimsky wrote: > > On 8/9/07, sinclair bain wrote: > > (WinXP) > > Hi, > > > > I have the autotest rails plugin running - detecting changes and running > the > > examples. > > > > However the rspec color output (of which I am a fan) ... has stopped > > happening > > > > Anybody got a spare moment to point me in the right direction, please ? > > You need a spec/spec.opts file with the following: > > --colour > > Is that in place? Also, what versions of everything are you using? > > > > > > Cheers! > > sinclair > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070809/11ac6c99/attachment.html From jonathan at parkerhill.com Thu Aug 9 23:58:26 2007 From: jonathan at parkerhill.com (Jonathan Linowes) Date: Thu, 9 Aug 2007 23:58:26 -0400 Subject: [rspec-users] rspec and active_scaffold Message-ID: <71BA1C74-FFA3-4CBD-85D7-06E3511BE577@parkerhill.com> Hi, Anyone here have a link or tips for a complete spec for a dead simple active_scaffold controller, including its internal calls stubbed out which we could use as a starting point? thanks. linoj From ingo at ingoweiss.com Fri Aug 10 02:13:10 2007 From: ingo at ingoweiss.com (Ingo Weiss) Date: Fri, 10 Aug 2007 08:13:10 +0200 Subject: [rspec-users] fixture scenario builder In-Reply-To: <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <49f64a900708080856n774a3da5m7c146c7fea1cf3cc@mail.gmail.com> <49f64a900708081050q5d926152k8eaaba820d9abee5@mail.gmail.com> <57c63afe0708081130x286c71eap17055ae66f3020f2@mail.gmail.com> <49f64a900708081138k6eff867dyf87199ca73df9591@mail.gmail.com> <57c63afe0708081141w4a309bd5kfae806dd4bd74d06@mail.gmail.com> <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> <57c63afe0708081553w73a5d5afme2d851a3179fe343@mail.gmail.com> <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> <57c63afe0708081935x21e68a7ey74335c0129149325@mail.gmail.com> <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> Message-ID: <06791B70-D34E-4421-832A-9B816540817D@ingoweiss.com> Hi all, did anybody get 'fixture scenario builder' (http://errtheblog.com/post/ 7708) to work with rspec? I am getting the following error: ..../plugins/fixture_scenarios_builder/lib/scenario_builder.rb:8:in `scenario': undefined method `scenario' for main (NoMethodError) Ingo From win at wincent.com Fri Aug 10 05:18:55 2007 From: win at wincent.com (Wincent Colaiuta) Date: Fri, 10 Aug 2007 11:18:55 +0200 Subject: [rspec-users] FixtureScenarios Message-ID: <98472412-6026-4A7F-9EC3-15204ED84FB8@wincent.com> This may have turned up in the RSS feeds of many of you already, but for those who haven't seen it yet, looks intersting: > The main problem with fixtures, for me, has always been how unfun > they are. They literally suck the fun out of anything they?re > around. You throw them in your test/ directory, then suddenly > testing is, like, work. But it?s not work, dammit. This is Ruby, > dammit. > Cheers, Wincent From dchelimsky at gmail.com Fri Aug 10 08:04:15 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 10 Aug 2007 07:04:15 -0500 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <49f64a900708091736x4b71f847je4dd001081b145e3@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <49f64a900708081146w6564983dhed18d215ef91d727@mail.gmail.com> <57c63afe0708081553w73a5d5afme2d851a3179fe343@mail.gmail.com> <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> <57c63afe0708081935x21e68a7ey74335c0129149325@mail.gmail.com> <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> <57c63afe0708091716u70a2f998j43fed817f6fe0f27@mail.gmail.com> <49f64a900708091721x4c7e0beeqf6febb40a7845192@mail.gmail.com> <57c63afe0708091731h37fc80a7qa5f1cff16bbd7549@mail.gmail.com> <49f64a900708091736x4b71f847je4dd001081b145e3@mail.gmail.com> Message-ID: <57c63afe0708100504o78effbfeu6aed0f2aee09af2f@mail.gmail.com> On 8/9/07, Lance Carlson wrote: > About these methods requiring arguments? I thought you were able to > reproduce the problems I was having and was also able to reproduce a > working application with no arguments. That is correct. > By default these methods should > not require arguments to be passed as it is unnecessary noise in the > code. I understand that, but that was news to me as of this thread. I spent a couple of hours banging my head against this and found the generated code I mentioned earlier in the thread. That's the only insight I have to offer at this point. > Perhaps we can continue this discussion on IRC? #rspec? I'll pop in at one point this morning but I really don't have much in the way of cycles to spend on this right now. I'm happy to help point you in the right direction, but it's not very high on my priority list. In the mean time, now that we know this is a bug, would you kindly report it in the tracker? http://rubyforge.org/tracker/?atid=3149&group_id=797&func=browse > What is your s/n? > > On 8/9/07, David Chelimsky wrote: > > On 8/9/07, Lance Carlson wrote: > > > Is it possible that rspec is not pulling the instance variables into > > > the method because this method is being defined before instance > > > variables in parameters are assigned to that method? I'm trying to > > > hone down where the problem is popping up exactly. Any insight? > > > > Not really more than what I said earlier in this thread. > > > > > On 8/9/07, David Chelimsky wrote: > > > > On 8/9/07, Lance Carlson wrote: > > > > > Were you able to come up with any solutions? > > > > > > > > Nope. Anyone else? > > > > > > > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > > Awesome! Thank you! :) > > > > > > > > > > > > Don't thank me yet. I've spent some time trying to track this down and > > > > > > I've found my way into some methods in routing.rb that are dynamically > > > > > > generated (and so you can't )(*&)(*& read them to debug them quite so > > > > > > easily) that call the methods (in your case) label_id_value and > > > > > > id_value (being the artist id). I have no idea yet where those two > > > > > > methods get generated. Once I do, then we can stub them. Unfortunately > > > > > > I can't really spend any more time on this right now (though I'd love > > > > > > to solve it). > > > > > > > > > > > > In the mean time, you'll just have to use the parameters if you want > > > > > > the specs to work with the same code with which your app works. > > > > > > > > > > > > > > > > > > > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > > > > I just visited the action in my browser and i don't get any errors. I > > > > > > > > > am also running on edge rails as the application relies on > > > > > > > > > ActiveResource. Can you show me the code you created? > > > > > > > > > > > > > > > > OK - I've created a small project and am able to reproduce the > > > > > > > > behaviour you're describing. I'll follow up when learn something. > > > > > > > > > > > > > > > > David > > > > > > > > _______________________________________________ > > > > > > > > rspec-users mailing list > > > > > > > > rspec-users at rubyforge.org > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > rspec-users mailing list > > > > > > > rspec-users at rubyforge.org > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > _______________________________________________ > > > > > > rspec-users mailing list > > > > > > rspec-users at rubyforge.org > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lancecarlson at gmail.com Fri Aug 10 09:52:09 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Fri, 10 Aug 2007 09:52:09 -0400 Subject: [rspec-users] FixtureScenarios In-Reply-To: <98472412-6026-4A7F-9EC3-15204ED84FB8@wincent.com> References: <98472412-6026-4A7F-9EC3-15204ED84FB8@wincent.com> Message-ID: <49f64a900708100652l7fcfc08n85aafbabfd57ae77@mail.gmail.com> Thusfar, my experience with stubbing and mocking has not been a walk in the park either. Hopefully this will change when rspec's mocking and stubbing matures some more. Fixtures have always been a source of anger for many railers because they slow down tests, rely on the database and are hard to maintain. On 8/10/07, Wincent Colaiuta wrote: > This may have turned up in the RSS feeds of many of you already, but > for those who haven't seen it yet, looks intersting: > > > > > The main problem with fixtures, for me, has always been how unfun > > they are. They literally suck the fun out of anything they're > > around. You throw them in your test/ directory, then suddenly > > testing is, like, work. But it's not work, dammit. This is Ruby, > > dammit. > > > > Cheers, > Wincent > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Fri Aug 10 10:01:07 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 10 Aug 2007 09:01:07 -0500 Subject: [rspec-users] FixtureScenarios In-Reply-To: <49f64a900708100652l7fcfc08n85aafbabfd57ae77@mail.gmail.com> References: <98472412-6026-4A7F-9EC3-15204ED84FB8@wincent.com> <49f64a900708100652l7fcfc08n85aafbabfd57ae77@mail.gmail.com> Message-ID: <57c63afe0708100701v4d37f169gc2c75cdfc750a8a5@mail.gmail.com> On 8/10/07, Lance Carlson wrote: > Thusfar, my experience with stubbing and mocking has not been a walk > in the park either. Hopefully this will change when rspec's mocking > and stubbing matures some more. Please elaborate. What new features are you expecting rspec's mocking framework to adopt? From lancecarlson at gmail.com Fri Aug 10 10:04:00 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Fri, 10 Aug 2007 10:04:00 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <57c63afe0708100504o78effbfeu6aed0f2aee09af2f@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <57c63afe0708081553w73a5d5afme2d851a3179fe343@mail.gmail.com> <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> <57c63afe0708081935x21e68a7ey74335c0129149325@mail.gmail.com> <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> <57c63afe0708091716u70a2f998j43fed817f6fe0f27@mail.gmail.com> <49f64a900708091721x4c7e0beeqf6febb40a7845192@mail.gmail.com> <57c63afe0708091731h37fc80a7qa5f1cff16bbd7549@mail.gmail.com> <49f64a900708091736x4b71f847je4dd001081b145e3@mail.gmail.com> <57c63afe0708100504o78effbfeu6aed0f2aee09af2f@mail.gmail.com> Message-ID: <49f64a900708100704pdf441een1cdf1dd8b49e007e@mail.gmail.com> Thanks for your patience trying to resolve this issue. I posted a bug report here: http://rubyforge.org/tracker/index.php?func=detail&aid=12963&group_id=797&atid=3149 On 8/10/07, David Chelimsky wrote: > On 8/9/07, Lance Carlson wrote: > > About these methods requiring arguments? I thought you were able to > > reproduce the problems I was having and was also able to reproduce a > > working application with no arguments. > > That is correct. > > > By default these methods should > > not require arguments to be passed as it is unnecessary noise in the > > code. > > I understand that, but that was news to me as of this thread. I spent > a couple of hours banging my head against this and found the generated > code I mentioned earlier in the thread. That's the only insight I have > to offer at this point. > > > Perhaps we can continue this discussion on IRC? #rspec? > > I'll pop in at one point this morning but I really don't have much in > the way of cycles to spend on this right now. I'm happy to help point > you in the right direction, but it's not very high on my priority > list. In the mean time, now that we know this is a bug, would you > kindly report it in the tracker? > > http://rubyforge.org/tracker/?atid=3149&group_id=797&func=browse > > > What is your s/n? > > > > On 8/9/07, David Chelimsky wrote: > > > On 8/9/07, Lance Carlson wrote: > > > > Is it possible that rspec is not pulling the instance variables into > > > > the method because this method is being defined before instance > > > > variables in parameters are assigned to that method? I'm trying to > > > > hone down where the problem is popping up exactly. Any insight? > > > > > > Not really more than what I said earlier in this thread. > > > > > > > On 8/9/07, David Chelimsky wrote: > > > > > On 8/9/07, Lance Carlson wrote: > > > > > > Were you able to come up with any solutions? > > > > > > > > > > Nope. Anyone else? > > > > > > > > > > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > > > Awesome! Thank you! :) > > > > > > > > > > > > > > Don't thank me yet. I've spent some time trying to track this down and > > > > > > > I've found my way into some methods in routing.rb that are dynamically > > > > > > > generated (and so you can't )(*&)(*& read them to debug them quite so > > > > > > > easily) that call the methods (in your case) label_id_value and > > > > > > > id_value (being the artist id). I have no idea yet where those two > > > > > > > methods get generated. Once I do, then we can stub them. Unfortunately > > > > > > > I can't really spend any more time on this right now (though I'd love > > > > > > > to solve it). > > > > > > > > > > > > > > In the mean time, you'll just have to use the parameters if you want > > > > > > > the specs to work with the same code with which your app works. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > > > > > I just visited the action in my browser and i don't get any errors. I > > > > > > > > > > am also running on edge rails as the application relies on > > > > > > > > > > ActiveResource. Can you show me the code you created? > > > > > > > > > > > > > > > > > > OK - I've created a small project and am able to reproduce the > > > > > > > > > behaviour you're describing. I'll follow up when learn something. > > > > > > > > > > > > > > > > > > David > > > > > > > > > _______________________________________________ > > > > > > > > > rspec-users mailing list > > > > > > > > > rspec-users at rubyforge.org > > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > rspec-users mailing list > > > > > > > > rspec-users at rubyforge.org > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > rspec-users mailing list > > > > > > > rspec-users at rubyforge.org > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > _______________________________________________ > > > > > > rspec-users mailing list > > > > > > rspec-users at rubyforge.org > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Fri Aug 10 10:05:48 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 10 Aug 2007 09:05:48 -0500 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <49f64a900708100704pdf441een1cdf1dd8b49e007e@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> <57c63afe0708081935x21e68a7ey74335c0129149325@mail.gmail.com> <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> <57c63afe0708091716u70a2f998j43fed817f6fe0f27@mail.gmail.com> <49f64a900708091721x4c7e0beeqf6febb40a7845192@mail.gmail.com> <57c63afe0708091731h37fc80a7qa5f1cff16bbd7549@mail.gmail.com> <49f64a900708091736x4b71f847je4dd001081b145e3@mail.gmail.com> <57c63afe0708100504o78effbfeu6aed0f2aee09af2f@mail.gmail.com> <49f64a900708100704pdf441een1cdf1dd8b49e007e@mail.gmail.com> Message-ID: <57c63afe0708100705s2cf1d71bue50d3916f37fad93@mail.gmail.com> On 8/10/07, Lance Carlson wrote: > Thanks for your patience trying to resolve this issue. I posted a bug > report here: > > http://rubyforge.org/tracker/index.php?func=detail&aid=12963&group_id=797&atid=3149 I see it - thanks. If you have time now, Lance, pls join the #rspec IRC chat. > > On 8/10/07, David Chelimsky wrote: > > On 8/9/07, Lance Carlson wrote: > > > About these methods requiring arguments? I thought you were able to > > > reproduce the problems I was having and was also able to reproduce a > > > working application with no arguments. > > > > That is correct. > > > > > By default these methods should > > > not require arguments to be passed as it is unnecessary noise in the > > > code. > > > > I understand that, but that was news to me as of this thread. I spent > > a couple of hours banging my head against this and found the generated > > code I mentioned earlier in the thread. That's the only insight I have > > to offer at this point. > > > > > Perhaps we can continue this discussion on IRC? #rspec? > > > > I'll pop in at one point this morning but I really don't have much in > > the way of cycles to spend on this right now. I'm happy to help point > > you in the right direction, but it's not very high on my priority > > list. In the mean time, now that we know this is a bug, would you > > kindly report it in the tracker? > > > > http://rubyforge.org/tracker/?atid=3149&group_id=797&func=browse > > > > > What is your s/n? > > > > > > On 8/9/07, David Chelimsky wrote: > > > > On 8/9/07, Lance Carlson wrote: > > > > > Is it possible that rspec is not pulling the instance variables into > > > > > the method because this method is being defined before instance > > > > > variables in parameters are assigned to that method? I'm trying to > > > > > hone down where the problem is popping up exactly. Any insight? > > > > > > > > Not really more than what I said earlier in this thread. > > > > > > > > > On 8/9/07, David Chelimsky wrote: > > > > > > On 8/9/07, Lance Carlson wrote: > > > > > > > Were you able to come up with any solutions? > > > > > > > > > > > > Nope. Anyone else? > > > > > > > > > > > > > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > > > > Awesome! Thank you! :) > > > > > > > > > > > > > > > > Don't thank me yet. I've spent some time trying to track this down and > > > > > > > > I've found my way into some methods in routing.rb that are dynamically > > > > > > > > generated (and so you can't )(*&)(*& read them to debug them quite so > > > > > > > > easily) that call the methods (in your case) label_id_value and > > > > > > > > id_value (being the artist id). I have no idea yet where those two > > > > > > > > methods get generated. Once I do, then we can stub them. Unfortunately > > > > > > > > I can't really spend any more time on this right now (though I'd love > > > > > > > > to solve it). > > > > > > > > > > > > > > > > In the mean time, you'll just have to use the parameters if you want > > > > > > > > the specs to work with the same code with which your app works. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 8/8/07, David Chelimsky wrote: > > > > > > > > > > On 8/8/07, Lance Carlson wrote: > > > > > > > > > > > I just visited the action in my browser and i don't get any errors. I > > > > > > > > > > > am also running on edge rails as the application relies on > > > > > > > > > > > ActiveResource. Can you show me the code you created? > > > > > > > > > > > > > > > > > > > > OK - I've created a small project and am able to reproduce the > > > > > > > > > > behaviour you're describing. I'll follow up when learn something. > > > > > > > > > > > > > > > > > > > > David > > > > > > > > > > _______________________________________________ > > > > > > > > > > rspec-users mailing list > > > > > > > > > > rspec-users at rubyforge.org > > > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > rspec-users mailing list > > > > > > > > > rspec-users at rubyforge.org > > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > rspec-users mailing list > > > > > > > > rspec-users at rubyforge.org > > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > rspec-users mailing list > > > > > > > rspec-users at rubyforge.org > > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > > > _______________________________________________ > > > > > > rspec-users mailing list > > > > > > rspec-users at rubyforge.org > > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > > _______________________________________________ > > > > > rspec-users mailing list > > > > > rspec-users at rubyforge.org > > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > _______________________________________________ > > > > rspec-users mailing list > > > > rspec-users at rubyforge.org > > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From steve.tooke at gmail.com Fri Aug 10 10:29:47 2007 From: steve.tooke at gmail.com (Steve Tooke) Date: Fri, 10 Aug 2007 15:29:47 +0100 Subject: [rspec-users] ActiveRecordAssociationMatcher Message-ID: <78d462040708100729r6f4c3f2bm8179e82a7554da4a@mail.gmail.com> I've started to put together a custom expectation matcher for specifying AR associations. Its not quite complete and I really need to put some specs together for it, but I'd appreciate any comments. It lets you spec your associations like this: describe Record do include ActiveRecordAssociationMatchers it "should belong to artist and use a counter cache" do Record.should belong_to(:artist).with_options(:counter_cache => true) end it "should have_many tracks" do Record.should have_many(:tracks).with_class_name("Song).and_options(:include => :writers) end end Please see my blog entry or the pastie for more details. http://stevetooke.karmatrading.co.uk/2007/8/10/simple-rails-association-matching-with-rspec http://pastie.caboo.se/86604 From mailing_lists at railsnewbie.com Fri Aug 10 15:22:58 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Fri, 10 Aug 2007 15:22:58 -0400 Subject: [rspec-users] FixtureScenarios In-Reply-To: <57c63afe0708100701v4d37f169gc2c75cdfc750a8a5@mail.gmail.com> References: <98472412-6026-4A7F-9EC3-15204ED84FB8@wincent.com> <49f64a900708100652l7fcfc08n85aafbabfd57ae77@mail.gmail.com> <57c63afe0708100701v4d37f169gc2c75cdfc750a8a5@mail.gmail.com> Message-ID: On Aug 10, 2007, at 10:01 AM, David Chelimsky wrote: > On 8/10/07, Lance Carlson wrote: >> Thusfar, my experience with stubbing and mocking has not been a walk >> in the park either. Hopefully this will change when rspec's mocking >> and stubbing matures some more. > > Please elaborate. What new features are you expecting rspec's mocking > framework to adopt? I would really like to see better support for anonymous functions + and what they execute. I've posted several emails now about spec'ing anonymous functions and have gotten no replies. I think the fixture problem has been the mutability of data while doing TDD/BDD. When you change a field name, do you end up changing 6 fixture records field names? What about if you change the data that a model should have? This is the real advantage to generating the fixture data in ruby - it allows more rapid BDD. Scott From dchelimsky at gmail.com Fri Aug 10 15:43:54 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 10 Aug 2007 14:43:54 -0500 Subject: [rspec-users] and_yield + instance_eval(&block) In-Reply-To: <46C54C9D-1BF3-436A-93A7-466B6B3BD51D@railsnewbie.com> References: <46C54C9D-1BF3-436A-93A7-466B6B3BD51D@railsnewbie.com> Message-ID: <57c63afe0708101243x23ab5bfr8af83d87d151c089@mail.gmail.com> On 8/7/07, Scott Taylor wrote: > > I have the following code, which yields instance eval's the block given: > > class Foo > > def bar(&blk) > instance_eval &blk > end > > def baz > yield > end > > end > > The effect of this is that self is reassigned: > > Foo.new.bar do > # here, self is the instance of Foo > # created by new > end Why not just do this, which is already a language construct? Foo.new.instance_eval { ... } > > But normally self is the object in which > Foo.new.bar {...} occurs. > > Foo.new.baz do > > # self is the execution context > # in which Foo.new was called, > # since a block is a closure > > end > > > The second case is easy; it is covered by and_yield (with no arguments). > > Is there some way to spec the first case? Do I smell the need for a > patch? > > Scott > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Fri Aug 10 15:45:25 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 10 Aug 2007 14:45:25 -0500 Subject: [rspec-users] and_yield + instance_eval(&block) In-Reply-To: <46C54C9D-1BF3-436A-93A7-466B6B3BD51D@railsnewbie.com> References: <46C54C9D-1BF3-436A-93A7-466B6B3BD51D@railsnewbie.com> Message-ID: <57c63afe0708101245h1421103eq3a8b73d7283a665f@mail.gmail.com> On 8/7/07, Scott Taylor wrote: > > I have the following code, which yields instance eval's the block given: > > class Foo > > def bar(&blk) > instance_eval &blk > end > > def baz > yield > end > > end > > The effect of this is that self is reassigned: > > Foo.new.bar do > # here, self is the instance of Foo > # created by new > end > > But normally self is the object in which > Foo.new.bar {...} occurs. > > Foo.new.baz do > > # self is the execution context > # in which Foo.new was called, > # since a block is a closure > > end > > > The second case is easy; it is covered by and_yield (with no arguments). > > Is there some way to spec the first case? Do I smell the need for a > patch? I'm not sure what you're trying to accomplish here - what would this spec look like? > > Scott > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From eivindu at ifi.uio.no Fri Aug 10 16:04:41 2007 From: eivindu at ifi.uio.no (Eivind Uggedal) Date: Fri, 10 Aug 2007 22:04:41 +0200 Subject: [rspec-users] Can't seem to spec a ActiveRecord::RecordInvalid exception properly... In-Reply-To: <57c63afe0708081510n53f725edu9aac14b9457a403a@mail.gmail.com> References: <7e565b5c0708081408q474ac9e9m729143cc86ddaab7@mail.gmail.com> <57c63afe0708081510n53f725edu9aac14b9457a403a@mail.gmail.com> Message-ID: <824b51d00708101304i15fcaa64y5881587c26126740@mail.gmail.com> I asked exactly this question on this list 2 days ago... See http://pastie.caboo.se/85887 for a working example. One has to mock out ActiveRecord::Errors::full_messages for it to work under Rails. Cheers, Eivind Uggedal On 8/9/07, David Chelimsky wrote: > On 8/8/07, Fischer, Daniel wrote: > > 1 def create > > 2 @user = User.new(params[:user]) > > 3 @user.save! > > 4 self.current_user = @user > > 5 redirect_to user_path(@user) > > 6 flash[:notice] = "Thanks for signing up!" > > 7 rescue ActiveRecord::RecordInvalid > > 8 render :action => 'new' > > 9 end > > Try this: > > describe "/users/create" do > before(:each) do > User.stub!(:new).and_return(@user = mock_model(User)) > end > > it "should redirect to show on successful save" do > @user.should_receive(:save!) > post :create > response.should redirect_to(user_path(@user)) > end > > it "should re-render new on failed save" do > @user.should_receive(:save!).and_raise(ActiveRecord::RecordInvalid.new(@user)) > post :create > response.should render_template('new') > end > end > > Cheers, > David > > > > > I can't seem to properly spec this out. I am trying numerous things, the > > latest one is this, which makes sense but it still fails... > > > > > > it "should re-render new on an invalid record exception" do > > post :create, :user => {:login => nil} > > response.should render_template(:new) > > end > > > > should re-render new on an invalid record exception > > expected "new", got nil > > > > Any help would be great, thanks! > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From tils-rspec at tils.net Fri Aug 10 11:15:49 2007 From: tils-rspec at tils.net (Tilmann Singer) Date: Fri, 10 Aug 2007 17:15:49 +0200 Subject: [rspec-users] Transactional fixtures not working as expected In-Reply-To: <46BA0038.10807@content-space.de> References: <46BA0038.10807@content-space.de> Message-ID: <20070810151549.GH6662@tils.net> * Michael Hamann [20070808 19:46]: > I am quite new to BDD and I just wrote my first tests. Suddenly I > received unexpected results because in a model test I load only > users-fixtures but when the views-fixtures in which I load the > posts-fixtures, are run before this model-test, the posts-fixtures are > loaded too. I test for example if there is one record in the posts-table > after creating one post. But when there are fixtures loaded, this does > not work of course. A similar issue was discussed here already in > October 2006, but there was no real result: > http://rubyforge.org/pipermail/rspec-users/2006-October/000088.html A fixture declaration in a context only guarantees that the explicitely declared fixtures are loaded and correspond to their fixture data in the .yml file - it does not guarantee that the non-declared fixtures are not loaded, nor does the absence of a fixture declaration guarantee that no fixtures are loaded. If a specific context depends on empty tables that may contain fixture data from previous runs the only way I can think of to guarantee that state is to add something like this in the context: before(:each) do Post.delete_all end This is certainly not ideal, but maybe a necessary workaround for you as long as fixtures work the way they do now. greetings, Til From mailing_lists at railsnewbie.com Fri Aug 10 16:31:18 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Fri, 10 Aug 2007 16:31:18 -0400 Subject: [rspec-users] and_yield + instance_eval(&block) In-Reply-To: <57c63afe0708101243x23ab5bfr8af83d87d151c089@mail.gmail.com> References: <46C54C9D-1BF3-436A-93A7-466B6B3BD51D@railsnewbie.com> <57c63afe0708101243x23ab5bfr8af83d87d151c089@mail.gmail.com> Message-ID: <27C7A435-E6EA-46B1-BE63-BE12F315DAF2@railsnewbie.com> On Aug 10, 2007, at 3:43 PM, David Chelimsky wrote: > On 8/7/07, Scott Taylor wrote: >> >> I have the following code, which yields instance eval's the block >> given: >> >> class Foo >> >> def bar(&blk) >> instance_eval &blk >> end >> >> def baz >> yield >> end >> >> end >> >> The effect of this is that self is reassigned: >> >> Foo.new.bar do >> # here, self is the instance of Foo >> # created by new >> end > > Why not just do this, which is already a language construct? > > Foo.new.instance_eval { ... } Maybe a better example would be in place. Consider the following from the Autotest plugin: Autotest.add_discovery do "rspec" if File.exist?('spec') end How would you go about testing this? It's easy enough to test that Autotest receives the method add_discovery. But how would you deal with the block? Scott From dchelimsky at gmail.com Fri Aug 10 16:36:15 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 10 Aug 2007 15:36:15 -0500 Subject: [rspec-users] and_yield + instance_eval(&block) In-Reply-To: <27C7A435-E6EA-46B1-BE63-BE12F315DAF2@railsnewbie.com> References: <46C54C9D-1BF3-436A-93A7-466B6B3BD51D@railsnewbie.com> <57c63afe0708101243x23ab5bfr8af83d87d151c089@mail.gmail.com> <27C7A435-E6EA-46B1-BE63-BE12F315DAF2@railsnewbie.com> Message-ID: <57c63afe0708101336r42ddc85dtc6154bc52cbe68b9@mail.gmail.com> On 8/10/07, Scott Taylor wrote: > > On Aug 10, 2007, at 3:43 PM, David Chelimsky wrote: > > > On 8/7/07, Scott Taylor wrote: > >> > >> I have the following code, which yields instance eval's the block > >> given: > >> > >> class Foo > >> > >> def bar(&blk) > >> instance_eval &blk > >> end > >> > >> def baz > >> yield > >> end > >> > >> end > >> > >> The effect of this is that self is reassigned: > >> > >> Foo.new.bar do > >> # here, self is the instance of Foo > >> # created by new > >> end > > > > Why not just do this, which is already a language construct? > > > > Foo.new.instance_eval { ... } > > Maybe a better example would be in place. Consider the following > from the Autotest plugin: > > Autotest.add_discovery do > "rspec" if File.exist?('spec') > end > > How would you go about testing this? > > It's easy enough to test that Autotest receives the method > add_discovery. But how would you deal with the block? OK - now I'm starting to see. Concrete examples are always helpful. I guess there's no mocking framework right now that would solve that for you. What spec do you *wish* you could write? From barjunk at attglobal.net Fri Aug 10 18:33:18 2007 From: barjunk at attglobal.net (barsalou) Date: Fri, 10 Aug 2007 14:33:18 -0800 Subject: [rspec-users] (no subject) Message-ID: <20070810143318.r4tlbzho0o4ss0c0@lcgalaska.com> Scott said: >> I'd like to output my rcov data to the screen in ascii instead of >> html...is that possible using the rake spec:rcov command? > Look at the RSpec gem's rdoc. I believe it is something like > Rake::RcovTask. An option can be provided to give rcov options. Run > rcov --help. This told me I needed the -T option to get what I wanted. Just to give a little more detail, I had to modify this file: vendor/plugins/rspec_on_rails/tasks/rspec.rake and in this section of code: desc "Run all specs in spec directory with RCov (excluding plugin specs)" Spec::Rake::SpecTask.new(:rcov) do |t| t.spec_opts = ['--options', "\"#{RAILS_ROOT}/spec/spec.opts\""] t.spec_files = FileList['spec/**/*_spec.rb'] t.rcov = true t.rcov_opts = ['--exclude', 'spec', '--rails'] end Change this: t.rcov_opts = ['--exclude', 'spec', '--rails'] to this: t.rcov_opts = ['--exclude', 'spec', '--rails', '-T'] Any way to do this by passing a command line arg? like: rake spec:rcov -T <- This DOESN'T work. If it bugs me enough, maybe I'll submit a patch that allows an rcov.opts file like the spec.opts file. :) > > Also, is there somewhere that will allow me to search the mail > archives...I'm pretty sure someone else has asked similar questions. > > Google is your friend. Rubyforge also has the mailing lists, > although they aren't searchable. Google is such a great resource...with abundant responses! Sometimes this hinders my progress. :) Thanks for the hints. > Scott Mike B. ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program. From barjunk at attglobal.net Fri Aug 10 18:35:49 2007 From: barjunk at attglobal.net (barsalou) Date: Fri, 10 Aug 2007 14:35:49 -0800 Subject: [rspec-users] Using rcov and ouput to screen Message-ID: <20070810143549.puoh3jebdw00kk84@lcgalaska.com> Sorry I left off the subject by accident...hopefully this will connect to the thread. Mike B. ----- Forwarded message from barjunk at attglobal.net ----- Date: Fri, 10 Aug 2007 14:33:18 -0800 From: barsalou Reply-To: barsalou To: rspec-users at rubyforge.org Scott said: >> I'd like to output my rcov data to the screen in ascii instead of >> html...is that possible using the rake spec:rcov command? > Look at the RSpec gem's rdoc. I believe it is something like > Rake::RcovTask. An option can be provided to give rcov options. Run > rcov --help. This told me I needed the -T option to get what I wanted. Just to give a little more detail, I had to modify this file: vendor/plugins/rspec_on_rails/tasks/rspec.rake and in this section of code: desc "Run all specs in spec directory with RCov (excluding plugin specs)" Spec::Rake::SpecTask.new(:rcov) do |t| t.spec_opts = ['--options', "\"#{RAILS_ROOT}/spec/spec.opts\""] t.spec_files = FileList['spec/**/*_spec.rb'] t.rcov = true t.rcov_opts = ['--exclude', 'spec', '--rails'] end Change this: t.rcov_opts = ['--exclude', 'spec', '--rails'] to this: t.rcov_opts = ['--exclude', 'spec', '--rails', '-T'] Any way to do this by passing a command line arg? like: rake spec:rcov -T <- This DOESN'T work. If it bugs me enough, maybe I'll submit a patch that allows an rcov.opts file like the spec.opts file. :) > > Also, is there somewhere that will allow me to search the mail > archives...I'm pretty sure someone else has asked similar questions. > > Google is your friend. Rubyforge also has the mailing lists, > although they aren't searchable. Google is such a great resource...with abundant responses! Sometimes this hinders my progress. :) Thanks for the hints. > Scott Mike B. ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program. ----- End forwarded message ----- ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program. From nemo7467 at gmail.com Fri Aug 10 19:18:34 2007 From: nemo7467 at gmail.com (David Parker) Date: Fri, 10 Aug 2007 18:18:34 -0500 Subject: [rspec-users] How to spec a model method Message-ID: <9a07e4a80708101618k6fd3ed54l8b8cc5eb216f8ce0@mail.gmail.com> Still new to Specs... How do I create a spec to test a model method? Specifically, here is my spec: #testing model describe User do it "should have many user roles" do User.reflect_on_association(:user_roles).should_not be_nil end it "should have many roles though user roles" do User.reflect_on_association(:roles).should_not be_nil end it "should know what role it has" do #User.should end end The last spec is incomplete... basically, I will want the code to be something like this: class User < ActiveRecord::Base has_many :user_roles has_many :roles, :through => :user_roles def has_role?(role) self.roles.count(:conditions => ['name = ?', role]) > 0 end end How would I spec the last method? Thanks -- dp -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070810/f4587f0e/attachment.html From dchelimsky at gmail.com Fri Aug 10 19:32:37 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 10 Aug 2007 18:32:37 -0500 Subject: [rspec-users] How to spec a model method In-Reply-To: <9a07e4a80708101618k6fd3ed54l8b8cc5eb216f8ce0@mail.gmail.com> References: <9a07e4a80708101618k6fd3ed54l8b8cc5eb216f8ce0@mail.gmail.com> Message-ID: <57c63afe0708101632n5452e3fj15a90b893b8af700@mail.gmail.com> On 8/10/07, David Parker wrote: > Still new to Specs... > How do I create a spec to test a model method? Specifically, here is my > spec: > #testing model > describe User do > it "should have many user roles" do > User.reflect_on_association (:user_roles).should_not be_nil > end > > it "should have many roles though user roles" do > User.reflect_on_association(:roles).should_not be_nil > end > > it "should know what role it has" do > #User.should > end > end > > The last spec is incomplete... basically, I will want the code to be > something like this: > class User < ActiveRecord::Base > has_many :user_roles > has_many :roles, :through => :user_roles > > def has_role?(role) > self.roles.count(:conditions => ['name = ?', role] ) > 0 > end > end > > How would I spec the last method? If you change has_role? to in_role?, you can say this: role = Role.create(:name => 'foo') user.roles.add(role) user.should be_in_role('foo') > Thanks > -- > dp > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From sbellware at hotmail.com Fri Aug 10 19:56:30 2007 From: sbellware at hotmail.com (sbellware) Date: Fri, 10 Aug 2007 16:56:30 -0700 (PDT) Subject: [rspec-users] Can't get should redirect_to match to work Message-ID: <12101072.post@talk.nabble.com> Folks, I've posted to the simple example I'm working with as well as the spec code and results here: http://pastie.caboo.se/86750 I can't seem to get this to work. Any ideas? Thanks, Scott -- View this message in context: http://www.nabble.com/Can%27t-get-should-redirect_to-match-to-work-tf4251891.html#a12101072 Sent from the rspec-users mailing list archive at Nabble.com. From dchelimsky at gmail.com Fri Aug 10 23:51:52 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 10 Aug 2007 22:51:52 -0500 Subject: [rspec-users] Can't get should redirect_to match to work In-Reply-To: <12101072.post@talk.nabble.com> References: <12101072.post@talk.nabble.com> Message-ID: <57c63afe0708102051v3494d7abjf352f0b56af3b5e5@mail.gmail.com> On 8/10/07, sbellware wrote: > > Folks, > > I've posted to the simple example I'm working with as well as the spec code > and results here: > http://pastie.caboo.se/86750 > > I can't seem to get this to work. Any ideas? As of some time ago, response.should redirect_to should come after the action. So: it "get foo" do get 'foo' response.should redirect_to(:action => 'bar') end > > Thanks, > Scott > -- > View this message in context: http://www.nabble.com/Can%27t-get-should-redirect_to-match-to-work-tf4251891.html#a12101072 > Sent from the rspec-users mailing list archive at Nabble.com. > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From jonathan at parkerhill.com Sat Aug 11 06:11:19 2007 From: jonathan at parkerhill.com (Jonathan Linowes) Date: Sat, 11 Aug 2007 06:11:19 -0400 Subject: [rspec-users] template.expect_render In-Reply-To: <57c63afe0706262231o31ffe07bv36d51b1fde376e15@mail.gmail.com> References: <57c63afe0706262231o31ffe07bv36d51b1fde376e15@mail.gmail.com> Message-ID: <3F0A0AF4-E210-45E2-B95E-207E282831EC@parkerhill.com> Hi, I'd like to stub out a partial call but not sure how. I tried something like this it "should render partial foo" do template.stub_render("bar/foo") render "/layouts/bar.html.erb" response.should render("bar/foo") end but the partial is still getting called On Jun 27, 2007, at 1:31 AM, David Chelimsky wrote: > Trunksters, > > I just added a couple of methods to ActionView::Base in Spec::Rails > (as of r2136) that lets you do this in view examples: > > describe '/things/index.html.erb' do > it "should render _thing with a collection of things" do > assigns[:things] = things = [Object.new] > template.expect_render(:partial => 'thing', :collection => things) > render '/things/index.html.erb' > end > end > > This solves two big problems - mocking nested partials and mocking > :object and :collection in partials. > > template.expect_render wraps part of 'spec/mocks', but not the whole > framework - so we get the expectation matching benefit w/o conflicting > with other mock frameworks that ppl might choose to use. > > There is also template.stub_render(opts) in case you just want to stub > the render w/o verification. > > I would LOVE it if some of you would try this method out and provide > feedback before we release it. Please feel to ask any questions about > this on this list. > > Thanks, > David > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From jonathan at parkerhill.com Sat Aug 11 08:00:01 2007 From: jonathan at parkerhill.com (Jonathan Linowes) Date: Sat, 11 Aug 2007 08:00:01 -0400 Subject: [rspec-users] template.expect_render In-Reply-To: <3F0A0AF4-E210-45E2-B95E-207E282831EC@parkerhill.com> References: <57c63afe0706262231o31ffe07bv36d51b1fde376e15@mail.gmail.com> <3F0A0AF4-E210-45E2-B95E-207E282831EC@parkerhill.com> Message-ID: <171B08D8-1DA8-413D-9A86-452D5E8E6DE0@parkerhill.com> oops, my bad this works (asserts pass, and partial not called) template.expect_render(:partial => 'bar/foo') render "/layouts/bar.html.erb" so does this: template.stub_render(:partial => 'bar/foo') render "/layouts/bar.html.erb" neither case seems to try to render the partial On Aug 11, 2007, at 6:11 AM, Jonathan Linowes wrote: > > Hi, I'd like to stub out a partial call but not sure how. > > I tried something like this > > it "should render partial foo" do > template.stub_render("bar/foo") > render "/layouts/bar.html.erb" > response.should render("bar/foo") > end > > but the partial is still getting called > > > On Jun 27, 2007, at 1:31 AM, David Chelimsky wrote: > >> Trunksters, >> >> I just added a couple of methods to ActionView::Base in Spec::Rails >> (as of r2136) that lets you do this in view examples: >> >> describe '/things/index.html.erb' do >> it "should render _thing with a collection of things" do >> assigns[:things] = things = [Object.new] >> template.expect_render(:partial => 'thing', :collection => >> things) >> render '/things/index.html.erb' >> end >> end >> >> This solves two big problems - mocking nested partials and mocking >> :object and :collection in partials. >> >> template.expect_render wraps part of 'spec/mocks', but not the whole >> framework - so we get the expectation matching benefit w/o >> conflicting >> with other mock frameworks that ppl might choose to use. >> >> There is also template.stub_render(opts) in case you just want to >> stub >> the render w/o verification. >> >> I would LOVE it if some of you would try this method out and provide >> feedback before we release it. Please feel to ask any questions about >> this on this list. >> >> Thanks, >> David >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From jonathan at parkerhill.com Sat Aug 11 08:52:36 2007 From: jonathan at parkerhill.com (Jonathan Linowes) Date: Sat, 11 Aug 2007 08:52:36 -0400 Subject: [rspec-users] nested layouts Message-ID: hi, I'm using a helper like in nested-layouts plugin as follows def inside_layout(layout, &block) layout = layout.include?('/') ? layout : "layouts/#{layout}" @template.instance_variable_set('@content_for_layout', capture (&block)) concat( @template.render( :file => layout, :user_full_path => true ), block.binding ) end used like this: views/layouts/bar.html.erb: <% inside_layout 'foo' do -%> ...stuff... <% end %> This basically works in my view spec although it brings in all the nested (outer) layouts Can you suggest a way to isolate the bar.html.erb template? thanks From dchelimsky at gmail.com Sat Aug 11 09:00:35 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Sat, 11 Aug 2007 08:00:35 -0500 Subject: [rspec-users] template.expect_render In-Reply-To: <171B08D8-1DA8-413D-9A86-452D5E8E6DE0@parkerhill.com> References: <57c63afe0706262231o31ffe07bv36d51b1fde376e15@mail.gmail.com> <3F0A0AF4-E210-45E2-B95E-207E282831EC@parkerhill.com> <171B08D8-1DA8-413D-9A86-452D5E8E6DE0@parkerhill.com> Message-ID: <57c63afe0708110600o6d22e5f5p4d93d654ceac1d97@mail.gmail.com> On 8/11/07, Jonathan Linowes wrote: > oops, my bad > > this works (asserts pass, and partial not called) > > template.expect_render(:partial => 'bar/foo') > render "/layouts/bar.html.erb" > > so does this: > > template.stub_render(:partial => 'bar/foo') > render "/layouts/bar.html.erb" > > neither case seems to try to render the partial Right - the difference is that stub_render won't complain if the partial is not rendered, so if what you mean to do is specify that it should be rendered, then you should use expects_render. > > > > On Aug 11, 2007, at 6:11 AM, Jonathan Linowes wrote: > > > > > Hi, I'd like to stub out a partial call but not sure how. > > > > I tried something like this > > > > it "should render partial foo" do > > template.stub_render("bar/foo") > > render "/layouts/bar.html.erb" > > response.should render("bar/foo") > > end > > > > but the partial is still getting called > > > > > > On Jun 27, 2007, at 1:31 AM, David Chelimsky wrote: > > > >> Trunksters, > >> > >> I just added a couple of methods to ActionView::Base in Spec::Rails > >> (as of r2136) that lets you do this in view examples: > >> > >> describe '/things/index.html.erb' do > >> it "should render _thing with a collection of things" do > >> assigns[:things] = things = [Object.new] > >> template.expect_render(:partial => 'thing', :collection => > >> things) > >> render '/things/index.html.erb' > >> end > >> end > >> > >> This solves two big problems - mocking nested partials and mocking > >> :object and :collection in partials. > >> > >> template.expect_render wraps part of 'spec/mocks', but not the whole > >> framework - so we get the expectation matching benefit w/o > >> conflicting > >> with other mock frameworks that ppl might choose to use. > >> > >> There is also template.stub_render(opts) in case you just want to > >> stub > >> the render w/o verification. > >> > >> I would LOVE it if some of you would try this method out and provide > >> feedback before we release it. Please feel to ask any questions about > >> this on this list. > >> > >> Thanks, > >> David > >> _______________________________________________ > >> rspec-users mailing list > >> rspec-users at rubyforge.org > >> http://rubyforge.org/mailman/listinfo/rspec-users > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From franck.dagostini at gmail.com Sat Aug 11 12:34:42 2007 From: franck.dagostini at gmail.com (Franck D'agostini) Date: Sat, 11 Aug 2007 09:34:42 -0700 (PDT) Subject: [rspec-users] Rspec and acl_system2 plugin Message-ID: <12106932.post@talk.nabble.com> Hello, I'm trying to spec a Rails application using the couple restful_authentication/acl_system2 plugins. In my admin layout, I put the following code : <% restrict_to "admin" do -%>

/users Users management

<% end -%> Then in my spec file 'spec/views/layout/admin.rhtml_spec.rb' : describe "Layout Admin if admin user" do include UserMockViewHelper it "should display the admin tabs" do login_as :admin render 'layouts/admin' response.should have_tag("ul#admin-tabs") end end the UserMockViewHelper module handle the mocking of the current user : module UserMockViewHelper def login_as(user) @current_user = mock_model(User) @role = mock_model(Role) case user when :admin @role.stub!(:map).and_return(["admin", "cms"]) when :cms_admin @role.stub!(:map).and_return(["cms", "cms_admin"]) when :cms @role.stub!(:map).and_return(["cms"]) else @role.stub!(:map).and_return([]) end @current_user.stub!(:roles).and_return(@role) @current_user.stub!(:login).and_return(user) User.should_receive(:find_by_id).any_number_of_times.and_return(@current_user) request.session[:user] = @current_user @controller.template.should_receive(:current_user).and_return(@current_user) end end When I run 'ruby script/spec spec/views/layouts/admin.rhtml_spec.rb', I've got the following error message : ActionView::TemplateError in 'Layout Admin if admin user should display the admin tabs' undefined local variable or method `current_user' for # On line #28 of app/views/layouts/admin.rhtml 25:

/articles Publications

28: <% restrict_to "admin" do -%> 29:

/users Utilisateurs

#{RAILS_ROOT}/vendor/plugins/acl_system2/lib/caboose/access_control.rb:75:in `restrict_to' (eval):2:in `send' (eval):2:in `restrict_to' #{RAILS_ROOT}/app/views/layouts/admin.rhtml:28:in `_run_rhtml_47app47views47layouts47admin46rhtml' /usr/local/lib/ruby/gems/1.8/gems/actionpack-1.13.3/lib/action_view/base.rb:326:in `send' /usr/local/lib/ruby/gems/1.8/gems/actionpack-1.13.3/lib/action_view/base.rb:326:in `compile_and_render_template' /usr/local/lib/ruby/gems/1.8/gems/actionpack-1.13.3/lib/action_view/base.rb:301:in `render_template' /usr/local/lib/ruby/gems/1.8/gems/actionpack-1.13.3/lib/action_view/base.rb:260:in `render_file' In the acl_system2 plugin, we have the following code : # restrict_to "admin | moderator" do # link_to "foo" # end def restrict_to(logicstring, context = {}) return false if current_user.nil? result = '' if permit?(logicstring, context) result = yield if block_given? end result end I'm just starting with rspec and I believe I'm missing something ... Did someone run into this error before ? -- View this message in context: http://www.nabble.com/Rspec-and-acl_system2-plugin-tf4254003.html#a12106932 Sent from the rspec-users mailing list archive at Nabble.com. From aslak.hellesoy at gmail.com Sat Aug 11 13:01:32 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Sat, 11 Aug 2007 19:01:32 +0200 Subject: [rspec-users] Using rcov and ouput to screen In-Reply-To: <20070810143549.puoh3jebdw00kk84@lcgalaska.com> References: <20070810143549.puoh3jebdw00kk84@lcgalaska.com> Message-ID: <8d961d900708111001g5fe852fejb0c24925e88e79c0@mail.gmail.com> On 8/11/07, barsalou wrote: > > Sorry I left off the subject by accident...hopefully this will connect > to the thread. > > Mike B. > ----- Forwarded message from barjunk at attglobal.net ----- > Date: Fri, 10 Aug 2007 14:33:18 -0800 > From: barsalou > Reply-To: barsalou > To: rspec-users at rubyforge.org > > > Scott said: > > >> I'd like to output my rcov data to the screen in ascii instead of > >> html...is that possible using the rake spec:rcov command? > > > Look at the RSpec gem's rdoc. I believe it is something like > > Rake::RcovTask. An option can be provided to give rcov options. Run > > rcov --help. > > This told me I needed the -T option to get what I wanted. > > Just to give a little more detail, I had to modify this file: > > > vendor/plugins/rspec_on_rails/tasks/rspec.rake > > and in this section of code: > > desc "Run all specs in spec directory with RCov (excluding plugin specs)" > Spec::Rake::SpecTask.new(:rcov) do |t| > t.spec_opts = ['--options', "\"#{RAILS_ROOT}/spec/spec.opts\""] > t.spec_files = FileList['spec/**/*_spec.rb'] > t.rcov = true > t.rcov_opts = ['--exclude', 'spec', '--rails'] > end > > Change this: > > t.rcov_opts = ['--exclude', 'spec', '--rails'] > > to this: > > t.rcov_opts = ['--exclude', 'spec', '--rails', '-T'] > > > Any way to do this by passing a command line arg? like: > > rake spec:rcov -T <- This DOESN'T work. > >From Spec::Rake::SpecTask's RDoc (on trunk) A Rake task that runs a set of RSpec contexts. Example: Spec::Rake::SpecTask.new do |t| t.warning = true t.rcov = true end This will create a task that can be run with: rake spec If rake is invoked with a "SPEC=filename" command line option, then the list of spec files will be overridden to include only the filename specified on the command line. This provides an easy way to run just one spec. If rake is invoked with a "SPEC_OPTS=options" command line option, then the given options will override the value of the spec_opts attribute. If rake is invoked with a "RCOV_OPTS=options" command line option, then the given options will override the value of the rcov_opts attribute. Examples: rake spec # run specs normally rake spec SPEC=just_one_file.rb # run just one spec file. rake spec SPEC_OPTS="--diff" # enable diffing rake spec RCOV_OPTS="--aggregate myfile.txt" # see rcov --help for details Each attribute of this task may be a proc. This allows for lazy evaluation, which is sometimes handy if you want to defer the evaluation of an attribute value until the task is run (as opposed to when it is defined). > > > If it bugs me enough, maybe I'll submit a patch that allows an > rcov.opts file like the spec.opts file. :) > > > > > > Also, is there somewhere that will allow me to search the mail > > archives...I'm pretty sure someone else has asked similar questions. > > > > > Google is your friend. Rubyforge also has the mailing lists, > > although they aren't searchable. > > Google is such a great resource...with abundant responses! Sometimes > this hinders my progress. :) > > Thanks for the hints. > > > Scott > > > Mike B. > > ---------------------------------------------------------------- > This message was sent using IMP, the Internet Messaging Program. > > > > ----- End forwarded message ----- > > > ---------------------------------------------------------------- > This message was sent using IMP, the Internet Messaging Program. > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From court3nay at gmail.com Sat Aug 11 14:08:21 2007 From: court3nay at gmail.com (Courtenay) Date: Sat, 11 Aug 2007 11:08:21 -0700 Subject: [rspec-users] Rspec and acl_system2 plugin In-Reply-To: <12106932.post@talk.nabble.com> References: <12106932.post@talk.nabble.com> Message-ID: <4b430c8f0708111108l7eef6dd5l53e217b0101011e1@mail.gmail.com> On 8/11/07, Franck D'agostini wrote: > > I'm trying to spec a Rails application using the couple > restful_authentication/acl_system2 plugins. > > In my admin layout, I put the following code : > > <% restrict_to "admin" do -%> >

/users Users management

> <% end -%> > Remember, rSpec is Behavioural. The code behind "restrict_to" doesn't matter; it's the behaviour that matters. As such, your view-spec should only know about the code in that view. So for example, there's no mention of a "user" or "role" model there, only a "restrict_to" method. Spec out the "restrict_to" code, rather than setting up a complex chain of fragile model interactions. This means that you can change the whole ACL system, but as long as it conforms to the same interface, restrict_to("rolename"), your specs will suceed. You can also change the associations or the name of your models, or add some fancy caching, anything, and this particular spec won't die. > User.should_receive(:find_by_id).any_number_of_times.and_return(@current_user) > request.session[:user] = @current_user The fact that you're stubbing "find" calls in the *view* spec indicates that you're probably testing things that are out of the scope of that spec. The actual ACL system should be tested on its own, not in the context of a view. Courtenay From franck.dagostini at gmail.com Sat Aug 11 12:54:42 2007 From: franck.dagostini at gmail.com (Franck D'agostini) Date: Sat, 11 Aug 2007 09:54:42 -0700 (PDT) Subject: [rspec-users] Rspec and acl_system2 plugin In-Reply-To: <12106932.post@talk.nabble.com> References: <12106932.post@talk.nabble.com> Message-ID: <12107096.post@talk.nabble.com> Sorry, I've just seen that this question has already been raised in this mailing list. I should have double checked first. My bad :sleep: -- View this message in context: http://www.nabble.com/Rspec-and-acl_system2-plugin-tf4254003.html#a12107096 Sent from the rspec-users mailing list archive at Nabble.com. From rupert_apsc at rupespad.com Sun Aug 12 06:34:28 2007 From: rupert_apsc at rupespad.com (rupert) Date: Sun, 12 Aug 2007 11:34:28 +0100 Subject: [rspec-users] stubbing a method that yeilds sequential results Message-ID: <3F7BD489-E648-4A40-8E6C-0BA5B313691A@rupespad.com> I've just found myself stuck trying to rspec something so am hoping someone more knowledgable can help. I have a Connector class which has a class method 'results' that yields results it get from a network service based on a set of attributes that I pass to it. I am wanting to yield these results from my Intermediate class up to the next 'level' so the basic no frills set up would be this: class Intermediate def self.results(attributes) Connector.each_result(attributes) do |result| yield result end end end I've worked out how to stub things for the case where the Connector. each_result method yields a result once #setup @result = mock("result") Connector.stub!(:each_result).and_yield(@result) @attributes = {} @results = [] @block = Proc.new { |r| @results << r } #action Intermediate.search_results(@attributes, &@block) # expectation @results.should == [@search_result] However, what I actually need to do is check each result that is yielded by the Connector.each_result method and compare it to the previous one. If they are sufficiently similar I need to merge them (and same again if the next result is sufficiently similar). I only want to yeild merged results and results that are not similar to their preceeding result(s) - I'd imagined he code to do this would be something along the lines of: class Intermediate def self.results(attributes) @saved_result = nil Connector.each_result(attributes) do |result| if results_match(result, @saved_result) @saved_result.merge!(result) else yield @saved_result unless @saved_result.nil? @saved_result = result end end yield @saved_result unless @saved_result.nil? end def results_match(this, last) return false if last.nil? .... end end I can't for the life of me see how I should spec this though, as trying: Connector.stub!(:results).and_yield(@result1, @result2) is expecting the two results to be yielded at the same time and not sequentially. I can't see how to stub a method to yield sequential results so I can spec the behavior for different scenarios of similarities between subsequent results. Is it possible to do this? Any help would be much appreciated Cheers Rupert From dchelimsky at gmail.com Sun Aug 12 09:38:36 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Sun, 12 Aug 2007 09:38:36 -0400 Subject: [rspec-users] stubbing a method that yeilds sequential results In-Reply-To: <3F7BD489-E648-4A40-8E6C-0BA5B313691A@rupespad.com> References: <3F7BD489-E648-4A40-8E6C-0BA5B313691A@rupespad.com> Message-ID: <57c63afe0708120638j626da921y13d414cf2879fe9@mail.gmail.com> On 8/12/07, rupert wrote: > I've just found myself stuck trying to rspec something so am hoping > someone more knowledgable can help. > > I have a Connector class which has a class method 'results' that > yields results it get from a network service based on a set of > attributes that I pass to it. I am wanting to yield these results > from my Intermediate class up to the next 'level' so the basic no > frills set up would be this: > > class Intermediate > def self.results(attributes) > Connector.each_result(attributes) do |result| > yield result > end > end > end > > I've worked out how to stub things for the case where the Connector. > each_result method yields a result once > > #setup > @result = mock("result") > Connector.stub!(:each_result).and_yield(@result) > > @attributes = {} > @results = [] > @block = Proc.new { |r| @results << r } > > #action > Intermediate.search_results(@attributes, &@block) > > # expectation > @results.should == [@search_result] > > > However, what I actually need to do is check each result that is > yielded by the Connector.each_result method and compare it to the > previous one. If they are sufficiently similar I need to merge them > (and same again if the next result is sufficiently similar). I only > want to yeild merged results and results that are not similar to > their preceeding result(s) - I'd imagined he code to do this would be > something along the lines of: > > class Intermediate > def self.results(attributes) > @saved_result = nil > > Connector.each_result(attributes) do |result| > if results_match(result, @saved_result) > @saved_result.merge!(result) > else > yield @saved_result unless @saved_result.nil? > @saved_result = result > end > end > yield @saved_result unless @saved_result.nil? > end > > def results_match(this, last) > return false if last.nil? > .... > end > end > > I can't for the life of me see how I should spec this though, as trying: > > Connector.stub!(:results).and_yield(@result1, @result2) > > is expecting the two results to be yielded at the same time and not > sequentially. I'm pretty sure you can get what you want by using should_receive instead of stub and doing this: Connector.should_receive(:results).and_yield(@result1) Connector.should_receive(:results).and_yield(@result2) > I can't see how to stub a method to yield sequential > results so I can spec the behavior for different scenarios of > similarities between subsequent results. Is it possible to do this? > > Any help would be much appreciated > > Cheers > > Rupert > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From rupert_apsc at rupespad.com Sun Aug 12 10:23:42 2007 From: rupert_apsc at rupespad.com (rupert) Date: Sun, 12 Aug 2007 15:23:42 +0100 Subject: [rspec-users] stubbing a method that yeilds sequential results In-Reply-To: <57c63afe0708120638j626da921y13d414cf2879fe9@mail.gmail.com> References: <3F7BD489-E648-4A40-8E6C-0BA5B313691A@rupespad.com> <57c63afe0708120638j626da921y13d414cf2879fe9@mail.gmail.com> Message-ID: <5ECC2B3D-BC8B-4EBE-8136-A65F6ABD8388@rupespad.com> On 12 Aug 2007, at 14:38, David Chelimsky wrote: > On 8/12/07, rupert wrote: >> I've just found myself stuck trying to rspec something so am hoping >> someone more knowledgable can help. >> >> I have a Connector class which has a class method 'results' that >> yields results it get from a network service based on a set of >> attributes that I pass to it. I am wanting to yield these results >> from my Intermediate class up to the next 'level' so the basic no >> frills set up would be this: >> >> class Intermediate >> def self.results(attributes) >> Connector.each_result(attributes) do |result| >> yield result >> end >> end >> end >> >> I've worked out how to stub things for the case where the Connector. >> each_result method yields a result once >> >> #setup >> @result = mock("result") >> Connector.stub!(:each_result).and_yield(@result) >> >> @attributes = {} >> @results = [] >> @block = Proc.new { |r| @results << r } >> >> #action >> Intermediate.search_results(@attributes, &@block) >> >> # expectation >> @results.should == [@search_result] >> >> >> However, what I actually need to do is check each result that is >> yielded by the Connector.each_result method and compare it to the >> previous one. If they are sufficiently similar I need to merge them >> (and same again if the next result is sufficiently similar). I only >> want to yeild merged results and results that are not similar to >> their preceeding result(s) - I'd imagined he code to do this would be >> something along the lines of: >> >> class Intermediate >> def self.results(attributes) >> @saved_result = nil >> >> Connector.each_result(attributes) do |result| >> if results_match(result, @saved_result) >> @saved_result.merge!(result) >> else >> yield @saved_result unless @saved_result.nil? >> @saved_result = result >> end >> end >> yield @saved_result unless @saved_result.nil? >> end >> >> def results_match(this, last) >> return false if last.nil? >> .... >> end >> end >> >> I can't for the life of me see how I should spec this though, as >> trying: >> >> Connector.stub!(:results).and_yield(@result1, @result2) >> >> is expecting the two results to be yielded at the same time and not >> sequentially. > > I'm pretty sure you can get what you want by using should_receive > instead of stub and doing this: > > Connector.should_receive(:results).and_yield(@result1) > Connector.should_receive(:results).and_yield(@result2) Thanks for getting back so quickly - on a Sunday too!! Unfortunately this doesn't seem to work - it's failing the second Conector.should_receive spec. This seems to be because the Connector is only receiving the results (sorry for the confusion - it should be each_result) method call once. So what's happening is that @result1 is being yielded then the second should_receive fails as the method isn't called a 2nd time. So what I need to be able to say is: Connector.should_receive(:each_result).once.and_yield(@result1 followed_by @result2 followed_by @result3) so one call to a method can yield a set of results in turn. Hope this makes sense (and it's not just that I'm missing the obvious or doing something stupid!) Cheers Rupert From dchelimsky at gmail.com Sun Aug 12 11:03:41 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Sun, 12 Aug 2007 11:03:41 -0400 Subject: [rspec-users] 1.0.6 gotcha Message-ID: <57c63afe0708120803w46fa1761ibf28b6ca3b2d3c2c@mail.gmail.com> Hi All - I released 1.0.6 this morning, but there is apparently a bug related to rspec and autotest. I'll be fixing this today (but not until tonight) so you have two options: Wait until 1.0.7 (tonight) Upgrade now to 1.0.6 but make sure you install the rspec gem. Thanks, David From port001 at gmail.com Sun Aug 12 12:07:23 2007 From: port001 at gmail.com (Ian Leitch) Date: Sun, 12 Aug 2007 17:07:23 +0100 Subject: [rspec-users] 1.0.6 gotcha In-Reply-To: <57c63afe0708120803w46fa1761ibf28b6ca3b2d3c2c@mail.gmail.com> References: <57c63afe0708120803w46fa1761ibf28b6ca3b2d3c2c@mail.gmail.com> Message-ID: Cheers David, I've been waiting patiently for this release :) I think I might wait for a rainy day until I upgrade though (I'm not using autotest btw).. 1469 examples, 62 failures It's good to see you (and the rest of the team) give credit where credit is due. I was half expecting the contributors list to stay the same with this release. I'm glad to see that it didn't, I only wish more projects accepted contributions so graciously. Cheers Ian On 12/08/07, David Chelimsky wrote: > > Hi All - I released 1.0.6 this morning, but there is apparently a bug > related to rspec and autotest. I'll be fixing this today (but not > until tonight) so you have two options: > > Wait until 1.0.7 (tonight) > > Upgrade now to 1.0.6 but make sure you install the rspec gem. > > Thanks, > David > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070812/c12e7cc7/attachment.html From nemo7467 at gmail.com Sun Aug 12 16:53:24 2007 From: nemo7467 at gmail.com (David Parker) Date: Sun, 12 Aug 2007 15:53:24 -0500 Subject: [rspec-users] Scope and specing models Message-ID: <9a07e4a80708121353v6a9de792k2d72cb4d2642f02b@mail.gmail.com> Hello all, I'm currently having an issue with some specs, specifically scope issues (probably more of a scope issue than a spec issue at this point)... Here's the error: ActiveRecord::AssociationTypeMismatch in 'A new User should know what role it has' Role expected, got NilClass D:/ruby/projects/restful_authentication_test/config/../app/models/role.rb:5:in `add' ./spec/models/user_spec.rb:62: script/spec:4: Here's the user.rb http://pastie.caboo.se/87029 role.rb http://pastie.caboo.se/87030 user_spec.rb http://pastie.caboo.se/87032 The code is based off of RESTful authentication + Ben Curtis' user roles in Rails Application: http://www.bencurtis.com/archives/2007/06/user-roles-in-rails-applications/ Thanks for your help! -- dp -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070812/38430919/attachment.html From lists-rspec at shopwatch.org Sun Aug 12 18:26:29 2007 From: lists-rspec at shopwatch.org (Jay Levitt) Date: Sun, 12 Aug 2007 18:26:29 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <57c63afe0708100705s2cf1d71bue50d3916f37fad93@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <49f64a900708081556s1454a8aey3feb2d937092083e@mail.gmail.com> <57c63afe0708081935x21e68a7ey74335c0129149325@mail.gmail.com> <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> <57c63afe0708091716u70a2f998j43fed817f6fe0f27@mail.gmail.com> <49f64a900708091721x4c7e0beeqf6febb40a7845192@mail.gmail.com> <57c63afe0708091731h37fc80a7qa5f1cff16bbd7549@mail.gmail.com> <49f64a900708091736x4b71f847je4dd001081b145e3@mail.gmail.com> <57c63afe0708100504o78effbfeu6aed0f2aee09af2f@mail.gmail.com> <49f64a900708100704pdf441een1cdf1dd8b49e007e@mail.gmail.com> <57c63afe0708100705s2cf1d71bue50d3916f37fad93@mail.gmail.com> Message-ID: <46BF8915.5040109@jay.fm> David Chelimsky wrote: > On 8/10/07, Lance Carlson wrote: >> Thanks for your patience trying to resolve this issue. I posted a bug >> report here: >> >> http://rubyforge.org/tracker/index.php?func=detail&aid=12963&group_id=797&atid=3149 > > I see it - thanks. If you have time now, Lance, pls join the #rspec IRC chat. How did this chat go, if it went? I'm about to dive into this problem but don't want to duplicate efforts. Jay From lancecarlson at gmail.com Sun Aug 12 18:33:47 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Sun, 12 Aug 2007 18:33:47 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <46BF8915.5040109@jay.fm> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> <57c63afe0708091716u70a2f998j43fed817f6fe0f27@mail.gmail.com> <49f64a900708091721x4c7e0beeqf6febb40a7845192@mail.gmail.com> <57c63afe0708091731h37fc80a7qa5f1cff16bbd7549@mail.gmail.com> <49f64a900708091736x4b71f847je4dd001081b145e3@mail.gmail.com> <57c63afe0708100504o78effbfeu6aed0f2aee09af2f@mail.gmail.com> <49f64a900708100704pdf441een1cdf1dd8b49e007e@mail.gmail.com> <57c63afe0708100705s2cf1d71bue50d3916f37fad93@mail.gmail.com> <46BF8915.5040109@jay.fm> Message-ID: <49f64a900708121533x630b6310je1b371eee99130e8@mail.gmail.com> It was never resolved.. the only resolution was to mock out the methods at this point or provide the views with the instance variables. On 8/12/07, Jay Levitt wrote: > David Chelimsky wrote: > > On 8/10/07, Lance Carlson wrote: > >> Thanks for your patience trying to resolve this issue. I posted a bug > >> report here: > >> > >> http://rubyforge.org/tracker/index.php?func=detail&aid=12963&group_id=797&atid=3149 > > > > I see it - thanks. If you have time now, Lance, pls join the #rspec IRC chat. > > How did this chat go, if it went? I'm about to dive into this problem > but don't want to duplicate efforts. > > Jay > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From davidjrice at gmail.com Sun Aug 12 18:50:42 2007 From: davidjrice at gmail.com (David Rice) Date: Sun, 12 Aug 2007 23:50:42 +0100 Subject: [rspec-users] Test::Unit to RSpec Converter Message-ID: <85797B99-B2CD-4A33-A229-0ABEFAAFD89E@gmail.com> Hey, just posting in case this is of interest. I just recently wrote a Rails plugin to convert Rails Test::Unit cases to RSpec. http://www.davidjrice.co.uk/articles/2007/8/12/ruby-on-rails-plugin- test-unit-to-rspec-converter it's not going to work 100% in every case, but it's really helped me convert old tests to the lovely RSpec :) Best, Dave --- David Rice http://www.davidjrice.co.uk -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070812/b809a804/attachment-0001.html From lists-rspec at shopwatch.org Sun Aug 12 20:28:39 2007 From: lists-rspec at shopwatch.org (Jay Levitt) Date: Sun, 12 Aug 2007 20:28:39 -0400 Subject: [rspec-users] Problems with RESTfully generated helpers In-Reply-To: <49f64a900708121533x630b6310je1b371eee99130e8@mail.gmail.com> References: <49f64a900708080726s52d972ak9b488bdd0fff3ddd@mail.gmail.com> <49f64a900708091711m5d4c4b62s811b50e957bbe092@mail.gmail.com> <57c63afe0708091716u70a2f998j43fed817f6fe0f27@mail.gmail.com> <49f64a900708091721x4c7e0beeqf6febb40a7845192@mail.gmail.com> <57c63afe0708091731h37fc80a7qa5f1cff16bbd7549@mail.gmail.com> <49f64a900708091736x4b71f847je4dd001081b145e3@mail.gmail.com> <57c63afe0708100504o78effbfeu6aed0f2aee09af2f@mail.gmail.com> <49f64a900708100704pdf441een1cdf1dd8b49e007e@mail.gmail.com> <57c63afe0708100705s2cf1d71bue50d3916f37fad93@mail.gmail.com> <46BF8915.5040109@jay.fm> <49f64a900708121533x630b6310je1b371eee99130e8@mail.gmail.com> Message-ID: <46BFA5B7.30909@jay.fm> Lance Carlson wrote: > It was never resolved.. the only resolution was to mock out the > methods at this point or provide the views with the instance > variables. Well, I didn't get anywhere tonight - but I did discover that script/console has the same problem. Given routes.rb: map.resources :users, :member => {:edit_business_card => :get, :update_business_card => :put } and: >> app.update_business_card_user_url I get: ActionController::RoutingError: update_business_card_user_url failed to generate from {:controller=>"users", :action=>"update_business_card"} - you may have ambiguous routes, or you may need to supply additional parameters for this route. content_url has the following required parameters: ["users", :id, "update_business_card"] - are they all satisfied? Yet using update_business_card_user_url from a view works fine. Since I can duplicate it without rspec, I'll post a message to rubyonrails-talk and see if anyone has some ideas. Jay From dchelimsky at gmail.com Mon Aug 13 01:39:05 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 13 Aug 2007 01:39:05 -0400 Subject: [rspec-users] Scope and specing models In-Reply-To: <9a07e4a80708121353v6a9de792k2d72cb4d2642f02b@mail.gmail.com> References: <9a07e4a80708121353v6a9de792k2d72cb4d2642f02b@mail.gmail.com> Message-ID: <57c63afe0708122239x56fe61fay766331e24e5b56f7@mail.gmail.com> On 8/12/07, David Parker wrote: > Hello all, I'm currently having an issue with some specs, specifically scope > issues (probably more of a scope issue than a spec issue at this point)... > Here's the error: > ActiveRecord::AssociationTypeMismatch in 'A new User should > know what role it has' > Role expected, got NilClass > D:/ruby/projects/restful_authentication_test/config/../app/models/role.rb:5:in > `add' > ./spec/models/user_spec.rb:62: > script/spec:4: > > Here's the user.rb > http://pastie.caboo.se/87029 > > role.rb > http://pastie.caboo.se/87030 > > user_spec.rb > http://pastie.caboo.se/87032 > > The code is based off of RESTful authentication + > Ben Curtis' user roles in Rails Application: > http://www.bencurtis.com/archives/2007/06/user-roles-in-rails-applications/ users.roles is an AssociationProxy, not the Role class, where you have defined the method add(user, role). You should be able to eliminate that method in the Role class and just pass the role on line 62 of your spec: users.roles.add(role) > > Thanks for your help! > -- > dp > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From flyeminent at hotmail.com Sun Aug 12 20:43:03 2007 From: flyeminent at hotmail.com (Shaker) Date: Sun, 12 Aug 2007 17:43:03 -0700 (PDT) Subject: [rspec-users] Problem of using fixture in Rspec Message-ID: <12119520.post@talk.nabble.com> Dear Fellows: I was using fixtures in the model tests using Rspec. I found that the test data specified in the fixtures was stored in the test database once I ran the spec and won't be removed anyway. Is my observation correct? There might be another problem regarding the fixtures. When I ran the specs one by one, it was working. However, it failed when I tried to run all the specs in one command. It seemed that the test data which was modified by one spec caused the other spec which accessed that particular data to fail. In other words, the data is actually kind of public to all specs, so the specs shares one copy of test data. If my observation is correct, are there any ways to overcome these problems? Is it possible that each single spec owns its test data so that the modifications on the data will not affect other specs? Cheers! -- View this message in context: http://www.nabble.com/Problem-of-using-fixture-in-Rspec-tf4258669.html#a12119520 Sent from the rspec-users mailing list archive at Nabble.com. From dchelimsky at gmail.com Mon Aug 13 01:58:42 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 13 Aug 2007 01:58:42 -0400 Subject: [rspec-users] [ANN] RSpec-1.0.8 Message-ID: <57c63afe0708122258r6ae4494cld9353dc135c00c94@mail.gmail.com> The RSpec Development Team is pleased to announce the release of RSpec-1.0.8. RSpec 1.0.6 is the "holy cow, batman, it's been a long time since we released and there are a ton of bug fixes, patches and even new features" release. RSpec 1.0.7 and 1.0.8 deal with a regression introduced in 1.0.6 and a hiccup in releasing 1.0.7, respectively. == RSpec RSpec is a Behaviour Driven Development framework which plays the same role that a unit testing framework would play in Test Driven Development, but does so using words and structures that better support BDD. http://rspec.rubyforge.org == rspec_on_rails rspec_on_rails is a Ruby on Rails plugin that supports a BDD approach to developing the various layers of objects within a Rails application. See http://rspec.rubyforge.org/documentation/rails/index.html == Installation http://rspec.rubyforge.org/download.html http://rspec.rubyforge.org/documentation/rails/install.html From flyeminent at hotmail.com Mon Aug 13 03:21:52 2007 From: flyeminent at hotmail.com (Shaker) Date: Mon, 13 Aug 2007 00:21:52 -0700 (PDT) Subject: [rspec-users] How to use expect_render? Message-ID: <12121894.post@talk.nabble.com> Hi: I am a rspec beginner. I have scratched my head for the whole afternoon, trying to figure out a way of writing render expectation in controller spec. However, I failed. It kept telling me that the 'expect_render' was an undefined method. I have installed rspec 1.0.8 and rspec_on_rails as well. Below is the controller to be tested. Controller def index pre = Array.new render :partial=>'index', :layout=>false, :locals=>{:pre=>pre} end My controller spec before do @controller = MyController.new end it "should render the index partial" do @controller.expect_render(:partial=>'index', :layout=>false) #I don't know how to expect the :locals end As I mentioned, the spec failed , saying that "Undefined method 'expect_render' ". There might be some mistakes in my "before" block. Do I need to mock the controller or something else? Anyway, do any one know how to fix the problem? It will be even better if you guys could show me a piece of example code. Thanks!! -- View this message in context: http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12121894 Sent from the rspec-users mailing list archive at Nabble.com. From aslak.hellesoy at gmail.com Mon Aug 13 03:51:05 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Mon, 13 Aug 2007 09:51:05 +0200 Subject: [rspec-users] Test::Unit to RSpec Converter In-Reply-To: <85797B99-B2CD-4A33-A229-0ABEFAAFD89E@gmail.com> References: <85797B99-B2CD-4A33-A229-0ABEFAAFD89E@gmail.com> Message-ID: <8d961d900708130051l2acf88e8x46794cb3c2cc0ff8@mail.gmail.com> On 8/13/07, David Rice wrote: > Hey, just posting in case this is of interest. > > I just recently wrote a Rails plugin to convert Rails Test::Unit cases to > RSpec. > > http://www.davidjrice.co.uk/articles/2007/8/12/ruby-on-rails-plugin-test-unit-to-rspec-converter > > it's not going to work 100% in every case, but it's really helped me convert > old tests to the lovely RSpec :) > Thanks David, We used to have one of those too. The first one was similar to yours, then I wrote one based on ParseTree and Ruby2Ruby which did the transformation on the syntax tree level. We ditched it because it was too much work to maintain (it's still part of older releases - around 0.7 IIRC). In many cases, simple is better :-) Aslak > Best, > Dave > > > --- > David Rice > http://www.davidjrice.co.uk > > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From aslak.hellesoy at gmail.com Mon Aug 13 04:01:12 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Mon, 13 Aug 2007 10:01:12 +0200 Subject: [rspec-users] How to use expect_render? In-Reply-To: <12121894.post@talk.nabble.com> References: <12121894.post@talk.nabble.com> Message-ID: <8d961d900708130101h4a4bceeelb2e26e61bbd65639@mail.gmail.com> On 8/13/07, Shaker wrote: > > Hi: > I am a rspec beginner. I have scratched my head for the whole afternoon, > trying to figure out a way of writing render expectation in controller spec. > However, I failed. It kept telling me that the 'expect_render' was an > undefined method. I have installed rspec 1.0.8 and rspec_on_rails as well. > Below is the controller to be tested. > > Controller > def index > pre = Array.new > render :partial=>'index', :layout=>false, :locals=>{:pre=>pre} > end > > My controller spec > before do > @controller = MyController.new > end > it "should render the index partial" do > @controller.expect_render(:partial=>'index', :layout=>false) #I don't > know how to expect the :locals > end > > As I mentioned, the spec failed , saying that "Undefined method > 'expect_render' ". There might be some mistakes in my "before" block. Do I > need to mock the controller or something else? Anyway, do any one know how > to fix the problem? It will be even better if you guys could show me a piece > of example code. > Thanks!! Have you looked here? http://rspec.rubyforge.org/documentation/rails/writing/views.html (you must use template.expect_render) Or perhaps you're looking for response.should render_template("path/to/template/for/action") HTH, Aslak > -- > View this message in context: http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12121894 > Sent from the rspec-users mailing list archive at Nabble.com. > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From aslak.hellesoy at gmail.com Mon Aug 13 04:07:00 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Mon, 13 Aug 2007 10:07:00 +0200 Subject: [rspec-users] Problem of using fixture in Rspec In-Reply-To: <12119520.post@talk.nabble.com> References: <12119520.post@talk.nabble.com> Message-ID: <8d961d900708130107k130d91d1pd22ecd841719464f@mail.gmail.com> On 8/13/07, Shaker wrote: > > Dear Fellows: > I was using fixtures in the model tests using Rspec. I found that the > test data specified in the fixtures was stored in the test database once I > ran the spec and won't be removed anyway. Is my observation correct? Yes, this is how Rails does it. > There might be another problem regarding the fixtures. When I ran the > specs one by one, it was working. However, it failed when I tried to run all > the specs in one command. It seemed that the test data which was modified by > one spec caused the other spec which accessed that particular data to fail. > In other words, the data is actually kind of public to all specs, so the > specs shares one copy of test data. > If my observation is correct, are there any ways to overcome these > problems? Is it possible that each single spec owns its test data so that > the modifications on the data will not affect other specs? My hunch is that you'll get the same behaviour with Test::Unit (try it). You probably need to tell your spec that it must use more fixture tables, to clean up before each example (it block). Aslak > Cheers! > -- > View this message in context: http://www.nabble.com/Problem-of-using-fixture-in-Rspec-tf4258669.html#a12119520 > Sent from the rspec-users mailing list archive at Nabble.com. > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From flyeminent at hotmail.com Mon Aug 13 04:15:46 2007 From: flyeminent at hotmail.com (Shaker) Date: Mon, 13 Aug 2007 01:15:46 -0700 (PDT) Subject: [rspec-users] How to use expect_render? In-Reply-To: <8d961d900708130101h4a4bceeelb2e26e61bbd65639@mail.gmail.com> References: <12121894.post@talk.nabble.com> <8d961d900708130101h4a4bceeelb2e26e61bbd65639@mail.gmail.com> Message-ID: <12122511.post@talk.nabble.com> Hello, Aslak: I know we could do template.expect_render somehow, although I haven't tried that out. But the rspec developer said that we could now actually use controller.expect_render in controller specs, which caused me confused. You may want to have a look at this: http://rspec.rubyforge.org/documentation/rails/writing/controllers.html writing controller spec Thanks, regards. aslak hellesoy wrote: > > On 8/13/07, Shaker wrote: >> >> Hi: >> I am a rspec beginner. I have scratched my head for the whole >> afternoon, >> trying to figure out a way of writing render expectation in controller >> spec. >> However, I failed. It kept telling me that the 'expect_render' was an >> undefined method. I have installed rspec 1.0.8 and rspec_on_rails as >> well. >> Below is the controller to be tested. >> >> Controller >> def index >> pre = Array.new >> render :partial=>'index', :layout=>false, :locals=>{:pre=>pre} >> end >> >> My controller spec >> before do >> @controller = MyController.new >> end >> it "should render the index partial" do >> @controller.expect_render(:partial=>'index', :layout=>false) #I >> don't >> know how to expect the :locals >> end >> >> As I mentioned, the spec failed , saying that "Undefined method >> 'expect_render' ". There might be some mistakes in my "before" block. Do >> I >> need to mock the controller or something else? Anyway, do any one know >> how >> to fix the problem? It will be even better if you guys could show me a >> piece >> of example code. >> Thanks!! > > Have you looked here? > > http://rspec.rubyforge.org/documentation/rails/writing/views.html > > (you must use template.expect_render) > Or perhaps you're looking for response.should > render_template("path/to/template/for/action") > > HTH, > Aslak > >> -- >> View this message in context: >> http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12121894 >> Sent from the rspec-users mailing list archive at Nabble.com. >> >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users >> > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > > -- View this message in context: http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12122511 Sent from the rspec-users mailing list archive at Nabble.com. From dchelimsky at gmail.com Mon Aug 13 04:41:47 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 13 Aug 2007 04:41:47 -0400 Subject: [rspec-users] How to use expect_render? In-Reply-To: <12122511.post@talk.nabble.com> References: <12121894.post@talk.nabble.com> <8d961d900708130101h4a4bceeelb2e26e61bbd65639@mail.gmail.com> <12122511.post@talk.nabble.com> Message-ID: <57c63afe0708130141g6d906ab0kd0699d48668abb0c@mail.gmail.com> On 8/13/07, Shaker wrote: > > Hello, Aslak: > I know we could do template.expect_render somehow, although I haven't > tried that out. But the rspec developer Aslak is one of the rspec developers. :) > said that we could now actually use > controller.expect_render in controller specs, which caused me confused. You > may want to have a look at this: > http://rspec.rubyforge.org/documentation/rails/writing/controllers.html > writing controller spec > Thanks, regards. > > aslak hellesoy wrote: > > > > On 8/13/07, Shaker wrote: > >> > >> Hi: > >> I am a rspec beginner. I have scratched my head for the whole > >> afternoon, > >> trying to figure out a way of writing render expectation in controller > >> spec. > >> However, I failed. It kept telling me that the 'expect_render' was an > >> undefined method. I have installed rspec 1.0.8 and rspec_on_rails as > >> well. > >> Below is the controller to be tested. > >> > >> Controller > >> def index > >> pre = Array.new > >> render :partial=>'index', :layout=>false, :locals=>{:pre=>pre} > >> end > >> > >> My controller spec > >> before do > >> @controller = MyController.new > >> end > >> it "should render the index partial" do > >> @controller.expect_render(:partial=>'index', :layout=>false) #I > >> don't > >> know how to expect the :locals > >> end Don't create an instance of the controller directly. Use either: describe MyController do ... or describe "MyController" do controller_name :my ... RSpec mixes some methods into the controller in these cases (including expect_render) but does not in the case you describe because it initializes the controller directly. Cheers, David > >> > >> As I mentioned, the spec failed , saying that "Undefined method > >> 'expect_render' ". There might be some mistakes in my "before" block. Do > >> I > >> need to mock the controller or something else? Anyway, do any one know > >> how > >> to fix the problem? It will be even better if you guys could show me a > >> piece > >> of example code. > >> Thanks!! > > > > Have you looked here? > > > > http://rspec.rubyforge.org/documentation/rails/writing/views.html > > > > (you must use template.expect_render) > > Or perhaps you're looking for response.should > > render_template("path/to/template/for/action") > > > > HTH, > > Aslak > > > >> -- > >> View this message in context: > >> http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12121894 > >> Sent from the rspec-users mailing list archive at Nabble.com. > >> > >> _______________________________________________ > >> rspec-users mailing list > >> rspec-users at rubyforge.org > >> http://rubyforge.org/mailman/listinfo/rspec-users > >> > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > -- > View this message in context: http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12122511 > Sent from the rspec-users mailing list archive at Nabble.com. > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From aslak.hellesoy at gmail.com Mon Aug 13 04:48:51 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Mon, 13 Aug 2007 10:48:51 +0200 Subject: [rspec-users] How to use expect_render? In-Reply-To: <57c63afe0708130141g6d906ab0kd0699d48668abb0c@mail.gmail.com> References: <12121894.post@talk.nabble.com> <8d961d900708130101h4a4bceeelb2e26e61bbd65639@mail.gmail.com> <12122511.post@talk.nabble.com> <57c63afe0708130141g6d906ab0kd0699d48668abb0c@mail.gmail.com> Message-ID: <8d961d900708130148w69d6d2d8nf1ed2d417615535a@mail.gmail.com> On 8/13/07, David Chelimsky wrote: > On 8/13/07, Shaker wrote: > > > > Hello, Aslak: > > I know we could do template.expect_render somehow, although I haven't > > tried that out. But the rspec developer > > Aslak is one of the rspec developers. :) > > > said that we could now actually use > > controller.expect_render in controller specs, which caused me confused. You > > may want to have a look at this: > > http://rspec.rubyforge.org/documentation/rails/writing/controllers.html > > writing controller spec > > Thanks, regards. > > > > aslak hellesoy wrote: > > > > > > On 8/13/07, Shaker wrote: > > >> > > >> Hi: > > >> I am a rspec beginner. I have scratched my head for the whole > > >> afternoon, > > >> trying to figure out a way of writing render expectation in controller > > >> spec. > > >> However, I failed. It kept telling me that the 'expect_render' was an > > >> undefined method. I have installed rspec 1.0.8 and rspec_on_rails as > > >> well. > > >> Below is the controller to be tested. > > >> > > >> Controller > > >> def index > > >> pre = Array.new > > >> render :partial=>'index', :layout=>false, :locals=>{:pre=>pre} > > >> end > > >> > > >> My controller spec > > >> before do > > >> @controller = MyController.new > > >> end > > >> it "should render the index partial" do > > >> @controller.expect_render(:partial=>'index', :layout=>false) #I > > >> don't > > >> know how to expect the :locals > > >> end > > Don't create an instance of the controller directly. Use either: > > describe MyController do > ... > > or > > describe "MyController" do > controller_name :my > ... > Doh, I missed that. > RSpec mixes some methods into the controller in these cases (including > expect_render) but does not in the case you describe because it > initializes the controller directly. > I wonder if this is a common mistake among newcomers to RSpec (since Rails/Test::Unit does it that way). I don't think we should build in any warning mechanisms, but I'll update the page mentioning this. Aslak > Cheers, > David > > > > >> > > >> As I mentioned, the spec failed , saying that "Undefined method > > >> 'expect_render' ". There might be some mistakes in my "before" block. Do > > >> I > > >> need to mock the controller or something else? Anyway, do any one know > > >> how > > >> to fix the problem? It will be even better if you guys could show me a > > >> piece > > >> of example code. > > >> Thanks!! > > > > > > Have you looked here? > > > > > > http://rspec.rubyforge.org/documentation/rails/writing/views.html > > > > > > (you must use template.expect_render) > > > Or perhaps you're looking for response.should > > > render_template("path/to/template/for/action") > > > > > > HTH, > > > Aslak > > > > > >> -- > > >> View this message in context: > > >> http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12121894 > > >> Sent from the rspec-users mailing list archive at Nabble.com. > > >> > > >> _______________________________________________ > > >> rspec-users mailing list > > >> rspec-users at rubyforge.org > > >> http://rubyforge.org/mailman/listinfo/rspec-users > > >> > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > > > > -- > > View this message in context: http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12122511 > > Sent from the rspec-users mailing list archive at Nabble.com. > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From flyeminent at hotmail.com Mon Aug 13 05:21:01 2007 From: flyeminent at hotmail.com (Shaker) Date: Mon, 13 Aug 2007 02:21:01 -0700 (PDT) Subject: [rspec-users] How to use expect_render? In-Reply-To: <12121894.post@talk.nabble.com> References: <12121894.post@talk.nabble.com> Message-ID: <12123224.post@talk.nabble.com> Dear Aslak and David: I have tried two possible ways to get expect_render work. However, they all failed. My combinations are: my controller spec describe MyController do before do #do nothing end it "should render the index partial" do controller.expect_render(:partial=>'index') #1st way MyController.expect_render(:partial=>'index') #2nd way end end The 1st way gave me an error: Mock 'expect_render_mock_proxy' expected :render with ({:partial=>'index'}) once, but received it 0 times The 2nd way gave me an error: undefined method 'expect_render' Do I need to mock the controller or there are some mistakes I have made in my spec? Shaker wrote: > > Hi: > I am a rspec beginner. I have scratched my head for the whole > afternoon, trying to figure out a way of writing render expectation in > controller spec. However, I failed. It kept telling me that the > 'expect_render' was an undefined method. I have installed rspec 1.0.8 and > rspec_on_rails as well. Below is the controller to be tested. > > Controller > def index > pre = Array.new > render :partial=>'index', :layout=>false, :locals=>{:pre=>pre} > end > > My controller spec > before do > @controller = MyController.new > end > it "should render the index partial" do > @controller.expect_render(:partial=>'index', :layout=>false) #I > don't know how to expect the :locals > end > > As I mentioned, the spec failed , saying that "Undefined method > 'expect_render' ". There might be some mistakes in my "before" block. Do I > need to mock the controller or something else? Anyway, do any one know how > to fix the problem? It will be even better if you guys could show me a > piece of example code. > Thanks!! > -- View this message in context: http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12123224 Sent from the rspec-users mailing list archive at Nabble.com. From aslak.hellesoy at gmail.com Mon Aug 13 05:43:36 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Mon, 13 Aug 2007 11:43:36 +0200 Subject: [rspec-users] How to use expect_render? In-Reply-To: <12123224.post@talk.nabble.com> References: <12121894.post@talk.nabble.com> <12123224.post@talk.nabble.com> Message-ID: <8d961d900708130243w28985a2dmf7ae9ebda7397c92@mail.gmail.com> On 8/13/07, Shaker wrote: > > Dear Aslak and David: > I have tried two possible ways to get expect_render work. However, they > all failed. My combinations are: > my controller spec > describe MyController do > before do > #do nothing > end > it "should render the index partial" do > controller.expect_render(:partial=>'index') #1st way That's the way to go > MyController.expect_render(:partial=>'index') #2nd way > end > end > > The 1st way gave me an error: Mock 'expect_render_mock_proxy' expected > :render with ({:partial=>'index'}) once, but received it 0 times You've forgotten to run the action. RSpec doesn't magically guess what action is supposed to render your index partial. it "should render the index partial" do controller.expect_render(:partial=>'index') get 'index' end > The 2nd way gave me an error: undefined method 'expect_render' > Do I need to mock the controller or there are some mistakes I have made in > my spec? > > Shaker wrote: > > > > Hi: > > I am a rspec beginner. I have scratched my head for the whole > > afternoon, trying to figure out a way of writing render expectation in > > controller spec. However, I failed. It kept telling me that the > > 'expect_render' was an undefined method. I have installed rspec 1.0.8 and > > rspec_on_rails as well. Below is the controller to be tested. > > > > Controller > > def index > > pre = Array.new > > render :partial=>'index', :layout=>false, :locals=>{:pre=>pre} > > end > > > > My controller spec > > before do > > @controller = MyController.new > > end > > it "should render the index partial" do > > @controller.expect_render(:partial=>'index', :layout=>false) #I > > don't know how to expect the :locals > > end > > > > As I mentioned, the spec failed , saying that "Undefined method > > 'expect_render' ". There might be some mistakes in my "before" block. Do I > > need to mock the controller or something else? Anyway, do any one know how > > to fix the problem? It will be even better if you guys could show me a > > piece of example code. > > Thanks!! > > > > -- > View this message in context: http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12123224 > Sent from the rspec-users mailing list archive at Nabble.com. > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From nemo7467 at gmail.com Mon Aug 13 06:51:01 2007 From: nemo7467 at gmail.com (David Parker) Date: Mon, 13 Aug 2007 05:51:01 -0500 Subject: [rspec-users] Scope and specing models Message-ID: <9a07e4a80708130351la69792fjef4bc2dcdbd7e74a@mail.gmail.com> On 8/12/07, David Parker wrote: > Hello all, I'm currently having an issue with some specs, specifically scope > issues (probably more of a scope issue than a spec issue at this point)... > Here's the error: > ActiveRecord::AssociationTypeMismatch in 'A new User should > know what role it has' > Role expected, got NilClass > D:/ruby/projects/restful_authentication_test/config/../app/models/role.rb:5:in > `add' > ./spec/models/user_spec.rb:62: > script/spec:4: > > Here's the user.rb > http://pastie.caboo.se/87029 > > role.rb > http://pastie.caboo.se/87030 > > user_spec.rb > http://pastie.caboo.se/87032 > > The code is based off of RESTful authentication + > Ben Curtis' user roles in Rails Application: > http://www.bencurtis.com/archives/2007/06/user-roles -in-rails-applications/ > users.roles is an AssociationProxy, not the Role class, where you have defined the method add(user, role). You should be able to eliminate that method in the Role class and just pass the role on line 62 of your spec: users.roles.add(role) ____________ I went ahead an eliminated the add method in the role class, and now, with the same spec as above these are the results I get, depending on what I have for line 62... Users.roles.add(role): NameError in 'A new User should know what role it has' uninitialized constant Users User.roles.add(role): NoMethodError in 'A new User should know what role it has' undefined method `roles' for User:Class user.roles.add(role): NoMethodError in 'A new User should know what role it has' undefined method `add' for Role:Class users.roles.add(role): NameError in 'A new User should know what role it has' undefined local variable or method `users' If I go ahead and do something like: users = User.find(:all) before doing users.roles.add(role), then I get: NoMethodError in 'A new User should know what role it has' undefined method `roles' are my associations somehow not registering? > > Thanks for your help! > -- > dp > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -- dp -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070813/954f6dcb/attachment.html From aslak.hellesoy at gmail.com Mon Aug 13 07:20:13 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Mon, 13 Aug 2007 13:20:13 +0200 Subject: [rspec-users] Scope and specing models In-Reply-To: <9a07e4a80708130351la69792fjef4bc2dcdbd7e74a@mail.gmail.com> References: <9a07e4a80708130351la69792fjef4bc2dcdbd7e74a@mail.gmail.com> Message-ID: <8d961d900708130420o3b9738d5le4e9fbd04df30a05@mail.gmail.com> On 8/13/07, David Parker wrote: > On 8/12/07, David Parker wrote: > > Hello all, I'm currently having an issue with some specs, specifically > scope > > issues (probably more of a scope issue than a spec issue at this point)... > > Here's the error: > > ActiveRecord::AssociationTypeM > ismatch in 'A new User should > > know what role it has' > > Role expected, got NilClass > > > D:/ruby/projects/restful_authentication_test/config/../app/models/role.rb:5:in > > `add' > > ./spec/models/user_spec.rb:62: > > script/spec:4: > > > > Here's the user.rb > > http://pastie.caboo.se/87029 > > > > role.rb > > http://pastie.caboo.se/87030 > > > > user_spec.rb > > http://pastie.caboo.se/87032 > > > > The code is based off of RESTful authentication + > > Ben Curtis' user roles in Rails Application: > > > http://www.bencurtis.com/archives/2007/06/user-roles-in-rails-applications/ > > > users.roles is an AssociationProxy, not the Role class, where you have > defined the method add(user, role). You should be able to eliminate > that method in the Role class and just pass the role on line 62 of > your spec: > > users.roles.add(role) > ____________ > I went ahead an eliminated the add method in the role class, and now, with > the same spec as above these are the results I get, depending on what I have > for line 62... > It looks like all of your questions are Ruby or Rails specific, not RSpec specific. There are other more suitable forums for that. > Users.roles.add(role): > NameError in 'A new User should know what role it has' > uninitialized constant Users > This is Ruby telling you that there is no class named Users. > User.roles.add(role): > NoMethodError in 'A new User should know what role it has' > undefined method `roles' for User:Class > Only ActiveRecord instances (not classes) have associations. You can find out more by reading up on ActiveRecord associations. > user.roles.add(role): > NoMethodError in 'A new User should know what role it has' > undefined method `add' for Role:Class > I don't think Rails has_many associations have an #add method. Use #<< or #build or #create http://api.rubyonrails.com/classes/ActiveRecord/Associations/ClassMethods.html#M000642 > users.roles.add(role): > NameError in 'A new User should know what role it has' > undefined local variable or method `users' > This is Ruby telling you that you don't have a users variable (or method) in the current scope. > If I go ahead and do something like: > users = User.find(:all) > before doing users.roles.add(role), then I get: > NoMethodError in 'A new User should know what role it has' > undefined method `roles' > I think you're trying to add a role to *one* user, not all of them. A collection of User (which is what your users variable is) doesn't have a roles method, but each of the User *instances* in that collection do. Try this: user = User.find(:first) user.should_not have_role('master') user.add_role('master') user.should have_role('master') > are my associations somehow not registering? > No, they're registering fine, but I think you need to study Ruby and Rails/ActiveRecord more. You're not using ActiveRecord properly. HTH, Aslak > > > > Thanks for your help! > > -- > > dp > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > -- > > dp > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From jonathan at parkerhill.com Mon Aug 13 09:00:08 2007 From: jonathan at parkerhill.com (Jonathan Linowes) Date: Mon, 13 Aug 2007 09:00:08 -0400 Subject: [rspec-users] expect_render not? Message-ID: <8D3ADA32-F6F0-4BBC-BBAC-6C2C9E7B896B@parkerhill.com> hi, I have a template that conditionally renders a partial. Is there a way to test that a partial is NOT rendered? :) From dchelimsky at gmail.com Mon Aug 13 09:06:25 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 13 Aug 2007 09:06:25 -0400 Subject: [rspec-users] expect_render not? In-Reply-To: <8D3ADA32-F6F0-4BBC-BBAC-6C2C9E7B896B@parkerhill.com> References: <8D3ADA32-F6F0-4BBC-BBAC-6C2C9E7B896B@parkerhill.com> Message-ID: <57c63afe0708130606m71ef6d7al5eccc1aaadd615f6@mail.gmail.com> On 8/13/07, Jonathan Linowes wrote: > hi, I have a template that conditionally renders a partial. Is there > a way to test that a partial is NOT rendered? > :) template.should_render(:partial => '/partial/that/should/not/get/rendered').never > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lists-rspec at shopwatch.org Mon Aug 13 17:41:27 2007 From: lists-rspec at shopwatch.org (Jay Levitt) Date: Mon, 13 Aug 2007 17:41:27 -0400 Subject: [rspec-users] Backtrace tweaker - broken or me? Message-ID: <46C0D007.3090406@jay.fm> Using 1.0.8, I just realized that I've been scrolling through pages of backtraces when rspec is supposed to clean them up for me. This is a new development machine, so I'm not sure if older versions worked or not. I'm running Ruby 1.8.6, Rails edge, Mac OS X 10.4.10. I've verified that the QuietBacktraceTweaker is the one that's running. However, error.backtrace seems to have only one big element in it (with multiple lines separated by \n), that whole line gets ignored because it matches, and then the whole backtrace gets printed out anyway somehow. I'm heading home and don't have time to dig into it right now, but has anyone else seen this? Jay Levitt From flyeminent at hotmail.com Mon Aug 13 20:58:45 2007 From: flyeminent at hotmail.com (Shaker) Date: Mon, 13 Aug 2007 17:58:45 -0700 (PDT) Subject: [rspec-users] How to use expect_render? In-Reply-To: <8d961d900708130243w28985a2dmf7ae9ebda7397c92@mail.gmail.com> References: <12121894.post@talk.nabble.com> <12123224.post@talk.nabble.com> <8d961d900708130243w28985a2dmf7ae9ebda7397c92@mail.gmail.com> Message-ID: <12136984.post@talk.nabble.com> Dear Aslak: Sorry to bother you over and over again. I did follow your instruction to write the controller spec, but...the thing is not getting better.:-( I'd like to post my code again, hopefully you would figure it out. My Controller class MyController def index pre = Array.new render :partial=>'index', layout=>false, locals=>{:pre=>pre} end end ------------------------------------------------------------ My Controller spec describe MyController do it "should render the index partial" do controller.expect_render(:partial=>'index', :layout=>false) get 'index' end end ------------------------------------------------------------ By the way, I am using JRuby rather than ruby. Hence my command to run the spec above is jruby --command spec spec/controllers/my_controller_spec.rb --format specdoc It always gave me an error:Mock 'expect_render_mock_proxy' expected :render with ({:partial=>"index"}) once, but received it 0 times. Is it because "expect_render" is not compatible with JRuby or I forgot to mock something? Thanks a lot. Regards. aslak hellesoy wrote: > > On 8/13/07, Shaker wrote: >> >> Dear Aslak and David: >> I have tried two possible ways to get expect_render work. However, >> they >> all failed. My combinations are: >> my controller spec >> describe MyController do >> before do >> #do nothing >> end >> it "should render the index partial" do >> controller.expect_render(:partial=>'index') #1st way > > That's the way to go > >> MyController.expect_render(:partial=>'index') #2nd way >> end >> end >> >> The 1st way gave me an error: Mock 'expect_render_mock_proxy' expected >> :render with ({:partial=>'index'}) once, but received it 0 times > > You've forgotten to run the action. RSpec doesn't magically guess what > action is supposed to render your index partial. > > it "should render the index partial" do > controller.expect_render(:partial=>'index') > get 'index' > end > > >> The 2nd way gave me an error: undefined method 'expect_render' >> Do I need to mock the controller or there are some mistakes I have made >> in >> my spec? >> >> Shaker wrote: >> > >> > Hi: >> > I am a rspec beginner. I have scratched my head for the whole >> > afternoon, trying to figure out a way of writing render expectation in >> > controller spec. However, I failed. It kept telling me that the >> > 'expect_render' was an undefined method. I have installed rspec 1.0.8 >> and >> > rspec_on_rails as well. Below is the controller to be tested. >> > >> > Controller >> > def index >> > pre = Array.new >> > render :partial=>'index', :layout=>false, :locals=>{:pre=>pre} >> > end >> > >> > My controller spec >> > before do >> > @controller = MyController.new >> > end >> > it "should render the index partial" do >> > @controller.expect_render(:partial=>'index', :layout=>false) #I >> > don't know how to expect the :locals >> > end >> > >> > As I mentioned, the spec failed , saying that "Undefined method >> > 'expect_render' ". There might be some mistakes in my "before" block. >> Do I >> > need to mock the controller or something else? Anyway, do any one know >> how >> > to fix the problem? It will be even better if you guys could show me a >> > piece of example code. >> > Thanks!! >> > >> >> -- >> View this message in context: >> http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12123224 >> Sent from the rspec-users mailing list archive at Nabble.com. >> >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users >> > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > > -- View this message in context: http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12136984 Sent from the rspec-users mailing list archive at Nabble.com. From zach.dennis at gmail.com Tue Aug 14 00:45:08 2007 From: zach.dennis at gmail.com (Zach Dennis) Date: Tue, 14 Aug 2007 00:45:08 -0400 Subject: [rspec-users] How to use expect_render? In-Reply-To: <12136984.post@talk.nabble.com> References: <12121894.post@talk.nabble.com> <12123224.post@talk.nabble.com> <8d961d900708130243w28985a2dmf7ae9ebda7397c92@mail.gmail.com> <12136984.post@talk.nabble.com> Message-ID: <85d99afe0708132145x7644d635wd90ad5116bd46c28@mail.gmail.com> On 8/13/07, Shaker wrote: > > Dear Aslak: > Sorry to bother you over and over again. I did follow your instruction to > write the controller spec, but...the thing is not getting better.:-( > I'd like to post my code again, hopefully you would figure it out. > My Controller > class MyController > def index > pre = Array.new > render :partial=>'index', layout=>false, locals=>{:pre=>pre} > end > end > ------------------------------------------------------------ > My Controller spec > describe MyController do > it "should render the index partial" do > controller.expect_render(:partial=>'index', :layout=>false) > get 'index' > end > end > ------------------------------------------------------------ > By the way, I am using JRuby rather than ruby. Hence my command to run the > spec above is > jruby --command spec spec/controllers/my_controller_spec.rb --format specdoc > It always gave me an error:Mock 'expect_render_mock_proxy' expected :render > with > ({:partial=>"index"}) once, but received it 0 times. > Is it because "expect_render" is not compatible with JRuby or I forgot to > mock something? > Thanks a lot. > Regards. > Your failing test case seems to indicate a correct failure. You are expecting: controller.expect_render(:partial=>'index', :layout=>false) but you are passing in: render :partial=>'index', layout=>false, locals=>{:pre=>pre} Try updating your test to expect the :locals or try removing them from your call to render, whichever is correct for what you are doing, Zach From zach.dennis at gmail.com Tue Aug 14 00:58:58 2007 From: zach.dennis at gmail.com (Zach Dennis) Date: Tue, 14 Aug 2007 00:58:58 -0400 Subject: [rspec-users] expect_render, why does there need to be a warning Message-ID: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> There is a warning on the web site about expect_render and stub_render: "WARNING: expect_render and stub_render, while very useful, act differently from standard Message Expectations (a.k.a. mock expectations), which would never pass calls through to the real object. This can be very confusing when there are failures if you're not aware of this fact, because some calls will be passed through while others will not. This is especially confusing when you use stub_render because, as with all Method Stubs, you will get very little feedback about what is going on." My questions: Is this a sign that expect_render is doing to much? Is there a benefit from having expect_render and stub_render sometimes pass the render call to the underlying template object? Why not force all partials to be tested individually? Testing partials individually seems like a cleaner, more consistent and less confusing route to go, especially when you consider the nesting of paritals which render other partials. Zach From zach.dennis at gmail.com Tue Aug 14 01:01:37 2007 From: zach.dennis at gmail.com (Zach Dennis) Date: Tue, 14 Aug 2007 01:01:37 -0400 Subject: [rspec-users] [ANN] RSpec-1.0.8 In-Reply-To: <57c63afe0708122258r6ae4494cld9353dc135c00c94@mail.gmail.com> References: <57c63afe0708122258r6ae4494cld9353dc135c00c94@mail.gmail.com> Message-ID: <85d99afe0708132201s7b3edba2lf1fc14adc4f8a399@mail.gmail.com> I've been waiting for this since June so I can have expect_render "officially" . Thanks for the hard work! Zach On 8/13/07, David Chelimsky wrote: > The RSpec Development Team is pleased to announce the release of RSpec-1.0.8. > > RSpec 1.0.6 is the "holy cow, batman, it's been a long time since we > released and there are a ton of bug fixes, patches and even new > features" release. RSpec 1.0.7 and 1.0.8 deal with a regression > introduced in 1.0.6 and a hiccup in releasing 1.0.7, respectively. > > == RSpec > > RSpec is a Behaviour Driven Development framework which plays the same > role that a unit testing framework would play in Test Driven > Development, but does so using words and structures that better > support BDD. > > http://rspec.rubyforge.org > > == rspec_on_rails > > rspec_on_rails is a Ruby on Rails plugin that supports a BDD approach > to developing the various layers of objects within a Rails > application. > > See http://rspec.rubyforge.org/documentation/rails/index.html > > == Installation > > http://rspec.rubyforge.org/download.html > http://rspec.rubyforge.org/documentation/rails/install.html > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From zach.dennis at gmail.com Tue Aug 14 01:15:59 2007 From: zach.dennis at gmail.com (Zach Dennis) Date: Tue, 14 Aug 2007 01:15:59 -0400 Subject: [rspec-users] [ANN] RSpec-1.0.8 In-Reply-To: <85d99afe0708132201s7b3edba2lf1fc14adc4f8a399@mail.gmail.com> References: <57c63afe0708122258r6ae4494cld9353dc135c00c94@mail.gmail.com> <85d99afe0708132201s7b3edba2lf1fc14adc4f8a399@mail.gmail.com> Message-ID: <85d99afe0708132215l2d040d5by8ffa5bb3ea151e43@mail.gmail.com> It looks like officially was in 1.0.6, but I don't recall seeing an announcement on 1.0.6 or 1.0.7 ... perhaps I just missed it, Zach On 8/14/07, Zach Dennis wrote: > I've been waiting for this since June so I can have expect_render > "officially" . > > Thanks for the hard work! > > Zach > > On 8/13/07, David Chelimsky wrote: > > The RSpec Development Team is pleased to announce the release of RSpec-1.0.8. > > > > RSpec 1.0.6 is the "holy cow, batman, it's been a long time since we > > released and there are a ton of bug fixes, patches and even new > > features" release. RSpec 1.0.7 and 1.0.8 deal with a regression > > introduced in 1.0.6 and a hiccup in releasing 1.0.7, respectively. > > > > == RSpec > > > > RSpec is a Behaviour Driven Development framework which plays the same > > role that a unit testing framework would play in Test Driven > > Development, but does so using words and structures that better > > support BDD. > > > > http://rspec.rubyforge.org > > > > == rspec_on_rails > > > > rspec_on_rails is a Ruby on Rails plugin that supports a BDD approach > > to developing the various layers of objects within a Rails > > application. > > > > See http://rspec.rubyforge.org/documentation/rails/index.html > > > > == Installation > > > > http://rspec.rubyforge.org/download.html > > http://rspec.rubyforge.org/documentation/rails/install.html > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > From aslak.hellesoy at gmail.com Tue Aug 14 01:28:41 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Tue, 14 Aug 2007 07:28:41 +0200 Subject: [rspec-users] Backtrace tweaker - broken or me? In-Reply-To: <46C0D007.3090406@jay.fm> References: <46C0D007.3090406@jay.fm> Message-ID: <8d961d900708132228k698b12fdo9919367bfba48d29@mail.gmail.com> On 8/13/07, Jay Levitt wrote: > Using 1.0.8, I just realized that I've been scrolling through pages of > backtraces when rspec is supposed to clean them up for me. This is a > new development machine, so I'm not sure if older versions worked or > not. I'm running Ruby 1.8.6, Rails edge, Mac OS X 10.4.10. > > I've verified that the QuietBacktraceTweaker is the one that's running. > However, error.backtrace seems to have only one big element in it > (with multiple lines separated by \n), that whole line gets ignored > because it matches, and then the whole backtrace gets printed out anyway > somehow. I'm heading home and don't have time to dig into it right now, > but has anyone else seen this? > How can we reproduce it? Aslak > Jay Levitt > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Tue Aug 14 01:38:52 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 14 Aug 2007 01:38:52 -0400 Subject: [rspec-users] [ANN] RSpec-1.0.8 In-Reply-To: <85d99afe0708132215l2d040d5by8ffa5bb3ea151e43@mail.gmail.com> References: <57c63afe0708122258r6ae4494cld9353dc135c00c94@mail.gmail.com> <85d99afe0708132201s7b3edba2lf1fc14adc4f8a399@mail.gmail.com> <85d99afe0708132215l2d040d5by8ffa5bb3ea151e43@mail.gmail.com> Message-ID: <58BFE93D-49BA-4D65-8513-A018B79C017F@railsnewbie.com> On Aug 14, 2007, at 1:15 AM, Zach Dennis wrote: > It looks like officially was in 1.0.6, but I don't recall seeing an > announcement on 1.0.6 or 1.0.7 ... perhaps I just missed it, They were tiny releases (mostly, if not all, bug fixes) Scott From flyeminent at hotmail.com Tue Aug 14 01:44:01 2007 From: flyeminent at hotmail.com (Shaker) Date: Mon, 13 Aug 2007 22:44:01 -0700 (PDT) Subject: [rspec-users] How to use expect_render? In-Reply-To: <8d961d900708130243w28985a2dmf7ae9ebda7397c92@mail.gmail.com> References: <12121894.post@talk.nabble.com> <12123224.post@talk.nabble.com> <8d961d900708130243w28985a2dmf7ae9ebda7397c92@mail.gmail.com> Message-ID: <12136984.post@talk.nabble.com> Dear Fellows: Sorry to bother you over and over again. I did follow your instruction to write the controller spec, but...the thing is not getting better.:-( I'd like to post my code again, hopefully you would figure it out. My Controller class MyController def index pre = Array.new render :partial=>'index', :layout=>false, :locals=>{:pre=>pre} end end Notes: sorry, I just missed the colons for layout and locals, but I am afraid that the spec still failed even I added in the colons. ------------------------------------------------------------ My Controller spec describe MyController do it "should render the index partial" do controller.expect_render(:partial=>'index', :layout=>false) get 'index' end end ------------------------------------------------------------ By the way, I am using JRuby rather than ruby. Hence my command to run the spec above is jruby --command spec spec/controllers/my_controller_spec.rb --format specdoc It always gave me an error:Mock 'expect_render_mock_proxy' expected :render with ({:partial=>"index"}) once, but received it 0 times. Is it because "expect_render" is not compatible with JRuby or I forgot to mock something? Thanks a lot. Regards. aslak hellesoy wrote: > > On 8/13/07, Shaker wrote: >> >> Dear Aslak and David: >> I have tried two possible ways to get expect_render work. However, >> they >> all failed. My combinations are: >> my controller spec >> describe MyController do >> before do >> #do nothing >> end >> it "should render the index partial" do >> controller.expect_render(:partial=>'index') #1st way > > That's the way to go > >> MyController.expect_render(:partial=>'index') #2nd way >> end >> end >> >> The 1st way gave me an error: Mock 'expect_render_mock_proxy' expected >> :render with ({:partial=>'index'}) once, but received it 0 times > > You've forgotten to run the action. RSpec doesn't magically guess what > action is supposed to render your index partial. > > it "should render the index partial" do > controller.expect_render(:partial=>'index') > get 'index' > end > > >> The 2nd way gave me an error: undefined method 'expect_render' >> Do I need to mock the controller or there are some mistakes I have made >> in >> my spec? >> >> Shaker wrote: >> > >> > Hi: >> > I am a rspec beginner. I have scratched my head for the whole >> > afternoon, trying to figure out a way of writing render expectation in >> > controller spec. However, I failed. It kept telling me that the >> > 'expect_render' was an undefined method. I have installed rspec 1.0.8 >> and >> > rspec_on_rails as well. Below is the controller to be tested. >> > >> > Controller >> > def index >> > pre = Array.new >> > render :partial=>'index', :layout=>false, :locals=>{:pre=>pre} >> > end >> > >> > My controller spec >> > before do >> > @controller = MyController.new >> > end >> > it "should render the index partial" do >> > @controller.expect_render(:partial=>'index', :layout=>false) #I >> > don't know how to expect the :locals >> > end >> > >> > As I mentioned, the spec failed , saying that "Undefined method >> > 'expect_render' ". There might be some mistakes in my "before" block. >> Do I >> > need to mock the controller or something else? Anyway, do any one know >> how >> > to fix the problem? It will be even better if you guys could show me a >> > piece of example code. >> > Thanks!! >> > >> >> -- >> View this message in context: >> http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12123224 >> Sent from the rspec-users mailing list archive at Nabble.com. >> >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users >> > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > > -- View this message in context: http://www.nabble.com/How-to-use-expect_render--tf4259590.html#a12136984 Sent from the rspec-users mailing list archive at Nabble.com. From aslak.hellesoy at gmail.com Tue Aug 14 01:50:55 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Tue, 14 Aug 2007 07:50:55 +0200 Subject: [rspec-users] Backtrace tweaker - broken or me? In-Reply-To: <8d961d900708132228k698b12fdo9919367bfba48d29@mail.gmail.com> References: <46C0D007.3090406@jay.fm> <8d961d900708132228k698b12fdo9919367bfba48d29@mail.gmail.com> Message-ID: <8d961d900708132250o3204fab9sb30bc2111748a1f3@mail.gmail.com> On 8/14/07, aslak hellesoy wrote: > On 8/13/07, Jay Levitt wrote: > > Using 1.0.8, I just realized that I've been scrolling through pages of > > backtraces when rspec is supposed to clean them up for me. This is a > > new development machine, so I'm not sure if older versions worked or > > not. I'm running Ruby 1.8.6, Rails edge, Mac OS X 10.4.10. > > > > I've verified that the QuietBacktraceTweaker is the one that's running. > > However, error.backtrace seems to have only one big element in it > > (with multiple lines separated by \n), that whole line gets ignored > > because it matches, and then the whole backtrace gets printed out anyway > > somehow. I'm heading home and don't have time to dig into it right now, > > but has anyone else seen this? > > > > How can we reproduce it? > Never mind, I saw the tracker issue. > Aslak > > > Jay Levitt > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > From dchelimsky at gmail.com Tue Aug 14 02:16:05 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 14 Aug 2007 02:16:05 -0400 Subject: [rspec-users] expect_render, why does there need to be a warning In-Reply-To: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> References: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> Message-ID: <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> On 8/14/07, Zach Dennis wrote: > There is a warning on the web site about expect_render and stub_render: > > "WARNING: expect_render and stub_render, while very useful, act > differently from standard Message Expectations (a.k.a. mock > expectations), which would never pass calls through to the real > object. This can be very confusing when there are failures if you're > not aware of this fact, because some calls will be passed through > while others will not. This is especially confusing when you use > stub_render because, as with all Method Stubs, you will get very > little feedback about what is going on." > > My questions: > > Is this a sign that expect_render is doing to much? > Is there a benefit from having expect_render and stub_render sometimes > pass the render call to the underlying template object? > Why not force all partials to be tested individually? > > Testing partials individually seems like a cleaner, more consistent > and less confusing route to go, especially when you consider the > nesting of paritals which render other partials. That's the whole reason for the existence of expect_render. If you're spec'ing '_outer_partial' and you want to specify that it renders '_inner_partial', but you don't want to actually render '_inner_partial', there is no way to do that with traditional mocking frameworks because they are not designed to pay attention to one call to a method: render(:partial => '_inner_partial') while letting another call to the same method: render(:partial => '_outer_partial') through to the object. Agreed that expect_partial is doing to much, but what alternatives do we have? Cheers, David From dchelimsky at gmail.com Tue Aug 14 02:26:44 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 14 Aug 2007 02:26:44 -0400 Subject: [rspec-users] expect_render, why does there need to be a warning In-Reply-To: <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> References: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> Message-ID: <57c63afe0708132326k51b28a31q1a7ef5ce298b963@mail.gmail.com> On 8/14/07, David Chelimsky wrote: > On 8/14/07, Zach Dennis wrote: > > Is this a sign that expect_render is doing to much? > Agreed that expect_partial is doing to much, Oy vey - we BOTH used the wrong "to". Shame on both of us :) From zach.dennis at gmail.com Tue Aug 14 10:01:49 2007 From: zach.dennis at gmail.com (Zach Dennis) Date: Tue, 14 Aug 2007 10:01:49 -0400 Subject: [rspec-users] expect_render, why does there need to be a warning In-Reply-To: <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> References: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> Message-ID: <85d99afe0708140701w4fadd922i5868c962bacfb0fc@mail.gmail.com> On 8/14/07, David Chelimsky wrote: > On 8/14/07, Zach Dennis wrote: > > There is a warning on the web site about expect_render and stub_render: > > > > "WARNING: expect_render and stub_render, while very useful, act > > differently from standard Message Expectations (a.k.a. mock > > expectations), which would never pass calls through to the real > > object. This can be very confusing when there are failures if you're > > not aware of this fact, because some calls will be passed through > > while others will not. This is especially confusing when you use > > stub_render because, as with all Method Stubs, you will get very > > little feedback about what is going on." > > > > My questions: > > > > Is this a sign that expect_render is doing to much? > > Is there a benefit from having expect_render and stub_render sometimes > > pass the render call to the underlying template object? > > Why not force all partials to be tested individually? > > > > Testing partials individually seems like a cleaner, more consistent > > and less confusing route to go, especially when you consider the > > nesting of paritals which render other partials. > > That's the whole reason for the existence of expect_render. If you're > spec'ing '_outer_partial' and you want to specify that it renders > '_inner_partial', but you don't want to actually render > '_inner_partial', there is no way to do that with traditional mocking > frameworks because they are not designed to pay attention to one call > to a method: > > render(:partial => '_inner_partial') > > while letting another call to the same method: > > render(:partial => '_outer_partial') > > through to the object. Agreed that expect_partial is doing to much, > but what alternatives do we have? When testing views the first call to render is going to be the one that should be passed to the underlying template, since this is from the test. Every subsequent call to render will be done from within the template, so RSpec can look for a matching expectation. It seems that expect_render is in charge of setting those up. If this is done then a simple convention will be enforced, every inline "render :partial" call will have to be expected in a view spec, and every view template (or partial) will have to have it's own view test. This gets rid of issues of nesting, confusion and poorly written specs where someone is asserting contents of a partial rendered multiple levels deep in the render chain. Granted you end up with more view tests, but they are cleaner, shorter and easier to read. More importantly they are easier to maintain and update because they will be easy to find an existing spec for to start test driving changes, rather then having to find the view which renders your partial and the spec that renders that view (and heaven forbid your partial is used in several views, and each view tests the contents of that partial). Zach From edward.og at gmail.com Tue Aug 14 14:44:23 2007 From: edward.og at gmail.com (Edward Ocampo-Gooding) Date: Tue, 14 Aug 2007 14:44:23 -0400 Subject: [rspec-users] AssociationTypeMismatch with RSpec 1.0.8, autotest running with drb Message-ID: <46C1F807.5070504@gmail.com> Before I chalk this up as a bug and report it, I just want to make sure I'm not doing something silly. Running ZenTest's autotest on OS 10.4.10 with RSpec 1.0.8, drb, produces the following failed test: ActiveRecord::AssociationTypeMismatch in 'User should create an avatar with uploaded_data' Avatar expected, got Avatar This only happens with that exact configuration; turning off drb will fix it, as will running 'rake spec' instead. I saw something like this in Brian's post here [http://rubyforge.org/pipermail/rspec-devel/2007-June/003032.html] but it's a little strange that it only gets triggered in this exact setup. Any ideas why? Edward From aslak.hellesoy at gmail.com Tue Aug 14 15:20:36 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Tue, 14 Aug 2007 21:20:36 +0200 Subject: [rspec-users] AssociationTypeMismatch with RSpec 1.0.8, autotest running with drb In-Reply-To: <46C1F807.5070504@gmail.com> References: <46C1F807.5070504@gmail.com> Message-ID: <8d961d900708141220r52eccf40l7a6f5bf9be137465@mail.gmail.com> On 8/14/07, Edward Ocampo-Gooding wrote: > Before I chalk this up as a bug and report it, I just want to make sure I'm not > doing something silly. > > Running ZenTest's autotest on OS 10.4.10 with RSpec 1.0.8, drb, produces the > following failed test: > > ActiveRecord::AssociationTypeMismatch in 'User should create an avatar with > uploaded_data' > Avatar expected, got Avatar > > This only happens with that exact configuration; turning off drb will fix it, as > will running 'rake spec' instead. > What if you run with drb *without* autotest? Does it pass the first time and fail the second time? If that's the case, it could have something to do with the reloading of AR classes. Have you tried with different versions of Rails? Aslak > I saw something like this in Brian's post here > [http://rubyforge.org/pipermail/rspec-devel/2007-June/003032.html] but it's a > little strange that it only gets triggered in this exact setup. > > Any ideas why? > > Edward > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Tue Aug 14 16:15:32 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 14 Aug 2007 16:15:32 -0400 Subject: [rspec-users] To mock or not mock base classes Message-ID: <5CC942B4-60A1-4146-9A52-1BFD0B7D9DB4@railsnewbie.com> Just a general opinion question on idioms/common usage. Is it better to mock Ruby's base classes, or to use real instances of those base classes? @string = mock String @string.stub!(:to_s).and_return "hello" # or: @string = "hello" I was wondering which is generally favored, and if so, for what reasons? Or is it highly dependent on the type of spec which is being written? Regards, Scott From mailing_lists at railsnewbie.com Tue Aug 14 16:24:19 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 14 Aug 2007 16:24:19 -0400 Subject: [rspec-users] Using rspec in a non-rails project w/ autotest Message-ID: Not sure if anyone needs this, but I have successfully been running rspec/trunk with autotest for a few days now on a non-rails project. The process is pretty simple: 1. Put rspec into vendor/plugins/rspec (on externals, or simply frozen) 2. Add autotest/discover.rb: Autotest.add_discovery do "myproj" end 3. Add autotest/myproj.rb: require File.dirname(__FILE__) + "/../vendor/plugins/rspec/rspec/lib/ autotest/rspec" class Autotest::Myproj < Autotest::Rspec alias :old_spec_commands :spec_commands def spec_commands [File.dirname(__FILE__) + "/../vendor/plugins/rspec/rspec/bin/ spec"] + old_spec_commands end end Autotest should now run fine with trunk rspec (it also means you don't need the rspec gem installed). Happy hacking, Scott From mailing_lists at railsnewbie.com Tue Aug 14 16:30:09 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 14 Aug 2007 16:30:09 -0400 Subject: [rspec-users] (no subject) Message-ID: How would you spec out something like the following: def a_method x = Class.new do include Enumerable end # do something here with x end describe "The Anonymous Class" do before :each do @anonymous_class = mock Class Class.stub!(:new).and_return @anonymous_class end it "should create a new anonymous class" do Class.should_receive(:new) a_method end it "should include Enumerable" do #... what goes here? end end One thought I've had on this is that we should be able to do something like this: it "should include Enumerable" do Class.should_receive(:new).with(&lambda { include Enumerable }).and_return true end The serious problem with implementing this is that in Ruby 1.8.6 proc equality occurs at the syntax/parser tree level, so this spec would fail: describe "Two procs" do it "should be equal with the same bodies" do @proc1 = lambda { do_something } @proc2 = lambda { do_something } @proc1.should == @proc2 end end Any good thoughts on how to get around this? Scott From rupert_apsc at rupespad.com Tue Aug 14 16:46:58 2007 From: rupert_apsc at rupespad.com (rupert) Date: Tue, 14 Aug 2007 21:46:58 +0100 Subject: [rspec-users] (no subject) In-Reply-To: References: Message-ID: On 14/8/07 21:30, "Scott Taylor" wrote: > How would you spec out something like the following: > > def a_method > x = Class.new do > include Enumerable > end > > # do something here with x > end > > > describe "The Anonymous Class" do > > before :each do > @anonymous_class = mock Class > Class.stub!(:new).and_return @anonymous_class > end > > it "should create a new anonymous class" do > Class.should_receive(:new) > a_method > end > > it "should include Enumerable" do > #... what goes here? > end > > end Not being an expert, so apply the relevant pinches of salt! ...but if you're including enumerable, then it must be so that you can enumerate the class, so would the behavior driven approach be that you would test the enumerable behavior you wish the class to exhibit rather than the implementation of enabling this behavior by including the enumerable module. Cheers Rupert -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070814/0379a970/attachment-0001.html From aslak.hellesoy at gmail.com Tue Aug 14 17:17:19 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Tue, 14 Aug 2007 23:17:19 +0200 Subject: [rspec-users] (no subject) In-Reply-To: References: Message-ID: <8d961d900708141417x70179b26sa0c28fb76cc7cc25@mail.gmail.com> On 8/14/07, Scott Taylor wrote: > > How would you spec out something like the following: > You're starting with the code, trying to tape on the spec afterwards. This is always a difficult task and is exactly what BDD and RSpec is trying to get you away from. Have you tried writing the RSpec examples first? I'd help you with an example if I knew what you're trying to achieve from a functional (not code) standpoint. Aslak > def a_method > x = Class.new do > include Enumerable > end > > # do something here with x > end > > > describe "The Anonymous Class" do > > before :each do > @anonymous_class = mock Class > Class.stub!(:new).and_return @anonymous_class > end > > it "should create a new anonymous class" do > Class.should_receive(:new) > a_method > end > > it "should include Enumerable" do > #... what goes here? > end > > end > > One thought I've had on this is that we should be able to do > something like this: > > it "should include Enumerable" do > Class.should_receive(:new).with(&lambda { > include Enumerable > }).and_return true > end > > The serious problem with implementing this is that in Ruby 1.8.6 proc > equality occurs at the syntax/parser tree level, so this spec would > fail: > > describe "Two procs" do > it "should be equal with the same bodies" do > @proc1 = lambda { do_something } > @proc2 = lambda { do_something } > > @proc1.should == @proc2 > end > end > > Any good thoughts on how to get around this? > > Scott > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From luislavena at gmail.com Tue Aug 14 17:33:56 2007 From: luislavena at gmail.com (Luis Lavena) Date: Tue, 14 Aug 2007 18:33:56 -0300 Subject: [rspec-users] Upgrade to 1.0.8 broke Rake Message-ID: <71166b3b0708141433x6c875c51l9e3ca0bf28da62f4@mail.gmail.com> Hello Guys. I'm upgrading a project from 0.9.8 to 1.0.8, following this procedure: * Removed vendor/plugins/rspec* completely. * installed rspec and rspec_on_rails from svn://rubyforge.org/var/svn/rspec/tags/REL_1_0_8 * Run script/generate rspec to update spec_helper and spec.opts Now, when running rake, get the following error: superclass mismatch for class Annotation The following pastie shows the backtrace from rake (--trace) http://pastie.caboo.se/87713 According to the last line evaluated by Ruby, class Annotation is defined in another place, with another signature... http://pastie.caboo.se/87714 Which worked flawlessly prior the update. This only brakes Rake (which actually is very helpful). using script/spec and spec as gem to fire spec "testing" works almost without problems (some issues with ActionController::DoubleRenderError, nothing that couldn't be fixed) Any idea or suggestion? or I should stay at 0.9.8? :-) Thanks -- Luis Lavena Multimedia systems - Leaders are made, they are not born. They are made by hard effort, which is the price which all of us must pay to achieve any goal that is worthwhile. Vince Lombardi From mailing_lists at railsnewbie.com Tue Aug 14 17:53:56 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 14 Aug 2007 17:53:56 -0400 Subject: [rspec-users] (no subject) In-Reply-To: <8d961d900708141417x70179b26sa0c28fb76cc7cc25@mail.gmail.com> References: <8d961d900708141417x70179b26sa0c28fb76cc7cc25@mail.gmail.com> Message-ID: <2CEB9406-202C-4B0E-A2F4-BECC367FFDEC@railsnewbie.com> On Aug 14, 2007, at 5:17 PM, aslak hellesoy wrote: > On 8/14/07, Scott Taylor wrote: >> >> How would you spec out something like the following: >> > > You're starting with the code, trying to tape on the spec afterwards. > This is always a difficult task and is exactly what BDD and RSpec is > trying to get you away from. > > Have you tried writing the RSpec examples first? I'd help you with an > example if I knew what you're trying to achieve from a functional (not > code) standpoint. Sounds fair. The only reason I included the code first and presented it in that way was for simplicity. I'll now go for the complexity: I already have developed test first, and running specs. I'd now like to refactor, but my specs are preventing me. The code is here: http://pastie.caboo.se/87722 Here is the code I'd like to refactor: def anonymous_class_with_loaded_modules(*mods) klass = Class.new mods.each do |mod| klass.send(:include, mod) end return klass end I'd like to change it to this, which is functionally equivalent: def anonymous_class_with_loaded_modules(*mods) klass = Class.new do mods.each do |mod| include, mod end end return klass end Sorry for the long code samples, but I'm not exactly sure how to simplify them. I can also give you a high level over-view of what this code is doing and what it's purpose is. Let me know if that would better help you help me. Thanks for listening, Scott From luislavena at gmail.com Tue Aug 14 17:51:48 2007 From: luislavena at gmail.com (Luis Lavena) Date: Tue, 14 Aug 2007 18:51:48 -0300 Subject: [rspec-users] Upgrade to 1.0.8 broke Rake In-Reply-To: <71166b3b0708141433x6c875c51l9e3ca0bf28da62f4@mail.gmail.com> References: <71166b3b0708141433x6c875c51l9e3ca0bf28da62f4@mail.gmail.com> Message-ID: <71166b3b0708141451q2b28ed22y2defb14ee495919f@mail.gmail.com> A follow up... On 8/14/07, Luis Lavena wrote: > Hello Guys. > > I'm upgrading a project from 0.9.8 to 1.0.8, following this procedure: > First, is 0.9.4 :-) > > Now, when running rake, get the following error: superclass mismatch > for class Annotation > > The following pastie shows the backtrace from rake (--trace) > > http://pastie.caboo.se/87713 > > It seems is that I missed rspec installed 'as gem' even I have in the vendor/plugins for this application (and use the script/spec to run). Doing "gem install rspec -v '1.0.8'" solves the problem... Which shouldn't happen in the first place :P -- Luis Lavena Multimedia systems - Leaders are made, they are not born. They are made by hard effort, which is the price which all of us must pay to achieve any goal that is worthwhile. Vince Lombardi From mailing_lists at railsnewbie.com Tue Aug 14 18:35:33 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 14 Aug 2007 18:35:33 -0400 Subject: [rspec-users] (no subject) In-Reply-To: <2CEB9406-202C-4B0E-A2F4-BECC367FFDEC@railsnewbie.com> References: <8d961d900708141417x70179b26sa0c28fb76cc7cc25@mail.gmail.com> <2CEB9406-202C-4B0E-A2F4-BECC367FFDEC@railsnewbie.com> Message-ID: <8F19E839-F815-4C0E-A9F0-E4CEADCEC45E@railsnewbie.com> On Aug 14, 2007, at 5:53 PM, Scott Taylor wrote: > > On Aug 14, 2007, at 5:17 PM, aslak hellesoy wrote: > >> On 8/14/07, Scott Taylor wrote: >>> >>> How would you spec out something like the following: >>> >> >> You're starting with the code, trying to tape on the spec afterwards. >> This is always a difficult task and is exactly what BDD and RSpec is >> trying to get you away from. >> >> Have you tried writing the RSpec examples first? I'd help you with an >> example if I knew what you're trying to achieve from a functional >> (not >> code) standpoint. > > > Sounds fair. The only reason I included the code first and presented > it in that way was for simplicity. I'll now go for the complexity: > > I already have developed test first, and running specs. I'd now like > to refactor, but my specs are preventing me. The code is here: > > http://pastie.caboo.se/87722 > > Here is the code I'd like to refactor: > > def anonymous_class_with_loaded_modules(*mods) > klass = Class.new > mods.each do |mod| > klass.send(:include, mod) > end > return klass > end > > I'd like to change it to this, which is functionally equivalent: > > def anonymous_class_with_loaded_modules(*mods) > klass = Class.new do > mods.each do |mod| > include, mod > end > end > return klass > end Aslak, Maybe dependency injection would be the way to solve this problem. Let me know your thoughts - I'd like to clean up this code. Scott From mailing_lists at railsnewbie.com Tue Aug 14 18:55:25 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 14 Aug 2007 18:55:25 -0400 Subject: [rspec-users] Stubbing all methods Message-ID: <98ECC771-E86C-4978-8E18-7F371FC845D0@railsnewbie.com> Mocha's mock/stub framework has the ability to stub all methods on a mock given. Does RSpec's mocking framework have this ability? And if not, is there some reason it shouldn't be implemeneted? Regards, Scott From aslak.hellesoy at gmail.com Tue Aug 14 18:59:48 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Wed, 15 Aug 2007 00:59:48 +0200 Subject: [rspec-users] Stubbing all methods In-Reply-To: <98ECC771-E86C-4978-8E18-7F371FC845D0@railsnewbie.com> References: <98ECC771-E86C-4978-8E18-7F371FC845D0@railsnewbie.com> Message-ID: <8d961d900708141559o32705ecar62f781e4f45a390b@mail.gmail.com> On 8/15/07, Scott Taylor wrote: > > Mocha's mock/stub framework has the ability to stub all methods on a > mock given. Does RSpec's mocking framework have this ability? No > And > if not, is there some reason it shouldn't be implemeneted? > Not that I can think of. Aslak > Regards, > > Scott > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From aslak.hellesoy at gmail.com Tue Aug 14 19:03:13 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Wed, 15 Aug 2007 01:03:13 +0200 Subject: [rspec-users] Stubbing all methods In-Reply-To: <8d961d900708141559o32705ecar62f781e4f45a390b@mail.gmail.com> References: <98ECC771-E86C-4978-8E18-7F371FC845D0@railsnewbie.com> <8d961d900708141559o32705ecar62f781e4f45a390b@mail.gmail.com> Message-ID: <8d961d900708141603x413f2643hfc4aa4b43be50d42@mail.gmail.com> On 8/15/07, aslak hellesoy wrote: > On 8/15/07, Scott Taylor wrote: > > > > Mocha's mock/stub framework has the ability to stub all methods on a > > mock given. Does RSpec's mocking framework have this ability? > > No Err, actually it is possible. (I first thought about "stub methods on all instances of a class" which mocha does, but RSpec doesn't). mock("person", :null_object => true) Is this what you're after? See RDoc for details. Aslak > > > And > > if not, is there some reason it shouldn't be implemeneted? > > > > Not that I can think of. > > Aslak > > > Regards, > > > > Scott > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > From court3nay at gmail.com Tue Aug 14 19:09:53 2007 From: court3nay at gmail.com (Courtenay) Date: Tue, 14 Aug 2007 16:09:53 -0700 Subject: [rspec-users] Stubbing all methods In-Reply-To: <8d961d900708141559o32705ecar62f781e4f45a390b@mail.gmail.com> References: <98ECC771-E86C-4978-8E18-7F371FC845D0@railsnewbie.com> <8d961d900708141559o32705ecar62f781e4f45a390b@mail.gmail.com> Message-ID: <4b430c8f0708141609k2a3303f7w326cba18ca74e7b1@mail.gmail.com> On 8/14/07, aslak hellesoy wrote: > On 8/15/07, Scott Taylor wrote: > > > > Mocha's mock/stub framework has the ability to stub all methods on a > > mock given. Does RSpec's mocking framework have this ability? > You mean like :null_object => true ?? ============ http://rspec.rubyforge.org/documentation/mocks/mocks.html "As above, but allows you to specific options to tweak the mock's behaviour. The options argument is a hash. Currently the only supported option is :null_object. Setting this to true instructs the mock to ignore (quietly consume) any messages it hasn't been told to expect ? and return itself. i.e. my_mock = mock("blah", :null_object => true) From edward.og at gmail.com Tue Aug 14 21:52:29 2007 From: edward.og at gmail.com (Edward Ocampo-Gooding) Date: Tue, 14 Aug 2007 21:52:29 -0400 Subject: [rspec-users] AssociationTypeMismatch with RSpec 1.0.8, autotest running with drb In-Reply-To: <8d961d900708141220r52eccf40l7a6f5bf9be137465@mail.gmail.com> References: <46C1F807.5070504@gmail.com> <8d961d900708141220r52eccf40l7a6f5bf9be137465@mail.gmail.com> Message-ID: <46C25C5D.3060203@gmail.com> aslak hellesoy wrote: > On 8/14/07, Edward Ocampo-Gooding wrote: >> Before I chalk this up as a bug and report it, I just want to make sure I'm not >> doing something silly. >> >> Running ZenTest's autotest on OS 10.4.10 with RSpec 1.0.8, drb, produces the >> following failed test: >> >> ActiveRecord::AssociationTypeMismatch in 'User should create an avatar with >> uploaded_data' >> Avatar expected, got Avatar >> >> This only happens with that exact configuration; turning off drb will fix it, as >> will running 'rake spec' instead. >> > > What if you run with drb *without* autotest? Does it pass the first > time and fail the second time? > If that's the case, it could have something to do with the reloading > of AR classes. Have you tried with different versions of Rails? After getting home and trying it out again on the same laptop, it looks like when drb is enabled, now both 'rake spec' and autotest hang for about 60 seconds and then finally run. (Running rake spec --trace shows that it's hanging on "Execute spec" for a really long time.) Is there some drb debugging flag I can turn on, or blow away some drb-related cache? Oh, and yes, you're right; 'rake spec' looks like it's having problems with reloading the class, as it works fine the first time, but on subsequent runs, it fails with an ActiveRecord::AssociationTypeMismatch. This is all on Rails 1.2.3 Thanks, Edward From mailing_lists at railsnewbie.com Tue Aug 14 22:40:43 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 14 Aug 2007 22:40:43 -0400 Subject: [rspec-users] Stubbing all methods In-Reply-To: <4b430c8f0708141609k2a3303f7w326cba18ca74e7b1@mail.gmail.com> References: <98ECC771-E86C-4978-8E18-7F371FC845D0@railsnewbie.com> <8d961d900708141559o32705ecar62f781e4f45a390b@mail.gmail.com> <4b430c8f0708141609k2a3303f7w326cba18ca74e7b1@mail.gmail.com> Message-ID: <4CE93F76-47E3-4215-8FC7-0DDD6E8848A0@railsnewbie.com> On Aug 14, 2007, at 7:09 PM, Courtenay wrote: > On 8/14/07, aslak hellesoy wrote: >> On 8/15/07, Scott Taylor wrote: >>> >>> Mocha's mock/stub framework has the ability to stub all methods on a >>> mock given. Does RSpec's mocking framework have this ability? >> > > You mean like :null_object => true ?? Yes, actually that works well. Aslak - were you understanding me to ask for Mocha's any_instance stub ? Thanks, Scott > > ============ > > http://rspec.rubyforge.org/documentation/mocks/mocks.html > > "As above, but allows you to specific options to tweak the mock's > behaviour. The options argument is a hash. Currently the only > supported option is :null_object. Setting this to true instructs the > mock to ignore (quietly consume) any messages it hasn't been told to > expect ? and return itself. i.e. > > my_mock = mock("blah", :null_object => true) > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From pergesu at gmail.com Tue Aug 14 23:36:54 2007 From: pergesu at gmail.com (Pat Maddox) Date: Tue, 14 Aug 2007 20:36:54 -0700 Subject: [rspec-users] To mock or not mock base classes In-Reply-To: <5CC942B4-60A1-4146-9A52-1BFD0B7D9DB4@railsnewbie.com> References: <5CC942B4-60A1-4146-9A52-1BFD0B7D9DB4@railsnewbie.com> Message-ID: <810a540e0708142036i262734aaya8aaed19e1e68a0c@mail.gmail.com> On 8/14/07, Scott Taylor wrote: > > Just a general opinion question on idioms/common usage. Is it better > to mock Ruby's base classes, or to use real instances of those base > classes? > > @string = mock String > @string.stub!(:to_s).and_return "hello" > > # or: > > @string = "hello" > > I was wondering which is generally favored, and if so, for what > reasons? Or is it highly dependent on the type of spec which is > being written? > > Regards, > > Scott > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > I would say the second way is pretty clearly the favorite :) However there might be usages where the first way could be appropriate, but it's surely not that example. Perhaps you could show the actual spec you're trying to write? Pat From dchelimsky at gmail.com Tue Aug 14 23:41:37 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 14 Aug 2007 23:41:37 -0400 Subject: [rspec-users] expect_render, why does there need to be a warning In-Reply-To: <85d99afe0708140701w4fadd922i5868c962bacfb0fc@mail.gmail.com> References: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> <85d99afe0708140701w4fadd922i5868c962bacfb0fc@mail.gmail.com> Message-ID: <57c63afe0708142041y55efc047m7230f01cd0a26e3e@mail.gmail.com> On 8/14/07, Zach Dennis wrote: > On 8/14/07, David Chelimsky wrote: > > On 8/14/07, Zach Dennis wrote: > > > There is a warning on the web site about expect_render and stub_render: > > > > > > "WARNING: expect_render and stub_render, while very useful, act > > > differently from standard Message Expectations (a.k.a. mock > > > expectations), which would never pass calls through to the real > > > object. This can be very confusing when there are failures if you're > > > not aware of this fact, because some calls will be passed through > > > while others will not. This is especially confusing when you use > > > stub_render because, as with all Method Stubs, you will get very > > > little feedback about what is going on." > > > > > > My questions: > > > > > > Is this a sign that expect_render is doing to much? > > > Is there a benefit from having expect_render and stub_render sometimes > > > pass the render call to the underlying template object? > > > Why not force all partials to be tested individually? > > > > > > Testing partials individually seems like a cleaner, more consistent > > > and less confusing route to go, especially when you consider the > > > nesting of paritals which render other partials. > > > > That's the whole reason for the existence of expect_render. If you're > > spec'ing '_outer_partial' and you want to specify that it renders > > '_inner_partial', but you don't want to actually render > > '_inner_partial', there is no way to do that with traditional mocking > > frameworks because they are not designed to pay attention to one call > > to a method: > > > > render(:partial => '_inner_partial') > > > > while letting another call to the same method: > > > > render(:partial => '_outer_partial') > > > > through to the object. Agreed that expect_partial is doing to much, > > but what alternatives do we have? > > When testing views the first call to render is going to be the one > that should be passed to the underlying template, since this is from > the test. > > Every subsequent call to render will be done from within the template, > so RSpec can look for a matching expectation. It seems that > expect_render is in charge of setting those up. > > If this is done then a simple convention will be enforced, every > inline "render :partial" call will have to be expected in a view spec, > and every view template (or partial) will have to have it's own view > test. > > This gets rid of issues of nesting, confusion and poorly written specs > where someone is asserting contents of a partial rendered multiple > levels deep in the render chain. > > Granted you end up with more view tests, but they are cleaner, shorter > and easier to read. More importantly they are easier to maintain and > update because they will be easy to find an existing spec for to start > test driving changes, rather then having to find the view which > renders your partial and the spec that renders that view (and heaven > forbid your partial is used in several views, and each view tests the > contents of that partial). I think you are describing a good convention, but I don't think rspec should force it on everybody. The goal here is to provide tools that ALLOW you to do things in certain ways but not force you to. For example, rspec_on_rails supports isolated views, but you can do rails-style functional tests (using controller specs with integrated views) if you want. From jonathan at parkerhill.com Wed Aug 15 03:40:38 2007 From: jonathan at parkerhill.com (Jonathan Linowes) Date: Wed, 15 Aug 2007 03:40:38 -0400 Subject: [rspec-users] active_scaffold partials In-Reply-To: <85d99afe0708140701w4fadd922i5868c962bacfb0fc@mail.gmail.com> References: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> <85d99afe0708140701w4fadd922i5868c962bacfb0fc@mail.gmail.com> Message-ID: <905E3694-C9B6-4FC1-9204-8135C10A4E9A@parkerhill.com> An issue I've run into is with a controller using the active_scaffold plugin, which injects a method that modifies the search path for partial files. When I try to run a spec on a a_s partial it reports the file cannot be found. I think this is the a_s code that does it but I'm not sure where to go from there to get rspec to handle it. Any suggestions would be appreciated. file: plugins/active_scaffold/lib/extensions/action_view.rb module ActionView #:nodoc: class Base ... def render_partial_with_active_scaffold(partial_path, local_assigns = nil, deprecated_local_assigns = nil) #:nodoc: if self.controller.class.respond_to?(:uses_active_scaffold?) and self.controller.class.uses_active_scaffold? partial_path = rewrite_partial_path_for_active_scaffold (partial_path) end render_partial_without_active_scaffold(partial_path, local_assigns, deprecated_local_assigns) end alias_method :render_partial_without_active_scaffold, :render_partial alias_method :render_partial, :render_partial_with_active_scaffold private def rewrite_partial_path_for_active_scaffold(partial_path) path, partial_name = partial_pieces(partial_path) # test for the actual file return partial_path if file_exists? File.join(path, "_# {partial_name}") # check the ActiveScaffold-specific directories ActiveScaffold::Config::Core.template_search_path.each do | template_path| return File.join(template_path, partial_name) if file_exists? File.join(template_path, "_#{partial_name}") end return partial_path end end end From mailing_lists at railsnewbie.com Wed Aug 15 07:51:33 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Wed, 15 Aug 2007 07:51:33 -0400 Subject: [rspec-users] Extra Options to Heckle Message-ID: I've tried running Heckle with rspec on some of my classes, but keep getting (what I believe to be) an infinite recursion. Is there some way to supply extra options to heckle via. rspec? Scott From steve.tooke at gmail.com Wed Aug 15 07:52:20 2007 From: steve.tooke at gmail.com (Steve Tooke) Date: Wed, 15 Aug 2007 12:52:20 +0100 Subject: [rspec-users] ActsAsList specs Message-ID: <78d462040708150452m747ae9d0k10aef7ba208af6db@mail.gmail.com> Hi, How are people specifying models which act_as_list? I'm thinking that it would be possible to check that acts_as_list instance methods have been added to a class using something like this: describe Page, "acts_as_list" do it "should act as a list" do Page.ancestors.should be_include(ActiveRecord::Acts::List::InstanceMethods) end it "should use page_index as position_column" do Page.new.position_column.should == "page_index" end it "should have scope of book_id" do Page.new.scope_condition.should == "book_id IS NULL" end end it at least lets you drive adding acts_as_list? Any thoughts on how I can improve this? How anyone else has done this? Cheers, Steve From aslak.hellesoy at gmail.com Wed Aug 15 07:57:03 2007 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Wed, 15 Aug 2007 13:57:03 +0200 Subject: [rspec-users] Extra Options to Heckle In-Reply-To: References: Message-ID: <8d961d900708150457w6a001d99t8b2ed18a55f0821b@mail.gmail.com> On 8/15/07, Scott Taylor wrote: > > I've tried running Heckle with rspec on some of my classes, but keep > getting (what I believe to be) an infinite recursion. Is there some > way to supply extra options to heckle via. rspec? > Currently not. What options do you want to supply? Aslak > Scott > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Wed Aug 15 08:11:00 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Wed, 15 Aug 2007 08:11:00 -0400 Subject: [rspec-users] Extra Options to Heckle In-Reply-To: <8d961d900708150457w6a001d99t8b2ed18a55f0821b@mail.gmail.com> References: <8d961d900708150457w6a001d99t8b2ed18a55f0821b@mail.gmail.com> Message-ID: <5A1E2341-F3CF-40FC-91D9-9F47EBC9CC1F@railsnewbie.com> On Aug 15, 2007, at 7:57 AM, aslak hellesoy wrote: > On 8/15/07, Scott Taylor wrote: >> >> I've tried running Heckle with rspec on some of my classes, but keep >> getting (what I believe to be) an infinite recursion. Is there some >> way to supply extra options to heckle via. rspec? >> > > Currently not. What options do you want to supply? Well right now the only one I care about is --verbose, but depending on the output of --verbose, I may want other options (probably -- assignments and --branches). Thanks, Scott From mailing_lists at railsnewbie.com Wed Aug 15 08:16:48 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Wed, 15 Aug 2007 08:16:48 -0400 Subject: [rspec-users] Extra Options to Heckle In-Reply-To: <5A1E2341-F3CF-40FC-91D9-9F47EBC9CC1F@railsnewbie.com> References: <8d961d900708150457w6a001d99t8b2ed18a55f0821b@mail.gmail.com> <5A1E2341-F3CF-40FC-91D9-9F47EBC9CC1F@railsnewbie.com> Message-ID: <38C5AD61-85C8-4C34-A401-0119BDF8E179@railsnewbie.com> On Aug 15, 2007, at 8:11 AM, Scott Taylor wrote: > > On Aug 15, 2007, at 7:57 AM, aslak hellesoy wrote: > >> On 8/15/07, Scott Taylor wrote: >>> >>> I've tried running Heckle with rspec on some of my classes, but keep >>> getting (what I believe to be) an infinite recursion. Is there some >>> way to supply extra options to heckle via. rspec? >>> >> >> Currently not. What options do you want to supply? > > Well right now the only one I care about is --verbose, but depending > on the output of --verbose, I may want other options (probably -- > assignments and --branches). > I can probably work up a patch for this one. Thanks for the info, Aslak. Scott From dchelimsky at gmail.com Wed Aug 15 10:28:12 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 15 Aug 2007 10:28:12 -0400 Subject: [rspec-users] expect_render, why does there need to be a warning In-Reply-To: <85d99afe0708150722x31a5b3fev117546f1c60617eb@mail.gmail.com> References: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> <85d99afe0708140701w4fadd922i5868c962bacfb0fc@mail.gmail.com> <57c63afe0708142041y55efc047m7230f01cd0a26e3e@mail.gmail.com> <85d99afe0708150722x31a5b3fev117546f1c60617eb@mail.gmail.com> Message-ID: <57c63afe0708150728p633fcda1k7401ce89a5429de7@mail.gmail.com> On 8/15/07, Zach Dennis wrote: > On 8/14/07, David Chelimsky wrote: > > On 8/14/07, Zach Dennis wrote: > > > On 8/14/07, David Chelimsky wrote: > > > > On 8/14/07, Zach Dennis wrote: > > > > > There is a warning on the web site about expect_render and stub_render: > > > > > > > > > > "WARNING: expect_render and stub_render, while very useful, act > > > > > differently from standard Message Expectations (a.k.a. mock > > > > > expectations), which would never pass calls through to the real > > > > > object. This can be very confusing when there are failures if you're > > > > > not aware of this fact, because some calls will be passed through > > > > > while others will not. This is especially confusing when you use > > > > > stub_render because, as with all Method Stubs, you will get very > > > > > little feedback about what is going on." > > > > > > > > > > My questions: > > > > > > > > > > Is this a sign that expect_render is doing to much? > > > > > Is there a benefit from having expect_render and stub_render sometimes > > > > > pass the render call to the underlying template object? > > > > > Why not force all partials to be tested individually? > > > > > > > > > > Testing partials individually seems like a cleaner, more consistent > > > > > and less confusing route to go, especially when you consider the > > > > > nesting of paritals which render other partials. > > > > > > > > That's the whole reason for the existence of expect_render. If you're > > > > spec'ing '_outer_partial' and you want to specify that it renders > > > > '_inner_partial', but you don't want to actually render > > > > '_inner_partial', there is no way to do that with traditional mocking > > > > frameworks because they are not designed to pay attention to one call > > > > to a method: > > > > > > > > render(:partial => '_inner_partial') > > > > > > > > while letting another call to the same method: > > > > > > > > render(:partial => '_outer_partial') > > > > > > > > through to the object. Agreed that expect_partial is doing to much, > > > > but what alternatives do we have? > > > > > > When testing views the first call to render is going to be the one > > > that should be passed to the underlying template, since this is from > > > the test. > > > > > > Every subsequent call to render will be done from within the template, > > > so RSpec can look for a matching expectation. It seems that > > > expect_render is in charge of setting those up. > > > > > > If this is done then a simple convention will be enforced, every > > > inline "render :partial" call will have to be expected in a view spec, > > > and every view template (or partial) will have to have it's own view > > > test. > > > > > > This gets rid of issues of nesting, confusion and poorly written specs > > > where someone is asserting contents of a partial rendered multiple > > > levels deep in the render chain. > > > > > > Granted you end up with more view tests, but they are cleaner, shorter > > > and easier to read. More importantly they are easier to maintain and > > > update because they will be easy to find an existing spec for to start > > > test driving changes, rather then having to find the view which > > > renders your partial and the spec that renders that view (and heaven > > > forbid your partial is used in several views, and each view tests the > > > contents of that partial). > > > > I think you are describing a good convention, but I don't think rspec > > should force it on everybody. The goal here is to provide tools that > > ALLOW you to do things in certain ways but not force you to. > > > > For example, rspec_on_rails supports isolated views, but you can do > > rails-style functional tests (using controller specs with integrated > > views) if you want. > > How about a "integrate_inline_renders" similar to "integrate_views"? Just don't use expect_render and it'll do that. Magic! > > Zach > From zach.dennis at gmail.com Wed Aug 15 10:22:13 2007 From: zach.dennis at gmail.com (Zach Dennis) Date: Wed, 15 Aug 2007 10:22:13 -0400 Subject: [rspec-users] expect_render, why does there need to be a warning In-Reply-To: <57c63afe0708142041y55efc047m7230f01cd0a26e3e@mail.gmail.com> References: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> <85d99afe0708140701w4fadd922i5868c962bacfb0fc@mail.gmail.com> <57c63afe0708142041y55efc047m7230f01cd0a26e3e@mail.gmail.com> Message-ID: <85d99afe0708150722x31a5b3fev117546f1c60617eb@mail.gmail.com> On 8/14/07, David Chelimsky wrote: > On 8/14/07, Zach Dennis wrote: > > On 8/14/07, David Chelimsky wrote: > > > On 8/14/07, Zach Dennis wrote: > > > > There is a warning on the web site about expect_render and stub_render: > > > > > > > > "WARNING: expect_render and stub_render, while very useful, act > > > > differently from standard Message Expectations (a.k.a. mock > > > > expectations), which would never pass calls through to the real > > > > object. This can be very confusing when there are failures if you're > > > > not aware of this fact, because some calls will be passed through > > > > while others will not. This is especially confusing when you use > > > > stub_render because, as with all Method Stubs, you will get very > > > > little feedback about what is going on." > > > > > > > > My questions: > > > > > > > > Is this a sign that expect_render is doing to much? > > > > Is there a benefit from having expect_render and stub_render sometimes > > > > pass the render call to the underlying template object? > > > > Why not force all partials to be tested individually? > > > > > > > > Testing partials individually seems like a cleaner, more consistent > > > > and less confusing route to go, especially when you consider the > > > > nesting of paritals which render other partials. > > > > > > That's the whole reason for the existence of expect_render. If you're > > > spec'ing '_outer_partial' and you want to specify that it renders > > > '_inner_partial', but you don't want to actually render > > > '_inner_partial', there is no way to do that with traditional mocking > > > frameworks because they are not designed to pay attention to one call > > > to a method: > > > > > > render(:partial => '_inner_partial') > > > > > > while letting another call to the same method: > > > > > > render(:partial => '_outer_partial') > > > > > > through to the object. Agreed that expect_partial is doing to much, > > > but what alternatives do we have? > > > > When testing views the first call to render is going to be the one > > that should be passed to the underlying template, since this is from > > the test. > > > > Every subsequent call to render will be done from within the template, > > so RSpec can look for a matching expectation. It seems that > > expect_render is in charge of setting those up. > > > > If this is done then a simple convention will be enforced, every > > inline "render :partial" call will have to be expected in a view spec, > > and every view template (or partial) will have to have it's own view > > test. > > > > This gets rid of issues of nesting, confusion and poorly written specs > > where someone is asserting contents of a partial rendered multiple > > levels deep in the render chain. > > > > Granted you end up with more view tests, but they are cleaner, shorter > > and easier to read. More importantly they are easier to maintain and > > update because they will be easy to find an existing spec for to start > > test driving changes, rather then having to find the view which > > renders your partial and the spec that renders that view (and heaven > > forbid your partial is used in several views, and each view tests the > > contents of that partial). > > I think you are describing a good convention, but I don't think rspec > should force it on everybody. The goal here is to provide tools that > ALLOW you to do things in certain ways but not force you to. > > For example, rspec_on_rails supports isolated views, but you can do > rails-style functional tests (using controller specs with integrated > views) if you want. How about a "integrate_inline_renders" similar to "integrate_views"? Zach From zach.dennis at gmail.com Wed Aug 15 13:09:11 2007 From: zach.dennis at gmail.com (Zach Dennis) Date: Wed, 15 Aug 2007 13:09:11 -0400 Subject: [rspec-users] expect_render, why does there need to be a warning In-Reply-To: <57c63afe0708150728p633fcda1k7401ce89a5429de7@mail.gmail.com> References: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> <85d99afe0708140701w4fadd922i5868c962bacfb0fc@mail.gmail.com> <57c63afe0708142041y55efc047m7230f01cd0a26e3e@mail.gmail.com> <85d99afe0708150722x31a5b3fev117546f1c60617eb@mail.gmail.com> <57c63afe0708150728p633fcda1k7401ce89a5429de7@mail.gmail.com> Message-ID: <85d99afe0708151009oef2bde8jc289dc721dcb6812@mail.gmail.com> On 8/15/07, David Chelimsky wrote: > On 8/15/07, Zach Dennis wrote: > > On 8/14/07, David Chelimsky wrote: > > > On 8/14/07, Zach Dennis wrote: > > > > On 8/14/07, David Chelimsky wrote: > > > > > On 8/14/07, Zach Dennis wrote: > > > > > > There is a warning on the web site about expect_render and stub_render: > > > > > > > > > > > > "WARNING: expect_render and stub_render, while very useful, act > > > > > > differently from standard Message Expectations (a.k.a. mock > > > > > > expectations), which would never pass calls through to the real > > > > > > object. This can be very confusing when there are failures if you're > > > > > > not aware of this fact, because some calls will be passed through > > > > > > while others will not. This is especially confusing when you use > > > > > > stub_render because, as with all Method Stubs, you will get very > > > > > > little feedback about what is going on." > > > > > > > > > > > > My questions: > > > > > > > > > > > > Is this a sign that expect_render is doing to much? > > > > > > Is there a benefit from having expect_render and stub_render sometimes > > > > > > pass the render call to the underlying template object? > > > > > > Why not force all partials to be tested individually? > > > > > > > > > > > > Testing partials individually seems like a cleaner, more consistent > > > > > > and less confusing route to go, especially when you consider the > > > > > > nesting of paritals which render other partials. > > > > > > > > > > That's the whole reason for the existence of expect_render. If you're > > > > > spec'ing '_outer_partial' and you want to specify that it renders > > > > > '_inner_partial', but you don't want to actually render > > > > > '_inner_partial', there is no way to do that with traditional mocking > > > > > frameworks because they are not designed to pay attention to one call > > > > > to a method: > > > > > > > > > > render(:partial => '_inner_partial') > > > > > > > > > > while letting another call to the same method: > > > > > > > > > > render(:partial => '_outer_partial') > > > > > > > > > > through to the object. Agreed that expect_partial is doing to much, > > > > > but what alternatives do we have? > > > > > > > > When testing views the first call to render is going to be the one > > > > that should be passed to the underlying template, since this is from > > > > the test. > > > > > > > > Every subsequent call to render will be done from within the template, > > > > so RSpec can look for a matching expectation. It seems that > > > > expect_render is in charge of setting those up. > > > > > > > > If this is done then a simple convention will be enforced, every > > > > inline "render :partial" call will have to be expected in a view spec, > > > > and every view template (or partial) will have to have it's own view > > > > test. > > > > > > > > This gets rid of issues of nesting, confusion and poorly written specs > > > > where someone is asserting contents of a partial rendered multiple > > > > levels deep in the render chain. > > > > > > > > Granted you end up with more view tests, but they are cleaner, shorter > > > > and easier to read. More importantly they are easier to maintain and > > > > update because they will be easy to find an existing spec for to start > > > > test driving changes, rather then having to find the view which > > > > renders your partial and the spec that renders that view (and heaven > > > > forbid your partial is used in several views, and each view tests the > > > > contents of that partial). > > > > > > I think you are describing a good convention, but I don't think rspec > > > should force it on everybody. The goal here is to provide tools that > > > ALLOW you to do things in certain ways but not force you to. > > > > > > For example, rspec_on_rails supports isolated views, but you can do > > > rails-style functional tests (using controller specs with integrated > > > views) if you want. > > > > How about a "integrate_inline_renders" similar to "integrate_views"? > > Just don't use expect_render and it'll do that. Magic! > I'm on the opposite view point. I don't want to pass through renders, I want to force all inline renders to be enforced. If i have a view that calls "render :partial => 'foo'" and I don't use expect_render I want it to yell at me saying an unexpected call was made on the template. Zach From dchelimsky at gmail.com Wed Aug 15 14:18:38 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 15 Aug 2007 14:18:38 -0400 Subject: [rspec-users] expect_render, why does there need to be a warning In-Reply-To: <85d99afe0708151009oef2bde8jc289dc721dcb6812@mail.gmail.com> References: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> <85d99afe0708140701w4fadd922i5868c962bacfb0fc@mail.gmail.com> <57c63afe0708142041y55efc047m7230f01cd0a26e3e@mail.gmail.com> <85d99afe0708150722x31a5b3fev117546f1c60617eb@mail.gmail.com> <57c63afe0708150728p633fcda1k7401ce89a5429de7@mail.gmail.com> <85d99afe0708151009oef2bde8jc289dc721dcb6812@mail.gmail.com> Message-ID: <57c63afe0708151118i36a45934m1b891f67d5dac5ed@mail.gmail.com> On 8/15/07, Zach Dennis wrote: > On 8/15/07, David Chelimsky wrote: > > On 8/15/07, Zach Dennis wrote: > > > On 8/14/07, David Chelimsky wrote: > > > > On 8/14/07, Zach Dennis wrote: > > > > > On 8/14/07, David Chelimsky wrote: > > > > > > On 8/14/07, Zach Dennis wrote: > > > > > > > There is a warning on the web site about expect_render and stub_render: > > > > > > > > > > > > > > "WARNING: expect_render and stub_render, while very useful, act > > > > > > > differently from standard Message Expectations (a.k.a. mock > > > > > > > expectations), which would never pass calls through to the real > > > > > > > object. This can be very confusing when there are failures if you're > > > > > > > not aware of this fact, because some calls will be passed through > > > > > > > while others will not. This is especially confusing when you use > > > > > > > stub_render because, as with all Method Stubs, you will get very > > > > > > > little feedback about what is going on." > > > > > > > > > > > > > > My questions: > > > > > > > > > > > > > > Is this a sign that expect_render is doing to much? > > > > > > > Is there a benefit from having expect_render and stub_render sometimes > > > > > > > pass the render call to the underlying template object? > > > > > > > Why not force all partials to be tested individually? > > > > > > > > > > > > > > Testing partials individually seems like a cleaner, more consistent > > > > > > > and less confusing route to go, especially when you consider the > > > > > > > nesting of paritals which render other partials. > > > > > > > > > > > > That's the whole reason for the existence of expect_render. If you're > > > > > > spec'ing '_outer_partial' and you want to specify that it renders > > > > > > '_inner_partial', but you don't want to actually render > > > > > > '_inner_partial', there is no way to do that with traditional mocking > > > > > > frameworks because they are not designed to pay attention to one call > > > > > > to a method: > > > > > > > > > > > > render(:partial => '_inner_partial') > > > > > > > > > > > > while letting another call to the same method: > > > > > > > > > > > > render(:partial => '_outer_partial') > > > > > > > > > > > > through to the object. Agreed that expect_partial is doing to much, > > > > > > but what alternatives do we have? > > > > > > > > > > When testing views the first call to render is going to be the one > > > > > that should be passed to the underlying template, since this is from > > > > > the test. > > > > > > > > > > Every subsequent call to render will be done from within the template, > > > > > so RSpec can look for a matching expectation. It seems that > > > > > expect_render is in charge of setting those up. > > > > > > > > > > If this is done then a simple convention will be enforced, every > > > > > inline "render :partial" call will have to be expected in a view spec, > > > > > and every view template (or partial) will have to have it's own view > > > > > test. > > > > > > > > > > This gets rid of issues of nesting, confusion and poorly written specs > > > > > where someone is asserting contents of a partial rendered multiple > > > > > levels deep in the render chain. > > > > > > > > > > Granted you end up with more view tests, but they are cleaner, shorter > > > > > and easier to read. More importantly they are easier to maintain and > > > > > update because they will be easy to find an existing spec for to start > > > > > test driving changes, rather then having to find the view which > > > > > renders your partial and the spec that renders that view (and heaven > > > > > forbid your partial is used in several views, and each view tests the > > > > > contents of that partial). > > > > > > > > I think you are describing a good convention, but I don't think rspec > > > > should force it on everybody. The goal here is to provide tools that > > > > ALLOW you to do things in certain ways but not force you to. > > > > > > > > For example, rspec_on_rails supports isolated views, but you can do > > > > rails-style functional tests (using controller specs with integrated > > > > views) if you want. > > > > > > How about a "integrate_inline_renders" similar to "integrate_views"? > > > > Just don't use expect_render and it'll do that. Magic! > > > > I'm on the opposite view point. I don't want to pass through renders, > I want to force all inline renders to be enforced. > > If i have a view that calls "render :partial => 'foo'" and I don't use > expect_render I want it to yell at me saying an unexpected call was > made on the template. There's nothing else in rspec_on_rails that yells at you because you don't like to organize your specs the way rspec thinks they should be organized, so I definitely wouldn't support this being default behaviour. I could see, maybe, the possibility of having a command like disallow_unexpected_renders or something like that, but I honestly don't see that much value in it in return for the additional complexity (didn't you start by saying this was too complex already?). I understand that you DO see value in this, and I'd encourage you to write a plugin that makes this work the way you want and feel free to publish it. Cheers, David From court3nay at gmail.com Wed Aug 15 14:22:47 2007 From: court3nay at gmail.com (Courtenay) Date: Wed, 15 Aug 2007 11:22:47 -0700 Subject: [rspec-users] ActsAsList specs In-Reply-To: <78d462040708150452m747ae9d0k10aef7ba208af6db@mail.gmail.com> References: <78d462040708150452m747ae9d0k10aef7ba208af6db@mail.gmail.com> Message-ID: <4b430c8f0708151122y50a361c8y5f23cf1c6d838e72@mail.gmail.com> On 8/15/07, Steve Tooke wrote: > Hi, > > How are people specifying models which act_as_list? > > I'm thinking that it would be possible to check that acts_as_list > instance methods have been added to a class using something like this: You're specing the code not the behavior. This will make double-work if you want to change anything. From priit.tamboom at gmail.com Wed Aug 15 15:14:18 2007 From: priit.tamboom at gmail.com (Priit Tamboom) Date: Thu, 16 Aug 2007 03:14:18 +0800 Subject: [rspec-users] nuby: how spec redirect_to at ApplicationController Message-ID: Good morning rspec people! Still rspec nuby: I must do something wrong obviously. How can I spec about redirect_to at ApplicationController describe ApplicationController do it "method login_required should redirect to home path without login" do pending "I tried to use controller.login_required.should be_redirected and got NoMethodError with nil object didn't expect error." end end class ApplicationController < ActionController::Base # using it with before_filter def login_required # I took out everything except redirecting to make the point simple redirect_to home_path # tried also redirect_to "/" end end However the code does work manually testing with browser. Thanks for any help, Priit -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070816/9f4d994e/attachment.html From jonathan at parkerhill.com Wed Aug 15 16:02:31 2007 From: jonathan at parkerhill.com (Jonathan Linowes) Date: Wed, 15 Aug 2007 16:02:31 -0400 Subject: [rspec-users] restful named routes In-Reply-To: <70EE6770-3ABB-46F4-9195-AE566AD21A12@railsnewbie.com> References: <70EE6770-3ABB-46F4-9195-AE566AD21A12@railsnewbie.com> Message-ID: Hi, revisiting this issue, I feel I'm getting closer: describe CommentsController, "named routes" do before do @post = mock_model(Post, :id => 22) end it "should generate post_comments_path" do controller.post_comments_path(@post).should == "/posts/22/comments" end end results in: NoMethodError in 'CommentsController named routes should generate post_comments_path' protected method `post_comments_path' called for # Is there a way around this? Or how are other testing named routes? thanks linoj On May 29, 2007, at 7:52 AM, Scott Taylor wrote: > > On May 29, 2007, at 4:54 AM, Jonathan Linowes wrote: > >> >> - Is there a way to test named routes? > > I don't think there is a very clean & direct way (hopefully the > others on the list can correct me). The rspec rest generator > generates some code to check the routes, so you could use something > like that. > > Scott > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From court3nay at gmail.com Wed Aug 15 16:30:04 2007 From: court3nay at gmail.com (Courtenay) Date: Wed, 15 Aug 2007 13:30:04 -0700 Subject: [rspec-users] nuby: how spec redirect_to at ApplicationController In-Reply-To: References: Message-ID: <4b430c8f0708151330n54b669f5hbf547eeac0e1b84a@mail.gmail.com> On 8/15/07, Priit Tamboom wrote: > Good morning rspec people! > > Still rspec nuby: I must do something wrong obviously. > > How can I spec about redirect_to at ApplicationController > > describe ApplicationController do > it "method login_required should redirect to home path without login" do heh. "it" is so out of place here :) > pending "I tried to use > controller.login_required.should be_redirected > and got NoMethodError with nil object didn't expect error." > end > end > like controller.should_receive(:redirect_to) controller.send :login_required ?? or controller.should_receive(:current_user).and_return(nil) get :foo response.should redirect_to(...) > class ApplicationController < ActionController::Base > # using it with before_filter > def login_required > # I took out everything except redirecting to make the point simple > redirect_to home_path # tried also redirect_to "/" > end > end > > However the code does work manually testing with browser. > > Thanks for any help, > Priit > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Wed Aug 15 16:48:09 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 15 Aug 2007 16:48:09 -0400 Subject: [rspec-users] nuby: how spec redirect_to at ApplicationController In-Reply-To: <4b430c8f0708151330n54b669f5hbf547eeac0e1b84a@mail.gmail.com> References: <4b430c8f0708151330n54b669f5hbf547eeac0e1b84a@mail.gmail.com> Message-ID: <57c63afe0708151348j6dfa6cf6nb14ccf4d055d3d30@mail.gmail.com> On 8/15/07, Courtenay wrote: > On 8/15/07, Priit Tamboom wrote: > > describe ApplicationController do > > it "method login_required should redirect to home path without login" do > > heh. "it" is so out of place here :) I agree. The goal is to describe behaviours of objects, not methods. So, I'd write: it "should redirect anonymous user to home path" Cheers, David From joevandyk at gmail.com Thu Aug 16 02:08:35 2007 From: joevandyk at gmail.com (Joe Van Dyk) Date: Wed, 15 Aug 2007 23:08:35 -0700 Subject: [rspec-users] Mocking a non-existent method Message-ID: I don't like this: i = mock(Integer) i.should_receive(:asdfasdf).and_return('foo') puts i.asdfasdf Shouldn't rspec check to see that :asdfasdf is a valid message to be sending Integer? Joe From steve.tooke at gmail.com Thu Aug 16 07:57:40 2007 From: steve.tooke at gmail.com (Steve Tooke) Date: Thu, 16 Aug 2007 12:57:40 +0100 Subject: [rspec-users] ActsAsList specs In-Reply-To: <4b430c8f0708151122y50a361c8y5f23cf1c6d838e72@mail.gmail.com> References: <78d462040708150452m747ae9d0k10aef7ba208af6db@mail.gmail.com> <4b430c8f0708151122y50a361c8y5f23cf1c6d838e72@mail.gmail.com> Message-ID: <78d462040708160457g65d4a87flf875215e70cb40ff@mail.gmail.com> Hmm that's true. If the acts_as_list implementation changed, or is removed then this isn't going to work. But you don't really want to go down the rabbit warren of checking that the whole of the acts_as_list implementation works as expected, as presumably that's already tested. Perhaps I'm just being over complicated, and you could just mock the call to acts_as_list? Of course that still wouldn't guard against the acts_as_list behaviour changing to something that doesn't match what you were trying to achieve. Thanks, more to think about! On 8/15/07, Courtenay wrote: > On 8/15/07, Steve Tooke wrote: > > Hi, > > > > How are people specifying models which act_as_list? > > > > I'm thinking that it would be possible to check that acts_as_list > > instance methods have been added to a class using something like this: > > You're specing the code not the behavior. > This will make double-work if you want to change anything. > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From zach.dennis at gmail.com Thu Aug 16 10:11:47 2007 From: zach.dennis at gmail.com (Zach Dennis) Date: Thu, 16 Aug 2007 10:11:47 -0400 Subject: [rspec-users] expect_render, why does there need to be a warning In-Reply-To: <57c63afe0708151118i36a45934m1b891f67d5dac5ed@mail.gmail.com> References: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> <85d99afe0708140701w4fadd922i5868c962bacfb0fc@mail.gmail.com> <57c63afe0708142041y55efc047m7230f01cd0a26e3e@mail.gmail.com> <85d99afe0708150722x31a5b3fev117546f1c60617eb@mail.gmail.com> <57c63afe0708150728p633fcda1k7401ce89a5429de7@mail.gmail.com> <85d99afe0708151009oef2bde8jc289dc721dcb6812@mail.gmail.com> <57c63afe0708151118i36a45934m1b891f67d5dac5ed@mail.gmail.com> Message-ID: <85d99afe0708160711x62348ea9ocafc1f39b3d8e26@mail.gmail.com> > > > > If i have a view that calls "render :partial => 'foo'" and I don't use > > expect_render I want it to yell at me saying an unexpected call was > > made on the template. > > There's nothing else in rspec_on_rails that yells at you because you > don't like to organize your specs the way rspec thinks they should be > organized, so I definitely wouldn't support this being default > behaviour. It was worth a shot. > > I could see, maybe, the possibility of having a command like > disallow_unexpected_renders or something like that, but I honestly > don't see that much value in it in return for the additional > complexity (didn't you start by saying this was too complex already?). To summarize for anyone else reading this or possibly picking it up in an archive down the road. I was wanting to have a one to one, view to spec. If I had a template called "show.html.erb" I want a "show.html.erb_spec.rb". If "show" had an inline call to render the partial "foo" I want to have a "_foo.html.erb_spec.rb" to test that partial. The one way I see how this can work is to have rspec_on_rails treat all inline render calls as expectations. This would result in a "unexpected call to render :partial => 'foo'" when I ran my "show" spec if I didn't have an "expect_render :partial => 'foo'" line. I do not want to be able to test the contents of the partial "foo" inside of my "show" spec. The reasons I do not want: - possibly multiple view specs testing the same partial - possibly multiple places for each partial to be tested, I'd rather make it easy to know where to go when updating a view and its spec - to add time for a developer having to search for what view a partial is being rendered in and then checking to see if that view's spec is testing the contents of the partial I do want: - consistency, expect_render is an expectation, let it be consistent with how expectations work, I should not get a passing test by potentially rendering the wrong thing - ease of maintainability and readability (which I see a single location is easier to maintain and read then potentially multiple spots) I see the convention of one view to one spec adding more value then it takes away. I may be a little to hardcore though, I also think that "integrate_views" in controller specs should just go away. > > I understand that you DO see value in this, and I'd encourage you to > write a plugin that makes this work the way you want and feel free to > publish it. > I think I'll have to give that a try. Thanks David, Zach From zach.dennis at gmail.com Thu Aug 16 10:17:30 2007 From: zach.dennis at gmail.com (Zach Dennis) Date: Thu, 16 Aug 2007 10:17:30 -0400 Subject: [rspec-users] undefined method `mock_model' for [RSpec example]:# Message-ID: <85d99afe0708160717w33a9ee7eybe57a55fcbd72455@mail.gmail.com> I am getting: undefined method `mock_model' for [RSpec example]:# with my view specs after upgrading to 1.0.8. Is anyone else seeing this? To isolate the message I did the following setup: - create new rails project (with edge) - installed rspec and rspec_on_rails - ran rake spec - ran script/generate rspec_scaffold products - tried to run a builtin view spec Zach From dchelimsky at gmail.com Thu Aug 16 10:32:02 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 16 Aug 2007 10:32:02 -0400 Subject: [rspec-users] undefined method `mock_model' for [RSpec example]:# In-Reply-To: <85d99afe0708160717w33a9ee7eybe57a55fcbd72455@mail.gmail.com> References: <85d99afe0708160717w33a9ee7eybe57a55fcbd72455@mail.gmail.com> Message-ID: <57c63afe0708160732s365df56bwfbbdca70dc5bafde@mail.gmail.com> On 8/16/07, Zach Dennis wrote: > I am getting: > undefined method `mock_model' for [RSpec example]:# The fact that it says [RSpec example] means that it's not the right class for a view spec. The plugin knows how to create the right class based on one of two things: If the file is below /spec/views/ or describe "...", :behaviour_type => :view do ... If the spec you're running satisfies either of these, you shouldn't be seeing this. > > with my view specs after upgrading to 1.0.8. Is anyone else seeing this? > > To isolate the message I did the following setup: > > - create new rails project (with edge) > - installed rspec and rspec_on_rails > - ran rake spec > - ran script/generate rspec_scaffold products > - tried to run a builtin view spec When you say "builtin view spec," do you mean one that was generated by running the rspec_scaffold generator? > > Zach > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Thu Aug 16 11:08:37 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 16 Aug 2007 11:08:37 -0400 Subject: [rspec-users] expect_render, why does there need to be a warning In-Reply-To: <85d99afe0708160711x62348ea9ocafc1f39b3d8e26@mail.gmail.com> References: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> <85d99afe0708140701w4fadd922i5868c962bacfb0fc@mail.gmail.com> <57c63afe0708142041y55efc047m7230f01cd0a26e3e@mail.gmail.com> <85d99afe0708150722x31a5b3fev117546f1c60617eb@mail.gmail.com> <57c63afe0708150728p633fcda1k7401ce89a5429de7@mail.gmail.com> <85d99afe0708151009oef2bde8jc289dc721dcb6812@mail.gmail.com> <57c63afe0708151118i36a45934m1b891f67d5dac5ed@mail.gmail.com> <85d99afe0708160711x62348ea9ocafc1f39b3d8e26@mail.gmail.com> Message-ID: <57c63afe0708160808i266891a3me7c8d24da022b5cd@mail.gmail.com> On 8/16/07, Zach Dennis wrote: > > > > > > If i have a view that calls "render :partial => 'foo'" and I don't use > > > expect_render I want it to yell at me saying an unexpected call was > > > made on the template. > > > > There's nothing else in rspec_on_rails that yells at you because you > > don't like to organize your specs the way rspec thinks they should be > > organized, so I definitely wouldn't support this being default > > behaviour. > > It was worth a shot. > > > > > I could see, maybe, the possibility of having a command like > > disallow_unexpected_renders or something like that, but I honestly > > don't see that much value in it in return for the additional > > complexity (didn't you start by saying this was too complex already?). > > To summarize for anyone else reading this or possibly picking it up in > an archive down the road. > > I was wanting to have a one to one, view to spec. You can have that. But you don't have to. It's your choice. > If I had a template > called "show.html.erb" I want > a "show.html.erb_spec.rb". If "show" had an inline call to render the > partial "foo" I want to have > a "_foo.html.erb_spec.rb" to test that partial. There is nothing stopping you from doing this. > The one way I see how > this can work is to have > rspec_on_rails treat all inline render calls as expectations. Again, there's nothing stopping you from doing this. There's nothing forcing you to either. That's an important point. >This > would result in a > "unexpected call to render :partial => 'foo'" when I ran my "show" > spec if I didn't have an "expect_render :partial => 'foo'" > line. > > I do not want to be able to test the contents of the partial "foo" > inside of my "show" spec. If you're actually driving your design with the specs, which is what rspec is designed to encourage, the way you do it is this: Spec-drive a view. At the end of several red/green/refactor cycles you'll likely have one spec and one view. Spec-drive another view. Recognize that both views display some of the same stuff. Extract the common stuff into a partial. This last step is refactoring: changing the design without changing the behaviour. Refactoring, ideally, should not require changing any specs. The way things are currently, after you extract the partial, you can run the specs and they pass. With rspec forcing things to work the way you seem to want it to, you couldn't change the design without causing failing specs. After you've refactored the design, extracting the partial, perhaps you want to restructure the specs so that there is only one spec for the partial. At this point, you create a new spec for the partial, moving the examples from one of the two view specs to the partial spec, and then remove the duplicate examples from the other. BDD is a process, not a result. The tools should support the process. What you're asking for would stand in the way of this process. > The reasons > I do not want: > - possibly multiple view specs testing the same partial > - possibly multiple places for each partial to be tested, I'd rather > make it easy to know where to go when updating a view and its spec > - to add time for a developer having to search for what view a > partial is being rendered in and then checking to see if that view's > spec is testing the contents of the partial > > I do want: > - consistency, expect_render is an expectation, let it be consistent > with how expectations work, I should not get a passing test by > potentially rendering the wrong thing How can this happen if you're writing the specs first? > - ease of maintainability and readability (which I see a single > location is easier to maintain and read then potentially multiple > spots) Again, there's nothing stopping you from getting to this. > I see the convention of one view to one spec adding more value then it > takes away. There's a difference between convention and handcuffs. What you are proposing is handcuffs. There is absolutely nothing stopping you from following this convention. > I may be a little to hardcore though, I also think that > "integrate_views" in controller specs should just go away. Again, while RSpec is opinionated in some ways, it also needs to be flexible. Obviously there are boundaries to this, but you and I seem to have these boundaries in different places. The fact that the default is to not integrate views guides you in the direction of strict isolation. But with strict isolation comes a cost, which is that you can get all your component specs working and the app doesn't run because you never had any integration tests. For some, using integrate_views takes the place of having integration tests. Although this is not the approach that I like to take, it is a perfectly reasonable approach and I think it would be wrong for rspec to disallow this. > > I understand that you DO see value in this, and I'd encourage you to > > write a plugin that makes this work the way you want and feel free to > > publish it. > > > > I think I'll have to give that a try. Thanks David, > > Zach > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From zach.dennis at gmail.com Thu Aug 16 13:01:06 2007 From: zach.dennis at gmail.com (Zach Dennis) Date: Thu, 16 Aug 2007 13:01:06 -0400 Subject: [rspec-users] undefined method `mock_model' for [RSpec example]:# In-Reply-To: <57c63afe0708160732s365df56bwfbbdca70dc5bafde@mail.gmail.com> References: <85d99afe0708160717w33a9ee7eybe57a55fcbd72455@mail.gmail.com> <57c63afe0708160732s365df56bwfbbdca70dc5bafde@mail.gmail.com> Message-ID: <85d99afe0708161001w371a6effsea9f7827943eaf39@mail.gmail.com> On 8/16/07, David Chelimsky wrote: > On 8/16/07, Zach Dennis wrote: > > I am getting: > > undefined method `mock_model' for [RSpec example]:# > > The fact that it says [RSpec example] means that it's not the right > class for a view spec. The plugin knows how to create the right class > based on one of two things: > > If the file is below /spec/views/ > > or > > describe "...", :behaviour_type => :view do > ... > > If the spec you're running satisfies either of these, you shouldn't be > seeing this. > > > > > with my view specs after upgrading to 1.0.8. Is anyone else seeing this? > > > > To isolate the message I did the following setup: > > > > - create new rails project (with edge) > > - installed rspec and rspec_on_rails > > - ran rake spec > > - ran script/generate rspec_scaffold products > > - tried to run a builtin view spec > > When you say "builtin view spec," do you mean one that was generated > by running the rspec_scaffold generator? > One that was generated by the rspec_scaffold generator, Zach From jerry.west at ntlworld.com Thu Aug 16 13:04:35 2007 From: jerry.west at ntlworld.com (Jerry West) Date: Thu, 16 Aug 2007 18:04:35 +0100 Subject: [rspec-users] restful named routes In-Reply-To: References: <70EE6770-3ABB-46F4-9195-AE566AD21A12@railsnewbie.com> Message-ID: <003001c7e027$8ff4f410$370aa8c0@CherithSimmons.local> try this: controller.send(:post_comments_path, @post).should == "/posts/22/comments" Rgds, Jerry -----Original Message----- From: rspec-users-bounces at rubyforge.org [mailto:rspec-users-bounces at rubyforge.org] On Behalf Of Jonathan Linowes Sent: 15 August 2007 21:03 To: rspec-users Subject: [rspec-users] restful named routes Hi, revisiting this issue, I feel I'm getting closer: describe CommentsController, "named routes" do before do @post = mock_model(Post, :id => 22) end it "should generate post_comments_path" do controller.post_comments_path(@post).should == "/posts/22/comments" end end results in: NoMethodError in 'CommentsController named routes should generate post_comments_path' protected method `post_comments_path' called for # Is there a way around this? Or how are other testing named routes? thanks linoj On May 29, 2007, at 7:52 AM, Scott Taylor wrote: > > On May 29, 2007, at 4:54 AM, Jonathan Linowes wrote: > >> >> - Is there a way to test named routes? > > I don't think there is a very clean & direct way (hopefully the others > on the list can correct me). The rspec rest generator generates some > code to check the routes, so you could use something like that. > > Scott > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users _______________________________________________ rspec-users mailing list rspec-users at rubyforge.org http://rubyforge.org/mailman/listinfo/rspec-users From dchelimsky at gmail.com Thu Aug 16 13:31:13 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 16 Aug 2007 13:31:13 -0400 Subject: [rspec-users] undefined method `mock_model' for [RSpec example]:# In-Reply-To: <85d99afe0708161001w371a6effsea9f7827943eaf39@mail.gmail.com> References: <85d99afe0708160717w33a9ee7eybe57a55fcbd72455@mail.gmail.com> <57c63afe0708160732s365df56bwfbbdca70dc5bafde@mail.gmail.com> <85d99afe0708161001w371a6effsea9f7827943eaf39@mail.gmail.com> Message-ID: <57c63afe0708161031i426e5edeo1f19058baf2fc028@mail.gmail.com> On 8/16/07, Zach Dennis wrote: > On 8/16/07, David Chelimsky wrote: > > On 8/16/07, Zach Dennis wrote: > > > I am getting: > > > undefined method `mock_model' for [RSpec example]:# > > > > The fact that it says [RSpec example] means that it's not the right > > class for a view spec. The plugin knows how to create the right class > > based on one of two things: > > > > If the file is below /spec/views/ > > > > or > > > > describe "...", :behaviour_type => :view do > > ... > > > > If the spec you're running satisfies either of these, you shouldn't be > > seeing this. > > > > > > > > with my view specs after upgrading to 1.0.8. Is anyone else seeing this? > > > > > > To isolate the message I did the following setup: > > > > > > - create new rails project (with edge) > > > - installed rspec and rspec_on_rails > > > - ran rake spec > > > - ran script/generate rspec_scaffold products > > > - tried to run a builtin view spec > > > > When you say "builtin view spec," do you mean one that was generated > > by running the rspec_scaffold generator? > > > > One that was generated by the rspec_scaffold generator, Sorry man, it should be working fine. I'm not having that experience personally - is anybody else? Zach - what platform are you on? > > Zach > From zach.dennis at gmail.com Thu Aug 16 14:01:06 2007 From: zach.dennis at gmail.com (Zach Dennis) Date: Thu, 16 Aug 2007 14:01:06 -0400 Subject: [rspec-users] expect_render, why does there need to be a warning In-Reply-To: <57c63afe0708160808i266891a3me7c8d24da022b5cd@mail.gmail.com> References: <85d99afe0708132158ua34f8beq61bd3f3a03c3eb14@mail.gmail.com> <57c63afe0708132316m467f4af7y6fc019096bff2d98@mail.gmail.com> <85d99afe0708140701w4fadd922i5868c962bacfb0fc@mail.gmail.com> <57c63afe0708142041y55efc047m7230f01cd0a26e3e@mail.gmail.com> <85d99afe0708150722x31a5b3fev117546f1c60617eb@mail.gmail.com> <57c63afe0708150728p633fcda1k7401ce89a5429de7@mail.gmail.com> <85d99afe0708151009oef2bde8jc289dc721dcb6812@mail.gmail.com> <57c63afe0708151118i36a45934m1b891f67d5dac5ed@mail.gmail.com> <85d99afe0708160711x62348ea9ocafc1f39b3d8e26@mail.gmail.com> <57c63afe0708160808i266891a3me7c8d24da022b5cd@mail.gmail.com> Message-ID: <85d99afe0708161101r46bba2e4wde5fd03131114b68@mail.gmail.com> > BDD is a process, not a result. The tools should support the process. > What you're asking for would stand in the way of this process. If there is a "disallow_unexpected_renders" that does not stand in the way of the process. It gives people a choice, much like integrate_views gives people a choice. Although I see people using integrate_views are disabling themselves, because they are probably writing horrible specs. Using controller specs to double as view specs to make up for not having integration specs is a big problem in itself. And I see disallow_unexpected_renders enabling themselves to not test the same partials in more then one spot. I get your point though, it's not getting in. Thats ok, Zach From mailing_lists at railsnewbie.com Thu Aug 16 15:13:31 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Thu, 16 Aug 2007 15:13:31 -0400 Subject: [rspec-users] Extra Options to Heckle In-Reply-To: <8d961d900708150457w6a001d99t8b2ed18a55f0821b@mail.gmail.com> References: <8d961d900708150457w6a001d99t8b2ed18a55f0821b@mail.gmail.com> Message-ID: <22B3939A-EE9E-496C-AEF8-E6BB259B4B96@railsnewbie.com> On Aug 15, 2007, at 7:57 AM, aslak hellesoy wrote: > On 8/15/07, Scott Taylor wrote: >> >> I've tried running Heckle with rspec on some of my classes, but keep >> getting (what I believe to be) an infinite recursion. Is there some >> way to supply extra options to heckle via. rspec? >> > > Currently not. What options do you want to supply? > > Aslak Aslak, What would be the best format for heckle options (through OptionParser) via the spec-command? Scott From dchelimsky at gmail.com Fri Aug 17 02:59:27 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 17 Aug 2007 02:59:27 -0400 Subject: [rspec-users] Mocking a non-existent method In-Reply-To: References: Message-ID: <57c63afe0708162359p7fe41269ne359a2c7e0dfc669@mail.gmail.com> On 8/16/07, Joe Van Dyk wrote: > I don't like this: > > i = mock(Integer) > i.should_receive(:asdfasdf).and_return('foo') > puts i.asdfasdf > > > Shouldn't rspec check to see that :asdfasdf is a valid message to be > sending Integer? Put simply: no. That's what integration testing is for. > > Joe > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Fri Aug 17 03:03:25 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 17 Aug 2007 03:03:25 -0400 Subject: [rspec-users] ActsAsList specs In-Reply-To: <78d462040708160457g65d4a87flf875215e70cb40ff@mail.gmail.com> References: <78d462040708150452m747ae9d0k10aef7ba208af6db@mail.gmail.com> <4b430c8f0708151122y50a361c8y5f23cf1c6d838e72@mail.gmail.com> <78d462040708160457g65d4a87flf875215e70cb40ff@mail.gmail.com> Message-ID: <57c63afe0708170003s61e68d2u6db0b6bef7d007e6@mail.gmail.com> On 8/16/07, Steve Tooke wrote: > Hmm that's true. > > If the acts_as_list implementation changed, or is removed then this > isn't going to work. But you don't really want to go down the rabbit > warren of checking that the whole of the acts_as_list implementation > works as expected, as presumably that's already tested. > > Perhaps I'm just being over complicated, and you could just mock the > call to acts_as_list? > > Of course that still wouldn't guard against the acts_as_list behaviour > changing to something that doesn't match what you were trying to > achieve. Exactly! You should spec the specific behaviour that YOUR application needs. acts_as_list likely provides more than you are using. If you focus your specs on that which your application needs, then you are safe when you update rails, plugins, etc, because if something changes that breaks what your application relies on, then you'll be alerted by failing specs. If whatever changes appear don't affect what your application cares about, then no problem. > > Thanks, more to think about! > > On 8/15/07, Courtenay wrote: > > On 8/15/07, Steve Tooke wrote: > > > Hi, > > > > > > How are people specifying models which act_as_list? > > > > > > I'm thinking that it would be possible to check that acts_as_list > > > instance methods have been added to a class using something like this: > > > > You're specing the code not the behavior. > > This will make double-work if you want to change anything. > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Fri Aug 17 04:46:18 2007 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Fri, 17 Aug 2007 04:46:18 -0400 Subject: [rspec-users] Mocking a non-existent method In-Reply-To: <57c63afe0708162359p7fe41269ne359a2c7e0dfc669@mail.gmail.com> References: <57c63afe0708162359p7fe41269ne359a2c7e0dfc669@mail.gmail.com> Message-ID: <3EA3375E-72FD-4A10-BD0F-C748B7465E69@railsnewbie.com> On Aug 17, 2007, at 2:59 AM, David Chelimsky wrote: > On 8/16/07, Joe Van Dyk wrote: >> I don't like this: >> >> i = mock(Integer) >> i.should_receive(:asdfasdf).and_return('foo') >> puts i.asdfasdf >> >> >> Shouldn't rspec check to see that :asdfasdf is a valid message to be >> sending Integer? > > Put simply: no. That's what integration testing is for. Speaking of which, how is the rbehave integration going? Or are you done with it? Scott From dchelimsky at gmail.com Fri Aug 17 07:56:51 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 17 Aug 2007 07:56:51 -0400 Subject: [rspec-users] Mocking a non-existent method In-Reply-To: <3EA3375E-72FD-4A10-BD0F-C748B7465E69@railsnewbie.com> References: <57c63afe0708162359p7fe41269ne359a2c7e0dfc669@mail.gmail.com> <3EA3375E-72FD-4A10-BD0F-C748B7465E69@railsnewbie.com> Message-ID: <57c63afe0708170456k19f960f3r76fa9a8dcc208996@mail.gmail.com> On 8/17/07, Scott Taylor wrote: > > On Aug 17, 2007, at 2:59 AM, David Chelimsky wrote: > > > On 8/16/07, Joe Van Dyk wrote: > >> I don't like this: > >> > >> i = mock(Integer) > >> i.should_receive(:asdfasdf).and_return('foo') > >> puts i.asdfasdf > >> > >> > >> Shouldn't rspec check to see that :asdfasdf is a valid message to be > >> sending Integer? > > > > Put simply: no. That's what integration testing is for. > > Speaking of which, how is the rbehave integration going? Or are you > done with it? The import-rbehave branch is now fully functional (passing rake pre_commit). Just waiting to coordinate w/ Dan to merge it into trunk. Coming soon. > > Scott > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From jrich013 at gmail.com Fri Aug 17 14:45:03 2007 From: jrich013 at gmail.com (Justin Rich) Date: Fri, 17 Aug 2007 14:45:03 -0400 Subject: [rspec-users] map.with_options :path_prefix => ' Message-ID: Hello, I am getting a 'No route matches' error in rspec with routes that have a path_prefix composed by map.with_options. Rails recognizes the routes just fine and the site works, but I can't get the specs to pass unless I put the prefix in each individual route. Any help is appreciated. My foo model has a polymorphic owner which is what I want the path_prefix to represent, so my routes.rb has something like... map.with_options :controller => 'foos', :path_prefix => ':owner_type/:owner_id' do |foos| foos.new_foo '/foos/new', :action => 'new' foos.create_foo '/foos', :action => 'create', :conditions => {:method => :post} end And in the foos_controller_spec.rb file is something like... describe FoosController, 'on a GET to new' do it "should make a baby foo" do # some stuff get 'new', :owner_type => 'client', :owner_id => '1' # shoulda's woulda's and coulda's end end Thanks, Justin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070817/971ba700/attachment.html From omen.king at gmail.com Fri Aug 17 15:14:39 2007 From: omen.king at gmail.com (Andrew WC Brown) Date: Fri, 17 Aug 2007 15:14:39 -0400 Subject: [rspec-users] [rspec] looking for a simple refresher Message-ID: I've been off the rspec for a few months and I'm trying to get back on it. 1) Spec::Mocks::MockExpectationError in 'TicketsController handling POST /tickets should create a new ticket' Mock 'Ticket_1001' expected :new with ({}) once, but received it 0 times ./spec/controllers/tickets_controller_spec.rb:16: script/spec:4: class TicketsController < ApplicationController def new Ticket.new end end describe TicketsController, "handling POST /tickets" do before do @ticket = mock_model(Ticket, :to_param => '1', :save => true) Ticket.stub!(:new).and_return(@ticket) @params = {} end def do_post post :create, :ticket => @params end it "should create a new ticket" do @ticket.should_receive(:new).with(@params).and_return(@ticket) do_post end end Would someone provide with an explanation what I have to do to make this spec pass? Peepcode hasn't released their screen cast on rspecing controllers yet ='( -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20070817/61e34fc1/attachment.html From dchelimsky at gmail.com Fri Aug 17 15:17:29 2007 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 17 Aug 2007 15:17:29 -0400 Subject: [rspec-users] [rspec] looking for a simple refresher In-Reply-To: References: Message-ID: <57c63afe0708171217w1414f170ra4de1784e688b40b@mail.gmail.com> On 8/17/07, Andrew WC Brown wrote: > I've been off the rspec for a few months and I'm trying to get back on it. > > 1) > Spec::Mocks::MockExpectationError in 'TicketsController > handling POST /tickets should create a new ticket' > Mock 'Ticket_1001' expected :new with ({}) once, but received it 0 times > ./spec/controllers/tickets_controller_spec.rb:16: > script/spec:4: > > class TicketsController < ApplicationController > > def new > Ticket.new > end > > end > > describe TicketsController, "handling POST /tickets" do > > before do > @ticket = mock_model(Ticket, :to_param => '1', :save => true) > Ticket.stub!(:new).and_return(@ticket) > @params = {} > end > > def do_post > post :create, :ticket => @params > end > > it "should create a new ticket" do > > @ticket.should_receive(:new).with(@params).and_return(@ticket) This is telling the ticket object to expect new, but it's the Ticket class that will receive it: Ticket.should_receive(:new).with(@params).and_return(@ticket) That should do it. > do_post > end > > end > > Would someone provide with an explanation what I have to do to make this > spec pass? > Peepcode hasn't released their screen cast on rspecing controllers yet ='( > > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From cody at skidmore.us Fri Aug 17 15:23:58 2007 From: cody at skidmore.us (Cody P. Skidmore) Date: Fri, 17 Aug 2007 12:23:58 -0700 (PDT) Subject: [rspec-users] test Message-ID: <1937.216.167.174.73.1187378638.squirrel@webmail.skidmore.us> This is a test. I sent an email to the list earlier but it looks like no one received it... From cody at skidmore.us Fri Aug 17 10:09:34 2007 From: cody at skidmore.us (Cody P. Skidmore) Date: Fri, 17 Aug 2007 07:09:34 -0700 (PDT) Subject: [rspec-users] RSpec --format --html:/path/to/file.html Message-ID: <3756.216.167.174.73.1187359774.squirrel@webmail.skidmore.us> Greetings everyone. I'm learning RSpec and am pretty fresh to Ruby/Rails, but am so excited I can't help jumping in. I'm running before I can walk here. :-) Yesterday I tried outputting test results to HTML instead of colorized plain text. It looked like there were some entries in the change log for the 1.0.5 release allowing RSpec to do what I wanted. I tried adding a setting to spec.opts but it didn't work to say the least. Here's the change log entry: * The --out option is gone. Use --format html:path/to/my.html instead (or similar). 1. Does this do what I think it should? 2. where can I find documentation on using spec.opts? The command line help doesn't mention a "--format" option. It looks like CI::Reporter [could] output XML format but can it be used independently? I'm mining the documentation for related information but didn't find it so far. Thank you for your help in advance. From court3nay at gmail.com Fri Aug 17 17:31:43 2007 From: court3nay at gmail.com (Courtenay) Date: Fri, 17 Aug 2007 14:31:43 -0700 Subject: [rspec-users] should_receive, used in the wrong place? Message-ID: <4b430c8f0708171431y477d82a9s2a06356541470443@mail.gmail.com> What do you guys think of this: if someone calls should_receive outside of an "it" block, it warns you. before(:each) do @foo = Foo.new @foo.should_receive(:monkeys) end would warn you that you're setting an expectation in the wrong place, and that "stub" is correct when setting up objects. Opinions? courtenay From lancecarlson at gmail.com Fri Aug 17 17:34:09 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Fri, 17 Aug 2007 17:34:09 -0400 Subject: [rspec-users] should_receive, used in the wrong place? In-Reply-To: <4b430c8f0708171431y477d82a9s2a06356541470443@mail.gmail.com> References: <4b430c8f0708171431y477d82a9s2a06356541470443@mail.gmail.com> Message-ID: <49f64a900708171434s51cfadd7gaddb7570625bdf5c@mail.gmail.com> what about template.should_receive(:current_user)? I don't know if that's a bad idea to do that in the before(:each) but it's more convenient.. On 8/17/07, Courtenay wrote: > What do you guys think of this: if someone calls should_receive > outside of an "it" block, it warns you. > > before(:each) do > @foo = Foo.new > @foo.should_receive(:monkeys) > end > > would warn you that you're setting an expectation in the wrong place, > and that "stub" is correct when setting up objects. > > Opinions? > > > courtenay > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From court3nay at gmail.com Fri Aug 17 17:47:09 2007 From: court3nay at gmail.com (Courtenay) Date: Fri, 17 Aug 2007 14:47:09 -0700 Subject: [rspec-users] should_receive, used in the wrong place? In-Reply-To: <49f64a900708171434s51cfadd7gaddb7570625bdf5c@mail.gmail.com> References: <4b430c8f0708171431y477d82a9s2a06356541470443@mail.gmail.com> <49f64a900708171434s51cfadd7gaddb7570625bdf5c@mail.gmail.com> Message-ID: <4b430c8f0708171447g72fa1ddbvff6515c2169aabad@mail.gmail.com> That's exactly my point; enforcing the difference between should_receive vs stub! On 8/17/07, Lance Carlson wrote: > what about template.should_receive(:current_user)? > > I don't know if that's a bad idea to do that in the before(:each) but > it's more convenient.. > > On 8/17/07, Courtenay wrote: > > What do you guys think of this: if someone calls should_receive > > outside of an "it" block, it warns you. > > > > before(:each) do > > @foo = Foo.new > > @foo.should_receive(:monkeys) > > end > > > > would warn you that you're setting an expectation in the wrong place, > > and that "stub" is correct when setting up objects. > > > > Opinions? > > > > > > courtenay > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lancecarlson at gmail.com Fri Aug 17 17:48:02 2007 From: lancecarlson at gmail.com (Lance Carlson) Date: Fri, 17 Aug 2007 17:48:02 -0400 Subject: [rspec-users] should_receive, used in the wrong place? In-Reply-To: <4b430c8f0708171447g72fa1ddbvff6515c2169aabad@mail.gmail.com> References: <4b430c8f0708171431y477d82a9s2a06356541470443@mail.gmail.com> <49f64a900708171434s51cfadd7gaddb7570625bdf5c@mail.gmail.com> <4b430c8f0708171447g72fa1ddbvff6515c2169aabad@mail.gmail.com> Message-ID: <49f64a900708171448x50b2fefdkfe46b22e288a0938@mail.gmail.com> I agree :) On 8/17/07, Courtenay wrote: > That's exactly my point; enforcing the difference between > should_receive vs stub! > > On 8/17/07, Lance Carlson

Editing artist

Editing artist

Editing artist

Editing artist

Editing artist

Editing artist

Editing artist

Editing artist

Editing artist

<%=h advert.title %>