) in the views breaks your specs, you're probably speccing wrong things. I always try to spec for logical things, not the actual tags, for example. That is not always an option, of course. //jarkko -- Jarkko Laine http://jlaine.net http://dotherightthing.com http://www.railsecommerce.com http://odesign.fi -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 2417 bytes Desc: not available Url : http://rubyforge.org/pipermail/rspec-users/attachments/20080219/774ab30e/attachment.bin From lists at ruby-forum.com Tue Feb 19 10:32:19 2008 From: lists at ruby-forum.com (Jennifer Lindner) Date: Tue, 19 Feb 2008 16:32:19 +0100 Subject: [rspec-users] ZenTest-3.9.0 incompatible with RSpec-1.1.2 In-Reply-To: References: <57c63afe0801310325w3b44adfhf829b54c123a9b33@mail.gmail.com> <57c63afe0801311214o2ea1903ao1163bbd95ec3a7ea@mail.gmail.com> <709E5FF1-93AF-4632-BF29-39591731B5A0@matt-darby.com> Message-ID: <420bf25b6300ef5926938b3db695b7ee@ruby-forum.com> David Chelimsky wrote: > Did you install both the rspec and rspec_on_rails 1.1.3 plugins? hey i've updated the plugins and still get the error: loading autotest/rails_rspec Autotest style autotest/rails_rspec doesn't seem to exist. Aborting. i'm running ruby 1.8.5 and rails 1.2.3, ZenTest 3.9.1 and rspec 1.1.3. i reinstalled the plugins and then updated the gem too. any other ideas? maybe i should just try going back down to ZenTest 3.8.0 and rspec 1.1.2 and restarting machine. -- Posted via http://www.ruby-forum.com/. From jarkko at jlaine.net Tue Feb 19 10:42:22 2008 From: jarkko at jlaine.net (Jarkko Laine) Date: Tue, 19 Feb 2008 17:42:22 +0200 Subject: [rspec-users] spec_server requiring absolute paths (and autotest breaking) Message-ID: <75AEFAFF-6CAD-4A04-8270-85C8F51EF928@jlaine.net> rspec and rspec_on_rails rev 3316, ZenTest 3.9.1 When run through spec_server, running spec fails if the spec file is not specified with an absolute path: Probutanol:koulutusweb jarkko$ script/spec --options spec/spec.opts `pwd`/spec/models/address_spec.rb ...... Finished in 0.166251 seconds 6 examples, 0 failures Probutanol:koulutusweb jarkko$ script/spec --options spec/spec.opts spec/models/address_spec.rb (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/runner/ options.rb:197:in `files_to_load': File or directory not found: spec/ models/address_spec.rb (RuntimeError) from (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/ runner/options.rb:189:in `each' from (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/ runner/options.rb:189:in `files_to_load' In the same way, autotest fails with spec_server: Probutanol:koulutusweb jarkko$ autotest loading autotest/rails_rspec /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby -S script/spec -O spec/spec.opts spec/controllers/ activations_controller_spec.rb spec/helpers/clients_helper_spec.rb [a bunch of files omitted] spec/models/enrollment_notifier_spec.rb spec/views/clients/ email_form.html.erb_spec.rb (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/runner/ options.rb:5:in `mtime': Not a directory - spec/models/address_spec.rb (Errno::ENOTDIR) from (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/ runner/options.rb:5 from (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/ runner/options.rb:251:in `sort' from (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/ runner/options.rb:251:in `sorted_files' Any ideas why spec_server has lost its marbles? Without the --drb option autotest runs fine. Cheers, //jarkko -- Jarkko Laine http://jlaine.net http://dotherightthing.com http://www.railsecommerce.com http://odesign.fi -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 2417 bytes Desc: not available Url : http://rubyforge.org/pipermail/rspec-users/attachments/20080219/14d880fc/attachment.bin From dchelimsky at gmail.com Tue Feb 19 10:57:25 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 19 Feb 2008 10:57:25 -0500 Subject: [rspec-users] spec_server requiring absolute paths (and autotest breaking) In-Reply-To: <75AEFAFF-6CAD-4A04-8270-85C8F51EF928@jlaine.net> References: <75AEFAFF-6CAD-4A04-8270-85C8F51EF928@jlaine.net> Message-ID: <57c63afe0802190757m40197549n1b2e8570fab2df66@mail.gmail.com> On Feb 19, 2008 10:42 AM, Jarkko Laine wrote: > rspec and rspec_on_rails rev 3316, ZenTest 3.9.1 > > When run through spec_server, running spec fails if the spec file is > not specified with an absolute path: > > Probutanol:koulutusweb jarkko$ script/spec --options spec/spec.opts > `pwd`/spec/models/address_spec.rb > ...... > > Finished in 0.166251 seconds > > 6 examples, 0 failures > Probutanol:koulutusweb jarkko$ script/spec --options spec/spec.opts > spec/models/address_spec.rb > (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/runner/ > options.rb:197:in `files_to_load': File or directory not found: spec/ > models/address_spec.rb (RuntimeError) > from (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/ > runner/options.rb:189:in `each' > from (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/ > runner/options.rb:189:in `files_to_load' > > > In the same way, autotest fails with spec_server: > > Probutanol:koulutusweb jarkko$ autotest > loading autotest/rails_rspec > /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby -S > script/spec -O spec/spec.opts spec/controllers/ > activations_controller_spec.rb spec/helpers/clients_helper_spec.rb > [a bunch of files omitted] > spec/models/enrollment_notifier_spec.rb spec/views/clients/ > email_form.html.erb_spec.rb > (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/runner/ > options.rb:5:in `mtime': Not a directory - spec/models/address_spec.rb > (Errno::ENOTDIR) > from (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/ > runner/options.rb:5 > from (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/ > runner/options.rb:251:in `sort' > from (druby://localhost:8989) ./../vendor/plugins/rspec/lib/spec/ > runner/options.rb:251:in `sorted_files' > > > Any ideas why spec_server has lost its marbles? Without the --drb > option autotest runs fine. Did this just start happening for you? If so, it could be the patch I applied in r3310. Would you mind checking out 3309 and seeing if you still have this problem? > > Cheers, > //jarkko > > -- > Jarkko Laine > http://jlaine.net > http://dotherightthing.com > http://www.railsecommerce.com > http://odesign.fi > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From jarkko at jlaine.net Tue Feb 19 11:27:06 2008 From: jarkko at jlaine.net (Jarkko Laine) Date: Tue, 19 Feb 2008 18:27:06 +0200 Subject: [rspec-users] spec_server requiring absolute paths (and autotest breaking) In-Reply-To: <57c63afe0802190757m40197549n1b2e8570fab2df66@mail.gmail.com> References: <75AEFAFF-6CAD-4A04-8270-85C8F51EF928@jlaine.net> <57c63afe0802190757m40197549n1b2e8570fab2df66@mail.gmail.com> Message-ID: <87102E9E-638A-4359-9DFC-AF61874BDA72@jlaine.net> On 19.2.2008, at 17.57, David Chelimsky wrote: > Did this just start happening for you? If so, it could be the patch I > applied in r3310. Would you mind checking out 3309 and seeing if you > still have this problem? That's it. However, with 3309 it seems that autotest doesn't really run through drb at all since it runs the same whether or not the spec_server is running. Yeah, I know that was the reason for the patch. //jarkko -- Jarkko Laine http://jlaine.net http://dotherightthing.com http://www.railsecommerce.com http://odesign.fi -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 2417 bytes Desc: not available Url : http://rubyforge.org/pipermail/rspec-users/attachments/20080219/881f102a/attachment.bin From jarkko at jlaine.net Tue Feb 19 12:08:01 2008 From: jarkko at jlaine.net (Jarkko Laine) Date: Tue, 19 Feb 2008 19:08:01 +0200 Subject: [rspec-users] spec_server requiring absolute paths (and autotest breaking) In-Reply-To: <57c63afe0802190757m40197549n1b2e8570fab2df66@mail.gmail.com> References: <75AEFAFF-6CAD-4A04-8270-85C8F51EF928@jlaine.net> <57c63afe0802190757m40197549n1b2e8570fab2df66@mail.gmail.com> Message-ID: <049954B4-A032-40D9-9D6C-3640135D2506@jlaine.net> On 19.2.2008, at 17.57, David Chelimsky wrote: > Did this just start happening for you? If so, it could be the patch I > applied in r3310. Would you mind checking out 3309 and seeing if you > still have this problem? Ok, found out the reason. I started spec_server from within the script directory and it only works correctly if you start it from the root of your Rails app. Gotcha. That said, now that autotest runs via drb, it's vastly (like 50%) slower than without it, doesn't respect the --colour option in spec.opts and causes failures that don't happen when running just plain autotest. All of them seem to be related to methods being run more times than they are supposed to. Examples: Mock 'Location_18994' expected :valid? with (any args) once, but received it twice expected: "Barney Hops doesn't have the required competency (MBA) to teach this class", got: ["Barney Hops doesn't have the required competency (MBA) to teach this class", "Barney Hops doesn't have the required competency (MBA) to teach this class"] Mock 'Enrollment' expected :on_waiting_list? with (any args) twice, but received it 3 times //jarkko -- Jarkko Laine http://jlaine.net http://dotherightthing.com http://www.railsecommerce.com http://odesign.fi -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 2417 bytes Desc: not available Url : http://rubyforge.org/pipermail/rspec-users/attachments/20080219/d0305d7a/attachment-0001.bin From andy at r210.com Tue Feb 19 12:12:50 2008 From: andy at r210.com (Andy Leak) Date: Tue, 19 Feb 2008 12:12:50 -0500 Subject: [rspec-users] ZenTest-3.9.0 incompatible with RSpec-1.1.2 In-Reply-To: <420bf25b6300ef5926938b3db695b7ee@ruby-forum.com> Message-ID: I got it working - using: - Cygwin on XP - Cygwin Ruby 1.8.6 - ZenTest 3.9.1 and RSpec 1.1.3 -----Original Message----- From: rspec-users-bounces at rubyforge.org [mailto:rspec-users-bounces at rubyforge.org] On Behalf Of Jennifer Lindner Sent: Tuesday, February 19, 2008 7:32 AM To: rspec-users at rubyforge.org Subject: Re: [rspec-users] ZenTest-3.9.0 incompatible with RSpec-1.1.2 David Chelimsky wrote: > Did you install both the rspec and rspec_on_rails 1.1.3 plugins? hey i've updated the plugins and still get the error: loading autotest/rails_rspec Autotest style autotest/rails_rspec doesn't seem to exist. Aborting. i'm running ruby 1.8.5 and rails 1.2.3, ZenTest 3.9.1 and rspec 1.1.3. i reinstalled the plugins and then updated the gem too. any other ideas? maybe i should just try going back down to ZenTest 3.8.0 and rspec 1.1.2 and restarting machine. -- Posted via http://www.ruby-forum.com/. _______________________________________________ rspec-users mailing list rspec-users at rubyforge.org http://rubyforge.org/mailman/listinfo/rspec-users From andy at r210.com Tue Feb 19 12:22:45 2008 From: andy at r210.com (Andy Leak) Date: Tue, 19 Feb 2008 12:22:45 -0500 Subject: [rspec-users] Playing Sounds with Autotest/RSpec on Cygwin Message-ID: I've read about integrating Growl with Autotest/RSpec to display test results. For cygwin users - here is a snippet that will play a sound after autotest runs. Add the code below to your ~/.autotest file. Modify the path of the .wav file to the sounds you want to play on your system. Cheers, Andy vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv Module AddSoundtoAutoTestforCygwin Autotest.add_hook :ran_command do |at| results = [at.results].flatten.join("\n") output = results.slice(/(\d+)\s+examples?,\s*(\d+)\s+failures?(,\s*(\d+)\s+not implemented)?/) if output if $~[2].to_i > 0 `cat /cygdrive/c/i386/ringout.wav > /dev/dsp` # failure else `cat /cygdrive/c/i386/chimes.wav > /dev/dsp` # success end end end end -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080219/d05d06f2/attachment.html From lists at ruby-forum.com Tue Feb 19 12:29:46 2008 From: lists at ruby-forum.com (Jennifer Lindner) Date: Tue, 19 Feb 2008 18:29:46 +0100 Subject: [rspec-users] ZenTest-3.9.0 incompatible with RSpec-1.1.2 In-Reply-To: References: <57c63afe0801310325w3b44adfhf829b54c123a9b33@mail.gmail.com> <57c63afe0801311214o2ea1903ao1163bbd95ec3a7ea@mail.gmail.com> <709E5FF1-93AF-4632-BF29-39591731B5A0@matt-darby.com> <420bf25b6300ef5926938b3db695b7ee@ruby-forum.com> Message-ID: <073b9bc4f7e24b552249bf5f05754edd@ruby-forum.com> Andy Leak wrote: > I got it working - using: > - Cygwin on XP > - Cygwin Ruby 1.8.6 > - ZenTest 3.9.1 and RSpec 1.1.3 thanks..i did go from ruby 1.8.4 to 1.8.5 recently.. going to go for 1.8.6 etc. -- Posted via http://www.ruby-forum.com/. From andy at r210.com Tue Feb 19 12:35:10 2008 From: andy at r210.com (Andy Leak) Date: Tue, 19 Feb 2008 12:35:10 -0500 Subject: [rspec-users] RSpec and script/console?? Message-ID: I am a rSpec newbie. When learning ruby and rails, I found the console to be a really helpful tool. But I haven't been able to figure out how to drive RSpec from the console. Is using rSpec with the Console even a valid approach? Does anyone else use rSpec from the console?? - Andy -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080219/10859606/attachment.html From omen.king at gmail.com Tue Feb 19 13:00:28 2008 From: omen.king at gmail.com (Andrew WC Brown) Date: Tue, 19 Feb 2008 13:00:28 -0500 Subject: [rspec-users] RSpec and script/console?? In-Reply-To: References: Message-ID: I don't know how or what the advantage would be to run it from console.I think the approach is just to run the specs file as normal. On Feb 19, 2008 12:35 PM, Andy Leak wrote: > I am a rSpec newbie. When learning ruby and rails, I found the console > to be a really helpful tool. But I haven't been able to figure out how to > drive RSpec from the console. > > > > Is using rSpec with the Console even a valid approach? > > > > Does anyone else use rSpec from the console?? > > > > - Andy > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080219/cfae56e2/attachment.html From dchelimsky at gmail.com Tue Feb 19 13:09:19 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 19 Feb 2008 13:09:19 -0500 Subject: [rspec-users] spec_server requiring absolute paths (and autotest breaking) In-Reply-To: <049954B4-A032-40D9-9D6C-3640135D2506@jlaine.net> References: <75AEFAFF-6CAD-4A04-8270-85C8F51EF928@jlaine.net> <57c63afe0802190757m40197549n1b2e8570fab2df66@mail.gmail.com> <049954B4-A032-40D9-9D6C-3640135D2506@jlaine.net> Message-ID: <57c63afe0802191009p2a670f6axdf0a43a59dc3477e@mail.gmail.com> On Feb 19, 2008 12:08 PM, Jarkko Laine wrote: > On 19.2.2008, at 17.57, David Chelimsky wrote: > > Did this just start happening for you? If so, it could be the patch I > > applied in r3310. Would you mind checking out 3309 and seeing if you > > still have this problem? > > > Ok, found out the reason. I started spec_server from within the script > directory and it only works correctly if you start it from the root of > your Rails app. Gotcha. > > That said, now that autotest runs via drb, it's vastly (like 50%) > slower than without it, doesn't respect the --colour option in > spec.opts and causes failures that don't happen when running just > plain autotest. All of them seem to be related to methods being run > more times than they are supposed to. Examples: > > Mock 'Location_18994' expected :valid? with (any args) once, but > received it twice > > expected: "Barney Hops doesn't have the required competency (MBA) to > teach this class", > got: ["Barney Hops doesn't have the required competency (MBA) to > teach this class", "Barney Hops doesn't have the required competency > (MBA) to teach this class"] > > Mock 'Enrollment' expected :on_waiting_list? with (any args) twice, > but received it 3 times There are a few drb related tickets in lighthouse. Please add this if information if/where appropriate or add a new ticket. Thanks, David > > > //jarkko > > -- > Jarkko Laine > http://jlaine.net > http://dotherightthing.com > http://www.railsecommerce.com > http://odesign.fi > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From james.deville at gmail.com Tue Feb 19 13:18:54 2008 From: james.deville at gmail.com (James Deville) Date: Tue, 19 Feb 2008 10:18:54 -0800 Subject: [rspec-users] render_to_string in a controller test? In-Reply-To: <57c63afe0802190342u4f22f9a9ue360418e3c935a9c@mail.gmail.com> References: <57c63afe0802190342u4f22f9a9ue360418e3c935a9c@mail.gmail.com> Message-ID: <4757C873-69BD-41AA-95AB-7FC699E06C84@gmail.com> On Feb 19, 2008, at 3:42 AM, David Chelimsky wrote: > On Feb 18, 2008 8:10 PM, EAW wrote: >> Hi all, >> >> I know that in general, view and controller tests should be isolated, >> such that controller specs don't test views etc. However, I think >> I've run into a situation that might be an exception. >> >> My controller uses render_to_string to produce a chunk of HTML that >> it >> passes to a model to be processed. >> >> The controller then redirects the user to a different page. The >> results of the render_to_string are not seen by the user. >> >> Since the controller is calling render_to_string, I've been trying to >> test that it is rendered correctly in my controller spec. Because a >> controller spec normally doesn't render views, render_to_string just >> returns the path of the view, rather than the rendered output. This >> prevents me from testing the output of render_to_string in the >> controller spec. >> >> I can work around the issue by using integrate_views, and I guess >> that's fine, but shouldn't render_to_string really work in >> controllers? > > The whole point of isolation is to isolate the code in the controller > from the code in the view. The two primary reasons for this are that > it allows you to write controller code before the view exists and it > keeps failures in views isolated to the view specs (why should a > controller spec fail because of a typo in a view?). > > The fact that the result of rendering is being passed to a model > instead of a (theoretical) browser should not make a difference, > should it? > I am of two minds on this. On one, I can see testing that the controller assigns a template to a variable, and then test that the view is as expected in a view spec. On the other hand, if I am doing a render to string, then from a testing perspective, I'm assigning a variable. Whether that variable goes to the browser or a model shouldn't matter, we should enable testing of it as a variable. > I can see your argument for wanting to be able to treat this example > differently, and you can, as you pointed out, accomplish that with > integrate_views. Perhaps there should be a way to allow render_to_string to render a without making all views render. WDYT? James Deville http://devillecompanies.org james.deville at gmail.com rspec r3172 rspec_on_rails r3172 rails r8331 > > > FWIW, > David > >> >> Thanks for your input, >> >> e. >> -- >> ericw at xmtp.net >> >> "If the answer isn't violence, neither is your silence!" >> -- Pop Will Eat Itself, "Ich Bin Ein >> Auslander" >> >> >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users >> > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From ed.howland at gmail.com Tue Feb 19 13:32:06 2008 From: ed.howland at gmail.com (Ed Howland) Date: Tue, 19 Feb 2008 12:32:06 -0600 Subject: [rspec-users] Webrat integration with Rspec and Rake tasks Message-ID: <3df642dd0802191032m63ddad28s53cfbdf8af660b3a@mail.gmail.com> Hi, I am trying to get Webrat integrated with RSpec. I've followed the steps in the various blog posts about this, but have one sniggling little issue. It might be a Webrat issue, but I am hoping the RSpec folks might have already solved it. I have the stories run from a Rake task (am hoping for one of these in the main rspec rake task soon,) ut to run webrat stuff in the steps, you need to: rake spec:stories RAILS_ENV=test. The reason is due to the boot order of rake and plugins (of which webrat and rspec are ones), webrat/init.rb doesn't attach itself to ActionController::Integration::Session unless it is on the test environment. Only setting the RAILS_ENV ahead of the boot sequence fixes this. But I am wondering if there is another alternative. Also, has anyone gotten it to run with autotest? Thanks in advance. Ed -- Ed Howland http://greenprogrammer.blogspot.com "The information transmitted is intended only for the person or entity to which it is addressed and may contain proprietary, confidential and/or legally privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete the material from all computers." From dchelimsky at gmail.com Tue Feb 19 13:34:33 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 19 Feb 2008 13:34:33 -0500 Subject: [rspec-users] render_to_string in a controller test? In-Reply-To: <4757C873-69BD-41AA-95AB-7FC699E06C84@gmail.com> References: <57c63afe0802190342u4f22f9a9ue360418e3c935a9c@mail.gmail.com> <4757C873-69BD-41AA-95AB-7FC699E06C84@gmail.com> Message-ID: <57c63afe0802191034s3a9f5299ma72423c84fb2e06d@mail.gmail.com> On Feb 19, 2008 1:18 PM, James Deville wrote: > > > On Feb 19, 2008, at 3:42 AM, David Chelimsky wrote: > > > On Feb 18, 2008 8:10 PM, EAW wrote: > >> Hi all, > >> > >> I know that in general, view and controller tests should be isolated, > >> such that controller specs don't test views etc. However, I think > >> I've run into a situation that might be an exception. > >> > >> My controller uses render_to_string to produce a chunk of HTML that > >> it > >> passes to a model to be processed. > >> > >> The controller then redirects the user to a different page. The > >> results of the render_to_string are not seen by the user. > >> > >> Since the controller is calling render_to_string, I've been trying to > >> test that it is rendered correctly in my controller spec. Because a > >> controller spec normally doesn't render views, render_to_string just > >> returns the path of the view, rather than the rendered output. This > >> prevents me from testing the output of render_to_string in the > >> controller spec. > >> > >> I can work around the issue by using integrate_views, and I guess > >> that's fine, but shouldn't render_to_string really work in > >> controllers? > > > > The whole point of isolation is to isolate the code in the controller > > from the code in the view. The two primary reasons for this are that > > it allows you to write controller code before the view exists and it > > keeps failures in views isolated to the view specs (why should a > > controller spec fail because of a typo in a view?). > > > > The fact that the result of rendering is being passed to a model > > instead of a (theoretical) browser should not make a difference, > > should it? > > > > I am of two minds on this. On one, I can see testing that the > controller assigns a template to a variable, and then test that the > view is as expected in a view spec. On the other hand, if I am doing a > render to string, then from a testing perspective, I'm assigning a > variable. Whether that variable goes to the browser or a model > shouldn't matter, we should enable testing of it as a variable. > > > I can see your argument for wanting to be able to treat this example > > differently, and you can, as you pointed out, accomplish that with > > integrate_views. > > Perhaps there should be a way to allow render_to_string to render a > without making all views render. There already is. You can already integrate_views in a single example group. describe FooController, " ... exception case ..." do integrate_views ... end > > WDYT? > > James Deville > http://devillecompanies.org > james.deville at gmail.com > rspec r3172 > rspec_on_rails r3172 > rails r8331 > > > > > > > > FWIW, > > David > > > >> > >> Thanks for your input, > >> > >> e. > >> -- > >> ericw at xmtp.net > >> > >> "If the answer isn't violence, neither is your silence!" > >> -- Pop Will Eat Itself, "Ich Bin Ein > >> Auslander" > >> > >> > >> _______________________________________________ > >> rspec-users mailing list > >> rspec-users at rubyforge.org > >> http://rubyforge.org/mailman/listinfo/rspec-users > >> > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From james.deville at gmail.com Tue Feb 19 13:45:14 2008 From: james.deville at gmail.com (James Deville) Date: Tue, 19 Feb 2008 10:45:14 -0800 Subject: [rspec-users] Webrat integration with Rspec and Rake tasks In-Reply-To: <3df642dd0802191032m63ddad28s53cfbdf8af660b3a@mail.gmail.com> References: <3df642dd0802191032m63ddad28s53cfbdf8af660b3a@mail.gmail.com> Message-ID: <20EBC997-4643-47DA-88A0-FE854BB5BD1F@gmail.com> I set RAILS_ENV in my stories/helper.rb file. That might be a good solution. On Feb 19, 2008, at 10:32 AM, Ed Howland wrote: > Hi, > > I am trying to get Webrat integrated with RSpec. I've followed the > steps in the various blog posts about this, but have one sniggling > little issue. It might be a Webrat issue, but I am hoping the RSpec > folks might have already solved it. > > I have the stories run from a Rake task (am hoping for one of these > in the main rspec rake task soon,) ut to run webrat stuff in the > steps, you need to: > > rake spec:stories RAILS_ENV=test. > > The reason is due to the boot order of rake and plugins (of which > webrat and rspec are ones), webrat/init.rb doesn't attach itself to > ActionController::Integration::Session unless it is on the test > environment. Only setting the RAILS_ENV ahead of the boot sequence > fixes this. But I am wondering if there is another alternative. > > Also, has anyone gotten it to run with autotest? > > Thanks in advance. > > Ed > > > > > -- > Ed Howland > http://greenprogrammer.blogspot.com > "The information transmitted is intended only for the person or entity > to which it is addressed and may contain proprietary, confidential > and/or legally privileged material. Any review, retransmission, > dissemination or other use of, or taking of any action in reliance > upon, this information by persons or entities other than the intended > recipient is prohibited. If you received this in error, please contact > the sender and delete the material from all computers." > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users James Deville http://devillecompanies.org james.deville at gmail.com rspec r3172 rspec_on_rails r3172 rails r8331 From lists at ruby-forum.com Tue Feb 19 16:41:18 2008 From: lists at ruby-forum.com (=?utf-8?Q?Art=c5=abras_=c5=a0lajus?=) Date: Tue, 19 Feb 2008 22:41:18 +0100 Subject: [rspec-users] Mocking kills usefullness of controller tests? Message-ID: <0e706e66d811c2d1800ac3262ac0d208@ruby-forum.com> Hello, Let's say we mock our User objects in controllers. Then we change attr_accessible in user.rb. Model tests break, controller do not. You fix the model ones and go on thinking everything is ok when it's not (the controllers are broken). Even with technique in http://www.ruby-forum.com/topic/128149 you would only be testing if attr_accessible gets called. It wouldn't show you places in your controllers where you need to change that mass assignment to attribute assignment. Any ideas how to prevent it? -- Posted via http://www.ruby-forum.com/. From brian.takita at gmail.com Tue Feb 19 16:44:36 2008 From: brian.takita at gmail.com (Brian Takita) Date: Tue, 19 Feb 2008 13:44:36 -0800 Subject: [rspec-users] deep test with rspec? In-Reply-To: References: <47A4A276.7010805@benmabey.com> <47A4A3AF.5000708@benmabey.com> <6F782576-3A1C-4F44-8557-C8DFC3BF5E96@railsnewbie.com> <47A5243F.3030109@benmabey.com> <79F67841-B8AF-4597-A097-331736FD2C49@railsnewbie.com> Message-ID: <1d7ddd110802191344v4e076d5fuf62c32f74e551cad@mail.gmail.com> On Feb 18, 2008 7:06 PM, Dan Manges wrote: > David Vollbracht spiked an rspec implementation for DeepTest: > svn diff -r 20:21 http://deep-test.rubyforge.org/svn/trunk > > Unfortunately nobody has had time to finish it. If anybody is interested in > working on it, that would be awesome. I can give you repo access. I would be interested in trying to get it to work. > > Dan > > > > On Feb 2, 2008 9:37 PM, Scott Taylor wrote: > > > > > > > > > > On Feb 2, 2008, at 9:17 PM, Ben Mabey wrote: > > > > > Scott Taylor wrote: > > >> On Feb 2, 2008, at 12:09 PM, Ben Mabey wrote: > > >> > > >> > > >>> Ben Mabey wrote: > > >>> > > >>>> All, > > >>>> Has anyone on this list tried to use DeepTest[1] with rspec? My > > >>>> initial > > >>>> attempts have failed so I would be really interested if someone has > > >>>> figured it out. Thanks. > > >>>> > > >>>> -Ben > > >>>> > > >>>> 1. http://www.somethingnimble.com/bliki/deep-test > > >>>> _______________________________________________ > > >>>> rspec-users mailing list > > >>>> rspec-users at rubyforge.org > > >>>> http://rubyforge.org/mailman/listinfo/rspec-users > > >>>> > > >>>> > > >>> Or maybe someone has some experience with spec_distributed they > > >>> could > > >>> share? I'm just trying to see if I can get my specs to run faster > > >>> on my > > >>> multi-core machines.... > > >>> > > >> > > >> I haven't used deep test (this was by Dan Manges / Thoughtworks, > > >> correct?). If I recall correctly, it only worked on test/unit. I > > >> don't know if anyone else was working on a version for rspec... > > >> > > > Right.. There were some comments in Dan's original post about someone > > > working on rspec compatibility but as far as I can tell that never > > > made > > > it into the gem. > > >> As for spec_distributed, I had gotten it working, and as I recall, it > > >> was pretty easy to do (at least, on a non-rails project). The > > >> documentation for that is pretty straight forward. It solves the > > >> speed problem by throwing hardware at the problem - If you have n > > >> number of machines, your test suite should take 1/n the amount of > > >> time it usually does on one machine (assuming the machines of equal > > >> processing power). > > >> > > > > > > Does this really address the use of multicores on a single machine > > > then? The only use I could see of this would be for running your CI > > > faster over a number of machines... > > > Thanks for you input, > > > > No - it doesn't, but it would cut your test suite in half, just as > > two processors would. > > > > I'm sure I'm not the only one who would like to know if you took up > > the job of getting deep test to run w/ rspec. > > > > Regards, > > > > Scott > > > > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From brian.takita at gmail.com Tue Feb 19 16:55:45 2008 From: brian.takita at gmail.com (Brian Takita) Date: Tue, 19 Feb 2008 13:55:45 -0800 Subject: [rspec-users] Mocking kills usefullness of controller tests? In-Reply-To: <0e706e66d811c2d1800ac3262ac0d208@ruby-forum.com> References: <0e706e66d811c2d1800ac3262ac0d208@ruby-forum.com> Message-ID: <1d7ddd110802191355t770a9f80g46ae7184569b7c99@mail.gmail.com> On Feb 19, 2008 1:41 PM, Art?ras ?lajus wrote: > Hello, > > Let's say we mock our User objects in controllers. Then we change > attr_accessible in user.rb. Model tests break, controller do not. > > You fix the model ones and go on thinking everything is ok when it's not > (the controllers are broken). > > Even with technique in http://www.ruby-forum.com/topic/128149 you would > only be testing if attr_accessible gets called. It wouldn't show you > places in your controllers where you need to change that mass assignment > to attribute assignment. > > Any ideas how to prevent it? This is a common tradeoff when using mocks. You lose the integration aspects and arguably incur more maintenance overhead but gain speed and isolation. It looks like you want to have integration coverage over that code. You can either use controller specs without mocks, rails integration specs, and/or selenium (or watir) test that covers that piece of code. > -- > Posted via http://www.ruby-forum.com/. > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Tue Feb 19 23:55:12 2008 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 19 Feb 2008 23:55:12 -0500 Subject: [rspec-users] spec_server requiring absolute paths (and autotest breaking) In-Reply-To: <049954B4-A032-40D9-9D6C-3640135D2506@jlaine.net> References: <75AEFAFF-6CAD-4A04-8270-85C8F51EF928@jlaine.net> <57c63afe0802190757m40197549n1b2e8570fab2df66@mail.gmail.com> <049954B4-A032-40D9-9D6C-3640135D2506@jlaine.net> Message-ID: <5FA7A5CA-66AA-4B98-929D-79FFA6BB92D7@railsnewbie.com> On Feb 19, 2008, at 12:08 PM, Jarkko Laine wrote: > On 19.2.2008, at 17.57, David Chelimsky wrote: >> Did this just start happening for you? If so, it could be the patch I >> applied in r3310. Would you mind checking out 3309 and seeing if you >> still have this problem? > > > Ok, found out the reason. I started spec_server from within the > script directory and it only works correctly if you start it from > the root of your Rails app. Gotcha. > > That said, now that autotest runs via drb, it's vastly (like 50%) > slower than without it, That's the idea. > doesn't respect the --colour option in spec.opts That's been a bug since 0.6 or 0.7 when I started with rspec. I guess not enough people have used the spec server for it to be already patched. I'll take a look at fixing it this weekend. > and causes failures that don't happen when running just plain > autotest. > All of them seem to be related to methods being run more times than > they are supposed to. Examples: > > Mock 'Location_18994' expected :valid? with (any args) once, but > received it twice I saw this happen recently when the spec server was started twice: once with the rake task (rake spec:server:start), the other with a straight script/spec_sever. My hunch is that both servers are loading the files at the same time. > > expected: "Barney Hops doesn't have the required competency (MBA) > to teach this class", > got: ["Barney Hops doesn't have the required competency (MBA) > to teach this class", "Barney Hops doesn't have the required > competency (MBA) to teach this class"] > Yeah - this is because rails load's instead of requires. You'll also see this sort of thing if you just call load directly in your specs. I've never dug deeper into how all of the rails magic happens regarding loading and constants (and the method generation with the association macros (has_* belongs_to), so if you have any insight, I'd be happy to hear it. Scott From mailing_lists at railsnewbie.com Tue Feb 19 23:59:05 2008 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Tue, 19 Feb 2008 23:59:05 -0500 Subject: [rspec-users] deep test with rspec? In-Reply-To: <1d7ddd110802191344v4e076d5fuf62c32f74e551cad@mail.gmail.com> References: <47A4A276.7010805@benmabey.com> <47A4A3AF.5000708@benmabey.com> <6F782576-3A1C-4F44-8557-C8DFC3BF5E96@railsnewbie.com> <47A5243F.3030109@benmabey.com> <79F67841-B8AF-4597-A097-331736FD2C49@railsnewbie.com> <1d7ddd110802191344v4e076d5fuf62c32f74e551cad@mail.gmail.com> Message-ID: <2127C586-BFFE-43DC-9BC8-EE4844577C4A@railsnewbie.com> On Feb 19, 2008, at 4:44 PM, Brian Takita wrote: > On Feb 18, 2008 7:06 PM, Dan Manges wrote: >> David Vollbracht spiked an rspec implementation for DeepTest: >> svn diff -r 20:21 http://deep-test.rubyforge.org/svn/trunk >> >> Unfortunately nobody has had time to finish it. If anybody is >> interested in >> working on it, that would be awesome. I can give you repo access. > I would be interested in trying to get it to work. Cool. Glad to hear it's out there. I'd be interesting in helping out, too. Scott From zach.dennis at gmail.com Wed Feb 20 00:06:22 2008 From: zach.dennis at gmail.com (Zach Dennis) Date: Wed, 20 Feb 2008 00:06:22 -0500 Subject: [rspec-users] Old Style Stories Message-ID: <85d99afe0802192106x268b5f69kc498bb8c0a89c9a9@mail.gmail.com> I was working on a past project tonight to trunk which is using the old story format. IE: Given "desc" do / end When "someting "do /end etc.. Is this officially supported, or is this just something that hasn't been ripped out yet? If it is officially supported how attached are people to the re-using of do/end blocks which match the same description. Every now and then it bites me and I end up having to change one of the descriptions to differ textually then another. IMO it is kind of annoying. A story part description may have the same description as another in the same scenario. Sometimes the sequence of steps provide the context, -- Zach Dennis http://www.continuousthinking.com From ben at benmabey.com Wed Feb 20 00:12:41 2008 From: ben at benmabey.com (Ben Mabey) Date: Tue, 19 Feb 2008 22:12:41 -0700 Subject: [rspec-users] deep test with rspec? In-Reply-To: <2127C586-BFFE-43DC-9BC8-EE4844577C4A@railsnewbie.com> References: <47A4A276.7010805@benmabey.com> <47A4A3AF.5000708@benmabey.com> <6F782576-3A1C-4F44-8557-C8DFC3BF5E96@railsnewbie.com> <47A5243F.3030109@benmabey.com> <79F67841-B8AF-4597-A097-331736FD2C49@railsnewbie.com> <1d7ddd110802191344v4e076d5fuf62c32f74e551cad@mail.gmail.com> <2127C586-BFFE-43DC-9BC8-EE4844577C4A@railsnewbie.com> Message-ID: <47BBB6C9.9020001@benmabey.com> Scott Taylor wrote: > On Feb 19, 2008, at 4:44 PM, Brian Takita wrote: > > >> On Feb 18, 2008 7:06 PM, Dan Manges wrote: >> >>> David Vollbracht spiked an rspec implementation for DeepTest: >>> svn diff -r 20:21 http://deep-test.rubyforge.org/svn/trunk >>> >>> Unfortunately nobody has had time to finish it. If anybody is >>> interested in >>> working on it, that would be awesome. I can give you repo access. >>> >> I would be interested in trying to get it to work. >> > > Cool. Glad to hear it's out there. I'd be interesting in helping > out, too. > > Scott > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > I'd like to see this working as well. I have never used rinda so I'll check it out so see what I can do to help. -Ben From lists at ruby-forum.com Wed Feb 20 00:35:19 2008 From: lists at ruby-forum.com (Peter Recore) Date: Wed, 20 Feb 2008 06:35:19 +0100 Subject: [rspec-users] does the rspec_scaffold generator know about :references ? Message-ID: I checked out the CURRENT release of rspec and rails_spec as outlined on the rubyforge page. I am having trouble with models that use the :references column type. I get tests with syntax errors after generating a new class from scratch using ruby script/generate rspec_scaffold. The problem seems to be that no default values are generated for these types in the templates used by the generator. I feel that there is a 2/3 chance I am wrong here, and 1/3 that rspec just doesn't handle this part of rails 2 yet. 1. I am supposed to edit the spec scaffolding for all models with associations. 2. I am doing something else wrong. 3. Rspec just doesn't support :references yet, and I should maybe figure out how and write a patch, assuming I continue to use rspec and fall in love with it like everyone seems to have. Can anyone tell me which of the above is correct, if any? Thanks! (PS: spec_server is going to save my sanity on my ever so cute but ever so slow ultraportable) Here is the line i use to generate the class: ruby script/generate rspec_scaffold MyBar foo:references Here is the specific syntax error. You can see where the value should be is blank. C:/instantrails/ruby/lib/ruby/gems/1.8/gems/activesupport-2.0.2/lib/active_support/dependencies.rb:489:in `load': C:/instantrails/rails_apps/silver/spec/vi ews/my_bars/index.html.erb_spec.rb:17: syntax error, unexpected ',' (SyntaxError) response.should have_tag("tr>td", , 2) ^ from C:/instantrails/ruby/lib/ruby/gems/1.8/gems/activesupport-2.0.2/lib/active_support/dependencies.rb:489 :in `load' from C:/instantrails/ruby/lib/ruby/gems/1.8/gems/activesupport-2.0.2/lib/active_support/dependencies.rb:342:in `new_constants_in' from C:/instantrails/ruby/lib/ruby/gems/1.8/gems/activesupport-2.0.2/lib/active_support/dependencies.rb:489:in `load' from C:/instantrails/rails_apps/silver/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:14:in `load_files' from C:/instantrails/rails_apps/silver/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:13:in `each' from C:/instantrails/rails_apps/silver/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:13:in `load_files' from C:/instantrails/rails_apps/silver/vendor/plugins/rspec/lib/spec/runner/options.rb:85:in `run_examples' from C:/instantrails/rails_apps/silver/vendor/plugins/rspec/lib/spec/runner/command_line.rb:19:in `run' from script/spec:4 -- Posted via http://www.ruby-forum.com/. From jarkko at jlaine.net Wed Feb 20 01:52:45 2008 From: jarkko at jlaine.net (Jarkko Laine) Date: Wed, 20 Feb 2008 08:52:45 +0200 Subject: [rspec-users] spec_server requiring absolute paths (and autotest breaking) In-Reply-To: <5FA7A5CA-66AA-4B98-929D-79FFA6BB92D7@railsnewbie.com> References: <75AEFAFF-6CAD-4A04-8270-85C8F51EF928@jlaine.net> <57c63afe0802190757m40197549n1b2e8570fab2df66@mail.gmail.com> <049954B4-A032-40D9-9D6C-3640135D2506@jlaine.net> <5FA7A5CA-66AA-4B98-929D-79FFA6BB92D7@railsnewbie.com> Message-ID: <412AF32D-58D7-416C-8994-94481F142583@jlaine.net> On 20.2.2008, at 6.55, Scott Taylor wrote: >> That said, now that autotest runs via drb, it's vastly (like 50%) >> slower than without it, > > That's the idea. Isn't the idea that specs run faster through drb, rather than slower? However, in general my specs seem to take a lot longer when run through autotest in the first place (compared to running just rake spec:models, e.g.). I haven't so far been able to track down what causes this. >> Mock 'Location_18994' expected :valid? with (any args) once, but >> received it twice > > I saw this happen recently when the spec server was started twice: > once with the rake task (rake spec:server:start), the other with a > straight script/spec_sever. My hunch is that both servers are > loading the files at the same time. That would seem logical. However, I just checked that I only have one spec_server process running and am still able to reproduce the problem. >> expected: "Barney Hops doesn't have the required competency (MBA) >> to teach this class", >> got: ["Barney Hops doesn't have the required competency (MBA) >> to teach this class", "Barney Hops doesn't have the required >> competency (MBA) to teach this class"] >> > > Yeah - this is because rails load's instead of requires. You'll also > see this sort of thing if you just call load directly in your specs. > I've never dug deeper into how all of the rails magic happens > regarding loading and constants (and the method generation with the > association macros (has_* belongs_to), so if you have any insight, > I'd be happy to hear it. Yeah, all these failures are certainly related and probably caused by something like what you describe. Got to try to figure out what spec_server does differently than normal spec. Or maybe we should just bite the bullet and make the deeptest spec fork work :-) Cheers, //jarkko -- Jarkko Laine http://jlaine.net http://dotherightthing.com http://www.railsecommerce.com http://odesign.fi -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 2417 bytes Desc: not available Url : http://rubyforge.org/pipermail/rspec-users/attachments/20080220/6c07b70e/attachment.bin From jarkko at jlaine.net Wed Feb 20 01:58:35 2008 From: jarkko at jlaine.net (Jarkko Laine) Date: Wed, 20 Feb 2008 08:58:35 +0200 Subject: [rspec-users] deep test with rspec? In-Reply-To: <47BBB6C9.9020001@benmabey.com> References: <47A4A276.7010805@benmabey.com> <47A4A3AF.5000708@benmabey.com> <6F782576-3A1C-4F44-8557-C8DFC3BF5E96@railsnewbie.com> <47A5243F.3030109@benmabey.com> <79F67841-B8AF-4597-A097-331736FD2C49@railsnewbie.com> <1d7ddd110802191344v4e076d5fuf62c32f74e551cad@mail.gmail.com> <2127C586-BFFE-43DC-9BC8-EE4844577C4A@railsnewbie.com> <47BBB6C9.9020001@benmabey.com> Message-ID: On 20.2.2008, at 7.12, Ben Mabey wrote: > Scott Taylor wrote: >> On Feb 19, 2008, at 4:44 PM, Brian Takita wrote: >> >> >>> On Feb 18, 2008 7:06 PM, Dan Manges wrote: >>> >>>> David Vollbracht spiked an rspec implementation for DeepTest: >>>> svn diff -r 20:21 http://deep-test.rubyforge.org/svn/trunk >>>> >>>> Unfortunately nobody has had time to finish it. If anybody is >>>> interested in >>>> working on it, that would be awesome. I can give you repo access. >>>> >>> I would be interested in trying to get it to work. >>> >> >> Cool. Glad to hear it's out there. I'd be interesting in helping >> out, too. >> >> Scott >> >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users >> > I'd like to see this working as well. I have never used rinda so I'll > check it out so see what I can do to help. +1 > > > -Ben > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users -- Jarkko Laine http://jlaine.net http://dotherightthing.com http://www.railsecommerce.com http://odesign.fi -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 2417 bytes Desc: not available Url : http://rubyforge.org/pipermail/rspec-users/attachments/20080220/58b6e7ee/attachment.bin From jarkko at jlaine.net Wed Feb 20 02:02:45 2008 From: jarkko at jlaine.net (Jarkko Laine) Date: Wed, 20 Feb 2008 09:02:45 +0200 Subject: [rspec-users] Webrat integration with Rspec and Rake tasks In-Reply-To: <20EBC997-4643-47DA-88A0-FE854BB5BD1F@gmail.com> References: <3df642dd0802191032m63ddad28s53cfbdf8af660b3a@mail.gmail.com> <20EBC997-4643-47DA-88A0-FE854BB5BD1F@gmail.com> Message-ID: On 19.2.2008, at 20.45, James Deville wrote: > I set RAILS_ENV in my stories/helper.rb file. That might be a good > solution. > > > On Feb 19, 2008, at 10:32 AM, Ed Howland wrote: > >> Hi, >> >> I am trying to get Webrat integrated with RSpec. I've followed the >> steps in the various blog posts about this, but have one sniggling >> little issue. It might be a Webrat issue, but I am hoping the RSpec >> folks might have already solved it. >> >> I have the stories run from a Rake task (am hoping for one of these >> in the main rspec rake task soon,) ut to run webrat stuff in the >> steps, you need to: >> >> rake spec:stories RAILS_ENV=test. >> >> The reason is due to the boot order of rake and plugins (of which >> webrat and rspec are ones), webrat/init.rb doesn't attach itself to >> ActionController::Integration::Session unless it is on the test >> environment. Only setting the RAILS_ENV ahead of the boot sequence >> fixes this. But I am wondering if there is another alternative. >> >> Also, has anyone gotten it to run with autotest? Using Webrat for 100% of my stories (and running autotest) and loving it. I also have the env set in stories/helper.rb, but I'm not sure whether it was there from the beginning (I just copied it from some of the early posts about stories). //jarkko -- Jarkko Laine http://jlaine.net http://dotherightthing.com http://www.railsecommerce.com http://odesign.fi -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 2417 bytes Desc: not available Url : http://rubyforge.org/pipermail/rspec-users/attachments/20080220/1de36c08/attachment.bin From dchelimsky at gmail.com Wed Feb 20 07:26:59 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 20 Feb 2008 07:26:59 -0500 Subject: [rspec-users] Old Style Stories In-Reply-To: <85d99afe0802192106x268b5f69kc498bb8c0a89c9a9@mail.gmail.com> References: <85d99afe0802192106x268b5f69kc498bb8c0a89c9a9@mail.gmail.com> Message-ID: <57c63afe0802200426n8fa1e41x640d799d7fce7282@mail.gmail.com> On Feb 20, 2008 12:06 AM, Zach Dennis wrote: > I was working on a past project tonight to trunk which is using the > old story format. IE: > Given "desc" do / end > When "someting "do /end > etc.. > > Is this officially supported, or is this just something that hasn't > been ripped out yet? It's funny to me that this is "Old Style" in your view. It's really just another approach. Plain text is great for some situations, but so is writing in Ruby :) Depends on the team, really, and how involved the customer is in actually doing the typing. > If it is officially supported how attached are people to the re-using > of do/end blocks which match the same description. Every now and then > it bites me and I end up having to change one of the descriptions to > differ textually then another. Why would this be specific to scenarios written in Ruby? > IMO it is kind of annoying. A story > part description may have the same description as another in the same > scenario. Sometimes the sequence of steps provide the context, This seems unfinished - was there more to this sentence? I think this is just a matter of documentation. If we got rid of block-sharing we'd be promoting much more verbose scenarios with a lot of redundancy. I think it's here to stay. FWIW, David > > -- > Zach Dennis > http://www.continuousthinking.com > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Wed Feb 20 07:28:23 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 20 Feb 2008 07:28:23 -0500 Subject: [rspec-users] does the rspec_scaffold generator know about :references ? In-Reply-To: References: Message-ID: <57c63afe0802200428r140d7736h887b05435efb5651@mail.gmail.com> On Feb 20, 2008 12:35 AM, Peter Recore wrote: > I checked out the CURRENT release of rspec and rails_spec as outlined on > the rubyforge page. I am having trouble with models that use the > :references column type. I get tests with syntax errors after > generating a new class from scratch using ruby script/generate > rspec_scaffold. The problem seems to be that no default values are > generated for these types in the templates used by the generator. I > feel that there is a 2/3 chance I am wrong here, and 1/3 that rspec just > doesn't handle this part of rails 2 yet. > > 1. I am supposed to edit the spec scaffolding for all models with > associations. > 2. I am doing something else wrong. > 3. Rspec just doesn't support :references yet, and I should maybe > figure out how and write a patch, assuming I continue to use rspec and > fall in love with it like everyone seems to have. #3 - patch away: http://rspec.lighthouseapp.com. Cheers, David > > Can anyone tell me which of the above is correct, if any? > > Thanks! (PS: spec_server is going to save my sanity on my ever so cute > but ever so slow ultraportable) > > > > Here is the line i use to generate the class: > > ruby script/generate rspec_scaffold MyBar foo:references > > Here is the specific syntax error. You can see where the value should be > is blank. > > C:/instantrails/ruby/lib/ruby/gems/1.8/gems/activesupport-2.0.2/lib/active_support/dependencies.rb:489:in > `load': C:/instantrails/rails_apps/silver/spec/vi > ews/my_bars/index.html.erb_spec.rb:17: syntax error, unexpected ',' > (SyntaxError) > response.should have_tag("tr>td", , 2) > ^ from > C:/instantrails/ruby/lib/ruby/gems/1.8/gems/activesupport-2.0.2/lib/active_support/dependencies.rb:489 > :in `load' > from > C:/instantrails/ruby/lib/ruby/gems/1.8/gems/activesupport-2.0.2/lib/active_support/dependencies.rb:342:in > `new_constants_in' > from > C:/instantrails/ruby/lib/ruby/gems/1.8/gems/activesupport-2.0.2/lib/active_support/dependencies.rb:489:in > `load' > from > C:/instantrails/rails_apps/silver/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:14:in > `load_files' > from > C:/instantrails/rails_apps/silver/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:13:in > `each' > from > C:/instantrails/rails_apps/silver/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:13:in > `load_files' > from > C:/instantrails/rails_apps/silver/vendor/plugins/rspec/lib/spec/runner/options.rb:85:in > `run_examples' > from > C:/instantrails/rails_apps/silver/vendor/plugins/rspec/lib/spec/runner/command_line.rb:19:in > `run' > from script/spec:4 > -- > Posted via http://www.ruby-forum.com/. > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Wed Feb 20 07:32:34 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 20 Feb 2008 07:32:34 -0500 Subject: [rspec-users] Webrat integration with Rspec and Rake tasks In-Reply-To: References: <3df642dd0802191032m63ddad28s53cfbdf8af660b3a@mail.gmail.com> <20EBC997-4643-47DA-88A0-FE854BB5BD1F@gmail.com> Message-ID: <57c63afe0802200432p20f64c03pc71de50f6aa93e07@mail.gmail.com> On Feb 20, 2008 2:02 AM, Jarkko Laine wrote: > > On 19.2.2008, at 20.45, James Deville wrote: > > > I set RAILS_ENV in my stories/helper.rb file. That might be a good > > solution. > > > > > > On Feb 19, 2008, at 10:32 AM, Ed Howland wrote: > > > >> Hi, > >> > >> I am trying to get Webrat integrated with RSpec. I've followed the > >> steps in the various blog posts about this, but have one sniggling > >> little issue. It might be a Webrat issue, but I am hoping the RSpec > >> folks might have already solved it. > >> > >> I have the stories run from a Rake task (am hoping for one of these > >> in the main rspec rake task soon,) ut to run webrat stuff in the > >> steps, you need to: > >> > >> rake spec:stories RAILS_ENV=test. > >> > >> The reason is due to the boot order of rake and plugins (of which > >> webrat and rspec are ones), webrat/init.rb doesn't attach itself to > >> ActionController::Integration::Session unless it is on the test > >> environment. Only setting the RAILS_ENV ahead of the boot sequence > >> fixes this. But I am wondering if there is another alternative. > >> > >> Also, has anyone gotten it to run with autotest? > > Using Webrat for 100% of my stories (and running autotest) and loving > it. I also have the env set in stories/helper.rb, but I'm not sure > whether it was there from the beginning (I just copied it from some of > the early posts about stories). This is set in the generated stories/helper.rb (when you run 'script/generate rspec'). Cheers, David > > //jarkko > > -- > Jarkko Laine > http://jlaine.net > http://dotherightthing.com > http://www.railsecommerce.com > http://odesign.fi > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lattam at mac.com Wed Feb 20 13:30:49 2008 From: lattam at mac.com (Michael Latta) Date: Wed, 20 Feb 2008 10:30:49 -0800 Subject: [rspec-users] Shared scenarios? Message-ID: <29703BDB-0509-41AF-B58E-535D9C691891@mac.com> In the story framework I would like to have tests that mix and match scenarios using GivenScenario so for example a scenario that does scenarios A, B, C in various orders. Right now all scenarios need to be self-standing since all the scenarios in the story get run. I would like scenarios that are only run from GivenScenario so they can be modular. Is this possible? Alternatively could I use GivenScenario to invoke scenarios from another story that is never itself directly run? Michael From dchelimsky at gmail.com Wed Feb 20 13:50:23 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 20 Feb 2008 13:50:23 -0500 Subject: [rspec-users] Shared scenarios? In-Reply-To: <29703BDB-0509-41AF-B58E-535D9C691891@mac.com> References: <29703BDB-0509-41AF-B58E-535D9C691891@mac.com> Message-ID: <57c63afe0802201050ied2b138obb067c6372eafbb7@mail.gmail.com> On Feb 20, 2008 1:30 PM, Michael Latta wrote: > In the story framework I would like to have tests that mix and match > scenarios using GivenScenario so for example a scenario that does > scenarios A, B, C in various orders. Right now all scenarios need to > be self-standing since all the scenarios in the story get run. I > would like scenarios that are only run from GivenScenario so they can > be modular. Is this possible? Alternatively could I use > GivenScenario to invoke scenarios from another story that is never > itself directly run? Neither of these are currently supported. Feel free to enter feature request tickets at http://rspec.lighthouseapp.com. Cheers, David > > Michael > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From lattam at mac.com Wed Feb 20 14:36:48 2008 From: lattam at mac.com (Michael Latta) Date: Wed, 20 Feb 2008 11:36:48 -0800 Subject: [rspec-users] Shared scenarios? In-Reply-To: <57c63afe0802201050ied2b138obb067c6372eafbb7@mail.gmail.com> References: <29703BDB-0509-41AF-B58E-535D9C691891@mac.com> <57c63afe0802201050ied2b138obb067c6372eafbb7@mail.gmail.com> Message-ID: <0CF3FD12-D83B-49B2-9CCE-FAD02F8C5992@mac.com> David, I am new to rspec. What is the process for getting changes done? If I implement this is it hard to get into the release version? What is the recommended approach for submitting such a change? Michael On Feb 20, 2008, at 10:50 AM, David Chelimsky wrote: > On Feb 20, 2008 1:30 PM, Michael Latta wrote: >> In the story framework I would like to have tests that mix and match >> scenarios using GivenScenario so for example a scenario that does >> scenarios A, B, C in various orders. Right now all scenarios need to >> be self-standing since all the scenarios in the story get run. I >> would like scenarios that are only run from GivenScenario so they can >> be modular. Is this possible? Alternatively could I use >> GivenScenario to invoke scenarios from another story that is never >> itself directly run? > > Neither of these are currently supported. Feel free to enter feature > request tickets at http://rspec.lighthouseapp.com. > > Cheers, > David > >> >> Michael >> >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users >> > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From cremes.devlist at mac.com Wed Feb 20 16:33:54 2008 From: cremes.devlist at mac.com (Chuck Remes) Date: Wed, 20 Feb 2008 15:33:54 -0600 Subject: [rspec-users] newbie - am I on the right track? Message-ID: A few days ago I posted a message asking for help in pointing out examples of rspec in the wild. I took the input from that thread, looked through specs from random projects on rubyforge, and pored over the docs. I decided to make my first project a rewrite of a Protocol for EventMachine [1] that I had created a few weeks ago. I want to tap into the hive brain here and make sure I'm doing things right because I feel kind of nervous. For example, the original version I wrote used a little fsm (finite state machine) for reading the header and body from incoming packets and extracting messages from it. In retrospect this factor probably made this project a bad choice for my first BDD. The whole "tell, don't ask" style doesn't come into play very much when verifying the specific states of a fsm. :-) Anyway, here is a printout of what I have spec'ed so far. I sort of know which way to go with this design, but even with that foreknowledge I am surprised how the design is *already different.* I am keeping all specs (except one) to a single assertion/check. I am refactoring my class code when any method exceeds 5 real lines. I'd like experienced BDD'ers to take a peek here and let me know if I'm going in the right direction. These specs are for a buffer utility class used by the EM::Protocol. Any hints or observations would be appreciated. If you want to see the actual specs or class code, let me know and I'll post that in a follow-up. cremes$ spec buf_spec.rb -f s Buf (creation) - should exist - should default to a header length of 1 like a pascal string - should take an integer in its initializer specifying header length - should allow a multi-byte integer in its initializer specifying header length - should default to the state :read_header given correct input - should raise an exception given an incorrect argument type in #new Buf (reading headers, :read_header state) - should remain in state :read_header when it doesn't receive the entire header in one chunk - should transition to the state :read_header_done when it receives the entire header in one chunk - should transition to the state :read_header_done when it receives the entire header in 2 chunks - should transition to the state :read_header_done when it receives the header in multiple chunks Buf ( interpreting header data, default behavior like pascal string) - should interpret the header as a packed byte - should be able to interpret multi-byte headers when the default header_length is overridden (PENDING: Not Yet Implemented) Buf (read header and read body, single message) - should read header and then consume that many bytes as the body (PENDING: Not Yet Implemented) - should read a whole message and end in the :read_body_done state (PENDING: Not Yet Implemented) - should transition to :read_header from :read_body_done when given more data (PENDING: Not Yet Implemented) - should return an array containing a string corresponding to the input (PENDING: Not Yet Implemented) Buf (read header and read body, multiple messages) - should behave like a single message (PENDING: Not Yet Implemented) - should return an array containing a string element corresponding to each message from the input (PENDING: Not Yet Implemented) Pending: Buf ( interpreting header data, default behavior like pascal string) should be able to interpret multi-byte headers when the default header_length is overridden (Not Yet Implemented) Buf (read header and read body, single message) should read header and then consume that many bytes as the body (Not Yet Implemented) Buf (read header and read body, single message) should read a whole message and end in the :read_body_done state (Not Yet Implemented) Buf (read header and read body, single message) should transition to :read_header from :read_body_done when given more data (Not Yet Implemented) Buf (read header and read body, single message) should return an array containing a string corresponding to the input (Not Yet Implemented) Buf (read header and read body, multiple messages) should behave like a single message (Not Yet Implemented) Buf (read header and read body, multiple messages) should return an array containing a string element corresponding to each message from the input (Not Yet Implemented) Finished in 0.011039 seconds 18 examples, 0 failures, 7 pending [1] http://rubyeventmachine.com/ From dchelimsky at gmail.com Wed Feb 20 19:14:18 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 20 Feb 2008 19:14:18 -0500 Subject: [rspec-users] Shared scenarios? In-Reply-To: <0CF3FD12-D83B-49B2-9CCE-FAD02F8C5992@mac.com> References: <29703BDB-0509-41AF-B58E-535D9C691891@mac.com> <57c63afe0802201050ied2b138obb067c6372eafbb7@mail.gmail.com> <0CF3FD12-D83B-49B2-9CCE-FAD02F8C5992@mac.com> Message-ID: <57c63afe0802201614p4550a4fai97216cd99dcdd7ef@mail.gmail.com> On Wed, Feb 20, 2008 at 2:36 PM, Michael Latta wrote: > David, > > I am new to rspec. What is the process for getting changes done? If > I implement this is it hard to get into the release version? What is > the recommended approach for submitting such a change? First read this: http://rspec.lighthouseapp.com/projects/5645/how-to-file-a-ticket. Then post back here if you have any questions. Cheers, David > > Michael > > > > > > On Feb 20, 2008, at 10:50 AM, David Chelimsky wrote: > > > On Feb 20, 2008 1:30 PM, Michael Latta wrote: > >> In the story framework I would like to have tests that mix and match > >> scenarios using GivenScenario so for example a scenario that does > >> scenarios A, B, C in various orders. Right now all scenarios need to > >> be self-standing since all the scenarios in the story get run. I > >> would like scenarios that are only run from GivenScenario so they can > >> be modular. Is this possible? Alternatively could I use > >> GivenScenario to invoke scenarios from another story that is never > >> itself directly run? > > > > Neither of these are currently supported. Feel free to enter feature > > request tickets at http://rspec.lighthouseapp.com. > > > > Cheers, > > David > > > >> > >> Michael > >> > >> _______________________________________________ > >> rspec-users mailing list > >> rspec-users at rubyforge.org > >> http://rubyforge.org/mailman/listinfo/rspec-users > >> > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mailing_lists at railsnewbie.com Wed Feb 20 21:14:56 2008 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Wed, 20 Feb 2008 21:14:56 -0500 Subject: [rspec-users] spec_server requiring absolute paths (and autotest breaking) In-Reply-To: <412AF32D-58D7-416C-8994-94481F142583@jlaine.net> References: <75AEFAFF-6CAD-4A04-8270-85C8F51EF928@jlaine.net> <57c63afe0802190757m40197549n1b2e8570fab2df66@mail.gmail.com> <049954B4-A032-40D9-9D6C-3640135D2506@jlaine.net> <5FA7A5CA-66AA-4B98-929D-79FFA6BB92D7@railsnewbie.com> <412AF32D-58D7-416C-8994-94481F142583@jlaine.net> Message-ID: <769B3D7F-A046-4C70-BAC7-81955674C562@railsnewbie.com> On Feb 20, 2008, at 1:52 AM, Jarkko Laine wrote: > On 20.2.2008, at 6.55, Scott Taylor wrote: >>> That said, now that autotest runs via drb, it's vastly (like 50%) >>> slower than without it, >> >> That's the idea. > > Isn't the idea that specs run faster through drb, rather than > slower? However, in general my specs seem to take a lot longer when > run through autotest in the first place (compared to running just > rake spec:models, e.g.). I haven't so far been able to track down > what causes this. Oops. Misread your post. Is this true running a single spec (or a single file)? I've noticed that a test suite which takes about 5 seconds normally takes about 7 seconds under drb (according to the numbers reported by rspec). Then again, running a single file is blazingly fast, as their is no wait (as though I'm testing against a non-rails project). > >>> Mock 'Location_18994' expected :valid? with (any args) once, but >>> received it twice >> >> I saw this happen recently when the spec server was started twice: >> once with the rake task (rake spec:server:start), the other with a >> straight script/spec_sever. My hunch is that both servers are >> loading the files at the same time. > > That would seem logical. However, I just checked that I only have > one spec_server process running and am still able to reproduce the > problem. Hmm. Are you reloading classes or using anonymous classes derived from AR::Base, or anything crazy like that? Are all your models in app/models? Do you have pending migrations? Are your running with rake, or with autotest? How about running the file alone? > >>> expected: "Barney Hops doesn't have the required competency (MBA) >>> to teach this class", >>> got: ["Barney Hops doesn't have the required competency (MBA) >>> to teach this class", "Barney Hops doesn't have the required >>> competency (MBA) to teach this class"] >>> >> >> Yeah - this is because rails load's instead of requires. You'll also >> see this sort of thing if you just call load directly in your specs. >> I've never dug deeper into how all of the rails magic happens >> regarding loading and constants (and the method generation with the >> association macros (has_* belongs_to), so if you have any insight, >> I'd be happy to hear it. > > Yeah, all these failures are certainly related and probably caused > by something like what you describe. Got to try to figure out what > spec_server does differently than normal spec. Or maybe we should > just bite the bullet and make the deeptest spec fork work :-) > Yeah - deeptest is great for slow suites, but now that I have a fast suite (take 5-7 seconds), deeptest probably wouldn't be much of a performance gain for me. Scott From mailing_lists at railsnewbie.com Wed Feb 20 21:27:23 2008 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Wed, 20 Feb 2008 21:27:23 -0500 Subject: [rspec-users] Shared scenarios? In-Reply-To: <0CF3FD12-D83B-49B2-9CCE-FAD02F8C5992@mac.com> References: <29703BDB-0509-41AF-B58E-535D9C691891@mac.com> <57c63afe0802201050ied2b138obb067c6372eafbb7@mail.gmail.com> <0CF3FD12-D83B-49B2-9CCE-FAD02F8C5992@mac.com> Message-ID: <2E1D5197-7B89-4FDA-A749-68537D689457@railsnewbie.com> On Feb 20, 2008, at 2:36 PM, Michael Latta wrote: > David, > > I am new to rspec. What is the process for getting changes done? If > I implement this is it hard to get into the release version? What is > the recommended approach for submitting such a change? > > Michael > 1. Download a copy of trunk 2. make a test driven change (obviously) 3. When done, rake install_dependencies, and rake pre_commit 4. svn diff > your_patch.diff 5. Create a ticket on lighthouse, give some explanation, and attach the patch. That's the basic process. Scott > > > On Feb 20, 2008, at 10:50 AM, David Chelimsky wrote: > >> On Feb 20, 2008 1:30 PM, Michael Latta wrote: >>> In the story framework I would like to have tests that mix and match >>> scenarios using GivenScenario so for example a scenario that does >>> scenarios A, B, C in various orders. Right now all scenarios >>> need to >>> be self-standing since all the scenarios in the story get run. I >>> would like scenarios that are only run from GivenScenario so they >>> can >>> be modular. Is this possible? Alternatively could I use >>> GivenScenario to invoke scenarios from another story that is never >>> itself directly run? >> >> Neither of these are currently supported. Feel free to enter feature >> request tickets at http://rspec.lighthouseapp.com. >> >> Cheers, >> David >> >>> >>> Michael >>> >>> _______________________________________________ >>> rspec-users mailing list >>> rspec-users at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/rspec-users >>> >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From joe at pinkpucker.net Wed Feb 20 22:41:15 2008 From: joe at pinkpucker.net (Joe Van Dyk) Date: Wed, 20 Feb 2008 19:41:15 -0800 Subject: [rspec-users] Run all tests after success In-Reply-To: <57c63afe0802161039k579d4974q628e0430f7ee84d@mail.gmail.com> References: <57c63afe0802160723yfd1d9dfu8085459c05709ceb@mail.gmail.com> <57c63afe0802161039k579d4974q628e0430f7ee84d@mail.gmail.com> Message-ID: On Sat, Feb 16, 2008 at 10:39 AM, David Chelimsky wrote: > On Feb 16, 2008 1:21 PM, Steve wrote: > > On Sat, 16 Feb 2008 18:13:51 +0000, Steve wrote: > > > What was the nature of the changes. I just updated to r3312, and when I > > > run autotest I get: > > > > > > loading autotest/rails_rspec > > > /usr/bin/ruby1.8 -S script/spec -O spec/spec.opts No > > > server is running > > > > > > I've never seen the "No server is running" message before. > > > > Cancel that. I had --drb in spec.opts, and it looks like there was a > > commit to make that work. Funny I never noticed that before. > > It was broken until a recent changeset :) I don't think it's working quite right. 1) 'A puzzle if rejected, when resaved, should be re-submitted' FAILED expected rejected? to return true, got false /Users/joe/projects/tanga/vendor/plugins/rspec/lib/spec/expectations.rb:52:in `fail_with' /Users/joe/projects/tanga/vendor/plugins/rspec/lib/spec/expectations/handler.rb:21:in `handle_matcher' /Users/joe/projects/tanga/vendor/plugins/rspec/lib/spec/expectations/extensions/object.rb:34:in `should' ./spec/models/puzzle_spec.rb:187: Then this is the next executation: ruby -S script/spec -O spec/spec.opts spec/models/puzzle_spec.rb /Users/joe/projects/tanga/vendor/plugins/rspec/lib/spec/expectations.rb So it thiks that some rspec file was the cause of the crash. If the exception was raised from inside the Rails framework, then it tries to re-run the Rails file, and that sometimes really messes things up. Joe From rspec-users at kero.tmfweb.nl Wed Feb 20 23:21:07 2008 From: rspec-users at kero.tmfweb.nl (Kero) Date: Thu, 21 Feb 2008 05:21:07 +0100 Subject: [rspec-users] Old Style Stories In-Reply-To: <57c63afe0802200426n8fa1e41x640d799d7fce7282@mail.gmail.com> References: <85d99afe0802192106x268b5f69kc498bb8c0a89c9a9@mail.gmail.com> <57c63afe0802200426n8fa1e41x640d799d7fce7282@mail.gmail.com> Message-ID: <20080221042106.GA562@chello.nl> > > I was working on a past project tonight to trunk which is using the > > old story format. IE: > > Given "desc" do / end > > When "someting "do /end > > etc.. > > > > Is this officially supported, or is this just something that hasn't > > been ripped out yet? > > It's funny to me that this is "Old Style" in your view. It's really > just another approach. Plain text is great for some situations, but so > is writing in Ruby :) Depends on the team, really, and how involved > the customer is in actually doing the typing. > > > If it is officially supported how attached are people to the re-using > > of do/end blocks which match the same description. Every now and then > > it bites me and I end up having to change one of the descriptions to > > differ textually then another. > > Why would this be specific to scenarios written in Ruby? > > > IMO it is kind of annoying. A story > > part description may have the same description as another in the same > > scenario. Sometimes the sequence of steps provide the context, If I understand you correctly, then we had a discussion on this: http://rspec.lighthouseapp.com/projects/5645/tickets/167-blocks-provided-to-when-then-clauses-should-always-be-used and concluded that same-description means exactly-same-step, then continued http://rspec.lighthouseapp.com/projects/5645/tickets/172-warn-or-fail-on-re-specified-when-then-clause which is still open. > This seems unfinished - was there more to this sentence? > > I think this is just a matter of documentation. If we got rid of > block-sharing we'd be promoting much more verbose scenarios with a lot > of redundancy. I think it's here to stay. From jed.hurt at gmail.com Thu Feb 21 00:52:19 2008 From: jed.hurt at gmail.com (Jed Hurt) Date: Wed, 20 Feb 2008 22:52:19 -0700 Subject: [rspec-users] Quiet Backtrace in RSpec In-Reply-To: <8d961d900801190039x7c973fb3xad1052df557c2e45@mail.gmail.com> References: <8d961d900801190039x7c973fb3xad1052df557c2e45@mail.gmail.com> Message-ID: Ahh, I see. Is Spec::Runner::QuietBacktraceTweaker configurable for more quietness? On Sat, Jan 19, 2008 at 1:39 AM, aslak hellesoy wrote: > On Jan 19, 2008 4:16 AM, Jed Hurt wrote: > > I'm using RSpec on Rails and would like to clean up the backtraces, so I > > went looking for an RSpec equivalent to ThoughtBot's Quiet Backtrace > gem. I > > found Spec::Runner::QuietBacktraceTweaker in the RDOCS, but I can't > figure > > out how to use it. Can I add something to spec_helper.rb that will > utilize > > Spec::Runner::QuietBacktraceTweaker to quiet the backtraces? > > It's on by default, and you can turn it off with -b on the command line > > Thanks for telling me about the Quiet Backtrace gem, I've added a > ticket for that: > > http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/243-add-support-for-quietbacktrace-gem > > Aslak > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080220/3c5c06a3/attachment.html From jarkko at jlaine.net Thu Feb 21 01:20:58 2008 From: jarkko at jlaine.net (Jarkko Laine) Date: Thu, 21 Feb 2008 08:20:58 +0200 Subject: [rspec-users] spec_server requiring absolute paths (and autotest breaking) In-Reply-To: <769B3D7F-A046-4C70-BAC7-81955674C562@railsnewbie.com> References: <75AEFAFF-6CAD-4A04-8270-85C8F51EF928@jlaine.net> <57c63afe0802190757m40197549n1b2e8570fab2df66@mail.gmail.com> <049954B4-A032-40D9-9D6C-3640135D2506@jlaine.net> <5FA7A5CA-66AA-4B98-929D-79FFA6BB92D7@railsnewbie.com> <412AF32D-58D7-416C-8994-94481F142583@jlaine.net> <769B3D7F-A046-4C70-BAC7-81955674C562@railsnewbie.com> Message-ID: <5602D2DF-3E3B-4650-9F89-68D888819A3F@jlaine.net> On 21.2.2008, at 4.14, Scott Taylor wrote: > > On Feb 20, 2008, at 1:52 AM, Jarkko Laine wrote: > >> On 20.2.2008, at 6.55, Scott Taylor wrote: >>>> That said, now that autotest runs via drb, it's vastly (like 50%) >>>> slower than without it, >>> >>> That's the idea. >> >> Isn't the idea that specs run faster through drb, rather than >> slower? However, in general my specs seem to take a lot longer when >> run through autotest in the first place (compared to running just >> rake spec:models, e.g.). I haven't so far been able to track down >> what causes this. > > Oops. Misread your post. > > Is this true running a single spec (or a single file)? I've noticed > that a test suite which takes about 5 seconds normally takes about 7 > seconds under drb (according to the numbers reported by rspec). Then > again, running a single file is blazingly fast, as their is no wait > (as though I'm testing against a non-rails project). If I run a single, small file (like a helper spec), it's faster in an absolute sense (using time): Probutanol:koulutusweb jarkko$ time script/spec -O spec/spec.opts spec/ helpers/date_extension_spec.rb .... Finished in 2.061605 seconds 4 examples, 0 failures real 0m2.212s user 0m0.060s sys 0m0.024s Probutanol:koulutusweb jarkko$ time script/spec spec/helpers/ date_extension_spec.rb .... Finished in 0.102506 seconds 4 examples, 0 failures real 0m4.682s user 0m3.738s sys 0m0.688s However, as you can see even there the actual running of the specs is painfully slow (2 vs 0.1 secs) and the only reason drb is faster is because there is no startup time. This is on 3316. Also, there really seems to be something wonky going on with the loading. When I run a model spec right after starting the spec server, it works, but running it the second time already gives some weird stuff back: Probutanol:koulutusweb jarkko$ time script/spec -O spec/spec.opts spec/ models/account_spec.rb .......... Finished in 0.371612 seconds 10 examples, 0 failures real 0m1.647s user 0m0.068s sys 0m0.024s Probutanol:koulutusweb jarkko$ time script/spec -O spec/spec.opts spec/ models/account_spec.rb .FFF.FFFFF 1) ActiveRecord::AssociationTypeMismatch in 'Account users should return user' Address expected, got Address > >> >>>> Mock 'Location_18994' expected :valid? with (any args) once, but >>>> received it twice >>> >>> I saw this happen recently when the spec server was started twice: >>> once with the rake task (rake spec:server:start), the other with a >>> straight script/spec_sever. My hunch is that both servers are >>> loading the files at the same time. >> >> That would seem logical. However, I just checked that I only have >> one spec_server process running and am still able to reproduce the >> problem. > > Hmm. Are you reloading classes or using anonymous classes derived > from AR::Base, or anything crazy like that? Are all your models in > app/models? Do you have pending migrations? Are your running with > rake, or with autotest? How about running the file alone? Doesn't matter. Shouldn't be doing anything super special with models but got to think about it. >>>> expected: "Barney Hops doesn't have the required competency (MBA) >>>> to teach this class", >>>> got: ["Barney Hops doesn't have the required competency (MBA) >>>> to teach this class", "Barney Hops doesn't have the required >>>> competency (MBA) to teach this class"] >>>> >>> >>> Yeah - this is because rails load's instead of requires. You'll >>> also >>> see this sort of thing if you just call load directly in your specs. >>> I've never dug deeper into how all of the rails magic happens >>> regarding loading and constants (and the method generation with the >>> association macros (has_* belongs_to), so if you have any insight, >>> I'd be happy to hear it. >> >> Yeah, all these failures are certainly related and probably caused >> by something like what you describe. Got to try to figure out what >> spec_server does differently than normal spec. Or maybe we should >> just bite the bullet and make the deeptest spec fork work :-) >> > Yeah - deeptest is great for slow suites, but now that I have a fast > suite (take 5-7 seconds), deeptest probably wouldn't be much of a > performance gain for me. Yeah, the funny thing is, model specs that sometimes need to go to the db are pretty fast but controller specs where most of the db traffic is stubbed out seem to become a drag, and I would think deeptest would help there. -- Jarkko Laine http://jlaine.net http://dotherightthing.com http://www.railsecommerce.com http://odesign.fi -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 2417 bytes Desc: not available Url : http://rubyforge.org/pipermail/rspec-users/attachments/20080221/5338a226/attachment.bin From rubyphunk at googlemail.com Thu Feb 21 05:12:11 2008 From: rubyphunk at googlemail.com (rubyphunk) Date: Thu, 21 Feb 2008 02:12:11 -0800 (PST) Subject: [rspec-users] [ANN] RSpec mailing list Google Group mirror Message-ID: <208d0010-1007-4d1d-be63-9964cbd4d0b6@i29g2000prf.googlegroups.com> Hi. I've created a Google Group 'rspec' that acts as a mirror to the RSpec- users mailing list. You can find the group at http://groups.google.com/group/rspec. lg -- andreas From toastkid.williams at gmail.com Thu Feb 21 06:17:46 2008 From: toastkid.williams at gmail.com (Max Williams) Date: Thu, 21 Feb 2008 11:17:46 +0000 Subject: [rspec-users] Unwanted fixture data messing up my other tests Message-ID: I have a fixture for one of my tables that i use in some model tests. The data in it is messing up some other tests for a different model, that doesn't ask for the fixture - isn't the fixture data supposed to be cleared out of the test db in between tests, and only be present if specifically asked for? or am i using them wrong? thanks max -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080221/efa88355/attachment-0001.html From dchelimsky at gmail.com Thu Feb 21 08:21:02 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 21 Feb 2008 08:21:02 -0500 Subject: [rspec-users] Run all tests after success In-Reply-To: References: <57c63afe0802160723yfd1d9dfu8085459c05709ceb@mail.gmail.com> <57c63afe0802161039k579d4974q628e0430f7ee84d@mail.gmail.com> Message-ID: <57c63afe0802210521u646e6c1bj3a6d3985868a06b3@mail.gmail.com> On Wed, Feb 20, 2008 at 10:41 PM, Joe Van Dyk wrote: > On Sat, Feb 16, 2008 at 10:39 AM, David Chelimsky wrote: > > On Feb 16, 2008 1:21 PM, Steve wrote: > > > On Sat, 16 Feb 2008 18:13:51 +0000, Steve wrote: > > > > What was the nature of the changes. I just updated to r3312, and when I > > > > run autotest I get: > > > > > > > > loading autotest/rails_rspec > > > > /usr/bin/ruby1.8 -S script/spec -O spec/spec.opts No > > > > server is running > > > > > > > > I've never seen the "No server is running" message before. > > > > > > Cancel that. I had --drb in spec.opts, and it looks like there was a > > > commit to make that work. Funny I never noticed that before. > > > > It was broken until a recent changeset :) > > I don't think it's working quite right. > > 1) > 'A puzzle if rejected, when resaved, should be re-submitted' FAILED > expected rejected? to return true, got false > /Users/joe/projects/tanga/vendor/plugins/rspec/lib/spec/expectations.rb:52:in > `fail_with' > /Users/joe/projects/tanga/vendor/plugins/rspec/lib/spec/expectations/handler.rb:21:in > `handle_matcher' > /Users/joe/projects/tanga/vendor/plugins/rspec/lib/spec/expectations/extensions/object.rb:34:in > `should' > ./spec/models/puzzle_spec.rb:187: > > Then this is the next executation: > ruby -S script/spec -O spec/spec.opts spec/models/puzzle_spec.rb > /Users/joe/projects/tanga/vendor/plugins/rspec/lib/spec/expectations.rb > > So it thiks that some rspec file was the cause of the crash. If the > exception was raised from inside the Rails framework, then it tries to > re-run the Rails file, and that sometimes really messes things up. What rspec revision? > > Joe > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Thu Feb 21 08:21:19 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 21 Feb 2008 08:21:19 -0500 Subject: [rspec-users] Quiet Backtrace in RSpec In-Reply-To: References: <8d961d900801190039x7c973fb3xad1052df557c2e45@mail.gmail.com> Message-ID: <57c63afe0802210521x625ad9efg1c87a37f2c113cf8@mail.gmail.com> On Thu, Feb 21, 2008 at 12:52 AM, Jed Hurt wrote: > Ahh, I see. Is Spec::Runner::QuietBacktraceTweaker configurable for more > quietness? Nope. > > > > On Sat, Jan 19, 2008 at 1:39 AM, aslak hellesoy > wrote: > > > > > > > > > On Jan 19, 2008 4:16 AM, Jed Hurt wrote: > > > I'm using RSpec on Rails and would like to clean up the backtraces, so I > > > went looking for an RSpec equivalent to ThoughtBot's Quiet Backtrace > gem. I > > > found Spec::Runner::QuietBacktraceTweaker in the RDOCS, but I can't > figure > > > out how to use it. Can I add something to spec_helper.rb that will > utilize > > > Spec::Runner::QuietBacktraceTweaker to quiet the backtraces? > > > > It's on by default, and you can turn it off with -b on the command line > > > > Thanks for telling me about the Quiet Backtrace gem, I've added a > > ticket for that: > > > http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/243-add-support-for-quietbacktrace-gem > > > > Aslak > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Thu Feb 21 08:24:27 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 21 Feb 2008 08:24:27 -0500 Subject: [rspec-users] Unwanted fixture data messing up my other tests In-Reply-To: References: Message-ID: <57c63afe0802210524w2b8a36a7je765f7c11aaddda1@mail.gmail.com> On Thu, Feb 21, 2008 at 6:17 AM, Max Williams wrote: > I have a fixture for one of my tables that i use in some model tests. The > data in it is messing up some other tests for a different model, that > doesn't ask for the fixture - isn't the fixture data supposed to be cleared > out of the test db in between tests, and only be present if specifically > asked for? or am i using them wrong? It depends on settings you have in spec_helper.rb. You should have this: config.use_transactional_fixtures = true You should also not be declaring any fixtures in spec_helper.rb, given your situation. HTH, David > > thanks > max > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From toastkid.williams at gmail.com Thu Feb 21 08:49:24 2008 From: toastkid.williams at gmail.com (Max Williams) Date: Thu, 21 Feb 2008 13:49:24 +0000 Subject: [rspec-users] Unwanted fixture data messing up my other tests In-Reply-To: <57c63afe0802210524w2b8a36a7je765f7c11aaddda1@mail.gmail.com> References: <57c63afe0802210524w2b8a36a7je765f7c11aaddda1@mail.gmail.com> Message-ID: Hi David I have that option set already, and i'm not using any fixtures in spec_helper. My spec helper looks like this: is it the use_instantiated_fixtures option perhaps? (i don't know what that does). thanks, max >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> ENV["RAILS_ENV"] = "test" require File.expand_path(File.dirname(__FILE__) + "/../config/environment") require 'spec' require 'spec/rails' require 'spec/custom_matchers' Spec::Runner.configure do |config| # If you're not using ActiveRecord you should remove these # lines, delete config/database.yml and disable :active_record # in your config/boot.rb config.use_transactional_fixtures = true config.use_instantiated_fixtures = false config.fixture_path = RAILS_ROOT + '/spec/fixtures/' #custom stuff config.include(CustomMatchers) def mock_login_required(allow_user_to_pass=true) controller.stub!(:login_required).and_return(allow_user_to_pass) end def mock_admin_user?(allow_user_to_pass=true) controller.stub!(:admin_user?).and_return(allow_user_to_pass) end def mock_current_user(id = 1) @user = mock_model(User, :to_param => id.to_s, :id => 1) controller.stub!(:current_user).and_return(@user) end end <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< On 21/02/2008, David Chelimsky wrote: > > On Thu, Feb 21, 2008 at 6:17 AM, Max Williams > wrote: > > I have a fixture for one of my tables that i use in some model > tests. The > > data in it is messing up some other tests for a different model, that > > doesn't ask for the fixture - isn't the fixture data supposed to be > cleared > > out of the test db in between tests, and only be present if specifically > > asked for? or am i using them wrong? > > > It depends on settings you have in spec_helper.rb. You should have this: > > config.use_transactional_fixtures = true > > You should also not be declaring any fixtures in spec_helper.rb, given > your situation. > > HTH, > David > > > > > thanks > > max > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080221/a100597e/attachment.html From amjibaly at gmail.com Thu Feb 21 10:21:02 2008 From: amjibaly at gmail.com (Abdullah Jibaly) Date: Thu, 21 Feb 2008 09:21:02 -0600 Subject: [rspec-users] Rspec, stories and web services Message-ID: <43cc3c280802210721p76ee46efx31912cbe6d8d4ab6@mail.gmail.com> Hi All, I'm just getting into Rspec and have a couple questions to get my head around this: 1- Testing web services: is this a good fit for User Stories? 2- The web services run on ActionWebServices, should I be doing additional testing using traditional Rspec/Rails integration (I don't know if I'm asking the right question here so any pointers would be appreciated)? 3- As far as load testing (for the web services), is there any way I can reuse the User Stories for that? Any advice would be appreciated. Thanks, Abdullah From cremes.devlist at mac.com Thu Feb 21 11:09:49 2008 From: cremes.devlist at mac.com (Chuck Remes) Date: Thu, 21 Feb 2008 10:09:49 -0600 Subject: [rspec-users] [Q] how to restructure tests for an abstract class? Message-ID: While practicing BDD on my first-ever BDD project, I have come to a point where it makes sense to change my original class to an abstract class and create one (or more) concrete subclasses that implement a specific method. What is the right way to restructure the tests in this scenario? Do I leave the existing tests in place and just create a new spec file that instantiates and tests the concrete subclass? I think I can continue to instantiate my "abstract" parent as long as I don't go near the behavior that will be defined by the concrete subclasses. Is that the right thing to do? Thanks for any hints. cr From joe at pinkpucker.net Thu Feb 21 11:29:54 2008 From: joe at pinkpucker.net (Joe Van Dyk) Date: Thu, 21 Feb 2008 08:29:54 -0800 Subject: [rspec-users] Run all tests after success In-Reply-To: <57c63afe0802210521u646e6c1bj3a6d3985868a06b3@mail.gmail.com> References: <57c63afe0802160723yfd1d9dfu8085459c05709ceb@mail.gmail.com> <57c63afe0802161039k579d4974q628e0430f7ee84d@mail.gmail.com> <57c63afe0802210521u646e6c1bj3a6d3985868a06b3@mail.gmail.com> Message-ID: On Thu, Feb 21, 2008 at 5:21 AM, David Chelimsky wrote: > > On Wed, Feb 20, 2008 at 10:41 PM, Joe Van Dyk wrote: > > On Sat, Feb 16, 2008 at 10:39 AM, David Chelimsky wrote: > > > On Feb 16, 2008 1:21 PM, Steve wrote: > > > > On Sat, 16 Feb 2008 18:13:51 +0000, Steve wrote: > > > > > What was the nature of the changes. I just updated to r3312, and when I > > > > > run autotest I get: > > > > > > > > > > loading autotest/rails_rspec > > > > > /usr/bin/ruby1.8 -S script/spec -O spec/spec.opts No > > > > > server is running > > > > > > > > > > I've never seen the "No server is running" message before. > > > > > > > > Cancel that. I had --drb in spec.opts, and it looks like there was a > > > > commit to make that work. Funny I never noticed that before. > > > > > > It was broken until a recent changeset :) > > > > I don't think it's working quite right. > > > > 1) > > 'A puzzle if rejected, when resaved, should be re-submitted' FAILED > > expected rejected? to return true, got false > > /Users/joe/projects/tanga/vendor/plugins/rspec/lib/spec/expectations.rb:52:in > > `fail_with' > > /Users/joe/projects/tanga/vendor/plugins/rspec/lib/spec/expectations/handler.rb:21:in > > `handle_matcher' > > /Users/joe/projects/tanga/vendor/plugins/rspec/lib/spec/expectations/extensions/object.rb:34:in > > `should' > > ./spec/models/puzzle_spec.rb:187: > > > > Then this is the next executation: > > ruby -S script/spec -O spec/spec.opts spec/models/puzzle_spec.rb > > /Users/joe/projects/tanga/vendor/plugins/rspec/lib/spec/expectations.rb > > > > So it thiks that some rspec file was the cause of the crash. If the > > exception was raised from inside the Rails framework, then it tries to > > re-run the Rails file, and that sometimes really messes things up. > > What rspec revision? trunk as of yesterday. From rick.denatale at gmail.com Thu Feb 21 11:37:43 2008 From: rick.denatale at gmail.com (Rick DeNatale) Date: Thu, 21 Feb 2008 11:37:43 -0500 Subject: [rspec-users] [Q] how to restructure tests for an abstract class? In-Reply-To: References: Message-ID: On 2/21/08, Chuck Remes wrote: > While practicing BDD on my first-ever BDD project, I have come to a > point where it makes sense to change my original class to an abstract > class and create one (or more) concrete subclasses that implement a > specific method. What is the right way to restructure the tests in > this scenario? Do I leave the existing tests in place and just create > a new spec file that instantiates and tests the concrete subclass? > > I think I can continue to instantiate my "abstract" parent as long as > I don't go near the behavior that will be defined by the concrete > subclasses. Is that the right thing to do? Let me respond not so much from a BDD/RSpec point of view, but from a Ruby language perspective. Abstract classes aren't used much in Ruby, most often the job of providing "abstract" methods is done by modules rather than classes. Abstract classes are used in languages which define types via inheritance like C++ or Java , or provide only single inheritance of implementation like Smalltalk. In C++/Java you're pretty much forced to use an abstract class if you want to provide partial implementation of a type to be filled out by subclasses. In Smalltalk they're used to keep things DRY. In Smalltalk, there are quite a few abstract classes, for example Collection provides an implementation of methods like select, map, inject based on subclasses implementing an each method. In Ruby the same thing is done by having the Enumerable module which can be mixed into classes which provide an each method. So the way I'd approach the kind of refactoring you seem to be implying would be to move the abstract methods in the existing class into a module included by that class, and then implement other classes which also include the module. HTH -- Rick DeNatale My blog on Ruby http://talklikeaduck.denhaven2.com/ From abroad-crawford at within3.com Thu Feb 21 11:40:45 2008 From: abroad-crawford at within3.com (Anthony Broad-Crawford) Date: Thu, 21 Feb 2008 11:40:45 -0500 Subject: [rspec-users] Newbie question ... Message-ID: I am testing an action on a controller and cannot seem to find the syntax to stub a method call off of the controller I am testing. pseudo code class SomeController < < ApplicationController def some_action stuff stuff stuff some_protected_method_call stuff redirect_to something end protected def some_protected_method_call end end describe SomeController do it "should have some description of behavior here" do #how do I stub some_protected_method_call get 'some_action' response.should be_redirect end end From joseph at josephholsten.com Thu Feb 21 14:02:16 2008 From: joseph at josephholsten.com (Joseph Anthony Pasquale Holsten) Date: Thu, 21 Feb 2008 13:02:16 -0600 Subject: [rspec-users] Specs versus Stories In-Reply-To: <57c63afe0802181544g4615eeb1w92409a0aecb04f92@mail.gmail.com> References: <3B87748D-51A3-483D-9A89-9754BAFE9466@civrot.org> <57c63afe0802181544g4615eeb1w92409a0aecb04f92@mail.gmail.com> Message-ID: <5CB219D7-A95E-4E18-87F8-0C640F6C18D6@josephholsten.com> I try to thing of the audience for the work, and it keeps me sane. Stories are to make sure you're holding up your contract with the client or user. They are high level, and don't deal with any implementation details that can be abstracted away. You might relate them to acceptance tests, because when you pass stories, you're passing all the acceptance criteria. You also might compare them integration tests, because they should ensure everything behind the UI (or API) works correctly. It's reasonable to mock external services, but I try to have these be as real as possible. If you and your user disagree about how something works, you make the change in the story. Then you change the specs and code as needed. Specs are to make sure you're holding up your contract with the code and its developers. With so little static checking in ruby, specs are your type checking, exception checking (ala java), the preconditions, postconditions, and invariants (ala DbC), published interface, performance profiler, and possibly even internal documentation. These make sure you know the right way to interact with the code. And of course you should specify the code before you implement it, red-green style. If you and a developer disagree about how something works, you make the change in the specs. Then you change the code as needed. Clear as mud? On 02008:02:18, at 5:44CST, David Chelimsky wrote: > On Feb 18, 2008 6:38 PM, Victor Asteinza wrote: >> Isn't there redundancy between what is in your stories and your >> specs? >> Or are your stories at a higher level and the specs are at a lower >> level? That would make more sense to me. There would be some cross >> over. but the specs expand on what is in the stories.... > > While either tool can technically support either mode of thinking: > > Stories are aimed at describing the behaviour of your applications. > Specs are aimed at describing the behaviour of the objects in your > applications. > > You are correct that there will likely be some cross over, but keep in > mind that there are different audiences and different processes. > > The steps in stories (the descriptive text, not the implementation of > the steps) are typically written in entirety before setting out to > develop a body of work. Stories should be run before a commit, or as > part of a CI build, but are not always run between every step. > > The examples in specs, on the other hand, typically come into > existence in a very granular red-green-refactor cycle, and should be > run between every step. > > HTH, > David > > >> >>> Message: 3 >>> Date: Mon, 18 Feb 2008 11:21:47 -0500 >>> From: "Andrew WC Brown" >>> Subject: Re: [rspec-users] Specs versus Stories >>> To: rspec-users >>> Message-ID: >>> >>> Content-Type: text/plain; charset="iso-8859-1" >> >>> >>> My workflow is the following: >>> Stories->Spec Views->Spec Controllers-Spec Models >>> >>> I'll write a few stories of what I think should it happen. >>> Then I'll write my specs of what should show (and also do some >>> static html >>> page mockups) >>> Then I'll spec my controllers and models >>> I'll go back to my stories to see if they need adjusting because my >>> perceptive of how the app changed >>> Then I run my stories and make them pass. >>> >>> Then I write a few stories and repeat. >>> >>> I constantly step move back and forth. >>> I think Stories and BDD greatly assists you to shape your idea. >>> Write stories for what you can think of and then move on to specing. >>> You don't need complete stories you can also go back and fill them >>> in later. >>> >>> On Feb 18, 2008 2:57 AM, Victor Asteinza wrote: >>> >>>> I am new to BDD and have been doing some reading and playing with >>>> rSpec. I am a little confused. I am not sure what the best >>>> practice >>>> for using stories and specs. Should I be writing stories first, >>>> then >>>> specs that would fulfill those stories, and then write the >>>> implementation code to have everything pass? At first that seems a >>>> little redundant. >>>> >>>> I understand that the stories let you write the behavior in plane >>>> English, which I can see it being useful when dealing with non >>>> technical users. But if I am developing an internal app I am >>>> struggling with whether I should develop the stories first and then >>>> move on to the specs. >>>> >>>> Opinions? Experiences? >>>> >>>> Thanks, >>>> Victor >>>> _______________________________________________ >>>> rspec-users mailing list >>>> rspec-users at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/rspec-users >>>> >> >> _______________________________________________ >> rspec-users mailing list >> rspec-users at rubyforge.org >> http://rubyforge.org/mailman/listinfo/rspec-users >> > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users http:// Joseph Holsten .com -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080221/1cf6e73c/attachment.html From dchelimsky at gmail.com Thu Feb 21 17:23:29 2008 From: dchelimsky at gmail.com (dchelimsky at gmail.com) Date: Thu, 21 Feb 2008 14:23:29 -0800 (PST) Subject: [rspec-users] Newbie question ... In-Reply-To: References: Message-ID: On Feb 21, 10:40 am, Anthony Broad-Crawford wrote: > I am testing an action on a controller and cannot seem to find the > syntax to stub a method call off of the controller I am testing. > > pseudo code > > class SomeController < < ApplicationController > > def some_action > > stuff > stuff > stuff > some_protected_method_call > > stuff > redirect_to something > end > > protected > def some_protected_method_call > > end > end > > describe SomeController do > > it "should have some description of behavior here" do > > #how do I stub some_protected_method_call > > get 'some_action' > response.should be_redirect > end > end controller.stub! (:some_protected_method_call).and_return(whatever_it_should_return) That work? > _______________________________________________ > rspec-users mailing list > rspec-us... at rubyforge.orghttp://rubyforge.org/mailman/listinfo/rspec-users From zach.dennis at gmail.com Thu Feb 21 22:07:10 2008 From: zach.dennis at gmail.com (Zach Dennis) Date: Thu, 21 Feb 2008 22:07:10 -0500 Subject: [rspec-users] Old Style Stories In-Reply-To: <20080221042106.GA562@chello.nl> References: <85d99afe0802192106x268b5f69kc498bb8c0a89c9a9@mail.gmail.com> <57c63afe0802200426n8fa1e41x640d799d7fce7282@mail.gmail.com> <20080221042106.GA562@chello.nl> Message-ID: <85d99afe0802211907p10d12e6duda471b87918255f9@mail.gmail.com> On Wed, Feb 20, 2008 at 11:21 PM, Kero wrote: > > > I was working on a past project tonight to trunk which is using the > > > old story format. IE: > > > Given "desc" do / end > > > When "someting "do /end > > > etc.. > > > > > > Is this officially supported, or is this just something that hasn't > > > been ripped out yet? > > > > It's funny to me that this is "Old Style" in your view. It's really > > just another approach. Plain text is great for some situations, but so > > is writing in Ruby :) Depends on the team, really, and how involved > > the customer is in actually doing the typing. > > > > > If it is officially supported how attached are people to the re-using > > > of do/end blocks which match the same description. Every now and then > > > it bites me and I end up having to change one of the descriptions to > > > differ textually then another. > > > > Why would this be specific to scenarios written in Ruby? > > > > > IMO it is kind of annoying. A story > > > part description may have the same description as another in the same > > > scenario. Sometimes the sequence of steps provide the context, > > If I understand you correctly, then we had a discussion on this: > http://rspec.lighthouseapp.com/projects/5645/tickets/167-blocks-provided-to-when-then-clauses-should-always-be-used > and concluded that same-description means exactly-same-step, then continued > http://rspec.lighthouseapp.com/projects/5645/tickets/172-warn-or-fail-on-re-specified-when-then-clause > which is still open. > Thanks for the links Kero. That ticket is the issue that I am talking about. > > > This seems unfinished - was there more to this sentence? There may have been, but I cannot recall at this point. > > > > I think this is just a matter of documentation. If we got rid of > > block-sharing we'd be promoting much more verbose scenarios with a lot > > of redundancy. I think it's here to stay. > An implementation of Kero's second ticket [0] would definitely help. That extra feedback of "Hey, you already implemented this story part! Right there on line 11" would be great. A smaller annoyance associated with this is that story parts without blocks can get lost visually when in a sea of story parts with do/end blocks. I may be biased because on the last few customer driven production projects I've been using test/unit story runner, which I think is simpler and more developer friendly. [1] As you mentioned David, "Plain text is great for some situations, but so is writing in Ruby". This begs the question now that we have plain text stories. Can we make the ruby-based stories more developer friendly? Perhaps remove string identifiers, use symbols. Quit passing in blocks to story parts, assume each story part is a method call, and I'm sure there are other things that could be suggested as well. -- Zach Dennis http://www.continuousthinking.com 0 - http://rspec.lighthouseapp.com/projects/5645/tickets/172-warn-or-fail-on-re-specified-when-then-clause 1 - http://www.continuousthinking.com/2007/11/14/test-unit-story-runner From abroad-crawford at within3.com Thu Feb 21 22:41:01 2008 From: abroad-crawford at within3.com (Anthony Broad-Crawford) Date: Thu, 21 Feb 2008 22:41:01 -0500 Subject: [rspec-users] Newbie question ... In-Reply-To: References:

Message-ID: <4C234774-F6C5-440A-8CF3-60B52596C747@within3.com> yes, thank you very much! On Feb 21, 2008, at 5:23 PM, dchelimsky at gmail.com wrote: > On Feb 21, 10:40 am, Anthony Broad-Crawford crawf... at within3.com> wrote: >> I am testing an action on a controller and cannot seem to find the >> syntax to stub a method call off of the controller I am testing. >> >> pseudo code >> >> class SomeController < < ApplicationController >> >> def some_action >> >> stuff >> stuff >> stuff >> some_protected_method_call >> >> stuff >> redirect_to something >> end >> >> protected >> def some_protected_method_call >> >> end >> end >> >> describe SomeController do >> >> it "should have some description of behavior here" do >> >> #how do I stub some_protected_method_call >> >> get 'some_action' >> response.should be_redirect >> end >> end > > controller.stub! > (:some_protected_method_call).and_return(whatever_it_should_return) > > That work? > >> _______________________________________________ >> rspec-users mailing list >> rspec-us... at rubyforge.orghttp://rubyforge.org/mailman/listinfo/rspec-users > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From dchelimsky at gmail.com Thu Feb 21 23:26:49 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 21 Feb 2008 22:26:49 -0600 Subject: [rspec-users] Old Style Stories In-Reply-To: <85d99afe0802211907p10d12e6duda471b87918255f9@mail.gmail.com> References: <85d99afe0802192106x268b5f69kc498bb8c0a89c9a9@mail.gmail.com> <57c63afe0802200426n8fa1e41x640d799d7fce7282@mail.gmail.com> <20080221042106.GA562@chello.nl> <85d99afe0802211907p10d12e6duda471b87918255f9@mail.gmail.com> Message-ID: <57c63afe0802212026g39e5d19bl858c367ffa3f5910@mail.gmail.com> On Thu, Feb 21, 2008 at 9:07 PM, Zach Dennis wrote: > > On Wed, Feb 20, 2008 at 11:21 PM, Kero wrote: > > > > I was working on a past project tonight to trunk which is using the > > > > old story format. IE: > > > > Given "desc" do / end > > > > When "someting "do /end > > > > etc.. > > > > > > > > Is this officially supported, or is this just something that hasn't > > > > been ripped out yet? > > > > > > It's funny to me that this is "Old Style" in your view. It's really > > > just another approach. Plain text is great for some situations, but so > > > is writing in Ruby :) Depends on the team, really, and how involved > > > the customer is in actually doing the typing. > > > > > > > If it is officially supported how attached are people to the re-using > > > > of do/end blocks which match the same description. Every now and then > > > > it bites me and I end up having to change one of the descriptions to > > > > differ textually then another. > > > > > > Why would this be specific to scenarios written in Ruby? > > > > > > > IMO it is kind of annoying. A story > > > > part description may have the same description as another in the same > > > > scenario. Sometimes the sequence of steps provide the context, > > > > If I understand you correctly, then we had a discussion on this: > > http://rspec.lighthouseapp.com/projects/5645/tickets/167-blocks-provided-to-when-then-clauses-should-always-be-used > > and concluded that same-description means exactly-same-step, then continued > > http://rspec.lighthouseapp.com/projects/5645/tickets/172-warn-or-fail-on-re-specified-when-then-clause > > which is still open. > > > > Thanks for the links Kero. That ticket is the issue that I am talking about. > > > > > > > This seems unfinished - was there more to this sentence? > > There may have been, but I cannot recall at this point. > > > > > > > > I think this is just a matter of documentation. If we got rid of > > > block-sharing we'd be promoting much more verbose scenarios with a lot > > > of redundancy. I think it's here to stay. > > > > An implementation of Kero's second ticket [0] would definitely help. > That extra feedback of "Hey, you already implemented this story part! > Right there on line 11" would be great. Agreed. If someone commits a patch with specs, I'll be glad to apply it. Dan has already stated (I think in that ticket) that a message like you suggest would be appropriate, and I agree. > A smaller annoyance associated with this is that story parts without > blocks can get lost visually when in a sea of story parts with do/end > blocks. I may be biased because on the last few customer driven > production projects I've been using test/unit story runner, which I > think is simpler and more developer friendly. [1] > > As you mentioned David, "Plain text is great for some situations, but > so is writing in Ruby". This begs the question now that we have plain > text stories. Can we make the ruby-based stories more developer > friendly? Perhaps remove string identifiers, use symbols. Quit passing > in blocks to story parts, assume each story part is a method call, and > I'm sure there are other things that could be suggested as well. You can do all of this already except using symbols instead of Strings, something which doesn't strike me as more readable. Here's an example: http://pastie.caboo.se/155775 With this approach, the step definitions are decoupled from the steps in scenarios, which function just like method calls only better, because they can include $tokens that get converted to block arguments, supporting re-use of the step definitions. The steps_for block can be in the same file or not, you can have multiple stories in one file, you can associate multiple step groups (the result of steps_for) with the same story. You can define steps with the same identification strings in different groups that operate at different levels (for example you could have two implementations of "When I submit the event creation form", one which works using webrat or similar, and another which uses selenium), allowing you to use the same scenarios to drive both in-memory and in-browser steps. FWIW, David > > -- > > Zach Dennis > http://www.continuousthinking.com > > 0 - http://rspec.lighthouseapp.com/projects/5645/tickets/172-warn-or-fail-on-re-specified-when-then-clause > 1 - http://www.continuousthinking.com/2007/11/14/test-unit-story-runner > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Thu Feb 21 23:40:21 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 21 Feb 2008 22:40:21 -0600 Subject: [rspec-users] Old Style Stories In-Reply-To: <57c63afe0802212026g39e5d19bl858c367ffa3f5910@mail.gmail.com> References: <85d99afe0802192106x268b5f69kc498bb8c0a89c9a9@mail.gmail.com> <57c63afe0802200426n8fa1e41x640d799d7fce7282@mail.gmail.com> <20080221042106.GA562@chello.nl> <85d99afe0802211907p10d12e6duda471b87918255f9@mail.gmail.com> <57c63afe0802212026g39e5d19bl858c367ffa3f5910@mail.gmail.com> Message-ID: <57c63afe0802212040i2891f15es382b08bca6241e9c@mail.gmail.com> On Thu, Feb 21, 2008 at 10:26 PM, David Chelimsky wrote: > > On Thu, Feb 21, 2008 at 9:07 PM, Zach Dennis > > As you mentioned David, "Plain text is great for some situations, but > > so is writing in Ruby". This begs the question now that we have plain > > text stories. Can we make the ruby-based stories more developer > > friendly? Perhaps remove string identifiers, use symbols. Quit passing > > in blocks to story parts, assume each story part is a method call, and > > I'm sure there are other things that could be suggested as well. > > You can do all of this already except using symbols instead of > Strings, something which doesn't strike me as more readable. Here's an > example: > > http://pastie.caboo.se/155775 And here's another example with a bit more reuse expressed in the steps at the expense of more complexity in the steps. Which approach is better? I can't really say one is always better than the other. I choose based on readability in a given context. Just exploring possibilities. Cheers, David From toastkid.williams at gmail.com Fri Feb 22 08:26:40 2008 From: toastkid.williams at gmail.com (Max Williams) Date: Fri, 22 Feb 2008 13:26:40 +0000 Subject: [rspec-users] Testing misc methods in ApplicationController Message-ID: I'm already successfully testing before_filters in application_controller courtesy of this blog post: http://www.movesonrails.com/articles/2008/01/23/spec-ing-your-application-controller However, i can;'t work out how to test the sort of method that is added to application_controller so that all controllers can use it. It must be something simple that i'm doing wrong/omitting, can anyone help? eg if i have this empty method in application_controller def andreplace(str) end and my spec looks like this: describe ApplicationController do describe "andreplace(str)" do it "should format ands for ferret search" do andreplace("foo and bar").should eql("+foo +bar") end end end Currently, the test breaks, saying: NoMethodError in 'ApplicationController andreplace(str) should format ands for ferret search' undefined method `andreplace' for # What's going wrong here, anyone know? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080222/a5ae09d4/attachment.html From dchelimsky at gmail.com Fri Feb 22 08:46:15 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 22 Feb 2008 07:46:15 -0600 Subject: [rspec-users] Testing misc methods in ApplicationController In-Reply-To: References: Message-ID: <57c63afe0802220546k5a8a9c9cn87ac6d00ee88485b@mail.gmail.com> On Fri, Feb 22, 2008 at 7:26 AM, Max Williams wrote: > I'm already successfully testing before_filters in application_controller > courtesy of this blog post: > http://www.movesonrails.com/articles/2008/01/23/spec-ing-your-application-controller > > However, i can;'t work out how to test the sort of method that is added to > application_controller so that all controllers can use it. It must be > something simple that i'm doing wrong/omitting, can anyone help? > > eg if i have this empty method in application_controller > > def andreplace(str) > end > > and my spec looks like this: > > describe ApplicationController do > describe "andreplace(str)" do > it "should format ands for ferret search" do > andreplace("foo and bar").should eql("+foo +bar") Try this: controller.andreplace("foo and bar").should eql("+foo +bar") > end > end > end > > Currently, the test breaks, saying: > NoMethodError in 'ApplicationController andreplace(str) should format ands > for ferret search' > undefined method `andreplace' for > # This is a pointer to the problem - the error is telling you that the #andreplace message is going to the ExampleGroup, not the controller. HTH, David > > > What's going wrong here, anyone know? > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From zach.dennis at gmail.com Fri Feb 22 08:46:43 2008 From: zach.dennis at gmail.com (Zach Dennis) Date: Fri, 22 Feb 2008 08:46:43 -0500 Subject: [rspec-users] Old Style Stories In-Reply-To: <57c63afe0802212040i2891f15es382b08bca6241e9c@mail.gmail.com> References: <85d99afe0802192106x268b5f69kc498bb8c0a89c9a9@mail.gmail.com> <57c63afe0802200426n8fa1e41x640d799d7fce7282@mail.gmail.com> <20080221042106.GA562@chello.nl> <85d99afe0802211907p10d12e6duda471b87918255f9@mail.gmail.com> <57c63afe0802212026g39e5d19bl858c367ffa3f5910@mail.gmail.com> <57c63afe0802212040i2891f15es382b08bca6241e9c@mail.gmail.com> Message-ID: <85d99afe0802220546o13e8c76p74eb8e0fe63ea71e@mail.gmail.com> On Thu, Feb 21, 2008 at 11:40 PM, David Chelimsky wrote: > On Thu, Feb 21, 2008 at 10:26 PM, David Chelimsky wrote: > > > > On Thu, Feb 21, 2008 at 9:07 PM, Zach Dennis > > As you mentioned David, "Plain text is great for some situations, but > > > > so is writing in Ruby". This begs the question now that we have plain > > > text stories. Can we make the ruby-based stories more developer > > > friendly? Perhaps remove string identifiers, use symbols. Quit passing > > > in blocks to story parts, assume each story part is a method call, and > > > I'm sure there are other things that could be suggested as well. > > > > You can do all of this already except using symbols instead of > > Strings, something which doesn't strike me as more readable. Here's an > > example: > > > > http://pastie.caboo.se/155775 > > And here's another example with a bit more reuse expressed in the > steps at the expense of more complexity in the steps. Which approach > is better? I can't really say one is always better than the other. I > choose based on readability in a given context. I hadn't even considered that using steps with the normal ruby stories was an option. This gives what I am looking for. As for symbols, they reduce a few keystrokes when you have to select them and/or see find them in a file or in the project, or copy them. They are not as readable as the strings as you point out. I may just need to buck up and/or write a macro which gives me the ability to select a string based on quotes. This is not really a story problem, more of my editor lacking a feature I want. > Just exploring possibilities. Ditto. Thanks for the reply and for the code pastes. -- Zach Dennis http://www.continuousthinking.com From mauricio.linhares at gmail.com Fri Feb 22 08:50:49 2008 From: mauricio.linhares at gmail.com (=?ISO-8859-1?Q?Maur=EDcio_Linhares?=) Date: Fri, 22 Feb 2008 10:50:49 -0300 Subject: [rspec-users] Problems with redirect_to Message-ID: Hello guys, I have the following spec: describe 'With successful save' do it 'Should redirect to the new page' do do_post response.should be_redirect response.should redirect_to( :action => 'show', :id => @static_page.permalink ) ## this is the line 118 end end And when I try to run it it gives me the following error: 1) ActionController::MethodNotAllowed in 'StaticPagesController Handling POST /pages With successful save Should redirect to the new page' Only get, put, and delete requests are allowed. ./spec/controllers/static_pages_controller_spec.rb:118: script/spec:4: So, the response is a redirect (the "response.should be_redirect" passes) but when i try to be sure that it redirected to the right page it throws this weird error to me. Any ideas about what I've done wrong? I'm using RSpec 1.1.3 and Rails 2.0.2. -- Maur?cio Linhares http://alinhavado.wordpress.com/ (pt-br) | http://codeshooter.wordpress.com/ (en) Jo?o Pessoa, PB, +55 83 8867-7208 From dchelimsky at gmail.com Fri Feb 22 08:54:50 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 22 Feb 2008 07:54:50 -0600 Subject: [rspec-users] Old Style Stories In-Reply-To: <85d99afe0802220546o13e8c76p74eb8e0fe63ea71e@mail.gmail.com> References: <85d99afe0802192106x268b5f69kc498bb8c0a89c9a9@mail.gmail.com> <57c63afe0802200426n8fa1e41x640d799d7fce7282@mail.gmail.com> <20080221042106.GA562@chello.nl> <85d99afe0802211907p10d12e6duda471b87918255f9@mail.gmail.com> <57c63afe0802212026g39e5d19bl858c367ffa3f5910@mail.gmail.com> <57c63afe0802212040i2891f15es382b08bca6241e9c@mail.gmail.com> <85d99afe0802220546o13e8c76p74eb8e0fe63ea71e@mail.gmail.com> Message-ID: <57c63afe0802220554i5166174cq49d2c91603b2c8f2@mail.gmail.com> On Fri, Feb 22, 2008 at 7:46 AM, Zach Dennis wrote: > > On Thu, Feb 21, 2008 at 11:40 PM, David Chelimsky wrote: > > On Thu, Feb 21, 2008 at 10:26 PM, David Chelimsky wrote: > > > > > > On Thu, Feb 21, 2008 at 9:07 PM, Zach Dennis > > As you mentioned David, "Plain text is great for some situations, but > > > > > > so is writing in Ruby". This begs the question now that we have plain > > > > text stories. Can we make the ruby-based stories more developer > > > > friendly? Perhaps remove string identifiers, use symbols. Quit passing > > > > in blocks to story parts, assume each story part is a method call, and > > > > I'm sure there are other things that could be suggested as well. > > > > > > You can do all of this already except using symbols instead of > > > Strings, something which doesn't strike me as more readable. Here's an > > > example: > > > > > > http://pastie.caboo.se/155775 > > > > And here's another example with a bit more reuse expressed in the > > steps at the expense of more complexity in the steps. Which approach > > is better? I can't really say one is always better than the other. I > > choose based on readability in a given context. > > I hadn't even considered that using steps with the normal ruby stories > was an option. This gives what I am looking for. Great! Glad to hear it. I need to get this documented. > As for symbols, they reduce a few keystrokes when you have to select > them and/or see find them in a file or in the project, or copy them. > They are not as readable as the strings as you point out. I may just > need to buck up and/or write a macro which gives me the ability to > select a string based on quotes. This is not really a story problem, > more of my editor lacking a feature I want. > > > Just exploring possibilities. > > Ditto. > > Thanks for the reply and for the code pastes. You're welcome. Cheers, David > > -- > > > Zach Dennis > http://www.continuousthinking.com > From toastkid.williams at gmail.com Fri Feb 22 08:58:58 2008 From: toastkid.williams at gmail.com (Max Williams) Date: Fri, 22 Feb 2008 13:58:58 +0000 Subject: [rspec-users] Testing misc methods in ApplicationController In-Reply-To: <57c63afe0802220546k5a8a9c9cn87ac6d00ee88485b@mail.gmail.com> References: <57c63afe0802220546k5a8a9c9cn87ac6d00ee88485b@mail.gmail.com> Message-ID: doh...dammit, i thought i'd tried that. I'm losing it... thanks! On 22/02/2008, David Chelimsky wrote: > > On Fri, Feb 22, 2008 at 7:26 AM, Max Williams > wrote: > > I'm already successfully testing before_filters in > application_controller > > courtesy of this blog post: > > > http://www.movesonrails.com/articles/2008/01/23/spec-ing-your-application-controller > > > > However, i can;'t work out how to test the sort of method that is added > to > > application_controller so that all controllers can use it. It must be > > something simple that i'm doing wrong/omitting, can anyone help? > > > > eg if i have this empty method in application_controller > > > > def andreplace(str) > > end > > > > and my spec looks like this: > > > > describe ApplicationController do > > describe "andreplace(str)" do > > it "should format ands for ferret search" do > > andreplace("foo and bar").should eql("+foo +bar") > > > Try this: > > controller.andreplace("foo and bar").should eql("+foo +bar") > > > > end > > end > > end > > > > Currently, the test breaks, saying: > > NoMethodError in 'ApplicationController andreplace(str) should format > ands > > for ferret search' > > undefined method `andreplace' for > > > # > > > This is a pointer to the problem - the error is telling you that the > #andreplace message is going to the ExampleGroup, not the controller. > > HTH, > David > > > > > > > > What's going wrong here, anyone know? > > > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080222/3c3edc44/attachment.html From dchelimsky at gmail.com Fri Feb 22 09:00:32 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 22 Feb 2008 08:00:32 -0600 Subject: [rspec-users] Problems with redirect_to In-Reply-To: References: Message-ID: <57c63afe0802220600l552a8e67u9c46467dfe612e2b@mail.gmail.com> On Fri, Feb 22, 2008 at 7:50 AM, Maur?cio Linhares wrote: > Hello guys, > > I have the following spec: > > describe 'With successful save' do > > it 'Should redirect to the new page' do > do_post > response.should be_redirect > response.should redirect_to( :action => 'show', :id => > @static_page.permalink ) ## this is the line 118 > end > > end > > And when I try to run it it gives me the following error: > > 1) > ActionController::MethodNotAllowed in 'StaticPagesController Handling > POST /pages With successful save Should redirect to the new page' > Only get, put, and delete requests are allowed. > ./spec/controllers/static_pages_controller_spec.rb:118: > script/spec:4: > > So, the response is a redirect (the "response.should be_redirect" > passes) but when i try to be sure that it redirected to the right page > it throws this weird error to me. Any ideas about what I've done > wrong? Can you post the full backtrace? script/spec ./spec/controllers/static_pages_controller_spec.rb -b > > I'm using RSpec 1.1.3 and Rails 2.0.2. > > -- > Maur?cio Linhares > http://alinhavado.wordpress.com/ (pt-br) | > http://codeshooter.wordpress.com/ (en) > Jo?o Pessoa, PB, +55 83 8867-7208 > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Fri Feb 22 09:02:16 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 22 Feb 2008 08:02:16 -0600 Subject: [rspec-users] Testing misc methods in ApplicationController In-Reply-To: References: <57c63afe0802220546k5a8a9c9cn87ac6d00ee88485b@mail.gmail.com> Message-ID: <57c63afe0802220602i5912df8etffb968bceb41d16b@mail.gmail.com> On Fri, Feb 22, 2008 at 7:58 AM, Max Williams wrote: > doh...dammit, i thought i'd tried that. I'm losing it... > > thanks! You're welcome. Cheers, David > > > > On 22/02/2008, David Chelimsky wrote: > > On Fri, Feb 22, 2008 at 7:26 AM, Max Williams > > wrote: > > > I'm already successfully testing before_filters in > application_controller > > > courtesy of this blog post: > > > > http://www.movesonrails.com/articles/2008/01/23/spec-ing-your-application-controller > > > > > > However, i can;'t work out how to test the sort of method that is added > to > > > application_controller so that all controllers can use it. It must be > > > something simple that i'm doing wrong/omitting, can anyone help? > > > > > > eg if i have this empty method in application_controller > > > > > > def andreplace(str) > > > end > > > > > > and my spec looks like this: > > > > > > describe ApplicationController do > > > describe "andreplace(str)" do > > > it "should format ands for ferret search" do > > > andreplace("foo and bar").should eql("+foo +bar") > > > > > > Try this: > > > > controller.andreplace("foo and bar").should eql("+foo +bar") > > > > > > > end > > > end > > > end > > > > > > Currently, the test breaks, saying: > > > NoMethodError in 'ApplicationController andreplace(str) should format > ands > > > for ferret search' > > > undefined method `andreplace' for > > > > # > > > > > > This is a pointer to the problem - the error is telling you that the > > #andreplace message is going to the ExampleGroup, not the controller. > > > > HTH, > > David > > > > > > > > > > > > > What's going wrong here, anyone know? > > > > > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mauricio.linhares at gmail.com Fri Feb 22 09:10:32 2008 From: mauricio.linhares at gmail.com (=?ISO-8859-1?Q?Maur=EDcio_Linhares?=) Date: Fri, 22 Feb 2008 11:10:32 -0300 Subject: [rspec-users] Problems with redirect_to In-Reply-To: <57c63afe0802220600l552a8e67u9c46467dfe612e2b@mail.gmail.com> References: <57c63afe0802220600l552a8e67u9c46467dfe612e2b@mail.gmail.com> Message-ID: Using the "path" method the spec passes, but i don't use the path method on my controller. First, here's my controller code: def create @static_page = @event.static_pages.build(params[:static_page]) respond_to do |format| if @static_page.save flash[:notice] = 'Page was successfully created.' format.html { redirect_to(:action => 'show', :id => @static_page.permalink ) } ## thats what i'm testing agains format.xml { render :xml => @static_page, :status => :created, :location => @static_page } else format.html { render :action => "new" } format.xml { render :xml => @static_page.errors, :status => :unprocessable_entity } end end end And here is the spec: it 'Should redirect to the new page' do do_post response.should be_redirect response.should redirect_to( page_path( :action => 'show', :id => @static_page.permalink ) ) ## this one, with the page_path goes fine response.should redirect_to( :action => 'show', :id => @static_page.permalink ) ## this one, without the page_path doesn't work end It seems that the redirect_to matcher doesn't recognize the current controller. And here goes the full backtrace: ActionController::MethodNotAllowed in 'StaticPagesController Handling POST /pages With successful save Should redirect to the new page' Only get, put, and delete requests are allowed. /usr/lib/ruby/gems/1.8/gems/actionpack-2.0.2/lib/action_controller/routing.rb:1439:in `recognize_path' /home/mauricio/workspace/antares/vendor/plugins/rspec_on_rails/lib/spec/rails/matchers/redirect_to.rb:43:in `path_hash' /home/mauricio/workspace/antares/vendor/plugins/rspec_on_rails/lib/spec/rails/matchers/redirect_to.rb:38:in `hash_from_url' /home/mauricio/workspace/antares/vendor/plugins/rspec_on_rails/lib/spec/rails/matchers/redirect_to.rb:26:in `actual_hash' /home/mauricio/workspace/antares/vendor/plugins/rspec_on_rails/lib/spec/rails/matchers/redirect_to.rb:34:in `actual_redirect_to_valid_route' /home/mauricio/workspace/antares/vendor/plugins/rspec_on_rails/lib/spec/rails/matchers/redirect_to.rb:18:in `matches?' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/expectations/handler.rb:19:in `handle_matcher' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/expectations/extensions/object.rb:34:in `should' ./spec/controllers/static_pages_controller_spec.rb:119: /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_methods.rb:78:in `instance_eval' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_methods.rb:78:in `run_with_description_capturing' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_methods.rb:19:in `execute' /usr/lib/ruby/1.8/timeout.rb:48:in `timeout' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_methods.rb:16:in `execute' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:292:in `execute_examples' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:291:in `each' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:291:in `execute_examples' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:121:in `run' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:22:in `run' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:21:in `each' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:21:in `run' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/runner/options.rb:90:in `run_examples' /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/runner/command_line.rb:19:in `run' script/spec:4: On Fri, Feb 22, 2008 at 11:00 AM, David Chelimsky wrote: > On Fri, Feb 22, 2008 at 7:50 AM, Maur?cio Linhares > wrote: > > Hello guys, > > > > I have the following spec: > > > > describe 'With successful save' do > > > > it 'Should redirect to the new page' do > > do_post > > response.should be_redirect > > response.should redirect_to( :action => 'show', :id => > > @static_page.permalink ) ## this is the line 118 > > end > > > > end > > > > And when I try to run it it gives me the following error: > > > > 1) > > ActionController::MethodNotAllowed in 'StaticPagesController Handling > > POST /pages With successful save Should redirect to the new page' > > Only get, put, and delete requests are allowed. > > ./spec/controllers/static_pages_controller_spec.rb:118: > > script/spec:4: > > > > So, the response is a redirect (the "response.should be_redirect" > > passes) but when i try to be sure that it redirected to the right page > > it throws this weird error to me. Any ideas about what I've done > > wrong? > > Can you post the full backtrace? > > script/spec ./spec/controllers/static_pages_controller_spec.rb -b > > > > > > I'm using RSpec 1.1.3 and Rails 2.0.2. > > > > -- > > Maur?cio Linhares > > http://alinhavado.wordpress.com/ (pt-br) | > > http://codeshooter.wordpress.com/ (en) > > Jo?o Pessoa, PB, +55 83 8867-7208 > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -- Maur?cio Linhares http://alinhavado.wordpress.com/ (pt-br) | http://codeshooter.wordpress.com/ (en) Jo?o Pessoa, PB, +55 83 8867-7208 From dchelimsky at gmail.com Fri Feb 22 09:25:21 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 22 Feb 2008 08:25:21 -0600 Subject: [rspec-users] Problems with redirect_to In-Reply-To: References: <57c63afe0802220600l552a8e67u9c46467dfe612e2b@mail.gmail.com> Message-ID: <57c63afe0802220625s74d7817s10875cd3ae2e6cb5@mail.gmail.com> On Fri, Feb 22, 2008 at 8:10 AM, Maur?cio Linhares wrote: > Using the "path" method the spec passes, but i don't use the path > method on my controller. First, here's my controller code: > > def create > @static_page = @event.static_pages.build(params[:static_page]) > > respond_to do |format| > if @static_page.save > flash[:notice] = 'Page was successfully created.' > format.html { redirect_to(:action => 'show', :id => > @static_page.permalink ) } ## thats what i'm testing agains > format.xml { render :xml => @static_page, :status => > :created, :location => @static_page } > else > format.html { render :action => "new" } > format.xml { render :xml => @static_page.errors, :status => > :unprocessable_entity } > end > end > end > > And here is the spec: > > > it 'Should redirect to the new page' do > do_post > response.should be_redirect > response.should redirect_to( page_path( :action => 'show', :id > => @static_page.permalink ) ) ## this one, with the page_path goes > fine > > response.should redirect_to( :action => 'show', :id => > @static_page.permalink ) ## this one, without the page_path doesn't > work > end > > It seems that the redirect_to matcher doesn't recognize the current controller. Ah. I missed that the initial example was missing the controller because I was focused on the error message, which is obviously a red herring. Try adding the controller to the hash: esponse.should redirect_to( :controller => 'static_pages', :action => 'show', :id => @static_page.permalink ) If that works, then please submit a bug report to the tracker (that redirect_to does not work with action + id unless you specify the controller). Thanks, David > > And here goes the full backtrace: > > > ActionController::MethodNotAllowed in 'StaticPagesController Handling > POST /pages With successful save Should redirect to the new page' > Only get, put, and delete requests are allowed. > /usr/lib/ruby/gems/1.8/gems/actionpack-2.0.2/lib/action_controller/routing.rb:1439:in > `recognize_path' > /home/mauricio/workspace/antares/vendor/plugins/rspec_on_rails/lib/spec/rails/matchers/redirect_to.rb:43:in > `path_hash' > /home/mauricio/workspace/antares/vendor/plugins/rspec_on_rails/lib/spec/rails/matchers/redirect_to.rb:38:in > `hash_from_url' > /home/mauricio/workspace/antares/vendor/plugins/rspec_on_rails/lib/spec/rails/matchers/redirect_to.rb:26:in > `actual_hash' > /home/mauricio/workspace/antares/vendor/plugins/rspec_on_rails/lib/spec/rails/matchers/redirect_to.rb:34:in > `actual_redirect_to_valid_route' > /home/mauricio/workspace/antares/vendor/plugins/rspec_on_rails/lib/spec/rails/matchers/redirect_to.rb:18:in > `matches?' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/expectations/handler.rb:19:in > `handle_matcher' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/expectations/extensions/object.rb:34:in > `should' > ./spec/controllers/static_pages_controller_spec.rb:119: > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_methods.rb:78:in > `instance_eval' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_methods.rb:78:in > `run_with_description_capturing' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_methods.rb:19:in > `execute' > /usr/lib/ruby/1.8/timeout.rb:48:in `timeout' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_methods.rb:16:in > `execute' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:292:in > `execute_examples' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:291:in > `each' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:291:in > `execute_examples' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/example/example_group_methods.rb:121:in > `run' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:22:in > `run' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:21:in > `each' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/runner/example_group_runner.rb:21:in > `run' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/runner/options.rb:90:in > `run_examples' > /home/mauricio/workspace/antares/vendor/plugins/rspec/lib/spec/runner/command_line.rb:19:in > `run' > script/spec:4: > > > > > On Fri, Feb 22, 2008 at 11:00 AM, David Chelimsky wrote: > > On Fri, Feb 22, 2008 at 7:50 AM, Maur?cio Linhares > > wrote: > > > Hello guys, > > > > > > I have the following spec: > > > > > > describe 'With successful save' do > > > > > > it 'Should redirect to the new page' do > > > do_post > > > response.should be_redirect > > > response.should redirect_to( :action => 'show', :id => > > > @static_page.permalink ) ## this is the line 118 > > > end > > > > > > end > > > > > > And when I try to run it it gives me the following error: > > > > > > 1) > > > ActionController::MethodNotAllowed in 'StaticPagesController Handling > > > POST /pages With successful save Should redirect to the new page' > > > Only get, put, and delete requests are allowed. > > > ./spec/controllers/static_pages_controller_spec.rb:118: > > > script/spec:4: > > > > > > So, the response is a redirect (the "response.should be_redirect" > > > passes) but when i try to be sure that it redirected to the right page > > > it throws this weird error to me. Any ideas about what I've done > > > wrong? > > > > Can you post the full backtrace? > > > > script/spec ./spec/controllers/static_pages_controller_spec.rb -b > > > > > > > > > > I'm using RSpec 1.1.3 and Rails 2.0.2. > > > > > > -- > > > Maur?cio Linhares > > > http://alinhavado.wordpress.com/ (pt-br) | > > > http://codeshooter.wordpress.com/ (en) > > > Jo?o Pessoa, PB, +55 83 8867-7208 > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > -- > > > Maur?cio Linhares > http://alinhavado.wordpress.com/ (pt-br) | > http://codeshooter.wordpress.com/ (en) > Jo?o Pessoa, PB, +55 83 8867-7208 > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From mauricio.linhares at gmail.com Fri Feb 22 10:20:59 2008 From: mauricio.linhares at gmail.com (=?ISO-8859-1?Q?Maur=EDcio_Linhares?=) Date: Fri, 22 Feb 2008 12:20:59 -0300 Subject: [rspec-users] Problems with redirect_to In-Reply-To: <57c63afe0802220625s74d7817s10875cd3ae2e6cb5@mail.gmail.com> References: <57c63afe0802220600l552a8e67u9c46467dfe612e2b@mail.gmail.com> <57c63afe0802220625s74d7817s10875cd3ae2e6cb5@mail.gmail.com> Message-ID: Hi David, First, using the controller doesn't work also :) After some debugging here i found out why it was trowing the error, the RedirectTo matcher uses the ActionController::Routing::Routes.recognize_path method to discover if a path exists and this method takes two parameters, the path and the "environment" that the path is being requested. When my code was being matched, the redirect_to matcher generated the right path "/pages/test" and sent it two the recognize_path method, but this path is a Restful one and only GET, PUT and DELETEs are allowed and the RedirectTo matcher didn't send any :method param, so when the path is being recognized and no method is sent it will never be recognized and thus that weird error is thrown. A simple way to solve this issue is change the path_hash method at the RedirectTo matcher to include the HTTP method being called: def path_hash(url) path = url.sub(%r{^\w+://#{@request.host}}, "").split("?", 2)[0] ActionController::Routing::Routes.recognize_path path, :method => :get end As you can only redirect to GET requests, this should not be a problem. Should i file a patch for this? Now, the two methods are working fine =D it 'Should redirect to the new page' do do_post response.should redirect_to( page_path( :action => 'show', :id => @static_page.permalink ) ) response.should redirect_to( :action => 'show', :id => @static_page.permalink ) end -- Maur?cio Linhares http://alinhavado.wordpress.com/ (pt-br) | http://codeshooter.wordpress.com/ (en) Jo?o Pessoa, PB, +55 83 8867-7208 On Fri, Feb 22, 2008 at 11:25 AM, David Chelimsky wrote: > On Fri, Feb 22, 2008 at 8:10 AM, Maur?cio Linhares > > wrote: > > > > Using the "path" method the spec passes, but i don't use the path > > method on my controller. First, here's my controller code: > > > > def create > > @static_page = @event.static_pages.build(params[:static_page]) > > > > respond_to do |format| > > if @static_page.save > > flash[:notice] = 'Page was successfully created.' > > format.html { redirect_to(:action => 'show', :id => > > @static_page.permalink ) } ## thats what i'm testing agains > > format.xml { render :xml => @static_page, :status => > > :created, :location => @static_page } > > else > > format.html { render :action => "new" } > > format.xml { render :xml => @static_page.errors, :status => > > :unprocessable_entity } > > end > > end > > end > > > > And here is the spec: > > > > > > it 'Should redirect to the new page' do > > do_post > > response.should be_redirect > > response.should redirect_to( page_path( :action => 'show', :id > > => @static_page.permalink ) ) ## this one, with the page_path goes > > fine > > > > response.should redirect_to( :action => 'show', :id => > > @static_page.permalink ) ## this one, without the page_path doesn't > > work > > end > > > > It seems that the redirect_to matcher doesn't recognize the current controller. > > Ah. I missed that the initial example was missing the controller > because I was focused on the error message, which is obviously a red > herring. > > Try adding the controller to the hash: > > esponse.should redirect_to( :controller => 'static_pages', :action => > > 'show', :id => @static_page.permalink ) > > If that works, then please submit a bug report to the tracker (that > redirect_to does not work with action + id unless you specify the > controller). > > Thanks, > David > From dchelimsky at gmail.com Fri Feb 22 10:43:33 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Fri, 22 Feb 2008 09:43:33 -0600 Subject: [rspec-users] Problems with redirect_to In-Reply-To: References: <57c63afe0802220600l552a8e67u9c46467dfe612e2b@mail.gmail.com> <57c63afe0802220625s74d7817s10875cd3ae2e6cb5@mail.gmail.com> Message-ID: <57c63afe0802220743q391a76c8g8a94835e0c85fad1@mail.gmail.com> On Fri, Feb 22, 2008 at 9:20 AM, Maur?cio Linhares wrote: > Hi David, > > First, using the controller doesn't work also :) > > After some debugging here i found out why it was trowing the error, > the RedirectTo matcher uses the > ActionController::Routing::Routes.recognize_path method to discover if > a path exists and this method takes two parameters, the path and the > "environment" that the path is being requested. When my code was being > matched, the redirect_to matcher generated the right path > "/pages/test" and sent it two the recognize_path method, but this path > is a Restful one and only GET, PUT and DELETEs are allowed and the > RedirectTo matcher didn't send any :method param, so when the path is > being recognized and no method is sent it will never be recognized and > thus that weird error is thrown. > > A simple way to solve this issue is change the path_hash method at the > RedirectTo matcher to include the HTTP method being called: > > def path_hash(url) > path = url.sub(%r{^\w+://#{@request.host}}, "").split("?", 2)[0] > ActionController::Routing::Routes.recognize_path path, :method => :get > end > > As you can only redirect to GET requests, this should not be a > problem. Should i file a patch for this? That would be great, thanks! Please do review http://rspec.lighthouseapp.com/projects/5645/how-to-file-a-ticket before you do. Thank you, David > > Now, the two methods are working fine =D > > > it 'Should redirect to the new page' do > do_post > > response.should redirect_to( page_path( :action => 'show', :id > => @static_page.permalink ) ) > > response.should redirect_to( :action => 'show', :id => > @static_page.permalink ) > end > > > -- > > Maur?cio Linhares > http://alinhavado.wordpress.com/ (pt-br) | > http://codeshooter.wordpress.com/ (en) > Jo?o Pessoa, PB, +55 83 8867-7208 > > > > > On Fri, Feb 22, 2008 at 11:25 AM, David Chelimsky wrote: > > On Fri, Feb 22, 2008 at 8:10 AM, Maur?cio Linhares > > > > wrote: > > > > > > > Using the "path" method the spec passes, but i don't use the path > > > method on my controller. First, here's my controller code: > > > > > > def create > > > @static_page = @event.static_pages.build(params[:static_page]) > > > > > > respond_to do |format| > > > if @static_page.save > > > flash[:notice] = 'Page was successfully created.' > > > format.html { redirect_to(:action => 'show', :id => > > > @static_page.permalink ) } ## thats what i'm testing agains > > > format.xml { render :xml => @static_page, :status => > > > :created, :location => @static_page } > > > else > > > format.html { render :action => "new" } > > > format.xml { render :xml => @static_page.errors, :status => > > > :unprocessable_entity } > > > end > > > end > > > end > > > > > > And here is the spec: > > > > > > > > > it 'Should redirect to the new page' do > > > do_post > > > response.should be_redirect > > > response.should redirect_to( page_path( :action => 'show', :id > > > => @static_page.permalink ) ) ## this one, with the page_path goes > > > fine > > > > > > response.should redirect_to( :action => 'show', :id => > > > @static_page.permalink ) ## this one, without the page_path doesn't > > > work > > > end > > > > > > It seems that the redirect_to matcher doesn't recognize the current controller. > > > > Ah. I missed that the initial example was missing the controller > > because I was focused on the error message, which is obviously a red > > herring. > > > > Try adding the controller to the hash: > > > > esponse.should redirect_to( :controller => 'static_pages', :action => > > > > 'show', :id => @static_page.permalink ) > > > > If that works, then please submit a bug report to the tracker (that > > redirect_to does not work with action + id unless you specify the > > controller). > > > > Thanks, > > David > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From brian.takita at gmail.com Fri Feb 22 16:22:08 2008 From: brian.takita at gmail.com (Brian Takita) Date: Fri, 22 Feb 2008 13:22:08 -0800 Subject: [rspec-users] Specs versus Stories In-Reply-To: <5CB219D7-A95E-4E18-87F8-0C640F6C18D6@josephholsten.com> References: <3B87748D-51A3-483D-9A89-9754BAFE9466@civrot.org> <57c63afe0802181544g4615eeb1w92409a0aecb04f92@mail.gmail.com> <5CB219D7-A95E-4E18-87F8-0C640F6C18D6@josephholsten.com> Message-ID: <1d7ddd110802221322s547e3e4eg90ada3df263de5a2@mail.gmail.com> There are automated & manual tests. Automated customer facing & Automated developer tests. Both customer facing and developer tests can have a unit, functional, and integration scope. That being said, you can have effective high level developer Specs. Stories are great for facilitation communication, especially with nondevelopers. It may also be useful in organizing the developer's thoughts too. There may also be other benefits that I'm missing here. However, there is an additional investment needed to build up your Story dsl, than would be expended in using high level Specs. Does the value of having Stories outweigh the costs in your situation? I think the best practice is what makes the most sense to you. On Thu, Feb 21, 2008 at 11:02 AM, Joseph Anthony Pasquale Holsten wrote: > I try to thing of the audience for the work, and it keeps me sane. > > Stories are to make sure you're holding up your contract with the client or > user. They are high level, and don't deal with any implementation details > that can be abstracted away. You might relate them to acceptance tests, > because when you pass stories, you're passing all the acceptance criteria. > You also might compare them integration tests, because they should ensure > everything behind the UI (or API) works correctly. It's reasonable to mock > external services, but I try to have these be as real as possible. > > If you and your user disagree about how something works, you make the change > in the story. Then you change the specs and code as needed. > > Specs are to make sure you're holding up your contract with the code and its > developers. With so little static checking in ruby, specs are your type > checking, exception checking (ala java), the preconditions, postconditions, > and invariants (ala DbC), published interface, performance profiler, and > possibly even internal documentation. These make sure you know the right way > to interact with the code. And of course you should specify the code before > you implement it, red-green style. > > If you and a developer disagree about how something works, you make the > change in the specs. Then you change the code as needed. > > Clear as mud? > > > > On 02008:02:18, at 5:44CST, David Chelimsky wrote: > > On Feb 18, 2008 6:38 PM, Victor Asteinza wrote: > Isn't there redundancy between what is in your stories and your specs? > Or are your stories at a higher level and the specs are at a lower > level? That would make more sense to me. There would be some cross > over. but the specs expand on what is in the stories.... > > While either tool can technically support either mode of thinking: > > Stories are aimed at describing the behaviour of your applications. > Specs are aimed at describing the behaviour of the objects in your > applications. > > You are correct that there will likely be some cross over, but keep in > mind that there are different audiences and different processes. > > The steps in stories (the descriptive text, not the implementation of > the steps) are typically written in entirety before setting out to > develop a body of work. Stories should be run before a commit, or as > part of a CI build, but are not always run between every step. > > The examples in specs, on the other hand, typically come into > existence in a very granular red-green-refactor cycle, and should be > run between every step. > > HTH, > David > > > > > > Message: 3 > Date: Mon, 18 Feb 2008 11:21:47 -0500 > From: "Andrew WC Brown" > Subject: Re: [rspec-users] Specs versus Stories > To: rspec-users > Message-ID: > > Content-Type: text/plain; charset="iso-8859-1" > > > > My workflow is the following: > Stories->Spec Views->Spec Controllers-Spec Models > > I'll write a few stories of what I think should it happen. > Then I'll write my specs of what should show (and also do some > static html > page mockups) > Then I'll spec my controllers and models > I'll go back to my stories to see if they need adjusting because my > perceptive of how the app changed > Then I run my stories and make them pass. > > Then I write a few stories and repeat. > > I constantly step move back and forth. > I think Stories and BDD greatly assists you to shape your idea. > Write stories for what you can think of and then move on to specing. > You don't need complete stories you can also go back and fill them > in later. > > On Feb 18, 2008 2:57 AM, Victor Asteinza wrote: > > > I am new to BDD and have been doing some reading and playing with > rSpec. I am a little confused. I am not sure what the best practice > for using stories and specs. Should I be writing stories first, then > specs that would fulfill those stories, and then write the > implementation code to have everything pass? At first that seems a > little redundant. > > I understand that the stories let you write the behavior in plane > English, which I can see it being useful when dealing with non > technical users. But if I am developing an internal app I am > struggling with whether I should develop the stories first and then > move on to the specs. > > Opinions? Experiences? > > Thanks, > Victor > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > > http:// Joseph Holsten .com > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From ed.howland at gmail.com Fri Feb 22 18:02:49 2008 From: ed.howland at gmail.com (Ed Howland) Date: Fri, 22 Feb 2008 17:02:49 -0600 Subject: [rspec-users] Webrat integration with Rspec and Rake tasks In-Reply-To: References: <3df642dd0802191032m63ddad28s53cfbdf8af660b3a@mail.gmail.com> <20EBC997-4643-47DA-88A0-FE854BB5BD1F@gmail.com> Message-ID: <3df642dd0802221502x27e0c408o8623f4f5b8f84176@mail.gmail.com> On Wed, Feb 20, 2008 at 1:02 AM, Jarkko Laine wrote: > > On 19.2.2008, at 20.45, James Deville wrote: > > > I set RAILS_ENV in my stories/helper.rb file. That might be a good > > solution. > > > > > > Using Webrat for 100% of my stories (and running autotest) and loving > it. I also have the env set in stories/helper.rb, but I'm not sure > whether it was there from the beginning (I just copied it from some of > the early posts about stories). > > //jarkko > It is set in stories/helper.rb, but not working. ./script/generate rspec creates a file with: ENV['RAILS_ENV']="test" which is deprecated It should be: RAILS_ENV="test" Changed that and it all worked fine. Ed > -- > Jarkko Laine > http://jlaine.net > http://dotherightthing.com > http://www.railsecommerce.com > http://odesign.fi > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -- Ed Howland http://greenprogrammer.blogspot.com "The information transmitted is intended only for the person or entity to which it is addressed and may contain proprietary, confidential and/or legally privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete the material from all computers." From joe at pinkpucker.net Fri Feb 22 21:00:28 2008 From: joe at pinkpucker.net (Joe Van Dyk) Date: Fri, 22 Feb 2008 18:00:28 -0800 Subject: [rspec-users] Webrat integration with Rspec and Rake tasks In-Reply-To: References: <3df642dd0802191032m63ddad28s53cfbdf8af660b3a@mail.gmail.com> <20EBC997-4643-47DA-88A0-FE854BB5BD1F@gmail.com> Message-ID: On Tue, Feb 19, 2008 at 11:02 PM, Jarkko Laine wrote: > > On 19.2.2008, at 20.45, James Deville wrote: > > > I set RAILS_ENV in my stories/helper.rb file. That might be a good > > solution. > > > > > > On Feb 19, 2008, at 10:32 AM, Ed Howland wrote: > > > >> Hi, > >> > >> I am trying to get Webrat integrated with RSpec. I've followed the > >> steps in the various blog posts about this, but have one sniggling > >> little issue. It might be a Webrat issue, but I am hoping the RSpec > >> folks might have already solved it. > >> > >> I have the stories run from a Rake task (am hoping for one of these > >> in the main rspec rake task soon,) ut to run webrat stuff in the > >> steps, you need to: > >> > >> rake spec:stories RAILS_ENV=test. > >> > >> The reason is due to the boot order of rake and plugins (of which > >> webrat and rspec are ones), webrat/init.rb doesn't attach itself to > >> ActionController::Integration::Session unless it is on the test > >> environment. Only setting the RAILS_ENV ahead of the boot sequence > >> fixes this. But I am wondering if there is another alternative. > >> > >> Also, has anyone gotten it to run with autotest? > > Using Webrat for 100% of my stories (and running autotest) and loving > it. I also have the env set in stories/helper.rb, but I'm not sure > whether it was there from the beginning (I just copied it from some of > the early posts about stories). How are you using both autotest and the stories? From rspec-users at kero.tmfweb.nl Fri Feb 22 22:23:12 2008 From: rspec-users at kero.tmfweb.nl (Kero) Date: Sat, 23 Feb 2008 04:23:12 +0100 Subject: [rspec-users] Old Style Stories In-Reply-To: <57c63afe0802212040i2891f15es382b08bca6241e9c@mail.gmail.com> References: <85d99afe0802192106x268b5f69kc498bb8c0a89c9a9@mail.gmail.com> <57c63afe0802200426n8fa1e41x640d799d7fce7282@mail.gmail.com> <20080221042106.GA562@chello.nl> <85d99afe0802211907p10d12e6duda471b87918255f9@mail.gmail.com> <57c63afe0802212026g39e5d19bl858c367ffa3f5910@mail.gmail.com> <57c63afe0802212040i2891f15es382b08bca6241e9c@mail.gmail.com> Message-ID: <20080223032312.GB562@chello.nl> > > > so is writing in Ruby". This begs the question now that we have plain > > > text stories. Can we make the ruby-based stories more developer > > > friendly? Perhaps remove string identifiers, use symbols. Quit passing > > > in blocks to story parts, assume each story part is a method call, and > > > I'm sure there are other things that could be suggested as well. > > > > You can do all of this already except using symbols instead of > > Strings, something which doesn't strike me as more readable. Here's an > > example: > > > > http://pastie.caboo.se/155775 > > And here's another example with a bit more reuse expressed in the > steps at the expense of more complexity in the steps. Which approach > is better? I can't really say one is always better than the other. I > choose based on readability in a given context. Just exploring > possibilities. where? From jarkko at jlaine.net Sat Feb 23 03:11:11 2008 From: jarkko at jlaine.net (Jarkko Laine) Date: Sat, 23 Feb 2008 10:11:11 +0200 Subject: [rspec-users] Webrat integration with Rspec and Rake tasks In-Reply-To: References: <3df642dd0802191032m63ddad28s53cfbdf8af660b3a@mail.gmail.com> <20EBC997-4643-47DA-88A0-FE854BB5BD1F@gmail.com> Message-ID: On 23.2.2008, at 4.00, Joe Van Dyk wrote: > How are you using both autotest and the stories? I use Geoffrey's rstakeout (http://nubyonrails.com/articles/automation-with-rstakeout ) to watch a single story (running all stories a la autotest is too slow) and /app, and autotest in a different terminal for normal specs. //jarkko -- Jarkko Laine http://jlaine.net http://dotherightthing.com http://www.railsecommerce.com http://odesign.fi -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 2417 bytes Desc: not available Url : http://rubyforge.org/pipermail/rspec-users/attachments/20080223/3dc6853f/attachment-0001.bin From a at heitler.com Fri Feb 22 08:29:50 2008 From: a at heitler.com (jesterj) Date: Fri, 22 Feb 2008 05:29:50 -0800 (PST) Subject: [rspec-users] Story teardowns? In-Reply-To: References: <8d961d900801110210j20dafd84kfd054839595afbfa@mail.gmail.com> Message-ID: <15633065.post@talk.nabble.com> Andreas Axelsson-2 wrote: > >> > Does the plain text story framework support teardowns? There doesn't >> seem to >> > be anywhere to put an "after" method. > >>For now I'd stick this in a Given that >> you use at the beginning of each scenario, for example: >> >> Given "the stash is in a clean state" do >> # yank any old residual gunk here >> end > > Another option, which I found more helpful, is to add another step like: And finally, clean up Which enables you to do all the teardown in: Then "finally, clean up" do{ teardown_stuff } -J -- View this message in context: http://www.nabble.com/Story-teardowns--tp14752945p15633065.html Sent from the rspec-users mailing list archive at Nabble.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080222/0b42a14f/attachment.html From lists at pauldowman.com Fri Feb 22 12:18:53 2008 From: lists at pauldowman.com (Paul Dowman) Date: Fri, 22 Feb 2008 09:18:53 -0800 (PST) Subject: [rspec-users] Autotest with TDD "test-first" problem Message-ID: Hi, I'm mostly quite happy using autotest with rspec, but there's one thing that's been bothering me, and as my test suite grows larger it'd becoming more painful. Autotest re-runs the entire suite whenever a spec that had previously failed passes for the first time. I find that incompatible with writing tests first in classic TDD style. I write the test which fails (because there's no implementation yet), and then just implement the method and watch it pass. But now autotest decides to re-run the entire test suite, which takes a couple of minutes, and in the meantime I'm stuck waiting to see if my next spec will pass or not. Is it possible to change that behavior somehow, so that it doesn't re- run the entire suite every time? Thanks, Paul From lists at pauldowman.com Fri Feb 22 12:21:04 2008 From: lists at pauldowman.com (Paul Dowman) Date: Fri, 22 Feb 2008 09:21:04 -0800 (PST) Subject: [rspec-users] disabling transactional fixtures for one spec Message-ID: Sometimes I need a spec that tests something which can't work inside a transaction. Is it possible to disable transactional fixtures for one spec? I tried: describe "MyClass without transactional fixtures" do before(:all) do Spec::Runner.configure { |config| config.use_transactional_fixtures = false } end after(:all) do Spec::Runner.configure { |config| config.use_transactional_fixtures = true } end end ... but that doesn't work. Thanks, Paul From dchelimsky at gmail.com Sat Feb 23 09:10:21 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Sat, 23 Feb 2008 08:10:21 -0600 Subject: [rspec-users] Autotest with TDD "test-first" problem In-Reply-To: References: Message-ID: <57c63afe0802230610v1e650434l8c3220a2a697fecb@mail.gmail.com> On Fri, Feb 22, 2008 at 11:18 AM, Paul Dowman wrote: > Hi, I'm mostly quite happy using autotest with rspec, but there's one > thing that's been bothering me, and as my test suite grows larger it'd > becoming more painful. > > Autotest re-runs the entire suite whenever a spec that had previously > failed passes for the first time. I find that incompatible with > writing tests first in classic TDD style. I write the test which fails > (because there's no implementation yet), and then just implement the > method and watch it pass. But now autotest decides to re-run the > entire test suite, which takes a couple of minutes, and in the > meantime I'm stuck waiting to see if my next spec will pass or not. > > Is it possible to change that behavior somehow, so that it doesn't re- > run the entire suite every time? Interesting idea. How would you want autotest to decide when to run everything? In the end, this belongs in ZenTest, not RSpec, but we can certainly discuss it here :) Cheers, David > > Thanks, > Paul > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Sat Feb 23 09:17:56 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Sat, 23 Feb 2008 08:17:56 -0600 Subject: [rspec-users] disabling transactional fixtures for one spec In-Reply-To: References: Message-ID: <57c63afe0802230617o2f76db7cie98faa013de501e2@mail.gmail.com> On Fri, Feb 22, 2008 at 11:21 AM, Paul Dowman wrote: > Sometimes I need a spec that tests something which can't work inside a > transaction. Is it possible to disable transactional fixtures for one > spec? > > I tried: > > describe "MyClass without transactional fixtures" do > before(:all) do > Spec::Runner.configure { |config| > config.use_transactional_fixtures = false } > end > > after(:all) do > Spec::Runner.configure { |config| > config.use_transactional_fixtures = true } > end > end > > ... but that doesn't work. Try this - don't know if it works but I think it might: describe "MyClass without transactional fixtures" do self.use_transactional_fixtures = true ... end Let us know if it works. Cheers, David > > Thanks, > Paul > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From joe at pinkpucker.net Sat Feb 23 13:16:18 2008 From: joe at pinkpucker.net (Joe Van Dyk) Date: Sat, 23 Feb 2008 10:16:18 -0800 Subject: [rspec-users] rake task for stories Message-ID: Any reason why there isn't a rake task for stories yet? (I'm looking in trunk) Someone want to share theirs? Joe From dchelimsky at gmail.com Sat Feb 23 13:41:26 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Sat, 23 Feb 2008 12:41:26 -0600 Subject: [rspec-users] rake task for stories In-Reply-To: References: Message-ID: On Feb 23, 2008, at 12:16 PM, "Joe Van Dyk" wrote: > Any reason why there isn't a rake task for stories yet? (I'm > looking in trunk) There is one for rspec_on_rails but it is nothing special. It just calls stories/ all.rb which is up to you to maintain. I know of at least one story command that is in the works. I think that once that exists we'll be in a better spot to wrap it in a rake task. I think, also, that there are still some different conventions at play and it makes sense to wait for a solid convention to emerge in terms of structure and organization. Cheers, David > Someone want to share theirs? > > Joe > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users From mailing_lists at railsnewbie.com Sat Feb 23 15:01:19 2008 From: mailing_lists at railsnewbie.com (Scott Taylor) Date: Sat, 23 Feb 2008 15:01:19 -0500 Subject: [rspec-users] Autotest with TDD "test-first" problem In-Reply-To: References: Message-ID: On Feb 22, 2008, at 12:18 PM, Paul Dowman wrote: > Hi, I'm mostly quite happy using autotest with rspec, but there's one > thing that's been bothering me, and as my test suite grows larger it'd > becoming more painful. > > Autotest re-runs the entire suite whenever a spec that had previously > failed passes for the first time. I find that incompatible with > writing tests first in classic TDD style. I write the test which fails > (because there's no implementation yet), and then just implement the > method and watch it pass. But now autotest decides to re-run the > entire test suite, which takes a couple of minutes, and in the > meantime I'm stuck waiting to see if my next spec will pass or not. > > Is it possible to change that behavior somehow, so that it doesn't re- > run the entire suite every time? I had the same problem - and decided that Autotest wasn't for me. I'm much smarter than autotest, so I know which files I should be re- running, and when. If, as David suggests, you can figure out a good strategy on when to rerun the full suite, continue to use it (just modify the mappings in ~/.autotest (or RAILS_ROOT/.autotest)). Otherwise, autotest is pretty much out (unless you want to work on Deeptest, or SpecDistributed). Scott From joseph at josephholsten.com Sat Feb 23 15:09:32 2008 From: joseph at josephholsten.com (Joseph Anthony Pasquale Holsten) Date: Sat, 23 Feb 2008 14:09:32 -0600 Subject: [rspec-users] Specs versus Stories In-Reply-To: <1d7ddd110802221322s547e3e4eg90ada3df263de5a2@mail.gmail.com> References: <3B87748D-51A3-483D-9A89-9754BAFE9466@civrot.org> <57c63afe0802181544g4615eeb1w92409a0aecb04f92@mail.gmail.com> <5CB219D7-A95E-4E18-87F8-0C640F6C18D6@josephholsten.com> <1d7ddd110802221322s547e3e4eg90ada3df263de5a2@mail.gmail.com> Message-ID: <4CD391F9-4CDA-4CAE-8120-06091DAFE0D4@josephholsten.com> Brian Takita wrote: > There are automated & manual tests. > Automated customer facing & Automated developer tests. > Both customer facing and developer tests can have a unit, functional, > and integration scope. > > That being said, you can have effective high level developer Specs. They certainly can, but I wonder who is. Does anyone have experiences with this specification (opposed to story-telling) at a high level they would share? > Stories are great for facilitation communication, especially with > nondevelopers. It may also be useful in organizing the developer's > thoughts too. There may also be other benefits that I'm missing here. So how about that opposite, is anyone using story-telling internally but not getting them from (or even sharing them with) clients? How's that working? > However, there is an additional investment needed to build up your > Story dsl, than would be expended in using high level Specs. > Does the value of having Stories outweigh the costs in your situation? > I think the best practice is what makes the most sense to you. That's how I always defined best! http:// Joseph Holsten .com -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080223/35211c29/attachment.html From joe at pinkpucker.net Sat Feb 23 15:35:01 2008 From: joe at pinkpucker.net (Joe Van Dyk) Date: Sat, 23 Feb 2008 12:35:01 -0800 Subject: [rspec-users] rake task for stories In-Reply-To: References:

Message-ID: On Sat, Feb 23, 2008 at 10:41 AM, David Chelimsky wrote: > On Feb 23, 2008, at 12:16 PM, "Joe Van Dyk" wrote: > > > Any reason why there isn't a rake task for stories yet? (I'm > > looking in trunk) > > There is one for rspec_on_rails but it is nothing special. It just > calls stories/ all.rb which is up to you to maintain. > > I know of at least one story command that is in the works. I think > that once that exists we'll be in a better spot to wrap it in a rake > task. > > I think, also, that there are still some different conventions at play > and it makes sense to wait for a solid convention to emerge in terms > of structure and organization. I can't seem to find the rspec_on_rails story task. What file is it in? From joe at pinkpucker.net Sat Feb 23 15:39:58 2008 From: joe at pinkpucker.net (Joe Van Dyk) Date: Sat, 23 Feb 2008 12:39:58 -0800 Subject: [rspec-users] Autotest with TDD "test-first" problem In-Reply-To: <57c63afe0802230610v1e650434l8c3220a2a697fecb@mail.gmail.com> References: <57c63afe0802230610v1e650434l8c3220a2a697fecb@mail.gmail.com> Message-ID: On Sat, Feb 23, 2008 at 6:10 AM, David Chelimsky wrote: > On Fri, Feb 22, 2008 at 11:18 AM, Paul Dowman wrote: > > Hi, I'm mostly quite happy using autotest with rspec, but there's one > > thing that's been bothering me, and as my test suite grows larger it'd > > becoming more painful. > > > > Autotest re-runs the entire suite whenever a spec that had previously > > failed passes for the first time. I find that incompatible with > > writing tests first in classic TDD style. I write the test which fails > > (because there's no implementation yet), and then just implement the > > method and watch it pass. But now autotest decides to re-run the > > entire test suite, which takes a couple of minutes, and in the > > meantime I'm stuck waiting to see if my next spec will pass or not. > > > > Is it possible to change that behavior somehow, so that it doesn't re- > > run the entire suite every time? > > Interesting idea. How would you want autotest to decide when to run everything? > > In the end, this belongs in ZenTest, not RSpec, but we can certainly > discuss it here :) Would be interesting to have the ability to run multiple tests at once. For example, one test runner could repeatedly run (or once a minute, or whatever) the entire test suite. And one test runner could run the related tests for the file you change. Perhaps two autotest instances, running off different test databases? From dchelimsky at gmail.com Sat Feb 23 18:06:36 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Sat, 23 Feb 2008 17:06:36 -0600 Subject: [rspec-users] rake task for stories In-Reply-To: References:

Message-ID: <57c63afe0802231506j3e80d751h294717c06d2c8492@mail.gmail.com> On Sat, Feb 23, 2008 at 2:35 PM, Joe Van Dyk wrote: > On Sat, Feb 23, 2008 at 10:41 AM, David Chelimsky wrote: > > On Feb 23, 2008, at 12:16 PM, "Joe Van Dyk" wrote: > > > > > Any reason why there isn't a rake task for stories yet? (I'm > > > looking in trunk) > > > > There is one for rspec_on_rails but it is nothing special. It just > > calls stories/ all.rb which is up to you to maintain. > > > > I know of at least one story command that is in the works. I think > > that once that exists we'll be in a better spot to wrap it in a rake > > task. > > > > I think, also, that there are still some different conventions at play > > and it makes sense to wait for a solid convention to emerge in terms > > of structure and organization. > > I can't seem to find the rspec_on_rails story task. What file is it in? I take it back. It does not get generated. I've just been adding one to my projects that runs stories/all.rb. Guess it's so trivial that I forgot it wasn't generated :) > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From pergesu at gmail.com Sat Feb 23 18:19:08 2008 From: pergesu at gmail.com (Pat Maddox) Date: Sat, 23 Feb 2008 15:19:08 -0800 Subject: [rspec-users] [Q] how to restructure tests for an abstract class? In-Reply-To: References: Message-ID: <810a540e0802231519v97659dek9eab36b2fa6836ec@mail.gmail.com> On Thu, Feb 21, 2008 at 8:09 AM, Chuck Remes wrote: > While practicing BDD on my first-ever BDD project, I have come to a > point where it makes sense to change my original class to an abstract > class and create one (or more) concrete subclasses that implement a > specific method. What is the right way to restructure the tests in > this scenario? Do I leave the existing tests in place and just create > a new spec file that instantiates and tests the concrete subclass? > > I think I can continue to instantiate my "abstract" parent as long as > I don't go near the behavior that will be defined by the concrete > subclasses. Is that the right thing to do? > > Thanks for any hints. > > cr > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > I think that shared example groups might be useful. Pat From agilejoe at gmail.com Sun Feb 24 06:29:00 2008 From: agilejoe at gmail.com (Joe Ocampo) Date: Sun, 24 Feb 2008 05:29:00 -0600 Subject: [rspec-users] Newbie question Context vs Describe Message-ID: <93cf9750802240329j72a629d1v64291faf0040ae6c@mail.gmail.com> Background just started programming in Ruby literally 12 hours ago and have a question regarding context and describe methods. Reading the RDoc it indicated that "context" is an alias for "describe". So I decided to try to the following syntax seeing this is how I would approach it in C# with NBehave. require 'user' describe User do before(:each) do @user = User.new end context "(adding assigned role)" do before(:each) do @user.assign_role("Manager") end specify "should be in any roles assigned to it" do @user.should be_in_role("Manager") end specify "should not be in any role not assigned to it" do @user.should_not be_in_role("unassigned role") end end context "(adding assigned group)" do end end I thought I could use the "describe" method to indicate the Type that the specifications where going to be concerning. I then would place the type into a behavioral context to assert the intended behavior against that context. This combination resulted in User never being instantiated for the internal context. (nil:NilClass). However! If I flip the "context" and "description" it works. Am I doing something wrong? require 'user' context User do ... describe "(adding assigned role)" do ... end end -- God Bless, Joe Ocampo agilejoe.lostechies.com "How do you benefit if you gain the whole world but lose your soul in the process?" Mark 8:36 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080224/1f07d223/attachment.html From dchelimsky at gmail.com Sun Feb 24 09:26:40 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Sun, 24 Feb 2008 08:26:40 -0600 Subject: [rspec-users] Newbie question Context vs Describe In-Reply-To: <93cf9750802240329j72a629d1v64291faf0040ae6c@mail.gmail.com> References: <93cf9750802240329j72a629d1v64291faf0040ae6c@mail.gmail.com> Message-ID: <57c63afe0802240626s4e1a3c64x7fca8c0d01f31412@mail.gmail.com> On Sun, Feb 24, 2008 at 5:29 AM, Joe Ocampo wrote: > Background just started programming in Ruby literally 12 hours ago and have > a question regarding context and describe methods. Reading the RDoc it > indicated that "context" is an alias for "describe". So I decided to try to > the following syntax seeing this is how I would approach it in C# with > NBehave. > require 'user' > > describe User do > > before(:each) do > @user = User.new > end > > context "(adding assigned role)" do > before(:each) do > @user.assign_role("Manager") > end > > specify "should be in any roles assigned to it" do > @user.should be_in_role("Manager") > end > > specify "should not be in any role not assigned to it" do > @user.should_not be_in_role("unassigned role") > end > end > > context "(adding assigned group)" do > > end > end > > I thought I could use the "describe" method to indicate the Type that the > specifications where going to be concerning. I then would place the type > into a behavioral context to assert the intended behavior against that > context. At first glance, that is really cool. We've also batted around some other names like #facet or #behaviour. > This combination resulted in User never being instantiated for the internal > context. (nil:NilClass). However! If I flip the "context" and > "description" it works. Am I doing something wrong? No you're not doing something wrong - there are two different places where describe is defined. One in main (the outermost layer) and one inside an ExampleGroup. The one in the example group isn't aliased. So to solve that for the short term in your own code you can do this in your spec_helper.rb file: module Spec::Example::ExampleGroupMethods alias :context :describe end In terms of getting that into RSpec, why don't you enter a feature request at http://rspec.lighthouseapp.com and we can discuss the merits of this there. As I said, I like it at first glance, but I want to think about it and get other opinions before just adding it (as context is only there for backwards compatibility right now). Thanks, David > > require 'user' > > context User do > ... > describe "(adding assigned role)" do > ... > end > end > > -- > God Bless, > > Joe Ocampo > agilejoe.lostechies.com > > "How do you benefit if you gain the whole world but lose your soul in the > process?" Mark 8:36 > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From agilejoe at gmail.com Sun Feb 24 14:42:30 2008 From: agilejoe at gmail.com (Joe Ocampo) Date: Sun, 24 Feb 2008 13:42:30 -0600 Subject: [rspec-users] Newbie question Context vs Describe In-Reply-To: <57c63afe0802240626s4e1a3c64x7fca8c0d01f31412@mail.gmail.com> References: <93cf9750802240329j72a629d1v64291faf0040ae6c@mail.gmail.com> <57c63afe0802240626s4e1a3c64x7fca8c0d01f31412@mail.gmail.com> Message-ID: <93cf9750802241142j5b73464wc423057d9b2a457f@mail.gmail.com> >At first glance, that is really cool. We've also batted around some >other names like #facet or #behavior. LOL..I smile because we went through the same semantic struggles as well. The funny thing is the rSpec project led us to our resolve. :-) We basically came to this conclusion every object has a behavior but that behavior is governed by a context or multiple context concerning that type. Given that we are specifying how an object should behave under a certain context, the DSL quickly took shape. About the only difference is we introduced the term [concerning] instead of describe. pseudo DSL: these specs are concerning this [Type] when this [type] is in this context then specify that it should behave this way In C# this DSL creates a lot of noise in the syntax! For example: [Context, Concerning("EquationGenerator")] public class When_initializing_the_EquationGenerator_with_one_and_five : NBehave.NUnitSpecBase { protected override void Before_each_spec() { _generator = new EquationGenerator(_LowerBound, _UpperBound); } [Specification] public void Should_generate_equations_where_the_left_hand_side_is_greater_than_or_equal_to_the_lower_bound() { IList equations = _generator.GenerateEquations(); foreach (Equation equation in equations) { equation.LeftHandSide.should_be_greater_than_or_equal_to (_LowerBound); } } [Specification] public void Should_generate_equations_where_the_left_hand_side_is_less_than_or_equal_to_the_upper_bound()... [Specification] public void Should_generate_equations_where_the_right_hand_side_is_greater_than_or_equal_to_the_lower_bound()... [Specification] public void Should_generate_equations_where_the_right_hand_side_is_less_than_or_equal_to_the_upper_bound()... [Specification] public void Should_generate_twenty_five_equations()... } I think we have taken this as far as it can go for a statically typed language. Hence my interest in rSpec especially once MS gets IronRuby baked! I can easily see Ruby taking over the MS culture once IronRuby is complete. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080224/390f8ba5/attachment.html From grail at goldweb.com.au Sun Feb 24 18:54:11 2008 From: grail at goldweb.com.au (Alex Satrapa) Date: Mon, 25 Feb 2008 10:54:11 +1100 Subject: [rspec-users] How to dump contents produced during spec evaluation? Message-ID: <362AC3D2-8610-47FD-8560-2A9A8715EE52@goldweb.com.au> In a story, I have the following happening: post("/resources/", 'resource' => request_attrs) response.should render_template('resource/new') response.should have_tag('*', /must have one or more X defined/) In the ResourceController spec, I have the following happening: post( :create, :resource => request_attrs ) response.should render_template('resource/new') response.should have_tag('*', /must have one or more X defined/) The problem I'm having is that the story works just fine, but the spec claims that there are no tags matching '*' in the response. Is there any way I can dump the contents of the response, in the hope that they might tip me off as to the cause of this error? I've checked the stories, and I do not have any steps with the same description as the one that passes in the story but fails in the spec. I've stumbled across this before, especially where a step is "when the user creates a new resource" - often the first one the story runner sees will become the definition of "when the user creates a new resource", and later versions have to be renamed eg: "when the user creates a new resource with special feature X". That's not happening here as far as I can tell. Any clues on where to start looking? Thanks Alex From dchelimsky at gmail.com Sun Feb 24 18:58:25 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Sun, 24 Feb 2008 17:58:25 -0600 Subject: [rspec-users] How to dump contents produced during spec evaluation? In-Reply-To: <362AC3D2-8610-47FD-8560-2A9A8715EE52@goldweb.com.au> References: <362AC3D2-8610-47FD-8560-2A9A8715EE52@goldweb.com.au> Message-ID: <57c63afe0802241558g2f17ec82qa17c144d2372cb05@mail.gmail.com> On Sun, Feb 24, 2008 at 5:54 PM, Alex Satrapa wrote: > In a story, I have the following happening: > post("/resources/", 'resource' => request_attrs) > response.should render_template('resource/new') > response.should have_tag('*', /must have one or more X defined/) > > In the ResourceController spec, I have the following happening: > post( :create, :resource => request_attrs ) > response.should render_template('resource/new') > response.should have_tag('*', /must have one or more X defined/) > > The problem I'm having is that the story works just fine, but the > spec claims that there are no tags matching '*' in the response. > > Is there any way I can dump the contents of the response, in the hope > that they might tip me off as to the cause of this error? puts response.body > > I've checked the stories, and I do not have any steps with the same > description as the one that passes in the story but fails in the > spec. I've stumbled across this before, especially where a step is > "when the user creates a new resource" - often the first one the > story runner sees will become the definition of "when the user > creates a new resource", and later versions have to be renamed eg: > "when the user creates a new resource with special feature X". > That's not happening here as far as I can tell. > > Any clues on where to start looking? > > Thanks > Alex > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From grail at goldweb.com.au Sun Feb 24 19:29:45 2008 From: grail at goldweb.com.au (Alex Satrapa) Date: Mon, 25 Feb 2008 11:29:45 +1100 Subject: [rspec-users] How to dump contents produced during spec evaluation? In-Reply-To: <57c63afe0802241558g2f17ec82qa17c144d2372cb05@mail.gmail.com> References: <362AC3D2-8610-47FD-8560-2A9A8715EE52@goldweb.com.au> <57c63afe0802241558g2f17ec82qa17c144d2372cb05@mail.gmail.com> Message-ID: On 25/02/2008, at 10:58 , David Chelimsky wrote: > On Sun, Feb 24, 2008 at 5:54 PM, Alex Satrapa > wrote: >> In the ResourceController spec, I have the following happening: >> post( :create, :resource => request_attrs ) >> response.should render_template('resource/new') >> response.should have_tag('*', /must have one or more X defined/) >> Is there any way I can dump the contents of the response, in the >> hope >> that they might tip me off as to the cause of this error? > > puts response.body Okay, this is weird. The result seems to indicate that the body of the response is the literal text, "resource/new": My autotest results show (I've changed the name of the resource to 'resource'): > ..........resources/new > F.............. > > 1) > 'ResourcesController on 'POST /resources/', with an invalid request > should generate an error message indicating that magic parts are > missing' FAILED > Expected at least 1 element matching "*", found 0. > is not true. > ./spec/controllers/resources_controller_spec.rb:138: > script/spec:4: > > Finished in 0.753821 seconds > > 25 examples, 1 failure Time to go through all my other specs and check that they're working (or breaking) the same way, to see if I can figure out what I've done wrong. Alex From dchelimsky at gmail.com Sun Feb 24 19:33:39 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Sun, 24 Feb 2008 18:33:39 -0600 Subject: [rspec-users] How to dump contents produced during spec evaluation? In-Reply-To: References: <362AC3D2-8610-47FD-8560-2A9A8715EE52@goldweb.com.au> <57c63afe0802241558g2f17ec82qa17c144d2372cb05@mail.gmail.com> Message-ID: <57c63afe0802241633u40722ed5s6a5a3e9de78a9fd4@mail.gmail.com> On Sun, Feb 24, 2008 at 6:29 PM, Alex Satrapa wrote: > On 25/02/2008, at 10:58 , David Chelimsky wrote: > > > On Sun, Feb 24, 2008 at 5:54 PM, Alex Satrapa > > wrote: > > >> In the ResourceController spec, I have the following happening: > >> post( :create, :resource => request_attrs ) > >> response.should render_template('resource/new') > >> response.should have_tag('*', /must have one or more X defined/) > > > >> Is there any way I can dump the contents of the response, in the > >> hope > >> that they might tip me off as to the cause of this error? > > > > puts response.body > > Okay, this is weird. The result seems to indicate that the body of > the response is the literal text, "resource/new": Ah yes - of course. Give this a read and see if it answers your question: http://rspec.info/documentation/rails/writing/controllers.html > > My autotest results show (I've changed the name of the resource to > 'resource'): > > ..........resources/new > > F.............. > > > > 1) > > 'ResourcesController on 'POST /resources/', with an invalid request > > should generate an error message indicating that magic parts are > > missing' FAILED > > Expected at least 1 element matching "*", found 0. > > is not true. > > ./spec/controllers/resources_controller_spec.rb:138: > > script/spec:4: > > > > Finished in 0.753821 seconds > > > > 25 examples, 1 failure > > > Time to go through all my other specs and check that they're working > (or breaking) the same way, to see if I can figure out what I've done > wrong. > > > > Alex > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From cwdinfo at gmail.com Sun Feb 24 19:35:02 2008 From: cwdinfo at gmail.com (s.ross) Date: Sun, 24 Feb 2008 16:35:02 -0800 Subject: [rspec-users] How to dump contents produced during spec evaluation? In-Reply-To: References: <362AC3D2-8610-47FD-8560-2A9A8715EE52@goldweb.com.au> <57c63afe0802241558g2f17ec82qa17c144d2372cb05@mail.gmail.com> Message-ID: <2825A7F0-374A-4555-B0A7-D5A8CADB837E@gmail.com> On Feb 24, 2008, at 4:29 PM, Alex Satrapa wrote: > Okay, this is weird. The result seems to indicate that the body of > the response is the literal text, "resource/new": > > My autotest results show (I've changed the name of the resource to > 'resource'): >> Try puts response.class puts response.inspect to see whether you have what you think you do. From dchelimsky at gmail.com Sun Feb 24 19:42:56 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Sun, 24 Feb 2008 18:42:56 -0600 Subject: [rspec-users] How to dump contents produced during spec evaluation? In-Reply-To: <2825A7F0-374A-4555-B0A7-D5A8CADB837E@gmail.com> References: <362AC3D2-8610-47FD-8560-2A9A8715EE52@goldweb.com.au> <57c63afe0802241558g2f17ec82qa17c144d2372cb05@mail.gmail.com> <2825A7F0-374A-4555-B0A7-D5A8CADB837E@gmail.com> Message-ID: <57c63afe0802241642v6b1499eai6f61bd4b337f315f@mail.gmail.com> On Sun, Feb 24, 2008 at 6:35 PM, s.ross wrote: > On Feb 24, 2008, at 4:29 PM, Alex Satrapa wrote: > > > Okay, this is weird. The result seems to indicate that the body of > > the response is the literal text, "resource/new": > > > > My autotest results show (I've changed the name of the resource to > > 'resource'): > >> > > Try > > puts response.class > puts response.inspect Steve - it's because of isolation - I pointed Alex to the docs. > > to see whether you have what you think you do. > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From grail at goldweb.com.au Sun Feb 24 20:10:22 2008 From: grail at goldweb.com.au (Alex Satrapa) Date: Mon, 25 Feb 2008 12:10:22 +1100 Subject: [rspec-users] How to dump contents produced during spec evaluation? In-Reply-To: <57c63afe0802241642v6b1499eai6f61bd4b337f315f@mail.gmail.com> References: <362AC3D2-8610-47FD-8560-2A9A8715EE52@goldweb.com.au> <57c63afe0802241558g2f17ec82qa17c144d2372cb05@mail.gmail.com> <2825A7F0-374A-4555-B0A7-D5A8CADB837E@gmail.com> <57c63afe0802241642v6b1499eai6f61bd4b337f315f@mail.gmail.com> Message-ID: On 25/02/2008, at 11:42 , David Chelimsky wrote: > Steve - it's because of isolation - I pointed Alex to the docs. Yup, I'm having a low-caffeine day apparently. I'm going to great pains to isolate just the portions of the controller that need to be designed (using mocks and stubs), then slapping a test in there that looks for an output that the mock will never generate. The error message is already specced in the model spec and the view spec, and it's already checked for in the story - do I need more testing for that failure path? Alex From mlangenberg at gmail.com Mon Feb 25 04:30:36 2008 From: mlangenberg at gmail.com (Matthijs Langenberg) Date: Mon, 25 Feb 2008 10:30:36 +0100 Subject: [rspec-users] [Q] how to restructure tests for an abstract class? In-Reply-To: <810a540e0802231519v97659dek9eab36b2fa6836ec@mail.gmail.com> References: <810a540e0802231519v97659dek9eab36b2fa6836ec@mail.gmail.com> Message-ID: <27c0ac6d0802250130n24a1c2b6o22d56880f09f3c6d@mail.gmail.com> Question is, would you duplicate the specs for all the classes that include a certain module (through shared behaviour for example), or would you use one set of specs for just the module, and specify that a class should include that module? On Sun, Feb 24, 2008 at 12:19 AM, Pat Maddox wrote: > On Thu, Feb 21, 2008 at 8:09 AM, Chuck Remes > wrote: > > While practicing BDD on my first-ever BDD project, I have come to a > > point where it makes sense to change my original class to an abstract > > class and create one (or more) concrete subclasses that implement a > > specific method. What is the right way to restructure the tests in > > this scenario? Do I leave the existing tests in place and just create > > a new spec file that instantiates and tests the concrete subclass? > > > > I think I can continue to instantiate my "abstract" parent as long as > > I don't go near the behavior that will be defined by the concrete > > subclasses. Is that the right thing to do? > > > > Thanks for any hints. > > > > cr > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > I think that shared example groups might be useful. > > Pat > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080225/0c9a4ac4/attachment.html From win at wincent.com Mon Feb 25 06:09:31 2008 From: win at wincent.com (Wincent Colaiuta) Date: Mon, 25 Feb 2008 12:09:31 +0100 Subject: [rspec-users] Route generation inside mailer specs Message-ID: <8540ADC7-AA51-4AB1-A686-B674B1A83B24@wincent.com> Rails mailers live under "app/models" even though they have some controller-like responsibilities, and I stick the corresponding specs under "spec/models" In one of my mailers I use the kind of dynamic route generation methods that Rails provides, things like foo_bar_path and foo_bar_url. What would I need to do to get access to those methods from within my mailer specs? I basically want to confirm the presence of a url in the generated body, something like: url = foo_bar_url(@foo, @bar) @mail.body.should match(url) Evidently I need to include some module or something, but as it's all dynamically generated I have no idea where to begin looking. Oddly enough, the foo_bar_url _is_ defined within the context of the example (ie. I don't get an "undefined method foo_bar_url in #" exception), but what I _do_ get is: You have a nil object when you didn't expect it! The error occurred while evaluating nil.foo_bar_url So the message is being sent to nil... not what I would have expected. Cheers, Wincent From cremes.devlist at mac.com Mon Feb 25 07:23:24 2008 From: cremes.devlist at mac.com (Chuck Remes) Date: Mon, 25 Feb 2008 06:23:24 -0600 Subject: [rspec-users] [Q] how to restructure tests for an abstract class? In-Reply-To: <27c0ac6d0802250130n24a1c2b6o22d56880f09f3c6d@mail.gmail.com> References: <810a540e0802231519v97659dek9eab36b2fa6836ec@mail.gmail.com> <27c0ac6d0802250130n24a1c2b6o22d56880f09f3c6d@mail.gmail.com> Message-ID: Thanks for asking this question. This is exactly what I was going to write, but you beat me to it! (Sorry for the top-post; just following the last responder.) cr On Feb 25, 2008, at 3:30 AM, Matthijs Langenberg wrote: > Question is, would you duplicate the specs for all the classes that > include a certain module (through shared behaviour for example), or > would you use one set of specs for just the module, and specify that > a class should include that module? > > On Sun, Feb 24, 2008 at 12:19 AM, Pat Maddox > wrote: > On Thu, Feb 21, 2008 at 8:09 AM, Chuck Remes > wrote: > > While practicing BDD on my first-ever BDD project, I have come to a > > point where it makes sense to change my original class to an > abstract > > class and create one (or more) concrete subclasses that implement a > > specific method. What is the right way to restructure the tests in > > this scenario? Do I leave the existing tests in place and just > create > > a new spec file that instantiates and tests the concrete subclass? > > > > I think I can continue to instantiate my "abstract" parent as > long as > > I don't go near the behavior that will be defined by the concrete > > subclasses. Is that the right thing to do? > > > > Thanks for any hints. > > > > cr > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > I think that shared example groups might be useful. > > Pat > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080225/74385466/attachment-0001.html From dchelimsky at gmail.com Mon Feb 25 09:30:47 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 25 Feb 2008 08:30:47 -0600 Subject: [rspec-users] [Q] how to restructure tests for an abstract class? In-Reply-To: References: <810a540e0802231519v97659dek9eab36b2fa6836ec@mail.gmail.com> <27c0ac6d0802250130n24a1c2b6o22d56880f09f3c6d@mail.gmail.com> Message-ID: <57c63afe0802250630i38c88d8eh36d4cb17f2364f3c@mail.gmail.com> On Mon, Feb 25, 2008 at 6:23 AM, Chuck Remes wrote: > Thanks for asking this question. This is exactly what I was going to write, > but you beat me to it! > > (Sorry for the top-post; just following the last responder.) > > cr > > > > On Feb 25, 2008, at 3:30 AM, Matthijs Langenberg wrote: > Question is, would you duplicate the specs for all the classes that include > a certain module (through shared behaviour for example), or would you use > one set of specs for just the module, and specify that a class should > include that module? Matthijs - I'd throw the same question back to you. Have you tried both approaches? How have they worked out for you? I won't wait for your answer :). But I am curious about other people's experiences with this. I can tell you this from my own experience - I tend to use shared groups for this for a couple of reasons. One, I like to see the specs for each object. Seeing this .... Thing - should include the Foo module in the spec output doesn't really help me understand what Thing does. Keep in mind that including a module does not guarantee that the methods in that module are used. They can be redefined. They can also behave differently depending on the state of the including object. For these reasons, I generally don't really like to specify module inclusion. I try to approach this from the perspective of "how do I want instances of this type to behave?" When I find duplication in behaviour across types, I may extract a shared example group. The discipline challenge really comes in when I already have a shared group and I'm adding a new type and my inner designer is quite certain that it should include the same module. I can tell you that I've gone at this from two directions - either spec'ing the new type cold or just including the shared group in the spec for the type and including the module. Neither route has been perfect every time :) Hope that helps ... a little. Cheers, David > > On Sun, Feb 24, 2008 at 12:19 AM, Pat Maddox wrote: > > > > > > > > On Thu, Feb 21, 2008 at 8:09 AM, Chuck Remes > wrote: > > > While practicing BDD on my first-ever BDD project, I have come to a > > > point where it makes sense to change my original class to an abstract > > > class and create one (or more) concrete subclasses that implement a > > > specific method. What is the right way to restructure the tests in > > > this scenario? Do I leave the existing tests in place and just create > > > a new spec file that instantiates and tests the concrete subclass? > > > > > > I think I can continue to instantiate my "abstract" parent as long as > > > I don't go near the behavior that will be defined by the concrete > > > subclasses. Is that the right thing to do? > > > > > > Thanks for any hints. > > > > > > cr > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > > I think that shared example groups might be useful. > > > > Pat > > > > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From rupert at rupespad.com Mon Feb 25 10:01:55 2008 From: rupert at rupespad.com (Rupert Voelcker) Date: Mon, 25 Feb 2008 15:01:55 +0000 Subject: [rspec-users] Problems running pre-commit Message-ID: <52138110802250701j50b40cb3ic8bce2664d71058d@mail.gmail.com> Have been having some probs getting the pre-commit to run so help would be appreciated (then I can add some specs to my patch) - thanks for the suggestion to post here Dave :) I'm on OS X and have checked out the source from svn://rubyforge.org/var/svn/rspec/trunk (rev 3317) rake check_for_gem_dependencies (nothing to see here) rake install_dependencies (long wait, much network activity, various rails versions appear in example_rails_app) rename database.sqlite3.yml to database.yml in example_rails_app/config rake pre_commit --trace Some tests fail (if this helps) -------------------------------------------------------------- 1) 'ExampleGroup with test/unit/interop with failing examples should return an exit code of 256' FAILED expected: 256, got: # (using ==) Diff: @@ -1,2 +1,2 @@ -256 +# ./spec/spec/interop/test/unit/spec_spec.rb:30: 2) 'ExampleGroup with test/unit/interop with example that raises an error should return an exit code of 256' FAILED expected: 256, got: # (using ==) Diff: @@ -1,2 +1,2 @@ -256 +# ./spec/spec/interop/test/unit/spec_spec.rb:42: 3) 'Test::Unit::TestCase with failing test case should return an exit code of 256' FAILED expected: 256, got: # (using ==) Diff: @@ -1,2 +1,2 @@ -256 +# ./spec/spec/interop/test/unit/testcase_spec.rb:30: 4) 'Test::Unit::TestCase with test case that raises an error should return an exit code of 256' FAILED expected: 256, got: # (using ==) Diff: @@ -1,2 +1,2 @@ -256 +# ./spec/spec/interop/test/unit/testcase_spec.rb:42: Finished in 23.137056 seconds 1305 examples, 4 failures, 8 pending -------------------------------------------------------------- and the pre-commit fails with the trace below Hopefully it's just something silly I've not done or done wrong, but I can't think what.... Cheers Rupert -------------------------------------------------------------- ry_spec.rb" "spec/spec/story/world_spec.rb" "spec/spec/translator_spec.rb" --format html:../doc/output/report.html --backtrace failed ./lib/spec/rake/spectask.rb:184:in `define' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1003:in `verbose' ./lib/spec/rake/spectask.rb:153:in `define' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in `invoke_with_call_chain' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `invoke_with_call_chain' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/pre_commit.rb:9:in `rake_invoke' /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/core.rb:10:in `website' /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/core.rb:4:in `pre_commit' /Users/rupert/stuff/downloads/rspec_new/rspec/rakefile:162 /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in `invoke_with_call_chain' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `invoke_with_call_chain' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1931:in `invoke_task' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `each' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in `standard_exception_handling' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1903:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1881:in `run' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in `standard_exception_handling' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1878:in `run' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/bin/rake:31 /usr/local/bin/rake:19:in `load' /usr/local/bin/rake:19 rake aborted! RSpec Core pre_commit failed /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/rspec.rb:64:in `pre_commit_core' /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/rspec.rb:61:in `chdir' /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/rspec.rb:61:in `pre_commit_core' /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/rspec.rb:6:in `pre_commit' /Users/rupert/stuff/downloads/rspec_new/rakefile:9 /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in `invoke_with_call_chain' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `invoke_with_call_chain' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1931:in `invoke_task' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `each' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in `standard_exception_handling' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1903:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1881:in `run' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in `standard_exception_handling' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1878:in `run' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/bin/rake:31 /usr/local/bin/rake:19:in `load' /usr/local/bin/rake:19 From dchelimsky at gmail.com Mon Feb 25 10:14:32 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 25 Feb 2008 09:14:32 -0600 Subject: [rspec-users] Problems running pre-commit In-Reply-To: <52138110802250701j50b40cb3ic8bce2664d71058d@mail.gmail.com> References: <52138110802250701j50b40cb3ic8bce2664d71058d@mail.gmail.com> Message-ID: <57c63afe0802250714s693a141ai944750630051824b@mail.gmail.com> On Mon, Feb 25, 2008 at 9:01 AM, Rupert Voelcker wrote: > Have been having some probs getting the pre-commit to run so help > would be appreciated (then I can add some specs to my patch) - thanks > for the suggestion to post here Dave :) > > I'm on OS X and have checked out the source from > svn://rubyforge.org/var/svn/rspec/trunk (rev 3317) > > rake check_for_gem_dependencies (nothing to see here) > rake install_dependencies (long wait, much network activity, various > rails versions appear in example_rails_app) > > rename database.sqlite3.yml to database.yml in example_rails_app/config > > rake pre_commit --trace There are a couple of steps missing. Did you read the README (http://rspec.info/rdoc/files/README.html)? Also - I see you're using sqlite3. I can't run mine with sqlite3 right now. It's probably been this way for a while, because it looks like the error is the "You have 5 pending migrations:" error, which has been around for some time. Try following the directions in the README to the letter (including using mysql instead of sqlite3) and see if that works. > > Some tests fail (if this helps) > > -------------------------------------------------------------- > > 1) > 'ExampleGroup with test/unit/interop with failing examples should > return an exit code of 256' FAILED > expected: 256, > got: # (using ==) > Diff: > @@ -1,2 +1,2 @@ > -256 > +# > > ./spec/spec/interop/test/unit/spec_spec.rb:30: > > 2) > 'ExampleGroup with test/unit/interop with example that raises an error > should return an exit code of 256' FAILED > expected: 256, > got: # (using ==) > Diff: > @@ -1,2 +1,2 @@ > -256 > +# > > ./spec/spec/interop/test/unit/spec_spec.rb:42: > > 3) > 'Test::Unit::TestCase with failing test case should return an exit > code of 256' FAILED > expected: 256, > got: # (using ==) > Diff: > @@ -1,2 +1,2 @@ > -256 > +# > > ./spec/spec/interop/test/unit/testcase_spec.rb:30: > > 4) > 'Test::Unit::TestCase with test case that raises an error should > return an exit code of 256' FAILED > expected: 256, > got: # (using ==) > Diff: > @@ -1,2 +1,2 @@ > -256 > +# > > ./spec/spec/interop/test/unit/testcase_spec.rb:42: > > Finished in 23.137056 seconds > > 1305 examples, 4 failures, 8 pending > > -------------------------------------------------------------- > > and the pre-commit fails with the trace below > > Hopefully it's just something silly I've not done or done wrong, but I > can't think what.... > > Cheers > > Rupert > > -------------------------------------------------------------- > > ry_spec.rb" "spec/spec/story/world_spec.rb" > "spec/spec/translator_spec.rb" --format html:../doc/output/report.html > --backtrace failed > ./lib/spec/rake/spectask.rb:184:in `define' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1003:in `verbose' > ./lib/spec/rake/spectask.rb:153:in `define' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in > `invoke_with_call_chain' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in > `invoke_with_call_chain' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/pre_commit.rb:9:in > `rake_invoke' > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/core.rb:10:in > `website' > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/core.rb:4:in > `pre_commit' > /Users/rupert/stuff/downloads/rspec_new/rspec/rakefile:162 > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in > `invoke_with_call_chain' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in > `invoke_with_call_chain' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1931:in `invoke_task' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `each' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in > `standard_exception_handling' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1903:in `top_level' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1881:in `run' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in > `standard_exception_handling' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1878:in `run' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/bin/rake:31 > /usr/local/bin/rake:19:in `load' > /usr/local/bin/rake:19 > rake aborted! > RSpec Core pre_commit failed > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/rspec.rb:64:in > `pre_commit_core' > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/rspec.rb:61:in > `chdir' > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/rspec.rb:61:in > `pre_commit_core' > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/rspec.rb:6:in > `pre_commit' > /Users/rupert/stuff/downloads/rspec_new/rakefile:9 > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in > `invoke_with_call_chain' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in > `invoke_with_call_chain' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1931:in `invoke_task' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `each' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in > `standard_exception_handling' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1903:in `top_level' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1881:in `run' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in > `standard_exception_handling' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1878:in `run' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/bin/rake:31 > /usr/local/bin/rake:19:in `load' > /usr/local/bin/rake:19 > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Mon Feb 25 10:31:38 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 25 Feb 2008 09:31:38 -0600 Subject: [rspec-users] Problems running pre-commit In-Reply-To: <57c63afe0802250714s693a141ai944750630051824b@mail.gmail.com> References: <52138110802250701j50b40cb3ic8bce2664d71058d@mail.gmail.com> <57c63afe0802250714s693a141ai944750630051824b@mail.gmail.com> Message-ID: <57c63afe0802250731o1cd2282dne3388328552174e3@mail.gmail.com> On Mon, Feb 25, 2008 at 9:14 AM, David Chelimsky wrote: > On Mon, Feb 25, 2008 at 9:01 AM, Rupert Voelcker wrote: > > Have been having some probs getting the pre-commit to run so help > > would be appreciated (then I can add some specs to my patch) - thanks > > for the suggestion to post here Dave :) > > > > I'm on OS X and have checked out the source from > > svn://rubyforge.org/var/svn/rspec/trunk (rev 3317) > > > > rake check_for_gem_dependencies (nothing to see here) > > rake install_dependencies (long wait, much network activity, various > > rails versions appear in example_rails_app) > > > > rename database.sqlite3.yml to database.yml in example_rails_app/config > > > > rake pre_commit --trace > > There are a couple of steps missing. Did you read the README > (http://rspec.info/rdoc/files/README.html)? > > Also - I see you're using sqlite3. I can't run mine with sqlite3 right > now. It's probably been this way for a while, because it looks like > the error is the "You have 5 pending migrations:" error, which has > been around for some time. FYI: http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/306 > > Try following the directions in the README to the letter (including > using mysql instead of sqlite3) and see if that works. > > > > > > > Some tests fail (if this helps) > > > > -------------------------------------------------------------- > > > > 1) > > 'ExampleGroup with test/unit/interop with failing examples should > > return an exit code of 256' FAILED > > expected: 256, > > got: # (using ==) > > Diff: > > @@ -1,2 +1,2 @@ > > -256 > > +# > > > > ./spec/spec/interop/test/unit/spec_spec.rb:30: > > > > 2) > > 'ExampleGroup with test/unit/interop with example that raises an error > > should return an exit code of 256' FAILED > > expected: 256, > > got: # (using ==) > > Diff: > > @@ -1,2 +1,2 @@ > > -256 > > +# > > > > ./spec/spec/interop/test/unit/spec_spec.rb:42: > > > > 3) > > 'Test::Unit::TestCase with failing test case should return an exit > > code of 256' FAILED > > expected: 256, > > got: # (using ==) > > Diff: > > @@ -1,2 +1,2 @@ > > -256 > > +# > > > > ./spec/spec/interop/test/unit/testcase_spec.rb:30: > > > > 4) > > 'Test::Unit::TestCase with test case that raises an error should > > return an exit code of 256' FAILED > > expected: 256, > > got: # (using ==) > > Diff: > > @@ -1,2 +1,2 @@ > > -256 > > +# > > > > ./spec/spec/interop/test/unit/testcase_spec.rb:42: > > > > Finished in 23.137056 seconds > > > > 1305 examples, 4 failures, 8 pending > > > > -------------------------------------------------------------- > > > > and the pre-commit fails with the trace below > > > > Hopefully it's just something silly I've not done or done wrong, but I > > can't think what.... > > > > Cheers > > > > Rupert > > > > -------------------------------------------------------------- > > > > ry_spec.rb" "spec/spec/story/world_spec.rb" > > "spec/spec/translator_spec.rb" --format html:../doc/output/report.html > > --backtrace failed > > ./lib/spec/rake/spectask.rb:184:in `define' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1003:in `verbose' > > ./lib/spec/rake/spectask.rb:153:in `define' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in > > `invoke_with_call_chain' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in > > `invoke_with_call_chain' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' > > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/pre_commit.rb:9:in > > `rake_invoke' > > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/core.rb:10:in > > `website' > > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/core.rb:4:in > > `pre_commit' > > /Users/rupert/stuff/downloads/rspec_new/rspec/rakefile:162 > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in > > `invoke_with_call_chain' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in > > `invoke_with_call_chain' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1931:in `invoke_task' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `each' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in > > `standard_exception_handling' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1903:in `top_level' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1881:in `run' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in > > `standard_exception_handling' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1878:in `run' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/bin/rake:31 > > /usr/local/bin/rake:19:in `load' > > /usr/local/bin/rake:19 > > rake aborted! > > RSpec Core pre_commit failed > > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/rspec.rb:64:in > > `pre_commit_core' > > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/rspec.rb:61:in > > `chdir' > > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/rspec.rb:61:in > > `pre_commit_core' > > /Users/rupert/stuff/downloads/rspec_new/rspec/pre_commit/lib/pre_commit/rspec.rb:6:in > > `pre_commit' > > /Users/rupert/stuff/downloads/rspec_new/rakefile:9 > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in > > `invoke_with_call_chain' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in > > `invoke_with_call_chain' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1931:in `invoke_task' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `each' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in > > `standard_exception_handling' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1903:in `top_level' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1881:in `run' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in > > `standard_exception_handling' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1878:in `run' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/bin/rake:31 > > /usr/local/bin/rake:19:in `load' > > /usr/local/bin/rake:19 > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > From rupert at rupespad.com Mon Feb 25 11:24:52 2008 From: rupert at rupespad.com (Rupert Voelcker) Date: Mon, 25 Feb 2008 16:24:52 +0000 Subject: [rspec-users] Problems running pre-commit In-Reply-To: <57c63afe0802250714s693a141ai944750630051824b@mail.gmail.com> References: <52138110802250701j50b40cb3ic8bce2664d71058d@mail.gmail.com> <57c63afe0802250714s693a141ai944750630051824b@mail.gmail.com> Message-ID: <52138110802250824w64e106fbxb42c409d8430aa66@mail.gmail.com> On 25/02/2008, David Chelimsky wrote: > On Mon, Feb 25, 2008 at 9:01 AM, Rupert Voelcker wrote: > > Have been having some probs getting the pre-commit to run so help > > would be appreciated (then I can add some specs to my patch) - thanks > > for the suggestion to post here Dave :) > > > > I'm on OS X and have checked out the source from > > svn://rubyforge.org/var/svn/rspec/trunk (rev 3317) > > > > rake check_for_gem_dependencies (nothing to see here) > > rake install_dependencies (long wait, much network activity, various > > rails versions appear in example_rails_app) > > > > rename database.sqlite3.yml to database.yml in example_rails_app/config > > > > rake pre_commit --trace > > > There are a couple of steps missing. Did you read the README > (http://rspec.info/rdoc/files/README.html)? > > Also - I see you're using sqlite3. I can't run mine with sqlite3 right > now. It's probably been this way for a while, because it looks like > the error is the "You have 5 pending migrations:" error, which has > been around for some time. > > Try following the directions in the README to the letter (including > using mysql instead of sqlite3) and see if that works. Ah-ha - missed the readme, but unfortunately it hasn't helped. I've followed what it says and I'm still getting the same 4 failures and the same stack trace at the end :( I also cannot run the rails pre-commit and am getting the following when I run rake -f Multirails.rake pre_commit --trace from inside the example_app: running against rails 2.0.2 ** Invoke db:migrate (first_time) ** Invoke environment (first_time) ** Execute environment ** Execute db:migrate == 5 CreatePurchases: migrating =============================================== -- create_table(:purchases) -> 0.0274s == 5 CreatePurchases: migrated (0.0275s) ====================================== ** Invoke db:schema:dump (first_time) ** Invoke environment ** Execute db:schema:dump (in /Users/rupert/stuff/downloads/rspec/example_rails_app) running against rails 2.0.2 ** Invoke spec (first_time) ** Invoke db:test:prepare (first_time) ** Invoke environment (first_time) ** Execute environment ** Invoke db:abort_if_pending_migrations (first_time) ** Invoke environment ** Execute db:abort_if_pending_migrations ** Execute db:test:prepare ** Invoke db:test:clone (first_time) ** Invoke db:schema:dump (first_time) ** Invoke environment ** Execute db:schema:dump ** Invoke db:test:purge (first_time) ** Invoke environment ** Execute db:test:purge ** Execute db:test:clone ** Invoke db:schema:load (first_time) ** Invoke environment ** Execute db:schema:load ** Execute spec running against rails 2.0.2 ................................................................................................ Finished in 0.649869 seconds 96 examples, 0 failures rake aborted! Command ruby -I"/Users/rupert/stuff/downloads/rspec/rspec/lib" "/Users/rupert/stuff/downloads/rspec/rspec/bin/spec" "vendor/plugins/rspec_on_rails/spec/rails/autotest/mappings_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/autotest/rails_rspec_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/example/assigns_hash_proxy_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/example/configuration_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/example/controller_isolation_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/example/controller_spec_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/example/example_group_factory_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/example/helper_spec_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/example/model_spec_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/example/shared_behaviour_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/example/test_unit_assertion_accessibility_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/example/view_spec_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/extensions/action_controller_rescue_action_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/extensions/action_view_base_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/extensions/active_record_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/matchers/assert_select_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/matchers/description_generation_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/matchers/errors_on_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/matchers/have_text_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/matchers/redirect_to_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/matchers/render_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/mocks/mock_model_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/sample_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/spec_server_spec.rb" "vendor/plugins/rspec_on_rails/spec/rails/spec_spec.rb" --options "/Users/rupert/stuff/downloads/rspec/example_rails_app/spec/spec.opts" failed /Users/rupert/stuff/downloads/rspec/rspec/lib/spec/rake/spectask.rb:184:in `define' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1003:in `verbose' /Users/rupert/stuff/downloads/rspec/rspec/lib/spec/rake/spectask.rb:153:in `define' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in `invoke_with_call_chain' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `invoke_with_call_chain' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1931:in `invoke_task' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `each' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in `standard_exception_handling' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1903:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1881:in `run' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in `standard_exception_handling' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1878:in `run' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/bin/rake:31 /usr/local/bin/rake:19:in `load' /usr/local/bin/rake:19 (in /Users/rupert/stuff/downloads/rspec/example_rails_app) running against rails 2.0.2 ** Invoke spec:plugins:rspec_on_rails (first_time) ** Execute spec:plugins:rspec_on_rails running against rails 2.0.2 .FF..............................................................................................................................................................P..........................................................................................P................ .........P................ ..................................... Pending: should have_tag should report the correct line number for a nested failed test/unit assertion (Doesn't work at the moment. Do we want to support this?) A controller spec a spec in a context without controller_name set should fail with a useful warning (need a new way to deal with examples that should_raise) A controller spec a spec in a context without controller_name set should fail with a useful warning (need a new way to deal with examples that should_raise) 1) Timeout::Error in 'script/spec_server file with TextMate bundle runs a spec' execution expired 2) Timeout::Error in 'script/spec_server file without TextMate bundle runs a spec' execution expired Finished in 24.2063 seconds 332 examples, 2 failures, 3 pending rake aborted! ERROR while running rake: rake spec:plugins:rspec_on_rails --trace /Users/rupert/stuff/downloads/rspec/rspec/pre_commit/lib/pre_commit/pre_commit.rb:19:in `rake_sh' /Users/rupert/stuff/downloads/rspec/rspec/pre_commit/lib/pre_commit/rspec_on_rails.rb:44:in `rspec_pre_commit' /Users/rupert/stuff/downloads/rspec/rspec/pre_commit/lib/pre_commit/rspec_on_rails.rb:10:in `pre_commit' /Users/rupert/stuff/downloads/rspec/rspec/pre_commit/lib/pre_commit/rspec_on_rails.rb:6:in `each' /Users/rupert/stuff/downloads/rspec/rspec/pre_commit/lib/pre_commit/rspec_on_rails.rb:6:in `pre_commit' /Users/rupert/stuff/downloads/rspec/example_rails_app/Multirails.rake:7 /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in `invoke_with_call_chain' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `invoke_with_call_chain' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1931:in `invoke_task' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `each' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in `standard_exception_handling' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1903:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1881:in `run' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in `standard_exception_handling' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1878:in `run' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/bin/rake:31 /usr/local/bin/rake:19:in `load' /usr/local/bin/rake:19 Any ideas? - thanks for trying to get this sorted btw. Rupert From dchelimsky at gmail.com Mon Feb 25 11:51:11 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 25 Feb 2008 10:51:11 -0600 Subject: [rspec-users] Problems running pre-commit In-Reply-To: <52138110802250824w64e106fbxb42c409d8430aa66@mail.gmail.com> References: <52138110802250701j50b40cb3ic8bce2664d71058d@mail.gmail.com> <57c63afe0802250714s693a141ai944750630051824b@mail.gmail.com> <52138110802250824w64e106fbxb42c409d8430aa66@mail.gmail.com> Message-ID: <57c63afe0802250851m117ab6d0wc2e5cda714031781@mail.gmail.com> On Mon, Feb 25, 2008 at 10:24 AM, Rupert Voelcker wrote: > On 25/02/2008, David Chelimsky wrote: > > On Mon, Feb 25, 2008 at 9:01 AM, Rupert Voelcker wrote: > > > Have been having some probs getting the pre-commit to run so help > > > would be appreciated (then I can add some specs to my patch) - thanks > > > for the suggestion to post here Dave :) > > > > > > I'm on OS X and have checked out the source from > > > svn://rubyforge.org/var/svn/rspec/trunk (rev 3317) > > > > > > rake check_for_gem_dependencies (nothing to see here) > > > rake install_dependencies (long wait, much network activity, various > > > rails versions appear in example_rails_app) > > > > > > rename database.sqlite3.yml to database.yml in example_rails_app/config > > > > > > rake pre_commit --trace > > > > > > There are a couple of steps missing. Did you read the README > > (http://rspec.info/rdoc/files/README.html)? > > > > Also - I see you're using sqlite3. I can't run mine with sqlite3 right > > now. It's probably been this way for a while, because it looks like > > the error is the "You have 5 pending migrations:" error, which has > > been around for some time. > > > > Try following the directions in the README to the letter (including > > using mysql instead of sqlite3) and see if that works. > > Ah-ha - missed the readme, but unfortunately it hasn't helped. I've > followed what it says and I'm still getting the same 4 failures and > the same stack trace at the end :( > > I also cannot run the rails pre-commit and am getting the following > when I run rake -f Multirails.rake pre_commit --trace from inside the > example_app: > > > running against rails 2.0.2 > ** Invoke db:migrate (first_time) > ** Invoke environment (first_time) > ** Execute environment > ** Execute db:migrate > == 5 CreatePurchases: migrating =============================================== > -- create_table(:purchases) > -> 0.0274s > == 5 CreatePurchases: migrated (0.0275s) ====================================== > > ** Invoke db:schema:dump (first_time) > ** Invoke environment > ** Execute db:schema:dump > (in /Users/rupert/stuff/downloads/rspec/example_rails_app) > running against rails 2.0.2 > ** Invoke spec (first_time) > ** Invoke db:test:prepare (first_time) > ** Invoke environment (first_time) > ** Execute environment > ** Invoke db:abort_if_pending_migrations (first_time) > ** Invoke environment > ** Execute db:abort_if_pending_migrations > ** Execute db:test:prepare > ** Invoke db:test:clone (first_time) > ** Invoke db:schema:dump (first_time) > ** Invoke environment > ** Execute db:schema:dump > ** Invoke db:test:purge (first_time) > ** Invoke environment > ** Execute db:test:purge > ** Execute db:test:clone > ** Invoke db:schema:load (first_time) > ** Invoke environment > ** Execute db:schema:load > ** Execute spec > running against rails 2.0.2 > ................................................................................................ > > Finished in 0.649869 seconds > > 96 examples, 0 failures > rake aborted! > Command ruby -I"/Users/rupert/stuff/downloads/rspec/rspec/lib" > "/Users/rupert/stuff/downloads/rspec/rspec/bin/spec" > "vendor/plugins/rspec_on_rails/spec/rails/autotest/mappings_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/autotest/rails_rspec_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/example/assigns_hash_proxy_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/example/configuration_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/example/controller_isolation_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/example/controller_spec_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/example/example_group_factory_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/example/helper_spec_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/example/model_spec_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/example/shared_behaviour_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/example/test_unit_assertion_accessibility_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/example/view_spec_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/extensions/action_controller_rescue_action_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/extensions/action_view_base_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/extensions/active_record_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/matchers/assert_select_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/matchers/description_generation_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/matchers/errors_on_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/matchers/have_text_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/matchers/redirect_to_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/matchers/render_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/mocks/mock_model_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/sample_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/spec_server_spec.rb" > "vendor/plugins/rspec_on_rails/spec/rails/spec_spec.rb" --options > "/Users/rupert/stuff/downloads/rspec/example_rails_app/spec/spec.opts" > failed > /Users/rupert/stuff/downloads/rspec/rspec/lib/spec/rake/spectask.rb:184:in > > `define' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1003:in `verbose' > /Users/rupert/stuff/downloads/rspec/rspec/lib/spec/rake/spectask.rb:153:in > > `define' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in > `invoke_with_call_chain' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in > `invoke_with_call_chain' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1931:in `invoke_task' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `each' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in > `standard_exception_handling' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1903:in `top_level' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1881:in `run' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in > `standard_exception_handling' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1878:in `run' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/bin/rake:31 > /usr/local/bin/rake:19:in `load' > /usr/local/bin/rake:19 > (in /Users/rupert/stuff/downloads/rspec/example_rails_app) > running against rails 2.0.2 > ** Invoke spec:plugins:rspec_on_rails (first_time) > ** Execute spec:plugins:rspec_on_rails > running against rails 2.0.2 > .FF..............................................................................................................................................................P..........................................................................................P................ > .........P................ > ..................................... > > Pending: > should have_tag should report the correct line number for a nested > failed test/unit assertion (Doesn't work at the moment. Do we want to > support this?) > A controller spec a spec in a context without controller_name set > should fail with a useful warning (need a new way to deal with > examples that should_raise) > A controller spec a spec in a context without controller_name set > should fail with a useful warning (need a new way to deal with > examples that should_raise) > > 1) > Timeout::Error in 'script/spec_server file with TextMate bundle runs a spec' > execution expired > > > 2) > Timeout::Error in 'script/spec_server file without TextMate bundle runs a spec' > execution expired > > > Finished in 24.2063 seconds > > 332 examples, 2 failures, 3 pending > rake aborted! > ERROR while running rake: rake spec:plugins:rspec_on_rails --trace > /Users/rupert/stuff/downloads/rspec/rspec/pre_commit/lib/pre_commit/pre_commit.rb:19:in > `rake_sh' > /Users/rupert/stuff/downloads/rspec/rspec/pre_commit/lib/pre_commit/rspec_on_rails.rb:44:in > `rspec_pre_commit' > /Users/rupert/stuff/downloads/rspec/rspec/pre_commit/lib/pre_commit/rspec_on_rails.rb:10:in > `pre_commit' > /Users/rupert/stuff/downloads/rspec/rspec/pre_commit/lib/pre_commit/rspec_on_rails.rb:6:in > `each' > /Users/rupert/stuff/downloads/rspec/rspec/pre_commit/lib/pre_commit/rspec_on_rails.rb:6:in > `pre_commit' > /Users/rupert/stuff/downloads/rspec/example_rails_app/Multirails.rake:7 > > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in > `invoke_with_call_chain' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in > `invoke_with_call_chain' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1931:in `invoke_task' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `each' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in > `standard_exception_handling' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1903:in `top_level' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1881:in `run' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in > `standard_exception_handling' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1878:in `run' > /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/bin/rake:31 > /usr/local/bin/rake:19:in `load' > /usr/local/bin/rake:19 > > Any ideas? - thanks for trying to get this sorted btw. Yes - I sometimes get the spec_server timeout as well - but I usually don't. Try running just against just one environment: rake rspec:pre_commit without the -f option. > > Rupert > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From rupert at rupespad.com Mon Feb 25 12:16:52 2008 From: rupert at rupespad.com (Rupert Voelcker) Date: Mon, 25 Feb 2008 17:16:52 +0000 Subject: [rspec-users] Problems running pre-commit In-Reply-To: <57c63afe0802250851m117ab6d0wc2e5cda714031781@mail.gmail.com> References: <52138110802250701j50b40cb3ic8bce2664d71058d@mail.gmail.com> <57c63afe0802250714s693a141ai944750630051824b@mail.gmail.com> <52138110802250824w64e106fbxb42c409d8430aa66@mail.gmail.com> <57c63afe0802250851m117ab6d0wc2e5cda714031781@mail.gmail.com> Message-ID: <52138110802250916n16836eacye9eed186988f4ddd@mail.gmail.com> > Yes - I sometimes get the spec_server timeout as well - but I usually don't. > > Try running just against just one environment: > > rake rspec:pre_commit > > without the -f option. tried that (it runs against edge) and it still won't wor. I'm still getting the timeouts: Pending: should have_tag should report the correct line number for a nested failed test/unit assertion (Doesn't work at the moment. Do we want to support this?) A controller spec a spec in a context without controller_name set should fail with a useful warning (need a new way to deal with examples that should_raise) A controller spec a spec in a context without controller_name set should fail with a useful warning (need a new way to deal with examples that should_raise) 1) Timeout::Error in 'script/spec_server file with TextMate bundle runs a spec' execution expired 2) Timeout::Error in 'script/spec_server file without TextMate bundle runs a spec' execution expired Finished in 24.298229 seconds 332 examples, 2 failures, 3 pending rake aborted! ERROR while running rake: rake spec:plugins:rspec_on_rails --trace /Users/rupert/stuff/downloads/rspec/rspec/pre_commit/lib/pre_commit/pre_commit.rb:19:in `rake_sh' /Users/rupert/stuff/downloads/rspec/rspec/pre_commit/lib/pre_commit/rspec_on_rails.rb:44:in `rspec_pre_commit' /Users/rupert/stuff/downloads/rspec/example_rails_app/lib/tasks/bootstrap_rspec.rake:11 /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `call' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:546:in `execute' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `each' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:541:in `execute' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:508:in `invoke_with_call_chain' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `synchronize' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:501:in `invoke_with_call_chain' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:494:in `invoke' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1931:in `invoke_task' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `each' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1909:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in `standard_exception_handling' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1903:in `top_level' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1881:in `run' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1948:in `standard_exception_handling' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/lib/rake.rb:1878:in `run' /usr/local/lib/ruby/gems/1.8/gems/rake-0.8.1/bin/rake:31 /usr/local/bin/rake:19:in `load' /usr/local/bin/rake:19 Is there something I can comment out to remove the offending bits from the run? Cheers Rupert From oli.azevedo.barnes at gmail.com Mon Feb 25 18:23:08 2008 From: oli.azevedo.barnes at gmail.com (Oliver Barnes) Date: Mon, 25 Feb 2008 20:23:08 -0300 Subject: [rspec-users] [newbie] rspec textmate bundle problem Message-ID: <6466d9040802251523g1955182ct848f67e98c867e71@mail.gmail.com> Hello, I've just installed the rspec textmate bundle from svn, and I'm getting the following error when I try to run a single example: /Users/oliver/Library/Application Support/TextMate/Bundles/RSpec.tmbundle/Support/lib/spec/mate.rb:2:in `require': No such file to load -- rubygems (LoadError) from /Users/oliver/Library/Application Support/TextMate/Bundles/RSpec.tmbundle/Support/lib/spec/mate.rb:2 from /tmp/temp_textmate.xVeAZb:3:in `require' from /tmp/temp_textmate.xVeAZb:3 I'm using a custom locomotive bundle with the rails 2.0.2 and rspec 1.1.3 gems installed, together with the respective rspec_on_rails plugin. I've been searching for a solution for a couple of hours, and i've tried setting both TM_RUBY and TM_RSPEC_HOME as suggested in other posts, but that didn't solve it. At one point the error changed, complaining about a missing rails 2.0.2 gem though it's installed and declared in the environment config, but I can't remember now what prompted it. appreciate any pointers with this, please bear with me as I'm new to the list and still learning my way around testing and rspec... ;) - Oliver From oli.azevedo.barnes at gmail.com Mon Feb 25 18:41:42 2008 From: oli.azevedo.barnes at gmail.com (Oliver Barnes) Date: Mon, 25 Feb 2008 20:41:42 -0300 Subject: [rspec-users] [newbie] rspec textmate bundle problem In-Reply-To: <6466d9040802251523g1955182ct848f67e98c867e71@mail.gmail.com> References: <6466d9040802251523g1955182ct848f67e98c867e71@mail.gmail.com> Message-ID: <6466d9040802251541q11a511r6acf1ee6ccfd5279@mail.gmail.com> ..2 seconds after posting I found this thread from the peepcode users group http://groups.google.com/group/peepcode/browse_thread/thread/089989c61181d39c and so I set the same variables in my .bashrc, and created a new project, which got the bundle to work when opening the project from the command line. it still doesn't work from locomotive though. 2008/2/25, Oliver Barnes : > Hello, > > I've just installed the rspec textmate bundle from svn, and I'm > getting the following error when I try to run a single example: > > /Users/oliver/Library/Application > Support/TextMate/Bundles/RSpec.tmbundle/Support/lib/spec/mate.rb:2:in > `require': No such file to load -- rubygems (LoadError) from > /Users/oliver/Library/Application > Support/TextMate/Bundles/RSpec.tmbundle/Support/lib/spec/mate.rb:2 > from /tmp/temp_textmate.xVeAZb:3:in `require' from > /tmp/temp_textmate.xVeAZb:3 > > I'm using a custom locomotive bundle with the rails 2.0.2 and rspec > 1.1.3 gems installed, together with the respective rspec_on_rails > plugin. I've been searching for a solution for a couple of hours, and > i've tried setting both TM_RUBY and TM_RSPEC_HOME as suggested in > other posts, but that didn't solve it. At one point the error changed, > complaining about a missing rails 2.0.2 gem though it's installed and > declared in the environment config, but I can't remember now what > prompted it. > > appreciate any pointers with this, please bear with me as I'm new to > the list and still learning my way around testing and rspec... ;) > > > - Oliver > From gilesb at gmail.com Mon Feb 25 21:18:28 2008 From: gilesb at gmail.com (Giles Bowkett) Date: Mon, 25 Feb 2008 18:18:28 -0800 Subject: [rspec-users] bad specs better than none? Message-ID: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> Hi - I've got a bunch of people using specs at a company. Everybody is writing specs, but people are not really practicing BDD. As in, the specs are there, but it doesn't go, write spec, write code, repeat. I recently came across 8 failing specs checked into svn; I think the plan was, I'll write the design as specs, and then implement the entire design to match. Obviously that's not really the way it should be. I also had to go into specs on a project I'm not working on, and found an unholy hive of database-accessing specs. It's disheartening. Basically, it's cargo cult development practices - using the "best practice" without actually understanding it. Should I tell these people to throw away their specs? Should I train them in the BDD "spec first" cycle? What do you do when you have specs that are not really that useful? This is mostly Rails stuff; there's a lot of controller specs that duplicate model specs instead of stubbing out the behavior. It's driving me nuts but I have no idea what the solution is yet. -- Giles Bowkett Blog: http://gilesbowkett.blogspot.com Portfolio: http://www.gilesgoatboy.org Tumblelog: http://giles.tumblr.com Podcast: http://hollywoodgrit.blogspot.com From omen.king at gmail.com Mon Feb 25 21:39:19 2008 From: omen.king at gmail.com (Andrew WC Brown) Date: Mon, 25 Feb 2008 21:39:19 -0500 Subject: [rspec-users] bad specs better than none? In-Reply-To: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> References: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> Message-ID: A better question would be do you have that authority to retrain them?That sounds awful to say the least. It could be worse, you could be the guy that is the test driven development library that manually goes in and see what breaks and what doesn't. When I refer to you "could be the guy", I'm actaully stating I am that guy. I wish my company understood the concept or the need for BDD or at least TDD. I'm trapped and its so painful. On Mon, Feb 25, 2008 at 9:18 PM, Giles Bowkett wrote: > Hi - I've got a bunch of people using specs at a company. Everybody is > writing specs, but people are not really practicing BDD. As in, the > specs are there, but it doesn't go, write spec, write code, repeat. I > recently came across 8 failing specs checked into svn; I think the > plan was, I'll write the design as specs, and then implement the > entire design to match. Obviously that's not really the way it should > be. > > I also had to go into specs on a project I'm not working on, and found > an unholy hive of database-accessing specs. It's disheartening. > Basically, it's cargo cult development practices - using the "best > practice" without actually understanding it. > > Should I tell these people to throw away their specs? Should I train > them in the BDD "spec first" cycle? What do you do when you have specs > that are not really that useful? This is mostly Rails stuff; there's a > lot of controller specs that duplicate model specs instead of stubbing > out the behavior. It's driving me nuts but I have no idea what the > solution is yet. > > -- > Giles Bowkett > > Blog: http://gilesbowkett.blogspot.com > Portfolio: http://www.gilesgoatboy.org > Tumblelog: http://giles.tumblr.com > Podcast: http://hollywoodgrit.blogspot.com > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080225/b9f7b1a7/attachment.html From dchelimsky at gmail.com Mon Feb 25 23:13:56 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Mon, 25 Feb 2008 22:13:56 -0600 Subject: [rspec-users] bad specs better than none? In-Reply-To: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> References: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> Message-ID: <57c63afe0802252013y112de342hcb8c2097052e9229@mail.gmail.com> On Mon, Feb 25, 2008 at 8:18 PM, Giles Bowkett wrote: > Hi - I've got a bunch of people using specs at a company. Everybody is > writing specs, but people are not really practicing BDD. As in, the > specs are there, but it doesn't go, write spec, write code, repeat. I > recently came across 8 failing specs checked into svn; I think the > plan was, I'll write the design as specs, and then implement the > entire design to match. Obviously that's not really the way it should > be. This is a fairly common misconception about what BDD is all about. You can move in the right direction by making those failing specs pending so the suite still passes. Then remove pending from one example, watch it fail, get it to pass, then the next pending example, etc. > I also had to go into specs on a project I'm not working on, and found > an unholy hive of database-accessing specs. It's disheartening. > Basically, it's cargo cult development practices - using the "best > practice" without actually understanding it. This is a really tough problem. The whole motivation for BDD was "people don't get TDD, so let's come up with some new ways to frame it so people get it." Now people don't get the new frame. In that respect we've made things twice as bad. > Should I tell these people to throw away their specs? Should I train > them in the BDD "spec first" cycle? What do you do when you have specs > that are not really that useful? This is mostly Rails stuff; there's a > lot of controller specs that duplicate model specs instead of stubbing > out the behavior. It's driving me nuts but I have no idea what the > solution is yet. If you're pair programming with these folks, then I'd recommend simply pushing the pairing sessions in the right direction. Focus on the task at hand, do it with good discipline, and change anything that's not right as you go. If you're working from afar, then I'm not sure what to recommend. There are some people who are going to respond favorably to your advise and others who will think you're nuts. The subject of this thread is "bad specs better than none?" If "bad" means "wrong" and the examples don't test what they say they're testing, then I'd point that out and ditch them - but probably one at a time. If "bad" means that there is poor balance, too much focus on structure, duplication, etc, then as long as they are really testing things, I'd leave them and gradually refactor them to a better place. Or maybe I'd just crack open a beer, grab my guitar and call it a day :) Cheers, David > > -- > Giles Bowkett > > Blog: http://gilesbowkett.blogspot.com > Portfolio: http://www.gilesgoatboy.org > Tumblelog: http://giles.tumblr.com > Podcast: http://hollywoodgrit.blogspot.com > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From aslak.hellesoy at gmail.com Mon Feb 25 23:37:28 2008 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Tue, 26 Feb 2008 05:37:28 +0100 Subject: [rspec-users] [newbie] rspec textmate bundle problem In-Reply-To: <6466d9040802251541q11a511r6acf1ee6ccfd5279@mail.gmail.com> References: <6466d9040802251523g1955182ct848f67e98c867e71@mail.gmail.com> <6466d9040802251541q11a511r6acf1ee6ccfd5279@mail.gmail.com> Message-ID: <8d961d900802252037g285e9adbl75f7ca280e2dd215@mail.gmail.com> There is also this: http://rspec.info/documentation/tools/extensions/editors/textmate.html Aslak On Tue, Feb 26, 2008 at 12:41 AM, Oliver Barnes wrote: > ..2 seconds after posting I found this thread from the peepcode users group > > http://groups.google.com/group/peepcode/browse_thread/thread/089989c61181d39c > > and so I set the same variables in my .bashrc, and created a new > project, which got the bundle to work when opening the project from > the command line. it still doesn't work from locomotive though. > > 2008/2/25, Oliver Barnes : > > > > Hello, > > > > I've just installed the rspec textmate bundle from svn, and I'm > > getting the following error when I try to run a single example: > > > > /Users/oliver/Library/Application > > Support/TextMate/Bundles/RSpec.tmbundle/Support/lib/spec/mate.rb:2:in > > `require': No such file to load -- rubygems (LoadError) from > > /Users/oliver/Library/Application > > Support/TextMate/Bundles/RSpec.tmbundle/Support/lib/spec/mate.rb:2 > > from /tmp/temp_textmate.xVeAZb:3:in `require' from > > /tmp/temp_textmate.xVeAZb:3 > > > > I'm using a custom locomotive bundle with the rails 2.0.2 and rspec > > 1.1.3 gems installed, together with the respective rspec_on_rails > > plugin. I've been searching for a solution for a couple of hours, and > > i've tried setting both TM_RUBY and TM_RSPEC_HOME as suggested in > > other posts, but that didn't solve it. At one point the error changed, > > complaining about a missing rails 2.0.2 gem though it's installed and > > declared in the environment config, but I can't remember now what > > prompted it. > > > > appreciate any pointers with this, please bear with me as I'm new to > > the list and still learning my way around testing and rspec... ;) > > > > > > - Oliver > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From edvard at majakari.net Tue Feb 26 00:35:36 2008 From: edvard at majakari.net (Edvard Majakari) Date: Tue, 26 Feb 2008 07:35:36 +0200 Subject: [rspec-users] Autotest with TDD "test-first" problem In-Reply-To: References: <57c63afe0802230610v1e650434l8c3220a2a697fecb@mail.gmail.com> Message-ID: On Sat, Feb 23, 2008 at 10:39 PM, Joe Van Dyk wrote: > For example, one test runner could repeatedly run (or once a minute, > or whatever) the entire test suite. And one test runner could run the > related tests for the file you change. > > Perhaps two autotest instances, running off different test databases? That's exactly my approach. I have 3 separate tests running, of which "rake test:recent" is run whenever the files change, and the re-check interval is just one second. However, "rake test:units" and "rake test:functionals" -- sorry, my tests are still in Test::Unit :( -- check the files only once a minute now. I use rstakeout.rb for the task. I added simple file locking support to prevent multiple instances running on the same time when requested (by default, it allows concurrency). See this pastie: http://pastie.caboo.se/pastes/152014 and use is as follows: # save this as mystakeout.sh or similar ruby rstakeout.rb -t 1 --sync "rake test:recent" "spec/**/*.rb" "app/**/*.rb" ruby rstakeout.rb -t 60 --sync "rake test:all_but_integration" "spec/**/*.rb" "app/**/*.rb" ..or something. -- "One day, when he was naughty, Mr Bunnsy looked over the hedge into Farmer Fred's field and it was full of fresh green lettuces. Mr Bunnsy, however, was not full of lettuces. This did not seem fair." -- Terry Pratchett, Mr. Bunnsy Has An Adventure From aslak.hellesoy at gmail.com Tue Feb 26 00:59:14 2008 From: aslak.hellesoy at gmail.com (aslak hellesoy) Date: Tue, 26 Feb 2008 06:59:14 +0100 Subject: [rspec-users] bad specs better than none? In-Reply-To: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> References: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> Message-ID: <8d961d900802252159j2b83c7ads80bd89594880e77f@mail.gmail.com> On Tue, Feb 26, 2008 at 3:18 AM, Giles Bowkett wrote: > Hi - I've got a bunch of people using specs at a company. Everybody is > writing specs, but people are not really practicing BDD. As in, the > specs are there, but it doesn't go, write spec, write code, repeat. I > recently came across 8 failing specs checked into svn; I think the > plan was, I'll write the design as specs, and then implement the > entire design to match. Obviously that's not really the way it should > be. > Here is how I would deal with this (and have dealt with it in the past) 1) In your standup meeting (if you have one) say you have an obstacle, and that it's failing specs in svn. Don't explain why it's an obstacle, just say you'd like to discuss it with the other devs after the standup. 2) Explain that you can't check in more code because you can't know whether your new code is any good. When something fails you can't know for sure whether it's due to "old" or new failing specs. 3) Try to get everyone to understand the benefits of a green SCM and the dangers of a red one. This can take days and weeks. Only then can you address the failing specs. 4) Set up Continuous Integration 5) Invest in some lamps and hook them up to your CI > I also had to go into specs on a project I'm not working on, and found > an unholy hive of database-accessing specs. It's disheartening. > Basically, it's cargo cult development practices - using the "best > practice" without actually understanding it. > What "best practice" are you referring to? > Should I tell these people to throw away their specs? Should I train > them in the BDD "spec first" cycle? What do you do when you have specs > that are not really that useful? This is mostly Rails stuff; there's a > lot of controller specs that duplicate model specs instead of stubbing > out the behavior. It's driving me nuts but I have no idea what the > solution is yet. > I don't know if your developers chose BDD/RSpec themselves (and got it wrong) or if they were "assigned". In any case, it sounds like there has been a lack of attention to collective code ownership and staffing with appropriate skills. Patience and pair programming would be my best suggestion. Have someone who gets BDD (you?) pair with the whole team till they get it too. And till they also get that they should fix bad code when they see it. Aslak > -- > Giles Bowkett > > Blog: http://gilesbowkett.blogspot.com > Portfolio: http://www.gilesgoatboy.org > Tumblelog: http://giles.tumblr.com > Podcast: http://hollywoodgrit.blogspot.com > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From pergesu at gmail.com Tue Feb 26 01:34:34 2008 From: pergesu at gmail.com (Pat Maddox) Date: Mon, 25 Feb 2008 22:34:34 -0800 Subject: [rspec-users] bad specs better than none? In-Reply-To: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> References: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> Message-ID: <810a540e0802252234m50e42cdege71d5430ee32d74f@mail.gmail.com> Are you on site or is this remote work? What role are you supposed to be fulfilling? Pat From toastkid.williams at gmail.com Tue Feb 26 05:55:12 2008 From: toastkid.williams at gmail.com (Max Williams) Date: Tue, 26 Feb 2008 10:55:12 +0000 Subject: [rspec-users] Test data problem (in general and with acts_as_tree) Message-ID: Hi all I'm having problems with data in my specs - i'm probably just going about things the wrong way though. I'm testing a model (called Property) that uses acts_as_tree, and for now have just done some specs for the basic acts_as_tree functionality - just as a sanity check, i thought, but i'm getting fails. In a before(:all) block, i'm creating a bunch of objects and saving them to the database - like this: describe Property, "with a fresh property tree" do before(:all) do @root = Property.new(:name => "Root") @root.id = 0 #root.id must be 0 for acts as tree to work properly @root.save @role = @root.children.create(:name => "Job Role") @dept = @root.children.create(:name => "Department") ...etc end describe ",standard acts_as_tree methods," do #this test is failing it "class.root" do Property.root.should eql(@root) end end and the fail report from the above test: 'Property with a fresh property tree ,standard acts_as_tree methods, class.root' FAILED expected #, got # (using .eql?) ./spec/models/property_spec.rb:50: script/spec:4: My problems seem to be arising from the fact that when i run the test, the objects i created last time are still in the database. Shouldn't they be cleared out automatically? This in turn is preventing me from saving root with an id of 0. If i test all of this stuff in the console it works fine, but it's failing in my tests, suggesting that my tests are broken. Am i setting up my data in the wrong way? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080226/3dcb43b4/attachment.html From edvard at majakari.net Tue Feb 26 06:41:21 2008 From: edvard at majakari.net (Edvard Majakari) Date: Tue, 26 Feb 2008 13:41:21 +0200 Subject: [rspec-users] Test data problem (in general and with acts_as_tree) In-Reply-To: References: Message-ID: > My problems seem to be arising from the fact that when i run the test, the > objects i created last time are still in the database. Shouldn't they be > cleared out automatically? This in turn is preventing me from saving root I don't know RSpec that well, but I'd guess before(:all) is run only once in a describe block (and as such torn down only after the block is finished), whereas before(:each) is run before every example (and torn down respectively). So, I guess you'll want to use before(:each) version. Was that it? -- "One day, when he was naughty, Mr Bunnsy looked over the hedge into Farmer Fred's field and it was full of fresh green lettuces. Mr Bunnsy, however, was not full of lettuces. This did not seem fair." -- Terry Pratchett, Mr. Bunnsy Has An Adventure From dchelimsky at gmail.com Tue Feb 26 07:09:11 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 26 Feb 2008 06:09:11 -0600 Subject: [rspec-users] Test data problem (in general and with acts_as_tree) In-Reply-To: References: Message-ID: <57c63afe0802260409v54ac5522n6a020f4e43356649@mail.gmail.com> On Tue, Feb 26, 2008 at 5:41 AM, Edvard Majakari wrote: > > My problems seem to be arising from the fact that when i run the test, the > > objects i created last time are still in the database. Shouldn't they be > > cleared out automatically? This in turn is preventing me from saving root > > I don't know RSpec that well, but I'd guess before(:all) is run only > once in a describe block (and as such torn down only after the block > is finished), whereas before(:each) is run before every example (and > torn down respectively). So, I guess you'll want to use before(:each) > version. > > Was that it? Yep. Use before(:each) and all should be well. > > -- > "One day, when he was naughty, Mr Bunnsy looked over the hedge into > Farmer Fred's field and it was full of fresh green lettuces. Mr > Bunnsy, however, was not full of lettuces. This did not seem fair." > -- Terry Pratchett, Mr. Bunnsy Has An Adventure > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From toastkid.williams at gmail.com Tue Feb 26 08:39:37 2008 From: toastkid.williams at gmail.com (Max Williams) Date: Tue, 26 Feb 2008 13:39:37 +0000 Subject: [rspec-users] Test data problem (in general and with acts_as_tree) In-Reply-To: <57c63afe0802260409v54ac5522n6a020f4e43356649@mail.gmail.com> References: <57c63afe0802260409v54ac5522n6a020f4e43356649@mail.gmail.com> Message-ID: I'm using before(:all) because i want to create a single 'family' of tree objects and then run tests against it. If i have all the object creation as a before(:each) then the database will be even more full of duplications, won't it? My problem, though, is that the data is left over from the last time (in fact all previous times) that i ran the spec file, where i thought that it was cleared out. Do i need to explicitly tell the database to clear all the records in an 'after' block? On 26/02/2008, David Chelimsky wrote: > > On Tue, Feb 26, 2008 at 5:41 AM, Edvard Majakari > wrote: > > > My problems seem to be arising from the fact that when i run the test, > the > > > objects i created last time are still in the database. Shouldn't > they be > > > cleared out automatically? This in turn is preventing me from saving > root > > > > I don't know RSpec that well, but I'd guess before(:all) is run only > > once in a describe block (and as such torn down only after the block > > is finished), whereas before(:each) is run before every example (and > > torn down respectively). So, I guess you'll want to use before(:each) > > version. > > > > Was that it? > > > Yep. Use before(:each) and all should be well. > > > > > -- > > > "One day, when he was naughty, Mr Bunnsy looked over the hedge into > > Farmer Fred's field and it was full of fresh green lettuces. Mr > > Bunnsy, however, was not full of lettuces. This did not seem fair." > > -- Terry Pratchett, Mr. Bunnsy Has An Adventure > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080226/14103881/attachment.html From a at heitler.com Tue Feb 26 08:16:29 2008 From: a at heitler.com (JH) Date: Tue, 26 Feb 2008 13:16:29 +0000 Subject: [rspec-users] A Jedit mode for stories Message-ID: <47C4112D.1070402@heitler.com> For other folks who use jedit, here is a little Mode script for editing stories to keep things looking nice: Just place this in your ~/.jedit/modes/ directory and add the MODE NAME tag to the catalog file in that same directory. It will become the editing mode for files that start with "story-". --- Story: Scenario: Given When Then And --- Cheers, -J From dchelimsky at gmail.com Tue Feb 26 08:59:31 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 26 Feb 2008 07:59:31 -0600 Subject: [rspec-users] Test data problem (in general and with acts_as_tree) In-Reply-To: References: <57c63afe0802260409v54ac5522n6a020f4e43356649@mail.gmail.com> Message-ID: <57c63afe0802260559g50069685m5956d6dccb6aab47@mail.gmail.com> On Tue, Feb 26, 2008 at 7:39 AM, Max Williams wrote: > I'm using before(:all) because i want to create a single 'family' of tree > objects and then run tests against it. If i have all the object creation as > a before(:each) then the database will be even more full of duplications, > won't it? No. If you have use_transactional_fixtures set to true, each example is run in a transaction, which is rolled back at the end of the example. This does not happen for you implicitly when you use before(:all) because there is no mechanism for running a group of examples in a transaction. > My problem, though, is that the data is left over from the last time (in > fact all previous times) that i ran the spec file, where i thought that it > was cleared out. Do i need to explicitly tell the database to clear all the > records in an 'after' block? Yes. If you want to use before(:all) to set up data, you need to use after(:all) to clean it up explicitly. Please beware that this approach is extremely error prone over time. If you ever introduce a side effect (intentionally or accidentally) that modifies the data, you're going to look at the spec, see the data you're setting up and incorrectly think that that's the data every example is using. It is much, much safer (and more sane) to use before(:each) even though it may slow things down a bit. HTH, David > > > > On 26/02/2008, David Chelimsky wrote: > > On Tue, Feb 26, 2008 at 5:41 AM, Edvard Majakari > wrote: > > > > My problems seem to be arising from the fact that when i run the test, > the > > > > objects i created last time are still in the database. Shouldn't > they be > > > > cleared out automatically? This in turn is preventing me from saving > root > > > > > > I don't know RSpec that well, but I'd guess before(:all) is run only > > > once in a describe block (and as such torn down only after the block > > > is finished), whereas before(:each) is run before every example (and > > > torn down respectively). So, I guess you'll want to use before(:each) > > > version. > > > > > > Was that it? > > > > > > Yep. Use before(:each) and all should be well. > > > > > > > > -- > > > > > "One day, when he was naughty, Mr Bunnsy looked over the hedge into > > > Farmer Fred's field and it was full of fresh green lettuces. Mr > > > Bunnsy, however, was not full of lettuces. This did not seem fair." > > > -- Terry Pratchett, Mr. Bunnsy Has An Adventure > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From toastkid.williams at gmail.com Tue Feb 26 09:08:30 2008 From: toastkid.williams at gmail.com (Max Williams) Date: Tue, 26 Feb 2008 14:08:30 +0000 Subject: [rspec-users] Test data problem (in general and with acts_as_tree) In-Reply-To: <57c63afe0802260559g50069685m5956d6dccb6aab47@mail.gmail.com> References: <57c63afe0802260409v54ac5522n6a020f4e43356649@mail.gmail.com> <57c63afe0802260559g50069685m5956d6dccb6aab47@mail.gmail.com> Message-ID: On 26/02/2008, David Chelimsky wrote: > > On Tue, Feb 26, 2008 at 7:39 AM, Max Williams > wrote: > > > This does not happen for you implicitly when you use before(:all) > because there is no mechanism for running a group of examples in a > transaction. ah...i see. I didn't know about that last bit. :) > My problem, though, is that the data is left over from the last time (in > > fact all previous times) that i ran the spec file, where i thought that > it > > was cleared out. Do i need to explicitly tell the database to clear all > the > > records in an 'after' block? > > > Yes. If you want to use before(:all) to set up data, you need to use > after(:all) to clean it up explicitly. > > Please beware that this approach is extremely error prone over time. > If you ever introduce a side effect (intentionally or accidentally) > that modifies the data, you're going to look at the spec, see the data > you're setting up and incorrectly think that that's the data every > example is using. It is much, much safer (and more sane) to use > before(:each) even though it may slow things down a bit. Gotcha. Thanks! HTH, > > David > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080226/070b194b/attachment-0001.html From dchelimsky at gmail.com Tue Feb 26 09:16:33 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 26 Feb 2008 08:16:33 -0600 Subject: [rspec-users] Test data problem (in general and with acts_as_tree) In-Reply-To: References: <57c63afe0802260409v54ac5522n6a020f4e43356649@mail.gmail.com> <57c63afe0802260559g50069685m5956d6dccb6aab47@mail.gmail.com> Message-ID: <57c63afe0802260616l689a08dema966707e5feef3e8@mail.gmail.com> On Tue, Feb 26, 2008 at 8:08 AM, Max Williams wrote: > > > > On 26/02/2008, David Chelimsky wrote: > > > > On Tue, Feb 26, 2008 at 7:39 AM, Max Williams > > wrote: > > > > > > > > This does not happen for you implicitly when you use before(:all) > > because there is no mechanism for running a group of examples in a > > transaction. > > ah...i see. I didn't know about that last bit. :) FYI: http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/310 Cheers, David > > > > My problem, though, is that the data is left over from the last time (in > > > fact all previous times) that i ran the spec file, where i thought that > it > > > was cleared out. Do i need to explicitly tell the database to clear all > the > > > records in an 'after' block? > > > > > > Yes. If you want to use before(:all) to set up data, you need to use > > after(:all) to clean it up explicitly. > > > > Please beware that this approach is extremely error prone over time. > > If you ever introduce a side effect (intentionally or accidentally) > > that modifies the data, you're going to look at the spec, see the data > > you're setting up and incorrectly think that that's the data every > > example is using. It is much, much safer (and more sane) to use > > before(:each) even though it may slow things down a bit. > > Gotcha. Thanks! > > > HTH, > > > > David > > > > > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From toastkid.williams at gmail.com Tue Feb 26 09:31:17 2008 From: toastkid.williams at gmail.com (Max Williams) Date: Tue, 26 Feb 2008 14:31:17 +0000 Subject: [rspec-users] Test data problem (in general and with acts_as_tree) In-Reply-To: <57c63afe0802260616l689a08dema966707e5feef3e8@mail.gmail.com> References: <57c63afe0802260409v54ac5522n6a020f4e43356649@mail.gmail.com> <57c63afe0802260559g50069685m5956d6dccb6aab47@mail.gmail.com> <57c63afe0802260616l689a08dema966707e5feef3e8@mail.gmail.com> Message-ID: hehe, tbh even if the documentation had been there i probably wouldn't have read it :) thanks! On 26/02/2008, David Chelimsky wrote: > > On Tue, Feb 26, 2008 at 8:08 AM, Max Williams > > wrote: > > > > > > > > On 26/02/2008, David Chelimsky wrote: > > > > > > On Tue, Feb 26, 2008 at 7:39 AM, Max Williams > > > wrote: > > > > > > > > > > > > This does not happen for you implicitly when you use before(:all) > > > because there is no mechanism for running a group of examples in a > > > transaction. > > > > ah...i see. I didn't know about that last bit. :) > > > FYI: http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/310 > > Cheers, > > David > > > > > > > > My problem, though, is that the data is left over from the last time > (in > > > > fact all previous times) that i ran the spec file, where i thought > that > > it > > > > was cleared out. Do i need to explicitly tell the database to clear > all > > the > > > > records in an 'after' block? > > > > > > > > > Yes. If you want to use before(:all) to set up data, you need to use > > > after(:all) to clean it up explicitly. > > > > > > Please beware that this approach is extremely error prone over time. > > > If you ever introduce a side effect (intentionally or accidentally) > > > that modifies the data, you're going to look at the spec, see the data > > > you're setting up and incorrectly think that that's the data every > > > example is using. It is much, much safer (and more sane) to use > > > before(:each) even though it may slow things down a bit. > > > > Gotcha. Thanks! > > > > > HTH, > > > > > > David > > > > > > > > > > > > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080226/1b9dfbd4/attachment.html From dchelimsky at gmail.com Tue Feb 26 09:33:23 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 26 Feb 2008 08:33:23 -0600 Subject: [rspec-users] Test data problem (in general and with acts_as_tree) In-Reply-To: References: <57c63afe0802260409v54ac5522n6a020f4e43356649@mail.gmail.com> <57c63afe0802260559g50069685m5956d6dccb6aab47@mail.gmail.com> <57c63afe0802260616l689a08dema966707e5feef3e8@mail.gmail.com> Message-ID: <57c63afe0802260633j373b6425i57a1aae29bcbfc15@mail.gmail.com> On Tue, Feb 26, 2008 at 8:31 AM, Max Williams wrote: > hehe, tbh even if the documentation had been there i probably wouldn't have > read it :) Yeah but then I get to say RTFM. Right now, TFM doesn't exist :( > > thanks! > > > > On 26/02/2008, David Chelimsky wrote: > > On Tue, Feb 26, 2008 at 8:08 AM, Max Williams > > > > wrote: > > > > > > > > > > > > On 26/02/2008, David Chelimsky wrote: > > > > > > > > On Tue, Feb 26, 2008 at 7:39 AM, Max Williams > > > > wrote: > > > > > > > > > > > > > > > > This does not happen for you implicitly when you use before(:all) > > > > because there is no mechanism for running a group of examples in a > > > > transaction. > > > > > > ah...i see. I didn't know about that last bit. :) > > > > > > FYI: http://rspec.lighthouseapp.com/projects/5645-rspec/tickets/310 > > > > Cheers, > > > > David > > > > > > > > > > > > My problem, though, is that the data is left over from the last time > (in > > > > > fact all previous times) that i ran the spec file, where i thought > that > > > it > > > > > was cleared out. Do i need to explicitly tell the database to clear > all > > > the > > > > > records in an 'after' block? > > > > > > > > > > > > Yes. If you want to use before(:all) to set up data, you need to use > > > > after(:all) to clean it up explicitly. > > > > > > > > Please beware that this approach is extremely error prone over time. > > > > If you ever introduce a side effect (intentionally or accidentally) > > > > that modifies the data, you're going to look at the spec, see the data > > > > you're setting up and incorrectly think that that's the data every > > > > example is using. It is much, much safer (and more sane) to use > > > > before(:each) even though it may slow things down a bit. > > > > > > Gotcha. Thanks! > > > > > > > HTH, > > > > > > > > David > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > rspec-users mailing list > > > rspec-users at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From pergesu at gmail.com Tue Feb 26 10:18:22 2008 From: pergesu at gmail.com (Pat Maddox) Date: Tue, 26 Feb 2008 07:18:22 -0800 Subject: [rspec-users] Newbie question Context vs Describe In-Reply-To: <57c63afe0802240626s4e1a3c64x7fca8c0d01f31412@mail.gmail.com> References: <93cf9750802240329j72a629d1v64291faf0040ae6c@mail.gmail.com> <57c63afe0802240626s4e1a3c64x7fca8c0d01f31412@mail.gmail.com> Message-ID: <810a540e0802260718g4af4a4cbr9effbaa3461bcacd@mail.gmail.com> On Sun, Feb 24, 2008 at 6:26 AM, David Chelimsky wrote: > In terms of getting that into RSpec, why don't you enter a feature > request at http://rspec.lighthouseapp.com and we can discuss the > merits of this there. As I said, I like it at first glance, but I want > to think about it and get other opinions before just adding it (as > context is only there for backwards compatibility right now). I like it. I always say that you can't really specify an object's behavior without considering its context. This seems like it would be a nice organizational tool, and contribute to the over all vision of BDD. Pat From edvard at majakari.net Tue Feb 26 13:10:39 2008 From: edvard at majakari.net (Edvard Majakari) Date: Tue, 26 Feb 2008 20:10:39 +0200 Subject: [rspec-users] Test data problem (in general and with acts_as_tree) In-Reply-To: <57c63afe0802260633j373b6425i57a1aae29bcbfc15@mail.gmail.com> References: <57c63afe0802260409v54ac5522n6a020f4e43356649@mail.gmail.com> <57c63afe0802260559g50069685m5956d6dccb6aab47@mail.gmail.com> <57c63afe0802260616l689a08dema966707e5feef3e8@mail.gmail.com> <57c63afe0802260633j373b6425i57a1aae29bcbfc15@mail.gmail.com> Message-ID: > Yeah but then I get to say RTFM. Right now, TFM doesn't exist :( rant << EOF Indeed. People see much trouble in writing documentation so that they don't have to answer the same questions ad nauseam. It would be nice if we appreciated their efforts and check the documentation first. EOF -- "One day, when he was naughty, Mr Bunnsy looked over the hedge into Farmer Fred's field and it was full of fresh green lettuces. Mr Bunnsy, however, was not full of lettuces. This did not seem fair." -- Terry Pratchett, Mr. Bunnsy Has An Adventure From cremes.devlist at mac.com Tue Feb 26 14:22:35 2008 From: cremes.devlist at mac.com (Chuck Remes) Date: Tue, 26 Feb 2008 13:22:35 -0600 Subject: [rspec-users] [Q] how to restructure tests for an abstract class? In-Reply-To: <57c63afe0802250630i38c88d8eh36d4cb17f2364f3c@mail.gmail.com> References: <810a540e0802231519v97659dek9eab36b2fa6836ec@mail.gmail.com> <27c0ac6d0802250130n24a1c2b6o22d56880f09f3c6d@mail.gmail.com> <57c63afe0802250630i38c88d8eh36d4cb17f2364f3c@mail.gmail.com> Message-ID: <62F17A77-A573-41C4-8EF6-FBC38FDA5E06@mac.com> On Feb 25, 2008, at 8:30 AM, David Chelimsky wrote: > On Mon, Feb 25, 2008 at 6:23 AM, Chuck Remes > wrote: >> Thanks for asking this question. This is exactly what I was going >> to write, >> but you beat me to it! >> >> (Sorry for the top-post; just following the last responder.) >> >> cr >> >> >> >> On Feb 25, 2008, at 3:30 AM, Matthijs Langenberg wrote: >> Question is, would you duplicate the specs for all the classes that >> include >> a certain module (through shared behaviour for example), or would >> you use >> one set of specs for just the module, and specify that a class should >> include that module? > > Matthijs - I'd throw the same question back to you. Have you tried > both approaches? How have they worked out for you? > > I won't wait for your answer :). But I am curious about other people's > experiences with this. > > I can tell you this from my own experience - I tend to use shared > groups for this for a couple of reasons. One, I like to see the specs > for each object. I thought I'd share my experiences with the group. Please recall I'm new at BDD/TDD so I may get some of the terminology wrong or whatever. So I have a class that, by itself, doesn't do anything. Concrete subclasses are necessary to flesh out a few characteristics before the parent class code can perform its magic. This is an abstract class which I'm told isn't the Ruby Way, so I'm looking at turning it into a module (a topic for another message). Originally, I was curious how to refactor my classes (and tests). I decided to write a second concrete subclass to see what kind of problems I might run into. I figured *any* problem I encountered was just more information for me to figure out the correct direction. The second subclass started out normally enough. I spec'd some behavior unique to that subclass. So far, so good. Then it occurred to me that I had no idea if the parent class was really being exercised by my new tests; turns out it wasn't being exercised. To resolve this I started adding some tests to make sure I covered the original behavior of the parent class. Now I had code duplication. The parent class tests and my *first* subclass were duping some of the same behavior. Looking into the examples directory I saw the concept of #shared_examples_for. I refactored my tests using shared examples. Most of these went into the parent class (perhaps soon to be a module). All the tests in my subclasses then focused exclusively on the behavior unique to that specific class while the describe blocks called #it_should_behave_like for shared behaviors. This DRY'ed the code up considerably. An added benefit was some test breakage I ran across while refactoring the tests. My second subclass had some rather tight coupling to the tests, so when I made it shared the subclass test broke. It forced me to rethink some of the test and class design to loosen the coupling. Ultimately it led to a better class api. So, that's my rambling summary. Kudos to you if you read this far. My next goal is to DRY up some of my 'before (:each)' blocks. I continually do the same setup operations across #describe blocks (@buf = Buf.new; @msg = blah, etc). It looks like I may want to define subclasses of a parent Spec::ExampleGroup so the subclasses can inherit some of the #before setup. I'd love to hear experiences from others on this technique. Lastly, I thought I'd say a word on the resulting class code. This BDD project was a learning experience. I rewrote a set of classes that I had originally written the old-fashioned way; puzzle through the logic in my head, write the code, and then debug the crap out of it until it worked. The original classes are rather short (LOC) with only a few methods (3 or 4). The classes I wrote via BDD are longer, maybe by 40% in terms of LOC. Plus, I now have around 10 methods none of which exceeds 5 lines of "real" code. It's more readable, more logical, and *far* easier to subclass. I'm now a believer. YMMV. cr From lists at ruby-forum.com Tue Feb 26 15:57:22 2008 From: lists at ruby-forum.com (Dave Myron) Date: Tue, 26 Feb 2008 21:57:22 +0100 Subject: [rspec-users] Rspec Textmate bundle errors In-Reply-To: <43362a720710120841u305422f7se5ed5ecdb1b7f47e@mail.gmail.com> References: <2E61B430-A2FC-4588-B35A-95AE51254512@kozmo.co.uk> <57c63afe0710101703k1476a37cu2897b9e61262a74f@mail.gmail.com> <8487E755-9FBC-4D6E-8A53-AB13239A84A2@kozmo.co.uk> <57c63afe0710101820x119f7289jfd1263b947361684@mail.gmail.com> <079D220E-DBC8-4C00-82FE-E596F1F2148C@gmail.com> <57c63afe0710110603y669f3e35v62f226ca8186e2cb@mail.gmail.com> <43362a720710120841u305422f7se5ed5ecdb1b7f47e@mail.gmail.com> Message-ID: Mel Riffe wrote: > This is what worked for me (just did this last night): > > 1. I removed everything rspec to have a clean slate: > - gem uninstall rspec > - rm -fr vendor/plugins/rpec > - rm -fr vendor/plugins/rpec_on_rails > - using BundleEditor, removed RSpec Bundle > > 2. I then installed the rspec plugins according to the website: > - script/plugin install svn://..../tags/CURRENT/rspec > - script/plugin install svn://..../tags/CURRENT/rspec_on_rails > - script/generate spec > - i then created a model rspec and ran 'rake spec' > > 3. I then installed the RSpec Bundle with the following SVN URL: > - svn co .../tags/CURRENT/RSpec.tmbundle > - Reloaded the Bundles > - ran the same model spec from within TM. Digging up an old thread here. I've done the above (and am at r3317). But getting a strange error when I run the example with the TextMate bundle (from within a project directory in TM): System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in `gem_original_require': no such file to load -- image_science (MissingSourceFile) from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in `require' from /myapp/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:496:in `require' from /myapp/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:342:in `new_constants_in' from /myapp/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:496:in `require' from /myapp/app/models/custom.rb:1 from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in `gem_original_require' from /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in `require' from /myapp/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:496:in `require' ... 14 levels... from /Users/user/Library/Application Support/TextMate/Bundles/RSpec.tmbundle/Support/lib/spec/../spec/mate/runner.rb:31:in `chdir' from /Users/user/Library/Application Support/TextMate/Bundles/RSpec.tmbundle/Support/lib/spec/../spec/mate/runner.rb:31:in `run' from /Users/user/Library/Application Support/TextMate/Bundles/RSpec.tmbundle/Support/lib/spec/../spec/mate/runner.rb:14:in `run_file' from /tmp/temp_textmate.eFFxZt:4 The line generating that error is a simple: require 'image_science'. Doing `gem which image_science` returns the correct value and running the spec from the command line works fine too. Strange? Dave -- Posted via http://www.ruby-forum.com/. From libei.twer at gmail.com Tue Feb 26 23:53:36 2008 From: libei.twer at gmail.com (Bei) Date: Tue, 26 Feb 2008 20:53:36 -0800 (PST) Subject: [rspec-users] how to set up data before story runner steps? Message-ID: <4086be02-537e-4e93-b6ac-aba4903c3ddd@71g2000hse.googlegroups.com> Hi I'm using story runner of RSpec now. What I'm trying to do is initializing the @selenium before any steps of one story is executing, and stop @selenium after any story is finished. just as @BeforeClass and @AfterClass in jUnit Any suggestions on this? Thanks!!! Bei here is my code for STEPS: steps_for(:search) do Given("user could access search page") do @google_page = GooglePage.new(@selenium) @google_page.open; end Given("user enter search test: $search_text") do |$search_text| @google_page.search_text=$search_text end When("do search") do @search_result_page = @google_page.search end Then("show search result") do @search_result_page.should_not == nil end end STORY: Story: #000 As A command human I want to get information quickly So that I could save me time on doing real things Scenario: could search Given user could access search page And user enter search test: asdfasdfasdfas When do search Then show search result GLUE: with_steps_for :search do run 'stories/000.story' end From dchelimsky at gmail.com Wed Feb 27 00:31:32 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Tue, 26 Feb 2008 23:31:32 -0600 Subject: [rspec-users] how to set up data before story runner steps? In-Reply-To: <4086be02-537e-4e93-b6ac-aba4903c3ddd@71g2000hse.googlegroups.com> References: <4086be02-537e-4e93-b6ac-aba4903c3ddd@71g2000hse.googlegroups.com> Message-ID: <57c63afe0802262131y79bf32f9v2ef0c701318e7448@mail.gmail.com> On Tue, Feb 26, 2008 at 10:53 PM, Bei wrote: > Hi > > I'm using story runner of RSpec now. What I'm trying to do is > initializing the @selenium before any steps of one story is executing, > and stop @selenium after any story is finished. just as @BeforeClass > and @AfterClass in jUnit > Any suggestions on this? There is no way built in to handle this yet. Is anybody doing this yet? If not, you'll have to experiment. If you're interested, I think the way to handle it is to register a listener like this: Spec::Story::Runner.register_listener(listener) The listener object should receive messages like run_started, story_started, scenario_started and story_ended, run_ended and scenario_failed or scenario_pending. Be sure to implement method_missing to ignore everything else. Good luck, and let us know what works. Cheers, David > > Thanks!!! > > > Bei > > here is my code for > STEPS: > > steps_for(:search) do > > Given("user could access search page") do > @google_page = GooglePage.new(@selenium) > @google_page.open; > end > > Given("user enter search test: $search_text") do |$search_text| > @google_page.search_text=$search_text > end > > When("do search") do > @search_result_page = @google_page.search > end > > Then("show search result") do > @search_result_page.should_not == nil > end > end > > > STORY: > > Story: #000 > As A command human > I want to get information quickly > So that I could save me time on doing real things > > Scenario: could search > Given user could access search page > And user enter search test: asdfasdfasdfas > When do search > Then show search result > > > GLUE: > with_steps_for :search do > run 'stories/000.story' > end > > > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From dchelimsky at gmail.com Wed Feb 27 01:00:16 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 27 Feb 2008 00:00:16 -0600 Subject: [rspec-users] the git experiment Message-ID: <57c63afe0802262200o6bd5ef9fy112034c9c5d276f5@mail.gmail.com> Hey all, A while back I mentioned that we were going to move to git or hg. We decided that we'd experiment with each for a month and see how it goes. We're going to start with git. Obviously if all goes well we'll have to reassess whether or not to also give hg a try. We have a repo set up at gitorious: Project page: http://gitorious.org/projects/rspec. Clone the repo: git clone git at gitorious.org:rspec/mainline.git We'll be setting up synchronization with subversion, so you'll be able to keep the rails plugins up to date, but it's a few days out before that's set up. In the meantime, you rails'ers who want to keep up with the plugins will have to clone the repo and move stuff around locally. Keep in mind that this is an experiment. The official repo is still the subversion repo at rubyforge until further notice. Cheers, David From thomasmarek_ at web.de Wed Feb 27 05:02:49 2008 From: thomasmarek_ at web.de (Thomas Marek) Date: Wed, 27 Feb 2008 11:02:49 +0100 Subject: [rspec-users] how to set up data before story runner steps? In-Reply-To: <4086be02-537e-4e93-b6ac-aba4903c3ddd@71g2000hse.googlegroups.com> References: <4086be02-537e-4e93-b6ac-aba4903c3ddd@71g2000hse.googlegroups.com> Message-ID: <47C53549.7040806@web.de> Bei schrieb: > Hi > > I'm using story runner of RSpec now. What I'm trying to do is > initializing the @selenium before any steps of one story is executing, > and stop @selenium after any story is finished. just as @BeforeClass > and @AfterClass in jUnit > Any suggestions on this? > > Thanks!!! > Hi, my helpers/selenium_helper.rb file look like that: # Alias some more ruby-like methods on SeleniumDriver, to make it play # better with rspec matchers. module Selenium class SeleniumDriver alias_method :original_method_missing, :method_missing def method_missing method_name, *args if method_name.to_s =~ /^has_.*\?$/ real_method = method_name.to_s.sub /has_(.*)\?$/, 'is_\1' if respond_to? real_method return send(real_method, args) end elsif respond_to?(real_method = "get_" + method_name.to_s) return send(real_method) end return original_method_missing(method_name, args) end end end $selenium_driver = nil unless $selenium_driver $selenium_listener_added = false unless $selenium_listener_added module StoryHelper def selenium $selenium_driver end Spec::Story::World.send :include, self end class SeleniumListener include Singleton def scenario_started(*args) $selenium_driver = Selenium::SeleniumDriver.new('localhost', 4444, '*firefox', 'http://localhost:3000/', 15000) $selenium_driver.start end def scenario_succeeded(*args) $selenium_driver.stop $selenium_driver = nil end alias :scenario_pending :scenario_succeeded alias :scenario_failed :scenario_succeeded end unless $selenium_listener_added Spec::Story::Runner.scenario_runner.add_listener(SeleniumListener.instance) $selenium_listener_added = true end Best wishes, Thomas From coreyhaines at gmail.com Wed Feb 27 07:08:05 2008 From: coreyhaines at gmail.com (Corey Haines) Date: Wed, 27 Feb 2008 07:08:05 -0500 Subject: [rspec-users] OT local version control? In-Reply-To: <6bdacb70802051116r66200b0fk477667ae00162adc@mail.gmail.com> References: <6bdacb70801271333y5825321dp67936e236030aae5@mail.gmail.com> <71166b3b0802030923u268a7d7cs5bcb694802b495c1@mail.gmail.com> <6bdacb70802030945u7209d4d3tf171de576c16e93a@mail.gmail.com> <71166b3b0802031000h65c66560vc8760b09269cf839@mail.gmail.com> <6bdacb70802031028k493d394ds793ca969792e2af6@mail.gmail.com> <6bdacb70802041528n308d5023i12be5a05f9b06e65@mail.gmail.com> <71166b3b0802041609k5f71461dpa1a0501f4506bec4@mail.gmail.com> <6bdacb70802041633v63dfe9e5x1d4a4fa8b0548238@mail.gmail.com> <6bdacb70802051116r66200b0fk477667ae00162adc@mail.gmail.com> Message-ID: <6bdacb70802270408u71e00093od9ec3cd307a92344@mail.gmail.com> Joe Fiorino, the faithful geek, recorded a conversation we had last Saturday about DSCM and my early experiences with it for his podcast. If anyone is inclined to listen and comment on anything I said, I'd appreciate it. I'm especially interested in any possible fallacious understandings of DSCM, since you all know that I'm new at it. http://www.faithfulgeek.org/2008/2/24/distributed-source-control-with-corey-haines Thanks. -Corey On Tue, Feb 5, 2008 at 2:16 PM, Corey Haines wrote: > Thanks, Dan, I'll check that out. > > -Corey > > On Feb 5, 2008 5:19 AM, Dan North wrote: > > > Hi Corey. > > > > I recently discovered a rather excellent online book: > > http://hgbook.red-bean.com/ > > > > It's about mercurial but it's a) largely scm-agnostic and b) really well > > written, with some useful diagrams about how changesets work in the small > > and collaboration models in the large (i.e. exactly what you were asking > > about). > > > > I also discovered a "deal-breaker" feature of mercurial that I hadn't > > realised before, which is that it tracks changes across copies and renames > > of files. Or rather, what I hadn't realised is that other SCMs don't do > > this. This was what was crippling me with subversion - I had a branch where > > I had done some quite aggressive refactoring (which means files getting > > moved and/or renamed), and subversion wouldn't merge the changes from the > > branch onto trunk. > > > > > > On 05/02/2008, Corey Haines wrote: > > > > > > Thanks for the response, Luis. > > > > > > I'm going through the user manual, and it looks like I can set up a > > > main branch, make a clone, work on the clone with its own > > > repository/revisions, then merge the changes back to the main branch when > > > I'm ready. I like the idea of being able to work on several things at once. > > > I'll let you guys know how it goes. > > > > > > -Corey > > > > > > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > -- > http://www.coreyhaines.com > The Internet's Premiere source of information about Corey Haines > -- http://www.coreyhaines.com The Internet's Premiere source of information about Corey Haines -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080227/ed04908d/attachment.html From toastkid.williams at gmail.com Wed Feb 27 07:12:20 2008 From: toastkid.williams at gmail.com (Max Williams) Date: Wed, 27 Feb 2008 12:12:20 +0000 Subject: [rspec-users] has_many_polymorphs is breaking my testing Message-ID: I have a class Property that was testing fine until i added the following to it: has_many_polymorphs :labelled, :from => [:instructional_objects, :lessons, :courses], :through => :labels, :dependent => :destroy (in other words, 'labels' is a join table through which various objects can be labelled with a property) Now my spec file crashes, saying that Property isn't defined in property.rb: does anyone know what's gone wrong here? /home/jars/rails/lesson_planner/branches/max/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:249:in `load_missing_constant': Expected /home/jars/rails/lesson_planner/branches/max/app/models/property.rb to define Property (LoadError) from /home/jars/rails/lesson_planner/branches/max/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:452:in `const_missing' from /home/jars/rails/lesson_planner/branches/max/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:464:in `const_missing' from ./spec/models/property_spec.rb:3 ... -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080227/01ae53a0/attachment.html From toastkid.williams at gmail.com Wed Feb 27 08:14:49 2008 From: toastkid.williams at gmail.com (Max Williams) Date: Wed, 27 Feb 2008 13:14:49 +0000 Subject: [rspec-users] has_many_polymorphs is breaking my testing In-Reply-To: References: Message-ID: Never mind, i'm an idiot, the problem was that i broke my Property class with the has_many_polymorphs declaration, so the spec couldn't load it. Sorry! On 27/02/2008, Max Williams wrote: > > I have a class Property that was testing fine until i added the following > to it: > > has_many_polymorphs :labelled, > :from => [:instructional_objects, :lessons, :courses], > :through => :labels, > :dependent => :destroy > > (in other words, 'labels' is a join table through which various objects > can be labelled with a property) > > Now my spec file crashes, saying that Property isn't defined in > property.rb: does anyone know what's gone wrong here? > > /home/jars/rails/lesson_planner/branches/max/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:249:in > `load_missing_constant': Expected > /home/jars/rails/lesson_planner/branches/max/app/models/property.rb to > define Property (LoadError) > from > /home/jars/rails/lesson_planner/branches/max/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:452:in > `const_missing' > from > /home/jars/rails/lesson_planner/branches/max/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/dependencies.rb:464:in > `const_missing' > from ./spec/models/property_spec.rb:3 > ... > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080227/ce0fee39/attachment-0001.html From lists at ruby-forum.com Wed Feb 27 09:14:35 2008 From: lists at ruby-forum.com (Greg Gigon) Date: Wed, 27 Feb 2008 15:14:35 +0100 Subject: [rspec-users] Problem with Plain Text Story Runner Message-ID: <193b74fd637be61803523a100f74d2fd@ruby-forum.com> Hi Guys I'm new to Ruby and BDD. I'm having a problem while running my story in plain text. This is the console OUTPUT. /var/lib/gems/1.8/gems/rspec-1.1.3/lib/spec/story/runner/story_mediator.rb:51:in `current_scenario': undefined method `current_scenario' for nil:NilClass (NoMethodError) from /var/lib/gems/1.8/gems/rspec-1.1.3/lib/spec/story/runner/story_mediator.rb:26:in `create_given' from /var/lib/gems/1.8/gems/rspec-1.1.3/lib/spec/story/runner/story_parser.rb:61:in `create_given' from /var/lib/gems/1.8/gems/rspec-1.1.3/lib/spec/story/runner/story_parser.rb:107:in `given' from /var/lib/gems/1.8/gems/rspec-1.1.3/lib/spec/story/runner/story_parser.rb:31:in `process_line' from /var/lib/gems/1.8/gems/rspec-1.1.3/lib/spec/story/runner/story_parser.rb:21:in `parse' from /var/lib/gems/1.8/gems/rspec-1.1.3/lib/spec/story/runner/plain_text_story_runner.rb:35:in `run' I was fallowing David Chelimsky article http://blog.davidchelimsky.net/articles/2007/10/21/story-runner-in-plain-english I got RB file with Steps defined, RB file with runner and a text file with Stories. Doing the same thing in Ruby code and not a plain text works fine. Any suggestions ? Greg -- Posted via http://www.ruby-forum.com/. From dchelimsky at gmail.com Wed Feb 27 09:27:03 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Wed, 27 Feb 2008 08:27:03 -0600 Subject: [rspec-users] the git experiment In-Reply-To: <57c63afe0802262200o6bd5ef9fy112034c9c5d276f5@mail.gmail.com> References: <57c63afe0802262200o6bd5ef9fy112034c9c5d276f5@mail.gmail.com> Message-ID: <57c63afe0802270627k6a7321f2k6f66de92fba1228e@mail.gmail.com> On Wed, Feb 27, 2008 at 12:00 AM, David Chelimsky wrote: > Hey all, > > A while back I mentioned that we were going to move to git or hg. We > decided that we'd experiment with each for a month and see how it > goes. > > We're going to start with git. Obviously if all goes well we'll have > to reassess whether or not to also give hg a try. > > We have a repo set up at gitorious: > > Project page: > http://gitorious.org/projects/rspec. > > Clone the repo: > git clone git at gitorious.org:rspec/mainline.git Correction: this should be: git clone git://gitorious.org/rspec/mainline.git > > We'll be setting up synchronization with subversion, so you'll be able > to keep the rails plugins up to date, but it's a few days out before > that's set up. In the meantime, you rails'ers who want to keep up with > the plugins will have to clone the repo and move stuff around locally. > > Keep in mind that this is an experiment. The official repo is still > the subversion repo at rubyforge until further notice. > > Cheers, > David > From matt-lists at reprocessed.org Wed Feb 27 09:13:47 2008 From: matt-lists at reprocessed.org (Matt Patterson) Date: Wed, 27 Feb 2008 14:13:47 +0000 Subject: [rspec-users] Passing options into Story Runner (like --format) Message-ID: <519C56C5-E4E4-448A-B0A1-0324B5491E0F@reprocessed.org> Hey, I've been trying to hook in the HTML formatter for story output, with zero success - passing the --format option to me stories/all.rb script was doing nothing. So, I slapped in some puts statements and figured out that ARGV was getting cleared before Spec::Story::Runner.run_options was ever being called... I broke out the debugger and discovered that this is happening because when spec/ rails/story_adapter is required, the extension of Test::Unit::TestCase with Spec::Example::ExampleGroupMethods in spec/ interop/test/unit/testcase.rb means that the Spec::Rails::Example::RailsExampleGroup inheritance of Test::Unit::TestCase causes Spec::Example::ExampleGroupMethods.inherited to fire, which winds up calling Spec::Example::ExampleGroupMethods#inherited, which calls rspec_options, which consumes ARGV and clears it out. Given that you then end up with a globally accessible Spec::Runner::Options instance, is there any reason for Spec::Story::Runner.run_options, since it tries to do exactly the same thing? I'm only asking in case I'm missing something obvious, behaviour- wise. Otherwise I'll look into fixing it and post a patch to Lighthouse Matt -- Matt Patterson | Design & Code | http://www.reprocessed.org/ From rspec-users at kero.tmfweb.nl Wed Feb 27 22:45:03 2008 From: rspec-users at kero.tmfweb.nl (Kero) Date: Thu, 28 Feb 2008 04:45:03 +0100 Subject: [rspec-users] bad specs better than none? In-Reply-To: <57c63afe0802252013y112de342hcb8c2097052e9229@mail.gmail.com> References: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> <57c63afe0802252013y112de342hcb8c2097052e9229@mail.gmail.com> Message-ID: <20080228034503.GA5500@chello.nl> > > I also had to go into specs on a project I'm not working on, and found > > an unholy hive of database-accessing specs. It's disheartening. > > Basically, it's cargo cult development practices - using the "best > > practice" without actually understanding it. > > This is a really tough problem. The whole motivation for BDD was > "people don't get TDD, so let's come up with some new ways to frame it > so people get it." Now people don't get the new frame. In that respect > we've made things twice as bad. What did you expect? Honestly? You need to show people the Right way, otherwise they're unlikely to figure it out by themselves. But as the fortune cookies go: "To make the right decision, one needs experience. To gain experience, one needs to make the wrong decision." It is easier for me to explain this from the point of view of aikido: I've been shown the right moves thousands of times. I can not even see what sensei does, let alone reproduce it. I can not perceive the balance, the timing, the acceptance of an attacker and the reflection of his/her energy to -ultimately- unbalance. How could I learn by trying even tens or hundreds of thousands of time? After seven years, I'm still a puny beginner. And I need other people to show me my mistakes. Again, again and again. To the original poster: yes, teach BDD. Make sure they accept you as a teacher, then teach, small steps at a time, by showing what is wrong. when they figure out a solution by themselves, encourage them, accept that solution (use it yourself). When they don't figure it out by themselves (likely enough), show how you would do it. And be prepared to repeat yourself. HtH, Kero. From mauricio.linhares at gmail.com Wed Feb 27 23:01:04 2008 From: mauricio.linhares at gmail.com (=?ISO-8859-1?Q?Maur=EDcio_Linhares?=) Date: Thu, 28 Feb 2008 01:01:04 -0300 Subject: [rspec-users] bad specs better than none? In-Reply-To: <8d961d900802252159j2b83c7ads80bd89594880e77f@mail.gmail.com> References: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> <8d961d900802252159j2b83c7ads80bd89594880e77f@mail.gmail.com> Message-ID: On Tue, Feb 26, 2008 at 2:59 AM, aslak hellesoy wrote: > > I also had to go into specs on a project I'm not working on, and found > > an unholy hive of database-accessing specs. It's disheartening. > > Basically, it's cargo cult development practices - using the "best > > practice" without actually understanding it. > > > > What "best practice" are you referring to? > I'm also interested in discovering what is this "best practice". I can't see any problem in specs running against a database, that's exactly what integration testing is about, shouldn't we do integration testing just because we're using BDD? I really don't think so. The big problem about specs running against a database is not knowing that it's integration testing and also that specs that access databases run slower than "pure" unit tests, but you can't be sure that your app works without a bunch of integration tests. -- Maur?cio Linhares http://alinhavado.wordpress.com/ (pt-br) | http://codeshooter.wordpress.com/ (en) Jo?o Pessoa, PB, +55 83 8867-7208 From joseph at josephholsten.com Thu Feb 28 00:09:52 2008 From: joseph at josephholsten.com (Joseph Anthony Pasquale Holsten) Date: Wed, 27 Feb 2008 23:09:52 -0600 Subject: [rspec-users] bad specs better than none? In-Reply-To: References: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> <8d961d900802252159j2b83c7ads80bd89594880e77f@mail.gmail.com> Message-ID: <99FAFCD2-A7B5-4F0C-83FE-82CD913757B2@josephholsten.com> On 02008:02:27, at 10:01CST, Maur?cio Linhares wrote: > On Tue, Feb 26, 2008 at 2:59 AM, aslak hellesoy > wrote: >>> I also had to go into specs on a project I'm not working on, and >>> found >>> an unholy hive of database-accessing specs. It's disheartening. >>> Basically, it's cargo cult development practices - using the "best >>> practice" without actually understanding it. >>> >> >> What "best practice" are you referring to? >> > > I'm also interested in discovering what is this "best practice". > > I can't see any problem in specs running against a database, that's > exactly what integration testing is about, shouldn't we do integration > testing just because we're using BDD? I really don't think so. > > The big problem about specs running against a database is not knowing > that it's integration testing and also that specs that access > databases run slower than "pure" unit tests, but you can't be sure > that your app works without a bunch of integration tests. I'm reminded of one of my heros, Matthias Felleisen. If you don't know exactly what I'm talking about, go here: . His mission in life is to teach the pattern to design programs. His approach draws more from the Design by Contract paradigm than TDD, but it's the same goal. If you can ever stop in at Northeastern University in Boston, drop in on a class. Especially the freshman intro to programming. If we can't teach the method as well as him, we're screwed. Because he's been working on it for twenty years. Of course, my hope is that hackety.org + bdd = hdtp++. I can dream, no? http:// Joseph Holsten .com From omen.king at gmail.com Thu Feb 28 00:31:15 2008 From: omen.king at gmail.com (Andrew WC Brown) Date: Thu, 28 Feb 2008 00:31:15 -0500 Subject: [rspec-users] bad specs better than none? In-Reply-To: <99FAFCD2-A7B5-4F0C-83FE-82CD913757B2@josephholsten.com> References: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> <8d961d900802252159j2b83c7ads80bd89594880e77f@mail.gmail.com> <99FAFCD2-A7B5-4F0C-83FE-82CD913757B2@josephholsten.com> Message-ID: I replied before in this topic saying that I was doing manual testing.I should state that I am now using Selenium + Ruby + RSpec. ASP 0 - Ruby 1 On Thu, Feb 28, 2008 at 12:09 AM, Joseph Anthony Pasquale Holsten < joseph at josephholsten.com> wrote: > > On 02008:02:27, at 10:01CST, Maur?cio Linhares wrote: > > > On Tue, Feb 26, 2008 at 2:59 AM, aslak hellesoy > > wrote: > >>> I also had to go into specs on a project I'm not working on, and > >>> found > >>> an unholy hive of database-accessing specs. It's disheartening. > >>> Basically, it's cargo cult development practices - using the "best > >>> practice" without actually understanding it. > >>> > >> > >> What "best practice" are you referring to? > >> > > > > I'm also interested in discovering what is this "best practice". > > > > I can't see any problem in specs running against a database, that's > > exactly what integration testing is about, shouldn't we do integration > > testing just because we're using BDD? I really don't think so. > > > > The big problem about specs running against a database is not knowing > > that it's integration testing and also that specs that access > > databases run slower than "pure" unit tests, but you can't be sure > > that your app works without a bunch of integration tests. > > I'm reminded of one of my heros, Matthias Felleisen. If you don't > know exactly what I'm talking about, go here: . His > mission in life is to teach the pattern to design programs. His > approach draws more from the Design by Contract paradigm than TDD, > but it's the same goal. > > If you can ever stop in at Northeastern University in Boston, drop in > on a class. Especially the freshman intro to programming. If we can't > teach the method as well as him, we're screwed. Because he's been > working on it for twenty years. > > Of course, my hope is that hackety.org + bdd = hdtp++. I can dream, no? > > http:// Joseph Holsten .com > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080228/7a223c0b/attachment.html From pergesu at gmail.com Thu Feb 28 00:50:10 2008 From: pergesu at gmail.com (Pat Maddox) Date: Wed, 27 Feb 2008 21:50:10 -0800 Subject: [rspec-users] bad specs better than none? In-Reply-To: <99FAFCD2-A7B5-4F0C-83FE-82CD913757B2@josephholsten.com> References: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> <8d961d900802252159j2b83c7ads80bd89594880e77f@mail.gmail.com> <99FAFCD2-A7B5-4F0C-83FE-82CD913757B2@josephholsten.com> Message-ID: <810a540e0802272150q33098642k13ed9fdee149da4c@mail.gmail.com> On Wed, Feb 27, 2008 at 9:09 PM, Joseph Anthony Pasquale Holsten wrote: > If you can ever stop in at Northeastern University in Boston, drop in > on a class. Especially the freshman intro to programming. If we can't > teach the method as well as him, we're screwed. Because he's been > working on it for twenty years. Pick up one/several of his books, too. The Little/Seasoned/Reasoned Schemer, Little MLer, A Little Java A Few Patterns. HTDP is a good book as well, it's kind of like SICP's little brother. The ones I listed above are quite different - written in a Socratic dialog format - and very enjoyable. Plus you can get them all off of ebay for like 10 bucks. Pat From korny at sietsma.com Thu Feb 28 01:49:41 2008 From: korny at sietsma.com (Korny Sietsma) Date: Thu, 28 Feb 2008 17:49:41 +1100 Subject: [rspec-users] bad specs better than none? In-Reply-To: References: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> <8d961d900802252159j2b83c7ads80bd89594880e77f@mail.gmail.com> Message-ID: <8e15872b0802272249r4edb1290q95f85b11b19b95d9@mail.gmail.com> Totally agree with this - I'm happy to work with specs that just define a single bit of the system's behaviour (i.e. "unit tests") and specs that define behaviour across several different parts of the system (i.e. "integration tests") - but it drives me mad when they are all mixed in together, rather than in different directory trees. Incidentally, is there a good naming scheme for this distinction in the BDD world? I'm used to saying "unit tests", "integration tests", "acceptance tests" (though the precise meaning of the last two seems to vary widely between different organisations!) but I'm not sure what to call them in rspec-land. "unit specs"? "stories" in story-runner? - Korny On Thu, Feb 28, 2008 at 3:01 PM, Maur?cio Linhares < mauricio.linhares at gmail.com> wrote: > On Tue, Feb 26, 2008 at 2:59 AM, aslak hellesoy > wrote: > > > I also had to go into specs on a project I'm not working on, and > found > > > an unholy hive of database-accessing specs. It's disheartening. > > > Basically, it's cargo cult development practices - using the "best > > > practice" without actually understanding it. > > > > > > > What "best practice" are you referring to? > > > > I'm also interested in discovering what is this "best practice". > > I can't see any problem in specs running against a database, that's > exactly what integration testing is about, shouldn't we do integration > testing just because we're using BDD? I really don't think so. > > The big problem about specs running against a database is not knowing > that it's integration testing and also that specs that access > databases run slower than "pure" unit tests, but you can't be sure > that your app works without a bunch of integration tests. > > -- > Maur?cio Linhares > http://alinhavado.wordpress.com/ (pt-br) | > http://codeshooter.wordpress.com/ (en) > Jo?o Pessoa, PB, +55 83 8867-7208 > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > -- Kornelis Sietsma korny at my surname dot com kornys at gmail dot com on google chat -- kornys on skype "we do what we must, because we can" -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/rspec-users/attachments/20080228/dc4f1e14/attachment-0001.html From dchelimsky at gmail.com Thu Feb 28 02:28:31 2008 From: dchelimsky at gmail.com (David Chelimsky) Date: Thu, 28 Feb 2008 01:28:31 -0600 Subject: [rspec-users] bad specs better than none? In-Reply-To: <8e15872b0802272249r4edb1290q95f85b11b19b95d9@mail.gmail.com> References: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> <8d961d900802252159j2b83c7ads80bd89594880e77f@mail.gmail.com> <8e15872b0802272249r4edb1290q95f85b11b19b95d9@mail.gmail.com> Message-ID: <57c63afe0802272328r558f4249q32bf850fd0226a9f@mail.gmail.com> On Thu, Feb 28, 2008 at 12:49 AM, Korny Sietsma wrote: > Totally agree with this - I'm happy to work with specs that just define a > single bit of the system's behaviour (i.e. "unit tests") and specs that > define behaviour across several different parts of the system (i.e. > "integration tests") - but it drives me mad when they are all mixed in > together, rather than in different directory trees. > > Incidentally, is there a good naming scheme for this distinction in the BDD > world? I'm used to saying "unit tests", "integration tests", "acceptance > tests" (though the precise meaning of the last two seems to vary widely > between different organisations!) but I'm not sure what to call them in > rspec-land. "unit specs"? "stories" in story-runner? I've been using "Stories" and "Object Specs". David > > - Korny > > > > On Thu, Feb 28, 2008 at 3:01 PM, Maur?cio Linhares > wrote: > > > > On Tue, Feb 26, 2008 at 2:59 AM, aslak hellesoy > > wrote: > > > > I also had to go into specs on a project I'm not working on, and > found > > > > an unholy hive of database-accessing specs. It's disheartening. > > > > Basically, it's cargo cult development practices - using the "best > > > > practice" without actually understanding it. > > > > > > > > > > What "best practice" are you referring to? > > > > > > > I'm also interested in discovering what is this "best practice". > > > > I can't see any problem in specs running against a database, that's > > exactly what integration testing is about, shouldn't we do integration > > testing just because we're using BDD? I really don't think so. > > > > The big problem about specs running against a database is not knowing > > that it's integration testing and also that specs that access > > databases run slower than "pure" unit tests, but you can't be sure > > that your app works without a bunch of integration tests. > > > > -- > > Maur?cio Linhares > > http://alinhavado.wordpress.com/ (pt-br) | > > http://codeshooter.wordpress.com/ (en) > > Jo?o Pessoa, PB, +55 83 8867-7208 > > > > > > > > _______________________________________________ > > rspec-users mailing list > > rspec-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/rspec-users > > > > > > -- > Kornelis Sietsma korny at my surname dot com > kornys at gmail dot com on google chat -- kornys on skype > "we do what we must, because we can" > _______________________________________________ > rspec-users mailing list > rspec-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/rspec-users > From pergesu at gmail.com Thu Feb 28 02:57:10 2008 From: pergesu at gmail.com (Pat Maddox) Date: Wed, 27 Feb 2008 23:57:10 -0800 Subject: [rspec-users] bad specs better than none? In-Reply-To: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> References: <2d81dedb0802251818p59d1c727l1e121736daf07366@mail.gmail.com> Message-ID: <810a540e0802272357u7ec4440x32d1c9201531f86e@mail.gmail.com> On Mon, Feb 25, 2008 at 6:18 PM, Giles Bowkett