From drbrain at segment7.net  Wed Sep 30 15:41:31 2009
From: drbrain at segment7.net (Eric Hodel)
Date: Wed, 30 Sep 2009 12:41:31 -0700
Subject: [Tmail-talk] 6 tests fail using OS X 10.5's apple ruby
Message-ID: <3449FF04-692F-4D67-A5B5-17BC7AFFA790@segment7.net>

This doesn't look anything like the contributing page:

   http://tmail.rubyforge.org/contributing/index.html

I get lots of extra output about making and destroying directories and  
6 failures.  Is my ruby version too old?

$ ruby -v
ruby 1.8.6 (2008-08-11 patchlevel 287) [universal-darwin9.0]
$ svnversion
261
$ rake test
(in /Users/drbrain/Work/svn/tmail/trunk)
Loaded suite test
Started
..F..........................................rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
.rm -rf tmp
mkdir tmp
rm -rf tmp
...rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf _mh
mkdir _mh
rm -rf _mh
.rm -rf tmp
mkdir tmp
rm -rf tmp
......rm -rf tmp
mkdir tmp
rm -rf tmp
.....................................E 
.E 
........F 
...E 
...F 
........................................................................
Finished in 0.472688 seconds.

   1) Failure:
test_ATTRS(ContentDispositionHeaderTester)
     [./test/test_header.rb:839:in `_test_raw_iso2022jp'
      ./test/test_header.rb:771:in `test_ATTRS']:
<"attachment"> expected but was
<nil>.

   2) Error:
test_at_char_in_address(TestAddress):
TMail::SyntaxError: parse error on token "<"
     lib/tmail/parser.y:379:in `on_error'
     ./test/../lib/tmail/port.rb:339:in `_racc_yyparse_c'
     lib/tmail/parser.y:375:in `scan'
     lib/tmail/parser.y:375:in `parse_in'
     /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ 
ruby/1.8/racc/parser.rb:152:in `_racc_yyparse_c'
     /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ 
ruby/1.8/racc/parser.rb:152:in `__send__'
     /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ 
ruby/1.8/racc/parser.rb:152:in `yyparse'
     lib/tmail/parser.y:366:in `parse'
     lib/tmail/parser.y:344:in `parse'
     ./test/../lib/tmail/address.rb:84:in `parse'
     ./test/test_address.rb:90:in `validate_case__address'
     ./test/test_address.rb:1137:in `test_at_char_in_address'

   3) Error:
test_dot_in_address(TestAddress):
TMail::SyntaxError: parse error on token "<"
     lib/tmail/parser.y:379:in `on_error'
     lib/tmail/parser.y:379:in `_racc_yyparse_c'
     lib/tmail/parser.y:375:in `scan'
     lib/tmail/parser.y:375:in `parse_in'
     /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ 
ruby/1.8/racc/parser.rb:152:in `_racc_yyparse_c'
     /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ 
ruby/1.8/racc/parser.rb:152:in `__send__'
     /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ 
ruby/1.8/racc/parser.rb:152:in `yyparse'
     lib/tmail/parser.y:366:in `parse'
     lib/tmail/parser.y:344:in `parse'
     ./test/../lib/tmail/address.rb:84:in `parse'
     ./test/test_address.rb:90:in `validate_case__address'
     ./test/test_address.rb:1093:in `test_dot_in_address'

   4) Failure:
test_parse__mailtools(TestAddress)
     [./test/test_address.rb:91:in `validate_case__address'
      ./test/test_address.rb:691:in `test_parse__mailtools']:
"(foo at bar.com (foobar), ned at foo.com (nedfoo) )  
<kevin at goess.org>" (phrase)
.
<"(foo at bar.com (foobar), ned at foo.com (nedfoo) )"> expected but was
<nil>.

   5) Error:
test_parse__rawjp(TestAddress):
TMail::SyntaxError: parse error on token error
     lib/tmail/parser.y:379:in `on_error'
     lib/tmail/parser.y:379:in `_racc_yyparse_c'
     lib/tmail/parser.y:375:in `scan'
     lib/tmail/parser.y:375:in `parse_in'
     /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ 
ruby/1.8/racc/parser.rb:152:in `_racc_yyparse_c'
     /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ 
ruby/1.8/racc/parser.rb:152:in `__send__'
     /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ 
ruby/1.8/racc/parser.rb:152:in `yyparse'
     lib/tmail/parser.y:366:in `parse'
     lib/tmail/parser.y:344:in `parse'
     ./test/../lib/tmail/address.rb:84:in `parse'
     ./test/test_address.rb:90:in `validate_case__address'
     ./test/test_address.rb:243:in `_test_parse__euc'
     ./test/test_address.rb:233:in `test_parse__rawjp'

   6) Failure:
test_trailing_dot_in_name(TestAddress) [./test/test_address.rb:1211]:
<"Sandy M. <noreply at rubyforge.org>"> expected but was
<nil>.

210 tests, 4004 assertions, 3 failures, 3 errors


From drbrain at segment7.net  Wed Sep 30 22:11:10 2009
From: drbrain at segment7.net (Eric Hodel)
Date: Wed, 30 Sep 2009 19:11:10 -0700
Subject: [Tmail-talk] `rake test`,
	`rake setup` are broken (Was: 6 tests fail using OS X 10.5's apple
	ruby)
In-Reply-To: <3449FF04-692F-4D67-A5B5-17BC7AFFA790@segment7.net>
References: <3449FF04-692F-4D67-A5B5-17BC7AFFA790@segment7.net>
Message-ID: <B1D38C5F-E455-448A-824F-0ADAEC3BF672@segment7.net>

On Sep 30, 2009, at 12:41, Eric Hodel wrote:

>  6) Failure:
> test_trailing_dot_in_name(TestAddress) [./test/test_address.rb:1211]:
> <"Sandy M. <noreply at rubyforge.org>"> expected but was
> <nil>.

I started looking into this last test first and determined that there  
are two scanners, one written in ruby and one in C.  (Maybe one of  
them is out of date and I'm using the out-of-date one?)

Unfortunately it looks like the Rakefile is broken and `rake test`  
doesn't build extensions before starting.  From setup.rb:

   task :test do exec_test end

rake -T indicates that `rake setup` will build extensions, but it  
doesn't:

$ rake -T setup
(in /Users/drbrain/Work/svn/tmail/trunk)
rake setup  # Compiles ruby extentions
$ rake setup
(in /Users/drbrain/Work/svn/tmail/trunk)
make: *** No targets specified and no makefile found.  Stop.
rake aborted!
system("make") failed

(See full trace by running task with --trace)
$

I think, setup.rb should be replaced with Hoe + rake-compiler which  
are state-of-the-art.

Not only will it remove ~70KB of code:

$ wc work/script/* setup.rb
       26      44     374 work/script/make
       39      95     851 work/script/rdoc
     1616    3582   36900 work/script/setup
       30      74     635 work/script/test
     1482    3751   37073 setup.rb
     3193    7546   75833 total

(Nokogiri's Rakefile is about 6KB and does what all the above code does)

But I can also give you a toolset that will actually work like your  
contribution page says it should.