From bret at pettichord.com Mon Sep 18 20:51:45 2006 From: bret at pettichord.com (Bret Pettichord) Date: Mon, 18 Sep 2006 19:51:45 -0500 Subject: [Wtr-development] [Wtr-general] What happened to the enabled_popup method? In-Reply-To: <450F153A.7040403@tower-mt.com> References: <450F153A.7040403@tower-mt.com> Message-ID: <450F3F21.2040200@pettichord.com> David Schmidt wrote: > Charley Baker wrote: > >> Mark, >> >> It's still available, but in the watir/contrib directory. In order >> to use it, add >> require 'watir/contrib/enabled_popup' >> to your scripts. This is still a development version and so there will >> be some bumps along the way. Sorry about the confusion, I'll try to >> make sure changes are documented along the way to the next release. >> >> -Charley >> > As the author of the enabled_popup() method I'd like to argue that it > remain in the main Watir code. The enabled_popup call will give you the > window handle of ANY type of popup, so it is very useful when a page may > or may not open a popup window, and the user doesn't know whether that > window will be a modal dialog window or a Javascript or IE popup. > > The functionality is already in the ModalDialog#find_modal_from_window > method, so no code is being saved (in fact, my original ModalDialog > class used enabled_popup to determine if a popup window was showing). > > This function is of general use and won't cost much in terms of code > size, so why not let it remain? > > David > There are four criteria for including code in Watir Core. Here is how i currently assess enabled_popup. I am interested in other people's views on this. Unit Tests: FAIL There are no unit tests for this. Known Bugs or Limitations: PASS There are no known limitations or bugs. Generally Useful: UNCLEAR It is unclear to me that there is a generally applicable testing use case for using this method. (I realize that this code is useful to Watir. The question is whether it is useful to expose it to testers using Watir.) Reports from users would be helpful here. Intuitive API: UNCLEAR I'm concerned about an inconsistency in how we refer to dialogs in the Watir API. Are they popups? dialogs? I think we need some consistency. It also is unclear to me whether "enabled" is the clear term for this method. How about "active" or "current"? To some degree, this lack of consistency is a problem with Watir in general, rather than this specific code. Nonetheless Watir needs a clear naming standard for how we name dialog-accessing methods. Bret From bret at pettichord.com Mon Sep 18 20:51:45 2006 From: bret at pettichord.com (Bret Pettichord) Date: Mon, 18 Sep 2006 19:51:45 -0500 Subject: [Wtr-development] [Wtr-general] What happened to the enabled_popup method? In-Reply-To: <450F153A.7040403@tower-mt.com> References: <450F153A.7040403@tower-mt.com> Message-ID: <450F3F21.2040200@pettichord.com> David Schmidt wrote: > Charley Baker wrote: > >> Mark, >> >> It's still available, but in the watir/contrib directory. In order >> to use it, add >> require 'watir/contrib/enabled_popup' >> to your scripts. This is still a development version and so there will >> be some bumps along the way. Sorry about the confusion, I'll try to >> make sure changes are documented along the way to the next release. >> >> -Charley >> > As the author of the enabled_popup() method I'd like to argue that it > remain in the main Watir code. The enabled_popup call will give you the > window handle of ANY type of popup, so it is very useful when a page may > or may not open a popup window, and the user doesn't know whether that > window will be a modal dialog window or a Javascript or IE popup. > > The functionality is already in the ModalDialog#find_modal_from_window > method, so no code is being saved (in fact, my original ModalDialog > class used enabled_popup to determine if a popup window was showing). > > This function is of general use and won't cost much in terms of code > size, so why not let it remain? > > David > There are four criteria for including code in Watir Core. Here is how i currently assess enabled_popup. I am interested in other people's views on this. Unit Tests: FAIL There are no unit tests for this. Known Bugs or Limitations: PASS There are no known limitations or bugs. Generally Useful: UNCLEAR It is unclear to me that there is a generally applicable testing use case for using this method. (I realize that this code is useful to Watir. The question is whether it is useful to expose it to testers using Watir.) Reports from users would be helpful here. Intuitive API: UNCLEAR I'm concerned about an inconsistency in how we refer to dialogs in the Watir API. Are they popups? dialogs? I think we need some consistency. It also is unclear to me whether "enabled" is the clear term for this method. How about "active" or "current"? To some degree, this lack of consistency is a problem with Watir in general, rather than this specific code. Nonetheless Watir needs a clear naming standard for how we name dialog-accessing methods. Bret From bret at pettichord.com Mon Sep 18 20:51:45 2006 From: bret at pettichord.com (Bret Pettichord) Date: Mon, 18 Sep 2006 19:51:45 -0500 Subject: [Wtr-development] [Wtr-general] What happened to the enabled_popup method? In-Reply-To: <450F153A.7040403@tower-mt.com> References: <450F153A.7040403@tower-mt.com> Message-ID: <450F3F21.2040200@pettichord.com> David Schmidt wrote: > Charley Baker wrote: > >> Mark, >> >> It's still available, but in the watir/contrib directory. In order >> to use it, add >> require 'watir/contrib/enabled_popup' >> to your scripts. This is still a development version and so there will >> be some bumps along the way. Sorry about the confusion, I'll try to >> make sure changes are documented along the way to the next release. >> >> -Charley >> > As the author of the enabled_popup() method I'd like to argue that it > remain in the main Watir code. The enabled_popup call will give you the > window handle of ANY type of popup, so it is very useful when a page may > or may not open a popup window, and the user doesn't know whether that > window will be a modal dialog window or a Javascript or IE popup. > > The functionality is already in the ModalDialog#find_modal_from_window > method, so no code is being saved (in fact, my original ModalDialog > class used enabled_popup to determine if a popup window was showing). > > This function is of general use and won't cost much in terms of code > size, so why not let it remain? > > David > There are four criteria for including code in Watir Core. Here is how i currently assess enabled_popup. I am interested in other people's views on this. Unit Tests: FAIL There are no unit tests for this. Known Bugs or Limitations: PASS There are no known limitations or bugs. Generally Useful: UNCLEAR It is unclear to me that there is a generally applicable testing use case for using this method. (I realize that this code is useful to Watir. The question is whether it is useful to expose it to testers using Watir.) Reports from users would be helpful here. Intuitive API: UNCLEAR I'm concerned about an inconsistency in how we refer to dialogs in the Watir API. Are they popups? dialogs? I think we need some consistency. It also is unclear to me whether "enabled" is the clear term for this method. How about "active" or "current"? To some degree, this lack of consistency is a problem with Watir in general, rather than this specific code. Nonetheless Watir needs a clear naming standard for how we name dialog-accessing methods. Bret