From charley.baker at gmail.com Mon Sep 8 15:22:09 2008 From: charley.baker at gmail.com (Charley Baker) Date: Mon, 8 Sep 2008 12:22:09 -0700 Subject: [Wtr-development] Watir source code moving to github Message-ID: Hi all, Watir's source is currently on OpenQA in a Subversion repository. Git has been making headway in becoming the successor to Subversion as the preferred manner of distributed source code management. There are several reasons why Git is preferable particularly for an open source project, not the least of which will be the ability to fork Watir code easily and submit pull requests to us as owners for any new features you might develop. We're moving Watir's main site off of OpenQA, making this a good opportunity to take advantage of a new source code management system, we will be moving the source code over to Github shortly. For those of you who have worked on Watir as a committer, please take the opportunity to sign up for an account on Github , send me your username and email address so that you'll be added to the project when we transfer it over with all of your previous commits intact. If you haven't taken a look at Git, now is the time. There are several helpful guides on the github site, a great introduction to git if you're currently a subversion user, and various other podcasts and sites about git on the web. I'd highly recommend taking a look at them. The complete Watir committer list can be found here: http://www.ohloh.net/projects/watir/contributors Post any questions or concerns to the list(s). -- Charley Baker blog: http://charleybakersblog.blogspot.com/ Project Manager, Watir, http://wtr.rubyforge.org QA Architect, Gap Inc Direct -------------- next part -------------- An HTML attachment was scrubbed... URL: From paul.rogers at shaw.ca Mon Sep 8 15:29:08 2008 From: paul.rogers at shaw.ca (Paul Rogers) Date: Mon, 8 Sep 2008 13:29:08 -0600 Subject: [Wtr-development] Watir source code moving to github In-Reply-To: References: Message-ID: paulrogers is my username paul.rogers at shaw.ca is the mail I signed up under Paul On Mon, Sep 8, 2008 at 1:22 PM, Charley Baker wrote: > Hi all, > > Watir's source is currently on OpenQA in a Subversion repository. Git has > been making headway in becoming the successor to Subversion as the preferred > manner of distributed source code management. There are several reasons why > Git is preferable particularly for an open source project, not the least of > which will be the ability to fork Watir code easily and submit pull requests > to us as owners for any new features you might develop. We're moving Watir's > main site off of OpenQA, making this a good opportunity to take advantage of > a new source code management system, we will be moving the source code over > to Github shortly. > > For those of you who have worked on Watir as a committer, please take the > opportunity to sign up for an account on Github, send me your username and > email address so that you'll be added to the project when we transfer it > over with all of your previous commits intact. > > If you haven't taken a look at Git, now is the time. There are several > helpful guides on the github site, a great introduction to git if you're > currently a subversion user, and various other podcasts and sites about git > on the web. I'd highly recommend taking a look at them. > > The complete Watir committer list can be found here: > http://www.ohloh.net/projects/watir/contributors > > Post any questions or concerns to the list(s). > > -- > Charley Baker > blog: http://charleybakersblog.blogspot.com/ > Project Manager, Watir, http://wtr.rubyforge.org > QA Architect, Gap Inc Direct > > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > From bret at pettichord.com Mon Sep 8 15:58:59 2008 From: bret at pettichord.com (Bret Pettichord) Date: Mon, 8 Sep 2008 14:58:59 -0500 Subject: [Wtr-development] Watir source code moving to github In-Reply-To: References: Message-ID: On Mon, Sep 8, 2008 at 2:29 PM, Paul Rogers wrote: > paulrogers is my username > paul.rogers at shaw.ca is the mail I signed up under > I've started the name conversion list. http://wiki.openqa.org/display/WTR/Author+list+for+Git+Conversion Contributors can directly update this list after creating Github accounts. For those of you who have taken a look at the Ohloh contributor list, you should know that Angrez's contributions are actually greater than indicated there. I've committed much of his contributions, thereby giving me credit for his work on Ohloh. One of the advantages of Git is that it separates the notion of "author" and "committer", thereby allowing you to commit code and still give credit to the original author. Bret On Mon, Sep 8, 2008 at 1:22 PM, Charley Baker > wrote: > > Hi all, > > > > Watir's source is currently on OpenQA in a Subversion repository. Git > has > > been making headway in becoming the successor to Subversion as the > preferred > > manner of distributed source code management. There are several reasons > why > > Git is preferable particularly for an open source project, not the least > of > > which will be the ability to fork Watir code easily and submit pull > requests > > to us as owners for any new features you might develop. We're moving > Watir's > > main site off of OpenQA, making this a good opportunity to take advantage > of > > a new source code management system, we will be moving the source code > over > > to Github shortly. > > > > For those of you who have worked on Watir as a committer, please take > the > > opportunity to sign up for an account on Github, send me your username > and > > email address so that you'll be added to the project when we transfer it > > over with all of your previous commits intact. > > > > If you haven't taken a look at Git, now is the time. There are several > > helpful guides on the github site, a great introduction to git if you're > > currently a subversion user, and various other podcasts and sites about > git > > on the web. I'd highly recommend taking a look at them. > > > > The complete Watir committer list can be found here: > > http://www.ohloh.net/projects/watir/contributors > > > > Post any questions or concerns to the list(s). > > > > -- > > Charley Baker > > blog: http://charleybakersblog.blogspot.com/ > > Project Manager, Watir, http://wtr.rubyforge.org > > QA Architect, Gap Inc Direct > > > > _______________________________________________ > > Wtr-development mailing list > > Wtr-development at rubyforge.org > > http://rubyforge.org/mailman/listinfo/wtr-development > > > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > -- Bret Pettichord GTalk: bpettichord at gmail.com CTO, WatirCraft LLC, http://www.watircraft.com Lead Developer, Watir, http://wtr.rubyforge.org Blog (Essays), http://www.io.com/~wazmo/blog MiniBlog (Links), http://feeds.feedburner.com/bretshotlist -------------- next part -------------- An HTML attachment was scrubbed... URL: From bret at pettichord.com Fri Sep 12 10:29:29 2008 From: bret at pettichord.com (Bret Pettichord) Date: Fri, 12 Sep 2008 09:29:29 -0500 Subject: [Wtr-development] Git Message-ID: <48CA7CC9.9070100@pettichord.com> I've spent the better part of the past week looking at Git. Several people have been urging us to use it, instead of Subversion (SVN), to manage the Watir source code. At this point, I don't think we are ready to use it for Watir. I've strugged to get it working on Windows, and have only had success when using it on OSX. The people urging me to use apparently have also mostly used it on OSX/Linux. We need to have some one who can attest that it works well on Windows (and advise us on which versions to use) before I can urge the Watir community to migrate to it. My top priority right now is improving support and compatibility with Firefox, both on Windows and OSX/Linux, and I've been eager to consider using Git, because I think using it will encourage contributions from the Ruby development community (which mostly uses OSX/Linux). However, we also need to maintain support for developing Watir on Windows. Right now my primary Watir development environment is Windows XP running under Fusion on OSX 10.5. Specifically, I tried using Msysgit 1.5.6 and ran into errors with git-svn. I rolled back to Mysgit 1.5.5 and ran into horrible performance programs that made it unusable. A "git svn clone" that took 30 seconds on my Mac, took 20 minutes using Msysgit on Windows. Contriwise, I had no problems using the version of Git (1.5.5) that came installed with OSX. I do think that we will eventually move to Git. It has several clear advantages. But Git also represents a significant change from SVN. Many of you may remember moving from CVS to SVN. This was a pretty easy move, because the tools are very similar. 90% of their commands are the same and they have the same underlying model. Git is completely different. There is only about 10% overlap with SVN commands. It is more complex, and more powerful. I'm impressed by it. I think Git will make it easier for us to accept contributions from more people. But it will take some time for people to learn it and right now, I don't think it is possible right now to learn Git on Windows. I wasn't able to. I was only able to make progress when I switched to OSX. We need to wait until better versions of Git appear on Windows. Bret From bret at pettichord.com Thu Sep 18 18:16:20 2008 From: bret at pettichord.com (Bret Pettichord) Date: Thu, 18 Sep 2008 17:16:20 -0500 Subject: [Wtr-development] firewatir integration In-Reply-To: <7ac2300c0809181505q75f81628w13cf7bfa1890f880@mail.gmail.com> References: <219784.65354.qm@web31815.mail.mud.yahoo.com> <7ac2300c0809181437p20584bb2w5a056ec01758b29d@mail.gmail.com> <7ac2300c0809181505q75f81628w13cf7bfa1890f880@mail.gmail.com> Message-ID: On Thu, Sep 18, 2008 at 5:05 PM, aidy lewis wrote: > Bret, > > On 18/09/2008, Bret Pettichord wrote: > > Aidy, > > > > Thanks for these. We can use the multiple-attribute tests for Watir as > tests > > for these (they now can be run against Firewatir), so there is no need > for > > additional tests. > > > > Can you tell me what version of FireWatir these are based on? I need to > know > > this before I can review the code, or commit it. > > I have done an svn diff from the current trunk and the major > differences are at the bottom of htmlelements and MozillaBaseElements; > the remaining files are very minor diffs so I would imagine the latest > gem. We really need to know, not guess. Otherwise there is a very real possibility of regression. I can't accept this code without knowing this. > Did you run the existing unit tests? > > No, but I will do. Are the multiple attribute tests in the core tests? Yes. Please also run the existing firewatir tests. Bret -- Bret Pettichord GTalk: bpettichord at gmail.com CTO, WatirCraft LLC, http://www.watircraft.com Lead Developer, Watir, http://wtr.rubyforge.org Blog (Essays), http://www.io.com/~wazmo/blog MiniBlog (Links), http://feeds.feedburner.com/bretshotlist -------------- next part -------------- An HTML attachment was scrubbed... URL: From bret at pettichord.com Mon Sep 22 18:01:40 2008 From: bret at pettichord.com (Bret Pettichord) Date: Mon, 22 Sep 2008 17:01:40 -0500 Subject: [Wtr-development] Status Message-ID: I just checked in multiple attribute support in FireWatir, thanks to Aidy and Michael. Some things i had to do to get this to work. 1. Find out what code this was based on. People often send us code, which we could use except that we are also getting code from other people, and there is no way of merging submissions unless we know what you changed. This means we need to know when what revision your code is based on. In this case we found out it was based on Firewatir 1.2.1. Note that if you are developing code, you should really be working out of SVN (and trunk) and not editing code in a gem. 2. I created a working directory based on the firewatir 1.2.1 tag in SVN and dropped in the files they submitted. 3. I ran the unit tests (mozilla_all_tests) to see if there were any regression bugs. Every test failed. 4. The errors all seemed to be related to the repackaging that Micheal had done, putting all the classes in the firewatir module. So as much as i agreed with the sentiment, i backed out these changes. I also backed out lots of debug messages that were added. After doing this, i was able to get the unit tests to run correctly. 5. I created a patch file (and uploaded to the Jira ticket, 233, http://jira.openqa.org/browse/WTR-233). Subclipse crashed when trying to parse MozillaBaseElement, so i used Tortoisse. 6. Created a new working directory based on trunk. 7. Applied the patch. This was trickier than it should have been and i don't know why. Tortoisse could only apply the patch to MozillaBaseElement (the complex changes). It could apply the changes to htmlelements, which were simple, so i just applied them by hand. 8. Ran mozilla all tests in trunk. passed. 9. Committed. There are several new developers working on contributions to FireWatir. I'm worried about merges. Many of you are contacting me, but not each other, and i may not be able to resolve all conflicts. By rights, you should be developing from trunk and periodically updating so that you get the changes that other contributors are making. I am worried that this doesn't seem to be happening. Anyway, i know Sai is working on making FireWatir jRuby compatible. Sai, can you say a few words about the status of your work so that others know? I'm working on merging the test suites. So far i have tagging implemented as a feature for the watir unit tests and will start tagging tests as to whether they apply to watir or firewatir or both. I talked about a lot of this in the podcast on Friday, so make sure you listen to that when Zeljko publishes it. Bret -- Bret Pettichord GTalk: bpettichord at gmail.com CTO, WatirCraft LLC, http://www.watircraft.com Lead Developer, Watir, http://wtr.rubyforge.org Blog (Essays), http://www.io.com/~wazmo/blog MiniBlog (Links), http://feeds.feedburner.com/bretshotlist -------------- next part -------------- An HTML attachment was scrubbed... URL: From zeljko.filipin at gmail.com Tue Sep 23 00:09:30 2008 From: zeljko.filipin at gmail.com (=?UTF-8?Q?=C5=BDeljko_Filipin?=) Date: Tue, 23 Sep 2008 06:09:30 +0200 Subject: [Wtr-development] Status In-Reply-To: References: Message-ID: On Tue, Sep 23, 2008 at 12:01 AM, Bret Pettichord wrote: > I talked about a lot of this in the podcast on Friday, so make sure you listen to that when Zeljko publishes it. I woke up way too early this morning (5 am, guess I am getting older) and now I do not have to do anything but to edit the podcast. :) I hope I will finish it today. ?eljko -- posts I find interesting: feeds.feedburner.com/ZeljkoFilipinReader -------------- next part -------------- An HTML attachment was scrubbed... URL: From bret at pettichord.com Thu Sep 25 18:12:26 2008 From: bret at pettichord.com (Bret Pettichord) Date: Thu, 25 Sep 2008 17:12:26 -0500 Subject: [Wtr-development] Merging the unit test suites Message-ID: I started to formally merging the Watir and FireWatir test suites. So far it is only one test file (buttons_test.rb), but even doing this has forced to me to concretely define the structure of a shared test suite. BTW, I should mention that this approach: get one test to be shared and provide the minimum framework necessary for this goal is a key move in XP/Agile. In any case, I thought I would make a few comments about what we have today and where I plan to take this in the days ahead. These comments are particularly for the benefit of developers who are working out of trunk and curious as to which tests they should be running. First of all, what hasn't changed, and what won't change soon: the regression test suites are firewatir/unittests/mozilla_all_tests.rb and watir/unittests/core_tests.rb. These are what worked before and my intent is to keep them working. In addition, you should be able to run any of the tests, simply but running the file (e.g. from the command line or from your IDE). I recently had to add some code so that the tests would be able to continue to run as before with Eclipse. In this case, I added filtering, and I had to write some extra code (watir-common/unittests/setup/filter.rb) to make sure the filter worked with Eclipse's test-unit runner. If something like this is needed for other IDE's that you may be using (Netbeans?), let me know and we'll figure it out. As I merge tests and move them to watir-common, they will automatically be included in both of the regression test suites. This is why you'll have to check out all three projects (up one level in svn). The tests are automatically configured to be able to find each other if you check out directly under trunk. So there are three ways to run unit tests (watir/core_tests, mozilla_all_tests, running test files directly). The new options.yml file also controls how these tests run: namely whether they run against IE or Firefox. There is one both in watir and in watir-common (which will soon get its own core-tests, which will give us another way to run unit tests). That gives us five ways to run tests (the options.yml file does not affect mozilla-all-tests). Because of all the ways to run tests, I will invariably break one of these with out realizing it, so please let me know if things don't look right to you. I watch the #watir channel during the day, so that is a good place to raise issues or questions. I'm also on the verge of adding yet another way to run the tests. As I merge the Watir::IE and FireWatir tests, I am adding tests that only pass with one of the implementations. I am tagging these tests and the regression suites, right now, will not run tests that are tagged as failing with that browser. This is good for regression testing, but not so good for compatability testing. So I am adding yet another test option: in the options.yml file you will be able to specify "coverage: regression" or "coverage: compatibility" (or maybe "coverage: all"). Regression will be the default, but the other option will run all the tests, not only the ones that have passed before. Eventually, i hope to merge all the tests into a single suite, but it is important to keep everything working as work on this integration, so i thought it important to share some of the issues and plans with the current work. Please, as always, let me know if there are questions or concerns. Bret -- Bret Pettichord GTalk: bpettichord at gmail.com CTO, WatirCraft LLC, http://www.watircraft.com Lead Developer, Watir, http://wtr.rubyforge.org Blog (Essays), http://www.io.com/~wazmo/blog MiniBlog (Links), http://feeds.feedburner.com/bretshotlist -------------- next part -------------- An HTML attachment was scrubbed... URL: From charley.baker at gmail.com Mon Sep 8 15:22:09 2008 From: charley.baker at gmail.com (Charley Baker) Date: Mon, 8 Sep 2008 12:22:09 -0700 Subject: [Wtr-development] Watir source code moving to github Message-ID: Hi all, Watir's source is currently on OpenQA in a Subversion repository. Git has been making headway in becoming the successor to Subversion as the preferred manner of distributed source code management. There are several reasons why Git is preferable particularly for an open source project, not the least of which will be the ability to fork Watir code easily and submit pull requests to us as owners for any new features you might develop. We're moving Watir's main site off of OpenQA, making this a good opportunity to take advantage of a new source code management system, we will be moving the source code over to Github shortly. For those of you who have worked on Watir as a committer, please take the opportunity to sign up for an account on Github , send me your username and email address so that you'll be added to the project when we transfer it over with all of your previous commits intact. If you haven't taken a look at Git, now is the time. There are several helpful guides on the github site, a great introduction to git if you're currently a subversion user, and various other podcasts and sites about git on the web. I'd highly recommend taking a look at them. The complete Watir committer list can be found here: http://www.ohloh.net/projects/watir/contributors Post any questions or concerns to the list(s). -- Charley Baker blog: http://charleybakersblog.blogspot.com/ Project Manager, Watir, http://wtr.rubyforge.org QA Architect, Gap Inc Direct -------------- next part -------------- An HTML attachment was scrubbed... URL: From paul.rogers at shaw.ca Mon Sep 8 15:29:08 2008 From: paul.rogers at shaw.ca (Paul Rogers) Date: Mon, 8 Sep 2008 13:29:08 -0600 Subject: [Wtr-development] Watir source code moving to github In-Reply-To: References: Message-ID: paulrogers is my username paul.rogers at shaw.ca is the mail I signed up under Paul On Mon, Sep 8, 2008 at 1:22 PM, Charley Baker wrote: > Hi all, > > Watir's source is currently on OpenQA in a Subversion repository. Git has > been making headway in becoming the successor to Subversion as the preferred > manner of distributed source code management. There are several reasons why > Git is preferable particularly for an open source project, not the least of > which will be the ability to fork Watir code easily and submit pull requests > to us as owners for any new features you might develop. We're moving Watir's > main site off of OpenQA, making this a good opportunity to take advantage of > a new source code management system, we will be moving the source code over > to Github shortly. > > For those of you who have worked on Watir as a committer, please take the > opportunity to sign up for an account on Github, send me your username and > email address so that you'll be added to the project when we transfer it > over with all of your previous commits intact. > > If you haven't taken a look at Git, now is the time. There are several > helpful guides on the github site, a great introduction to git if you're > currently a subversion user, and various other podcasts and sites about git > on the web. I'd highly recommend taking a look at them. > > The complete Watir committer list can be found here: > http://www.ohloh.net/projects/watir/contributors > > Post any questions or concerns to the list(s). > > -- > Charley Baker > blog: http://charleybakersblog.blogspot.com/ > Project Manager, Watir, http://wtr.rubyforge.org > QA Architect, Gap Inc Direct > > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > From bret at pettichord.com Mon Sep 8 15:58:59 2008 From: bret at pettichord.com (Bret Pettichord) Date: Mon, 8 Sep 2008 14:58:59 -0500 Subject: [Wtr-development] Watir source code moving to github In-Reply-To: References: Message-ID: On Mon, Sep 8, 2008 at 2:29 PM, Paul Rogers wrote: > paulrogers is my username > paul.rogers at shaw.ca is the mail I signed up under > I've started the name conversion list. http://wiki.openqa.org/display/WTR/Author+list+for+Git+Conversion Contributors can directly update this list after creating Github accounts. For those of you who have taken a look at the Ohloh contributor list, you should know that Angrez's contributions are actually greater than indicated there. I've committed much of his contributions, thereby giving me credit for his work on Ohloh. One of the advantages of Git is that it separates the notion of "author" and "committer", thereby allowing you to commit code and still give credit to the original author. Bret On Mon, Sep 8, 2008 at 1:22 PM, Charley Baker > wrote: > > Hi all, > > > > Watir's source is currently on OpenQA in a Subversion repository. Git > has > > been making headway in becoming the successor to Subversion as the > preferred > > manner of distributed source code management. There are several reasons > why > > Git is preferable particularly for an open source project, not the least > of > > which will be the ability to fork Watir code easily and submit pull > requests > > to us as owners for any new features you might develop. We're moving > Watir's > > main site off of OpenQA, making this a good opportunity to take advantage > of > > a new source code management system, we will be moving the source code > over > > to Github shortly. > > > > For those of you who have worked on Watir as a committer, please take > the > > opportunity to sign up for an account on Github, send me your username > and > > email address so that you'll be added to the project when we transfer it > > over with all of your previous commits intact. > > > > If you haven't taken a look at Git, now is the time. There are several > > helpful guides on the github site, a great introduction to git if you're > > currently a subversion user, and various other podcasts and sites about > git > > on the web. I'd highly recommend taking a look at them. > > > > The complete Watir committer list can be found here: > > http://www.ohloh.net/projects/watir/contributors > > > > Post any questions or concerns to the list(s). > > > > -- > > Charley Baker > > blog: http://charleybakersblog.blogspot.com/ > > Project Manager, Watir, http://wtr.rubyforge.org > > QA Architect, Gap Inc Direct > > > > _______________________________________________ > > Wtr-development mailing list > > Wtr-development at rubyforge.org > > http://rubyforge.org/mailman/listinfo/wtr-development > > > _______________________________________________ > Wtr-development mailing list > Wtr-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development > -- Bret Pettichord GTalk: bpettichord at gmail.com CTO, WatirCraft LLC, http://www.watircraft.com Lead Developer, Watir, http://wtr.rubyforge.org Blog (Essays), http://www.io.com/~wazmo/blog MiniBlog (Links), http://feeds.feedburner.com/bretshotlist -------------- next part -------------- An HTML attachment was scrubbed... URL: From bret at pettichord.com Fri Sep 12 10:29:29 2008 From: bret at pettichord.com (Bret Pettichord) Date: Fri, 12 Sep 2008 09:29:29 -0500 Subject: [Wtr-development] Git Message-ID: <48CA7CC9.9070100@pettichord.com> I've spent the better part of the past week looking at Git. Several people have been urging us to use it, instead of Subversion (SVN), to manage the Watir source code. At this point, I don't think we are ready to use it for Watir. I've strugged to get it working on Windows, and have only had success when using it on OSX. The people urging me to use apparently have also mostly used it on OSX/Linux. We need to have some one who can attest that it works well on Windows (and advise us on which versions to use) before I can urge the Watir community to migrate to it. My top priority right now is improving support and compatibility with Firefox, both on Windows and OSX/Linux, and I've been eager to consider using Git, because I think using it will encourage contributions from the Ruby development community (which mostly uses OSX/Linux). However, we also need to maintain support for developing Watir on Windows. Right now my primary Watir development environment is Windows XP running under Fusion on OSX 10.5. Specifically, I tried using Msysgit 1.5.6 and ran into errors with git-svn. I rolled back to Mysgit 1.5.5 and ran into horrible performance programs that made it unusable. A "git svn clone" that took 30 seconds on my Mac, took 20 minutes using Msysgit on Windows. Contriwise, I had no problems using the version of Git (1.5.5) that came installed with OSX. I do think that we will eventually move to Git. It has several clear advantages. But Git also represents a significant change from SVN. Many of you may remember moving from CVS to SVN. This was a pretty easy move, because the tools are very similar. 90% of their commands are the same and they have the same underlying model. Git is completely different. There is only about 10% overlap with SVN commands. It is more complex, and more powerful. I'm impressed by it. I think Git will make it easier for us to accept contributions from more people. But it will take some time for people to learn it and right now, I don't think it is possible right now to learn Git on Windows. I wasn't able to. I was only able to make progress when I switched to OSX. We need to wait until better versions of Git appear on Windows. Bret From bret at pettichord.com Thu Sep 18 18:16:20 2008 From: bret at pettichord.com (Bret Pettichord) Date: Thu, 18 Sep 2008 17:16:20 -0500 Subject: [Wtr-development] firewatir integration In-Reply-To: <7ac2300c0809181505q75f81628w13cf7bfa1890f880@mail.gmail.com> References: <219784.65354.qm@web31815.mail.mud.yahoo.com> <7ac2300c0809181437p20584bb2w5a056ec01758b29d@mail.gmail.com> <7ac2300c0809181505q75f81628w13cf7bfa1890f880@mail.gmail.com> Message-ID: On Thu, Sep 18, 2008 at 5:05 PM, aidy lewis wrote: > Bret, > > On 18/09/2008, Bret Pettichord wrote: > > Aidy, > > > > Thanks for these. We can use the multiple-attribute tests for Watir as > tests > > for these (they now can be run against Firewatir), so there is no need > for > > additional tests. > > > > Can you tell me what version of FireWatir these are based on? I need to > know > > this before I can review the code, or commit it. > > I have done an svn diff from the current trunk and the major > differences are at the bottom of htmlelements and MozillaBaseElements; > the remaining files are very minor diffs so I would imagine the latest > gem. We really need to know, not guess. Otherwise there is a very real possibility of regression. I can't accept this code without knowing this. > Did you run the existing unit tests? > > No, but I will do. Are the multiple attribute tests in the core tests? Yes. Please also run the existing firewatir tests. Bret -- Bret Pettichord GTalk: bpettichord at gmail.com CTO, WatirCraft LLC, http://www.watircraft.com Lead Developer, Watir, http://wtr.rubyforge.org Blog (Essays), http://www.io.com/~wazmo/blog MiniBlog (Links), http://feeds.feedburner.com/bretshotlist -------------- next part -------------- An HTML attachment was scrubbed... URL: From bret at pettichord.com Mon Sep 22 18:01:40 2008 From: bret at pettichord.com (Bret Pettichord) Date: Mon, 22 Sep 2008 17:01:40 -0500 Subject: [Wtr-development] Status Message-ID: I just checked in multiple attribute support in FireWatir, thanks to Aidy and Michael. Some things i had to do to get this to work. 1. Find out what code this was based on. People often send us code, which we could use except that we are also getting code from other people, and there is no way of merging submissions unless we know what you changed. This means we need to know when what revision your code is based on. In this case we found out it was based on Firewatir 1.2.1. Note that if you are developing code, you should really be working out of SVN (and trunk) and not editing code in a gem. 2. I created a working directory based on the firewatir 1.2.1 tag in SVN and dropped in the files they submitted. 3. I ran the unit tests (mozilla_all_tests) to see if there were any regression bugs. Every test failed. 4. The errors all seemed to be related to the repackaging that Micheal had done, putting all the classes in the firewatir module. So as much as i agreed with the sentiment, i backed out these changes. I also backed out lots of debug messages that were added. After doing this, i was able to get the unit tests to run correctly. 5. I created a patch file (and uploaded to the Jira ticket, 233, http://jira.openqa.org/browse/WTR-233). Subclipse crashed when trying to parse MozillaBaseElement, so i used Tortoisse. 6. Created a new working directory based on trunk. 7. Applied the patch. This was trickier than it should have been and i don't know why. Tortoisse could only apply the patch to MozillaBaseElement (the complex changes). It could apply the changes to htmlelements, which were simple, so i just applied them by hand. 8. Ran mozilla all tests in trunk. passed. 9. Committed. There are several new developers working on contributions to FireWatir. I'm worried about merges. Many of you are contacting me, but not each other, and i may not be able to resolve all conflicts. By rights, you should be developing from trunk and periodically updating so that you get the changes that other contributors are making. I am worried that this doesn't seem to be happening. Anyway, i know Sai is working on making FireWatir jRuby compatible. Sai, can you say a few words about the status of your work so that others know? I'm working on merging the test suites. So far i have tagging implemented as a feature for the watir unit tests and will start tagging tests as to whether they apply to watir or firewatir or both. I talked about a lot of this in the podcast on Friday, so make sure you listen to that when Zeljko publishes it. Bret -- Bret Pettichord GTalk: bpettichord at gmail.com CTO, WatirCraft LLC, http://www.watircraft.com Lead Developer, Watir, http://wtr.rubyforge.org Blog (Essays), http://www.io.com/~wazmo/blog MiniBlog (Links), http://feeds.feedburner.com/bretshotlist -------------- next part -------------- An HTML attachment was scrubbed... URL: From zeljko.filipin at gmail.com Tue Sep 23 00:09:30 2008 From: zeljko.filipin at gmail.com (=?UTF-8?Q?=C5=BDeljko_Filipin?=) Date: Tue, 23 Sep 2008 06:09:30 +0200 Subject: [Wtr-development] Status In-Reply-To: References: Message-ID: On Tue, Sep 23, 2008 at 12:01 AM, Bret Pettichord wrote: > I talked about a lot of this in the podcast on Friday, so make sure you listen to that when Zeljko publishes it. I woke up way too early this morning (5 am, guess I am getting older) and now I do not have to do anything but to edit the podcast. :) I hope I will finish it today. ?eljko -- posts I find interesting: feeds.feedburner.com/ZeljkoFilipinReader -------------- next part -------------- An HTML attachment was scrubbed... URL: From bret at pettichord.com Thu Sep 25 18:12:26 2008 From: bret at pettichord.com (Bret Pettichord) Date: Thu, 25 Sep 2008 17:12:26 -0500 Subject: [Wtr-development] Merging the unit test suites Message-ID: I started to formally merging the Watir and FireWatir test suites. So far it is only one test file (buttons_test.rb), but even doing this has forced to me to concretely define the structure of a shared test suite. BTW, I should mention that this approach: get one test to be shared and provide the minimum framework necessary for this goal is a key move in XP/Agile. In any case, I thought I would make a few comments about what we have today and where I plan to take this in the days ahead. These comments are particularly for the benefit of developers who are working out of trunk and curious as to which tests they should be running. First of all, what hasn't changed, and what won't change soon: the regression test suites are firewatir/unittests/mozilla_all_tests.rb and watir/unittests/core_tests.rb. These are what worked before and my intent is to keep them working. In addition, you should be able to run any of the tests, simply but running the file (e.g. from the command line or from your IDE). I recently had to add some code so that the tests would be able to continue to run as before with Eclipse. In this case, I added filtering, and I had to write some extra code (watir-common/unittests/setup/filter.rb) to make sure the filter worked with Eclipse's test-unit runner. If something like this is needed for other IDE's that you may be using (Netbeans?), let me know and we'll figure it out. As I merge tests and move them to watir-common, they will automatically be included in both of the regression test suites. This is why you'll have to check out all three projects (up one level in svn). The tests are automatically configured to be able to find each other if you check out directly under trunk. So there are three ways to run unit tests (watir/core_tests, mozilla_all_tests, running test files directly). The new options.yml file also controls how these tests run: namely whether they run against IE or Firefox. There is one both in watir and in watir-common (which will soon get its own core-tests, which will give us another way to run unit tests). That gives us five ways to run tests (the options.yml file does not affect mozilla-all-tests). Because of all the ways to run tests, I will invariably break one of these with out realizing it, so please let me know if things don't look right to you. I watch the #watir channel during the day, so that is a good place to raise issues or questions. I'm also on the verge of adding yet another way to run the tests. As I merge the Watir::IE and FireWatir tests, I am adding tests that only pass with one of the implementations. I am tagging these tests and the regression suites, right now, will not run tests that are tagged as failing with that browser. This is good for regression testing, but not so good for compatability testing. So I am adding yet another test option: in the options.yml file you will be able to specify "coverage: regression" or "coverage: compatibility" (or maybe "coverage: all"). Regression will be the default, but the other option will run all the tests, not only the ones that have passed before. Eventually, i hope to merge all the tests into a single suite, but it is important to keep everything working as work on this integration, so i thought it important to share some of the issues and plans with the current work. Please, as always, let me know if there are questions or concerns. Bret -- Bret Pettichord GTalk: bpettichord at gmail.com CTO, WatirCraft LLC, http://www.watircraft.com Lead Developer, Watir, http://wtr.rubyforge.org Blog (Essays), http://www.io.com/~wazmo/blog MiniBlog (Links), http://feeds.feedburner.com/bretshotlist -------------- next part -------------- An HTML attachment was scrubbed... URL: